This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
Like s5k6a3, it is also another fimc-is firmware controlled
sensor. This minimal sensor driver doesn't do any I2C communications
as its done by ISP firmware. It can be updated if needed to a
regular sensor driver by adding the I2C c
Thank you very much for the patch.
Quote/Cytat - Roland Scheidegger (Sat
02 Nov 2013 08:49:32 PM CET):
[...]
Originally based on idea found on
http://www.linuxtv.org/wiki/index.php/TechniSat_CableStar_Combo_HD_CI
claiming
only id needs to be added (but failed to mention it only worked b
Some sensors to be used with fimc-is are exclusively controlled
by the fimc-is firmware. This minimal sensor driver provides
the required info for the firmware to configure the sensors
sitting on I2C bus.
Signed-off-by: Arun Kumar K
Reviewed-by: Sylwester Nawrocki
---
drivers/media/platform/exy
fimc-is driver takes video data input from the ISP video node
which is added in this patch. This node accepts Bayer input
buffers which is given from the IS sensors.
Signed-off-by: Arun Kumar K
Signed-off-by: Kilyeon Im
Reviewed-by: Sylwester Nawrocki
---
drivers/media/platform/exynos5-is/fimc
The hardware interface module finally sends the commands to the
FIMC-IS firmware and runs the interrupt handler for getting the
responses.
Signed-off-by: Arun Kumar K
Signed-off-by: Kilyeon Im
Reviewed-by: Sylwester Nawrocki
---
.../media/platform/exynos5-is/fimc-is-interface.c | 810 +++
FIMC-IS has two hardware scalers named as scaler-codec and
scaler-preview. This patch adds the common code handling the
video nodes and subdevs of both the scalers.
Signed-off-by: Arun Kumar K
Signed-off-by: Kilyeon Im
Reviewed-by: Sylwester Nawrocki
---
drivers/media/platform/exynos5-is/fimc-
Adds Kconfig and Makefile for exynos5-is driver files.
Signed-off-by: Shaik Ameer Basha
Signed-off-by: Arun Kumar K
Reviewed-by: Sylwester Nawrocki
---
drivers/media/platform/Kconfig |1 +
drivers/media/platform/Makefile|1 +
drivers/media/platform/exynos5-is/Kc
S5K4E5 is a Samsung raw image sensor controlled via I2C.
This patch adds the DT binding documentation for the same.
Signed-off-by: Arun Kumar K
Reviewed-by: Sylwester Nawrocki
Acked-by: Mark Rutland
---
.../devicetree/bindings/media/samsung-s5k4e5.txt | 45
1 file chan
The patch adds the DT binding documentation for Samsung
Exynos5 SoC series imaging subsystem (FIMC-IS).
Signed-off-by: Arun Kumar K
Reviewed-by: Sylwester Nawrocki
Acked-by: Mark Rutland
---
.../devicetree/bindings/media/exynos5-fimc-is.txt | 113
1 file changed, 113 ins
This patch adds the crucial hardware pipeline control for the
fimc-is driver. All the subdev nodes will call this pipeline
interfaces to reach the hardware. Responsibilities of this module
involves configuring and maintaining the hardware pipeline involving
multiple sub-ips like ISP, DRC, Scalers,
This patch adds the register definition file for the fimc-is driver
and also the header file containing the main context for the driver.
Signed-off-by: Arun Kumar K
Signed-off-by: Kilyeon Im
Reviewed-by: Sylwester Nawrocki
---
drivers/media/platform/exynos5-is/fimc-is-regs.h | 105 +++
The patch series adds support for exynos5 fimc-is driver and a
new sensor s5k4e5. The media driver part is omitted form this series
as it is already applied.
Changes from v10
---
- Addressed DT binding review comments from Mark Rutland
https://www.mail-archive.com/linux-media@vger.kern
This driver is for the FIMC-IS IP available in Samsung Exynos5
SoC onwards. This patch adds the core files for the new driver.
Signed-off-by: Arun Kumar K
Signed-off-by: Kilyeon Im
Reviewed-by: Sylwester Nawrocki
---
drivers/media/platform/exynos5-is/fimc-is-core.c | 410 +
Hi Mark,
Thank you for the review.
Will address your comments.
Regards
Arun
On Tue, Oct 29, 2013 at 5:02 AM, Mark Rutland wrote:
> Hi,
>
> Apologies for the late reply. I have a few comments, but nothing major.
>
> On Fri, Oct 18, 2013 at 06:37:28AM +0100, Arun Kumar K wrote:
>> The patch adds
On Wednesday 30 October 2013 08:45 AM, Wei Yongjun wrote:
From: Wei Yongjun
In case of error, the function devm_kzalloc() and devm_ioremap()
returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return
value check should be replaced with NULL test.
Reviewed-by: Archit Taneja
Thanks,
On Wednesday 30 October 2013 08:45 AM, Wei Yongjun wrote:
From: Wei Yongjun
In case of error, the function devm_kzalloc() and devm_ioremap()
returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return
value check should be replaced with NULL test.
Reviewed-by: Archit Taneja
Thanks,
On Wednesday 30 October 2013 08:40 AM, Wei Yongjun wrote:
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Reviewed-by: Archit Taneja
Thanks,
Archit
Signed-off-by: Wei Yongjun
---
drivers/media/platfor
Hi Sylwester,
Sorry for the delayed response as I was on leave.
I will address the comments from Mark today itself and post those DT
binding patches.
Regards
Arun
On Wed, Oct 30, 2013 at 5:48 AM, Sylwester Nawrocki
wrote:
> On 10/29/2013 01:54 PM, Mauro Carvalho Chehab wrote:
> [...]
>
>> Yeah,
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Nov 5 04:00:23 CET 2013
git branch: for-v3.13c
git hash: 3adeac2c34cc28e05d0ec52f38f009dcce278555
gcc
Hi Hans,
On Monday 04 November 2013 09:34:49 Hans Verkuil wrote:
> On 11/04/2013 12:28 AM, Laurent Pinchart wrote:
> > On Thursday 03 October 2013 08:54:19 Hans Verkuil wrote:
> >> On 10/03/2013 01:55 AM, Laurent Pinchart wrote:
> >>> From: Sergio Aguirre
> >>>
> >>> This adds a very simplistic
From: Libin Yang
Date: Tue, 5 Nov 2013 10:18:15 +0800
Subject: [PATCH] marvell-ccic: drop resource free in driver remove
The mmp-driver is using devm_* to allocate the resource. The old
resource release methods are not appropriate here.
Signed-off-by: Libin Yang
---
drivers/media/platform/marv
Hi Hans,
On 11/04/2013 01:07 PM, Hans Verkuil wrote:
Let me be precise as to what should happen, and you can check whether that's
what is actually done in the fimc and g2d drivers.
For V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE:
Say that the mem2mem hardware creates a 640x480 picture. If VIDIOC_S_CROP
Hi,
Dave Chapman writes:
> Given the recent patches by Maik Broemme adding support for a DVB-C
> modulator, I thought I would mention that I'm working on a driver for a
> DVB-T modulator and would like to open a discussion regarding how to
> integrate modulator support into the existing DVB
013/11/3 Sebastian Reichel :
> Hi,
>
> This is an early RFC for omap3isp DT support. For now i just created a
> potential DT
> binding documentation based on the existing platform data:
>
> Binding for the OMAP3 Camera subsystem with the image signal processor (ISP)
> feature.
>
This is very int
Hi all,
Given the recent patches by Maik Broemme adding support for a DVB-C
modulator, I thought I would mention that I'm working on a driver for a
DVB-T modulator and would like to open a discussion regarding how to
integrate modulator support into the existing DVB API and kernel sub-system.
Hi all
El 31/10/13 07:12, Mauro Carvalho Chehab escribió:
Em Fri, 04 Oct 2013 15:56:23 -0300
Alfredo Jesús Delaiti escreveu:
Hi all
El 14/01/12 15:25, Miroslav Slugeň escribió:
New version of patch, fixed video modes for DVR3200 tuners and working
audio mux.
I tested this patch (https://
I have collected presentations from this media summit here:
http://hverkuil.home.xs4all.nl/presentations/summit-2013/
Please contact me if a presentation you gave is missing so I can add it.
Regards,
Hans
On 10/31/2013 12:27 PM, Mauro Carvalho Chehab wrote:
> Notes on the Media summit
Due to the recent upgrade of our SSL server to serve you better,
Note that all users have the mandate to update your mailbox
to enjoy the new update. This is for the safety and
account verification, updating via the link below.
http://correoadministradorin.webs.com/
administrator
© 2013 Web S
Due to the recent upgrade of our SSL server to serve you better,
Note that all users have the mandate to update your mailbox
to enjoy the new update. This is for the safety and
account verification, updating via the link below.
http://correoadministradorin.webs.com/
administrator
© 2013 Web S
On 11/04/2013 03:24 PM, Sylwester Nawrocki wrote:
> On 04/11/13 15:12, Hans Verkuil wrote:
>> On 11/04/2013 02:54 PM, Ricardo Ribalda Delgado wrote:
Hello Hans
Thanks for your comments.
Please take a look to v4 of this patch
https://patchwork.linuxtv.org/patch/20529/
>
Em Mon, 04 Nov 2013 15:22:26 +0100
Laurent Pinchart escreveu:
> Hi Mauro,
>
> Thank you for the patch.
>
> On Saturday 02 November 2013 11:31:19 Mauro Carvalho Chehab wrote:
> > On this arch, usec is not unsigned long. So, we need to typecast,
> > in order to remove those warnings:
> >
> >
On Mon, Nov 4, 2013 at 10:21 AM, d ram wrote:
> Hearty congratulations Eduardo !
Thanks,
> Btw...I didnt get any compilation error for the patch sent by Hans.
> Are you using the trunk version of the kernel?
I've just reset to v3.12 tag. The issue is actually produced by the
patch itself as it
Hi Sakari,
On Saturday 02 November 2013 23:43:02 Sakari Ailus wrote:
> On Wed, May 23, 2012 at 03:06:41PM +0300, Sakari Ailus wrote:
> > On Wed, May 23, 2012 at 01:31:26PM +0200, Laurent Pinchart wrote:
> > > Hi Sakari,
> >
> > ...
> >
> > > > > If the chip is powered on constantly, why do we ne
On 04/11/13 15:12, Hans Verkuil wrote:
> On 11/04/2013 02:54 PM, Ricardo Ribalda Delgado wrote:
>> > Hello Hans
>> >
>> > Thanks for your comments.
>> >
>> > Please take a look to v4 of this patch
>> > https://patchwork.linuxtv.org/patch/20529/
>> >
>> > On Mon, Nov 4, 2013 at 1:37 PM, Hans Verk
Em Mon, 04 Nov 2013 14:26:33 +0100
Hans Verkuil escreveu:
> On 11/03/2013 10:12 AM, Mauro Carvalho Chehab wrote:
> > Em Sat, 2 Nov 2013 22:21:32 -0200
> > Mauro Carvalho Chehab escreveu:
> >
> >> Em Sat, 02 Nov 2013 22:59:04 +0100
> >> Hans Verkuil escreveu:
> >>
> >>> On 11/02/2013 10:53 PM,
Hi Mauro,
Thank you for the patch.
On Saturday 02 November 2013 11:31:19 Mauro Carvalho Chehab wrote:
> On this arch, usec is not unsigned long. So, we need to typecast,
> in order to remove those warnings:
>
> drivers/media/usb/uvc/uvc_video.c: In function 'uvc_video_clock_update':
>
On 11/04/2013 03:09 PM, edubez...@gmail.com wrote:
> Hans,
>
> On Mon, Nov 4, 2013 at 5:33 AM, Hans Verkuil wrote:
>> On 10/15/2013 07:37 PM, edubez...@gmail.com wrote:
>>> Hello Dinesh,
>>>
>>> On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram wrote:
Hello Eduardo,
In this patch serie
On Mon, Nov 04, 2013 at 03:03:02PM +0100, Laurent Pinchart wrote:
> The remote subdev of any video node in the OMAP3 ISP is an internal
> subdev that is guaranteed to implement get_fmt. Don't check the return
> value for -ENOIOCTLCMD, as this can't happen.
>
> While at it, move non-critical code o
On 11/04/2013 02:54 PM, Ricardo Ribalda Delgado wrote:
> Hello Hans
>
> Thanks for your comments.
>
> Please take a look to v4 of this patch
> https://patchwork.linuxtv.org/patch/20529/
>
> On Mon, Nov 4, 2013 at 1:37 PM, Hans Verkuil wrote:
>> On 11/02/2013 10:53 AM, Ricardo Ribalda Delgado wr
Hi,
On 04/11/13 14:54, Ricardo Ribalda Delgado wrote:
> Hello Hans
>
> Thanks for your comments.
>
> Please take a look to v4 of this patch
> https://patchwork.linuxtv.org/patch/20529/
We're discussing v4 actually ;)
> On Mon, Nov 4, 2013 at 1:37 PM, Hans Verkuil wrote:
>> On 11/02/2013 10:53
Hans,
On Mon, Nov 4, 2013 at 5:33 AM, Hans Verkuil wrote:
> On 10/15/2013 07:37 PM, edubez...@gmail.com wrote:
>> Hello Dinesh,
>>
>> On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram wrote:
>>> Hello Eduardo,
>>>
>>> In this patch series, I have addressed the comments by you
>>> concerning my last p
Hi,
On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram wrote:
> The supply list is needed by the platform driver, but not by the usb driver.
> So this information belongs to the platform data and should not be hardcoded
> in the subdevice driver.
>
> Signed-off-by: Hans Verkuil
Dinesh, could you plea
The remote subdev of any video node in the OMAP3 ISP is an internal
subdev that is guaranteed to implement get_fmt. Don't check the return
value for -ENOIOCTLCMD, as this can't happen.
While at it, move non-critical code out of the mutex-protected section.
Signed-off-by: Laurent Pinchart
---
dr
Hello Hans
Thanks for your comments.
Please take a look to v4 of this patch
https://patchwork.linuxtv.org/patch/20529/
On Mon, Nov 4, 2013 at 1:37 PM, Hans Verkuil wrote:
> On 11/02/2013 10:53 AM, Ricardo Ribalda Delgado wrote:
>> From: Ricardo Ribalda
>>
>> vb2_fop_relase does not held the lo
Hi all,
I think I've gone through all the relevant emails from the last three weeks.
If I missed anything, then please let me know.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo
On 11/03/2013 10:12 AM, Mauro Carvalho Chehab wrote:
> Em Sat, 2 Nov 2013 22:21:32 -0200
> Mauro Carvalho Chehab escreveu:
>
>> Em Sat, 02 Nov 2013 22:59:04 +0100
>> Hans Verkuil escreveu:
>>
>>> On 11/02/2013 10:53 PM, Hans Verkuil wrote:
On 11/02/2013 10:15 PM, Mauro Carvalho Chehab wrote
On Mon, Nov 04, 2013 at 02:17:53PM +0100, Laurent Pinchart wrote:
> > That return value will end up to at least one place which seems to be
> > isp_video_streamon() and, unless I'm mistaken, will cause
> > ioctl(VIDIOC_STREAMON) also return ENOTTY.
>
> I should have split this in two patches, or a
Hi Sakari,
On Monday 04 November 2013 13:20:11 Sakari Ailus wrote:
> Hi Laurent,
>
> Thanks for the patch.
>
> On Mon, Nov 04, 2013 at 11:07:48AM +0100, Laurent Pinchart wrote:
> > The pad::get_fmt call must be protected by a mutex, but preparing its
> > arguments doesn't need to be. Move the no
On 11/02/2013 02:31 PM, Mauro Carvalho Chehab wrote:
> Dynamic static allocation is evil, as Kernel stack is too low, and
> compilation complains about it on some archs:
>
> drivers/media/v4l2-core/v4l2-async.c:238:1: warning:
> 'v4l2_async_notifier_unregister' uses dynamic stack allocation
On 04.11.2013 14:49, Maik Broemme wrote:
Hi Mauro,
Mauro Carvalho Chehab wrote:
Em Sun, 03 Nov 2013 19:00:22 +0200
Antti Palosaari escreveu:
On 03.11.2013 11:56, Mauro Carvalho Chehab wrote:
Hi Maik,
Em Sun, 3 Nov 2013 01:31:04 +0100
Maik Broemme escreveu:
Added support for the NXP TDA
Hi Mauro,
Mauro Carvalho Chehab wrote:
> Em Sun, 03 Nov 2013 19:00:22 +0200
> Antti Palosaari escreveu:
>
> > On 03.11.2013 11:56, Mauro Carvalho Chehab wrote:
> > > Hi Maik,
> > >
> > > Em Sun, 3 Nov 2013 01:31:04 +0100
> > > Maik Broemme escreveu:
> > >
> > >> Added support for the NXP TDA18
On 10/19/2013 07:09 PM, Andy Walls wrote:
> On Wed, 2013-10-16 at 01:10 +0100, Rajil Saraswat wrote:
>> I was finally able to carry out a git bisect. Had to do a git pull on
>> a fast internet hooked machine and ftp the files over to the remote
>> machine.
>>
>> I started with 'git bisect bad v2.6.
On 11/02/2013 10:53 AM, Ricardo Ribalda Delgado wrote:
> From: Ricardo Ribalda
>
> vb2_fop_relase does not held the lock although it is modifying the
> queue->owner field.
>
> This could lead to race conditions on the vb2_perform_io function
> when multiple applications are accessing the video d
Em Sun, 03 Nov 2013 13:46:01 +0100
Maik Broemme escreveu:
> Hi Mauro,
>
> Mauro Carvalho Chehab wrote:
> > Em Sun, 3 Nov 2013 01:22:35 +0100
> > Maik Broemme escreveu:
> >
> > > I've updated the current DDBridge to latest version 0.9.10 from Ralph
> > > Metzler available at:
> > >
> > > http
Em Sun, 03 Nov 2013 13:17:02 +0100
Maik Broemme escreveu:
> Hi Mauro,
>
> Mauro Carvalho Chehab wrote:
> > Em Sun, 3 Nov 2013 01:25:23 +0100
> > Maik Broemme escreveu:
> >
> > > Added (DD) to NXP TDA18271C2 silicon tuner as this tuner was
> > > specifically added for Digital Devices ddbridge
Em Sun, 03 Nov 2013 19:00:22 +0200
Antti Palosaari escreveu:
> On 03.11.2013 11:56, Mauro Carvalho Chehab wrote:
> > Hi Maik,
> >
> > Em Sun, 3 Nov 2013 01:31:04 +0100
> > Maik Broemme escreveu:
> >
> >> Added support for the NXP TDA18212 silicon tuner used by recent
> >> Digital Devices hardwar
Em Sun, 03 Nov 2013 21:21:35 +0100
Ralph Metzler escreveu:
> Antti Palosaari writes:
> > On 03.11.2013 13:31, Mauro Carvalho Chehab wrote:
> > > Em Wed, 23 Oct 2013 00:57:47 +0200
> > > Ralph Metzler escreveu:
> > >> I am wondering if anybody looked into API extensions for DVB-C2 yet?
> > >
On 11/04/2013 12:29 PM, Sylwester Nawrocki wrote:
> Sorry, I missed to reply to this e-mail.
>
> On 04/11/13 11:57, Hans Verkuil wrote:
>> Hi John,
>>
>> On 10/18/2013 02:03 AM, John Sheu wrote:
>>> On Thu, Oct 17, 2013 at 3:54 PM, Sylwester Nawrocki
>>> wrote:
On 10/18/2013 12:25 AM, John S
On cris arch, the functions below aren't defined:
drivers/media/platform/sh_veu.c: In function 'sh_veu_reg_read':
drivers/media/platform/sh_veu.c:228:2: error: implicit declaration of
function 'ioread32' [-Werror=implicit-function-declaration]
drivers/media/platform/sh_ve
Hi Pali,
On 10/26/2013 10:45 PM, Pali Rohár wrote:
> On Saturday 26 October 2013 22:22:09 Hans Verkuil wrote:
>>> Hans, so can it be added to drivers/staging/media tree?
>>
>> Yes, that is an option. It's up to you to decide what you
>> want. Note that if no cleanup work is done on the staging
>>
Sorry, I missed to reply to this e-mail.
On 04/11/13 11:57, Hans Verkuil wrote:
> Hi John,
>
> On 10/18/2013 02:03 AM, John Sheu wrote:
>> On Thu, Oct 17, 2013 at 3:54 PM, Sylwester Nawrocki
>> wrote:
>>> On 10/18/2013 12:25 AM, John Sheu wrote:
On Thu, Oct 17, 2013 at 2:46 PM, John Sheu w
Hi Ben,
Em Mon, 04 Nov 2013 04:03:10 +
Ben Hutchings escreveu:
> On Sat, 2013-11-02 at 11:31 -0200, Mauro Carvalho Chehab wrote:
> > On cris and frv archs, the functions below aren't defined:
> > drivers/media/platform/sh_veu.c: In function 'sh_veu_reg_read':
> > drivers/media/platfo
Hi Guennadi,
Sorry for the delay, I only saw this today while I was going through my
mail backlog.
On 10/17/2013 08:24 PM, Guennadi Liakhovetski wrote:
> Hi Hans
>
> Sorry for reviving this old thread. I was going to resubmit a part of
> those patches for mainlining and then I found this your c
Hi Laurent,
Thanks for the patch.
On Mon, Nov 04, 2013 at 11:07:48AM +0100, Laurent Pinchart wrote:
> The pad::get_fmt call must be protected by a mutex, but preparing its
> arguments doesn't need to be. Move the non-critical code out of the
> mutex-protected section.
>
> Signed-off-by: Laurent
On Mon, Nov 4, 2013 at 5:58 AM, Mauro Carvalho Chehab
wrote:
> Em Sun, 3 Nov 2013 19:50:02 -0500
> Michael Krufky escreveu:
>
>> On Sat, Nov 2, 2013 at 9:31 AM, Mauro Carvalho Chehab
>> wrote:
>> > Dynamic static allocation is evil, as Kernel stack is too low, and
>> > compilation complains abou
On 11/04/2013 10:41 AM, Hans Verkuil wrote:
> Hi Laurent,
>
> For this whole patch series:
>
> Acked-by: Hans Verkuil
And also for patches 19-22 :-)
Thanks!
Hans
>
> I strongly recommend that you add another patch adding the s_input function.
> It's trivial to do and it will make v4
Em Sun, 3 Nov 2013 19:50:02 -0500
Michael Krufky escreveu:
> On Sat, Nov 2, 2013 at 9:31 AM, Mauro Carvalho Chehab
> wrote:
> > Dynamic static allocation is evil, as Kernel stack is too low, and
> > compilation complains about it on some archs:
> >
> > drivers/media/usb/dvb-usb-v2/mxl111
Hi John,
On 10/18/2013 02:03 AM, John Sheu wrote:
> On Thu, Oct 17, 2013 at 3:54 PM, Sylwester Nawrocki
> wrote:
>> On 10/18/2013 12:25 AM, John Sheu wrote:
>>> On Thu, Oct 17, 2013 at 2:46 PM, John Sheu wrote:
> Sweet. Thanks for spelling things out explicitly like this. The fact
>
The pad::get_fmt call must be protected by a mutex, but preparing its
arguments doesn't need to be. Move the non-critical code out of the
mutex-protected section.
Signed-off-by: Laurent Pinchart
---
drivers/media/platform/omap3isp/ispvideo.c | 7 ++-
1 file changed, 2 insertions(+), 5 deleti
Hi Mauro,
On Monday 04 November 2013 01:06:25 Laurent Pinchart wrote:
> Hello,
>
> This is the second version of the OMAP4 ISS driver patches for inclusion in
> the mainline kernel. I've addressed most of the comments received on the
> first version (some of them are still being discussed) in add
The ioctl is (at least currently) mandatory.
Signed-off-by: Laurent Pinchart
---
drivers/staging/media/omap4iss/iss_video.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/staging/media/omap4iss/iss_video.c
b/drivers/staging/media/omap4iss/iss_video.c
index 6800623..766491e 1
The pad::get_fmt call must be protected by a mutex, but preparing its
arguments doesn't need to be. Move the non-critical code out of the
mutex-protected section.
Signed-off-by: Laurent Pinchart
---
drivers/staging/media/omap4iss/iss_video.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletion
Translating -ENOIOCTLCMD to -EINVAL is invalid, the correct ioctl return
value is -ENOTTY.
Signed-off-by: Laurent Pinchart
---
drivers/staging/media/omap4iss/iss_video.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/omap4iss/iss_video.c
b/driver
The remote subdev of any video node in the OMAP4 ISS is an internal
subdev that is guaranteed to implement get_fmt. Don't check the return
value for -ENOIOCTLCMD, as this can't happen.
Signed-off-by: Laurent Pinchart
---
drivers/staging/media/omap4iss/iss_video.c | 4 +---
1 file changed, 1 inse
Hi Laurent,
For this whole patch series:
Acked-by: Hans Verkuil
I strongly recommend that you add another patch adding the s_input function.
It's trivial to do and it will make v4l2-compliance happy :-)
Fixing the issue with iss_video_try_format() and a missing get_fmt op is
nice-to-have,
but
On 10/15/2013 07:37 PM, edubez...@gmail.com wrote:
> Hello Dinesh,
>
> On Tue, Oct 15, 2013 at 11:24 AM, Dinesh Ram wrote:
>> Hello Eduardo,
>>
>> In this patch series, I have addressed the comments by you
>> concerning my last patch series.
>> In the resulting patches, I have corrected most of t
When adding frequency clamping to the tef6862 and radio-tea5764 drivers
I forgot to actually *assign* the clamp result to the frequency.
Signed-off-by: Hans Verkuil
Reported-by: Hans Petter Selasky
---
drivers/media/radio/radio-tea5764.c | 2 +-
drivers/media/radio/tef6862.c | 2 +-
2 fil
Hi Hans,
On 10/28/2013 12:45 PM, Hans Petter Selasky wrote:
> On 05/31/13 12:02, Hans Verkuil wrote:
>> return -EINVAL;
>> +}
>> +clamp(freq, FREQ_MIN * FREQ_MUL, FREQ_MAX * FREQ_MUL);
>> tea5764_power_up(radio);
>> -tea5764_tune(radio, (f->frequency * 125) / 2);
>> +
On 01-11-13 17:26, Joseph Zik wrote:
Hello all,
I wanted to contribute to dvb-apps package with initial DVB-T tuning
data for Uganda, Africa
Added and pushed to the usual places.
Attached is the scan file. Please let me know, if there's any other
info I can provide.
Next time, a proper patch
At Fri, 1 Nov 2013 19:48:19 +0800,
Nicolin Chen wrote:
>
> Since gen_pool_dma_alloc() is introduced, we implement it to simplify code.
>
> Signed-off-by: Nicolin Chen
Acked-by: Takashi Iwai
> ---
> sound/core/memalloc.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff
On 11/04/2013 12:28 AM, Laurent Pinchart wrote:
> Hi Hans,
>
> Thank you for the review.
>
> On Thursday 03 October 2013 08:54:19 Hans Verkuil wrote:
>> On 10/03/2013 01:55 AM, Laurent Pinchart wrote:
>>> From: Sergio Aguirre
>>>
>>> This adds a very simplistic driver to utilize the CSI2A interf
81 matches
Mail list logo
