Re: [PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-02-04 Thread Hans Verkuil
On 02/05/2014 12:04 AM, Sylwester Nawrocki wrote: > Hi, > > On 02/03/2014 10:03 AM, Hans Verkuil wrote: >> Hi Philipp, Laurent, >> >> On 02/02/2014 02:04 PM, Philipp Zabel wrote: >>> On Sun, Feb 02, 2014 at 11:21:13AM +0100, Laurent Pinchart wrote: Hi Hans, On Friday 31 January 2014

Re: [PATCH] e4000: implement controls via v4l2 control framework

2014-02-04 Thread Hans Verkuil
Hi Antti, Hmm, it's a bit ugly this code. I have some suggestions below... On 02/05/2014 01:05 AM, Antti Palosaari wrote: > Implement gain and bandwidth controls using v4l2 control framework. > Pointer to control handler is provided by exported symbol. > > Cc: Mauro Carvalho Chehab > Cc: Hans V

Re: [PATCH] s2255drv: file handle cleanup

2014-02-04 Thread Hans Verkuil
On 02/05/2014 12:10 AM, Dean Anderson wrote: > Hi Hans, > > Please ignore and reject this patch. videobuf_queue_vmalloc_init needs > to be in probe, not in open. > > Let me know your thoughts on doing videobuf2 before s2255_fh removal so > we don't have to work around or fix videobuf version on

Re: [PATCH] s2255drv: file handle cleanup

2014-02-04 Thread Hans Verkuil
On 02/04/2014 11:36 PM, Dean Anderson wrote: > Removes most parameters from s2255_fh. These elements belong in s2255_ch. > In the future, s2255_fh will be removed when videobuf2 is used. videobuf2 > has convenient and safe functions for locking streaming resources. > > The removal of s2255_fh (an

Re: [PATCH v2 1/1] v4l: subdev: Allow 32-bit compat IOCTLs

2014-02-04 Thread Hans Verkuil
On 02/04/2014 09:10 PM, Mauro Carvalho Chehab wrote: > Em Fri, 31 Jan 2014 18:35:12 +0100 > Hans Verkuil escreveu: > >> Hi Sakari, >> >> On 01/31/2014 05:15 PM, Sakari Ailus wrote: >>> I thought this was already working but apparently not. Allow 32-bit compat >>> IOCTLs on 64-bit systems. >>> >>>

Re: [RFC PATCH 0/4] rc: Adding support for sysfs wakeup scancodes

2014-02-04 Thread Antti Seppälä
On 4 February 2014 19:54, Mauro Carvalho Chehab wrote: > Em Thu, 23 Jan 2014 21:11:09 +0200 > Antti Seppälä escreveu: > >> On 23 January 2014 00:01, Mauro Carvalho Chehab wrote: >> > Not sure if you saw it, but there's already another patchset proposing >> > that, that got submitted before this

au0828 errors and mangled video with Hauppauge 950Q

2014-02-04 Thread Connor Behan
Ccing Devin. I'm pretty sure the analog side has a problem at the driver level. On most days, one cannot pickup an ATSC signal where I am, so I am trying to capture analog video with a Hauppauge WinTV HVR 950Q. Whether I use Television, Composite or S-Video, I see the same corrupted video such as

cron job: media_tree daily build: ERRORS

2014-02-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Feb 5 04:00:30 CET 2014 git branch: test git hash: 261cb200e7227820cd0056435d7c1a3a9c476766 gcc versio

[PATCH v2] DVB tuner use v4l2 controls

2014-02-04 Thread Antti Palosaari
Split .s_ctrl logic according to Hans comments. regards Antti Antti Palosaari (1): e4000: implement controls via v4l2 control framework drivers/media/tuners/e4000.c | 210 +- drivers/media/tuners/e4000.h | 14 +++ drivers/media/tuners/e4000_priv.

[PATCH] e4000: implement controls via v4l2 control framework

2014-02-04 Thread Antti Palosaari
Implement gain and bandwidth controls using v4l2 control framework. Pointer to control handler is provided by exported symbol. Cc: Mauro Carvalho Chehab Cc: Hans Verkuil Signed-off-by: Antti Palosaari --- drivers/media/tuners/e4000.c | 210 +- drivers/m

Re: [PATCH] s2255drv: file handle cleanup

2014-02-04 Thread Dean Anderson
Hi Hans, Please ignore and reject this patch. videobuf_queue_vmalloc_init needs to be in probe, not in open. Let me know your thoughts on doing videobuf2 before s2255_fh removal so we don't have to work around or fix videobuf version one's deficiencies. Thanks, On 2014-02-04 16:36, Dean

Re: [PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-02-04 Thread Sylwester Nawrocki
Hi, On 02/03/2014 10:03 AM, Hans Verkuil wrote: Hi Philipp, Laurent, On 02/02/2014 02:04 PM, Philipp Zabel wrote: On Sun, Feb 02, 2014 at 11:21:13AM +0100, Laurent Pinchart wrote: Hi Hans, On Friday 31 January 2014 09:43:00 Hans Verkuil wrote: I think you might want to add a check in uvc_qu

[PATCH] s2255drv: file handle cleanup

2014-02-04 Thread Dean Anderson
Removes most parameters from s2255_fh. These elements belong in s2255_ch. In the future, s2255_fh will be removed when videobuf2 is used. videobuf2 has convenient and safe functions for locking streaming resources. The removal of s2255_fh (and s2255_fh->resources) was not done now to avoid using

Re: [PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-02-04 Thread Laurent Pinchart
Hi Hans, On Monday 03 February 2014 10:03:39 Hans Verkuil wrote: > On 02/02/2014 02:04 PM, Philipp Zabel wrote: > > On Sun, Feb 02, 2014 at 11:21:13AM +0100, Laurent Pinchart wrote: > >> On Friday 31 January 2014 09:43:00 Hans Verkuil wrote: > >>> I think you might want to add a check in uvc_queue

[PATCH v2] s2255drv: refactoring s2255_channel to s2255_vc

2014-02-04 Thread Dean Anderson
Renaming s2255_channel and all instances of channel to vc (video channel). Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 517 ++-- 1 file changed, 259 insertions(+), 258 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/driv

Re: [PATCH] s2255drv: refactoring s2255_channel to s2255_vc

2014-02-04 Thread Dean Anderson
There are some missing changes. It compiles, but please review v2 instead. On 2014-02-04 15:04, Dean Anderson wrote: Renaming s2255_channel and all instances of channel to vc (video channel). Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 469 ++

[PATCH] s2255drv: refactoring s2255_channel to s2255_vc

2014-02-04 Thread Dean Anderson
Renaming s2255_channel and all instances of channel to vc (video channel). Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 469 ++-- 1 file changed, 235 insertions(+), 234 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/driv

[PATCH] s2255drv: removal of s2255_dmaqueue structure

2014-02-04 Thread Dean Anderson
Removal of unused and unnecessary s2255dma_queue structure. Signed-off-by: Dean Anderson --- drivers/media/usb/s2255/s2255drv.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s225

[PATCH 1/2] m88rs2000: add caps FE_CAN_INVERSION_AUTO

2014-02-04 Thread Malcolm Priestley
This frontend is always auto inversion. Signed-off-by: Malcolm Priestley Cc: sta...@vger.kernel.org # v3.9+ --- drivers/media/dvb-frontends/m88rs2000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/m88rs2000.c b/drivers/media/dvb-frontends/m88rs

[PATCH 2/2] m88rs2000: add m88rs2000_get_tune_settings

2014-02-04 Thread Malcolm Priestley
Add min delay of 2000 ms on symbol rate more than 300 and delay of 3000ms less than this. This prevents crashing the frontend on continuous transponder scans. Otherwise other dvb_frontend_tune_settings are the same as default. This makes very little time difference to good channel scans, but

Re: [PATCH v2 1/1] v4l: subdev: Allow 32-bit compat IOCTLs

2014-02-04 Thread Mauro Carvalho Chehab
Em Fri, 31 Jan 2014 18:35:12 +0100 Hans Verkuil escreveu: > Hi Sakari, > > On 01/31/2014 05:15 PM, Sakari Ailus wrote: > > I thought this was already working but apparently not. Allow 32-bit compat > > IOCTLs on 64-bit systems. > > > > Signed-off-by: Sakari Ailus > > --- > > drivers/media/v4l

Re: [PATCH 2/4] e4000: implement controls via v4l2 control framework

2014-02-04 Thread Antti Palosaari
Moi Hans On 04.02.2014 20:43, Hans Verkuil wrote: On 02/04/2014 02:39 AM, Antti Palosaari wrote: Implement gain and bandwidth controls using v4l2 control framework. Pointer to control handler is provided by exported symbol. Cc: Mauro Carvalho Chehab Cc: Hans Verkuil Signed-off-by: Antti Palo

Re: [PATCH 3/4] [media] mceusb: remove redundant function and defines

2014-02-04 Thread Mauro Carvalho Chehab
Hi Sean, Em Mon, 20 Jan 2014 22:10:43 + Sean Young escreveu: Could you please provide a patch description? Even simple ones should have, and this one is everything but trivial... Also, you should likely break it into smaller changesets. For example, the last hunk adding a usb_kill_urb() loo

Re: [PATCH] s2255drv: port to videobuf2

2014-02-04 Thread Dean Anderson
On 2014-02-04 04:04, Hans Verkuil wrote: Hi Dean, On 02/03/14 18:06, Dean Anderson wrote: On 2014-02-03 03:51, Hans Verkuil wrote: Hi Dean, Some specific comments below, but first two general comments: It is easier to review if at least the removal of the old s2255_fh struct was done as a s

Re: [PATCH 4/4] em28xx-i2c: remove duplicate error printing code from em28xx_i2c_xfer()

2014-02-04 Thread Mauro Carvalho Chehab
Em Sun, 19 Jan 2014 22:48:37 +0100 Frank Schäfer escreveu: > Signed-off-by: Frank Schäfer > --- > drivers/media/usb/em28xx/em28xx-i2c.c | 11 +++ > 1 Datei geändert, 3 Zeilen hinzugefügt(+), 8 Zeilen entfernt(-) > > diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c > b/drivers/medi

Re: [PATCH 3/4] em28xx-i2c: do not map -ENXIO errors to -ENODEV for empty i2c transfers

2014-02-04 Thread Mauro Carvalho Chehab
Em Sun, 19 Jan 2014 22:48:36 +0100 Frank Schäfer escreveu: > Commit e63b009d6e "" changed the error codes i2c ACK errors from -ENODEV to > -ENXIO. > But it also introduced a line that maps -ENXIO back to -ENODEV in case of > empty i2c > messages, which makes no sense, because > 1.) an ACK error

Re: [PATCH 2/4] e4000: implement controls via v4l2 control framework

2014-02-04 Thread Hans Verkuil
On 02/04/2014 02:39 AM, Antti Palosaari wrote: > Implement gain and bandwidth controls using v4l2 control framework. > Pointer to control handler is provided by exported symbol. > > Cc: Mauro Carvalho Chehab > Cc: Hans Verkuil > Signed-off-by: Antti Palosaari > --- > drivers/media/tuners/e4000

[git:media_tree/master] [media] media: rc: add raw decoder for Sharp protocol

2014-02-04 Thread Mauro Carvalho Chehab
This is an automatic generated email to let you know that the following patch were queued at the http://git.linuxtv.org/media_tree.git tree: Subject: [media] media: rc: add raw decoder for Sharp protocol Author: James Hogan Date:Fri Jan 17 10:58:48 2014 -0300 Add a raw decoder for the Sha

Re: [RFC PATCH 0/4] rc: Adding support for sysfs wakeup scancodes

2014-02-04 Thread Mauro Carvalho Chehab
Em Thu, 23 Jan 2014 21:11:09 +0200 Antti Seppälä escreveu: > On 23 January 2014 00:01, Mauro Carvalho Chehab wrote: > > Not sure if you saw it, but there's already another patchset proposing > > that, that got submitted before this changeset: > > https://patchwork.linuxtv.org/patch/21625

Re: linux-next: Tree for Feb 4 (media/radio/si4713/radio-usb-si4713.c)

2014-02-04 Thread Randy Dunlap
On 02/03/2014 09:07 PM, Stephen Rothwell wrote: > Hi all, > > This tree fails (more than usual) the powerpc allyesconfig build. > > Changes since 20140203: > on i386: # CONFIG_I2C is not set CC [M] drivers/media/radio/si4713/radio-usb-si4713.o drivers/media/radio/si4713/radio-usb-si4713.c:

Re: Help wanted patching saa7164 driver to work with Compro E900F

2014-02-04 Thread Steven Toth
>> Where did you purchase the card? > > Hi Steve > > It is a pleasure, I'm finding it very interesting, and it would > certainly be satisfying if I did get it working. Thankyou for writing > the driver! You are welcome! > > I bought it from either msy.com.au or skycomp.com.au quite a few years >

Re: Fw: [PATCH 34/52] devices.txt: add video4linux device for Software Defined Radio

2014-02-04 Thread Greg Kroah-Hartman
On Tue, Feb 04, 2014 at 11:19:03AM -0200, Mauro Carvalho Chehab wrote: > Alan/Greg/Andrew/Rob, > > Not sure who is currently maintaining Documentation/devices.txt. > > We're needing to add support of a new type of V4L2 devices there. > > Could you please ack with the following patch? If this one

Re: Help wanted patching saa7164 driver to work with Compro E900F

2014-02-04 Thread Daniel Playfair Cal
On Wed, Feb 5, 2014 at 12:32 AM, Steven Toth wrote: > On Tue, Feb 4, 2014 at 5:29 AM, Daniel Playfair Cal . > > Hey Daniel, > > Thanks for showing an interest in the driver. > > I've been trying to source one of these cards for quite a while, > occasionally checking amazon etc. I can't seem to fin

Re: Help wanted patching saa7164 driver to work with Compro E900F

2014-02-04 Thread Steven Toth
On Tue, Feb 4, 2014 at 5:29 AM, Daniel Playfair Cal wrote: > Hello all, > > I've been working on patching the saa7164 driver to work with the > Compro Videomate Vista E900F. This is a PCI-e tuner card that seems to > be almost identical to the Hauppauge HVR-2200, many versions of which > are suppo

Re: [PATCH 34/52] devices.txt: add video4linux device for Software Defined Radio

2014-02-04 Thread Alan Cox
On Tue, 04 Feb 2014 11:19:03 -0200 Mauro Carvalho Chehab wrote: > Alan/Greg/Andrew/Rob, > > Not sure who is currently maintaining Documentation/devices.txt. > > We're needing to add support of a new type of V4L2 devices there. > > Could you please ack with the following patch? If this one is o

Fw: [PATCH 34/52] devices.txt: add video4linux device for Software Defined Radio

2014-02-04 Thread Mauro Carvalho Chehab
Alan/Greg/Andrew/Rob, Not sure who is currently maintaining Documentation/devices.txt. We're needing to add support of a new type of V4L2 devices there. Could you please ack with the following patch? If this one is ok, I intend to send via my tree together with the patch series that implements s

[REVIEW PATCH] DocBook media: partial rewrite of "Opening and Closing Devices"

2014-02-04 Thread Hans Verkuil
This section was horribly out of date. A lot of references to old and obsolete behavior have been dropped. Same as https://patchwork.linuxtv.org/patch/21620/, but with the text ", with the exception of overlay support." dropped since 'overlay' is not a function in that sense. Signed-off-by: Hans

Re: [GIT PULL FOR v3.15] Updates for 3.15

2014-02-04 Thread Mauro Carvalho Chehab
Em Mon, 03 Feb 2014 11:35:20 +0100 Hans Verkuil escreveu: > Hi Mauro, > > The usual list of updates. I also decided to add my DocBook changes to this > pull request. > > Regards, > > Hans > > The following changes since commit 587d1b06e07b4a079453c74ba9edf17d21931049: > > [media] rc-

Re: [RFC PATCH 3/6] DocBook media: partial rewrite of "Opening and Closing Devices"

2014-02-04 Thread Hans Verkuil
On 02/04/14 13:20, Mauro Carvalho Chehab wrote: > Em Fri, 17 Jan 2014 10:24:11 +0100 > Hans Verkuil escreveu: > >> >> I'll post the revised version of this patch next. > > Weird, I'm not seeing the revised version of this patch posted. https://patchwork.linuxtv.org/patch/21620/ > > Anyway, fr

Re: [RFC PATCH 3/6] DocBook media: partial rewrite of "Opening and Closing Devices"

2014-02-04 Thread Mauro Carvalho Chehab
Em Fri, 17 Jan 2014 10:24:11 +0100 Hans Verkuil escreveu: > Hi Mauro, > > On 01/13/2014 06:23 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 13 Jan 2014 17:15:40 +0100 > > Hans Verkuil escreveu: > > > >> On 01/13/2014 04:20 PM, Mauro Carvalho Chehab wrote: > >>> Em Tue, 7 Jan 2014 14:06:54 +010

RFC: how to set the colorspace for an output sub-device?

2014-02-04 Thread Hans Verkuil
Hi all, We have the following situation: we use a ths8200 to send video out over a VGA connector. It receives RGB video from a videoport DMA engine. However, we want to be able to tell the ths8200 to convert the RGB to YUV and send out YUV over the VGA connector instead of RGB. Yeah, I know, it's

Help wanted patching saa7164 driver to work with Compro E900F

2014-02-04 Thread Daniel Playfair Cal
Hello all, I've been working on patching the saa7164 driver to work with the Compro Videomate Vista E900F. This is a PCI-e tuner card that seems to be almost identical to the Hauppauge HVR-2200, many versions of which are supported. I've had some success but there are a few problems which I'm not

Re: [PATCH 1/2] [media] v4l2: Add settings for Horizontal and Vertical MV Search Range

2014-02-04 Thread Hans Verkuil
Acked-by: Hans Verkuil Regards, Hans On 02/04/14 10:59, Amit Grover wrote: > Adding V4L2 controls for horizontal and vertical search range in pixels > for motion estimation module in video encoder. > > Signed-off-by: Swami Nathan > Signed-off-by: Amit Grover > --- > Documentation/Do

Re: [PATCH] s2255drv: port to videobuf2

2014-02-04 Thread Hans Verkuil
Hi Dean, On 02/03/14 18:06, Dean Anderson wrote: > On 2014-02-03 03:51, Hans Verkuil wrote: >> Hi Dean, >> >> Some specific comments below, but first two general comments: >> >> It is easier to review if at least the removal of the old s2255_fh struct >> was done as a separate patch. It's always g

[PATCH 1/2] [media] v4l2: Add settings for Horizontal and Vertical MV Search Range

2014-02-04 Thread Amit Grover
Adding V4L2 controls for horizontal and vertical search range in pixels for motion estimation module in video encoder. Signed-off-by: Swami Nathan Signed-off-by: Amit Grover --- Documentation/DocBook/media/v4l/controls.xml | 20 drivers/media/v4l2-core/v4l2-ctrls.c

[PATCH v3 0/2] drivers/media: Add controls for Horizontal and Vertical MV Search Range

2014-02-04 Thread Amit Grover
This is v3 version for the patch: s5p-mfc: Add Horizontal and Vertical search range for Video Macro Blocks (https://lkml.org/lkml/2013/12/30/83) Changes from v1: 1) Splitted the patch into V4L2 and MFC driver patches. 2) Incorporated review comments on v1. Changes from v2: 1) Removed the range re

[PATCH 2/2] [media] s5p-mfc: Add Horizontal and Vertical MV Search Range

2014-02-04 Thread Amit Grover
This patch adds Controls to set Horizontal and Vertical search range for Motion Estimation block for Samsung MFC video Encoders. Signed-off-by: Swami Nathan Signed-off-by: Amit Grover --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h|1 + drivers/media/platform/s5p-mfc/s5p_mfc_common.h |

[linuxtv-media:master 499/499] drivers/media/usb/usbtv/usbtv-core.c:119:22: sparse: symbol 'usbtv_id_table' was not declared. Should it be static?

2014-02-04 Thread kbuild test robot
tree: git://linuxtv.org/media_tree.git master head: a3550ea665acd1922df8275379028c1634675629 commit: a3550ea665acd1922df8275379028c1634675629 [499/499] [media] usbtv: split core and video implementation reproduce: make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >>

[PATCH] usbtv: fix compiler error due to missing module.h

2014-02-04 Thread Hans Verkuil
usbtv-video.c needs module.h. So move the module.h include from usbtv-core.c to usbtv.h, that way both core.c and video.c have it. Signed-off-by: Hans Verkuil diff --git a/drivers/media/usb/usbtv/usbtv-core.c b/drivers/media/usb/usbtv/usbtv-core.c index e89e48b..d543928 100644 --- a/drivers/me

Re: [RFCv1 PATCH 7/9] vb2: add reinit_streaming op.

2014-02-04 Thread Hans Verkuil
On 01/30/2014 03:51 PM, Hans Verkuil wrote: > From: Hans Verkuil > > This new op is called after stop_streaming() or after a failed call to > start_streaming(). The driver needs to dequeue any pending active buffers > it got from the buf_queue() callback. > > The reason this op was added is that

Re: [RFCv1 PATCH 9/9] v4l2-ioctl: check CREATE_BUFS format via TRY_FMT.

2014-02-04 Thread Hans Verkuil
On 01/30/2014 03:51 PM, Hans Verkuil wrote: > From: Hans Verkuil > > The format passed to VIDIOC_CREATE_BUFS is completely unchecked at > the moment. So pass it to VIDIOC_TRY_FMT first. Don't bother reviewing this. I'm going to change this anyway. Regards, Hans > > Signed-off-by: Han

Re: [PATCH 2/2] usbtv: add audio support

2014-02-04 Thread Mauro Carvalho Chehab
Em Tue, 7 Jan 2014 23:13:22 +0100 Federico Simoncelli escreveu: > From: Federico Simoncelli > > Signed-off-by: Federico Simoncelli > Tested-by: Lubomir Rintel > --- > drivers/media/usb/usbtv/Makefile | 3 +- > drivers/media/usb/usbtv/usbtv-audio.c | 384 > +++