[PATCH 1/2] media: mx1_camera: Remove driver

2014-05-23 Thread Alexander Shiyan
That driver hasn't been really maintained for a long time. It doesn't compile in any way, it includes non-existent headers, has no users, and marked as "BROKEN" more than year. Due to these factors, mx1_camera is now removed from the tree. Signed-off-by: Alexander Shiyan --- drivers/media/platfo

[PATCH 2/2] media: mx2_camera: Change Kconfig dependency

2014-05-23 Thread Alexander Shiyan
This patch change MACH_MX27 dependency to SOC_IMX27 for MX2 camera driver, since MACH_MX27 symbol is scheduled for removal. Signed-off-by: Alexander Shiyan --- drivers/media/platform/soc_camera/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/soc

[PATCH RESEND] media: m2m-deinterlace: Convert to devm* API

2014-05-23 Thread Alexander Shiyan
Replace resource handling in the driver with managed device resource. Signed-off-by: Alexander Shiyan --- drivers/media/platform/m2m-deinterlace.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/m2m-deinterlace.c b/drivers/media/platform/m2m-dei

Re: [PATCH v5 41/49] media: davinci: vpif_capture: drop unneeded module params

2014-05-23 Thread Prabhakar Lad
Hi Mauro, On Sat, May 24, 2014 at 4:08 AM, Mauro Carvalho Chehab wrote: > Em Fri, 16 May 2014 19:03:47 +0530 > "Lad, Prabhakar" escreveu: > >> From: "Lad, Prabhakar" >> >> Signed-off-by: Lad, Prabhakar > > -ENOPATCHDESCRIPTION > > Why to remove those parameters? Please _ALWAYS_ describe yo

Re: [PATCH v5 00/49] DaVinci: vpif: upgrade with v4l helpers and v4l compliance fixes

2014-05-23 Thread Prabhakar Lad
Hi Hans, Thanks for the review from 2 patches to 50 :) On Fri, May 23, 2014 at 2:00 PM, Hans Verkuil wrote: > Hi Prabhakar, > > Thanks for this patch series, it looks good to me and I'll make a pull > request for this. > Thanks. > I did find a few issues, but they are all pre-existing problems,

Re: [PATCH v5 04/49] media: davinci: vpif_display: release buffers in case start_streaming() call back fails

2014-05-23 Thread Prabhakar Lad
Hi Hans, Thanks for the review. On Fri, May 23, 2014 at 2:05 PM, Hans Verkuil wrote: > On 05/16/2014 03:33 PM, Lad, Prabhakar wrote: >> From: "Lad, Prabhakar" >> >> this patch adds support to release the buffer by calling >> vb2_buffer_done(), with state marked as VB2_BUF_STATE_QUEUED >> if sta

cron job: media_tree daily build: ERRORS

2014-05-23 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat May 24 04:00:26 CEST 2014 git branch: test git hash: 12bd10c79bd8f65698660e992b8656e9a48eeca1 gcc versi

Re: [GIT PULL FOR v3.16] davinci updates

2014-05-23 Thread Mauro Carvalho Chehab
Em Fri, 23 May 2014 11:07:25 +0200 Hans Verkuil escreveu: > Hi Mauro, > > These are cleanup patches for the davinci drivers. A total of about 1200 lines > of code are removed. Not bad! > > Regards, > > Hans > > > The following changes since commit e899966f626f1f657a4a7bac736c0b9ae5a243

Re: [PATCH v5 41/49] media: davinci: vpif_capture: drop unneeded module params

2014-05-23 Thread Mauro Carvalho Chehab
Em Fri, 16 May 2014 19:03:47 +0530 "Lad, Prabhakar" escreveu: > From: "Lad, Prabhakar" > > Signed-off-by: Lad, Prabhakar -ENOPATCHDESCRIPTION Why to remove those parameters? Please _ALWAYS_ describe your patches. My crystal ball is malfunctioning today, so I was unable to scry the reaso

[PATCH] [media] usbtv: fix leak at failure path in usbtv_probe()

2014-05-23 Thread Alexey Khoroshilov
Error handling code in usbtv_probe() misses usb_put_dev(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/media/usb/usbtv/usbtv-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/usbtv/usbtv-core.c b/driv

Up to 76% off on watches

2014-05-23 Thread Linux
You will be the envy of the people at the office with your new watch http://blakematthews.ca/kgpytya.php -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.h

Re: [PATCH] Staging: Media: sn9c102: Fixed a pointer declaration coding style issue

2014-05-23 Thread Hans Verkuil
On 05/23/2014 06:59 PM, Chaitanya Hazarey wrote: > Hey Dan, > > Sorry my bad, will resubmit the patch in a proper manner with the > required corrections. > Don't bother. This patch: http://comments.gmane.org/gmane.linux.drivers.driver-project.devel/48570 has just been merged and that has the sa

Re: [PATCH] Staging: Media: sn9c102: Fixed a pointer declaration coding style issue

2014-05-23 Thread Chaitanya Hazarey
Hey Dan, Sorry my bad, will resubmit the patch in a proper manner with the required corrections. Thanks for looking into this. Thanks, Chaitanya On Fri, May 23, 2014 at 12:10 AM, Dan Carpenter wrote: > On Thu, May 22, 2014 at 04:11:38PM -0700, Chaitanya wrote: >> Fixed the ERROR thrown off by

Re: [GIT PULL FOR v3.16] Various fixes

2014-05-23 Thread Mauro Carvalho Chehab
Em Mon, 12 May 2014 10:31:10 +0200 Hans Verkuil escreveu: > (Updated version of my pull request of May 9th, adding the remaining em28xx > patches > from Frank.) > > Hi Mauro, > > I went through my pending patches queue and managed to go through most of it. > > Most patches are fairly trivial,

Re: [PATCH v7] media: vb2: Take queue or device lock in mmap-related vb2 ioctl handlers

2014-05-23 Thread Hans Verkuil
Hi Laurent, This patch caused a circular locking dependency as reported by Sasha Levin: https://lkml.org/lkml/2014/5/5/366 The reason is that copy_to/from_user is called in video_usercopy() with the core lock held. The copy functions can fault which takes the mmap_sem. If it was just video_userc

[GIT PULL FOR v3.16] Various fixes

2014-05-23 Thread Hans Verkuil
Hi Mauro, For the most part these are assorted fixes. The exception is the patch from Arun that adds a new V4L2 event type. The addition of that event is long overdue so I'm happy to see it go in. Regards, Hans The following changes since commit e899966f626f1f657a4a7bac736c0b9ae5a243ea:

Re: [PATCH v2] media: stk1160: Avoid stack-allocated buffer for control URBs

2014-05-23 Thread Hans Verkuil
On 05/17/2014 02:21 PM, Ezequiel Garcia wrote: > Hi Hans, > > On 09 May 12:34 PM, Hans Verkuil wrote: >> On 04/17/2014 02:28 PM, Ezequiel Garcia wrote: >>> Currently stk1160_read_reg() uses a stack-allocated char to get the >>> read control value. This is wrong because usb_control_msg() requires >

Re: [PATCH 1/1] v4l: Check pad arguments for [gs]_frame_interval

2014-05-23 Thread Sakari Ailus
Laurent Pinchart wrote: Hi Sakari, Thank you for the patch. On Monday 31 March 2014 11:23:08 Sakari Ailus wrote: VIDIOC_SUBDEV_[GS]_FRAME_INTERVAL IOCTLs argument structs contain the pad field but the validity check was missing. There should be no implications security-wise from this since no

Re: [PATCH 1/1] v4l: Check pad arguments for [gs]_frame_interval

2014-05-23 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Monday 31 March 2014 11:23:08 Sakari Ailus wrote: > VIDIOC_SUBDEV_[GS]_FRAME_INTERVAL IOCTLs argument structs contain the pad > field but the validity check was missing. There should be no implications > security-wise from this since no driver currently uses

[GIT PULL FOR v3.16] davinci updates

2014-05-23 Thread Hans Verkuil
Hi Mauro, These are cleanup patches for the davinci drivers. A total of about 1200 lines of code are removed. Not bad! Regards, Hans The following changes since commit e899966f626f1f657a4a7bac736c0b9ae5a243ea: Merge tag 'v3.15-rc6' into patchwork (2014-05-21 23:03:15 -0300) are ava

Re: [PATCH v5 00/49] DaVinci: vpif: upgrade with v4l helpers and v4l compliance fixes

2014-05-23 Thread Hans Verkuil
On 05/16/2014 03:33 PM, Lad, Prabhakar wrote: > From: "Lad, Prabhakar" > > Hi, > > This patch series upgrades the vpif capture & display > driver with the all the helpers provided by v4l, this makes > the driver much simpler and cleaner. This also includes few > checkpatch issues. > > Changes f

[PATCH] [media] V4L2: soc_camera: add run-time dependencies to R-Car VIN driver

2014-05-23 Thread Jean Delvare
The R-Car Video Input driver is only useful on shmobile unless build testing. Signed-off-by: Jean Delvare Cc: Vladimir Barinov Cc: Sergei Shtylyov Cc: Guennadi Liakhovetski Cc: Mauro Carvalho Chehab --- drivers/media/platform/soc_camera/Kconfig |1 + 1 file changed, 1 insertion(+) --- l

Re: [PATCH v5 21/49] media: davinci: vpif_display: use SIMPLE_DEV_PM_OPS

2014-05-23 Thread Hans Verkuil
On 05/16/2014 03:33 PM, Lad, Prabhakar wrote: > From: "Lad, Prabhakar" > > this patch uses SIMPLE_DEV_PM_OPS, and drops unneeded members > from io_usrs, usrs and makes use of vb2 helepers instead. > > Signed-off-by: Lad, Prabhakar > --- > drivers/media/platform/davinci/vpif_display.c | 64 >

Re: [PATCH v5 04/49] media: davinci: vpif_display: release buffers in case start_streaming() call back fails

2014-05-23 Thread Hans Verkuil
On 05/16/2014 03:33 PM, Lad, Prabhakar wrote: > From: "Lad, Prabhakar" > > this patch adds support to release the buffer by calling > vb2_buffer_done(), with state marked as VB2_BUF_STATE_QUEUED > if start_streaming() call back fails. > > Signed-off-by: Lad, Prabhakar > --- > drivers/media/pla

Re: [PATCH v5 00/49] DaVinci: vpif: upgrade with v4l helpers and v4l compliance fixes

2014-05-23 Thread Hans Verkuil
Hi Prabhakar, Thanks for this patch series, it looks good to me and I'll make a pull request for this. I did find a few issues, but they are all pre-existing problems, so they can be fixed in follow-up patches. I'll comment on those in the relevant patches. Since display and capture are so simil

[PATCH] [media] mt9v032: fix hblank calculation

2014-05-23 Thread Philipp Zabel
Since (min_row_time - crop->width) can be negative, we have to do a signed comparison here. Otherwise max_t casts the negative value to unsigned int and sets min_hblank to that invalid value. Signed-off-by: Philipp Zabel --- drivers/media/i2c/mt9v032.c | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: [PATCH] Staging: Media: sn9c102: Fixed a pointer declaration coding style issue

2014-05-23 Thread Dan Carpenter
On Thu, May 22, 2014 at 04:11:38PM -0700, Chaitanya wrote: > Fixed the ERROR thrown off by checkpatch.pl. > Put the error message here, or say what it was. > Signed-off-by: Chaitanya Hazarey Could you change your email client so it has your last in the From: header? This patch doesn't apply.

Re: V4L2 control API - choosing base CID for private controls

2014-05-23 Thread Hans Verkuil
On 05/22/2014 01:33 PM, Krzysztof Czarnowski wrote: > Hi, > > I got completely confused while trying to create private controls with > control API and when I finally got down to sanity checks in > v4l2_ctrl_new() in v4l2-ctrls.c... > > It would be nice if the following explanation by Hans (archiv