Re: [PATCH] em28xx: fix compiler warnings

2014-08-07 Thread Hans Verkuil
On 08/05/2014 05:18 PM, Frank Schäfer wrote: Hi Hans, Am 05.08.2014 um 09:00 schrieb Hans Verkuil: Fix three compiler warnings: drivers/media/usb/em28xx/em28xx-input.c: In function ‘em28xx_i2c_ir_handle_key’: drivers/media/usb/em28xx/em28xx-input.c:318:1: warning: the frame size of

[PATCHv4] videobuf2: fix lockdep warning

2014-08-07 Thread Hans Verkuil
Changes since v3: renamed queue_lock to mmap_lock. The following lockdep warning has been there ever since commit a517cca6b24fc54ac209e44118ec8962051662e3 one year ago: [ 403.117947] == [ 403.117949] [ INFO: possible circular locking

Re: [PATCH v2 1/1] v4l: Event documentation fixes

2014-08-07 Thread Hans Verkuil
On 08/06/2014 08:52 AM, Sakari Ailus wrote: Constify event type constants and correct motion detection event number (it's 6, not 5). Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- Thanks for the review, Hans! Since v1: - No

Re: [PATCH v2 1/1] v4l: Event documentation fixes

2014-08-07 Thread Hans Verkuil
On 08/07/2014 08:50 AM, Hans Verkuil wrote: On 08/06/2014 08:52 AM, Sakari Ailus wrote: Constify event type constants and correct motion detection event number (it's 6, not 5). Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com Acked-by: Hans Verkuil hans.verk...@cisco.com Hmm, I

Re: [PATCH 1/4] support for DVBSky dvb-s2 usb: add some config and set_voltage for m88ds3103

2014-08-07 Thread Antti Palosaari
Moikka! That patch contains (too) many changes: 1) TS clock config option 2) TS clock polarity config option 3) start_ctrl() callback 4) set_voltage implementation 5) set_voltage() callback Generally I am fine with 1, 2 and 4. When you do that many different logical changes for existing driver,

Re: [PATCH/RFC v4 00/21] LED / flash API integration

2014-08-07 Thread Jacek Anaszewski
Hi Sakari, On 08/06/2014 08:53 AM, Sakari Ailus wrote: Hi Jacek, On Fri, Jul 11, 2014 at 04:04:03PM +0200, Jacek Anaszewski wrote: ... 1) Who should register V4L2 Flash sub-device? LED Flash Class devices, after introduction of the Flash Manager, are not tightly coupled with any media

Re: [PATCH/RFC v4 00/21] LED / flash API integration

2014-08-07 Thread Jacek Anaszewski
On 08/07/2014 10:21 AM, Jacek Anaszewski wrote: Hi Sakari, On 08/06/2014 08:53 AM, Sakari Ailus wrote: Hi Jacek, On Fri, Jul 11, 2014 at 04:04:03PM +0200, Jacek Anaszewski wrote: ... 1) Who should register V4L2 Flash sub-device? LED Flash Class devices, after introduction of the Flash

Re: Re: [PATCH 1/4] support for DVBSky dvb-s2 usb: add some config andset_voltage for m88ds3103

2014-08-07 Thread nibble.max
Moikka! Thanks for your review. Moikka! That patch contains (too) many changes: 1) TS clock config option 2) TS clock polarity config option 3) start_ctrl() callback 4) set_voltage implementation 5) set_voltage() callback Generally I am fine with 1, 2 and 4. When you do that many different

Re: [PATCH 1/4] support for DVBSky dvb-s2 usb: add some config andset_voltage for m88ds3103

2014-08-07 Thread Antti Palosaari
Moikka! On 08/07/2014 12:31 PM, nibble.max wrote: @@ -523,6 +508,17 @@ static int m88ds3103_set_frontend(struct dvb_frontend *fe) priv-delivery_system = c-delivery_system; + if (priv-cfg-start_ctrl) { + for (len = 0; len 30 ; len++) { +

Casino

2014-08-07 Thread Herbert Meadows
Casino International http://michelle-cash-money.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH/RFC v4 06/21] leds: add API for setting torch brightness

2014-08-07 Thread Jacek Anaszewski
Hi Sakari, On 08/04/2014 02:50 PM, Sakari Ailus wrote: Hi Jacek, Thank you for your continued efforts on this! On Mon, Aug 04, 2014 at 02:35:26PM +0200, Jacek Anaszewski wrote: On 07/16/2014 11:54 PM, Sakari Ailus wrote: Hi Jacek, Jacek Anaszewski wrote: ... diff --git

Re: Re: [PATCH 1/4] support for DVBSky dvb-s2 usb: add some config andset_voltagefor m88ds3103

2014-08-07 Thread nibble.max
Moikka! On 08/07/2014 12:31 PM, nibble.max wrote: @@ -523,6 +508,17 @@ static int m88ds3103_set_frontend(struct dvb_frontend *fe) priv-delivery_system = c-delivery_system; + if (priv-cfg-start_ctrl) { + for (len = 0; len 30 ; len++) { +

[PATCH] au0828-input: Be sure that IR is enabled at polling

2014-08-07 Thread Mauro Carvalho Chehab
When the DVB code sets the frontend, it disables the IR INT, probably due to some hardware bug, as there's no code there at au8522 frontend that writes on register 0xe0. Fixing it at au8522 code is hard, as it doesn't know if the IR is enabled or disabled, and just restoring the value of register

Re: [PATCH] au0828-input: Be sure that IR is enabled at polling

2014-08-07 Thread Devin Heitmueller
On Thu, Aug 7, 2014 at 9:46 AM, Mauro Carvalho Chehab m.che...@samsung.com wrote: When the DVB code sets the frontend, it disables the IR INT, probably due to some hardware bug, as there's no code there at au8522 frontend that writes on register 0xe0. Fixing it at au8522 code is hard, as it

Re: [PATCH] au0828-input: Be sure that IR is enabled at polling

2014-08-07 Thread Mauro Carvalho Chehab
Em Thu, 07 Aug 2014 10:00:31 -0400 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: On Thu, Aug 7, 2014 at 9:46 AM, Mauro Carvalho Chehab m.che...@samsung.com wrote: When the DVB code sets the frontend, it disables the IR INT, probably due to some hardware bug, as there's no code

Re: [PATCH] au0828-input: Be sure that IR is enabled at polling

2014-08-07 Thread Devin Heitmueller
Well, au8522_rc_set is defined as: #define au8522_rc_set(ir, reg, bit) au8522_rc_andor(ir, (reg), (bit), (bit)) Ah, ok. It's just a really poorly named macro. Nevermind then. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list:

Multiple devices with same SMBus address

2014-08-07 Thread Jean-Michel Hautbois
Hi, I have a custom board which has two LMH0303 SDI drivers on the same i2c bus. They are connected in some daisy chain form, like on the schematics in the datasheet on page 9 : http://www.ti.com/lit/ds/symlink/lmh0303.pdf My problem is how to declare these devices in the DT in order to set the

Re: [PATCH] au0828-input: Be sure that IR is enabled at polling

2014-08-07 Thread Mauro Carvalho Chehab
Em Thu, 07 Aug 2014 10:14:45 -0400 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: Well, au8522_rc_set is defined as: #define au8522_rc_set(ir, reg, bit) au8522_rc_andor(ir, (reg), (bit), (bit)) Ah, ok. It's just a really poorly named macro. Nevermind then. Yep.

Re: omap3isp device tree support

2014-08-07 Thread Alaganraj Sandhanam
Hi Sakari, Thanks for the patches. I'll try this... ThanksRegards, Alagan On Thu, Aug 7, 2014 at 5:48 AM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Alaganraj, On Wed, Aug 06, 2014 at 04:07:58AM +0530, alaganraj sandhanam wrote: Hi Laurent, Thanks for the info. what about

Re: 3.15.6 USB issue with pwc cam

2014-08-07 Thread Udo van den Heuvel
On 2014-08-04 11:17, Laurent Pinchart wrote: (CC'ing Hans de Goede, the pwc maintainer, and the linux-media mailing list) On Saturday 02 August 2014 15:10:01 Udo van den Heuvel wrote: Hello, I moved a PWC webcam to a USB3 port, and this happened: I get similar stuff when trying to use a

[PATCH 3/3] au0828: Enable IR for HVR-850.

2014-08-07 Thread Mauro Carvalho Chehab
HVR-850 also has a remote. Enable it. Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com --- drivers/media/usb/au0828/au0828-cards.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/au0828/au0828-cards.c b/drivers/media/usb/au0828/au0828-cards.c index

[PATCH 1/3] au0828: no need to sleep at the IR code.

2014-08-07 Thread Mauro Carvalho Chehab
This sleep was doing some debouncing on the original driver. This is not needed on Linux, because the RC core and the input layer already takes care of it. Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com --- drivers/media/usb/au0828/au0828-input.c | 2 -- 1 file changed, 2 deletions(-)

[PATCH 2/3] au0828: add an option to disable IR via modprobe parameter

2014-08-07 Thread Mauro Carvalho Chehab
The IR code increases the power consumption of the device. Allow to disable it via modprobe parameter. Signed-off-by: Mauro Carvalho Chehab m.che...@samsung.com --- drivers/media/usb/au0828/au0828-input.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 1/3] sp2: Add I2C driver for CIMaX SP2 common interface module

2014-08-07 Thread Antti Palosaari
On 08/06/2014 10:05 AM, Olli Salonen wrote: Driver for the CIMaX SP2 common interface chip. It is very much based on the existing cimax2 driver for cx23885, but should be more reusable. The product has been sold with name Atmel T90FJR as well and the data sheets for that chip seem to be

Re: [PATCH] em28xx: fix compiler warnings

2014-08-07 Thread Frank Schäfer
Am 07.08.2014 um 08:45 schrieb Hans Verkuil: On 08/05/2014 05:18 PM, Frank Schäfer wrote: Hi Hans, Am 05.08.2014 um 09:00 schrieb Hans Verkuil: Fix three compiler warnings: drivers/media/usb/em28xx/em28xx-input.c: In function ‘em28xx_i2c_ir_handle_key’:

Re: [PATCH 1/3] sp2: Add I2C driver for CIMaX SP2 common interface module

2014-08-07 Thread Olli Salonen
Thank you Antti for the review. I'll submit another version of the patch in the coming days. Cheers, -olli On 7 August 2014 19:28, Antti Palosaari cr...@iki.fi wrote: Reviewed-by: Antti Palosaari cr...@iki.fi None of those findings are critical. However I hope you double check and fix if

Re: [PATCH 3/4] support for DVBSky dvb-s2 usb: add dvb-usb-v2 driver for DVBSky dvb-s2 box

2014-08-07 Thread Antti Palosaari
Moikka! Biggest issue is that CIMax2 SP2 driver. Olli put all that stuff to own I2C driver recently. Could you took SP2 from patchwork and use it instead: https://patchwork.linuxtv.org/patch/25206/ https://patchwork.linuxtv.org/patch/25210/ It is not yet in mainline, but there should not be any

Re: [media:v4l_for_linus 393/499] tuner-core.c:undefined reference to `xc5000_attach'

2014-08-07 Thread Antti Palosaari
Mauro, could you look that one? There is now multiple reports for ~all those silicon tuners which are used by tuner.ko module (CONFIG MEDIA_TUNER). Even it blames SDR Kconfig tuner patch I made, it is not the real issue. In my understanding issue is that tuner.ko is build-in and those tuner

cron job: media_tree daily build: WARNINGS

2014-08-07 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Aug 8 04:00:28 CEST 2014 git branch: test git hash: 0f3bf3dc1ca394a8385079a5653088672b65c5c4 gcc

Re: Re: [PATCH 3/4] support for DVBSky dvb-s2 usb: add dvb-usb-v2 driverfor DVBSky dvb-s2 box

2014-08-07 Thread nibble.max
Moikka! Moikka! Biggest issue is that CIMax2 SP2 driver. Olli put all that stuff to own I2C driver recently. Could you took SP2 from patchwork and use it instead: https://patchwork.linuxtv.org/patch/25206/ https://patchwork.linuxtv.org/patch/25210/ Yes, the CIMax2 SP2 code here is the same as

3.15.8 USB issue with uvc cam

2014-08-07 Thread Udo van den Heuvel
Hello, I get WARNINGs when trying to use a Logitech C615 cam. See attachment for full dmesg of errors but excerpt below: [80346.835015] xhci_hcd :02:00.0: ERROR: unexpected command completion code 0x11. [80346.835027] usb 6-2: Not enough bandwidth for altsetting 11 [80346.835137]

[PATCH 1/4 v2] support for DVBSky dvb-s2 usb: Add ts clock and clock polarity, lnb set voltage for m88ds3103

2014-08-07 Thread nibble.max
Add ts clock and clock polarity, lnb set voltage. Signed-off-by: Nibble Max nibble@gmail.com --- drivers/media/dvb-frontends/m88ds3103.c | 77 + drivers/media/dvb-frontends/m88ds3103.h | 25 --- 2 files changed, 70 insertions(+), 32 deletions(-) diff

[PATCH 3/4 v2] support for DVBSky dvb-s2 usb: add dvb-usb-v2 driver for DVBSky dvb-s2 box, no ci support.

2014-08-07 Thread nibble.max
remove ci support part in v1 patch. hook demod read status and set voltage operations. Signed-off-by: Nibble Max nibble@gmail.com --- drivers/media/usb/dvb-usb-v2/Kconfig | 6 + drivers/media/usb/dvb-usb-v2/Makefile | 3 + drivers/media/usb/dvb-usb-v2/dvbsky.c | 455

Re: [PATCH 3/4] support for DVBSky dvb-s2 usb: add dvb-usb-v2 driver for DVBSky dvb-s2 box

2014-08-07 Thread Olli Salonen
Hi Max, nibble.max nibble.max at gmail.com writes: diff --git a/drivers/media/usb/dvb-usb-v2/Kconfig b/drivers/media/usb/dvb-usb-v2/Kconfig index 66645b0..8107c8d 100644 --- a/drivers/media/usb/dvb-usb-v2/Kconfig +++ b/drivers/media/usb/dvb-usb-v2/Kconfig at at -141,3 +141,9 at at

Re: Re: [PATCH 3/4] support for DVBSky dvb-s2 usb: add dvb-usb-v2 driver for DVBSky dvb-s2 box

2014-08-07 Thread nibble.max
Hello Olli, Hi Max, nibble.max nibble.max at gmail.com writes: diff --git a/drivers/media/usb/dvb-usb-v2/Kconfig b/drivers/media/usb/dvb-usb-v2/Kconfig index 66645b0..8107c8d 100644 --- a/drivers/media/usb/dvb-usb-v2/Kconfig +++ b/drivers/media/usb/dvb-usb-v2/Kconfig at at -141,3 +141,9

[PATCH 3/4 v3] support for DVBSky dvb-s2 usb: add dvb-usb-v2 driver for DVBSky dvb-s2 box, no ci support.

2014-08-07 Thread nibble.max
remove ci support part in v1 patch. hook demod read status and set voltage operations. add m88ts2022 select in Kconfig. Signed-off-by: Nibble Max nibble@gmail.com --- drivers/media/usb/dvb-usb-v2/Kconfig | 7 + drivers/media/usb/dvb-usb-v2/Makefile | 3 +