tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 3c2ea7024a686e9e7121ef6405da7412619a98f5
commit: 1c59390b3b551524d4c8415bd39c9c788705c7c0 [media] cx23885: use IS_ENABLED
date: 1 year, 6 months ago
config: x86_64-randconfig-wa0-0922 (attached as .config)
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Sun Sep 21 04:00:24 CEST 2014
git branch: test
git hash: f5281fc81e9a0a3e80b78720c5ae2ed06da3bfae
gcc versi
Hi Hans,
Thank you for the patches.
Acked-by: Laurent Pinchart
On Saturday 20 September 2014 21:16:34 Hans Verkuil wrote:
> OK, so v1 wasn't the final patch series :-) Let's see if this is.
>
> Changes since v1:
>
> - Also initialize waiting_for_buffers in STREAMOFF and when CREATE_BUFS is
>
Hi Hans,
Thank you for the patch.
On Saturday 20 September 2014 21:16:35 Hans Verkuil wrote:
> From: Hans Verkuil
>
> The recent conversion of saa7134 to vb2 unconvered a poll() bug that
> broke the teletext applications alevt and mtt. These applications
> expect that calling poll() without hav
From: Hans Verkuil
The poll documentation was incomplete: document how events (POLLPRI)
are handled and fix the documentation of what poll does for display devices
and streaming I/O.
Signed-off-by: Hans Verkuil
---
Documentation/DocBook/media/v4l/func-poll.xml | 23 +++
1 f
OK, so v1 wasn't the final patch series :-) Let's see if this is.
Changes since v1:
- Also initialize waiting_for_buffers in STREAMOFF and when CREATE_BUFS is
called and no buffers have been allocated yet.
- Improve some of the wording in patch 2 based on suggestions from Laurent.
This patch s
From: Hans Verkuil
The recent conversion of saa7134 to vb2 unconvered a poll() bug that
broke the teletext applications alevt and mtt. These applications
expect that calling poll() without having called VIDIOC_STREAMON will
cause poll() to return POLLERR. That did not happen in vb2.
This patch f
From: Hans Verkuil
Clarify what poll() returns if STREAMON was called but not QBUF.
Make explicit the different behavior for this scenario for
capture and output devices.
Signed-off-by: Hans Verkuil
---
Documentation/DocBook/media/v4l/func-poll.xml | 12 ++--
1 file changed, 10 inserti
On 09/20/2014 08:32 PM, Laurent Pinchart wrote:
> Hi Hans,
>
> Thank you for the patch.
>
> On Saturday 20 September 2014 10:56:13 Hans Verkuil wrote:
>> From: Hans Verkuil
>>
>> The recent conversion of saa7134 to vb2 unconvered a poll() bug that
>> broke the teletext applications alevt and mtt
Hi Hans,
Thank you for the patch.
On Saturday 20 September 2014 10:56:14 Hans Verkuil wrote:
> From: Hans Verkuil
>
> Clarify what poll() returns if STREAMON was called but not QBUF.
> Make explicit the different behavior for this scenario for
> capture and output devices.
>
> Signed-off-by: H
Hi Hans,
Thank you for the patch.
On Saturday 20 September 2014 10:56:13 Hans Verkuil wrote:
> From: Hans Verkuil
>
> The recent conversion of saa7134 to vb2 unconvered a poll() bug that
> broke the teletext applications alevt and mtt. These applications
> expect that calling poll() without hav
From: Hans Verkuil
Tested VBI support and discovered that the wrong offset was used.
After this change it is now working. Verified with CC/XDS for NTSC
and WSS/Teletext on PAL.
It also reported the wrong start lines for the second field. That's
now fixed as well.
Signed-off-by: Hans Verkuil
--
These two patches were part of the cx23885 v2 patch series that converted
the driver to vb2, but were left out when that series was merged. Mauro
had some questions about the size helper functions and I wanted to double
check the VBI changes with closed captioning in NTSC.
I figured out what was g
From: Hans Verkuil
The norm_swidth function was unused and is dropped. It's not clear
what the purpose of that function was.
The norm_maxh function was changed so it tests for 60 Hz standards
rather than for 50 Hz standards. The is the preferred order.
The norm_maxw function was poorly written
Hi Laurent,
Even with "nodrop=1" the framerate is still stuck at ~12fps when it
should be ~30fps. I ran "/yavta -c -f Y800 -s 1280x960 /dev/video0" to
test the camera fps.
Here is the YAVTA output for nodrop=0: http://pastebin.com/bQZcJ0Fd
Here is the YAVTA output for nodrop=1: http://pastebin.co
The v4l2_ctrl_config struct must be zeroed before passing it to
v4l2_ctrl_new_custom(). This was always wrong, but with the recent
v4l2-ctrls.c changes this is now much more likely to lead to a
kernel bug.
This is the only place where this struct wasn't initialized properly.
Signed-off-by: Hans V
From: Hans Verkuil
There is no reason to dump the sram code to the kernel log when you
stop streaming. Remove those calls to cx88_sram_channel_dump.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/cx88/cx88-vbi.c | 2 --
drivers/media/pci/cx88/cx88-video.c | 2 --
2 files changed, 4 deleti
From: Hans Verkuil
The vb2 framework knows if streaming is in progress, no need to use
a separate field for that.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/cx88/cx88-blackbird.c | 11 +--
drivers/media/pci/cx88/cx88.h | 1 -
2 files changed, 5 insertions(+), 7 deleti
From: Hans Verkuil
Remove this function. This makes all vb2 queues behave the same, which
simplifies comparing the various vb2 queue op implementations.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/cx88/cx88-blackbird.c | 2 +-
drivers/media/pci/cx88/cx88-core.c | 7 ---
drivers/
From: Hans Verkuil
drivers/media/pci/cx88/cx88-blackbird.c:476:25: warning: cast to restricted
__le32
Signed-off-by: Hans Verkuil
---
drivers/media/pci/cx88/cx88-blackbird.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/pci/cx88/cx88-blackbird.c
b/driv
From: Hans Verkuil
The timeout is way too small. Especially complicated command like
CX2341X_ENC_STOP_CAPTURE takes much more time than 10 ms. Increase the
timeout to 1 second, just as ivtv does (the cx88-blackbird has the
same IP core for MPEG compression as ivtv).
This solves a nasty issue whe
From: Hans Verkuil
As usual, this patch is very large due to the fact that half a vb2 conversion
isn't possible. And since this affects blackbird, alsa, core, dvb, vbi and
video the changes are all over.
What made this more difficult was the peculiar way the risc program was setup.
The driver al
From: Hans Verkuil
The width, height and field values are core fields since both vbi, video
and blackbird use the same video input.
Move those fields to the correct struct.
Also fix the field checks in the try_fmt functions: add V4L2_FIELD_SEQ_BT/TB
support and map incorrect field values to a c
From: Hans Verkuil
Don't return -1, return a proper error.
Replace dprintk(0, ...) by pr_err since firmware load errors should just be
reported as an error.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/cx88/cx88-blackbird.c | 32 +++-
1 file changed, 15 insert
From: Hans Verkuil
btcx-risc is for the bt8xx driver and other drivers shouldn't depend
on it. There is no benefit to use that module just to do a
pci_zalloc_consistent.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/cx88/Kconfig | 1 -
drivers/media/pci/cx88/Makefile | 1
From: Hans Verkuil
Make sure that changing the standard or format is not allowed while
one or more of the video, vbi or mpeg vb2 queues are busy.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/cx88/cx88-blackbird.c | 8 ++--
drivers/media/pci/cx88/cx88-core.c | 7 +++
drivers
From: Hans Verkuil
Don't mix UNSET and TUNER_ABSENT: you have to pick one or the other. For
this driver selecting UNSET to represent an absent tuner resulting in
the fewest changes.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/cx88/cx88-cards.c | 66 ++---
From: Hans Verkuil
Move pci_disable_device() down otherwise it will complain about an
unfreed irq.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/cx88/cx88-video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/cx88/cx88-video.c
b/drivers/media/pci/cx
From: Hans Verkuil
Now works with both NTSC and PAL. Tested with CC/XDS for NTSC and
teletext/WSS for PAL. The start lines were wrong, the WSS signal
wasn't captured and there was no difference between NTSC and PAL
w.r.t. the count[] values so NTSC returned way too many lines.
Signed-off-by: Han
From: Hans Verkuil
This list is used some buffers have a different format, but that can
never happen. Remove it and all associated code.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/cx88/cx88-mpeg.c | 31 -
drivers/media/pci/cx88/cx88-video.c | 39 +++-
From: Hans Verkuil
This is a duplicate of dev->fmt and can be removed. As a consequence a
lot of tests that check if the format has changed midstream can be
removed as well: the format cannot change midstream, so this is a bogus
check.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/cx88/cx8
From: Hans Verkuil
The alsa driver uses videobuf low-level functions that are not
available in vb2, so replace them by driver-specific functions.
Signed-off-by: Hans Verkuil
---
drivers/media/pci/cx88/cx88-alsa.c | 107 ++---
1 file changed, 89 insertions(+), 18
This patch series converts the cx88 driver to vb2. Tested with NTSC and
PAL, video, vbi, audio, mpeg and dvb-t on a Hauppauge WinTV-HVR3000 and
a Hauppauge WinTV-HVR1300.
I see this as something for 3.19 so that there is enough time for testing
since this is a popular card.
Regards,
Hans
When I try to set the TV standard to e.g. PAL on my Hauppauge WinTV-HVR3000 I
get
the following oops:
9464.262345] CX24123: detected CX24123
[ 9464.262526] BUG: unable to handle kernel NULL pointer dereference at
0230
[ 9464.262555] IP: [] acpi_i2c_install_space_handler+0x15/0xc0
[
> > That sounds plausible wrt timeframe, but if cx23885 only started using vb2
> > after Sept 8 then it couldn't have affected me before then right?
>
> You are right about that. You are using DVB right? Not analog video? (Just to
> be 100% certain).
>
Yes. Australia mostly has no analog anymore
> > I was looking through the patches and saw a date of August 14 on the
> > cx23885 to vb2 patch and thought that could have been around when it
> > started breaking, but then the
> > 73d8102298719863d54264f62521362487f84256 is dated September 3 and I'm
> > pretty sure it had started playing up be
Moikka!
On 09/19/2014 10:55 PM, Luca Olivetti wrote:
El 19/09/14 21:22, Frank Schäfer ha escrit:
So symbol_request() returns pointers.!= NULL
A closer look at the definition of symbol_request() shows, that it does
nothing if CONFIG_MODULES is disabled (it just returns its argument).
One po
On 09/20/2014 01:05 PM, James Harper wrote:
>>> I was looking through the patches and saw a date of August 14 on the
>>> cx23885 to vb2 patch and thought that could have been around when it
>>> started breaking, but then the
>>> 73d8102298719863d54264f62521362487f84256 is dated September 3 and I'm
On 09/20/2014 12:30 PM, James Harper wrote:
>>> Oops I should have mentioned that. I'm using Debian "Jessie" with
>>> 3.16 kernel and already using the latest v4l as per link you sent (my
>>> DViCO FusionHDTV DVB-T Dual Express2 patch is in 3.17 I think, but
>>> that's not in Debian yet).
>>
>> Ah,
tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 46be7b73e82453447cd97b3440d523159eab09f8
commit: 7b34be71db533f3e0cf93d53cf62d036cdb5418a [media] use IS_ENABLED() macro
date: 1 year, 7 months ago
config: x86_64-randconfig-hsb1-09201827 (attached as .config)
This patch series supercedes https://patchwork.linuxtv.org/patch/25954/.
After working on it a bit more I realized that that patch didn't really
address the core issues.
Besides the il_vbackporch typo there was a too strict check in
v4l2_valid_dv_timings() where it checked for compatible standards
From: Hans Verkuil
Both adv7604 and adv7842 had the same typo in the code that sets
the vertical backporch for the second interlaced field: it was
assigned to vbackporch instead of il_vbackporch.
In addition, the timings struct wasn't zeroed in the adv7842 driver,
leaving several fields to undef
From: Hans Verkuil
If one or both of the timings being compared have the standards field
with value 0, then accept that. Only check for matching standards if
both timings have actually filled in that field.
Otherwise no match will ever be found since when timings are detected
the standards field
> > Oops I should have mentioned that. I'm using Debian "Jessie" with
> > 3.16 kernel and already using the latest v4l as per link you sent (my
> > DViCO FusionHDTV DVB-T Dual Express2 patch is in 3.17 I think, but
> > that's not in Debian yet).
>
> Ah, yes, that's rather important information :-)
Em Sat, 20 Sep 2014 07:08:08 -0300
Mauro Carvalho Chehab escreveu:
> Em Sat, 20 Sep 2014 11:14:16 +0200
> Hans Verkuil escreveu:
>
> > On 09/20/2014 11:08 AM, James Harper wrote:
> > >>
> > >> The recent conversion of saa7134 to vb2 unconvered a poll() bug that
> > >> broke the teletext applica
On 09/20/2014 11:26 AM, James Harper wrote:
>>
>> On 09/20/2014 05:32 AM, James Harper wrote:
>>>
>>> My cx23885 based DViCO FusionHDTV DVB-T Dual Express2 (I submitted a
>>> patch for this a little while ago) has been working great but over
>>> the last few months it has started playing up. Nothin
Em Sat, 20 Sep 2014 11:14:16 +0200
Hans Verkuil escreveu:
> On 09/20/2014 11:08 AM, James Harper wrote:
> >>
> >> The recent conversion of saa7134 to vb2 unconvered a poll() bug that
> >> broke the teletext applications alevt and mtt. These applications
> >> expect that calling poll() without hav
Em Sat, 20 Sep 2014 11:14:16 +0200
Hans Verkuil escreveu:
> On 09/20/2014 11:08 AM, James Harper wrote:
> >>
> >> The recent conversion of saa7134 to vb2 unconvered a poll() bug that
> >> broke the teletext applications alevt and mtt. These applications
> >> expect that calling poll() without hav
Em Sat, 20 Sep 2014 09:26:23 +
James Harper escreveu:
> >
> > On 09/20/2014 05:32 AM, James Harper wrote:
> > >
> > > My cx23885 based DViCO FusionHDTV DVB-T Dual Express2 (I submitted a
> > > patch for this a little while ago) has been working great but over
> > > the last few months it has
Em Sat, 20 Sep 2014 10:56:12 +0200
Hans Verkuil escreveu:
> OK, this is the final (?) patch series to resolve the vb2 VBI poll regression
> where alevt and mtt fail on drivers using vb2.
>
> These applications call REQBUFS, queue the buffers and then poll() without
> calling STREAMON first. They
>
> On 09/20/2014 05:32 AM, James Harper wrote:
> >
> > My cx23885 based DViCO FusionHDTV DVB-T Dual Express2 (I submitted a
> > patch for this a little while ago) has been working great but over
> > the last few months it has started playing up. Nothing has really
> > changed that I can put my fi
On 09/20/2014 05:32 AM, James Harper wrote:
>
> My cx23885 based DViCO FusionHDTV DVB-T Dual Express2 (I submitted a
> patch for this a little while ago) has been working great but over
> the last few months it has started playing up. Nothing has really
> changed that I can put my finger on. Basic
On 09/20/2014 01:51 AM, beta992 wrote:
> Hauppauge HVR-5500 using the latest git build, keeps crashing with the
> following error:
Fixed in this patch:
https://patchwork.linuxtv.org/patch/25123/
Should have been merged quite some time ago but we discovered a few days
ago that this one fell betwe
On 09/20/2014 11:08 AM, James Harper wrote:
>>
>> The recent conversion of saa7134 to vb2 unconvered a poll() bug that
>> broke the teletext applications alevt and mtt. These applications
>> expect that calling poll() without having called VIDIOC_STREAMON will
>> cause poll() to return POLLERR. Tha
This is useful to test teletext capture applications like alevt and mtt.
It also fixes a previously undetected bug where the PAL VBI start line
of the second field was off by one. Using the new field start defines
helps a lot fixing such bugs.
Signed-off-by: Hans Verkuil
---
Documentation/video
>
> The recent conversion of saa7134 to vb2 unconvered a poll() bug that
> broke the teletext applications alevt and mtt. These applications
> expect that calling poll() without having called VIDIOC_STREAMON will
> cause poll() to return POLLERR. That did not happen in vb2.
>
> This patch fixes t
From: Hans Verkuil
The recent conversion of saa7134 to vb2 unconvered a poll() bug that
broke the teletext applications alevt and mtt. These applications
expect that calling poll() without having called VIDIOC_STREAMON will
cause poll() to return POLLERR. That did not happen in vb2.
This patch f
From: Hans Verkuil
The poll documentation was incomplete: document how events (POLLPRI)
are handled and fix the documentation of what poll does for display devices
and streaming I/O.
Signed-off-by: Hans Verkuil
---
Documentation/DocBook/media/v4l/func-poll.xml | 23 +++
1 f
From: Hans Verkuil
Clarify what poll() returns if STREAMON was called but not QBUF.
Make explicit the different behavior for this scenario for
capture and output devices.
Signed-off-by: Hans Verkuil
---
Documentation/DocBook/media/v4l/func-poll.xml | 12 ++--
1 file changed, 10 inserti
OK, this is the final (?) patch series to resolve the vb2 VBI poll regression
where alevt and mtt fail on drivers using vb2.
These applications call REQBUFS, queue the buffers and then poll() without
calling STREAMON first. They rely on poll() to return POLLERR in that case
and they do the STREAMO
Hi Kobayashi-san,
Thanks for the patch. In principle it looks good, just one question below:
On Thu, 11 Sep 2014, Kazunori Kobayashi wrote:
> This patch allows for exporting a dmabuf descriptor from soc_camera drivers.
>
> Signed-off-by: Kazunori Kobayashi
> ---
> drivers/media/platform/soc_c
Hi Philippe,
On Thu, 11 Sep 2014, Philipp Zabel wrote:
> In preparation for a following patch, stop decrementing the endpoint node
> refcount in the loop. This temporarily leaks a reference to the endpoint node,
> which will be fixed by having of_graph_get_next_endpoint decrement the
> refcount
62 matches
Mail list logo
