Re: [PATCH v2] media: ti-vpe: Use mem-to-mem ioctl helpers
Hello Hans/Kamil, On Fri, Dec 19, 2014 at 1:52 PM, Lad, Prabhakar prabhakar.cse...@gmail.com wrote: 1: Simplify the vpe mem-to-mem driver by using the m2m ioctl and vb2 helpers. 2: Align and arranged the v4l2_ioctl_ops. 3: Fixes a typo. 4: Use of_match_ptr() instead of explicitly defining the macro to NULL in case CONFIG_OF is not defined. Can you please review and queue this patch for v3.20 ? Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference
2015-01-30 14:09 GMT+01:00 valdis.kletni...@vt.edu:
On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said:
- if (ir == NULL) {
- dev_err(ir-l.dev, close: no private_data attached to the file
!\n);
Yes, the dev_err() call is an obvious thinko.
However, I'm not sure whether removing it entirely is right either. If
there *should* be a struct IR * passed there, maybe some other printk()
should be issued, or even a WARN_ON(!ir), or something?
We set filep-private_data to non-NULL in open() so I don't think it can
be NULL here.
Then probably the *right* fix is to remove the *entire* if statement, as
we can't end up doing the 'return -ENODEV'
Hi
Ok, but think or know. Who knows?
Do the remove if patch?
Kind regards
Rickard Strandqvist
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] media: ti-vpe: Use mem-to-mem ioctl helpers
Hi Prabhakar, I might have time on Monday, but that is almost certainly too late for 3.20. It's a bit busy at the moment. Sorry, Hans On 01/30/2015 04:54 PM, Lad, Prabhakar wrote: Hello Hans/Kamil, On Fri, Dec 19, 2014 at 1:52 PM, Lad, Prabhakar prabhakar.cse...@gmail.com wrote: 1: Simplify the vpe mem-to-mem driver by using the m2m ioctl and vb2 helpers. 2: Align and arranged the v4l2_ioctl_ops. 3: Fixes a typo. 4: Use of_match_ptr() instead of explicitly defining the macro to NULL in case CONFIG_OF is not defined. Can you please review and queue this patch for v3.20 ? Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] media: i2c: add support for omnivision's ov2659 sensor
Hello, On Thu, Jan 15, 2015 at 11:39 PM, Lad, Prabhakar prabhakar.cse...@gmail.com wrote: From: Benoit Parrot bpar...@ti.com this patch adds support for omnivision's ov2659 sensor. Signed-off-by: Benoit Parrot bpar...@ti.com Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- .../devicetree/bindings/media/i2c/ov2659.txt | 33 + .../devicetree/bindings/vendor-prefixes.txt|1 + MAINTAINERS| 10 + drivers/media/i2c/Kconfig | 11 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov2659.c | 1623 include/media/ov2659.h | 33 + 7 files changed, 1712 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2659.txt create mode 100644 drivers/media/i2c/ov2659.c create mode 100644 include/media/ov2659.h gentle ping for review comments. Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/15] media: blackfin: bfin_capture enhancements
Hello Scott, On Thu, Jan 22, 2015 at 10:18 PM, Lad, Prabhakar prabhakar.cse...@gmail.com wrote: This patch series, enhances blackfin capture driver with vb2 helpers. Changes for v2: -- Only patches 5/15 and 8/15 as per Scott's suggestions. Lad, Prabhakar (15): media: blackfin: bfin_capture: drop buf_init() callback media: blackfin: bfin_capture: release buffers in case start_streaming() call back fails media: blackfin: bfin_capture: set min_buffers_needed media: blackfin: bfin_capture: improve buf_prepare() callback media: blackfin: bfin_capture: improve queue_setup() callback media: blackfin: bfin_capture: use vb2_fop_mmap/poll media: blackfin: bfin_capture: use v4l2_fh_open and vb2_fop_release media: blackfin: bfin_capture: use vb2_ioctl_* helpers media: blackfin: bfin_capture: make sure all buffers are returned on stop_streaming() callback media: blackfin: bfin_capture: return -ENODATA for *std calls media: blackfin: bfin_capture: return -ENODATA for *dv_timings calls media: blackfin: bfin_capture: add support for vidioc_create_bufs media: blackfin: bfin_capture: add support for VB2_DMABUF media: blackfin: bfin_capture: add support for VIDIOC_EXPBUF media: blackfin: bfin_capture: set v4l2 buffer sequence drivers/media/platform/blackfin/bfin_capture.c | 311 - 1 file changed, 99 insertions(+), 212 deletions(-) Can you ACK the series ? so that its easier for Hans to pick it up. Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
cron job: media_tree daily build: OK
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Jan 31 04:00:16 CET 2015 git branch: test git hash: a5f43c18fceb2b96ec9fddb4348f5282a71cf2b0 gcc version:i686-linux-gcc (GCC) 4.9.1 sparse version: v0.5.0-41-g6c2d743 smatch version: 0.4.1-3153-g7d56ab3 host hardware: x86_64 host os:3.18.0-1.slh.1-amd64 linux-git-arm-at91: OK linux-git-arm-davinci: OK linux-git-arm-exynos: OK linux-git-arm-mx: OK linux-git-arm-omap: OK linux-git-arm-omap1: OK linux-git-arm-pxa: OK linux-git-blackfin: OK linux-git-i686: OK linux-git-m32r: OK linux-git-mips: OK linux-git-powerpc64: OK linux-git-sh: OK linux-git-x86_64: OK linux-2.6.32.27-i686: OK linux-2.6.33.7-i686: OK linux-2.6.34.7-i686: OK linux-2.6.35.9-i686: OK linux-2.6.36.4-i686: OK linux-2.6.37.6-i686: OK linux-2.6.38.8-i686: OK linux-2.6.39.4-i686: OK linux-3.0.60-i686: OK linux-3.1.10-i686: OK linux-3.2.37-i686: OK linux-3.3.8-i686: OK linux-3.4.27-i686: OK linux-3.5.7-i686: OK linux-3.6.11-i686: OK linux-3.7.4-i686: OK linux-3.8-i686: OK linux-3.9.2-i686: OK linux-3.10.1-i686: OK linux-3.11.1-i686: OK linux-3.12.23-i686: OK linux-3.13.11-i686: OK linux-3.14.9-i686: OK linux-3.15.2-i686: OK linux-3.16-i686: OK linux-3.17.8-i686: OK linux-3.18-i686: OK linux-3.19-rc4-i686: OK linux-2.6.32.27-x86_64: OK linux-2.6.33.7-x86_64: OK linux-2.6.34.7-x86_64: OK linux-2.6.35.9-x86_64: OK linux-2.6.36.4-x86_64: OK linux-2.6.37.6-x86_64: OK linux-2.6.38.8-x86_64: OK linux-2.6.39.4-x86_64: OK linux-3.0.60-x86_64: OK linux-3.1.10-x86_64: OK linux-3.2.37-x86_64: OK linux-3.3.8-x86_64: OK linux-3.4.27-x86_64: OK linux-3.5.7-x86_64: OK linux-3.6.11-x86_64: OK linux-3.7.4-x86_64: OK linux-3.8-x86_64: OK linux-3.9.2-x86_64: OK linux-3.10.1-x86_64: OK linux-3.11.1-x86_64: OK linux-3.12.23-x86_64: OK linux-3.13.11-x86_64: OK linux-3.14.9-x86_64: OK linux-3.15.2-x86_64: OK linux-3.16-x86_64: OK linux-3.17.8-x86_64: OK linux-3.18-x86_64: OK linux-3.19-rc4-x86_64: OK apps: OK spec-git: OK sparse: WARNINGS smatch: ERRORS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Saturday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Saturday.tar.bz2 The Media Infrastructure API from this daily build is here: http://www.xs4all.nl/~hverkuil/spec/media.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference
On Fri, 2015-01-30 at 08:09 -0500, valdis.kletni...@vt.edu wrote:
On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said:
- if (ir == NULL) {
- dev_err(ir-l.dev, close: no private_data attached to
the file
!\n);
commit be4aa8157c981a8bb9634b886bf1180f97205259
removed the dprintk(), which didn't depend on ir-l.dev, with this
dev_err() call. That was the wrong thing to do. pr_info() is probably
the right thing to use, if one doesn't have a struct device instance.
Yes, the dev_err() call is an obvious thinko.
However, I'm not sure whether removing it entirely is right either. If
there *should* be a struct IR * passed there, maybe some other printk()
should be issued, or even a WARN_ON(!ir), or something?
We set filep-private_data to non-NULL in open() so I don't think it can
be NULL here.
Then probably the *right* fix is to remove the *entire* if statement, as
we can't end up doing the 'return -ENODEV'
The if() clause is here as an artifact of being part of a mass port of
lirc drivers from userspace. I never removed it, because I needed it
when fixing all the lirc_zilog.c ref counting.
IF I got all the lirc_zilog ref counting right, and the upper layers of
the kernel never call close() in error, then this if() statement is not
needed.
I welcome anyone wishing to audit the ref-counting in lirc_zilog. It
was mentally exhausting to get to what I think is right. Maybe I just
tire easily mentally though. :)
-Andy
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL] mem2mem changes
The following changes since commit a5f43c18fceb2b96ec9fddb4348f5282a71cf2b0: [media] Documentation/video4linux: remove obsolete text files (2015-01-29 19:16:30 -0200) are available in the git repository at: git://linuxtv.org/kdebski/media_tree_2.git for-3.20-a for you to fetch changes up to 403655cc66ee4497cdd7045d71bf1376e88c5909: coda: simplify check in coda_buf_queue (2015-01-30 15:14:55 +0100) Fabian Frederick (2): s5p-g2d: remove unnecessary version.h inclusion s5p-mfc: remove unnecessary version.h inclusion Lucas Stach (1): coda: adjust sequence offset after unexpected decoded frame Markus Pargmann (1): coda: fix width validity check when starting to decode Nicolas Dufresne (3): s5p-mfc-v6+: Use display_delay_enable CID s5p-mfc-dec: Don't use encoder stop command media-doc: Fix MFC display delay control doc Philipp Zabel (18): coda: fix encoder rate control parameter masks coda: remove context debugfs entry last coda: move meta out of padding coda: fix job_ready debug reporting for bitstream decoding coda: fix try_fmt_vid_out colorspace setting coda: properly clear f_cap in coda_s_fmt_vid_out coda: initialize SRAM on probe coda: clear RET_DEC_PIC_SUCCESS flag in prepare_decode coda: remove unused isequence, reset qsequence in stop_streaming coda: issue seq_end_work during stop_streaming coda: don't ever use subsampling ping-pong buffers as reconstructed reference buffers coda: add coda_estimate_sizeimage and use it in set_defaults coda: switch BIT decoder source queue to vmalloc coda: make seq_end_work optional coda: free context buffers under buffer mutex coda: add support for contexts that do not use the BIT processor coda: allocate bitstream ringbuffer only for BIT decoder coda: simplify check in coda_buf_queue Documentation/DocBook/media/v4l/controls.xml| 11 +- drivers/media/platform/Kconfig |1 + drivers/media/platform/coda/coda-bit.c | 25 +++- drivers/media/platform/coda/coda-common.c | 159 +++ drivers/media/platform/coda/coda.h |2 +- drivers/media/platform/coda/coda_regs.h |4 +- drivers/media/platform/s5p-g2d/g2d.c|1 - drivers/media/platform/s5p-mfc/s5p_mfc_dec.c|3 +- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c|1 - drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c |6 +- 10 files changed, 136 insertions(+), 77 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference
On Thu, Jan 29, 2015 at 05:12:40PM -0500, valdis.kletni...@vt.edu wrote:
On Thu, 29 Jan 2015 19:48:08 +0100, Rickard Strandqvist said:
Fix a possible null pointer dereference, there is
otherwise a risk of a possible null pointer dereference.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se
---
drivers/staging/media/lirc/lirc_zilog.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
/* find our IR struct */
struct IR *ir = filep-private_data;
- if (ir == NULL) {
- dev_err(ir-l.dev, close: no private_data attached to the
file!\n);
Yes, the dev_err() call is an obvious thinko.
However, I'm not sure whether removing it entirely is right either. If
there *should* be a struct IR * passed there, maybe some other printk()
should be issued, or even a WARN_ON(!ir), or something?
We set filep-private_data to non-NULL in open() so I don't think it can
be NULL here.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference
On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said:
- if (ir == NULL) {
- dev_err(ir-l.dev, close: no private_data attached to the file
!\n);
Yes, the dev_err() call is an obvious thinko.
However, I'm not sure whether removing it entirely is right either. If
there *should* be a struct IR * passed there, maybe some other printk()
should be issued, or even a WARN_ON(!ir), or something?
We set filep-private_data to non-NULL in open() so I don't think it can
be NULL here.
Then probably the *right* fix is to remove the *entire* if statement, as
we can't end up doing the 'return -ENODEV'
pgpp86y4WHJ_X.pgp
Description: PGP signature
