Re: [PATCHv4 00/25] dvb core: add basic support for the media controller
On 02/13/2015 11:57 PM, Mauro Carvalho Chehab wrote: This patch series adds basic support for the media controller at the DVB core: it creates one media entity per DVB devnode, if the media device is passed as an argument to the DVB structures. The cx231xx driver was modified to pass such argument for DVB NET, DVB frontend and DVB demux. - version 4: - Addressed the issues pointed via e-mail No, you didn't. Especially with regards to the alsa node definition. I'm pretty sure you need at least the subdevice information which is now removed. I also do *not* like the fact that you posted a v4 and immediately applied these patches to the master without leaving any time for more discussions. These patches change the kernel API and need to go to proper review and need a bunch of Acks, Laurent's at the very minimum since he's MC maintainer. Please revert the whole patch series from master, then we can discuss this more. For the record, for patch 02/25: Nacked-by: Hans Verkuil hans.verk...@cisco.com I do *not* agree with this API change. We can discuss this more on Monday. Regards, Hans - Added a separate Kconfig option to enable media controller DVB experimental support - Fixed some CodingStyle issues - Added documentation for the API changes at the DocBook version 3: - Added the second series of patches (add link graph to cx231xx using the media controller) - tuner-core and cx25840: add proper error handling as suggested by Sakari Ailus and pointed by Joe Perches; - dvb core: move the media_dev struct to be inside the DVB adapter. That allowed to simplify the changes for the dvbdev clients; - Add logic to setup the pipelines when analog or digital TV stream starts. - Renamed some patches to better describe its contents. version 2: - Now the PADs are created for all nodes - Instead of using entity-flags for subtypes, create separate MEDIA_ENT_T_DEVNODE_DVB_foo for each DVB devtype - The API change patch was split from the DVB core changes Mauro Carvalho Chehab (24): [media] media: Fix DVB devnode representation at media controller [media] Docbook: Fix documentation for media controller devnodes [media] media: add new types for DVB devnodes [media] DocBook: Document the DVB API devnodes at the media controller [media] media: add a subdev type for tuner [media] DocBook: Add tuner subdev at documentation [media] dvbdev: add support for media controller [media] cx231xx: add media controller support [media] dvb_frontend: add media controller support for DVB frontend [media] dmxdev: add support for demux/dvr nodes at media controller [media] dvb_ca_en50221: add support for CA node at the media controller [media] dvb_net: add support for DVB net node at the media controller [media] dvbdev: add pad for the DVB devnodes [media] tuner-core: properly initialize media controller subdev [media] cx25840: fill the media controller entity [media] cx231xx: initialize video/vbi pads [media] cx231xx: create media links for analog mode [media] dvbdev: represent frontend with two pads [media] dvbdev: add a function to create DVB media graph [media] cx231xx: create DVB graph [media] dvbdev: enable DVB-specific links [media] dvb-frontend: enable tuner link when the FE thread starts [media] cx231xx: enable tuner-decoder link at videobuf start [media] dvb_frontend: start media pipeline while thread is running Zhangfei Gao (1): [media] ir-hix5hd2: remove writel/readl_relaxed define .../DocBook/media/v4l/media-ioc-enum-entities.xml | 102 --- Documentation/DocBook/media/v4l/v4l2.xml | 9 ++ drivers/media/Kconfig | 10 +- drivers/media/dvb-core/dmxdev.c| 11 +- drivers/media/dvb-core/dvb_ca_en50221.c| 6 +- drivers/media/dvb-core/dvb_frontend.c | 121 - drivers/media/dvb-core/dvb_net.c | 6 +- drivers/media/dvb-core/dvbdev.c| 143 - drivers/media/dvb-core/dvbdev.h| 15 +++ drivers/media/i2c/cx25840/cx25840-core.c | 18 +++ drivers/media/i2c/cx25840/cx25840-core.h | 3 + drivers/media/rc/ir-hix5hd2.c | 8 -- drivers/media/usb/cx231xx/cx231xx-cards.c | 98 +- drivers/media/usb/cx231xx/cx231xx-dvb.c| 5 + drivers/media/usb/cx231xx/cx231xx-video.c | 84 +++- drivers/media/usb/cx231xx/cx231xx.h| 5 + drivers/media/v4l2-core/tuner-core.c | 20 +++ drivers/media/v4l2-core/v4l2-dev.c | 4 +- drivers/media/v4l2-core/v4l2-device.c | 4 +- include/media/media-entity.h | 12 +- include/uapi/linux/media.h | 26 +++- 21 files changed, 592 insertions(+), 118 deletions(-)
Re: [PATCHv4 00/25] dvb core: add basic support for the media controller
On 02/14/2015 12:00 PM, Mauro Carvalho Chehab wrote:
Em Sat, 14 Feb 2015 10:32:21 +0100
Hans Verkuil hverk...@xs4all.nl escreveu:
On 02/13/2015 11:57 PM, Mauro Carvalho Chehab wrote:
This patch series adds basic support for the media controller at the
DVB core: it creates one media entity per DVB devnode, if the media
device is passed as an argument to the DVB structures.
The cx231xx driver was modified to pass such argument for DVB NET,
DVB frontend and DVB demux.
-
version 4:
- Addressed the issues pointed via e-mail
No, you didn't. Especially with regards to the alsa node definition. I'm
pretty sure you need at least the subdevice information which is now removed.
Well, back on Jan, 26 I answered your issues about that at:
http://www.spinics.net/lists/linux-media/msg85857.html
As you didn't reply back in a reasonable amount of time, I assumed that
you're happy with that.
In any case, the definitions are still there, as nothing got dropped
from the external header.
So, when ALSA media controller support will be added at the Kernel, we
can decide if it will use major/minor or card/device/subdevice or both.
As I said back in Jan, 26, IMO, the best would be to use both:
struct media_entity_desc {
...
union {
struct {
u32 major;
u32 minor;
} dev;
/* deprecated fields */
...
}
union {
struct {
u32 card;
u32 device;
u32 subdevice;
} alsa_props;
__u8 raw[172];
}
}
(additional and deprecated fields removed just to simplify its
representation above)
Even for ALSA, it is a way easier for libmediactl.c to keep using
major/minor to get the device node name via both udev/sysfs than
using anything else, as I don't think that udev has any method to
find the associated name without major,minor information. Ok, there
are indirect methods using the ALSA API to get such association, but
it is just easier to fill everything at the struct than to add the
extra complexity for the media control clients to convert between
major/minor into card/device/subdevice.
What I'm saying is that the card/device/subdevice really seems to be
an extra property for this specific type of devnode, and not a
replacement.
In any case, I think we should take the decision on how to properly
map the ALSA specific bits when we merge ALSA media controller patches,
and not before.
I also do *not* like the fact that you posted a v4 and immediately applied
these patches to the master without leaving any time for more discussions.
These patches change the kernel API and need to go to proper review and need
a bunch of Acks, Laurent's at the very minimum since he's MC maintainer.
Please revert the whole patch series from master, then we can discuss this
more.
For the record, for patch 02/25:
Nacked-by: Hans Verkuil hans.verk...@cisco.com
I do *not* agree with this API change.
We can discuss this more on Monday.
This hole series is for discussions for a long time (since the beginning of
January), without rejection, and its now starting to receive patches from
other authors. Keeping it OOT just makes harder to discuss and for people to
test. It is time to move on.
No, it isn't. Laurent and myself actually discussed it during FOSDEM, and
we did have concerns about the API changes. Since he's the MC maintainer I
assumed he would get back to you, but I think he's been very busy since FOSDEM.
In fact, I believe he attended the Linaro Connect last week, so it is very
likely he will not have had time to do anything with what we discussed at
FOSDEM.
Patches changing the MC API need his Ack at minimum. You can't just post a
v4 patch series and commit the same day. Not when it changes APIs and especially
not since there were concerns raised about it in the past. You should have
pinged Laurent and probably myself and ask for comments on v4.
As I said on IRC, as I opted to merge it for 3.21, we'll have 2 entire
Kernel cycles to make it mature before being merged upstream. During that
period, we can fix any issues on it.
That's not the way things are supposed to work. You wouldn't merge patches
from us in a similar situation, and quite rightly. I know, we've tried :-)
Just revert, try to setup an irc session next week, based on that post a v5
and you are likely able to merge this within 2 weeks. Everyone agrees with
*what* you want to do, just not about some of the details.
Regards,
Hans
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv4 00/25] dvb core: add basic support for the media controller
Em Sat, 14 Feb 2015 10:32:21 +0100
Hans Verkuil hverk...@xs4all.nl escreveu:
On 02/13/2015 11:57 PM, Mauro Carvalho Chehab wrote:
This patch series adds basic support for the media controller at the
DVB core: it creates one media entity per DVB devnode, if the media
device is passed as an argument to the DVB structures.
The cx231xx driver was modified to pass such argument for DVB NET,
DVB frontend and DVB demux.
-
version 4:
- Addressed the issues pointed via e-mail
No, you didn't. Especially with regards to the alsa node definition. I'm
pretty sure you need at least the subdevice information which is now removed.
Well, back on Jan, 26 I answered your issues about that at:
http://www.spinics.net/lists/linux-media/msg85857.html
As you didn't reply back in a reasonable amount of time, I assumed that
you're happy with that.
In any case, the definitions are still there, as nothing got dropped
from the external header.
So, when ALSA media controller support will be added at the Kernel, we
can decide if it will use major/minor or card/device/subdevice or both.
As I said back in Jan, 26, IMO, the best would be to use both:
struct media_entity_desc {
...
union {
struct {
u32 major;
u32 minor;
} dev;
/* deprecated fields */
...
}
union {
struct {
u32 card;
u32 device;
u32 subdevice;
} alsa_props;
__u8 raw[172];
}
}
(additional and deprecated fields removed just to simplify its
representation above)
Even for ALSA, it is a way easier for libmediactl.c to keep using
major/minor to get the device node name via both udev/sysfs than
using anything else, as I don't think that udev has any method to
find the associated name without major,minor information. Ok, there
are indirect methods using the ALSA API to get such association, but
it is just easier to fill everything at the struct than to add the
extra complexity for the media control clients to convert between
major/minor into card/device/subdevice.
What I'm saying is that the card/device/subdevice really seems to be
an extra property for this specific type of devnode, and not a
replacement.
In any case, I think we should take the decision on how to properly
map the ALSA specific bits when we merge ALSA media controller patches,
and not before.
I also do *not* like the fact that you posted a v4 and immediately applied
these patches to the master without leaving any time for more discussions.
These patches change the kernel API and need to go to proper review and need
a bunch of Acks, Laurent's at the very minimum since he's MC maintainer.
Please revert the whole patch series from master, then we can discuss this
more.
For the record, for patch 02/25:
Nacked-by: Hans Verkuil hans.verk...@cisco.com
I do *not* agree with this API change.
We can discuss this more on Monday.
This hole series is for discussions for a long time (since the beginning of
January), without rejection, and its now starting to receive patches from
other authors. Keeping it OOT just makes harder to discuss and for people to
test. It is time to move on.
As I said on IRC, as I opted to merge it for 3.21, we'll have 2 entire
Kernel cycles to make it mature before being merged upstream. During that
period, we can fix any issues on it.
Regards,
Mauro
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[linuxtv-media:master 348/348] drivers/media/dvb-core/dvb_frontend.c:695:6: warning: unused variable 'ret'
tree: git://linuxtv.org/media_tree.git master
head: 135f9be9194cf7778eb73594aa55791b229cf27c
commit: 135f9be9194cf7778eb73594aa55791b229cf27c [348/348] [media]
dvb_frontend: start media pipeline while thread is running
config: x86_64-rhel (attached as .config)
reproduce:
git checkout 135f9be9194cf7778eb73594aa55791b229cf27c
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings:
drivers/media/dvb-core/dvb_frontend.c: In function 'dvb_frontend_thread':
drivers/media/dvb-core/dvb_frontend.c:695:6: warning: unused variable 'ret'
[-Wunused-variable]
int ret;
^
vim +/ret +695 drivers/media/dvb-core/dvb_frontend.c
9239effd5 drivers/media/dvb-core/dvb_frontend.c Mauro Carvalho Chehab
2015-01-06 679 } else
9239effd5 drivers/media/dvb-core/dvb_frontend.c Mauro Carvalho Chehab
2015-01-06 680 dev_dbg(fe-dvb-device,
9239effd5 drivers/media/dvb-core/dvb_frontend.c Mauro Carvalho Chehab
2015-01-06 681 link %s-%s was %s\n,
9239effd5 drivers/media/dvb-core/dvb_frontend.c Mauro Carvalho Chehab
2015-01-06 682 source-name, sink-name,
9239effd5 drivers/media/dvb-core/dvb_frontend.c Mauro Carvalho Chehab
2015-01-06 683 flags ? ENABLED : disabled);
9239effd5 drivers/media/dvb-core/dvb_frontend.c Mauro Carvalho Chehab
2015-01-06 684 }
9239effd5 drivers/media/dvb-core/dvb_frontend.c Mauro Carvalho Chehab
2015-01-06 685 return 0;
9239effd5 drivers/media/dvb-core/dvb_frontend.c Mauro Carvalho Chehab
2015-01-06 686 }
135f9be91 drivers/media/dvb-core/dvb_frontend.c Mauro Carvalho Chehab
2015-01-06 687 #endif
9239effd5 drivers/media/dvb-core/dvb_frontend.c Mauro Carvalho Chehab
2015-01-06 688
36cb557a2 drivers/media/dvb/dvb-core/dvb_frontend.c Andrew de Quincey
2006-01-09 689 static int dvb_frontend_thread(void *data)
36cb557a2 drivers/media/dvb/dvb-core/dvb_frontend.c Andrew de Quincey
2006-01-09 690 {
36cb557a2 drivers/media/dvb/dvb-core/dvb_frontend.c Andrew de Quincey
2006-01-09 691 struct dvb_frontend *fe = data;
36cb557a2 drivers/media/dvb/dvb-core/dvb_frontend.c Andrew de Quincey
2006-01-09 692 struct dvb_frontend_private *fepriv = fe-frontend_priv;
36cb557a2 drivers/media/dvb/dvb-core/dvb_frontend.c Andrew de Quincey
2006-01-09 693 fe_status_t s;
c59e7870f drivers/media/dvb/dvb-core/dvb_frontend.c Manu Abraham
2008-10-14 694 enum dvbfe_algo algo;
9239effd5 drivers/media/dvb-core/dvb_frontend.c Mauro Carvalho Chehab
2015-01-06 @695 int ret;
c59e7870f drivers/media/dvb/dvb-core/dvb_frontend.c Manu Abraham
2008-10-14 696
7e0722215 drivers/media/dvb/dvb-core/dvb_frontend.c Mauro Carvalho Chehab
2011-12-26 697 bool re_tune = false;
6ae232245 drivers/media/dvb-core/dvb_frontend.c Juergen Lock
2012-12-23 698 bool semheld = false;
36cb557a2 drivers/media/dvb/dvb-core/dvb_frontend.c Andrew de Quincey
2006-01-09 699
36bdbc3ff drivers/media/dvb-core/dvb_frontend.c Antti Palosaari
2012-08-15 700 dev_dbg(fe-dvb-device, %s:\n, __func__);
36cb557a2 drivers/media/dvb/dvb-core/dvb_frontend.c Andrew de Quincey
2006-01-09 701
36cb557a2 drivers/media/dvb/dvb-core/dvb_frontend.c Andrew de Quincey
2006-01-09 702 fepriv-check_wrapped = 0;
36cb557a2 drivers/media/dvb/dvb-core/dvb_frontend.c Andrew de Quincey
2006-01-09 703 fepriv-quality = 0;
:: The code at line 695 was first introduced by commit
:: 9239effd53d47e3cd9c653830c8465c0a3a427dc [media] dvb-frontend: enable
tuner link when the FE thread starts
:: TO: Mauro Carvalho Chehab mche...@osg.samsung.com
:: CC: Mauro Carvalho Chehab mche...@osg.samsung.com
---
0-DAY kernel test infrastructureOpen Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
#
# Automatically generated file; DO NOT EDIT.
# Linux/x86_64 3.19.0-rc6 Kernel Configuration
#
CONFIG_64BIT=y
CONFIG_X86_64=y
CONFIG_X86=y
CONFIG_INSTRUCTION_DECODER=y
CONFIG_PERF_EVENTS_INTEL_UNCORE=y
CONFIG_OUTPUT_FORMAT=elf64-x86-64
CONFIG_ARCH_DEFCONFIG=arch/x86/configs/x86_64_defconfig
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_HAVE_LATENCYTOP_SUPPORT=y
CONFIG_MMU=y
CONFIG_NEED_DMA_MAP_STATE=y
CONFIG_NEED_SG_DMA_LENGTH=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_BUG=y
CONFIG_GENERIC_BUG_RELATIVE_POINTERS=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_ARCH_HAS_CPU_RELAX=y
CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y
CONFIG_HAVE_SETUP_PER_CPU_AREA=y
CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y
CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y
CONFIG_ARCH_HIBERNATION_POSSIBLE=y
CONFIG_ARCH_SUSPEND_POSSIBLE=y
CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y
[linuxtv-media:master 338/348] drivers/media/v4l2-core/tuner-core.c:440:7: error: 'struct v4l2_subdev' has no member named 'entity'
tree: git://linuxtv.org/media_tree.git master
head: 135f9be9194cf7778eb73594aa55791b229cf27c
commit: 00a5a4bf7bb40fe8cd5de042948b925c54b016de [338/348] [media] tuner-core:
properly initialize media controller subdev
config: x86_64-rhel (attached as .config)
reproduce:
git checkout 00a5a4bf7bb40fe8cd5de042948b925c54b016de
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings:
drivers/media/v4l2-core/tuner-core.c: In function 'set_type':
drivers/media/v4l2-core/tuner-core.c:440:7: error: 'struct v4l2_subdev' has
no member named 'entity'
t-sd.entity.name = t-name;
^
vim +440 drivers/media/v4l2-core/tuner-core.c
434 analog_ops-get_afc = fe_tuner_ops-get_afc;
435
436 } else {
437 t-name = analog_ops-info.name;
438 }
439
440 t-sd.entity.name = t-name;
441
442 tuner_dbg(type set to %s\n, t-name);
443
---
0-DAY kernel test infrastructureOpen Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
#
# Automatically generated file; DO NOT EDIT.
# Linux/x86_64 3.19.0-rc6 Kernel Configuration
#
CONFIG_64BIT=y
CONFIG_X86_64=y
CONFIG_X86=y
CONFIG_INSTRUCTION_DECODER=y
CONFIG_PERF_EVENTS_INTEL_UNCORE=y
CONFIG_OUTPUT_FORMAT=elf64-x86-64
CONFIG_ARCH_DEFCONFIG=arch/x86/configs/x86_64_defconfig
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_HAVE_LATENCYTOP_SUPPORT=y
CONFIG_MMU=y
CONFIG_NEED_DMA_MAP_STATE=y
CONFIG_NEED_SG_DMA_LENGTH=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_BUG=y
CONFIG_GENERIC_BUG_RELATIVE_POINTERS=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_ARCH_HAS_CPU_RELAX=y
CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y
CONFIG_HAVE_SETUP_PER_CPU_AREA=y
CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y
CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y
CONFIG_ARCH_HIBERNATION_POSSIBLE=y
CONFIG_ARCH_SUSPEND_POSSIBLE=y
CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y
CONFIG_ARCH_WANT_GENERAL_HUGETLB=y
CONFIG_ZONE_DMA32=y
CONFIG_AUDIT_ARCH=y
CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING=y
CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC=y
CONFIG_HAVE_INTEL_TXT=y
CONFIG_X86_64_SMP=y
CONFIG_X86_HT=y
CONFIG_ARCH_HWEIGHT_CFLAGS=-fcall-saved-rdi -fcall-saved-rsi -fcall-saved-rdx
-fcall-saved-rcx -fcall-saved-r8 -fcall-saved-r9 -fcall-saved-r10
-fcall-saved-r11
CONFIG_ARCH_SUPPORTS_UPROBES=y
CONFIG_FIX_EARLYCON_MEM=y
CONFIG_DEFCONFIG_LIST=/lib/modules/$UNAME_RELEASE/.config
CONFIG_IRQ_WORK=y
CONFIG_BUILDTIME_EXTABLE_SORT=y
#
# General setup
#
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_CROSS_COMPILE=
# CONFIG_COMPILE_TEST is not set
CONFIG_LOCALVERSION=
CONFIG_LOCALVERSION_AUTO=y
CONFIG_HAVE_KERNEL_GZIP=y
CONFIG_HAVE_KERNEL_BZIP2=y
CONFIG_HAVE_KERNEL_LZMA=y
CONFIG_HAVE_KERNEL_XZ=y
CONFIG_HAVE_KERNEL_LZO=y
CONFIG_HAVE_KERNEL_LZ4=y
CONFIG_KERNEL_GZIP=y
# CONFIG_KERNEL_BZIP2 is not set
# CONFIG_KERNEL_LZMA is not set
# CONFIG_KERNEL_XZ is not set
# CONFIG_KERNEL_LZO is not set
# CONFIG_KERNEL_LZ4 is not set
CONFIG_DEFAULT_HOSTNAME=(none)
CONFIG_SWAP=y
CONFIG_SYSVIPC=y
CONFIG_SYSVIPC_SYSCTL=y
CONFIG_POSIX_MQUEUE=y
CONFIG_POSIX_MQUEUE_SYSCTL=y
CONFIG_CROSS_MEMORY_ATTACH=y
CONFIG_FHANDLE=y
CONFIG_USELIB=y
CONFIG_AUDIT=y
CONFIG_HAVE_ARCH_AUDITSYSCALL=y
CONFIG_AUDITSYSCALL=y
CONFIG_AUDIT_WATCH=y
CONFIG_AUDIT_TREE=y
#
# IRQ subsystem
#
CONFIG_GENERIC_IRQ_PROBE=y
CONFIG_GENERIC_IRQ_SHOW=y
CONFIG_GENERIC_IRQ_LEGACY_ALLOC_HWIRQ=y
CONFIG_GENERIC_PENDING_IRQ=y
CONFIG_IRQ_DOMAIN=y
CONFIG_GENERIC_MSI_IRQ=y
# CONFIG_IRQ_DOMAIN_DEBUG is not set
CONFIG_IRQ_FORCED_THREADING=y
CONFIG_SPARSE_IRQ=y
CONFIG_CLOCKSOURCE_WATCHDOG=y
CONFIG_ARCH_CLOCKSOURCE_DATA=y
CONFIG_CLOCKSOURCE_VALIDATE_LAST_CYCLE=y
CONFIG_GENERIC_TIME_VSYSCALL=y
CONFIG_GENERIC_CLOCKEVENTS=y
CONFIG_GENERIC_CLOCKEVENTS_BUILD=y
CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y
CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST=y
CONFIG_GENERIC_CMOS_UPDATE=y
#
# Timers subsystem
#
CONFIG_TICK_ONESHOT=y
CONFIG_NO_HZ_COMMON=y
# CONFIG_HZ_PERIODIC is not set
# CONFIG_NO_HZ_IDLE is not set
CONFIG_NO_HZ_FULL=y
# CONFIG_NO_HZ_FULL_ALL is not set
# CONFIG_NO_HZ_FULL_SYSIDLE is not set
CONFIG_NO_HZ=y
CONFIG_HIGH_RES_TIMERS=y
#
# CPU/Task time and stats accounting
#
CONFIG_VIRT_CPU_ACCOUNTING=y
CONFIG_VIRT_CPU_ACCOUNTING_GEN=y
CONFIG_BSD_PROCESS_ACCT=y
CONFIG_BSD_PROCESS_ACCT_V3=y
CONFIG_TASKSTATS=y
CONFIG_TASK_DELAY_ACCT=y
CONFIG_TASK_XACCT=y
CONFIG_TASK_IO_ACCOUNTING=y
#
# RCU Subsystem
#
CONFIG_TREE_RCU=y
# CONFIG_TASKS_RCU is not set
CONFIG_RCU_STALL_COMMON=y
CONFIG_CONTEXT_TRACKING=y
CONFIG_RCU_USER_QS=y
# CONFIG_CONTEXT_TRACKING_FORCE is not set
CONFIG_RCU_FANOUT=64
CONFIG_RCU_FANOUT_LEAF=16
# CONFIG_RCU_FANOUT_EXACT is not set
# CONFIG_RCU_FAST_NO_HZ is not set
# CONFIG_TREE_RCU_TRACE is not set
CONFIG_RCU_NOCB_CPU=y
# CONFIG_RCU_NOCB_CPU_NONE is not set
# CONFIG_RCU_NOCB_CPU_ZERO is not set
CONFIG_RCU_NOCB_CPU_ALL=y
CONFIG_BUILD_BIN2C=y
[linuxtv-media:master 332/348] drivers/media/usb/cx231xx/cx231xx-cards.c:1553:15: error: 'struct v4l2_device' has no member named 'mdev'
tree: git://linuxtv.org/media_tree.git master
head: 135f9be9194cf7778eb73594aa55791b229cf27c
commit: 1d058bdcf5cc800fbfeece0204f7774556d341bb [332/348] [media] cx231xx: add
media controller support
config: x86_64-rhel (attached as .config)
reproduce:
git checkout 1d058bdcf5cc800fbfeece0204f7774556d341bb
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings:
drivers/media/usb/cx231xx/cx231xx-cards.c: In function 'cx231xx_usb_probe':
drivers/media/usb/cx231xx/cx231xx-cards.c:1553:15: error: 'struct
v4l2_device' has no member named 'mdev'
dev-v4l2_dev.mdev = dev-media_dev;
^
drivers/media/usb/cx231xx/cx231xx-cards.c:1553:26: error: 'struct cx231xx'
has no member named 'media_dev'
dev-v4l2_dev.mdev = dev-media_dev;
^
vim +1553 drivers/media/usb/cx231xx/cx231xx-cards.c
1547 usb_set_intfdata(interface, dev);
1548
1549 /* Register the media controller */
1550 cx231xx_media_device_register(dev, udev);
1551
1552 /* Create v4l2 device */
1553 dev-v4l2_dev.mdev = dev-media_dev;
1554 retval = v4l2_device_register(interface-dev, dev-v4l2_dev);
1555 if (retval) {
1556 dev_err(d, v4l2_device_register failed\n);
---
0-DAY kernel test infrastructureOpen Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
#
# Automatically generated file; DO NOT EDIT.
# Linux/x86_64 3.19.0-rc6 Kernel Configuration
#
CONFIG_64BIT=y
CONFIG_X86_64=y
CONFIG_X86=y
CONFIG_INSTRUCTION_DECODER=y
CONFIG_PERF_EVENTS_INTEL_UNCORE=y
CONFIG_OUTPUT_FORMAT=elf64-x86-64
CONFIG_ARCH_DEFCONFIG=arch/x86/configs/x86_64_defconfig
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_HAVE_LATENCYTOP_SUPPORT=y
CONFIG_MMU=y
CONFIG_NEED_DMA_MAP_STATE=y
CONFIG_NEED_SG_DMA_LENGTH=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_BUG=y
CONFIG_GENERIC_BUG_RELATIVE_POINTERS=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_ARCH_HAS_CPU_RELAX=y
CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y
CONFIG_HAVE_SETUP_PER_CPU_AREA=y
CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y
CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y
CONFIG_ARCH_HIBERNATION_POSSIBLE=y
CONFIG_ARCH_SUSPEND_POSSIBLE=y
CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y
CONFIG_ARCH_WANT_GENERAL_HUGETLB=y
CONFIG_ZONE_DMA32=y
CONFIG_AUDIT_ARCH=y
CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING=y
CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC=y
CONFIG_HAVE_INTEL_TXT=y
CONFIG_X86_64_SMP=y
CONFIG_X86_HT=y
CONFIG_ARCH_HWEIGHT_CFLAGS=-fcall-saved-rdi -fcall-saved-rsi -fcall-saved-rdx
-fcall-saved-rcx -fcall-saved-r8 -fcall-saved-r9 -fcall-saved-r10
-fcall-saved-r11
CONFIG_ARCH_SUPPORTS_UPROBES=y
CONFIG_FIX_EARLYCON_MEM=y
CONFIG_DEFCONFIG_LIST=/lib/modules/$UNAME_RELEASE/.config
CONFIG_IRQ_WORK=y
CONFIG_BUILDTIME_EXTABLE_SORT=y
#
# General setup
#
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_CROSS_COMPILE=
# CONFIG_COMPILE_TEST is not set
CONFIG_LOCALVERSION=
CONFIG_LOCALVERSION_AUTO=y
CONFIG_HAVE_KERNEL_GZIP=y
CONFIG_HAVE_KERNEL_BZIP2=y
CONFIG_HAVE_KERNEL_LZMA=y
CONFIG_HAVE_KERNEL_XZ=y
CONFIG_HAVE_KERNEL_LZO=y
CONFIG_HAVE_KERNEL_LZ4=y
CONFIG_KERNEL_GZIP=y
# CONFIG_KERNEL_BZIP2 is not set
# CONFIG_KERNEL_LZMA is not set
# CONFIG_KERNEL_XZ is not set
# CONFIG_KERNEL_LZO is not set
# CONFIG_KERNEL_LZ4 is not set
CONFIG_DEFAULT_HOSTNAME=(none)
CONFIG_SWAP=y
CONFIG_SYSVIPC=y
CONFIG_SYSVIPC_SYSCTL=y
CONFIG_POSIX_MQUEUE=y
CONFIG_POSIX_MQUEUE_SYSCTL=y
CONFIG_CROSS_MEMORY_ATTACH=y
CONFIG_FHANDLE=y
CONFIG_USELIB=y
CONFIG_AUDIT=y
CONFIG_HAVE_ARCH_AUDITSYSCALL=y
CONFIG_AUDITSYSCALL=y
CONFIG_AUDIT_WATCH=y
CONFIG_AUDIT_TREE=y
#
# IRQ subsystem
#
CONFIG_GENERIC_IRQ_PROBE=y
CONFIG_GENERIC_IRQ_SHOW=y
CONFIG_GENERIC_IRQ_LEGACY_ALLOC_HWIRQ=y
CONFIG_GENERIC_PENDING_IRQ=y
CONFIG_IRQ_DOMAIN=y
CONFIG_GENERIC_MSI_IRQ=y
# CONFIG_IRQ_DOMAIN_DEBUG is not set
CONFIG_IRQ_FORCED_THREADING=y
CONFIG_SPARSE_IRQ=y
CONFIG_CLOCKSOURCE_WATCHDOG=y
CONFIG_ARCH_CLOCKSOURCE_DATA=y
CONFIG_CLOCKSOURCE_VALIDATE_LAST_CYCLE=y
CONFIG_GENERIC_TIME_VSYSCALL=y
CONFIG_GENERIC_CLOCKEVENTS=y
CONFIG_GENERIC_CLOCKEVENTS_BUILD=y
CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y
CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST=y
CONFIG_GENERIC_CMOS_UPDATE=y
#
# Timers subsystem
#
CONFIG_TICK_ONESHOT=y
CONFIG_NO_HZ_COMMON=y
# CONFIG_HZ_PERIODIC is not set
# CONFIG_NO_HZ_IDLE is not set
CONFIG_NO_HZ_FULL=y
# CONFIG_NO_HZ_FULL_ALL is not set
# CONFIG_NO_HZ_FULL_SYSIDLE is not set
CONFIG_NO_HZ=y
CONFIG_HIGH_RES_TIMERS=y
#
# CPU/Task time and stats accounting
#
CONFIG_VIRT_CPU_ACCOUNTING=y
CONFIG_VIRT_CPU_ACCOUNTING_GEN=y
CONFIG_BSD_PROCESS_ACCT=y
CONFIG_BSD_PROCESS_ACCT_V3=y
CONFIG_TASKSTATS=y
CONFIG_TASK_DELAY_ACCT=y
CONFIG_TASK_XACCT=y
CONFIG_TASK_IO_ACCOUNTING=y
#
# RCU Subsystem
#
CONFIG_TREE_RCU=y
# CONFIG_TASKS_RCU is not set
CONFIG_RCU_STALL_COMMON=y
CONFIG_CONTEXT_TRACKING=y
CONFIG_RCU_USER_QS=y
#
[PATCH] rtl28xxu: add support for Turbo-X DTT2000
ID 1b80:d3a4 Afatech
Simply added the PID (0xd3a4) of this DVB-T USB device to the list of
rtl2832u-supported devices. VID (0x1b80) is same as KWORLD2.
Tested and verified to work in amd64 with kernels 3.13.0 and 3.16.0.
Signed-off-by: Dimitris Lampridis dlampri...@logikonlabs.com
---
drivers/media/dvb-core/dvb-usb-ids.h| 1 +
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/drivers/media/dvb-core/dvb-usb-ids.h
b/drivers/media/dvb-core/dvb-usb-ids.h
index 80ab8d0..a9d601d 100644
--- a/drivers/media/dvb-core/dvb-usb-ids.h
+++ b/drivers/media/dvb-core/dvb-usb-ids.h
@@ -385,4 +385,5 @@
#define USB_PID_PCTV_2002E 0x025c
#define USB_PID_PCTV_2002E_SE 0x025d
#define USB_PID_SVEON_STV27 0xd3af
+#define USB_PID_TURBOX_DTT_2000 0xd3a4
#endif
diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
index 77dcfdf..b11380d 100644
--- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
+++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
@@ -1756,6 +1756,8 @@ static const struct usb_device_id rtl28xxu_id_table[] = {
rtl28xxu_props, Sveon STV21, NULL) },
{ DVB_USB_DEVICE(USB_VID_KWORLD_2, USB_PID_SVEON_STV27,
rtl28xxu_props, Sveon STV27, NULL) },
+ { DVB_USB_DEVICE(USB_VID_KWORLD_2, USB_PID_TURBOX_DTT_2000,
+ rtl28xxu_props, TURBO-X Pure TV Tuner DTT-2000, NULL) },
/* RTL2832P devices: */
{ DVB_USB_DEVICE(USB_VID_HANFTEK, 0x0131,
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[linuxtv-media:master 344/348] drivers/media/usb/cx231xx/cx231xx-dvb.c:543:28: error: 'struct cx231xx' has no member named 'media_dev'
tree: git://linuxtv.org/media_tree.git master head: 135f9be9194cf7778eb73594aa55791b229cf27c commit: 54e339a960f8166df4368d01e792d0550d3bcd57 [344/348] [media] cx231xx: create DVB graph config: x86_64-rhel (attached as .config) reproduce: git checkout 54e339a960f8166df4368d01e792d0550d3bcd57 # save the attached .config to linux build tree make ARCH=x86_64 All error/warnings: drivers/media/usb/cx231xx/cx231xx-dvb.c: In function 'register_dvb': drivers/media/usb/cx231xx/cx231xx-dvb.c:543:28: error: 'struct cx231xx' has no member named 'media_dev' dvb_create_media_graph(dev-media_dev); ^ vim +543 drivers/media/usb/cx231xx/cx231xx-dvb.c 537 dev-name, result); 538 goto fail_fe_conn; 539 } 540 541 /* register network adapter */ 542 dvb_net_init(dvb-adapter, dvb-net, dvb-demux.dmx); 543 dvb_create_media_graph(dev-media_dev); 544 return 0; 545 546 fail_fe_conn: --- 0-DAY kernel test infrastructureOpen Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation # # Automatically generated file; DO NOT EDIT. # Linux/x86_64 3.19.0-rc6 Kernel Configuration # CONFIG_64BIT=y CONFIG_X86_64=y CONFIG_X86=y CONFIG_INSTRUCTION_DECODER=y CONFIG_PERF_EVENTS_INTEL_UNCORE=y CONFIG_OUTPUT_FORMAT=elf64-x86-64 CONFIG_ARCH_DEFCONFIG=arch/x86/configs/x86_64_defconfig CONFIG_LOCKDEP_SUPPORT=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_HAVE_LATENCYTOP_SUPPORT=y CONFIG_MMU=y CONFIG_NEED_DMA_MAP_STATE=y CONFIG_NEED_SG_DMA_LENGTH=y CONFIG_GENERIC_ISA_DMA=y CONFIG_GENERIC_BUG=y CONFIG_GENERIC_BUG_RELATIVE_POINTERS=y CONFIG_GENERIC_HWEIGHT=y CONFIG_ARCH_MAY_HAVE_PC_FDC=y CONFIG_RWSEM_XCHGADD_ALGORITHM=y CONFIG_GENERIC_CALIBRATE_DELAY=y CONFIG_ARCH_HAS_CPU_RELAX=y CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y CONFIG_HAVE_SETUP_PER_CPU_AREA=y CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y CONFIG_ARCH_HIBERNATION_POSSIBLE=y CONFIG_ARCH_SUSPEND_POSSIBLE=y CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y CONFIG_ARCH_WANT_GENERAL_HUGETLB=y CONFIG_ZONE_DMA32=y CONFIG_AUDIT_ARCH=y CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING=y CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC=y CONFIG_HAVE_INTEL_TXT=y CONFIG_X86_64_SMP=y CONFIG_X86_HT=y CONFIG_ARCH_HWEIGHT_CFLAGS=-fcall-saved-rdi -fcall-saved-rsi -fcall-saved-rdx -fcall-saved-rcx -fcall-saved-r8 -fcall-saved-r9 -fcall-saved-r10 -fcall-saved-r11 CONFIG_ARCH_SUPPORTS_UPROBES=y CONFIG_FIX_EARLYCON_MEM=y CONFIG_DEFCONFIG_LIST=/lib/modules/$UNAME_RELEASE/.config CONFIG_IRQ_WORK=y CONFIG_BUILDTIME_EXTABLE_SORT=y # # General setup # CONFIG_INIT_ENV_ARG_LIMIT=32 CONFIG_CROSS_COMPILE= # CONFIG_COMPILE_TEST is not set CONFIG_LOCALVERSION= CONFIG_LOCALVERSION_AUTO=y CONFIG_HAVE_KERNEL_GZIP=y CONFIG_HAVE_KERNEL_BZIP2=y CONFIG_HAVE_KERNEL_LZMA=y CONFIG_HAVE_KERNEL_XZ=y CONFIG_HAVE_KERNEL_LZO=y CONFIG_HAVE_KERNEL_LZ4=y CONFIG_KERNEL_GZIP=y # CONFIG_KERNEL_BZIP2 is not set # CONFIG_KERNEL_LZMA is not set # CONFIG_KERNEL_XZ is not set # CONFIG_KERNEL_LZO is not set # CONFIG_KERNEL_LZ4 is not set CONFIG_DEFAULT_HOSTNAME=(none) CONFIG_SWAP=y CONFIG_SYSVIPC=y CONFIG_SYSVIPC_SYSCTL=y CONFIG_POSIX_MQUEUE=y CONFIG_POSIX_MQUEUE_SYSCTL=y CONFIG_CROSS_MEMORY_ATTACH=y CONFIG_FHANDLE=y CONFIG_USELIB=y CONFIG_AUDIT=y CONFIG_HAVE_ARCH_AUDITSYSCALL=y CONFIG_AUDITSYSCALL=y CONFIG_AUDIT_WATCH=y CONFIG_AUDIT_TREE=y # # IRQ subsystem # CONFIG_GENERIC_IRQ_PROBE=y CONFIG_GENERIC_IRQ_SHOW=y CONFIG_GENERIC_IRQ_LEGACY_ALLOC_HWIRQ=y CONFIG_GENERIC_PENDING_IRQ=y CONFIG_IRQ_DOMAIN=y CONFIG_GENERIC_MSI_IRQ=y # CONFIG_IRQ_DOMAIN_DEBUG is not set CONFIG_IRQ_FORCED_THREADING=y CONFIG_SPARSE_IRQ=y CONFIG_CLOCKSOURCE_WATCHDOG=y CONFIG_ARCH_CLOCKSOURCE_DATA=y CONFIG_CLOCKSOURCE_VALIDATE_LAST_CYCLE=y CONFIG_GENERIC_TIME_VSYSCALL=y CONFIG_GENERIC_CLOCKEVENTS=y CONFIG_GENERIC_CLOCKEVENTS_BUILD=y CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST=y CONFIG_GENERIC_CMOS_UPDATE=y # # Timers subsystem # CONFIG_TICK_ONESHOT=y CONFIG_NO_HZ_COMMON=y # CONFIG_HZ_PERIODIC is not set # CONFIG_NO_HZ_IDLE is not set CONFIG_NO_HZ_FULL=y # CONFIG_NO_HZ_FULL_ALL is not set # CONFIG_NO_HZ_FULL_SYSIDLE is not set CONFIG_NO_HZ=y CONFIG_HIGH_RES_TIMERS=y # # CPU/Task time and stats accounting # CONFIG_VIRT_CPU_ACCOUNTING=y CONFIG_VIRT_CPU_ACCOUNTING_GEN=y CONFIG_BSD_PROCESS_ACCT=y CONFIG_BSD_PROCESS_ACCT_V3=y CONFIG_TASKSTATS=y CONFIG_TASK_DELAY_ACCT=y CONFIG_TASK_XACCT=y CONFIG_TASK_IO_ACCOUNTING=y # # RCU Subsystem # CONFIG_TREE_RCU=y # CONFIG_TASKS_RCU is not set CONFIG_RCU_STALL_COMMON=y CONFIG_CONTEXT_TRACKING=y CONFIG_RCU_USER_QS=y # CONFIG_CONTEXT_TRACKING_FORCE is not set CONFIG_RCU_FANOUT=64 CONFIG_RCU_FANOUT_LEAF=16 # CONFIG_RCU_FANOUT_EXACT is not set # CONFIG_RCU_FAST_NO_HZ is not set # CONFIG_TREE_RCU_TRACE is not set CONFIG_RCU_NOCB_CPU=y # CONFIG_RCU_NOCB_CPU_NONE is not set # CONFIG_RCU_NOCB_CPU_ZERO is
dib0700_devices.c:undefined reference to `dibx000_i2c_set_speed'
tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 18320f2a6871aaf2522f793fee4a67eccf5e131a commit: a34ff6cdbb464b3e37f0cbb6b0cff9dab4ee057b [media] Make DVB NET configurable in the kernel date: 3 years, 7 months ago config: i386-randconfig-ib1-02150438 (attached as .config) reproduce: git checkout a34ff6cdbb464b3e37f0cbb6b0cff9dab4ee057b # save the attached .config to linux build tree make ARCH=i386 All error/warnings: drivers/built-in.o: In function `dib01x0_pmu_update.constprop.31': dib0700_devices.c:(.text.unlikely+0x7557): undefined reference to `dibx000_i2c_set_speed' --- 0-DAY kernel test infrastructureOpen Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation # # Automatically generated make config: don't edit # Linux/i386 3.0.0 Kernel Configuration # # CONFIG_64BIT is not set CONFIG_X86_32=y # CONFIG_X86_64 is not set CONFIG_X86=y CONFIG_INSTRUCTION_DECODER=y CONFIG_OUTPUT_FORMAT=elf32-i386 CONFIG_ARCH_DEFCONFIG=arch/x86/configs/i386_defconfig CONFIG_GENERIC_CMOS_UPDATE=y CONFIG_CLOCKSOURCE_WATCHDOG=y CONFIG_GENERIC_CLOCKEVENTS=y CONFIG_LOCKDEP_SUPPORT=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_HAVE_LATENCYTOP_SUPPORT=y CONFIG_MMU=y CONFIG_ZONE_DMA=y # CONFIG_NEED_DMA_MAP_STATE is not set CONFIG_NEED_SG_DMA_LENGTH=y CONFIG_GENERIC_ISA_DMA=y CONFIG_GENERIC_IOMAP=y CONFIG_GENERIC_BUG=y CONFIG_GENERIC_HWEIGHT=y CONFIG_GENERIC_GPIO=y CONFIG_ARCH_MAY_HAVE_PC_FDC=y # CONFIG_RWSEM_GENERIC_SPINLOCK is not set CONFIG_RWSEM_XCHGADD_ALGORITHM=y CONFIG_ARCH_HAS_CPU_IDLE_WAIT=y CONFIG_GENERIC_CALIBRATE_DELAY=y # CONFIG_GENERIC_TIME_VSYSCALL is not set CONFIG_ARCH_HAS_CPU_RELAX=y CONFIG_ARCH_HAS_DEFAULT_IDLE=y CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y CONFIG_HAVE_SETUP_PER_CPU_AREA=y CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y # CONFIG_HAVE_CPUMASK_OF_CPU_MAP is not set CONFIG_ARCH_HIBERNATION_POSSIBLE=y CONFIG_ARCH_SUSPEND_POSSIBLE=y # CONFIG_ZONE_DMA32 is not set CONFIG_ARCH_POPULATES_NODE_MAP=y # CONFIG_AUDIT_ARCH is not set CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING=y CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC=y CONFIG_ARCH_HWEIGHT_CFLAGS=-fcall-saved-ecx -fcall-saved-edx CONFIG_KTIME_SCALAR=y CONFIG_DEFCONFIG_LIST=/lib/modules/$UNAME_RELEASE/.config CONFIG_HAVE_IRQ_WORK=y CONFIG_IRQ_WORK=y # # General setup # # CONFIG_EXPERIMENTAL is not set CONFIG_BROKEN_ON_SMP=y CONFIG_INIT_ENV_ARG_LIMIT=32 CONFIG_CROSS_COMPILE= CONFIG_LOCALVERSION= CONFIG_LOCALVERSION_AUTO=y CONFIG_HAVE_KERNEL_GZIP=y CONFIG_HAVE_KERNEL_BZIP2=y CONFIG_HAVE_KERNEL_LZMA=y CONFIG_HAVE_KERNEL_XZ=y CONFIG_HAVE_KERNEL_LZO=y # CONFIG_KERNEL_GZIP is not set # CONFIG_KERNEL_BZIP2 is not set CONFIG_KERNEL_LZMA=y # CONFIG_KERNEL_XZ is not set # CONFIG_KERNEL_LZO is not set CONFIG_DEFAULT_HOSTNAME=(none) CONFIG_SYSVIPC=y CONFIG_BSD_PROCESS_ACCT=y # CONFIG_BSD_PROCESS_ACCT_V3 is not set # CONFIG_FHANDLE is not set # CONFIG_TASKSTATS is not set # CONFIG_AUDIT is not set CONFIG_HAVE_GENERIC_HARDIRQS=y # # IRQ subsystem # CONFIG_GENERIC_HARDIRQS=y CONFIG_HAVE_SPARSE_IRQ=y CONFIG_GENERIC_IRQ_PROBE=y CONFIG_GENERIC_IRQ_SHOW=y CONFIG_IRQ_FORCED_THREADING=y CONFIG_SPARSE_IRQ=y # # RCU Subsystem # CONFIG_TINY_RCU=y # CONFIG_PREEMPT_RCU is not set CONFIG_RCU_TRACE=y # CONFIG_TREE_RCU_TRACE is not set CONFIG_IKCONFIG=y CONFIG_LOG_BUF_SHIFT=17 CONFIG_HAVE_UNSTABLE_SCHED_CLOCK=y CONFIG_NAMESPACES=y # CONFIG_UTS_NS is not set # CONFIG_IPC_NS is not set CONFIG_PID_NS=y CONFIG_NET_NS=y # CONFIG_SCHED_AUTOGROUP is not set # CONFIG_SYSFS_DEPRECATED is not set # CONFIG_RELAY is not set CONFIG_BLK_DEV_INITRD=y CONFIG_INITRAMFS_SOURCE= CONFIG_RD_GZIP=y CONFIG_RD_BZIP2=y CONFIG_RD_LZMA=y CONFIG_RD_XZ=y CONFIG_RD_LZO=y # CONFIG_CC_OPTIMIZE_FOR_SIZE is not set CONFIG_ANON_INODES=y CONFIG_EXPERT=y CONFIG_UID16=y CONFIG_KALLSYMS=y CONFIG_KALLSYMS_ALL=y CONFIG_HOTPLUG=y CONFIG_PRINTK=y CONFIG_BUG=y CONFIG_ELF_CORE=y CONFIG_PCSPKR_PLATFORM=y # CONFIG_BASE_FULL is not set CONFIG_FUTEX=y # CONFIG_EPOLL is not set CONFIG_SIGNALFD=y CONFIG_TIMERFD=y # CONFIG_EVENTFD is not set CONFIG_SHMEM=y # CONFIG_AIO is not set # CONFIG_EMBEDDED is not set CONFIG_HAVE_PERF_EVENTS=y CONFIG_PERF_USE_VMALLOC=y # # Kernel Performance Events And Counters # CONFIG_PERF_EVENTS=y # CONFIG_PERF_COUNTERS is not set CONFIG_DEBUG_PERF_USE_VMALLOC=y CONFIG_VM_EVENT_COUNTERS=y CONFIG_PCI_QUIRKS=y CONFIG_COMPAT_BRK=y CONFIG_SLAB=y # CONFIG_SLUB is not set # CONFIG_SLOB is not set # CONFIG_PROFILING is not set CONFIG_HAVE_OPROFILE=y # CONFIG_JUMP_LABEL is not set CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=y CONFIG_HAVE_IOREMAP_PROT=y CONFIG_HAVE_KPROBES=y CONFIG_HAVE_KRETPROBES=y CONFIG_HAVE_OPTPROBES=y CONFIG_HAVE_ARCH_TRACEHOOK=y CONFIG_HAVE_DMA_ATTRS=y CONFIG_HAVE_REGS_AND_STACK_ACCESS_API=y CONFIG_HAVE_DMA_API_DEBUG=y CONFIG_HAVE_HW_BREAKPOINT=y CONFIG_HAVE_MIXED_BREAKPOINTS_REGS=y CONFIG_HAVE_USER_RETURN_NOTIFIER=y CONFIG_HAVE_PERF_EVENTS_NMI=y
[PATCH] [media] cx88: Fix possible leak in cx8802_probe()
In case allocation vb2_dma_sg_init_ctx() fails during cx8802_probe(), the
already allocated cx8802 device structure memory is not freed in the used
exit path. Thus adapt the cleanup handling accordingly. Detected by Coverity
CID 1260065.
Signed-off-by: Christian Engelmayer cenge...@gmx.at
---
Compile tested only. Applies against linux-next.
---
drivers/media/pci/cx88/cx88-mpeg.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/pci/cx88/cx88-mpeg.c
b/drivers/media/pci/cx88/cx88-mpeg.c
index a369b0840acf..98344540c51f 100644
--- a/drivers/media/pci/cx88/cx88-mpeg.c
+++ b/drivers/media/pci/cx88/cx88-mpeg.c
@@ -732,7 +732,7 @@ static int cx8802_probe(struct pci_dev *pci_dev,
dev-alloc_ctx = vb2_dma_sg_init_ctx(pci_dev-dev);
if (IS_ERR(dev-alloc_ctx)) {
err = PTR_ERR(dev-alloc_ctx);
- goto fail_core;
+ goto fail_dev;
}
dev-core = core;
@@ -754,6 +754,7 @@ static int cx8802_probe(struct pci_dev *pci_dev,
fail_free:
vb2_dma_sg_cleanup_ctx(dev-alloc_ctx);
+ fail_dev:
kfree(dev);
fail_core:
core-dvbdev = NULL;
--
1.9.1
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Driver Request
Hi, Trying to get an Empia EasyCap USB video capture device to work in Ubuntu 14.04 and only audio capture works, no video capture device detected. Kind of new at this but I'll give you all the information I have. More info available upon request. Parent Company: Geniatech Make: MyGica Model: iGrabber for MAC Vendor/Product ID: [1f4d:1abe] Opened the case and found the following text printed on the board: HandyCap v1.51 2007-4-24 Three chips on board are: 1: empia EM2860 P8367-010 201036-01AG 2: Trident SAA7113H C2P409.00 02 A5G11152 3: eMPIA Technology EMP202 UT11958 1027 uname -a: 3.13.0-45-generic #74-Ubuntu SMP Tue Jan 13 19:36:28 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux dmesg: [74.661399] usb 3-2: new high-speed USB device number 6 using xhci_hcd [74.680016] usb 3-2: New USB device found, idVendor=1f4d, idProduct=1abe [74.680019] usb 3-2: New USB device strings: Mfr=0, Product=1, SerialNumber=0 [74.680021] usb 3-2: Product: USB Device [74.701455] usbcore: registered new interface driver snd-usb-audio Tried loading 5 additional modules but didn't help: saa7115 em28xx em28xx_dvb em28xx_rc em28xx_alsa lsusb -v: Bus 003 Device 015: ID 1f4d:1abe G-Tek Electronics Group Device Descriptor: bLength18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass0 (Defined at Interface level) bDeviceSubClass 0 bDeviceProtocol 0 bMaxPacketSize064 idVendor 0x1f4d G-Tek Electronics Group idProduct 0x1abe bcdDevice1.00 iManufacturer 0 iProduct1 iSerial 0 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 555 bNumInterfaces 3 bConfigurationValue 1 iConfiguration 0 bmAttributes 0x80 (Bus Powered) MaxPower 500mA -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] r820t: add DVBC profile in sysfreq_sel
Signed-off-by: Benjamin Larsson benja...@southpole.se --- drivers/media/tuners/r820t.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c index 8e040cf..639c220 100644 --- a/drivers/media/tuners/r820t.c +++ b/drivers/media/tuners/r820t.c @@ -775,6 +775,19 @@ static int r820t_sysfreq_sel(struct r820t_priv *priv, u32 freq, div_buf_cur = 0x30; /* 11, 150u */ filter_cur = 0x40; /* 10, low */ break; + case SYS_DVBC_ANNEX_A: + mixer_top = 0x24; /* mixer top:13 , top-1, low-discharge */ + lna_top = 0xe5; + lna_vth_l = 0x62; + mixer_vth_l = 0x75; + air_cable1_in = 0x60; + cable2_in = 0x00; + pre_dect = 0x40; + lna_discharge = 14; + cp_cur = 0x38; /* 111, auto */ + div_buf_cur = 0x30; /* 11, 150u */ + filter_cur = 0x40; /* 10, low */ + break; default: /* DVB-T 8M */ mixer_top = 0x24; /* mixer top:13 , top-1, low-discharge */ lna_top = 0xe5; /* detect bw 3, lna top:4, predet top:2 */ -- 2.1.0 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
cron job: media_tree daily build: ERRORS
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun Feb 15 04:00:16 CET 2015 git branch: test git hash: 135f9be9194cf7778eb73594aa55791b229cf27c gcc version:i686-linux-gcc (GCC) 4.9.1 sparse version: v0.5.0-41-g6c2d743 smatch version: 0.4.1-3153-g7d56ab3 host hardware: x86_64 host os:3.18.0-5.slh.1-amd64 linux-git-arm-at91: ERRORS linux-git-arm-davinci: ERRORS linux-git-arm-exynos: ERRORS linux-git-arm-mx: ERRORS linux-git-arm-omap: ERRORS linux-git-arm-omap1: ERRORS linux-git-arm-pxa: ERRORS linux-git-blackfin: OK linux-git-i686: OK linux-git-m32r: OK linux-git-mips: ERRORS linux-git-powerpc64: OK linux-git-sh: ERRORS linux-git-x86_64: OK linux-2.6.32.27-i686: OK linux-2.6.33.7-i686: OK linux-2.6.34.7-i686: OK linux-2.6.35.9-i686: OK linux-2.6.36.4-i686: OK linux-2.6.37.6-i686: OK linux-2.6.38.8-i686: OK linux-2.6.39.4-i686: OK linux-3.0.60-i686: OK linux-3.1.10-i686: OK linux-3.2.37-i686: OK linux-3.3.8-i686: OK linux-3.4.27-i686: OK linux-3.5.7-i686: OK linux-3.6.11-i686: OK linux-3.7.4-i686: OK linux-3.8-i686: WARNINGS linux-3.9.2-i686: WARNINGS linux-3.10.1-i686: ERRORS linux-3.11.1-i686: ERRORS linux-3.12.23-i686: ERRORS linux-3.13.11-i686: ERRORS linux-3.14.9-i686: ERRORS linux-3.15.2-i686: ERRORS linux-3.16-i686: ERRORS linux-3.17.8-i686: ERRORS linux-3.18-i686: ERRORS linux-3.19-rc4-i686: OK linux-2.6.32.27-x86_64: OK linux-2.6.33.7-x86_64: OK linux-2.6.34.7-x86_64: OK linux-2.6.35.9-x86_64: OK linux-2.6.36.4-x86_64: OK linux-2.6.37.6-x86_64: OK linux-2.6.38.8-x86_64: OK linux-2.6.39.4-x86_64: OK linux-3.0.60-x86_64: OK linux-3.1.10-x86_64: OK linux-3.2.37-x86_64: OK linux-3.3.8-x86_64: OK linux-3.4.27-x86_64: OK linux-3.5.7-x86_64: OK linux-3.6.11-x86_64: OK linux-3.7.4-x86_64: OK linux-3.8-x86_64: WARNINGS linux-3.9.2-x86_64: WARNINGS linux-3.10.1-x86_64: ERRORS linux-3.11.1-x86_64: ERRORS linux-3.12.23-x86_64: ERRORS linux-3.13.11-x86_64: ERRORS linux-3.14.9-x86_64: ERRORS linux-3.15.2-x86_64: ERRORS linux-3.16-x86_64: ERRORS linux-3.17.8-x86_64: ERRORS linux-3.18-x86_64: ERRORS linux-3.19-rc4-x86_64: OK apps: OK spec-git: OK sparse: ERRORS ABI WARNING: change for arm-at91 ABI WARNING: change for arm-davinci ABI WARNING: change for arm-exynos ABI WARNING: change for arm-mx ABI WARNING: change for arm-omap ABI WARNING: change for arm-omap1 ABI WARNING: change for arm-pxa ABI WARNING: change for blackfin ABI WARNING: change for i686 ABI WARNING: change for m32r ABI WARNING: change for mips ABI WARNING: change for powerpc64 ABI WARNING: change for sh ABI WARNING: change for x86_64 smatch: ERRORS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Sunday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Sunday.tar.bz2 The Media Infrastructure API from this daily build is here: http://www.xs4all.nl/~hverkuil/spec/media.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [REGRESSION] media: cx23885 broken by commit 453afdd [media] cx23885: convert to vb2
Hi Hans, On Fri, 2015-02-13 at 10:24 +0100, Hans Verkuil wrote: Jurgen, Raimond, On 02/13/2015 10:12 AM, Hans Verkuil wrote: Hi Jurgen, On 02/04/2015 06:21 PM, Jurgen Kramer wrote: On Wed, 2015-02-04 at 17:19 +0100, Hans Verkuil wrote: On 02/04/2015 05:06 PM, Jurgen Kramer wrote: Hi Hans, On Mon, 2015-02-02 at 10:36 +0100, Hans Verkuil wrote: Raimonds and Jurgen, Can you both test with the following patch applied to the driver: Unfortunately the mpeg error is not (completely) gone: OK, I suspected that might be the case. Is the UNBALANCED warning gone with my vb2 patch? When you see this risc error, does anything break (broken up video) or crash, or does it just keep on streaming? Can you comment on this question? The UNBALANCED warnings have not reappeared (so far). And they are still gone? If that's the case, then I'll merge the patch fixing this for 3.20. With respect to the risc error: the only reason I can think of is that it is a race condition when the risc program is updated. I'll see if I can spend some time on this today or on Monday. Can you give me an indication how often you see this risc error message? Can you both apply this patch and let me know what it says the next time you get a risc error message? I just realized that important information was never logged, so with luck this might help me pinpoint the problem. So far I got one mpeg error: [81639.485605] cx23885[2]: mpeg risc op code error 10001 0 [81639.485610] cx23885[2]: TS1 B - dma channel status dump [81639.485612] cx23885[2]: cmds: init risc lo : 0x053aa000 [81639.485615] cx23885[2]: cmds: init risc hi : 0x [81639.485617] cx23885[2]: cmds: cdt base : 0x00010580 [81639.485620] cx23885[2]: cmds: cdt size : 0x000a [81639.485622] cx23885[2]: cmds: iq base: 0x00010400 [81639.485625] cx23885[2]: cmds: iq size: 0x0010 [81639.485628] cx23885[2]: cmds: risc pc lo : 0x048e5048 [81639.485630] cx23885[2]: cmds: risc pc hi : 0x [81639.485633] cx23885[2]: cmds: iq wr ptr : 0x4105 [81639.485636] cx23885[2]: cmds: iq rd ptr : 0x4109 [81639.485638] cx23885[2]: cmds: cdt current: 0x000105a8 [81639.485640] cx23885[2]: cmds: pci target lo : 0xadc44000 [81639.485642] cx23885[2]: cmds: pci target hi : 0x [81639.485645] cx23885[2]: cmds: line / byte: 0x0020 [81639.485648] cx23885[2]: risc0: 0x1c0002f0 [ write sol eol count=752 ] [81639.485651] cx23885[2]: risc1: 0xadc44000 [ readc sol eol irq1 23 22 18 14 count=0 ] [81639.485655] cx23885[2]: risc2: 0x [ INVALID count=0 ] [81639.485658] cx23885[2]: risc3: 0x1c0002f0 [ write sol eol count=752 ] [81639.485661] cx23885[2]: (0x00010400) iq 0: 0xadc448d0 [ readc sol eol irq1 23 22 18 14 count=2256 ] [81639.485665] cx23885[2]: (0x00010404) iq 1: 0x [ INVALID count=0 ] [81639.485667] cx23885[2]: (0x00010408) iq 2: 0x1c0002f0 [ write sol eol count=752 ] [81639.485670] cx23885[2]: iq 3: 0xadc44bc0 [ arg #1 ] [81639.485672] cx23885[2]: iq 4: 0x [ arg #2 ] [81639.485674] cx23885[2]: (0x00010414) iq 5: 0x7100 [ jump irq1 count=0 ] [81639.485677] cx23885[2]: iq 6: 0x1c0002f0 [ arg #1 ] [81639.485679] cx23885[2]: iq 7: 0xadc44000 [ arg #2 ] [81639.485682] cx23885[2]: (0x00010420) iq 8: 0x [ INVALID count=0 ] [81639.485684] cx23885[2]: (0x00010424) iq 9: 0x1c0002f0 [ write sol eol count=752 ] [81639.485687] cx23885[2]: iq a: 0xadc442f0 [ arg #1 ] [81639.485689] cx23885[2]: iq b: 0x [ arg #2 ] [81639.485691] cx23885[2]: (0x00010430) iq c: 0x1c0002f0 [ write sol eol count=752 ] [81639.485694] cx23885[2]: iq d: 0xadc445e0 [ arg #1 ] [81639.485696] cx23885[2]: iq e: 0x [ arg #2 ] [81639.485698] cx23885[2]: (0x0001043c) iq f: 0x1c0002f0 [ write sol eol count=752 ] [81639.485701] cx23885[2]: iq 10: 0x3efdbb2f [ arg #1 ] [81639.485704] cx23885[2]: iq 11: 0xbb1ae8fd [ arg #2 ] [81639.485704] cx23885[2]: fifo: 0x5000 - 0x6000 [81639.485705] cx23885[2]: ctrl: 0x00010400 - 0x10460 [81639.485707] cx23885[2]: ptr1_reg: 0x5700 [81639.485709] cx23885[2]: ptr2_reg: 0x000105a8 [81639.485711] cx23885[2]: cnt1_reg: 0x0012 [81639.485714] cx23885[2]: cnt2_reg: 0x0005 Best regards, Jurgen -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
