cron job: media_tree daily build: ERRORS
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat May 2 04:00:16 CEST 2015 git branch: test git hash: ebf984bb151e9952cccd060d3aba0b4d30a87e81 gcc version:i686-linux-gcc (GCC) 5.1.0 sparse version: v0.5.0-44-g40791b9 smatch version: 0.4.1-3153-g7d56ab3 host hardware: x86_64 host os:4.0.0-0.slh.3-amd64 linux-git-arm-at91: OK linux-git-arm-davinci: WARNINGS linux-git-arm-exynos: OK linux-git-arm-mx: OK linux-git-arm-omap: ERRORS linux-git-arm-omap1: OK linux-git-arm-pxa: OK linux-git-blackfin-bf561: OK linux-git-i686: OK linux-git-m32r: OK linux-git-mips: OK linux-git-powerpc64: OK linux-git-sh: OK linux-git-x86_64: OK linux-2.6.32.27-i686: ERRORS linux-2.6.33.7-i686: ERRORS linux-2.6.34.7-i686: ERRORS linux-2.6.35.9-i686: ERRORS linux-2.6.36.4-i686: ERRORS linux-2.6.37.6-i686: ERRORS linux-2.6.38.8-i686: ERRORS linux-2.6.39.4-i686: ERRORS linux-3.0.60-i686: ERRORS linux-3.1.10-i686: ERRORS linux-3.2.37-i686: ERRORS linux-3.3.8-i686: ERRORS linux-3.4.27-i686: ERRORS linux-3.5.7-i686: ERRORS linux-3.6.11-i686: ERRORS linux-3.7.4-i686: ERRORS linux-3.8-i686: ERRORS linux-3.9.2-i686: ERRORS linux-3.10.1-i686: ERRORS linux-3.11.1-i686: ERRORS linux-3.12.23-i686: ERRORS linux-3.13.11-i686: ERRORS linux-3.14.9-i686: ERRORS linux-3.15.2-i686: ERRORS linux-3.16.7-i686: WARNINGS linux-3.17.8-i686: WARNINGS linux-3.18.7-i686: WARNINGS linux-3.19-i686: WARNINGS linux-4.0-i686: WARNINGS linux-4.1-rc1-i686: WARNINGS linux-2.6.32.27-x86_64: ERRORS linux-2.6.33.7-x86_64: ERRORS linux-2.6.34.7-x86_64: ERRORS linux-2.6.35.9-x86_64: ERRORS linux-2.6.36.4-x86_64: ERRORS linux-2.6.37.6-x86_64: ERRORS linux-2.6.38.8-x86_64: ERRORS linux-2.6.39.4-x86_64: ERRORS linux-3.0.60-x86_64: ERRORS linux-3.1.10-x86_64: ERRORS linux-3.2.37-x86_64: ERRORS linux-3.3.8-x86_64: ERRORS linux-3.4.27-x86_64: ERRORS linux-3.5.7-x86_64: ERRORS linux-3.6.11-x86_64: ERRORS linux-3.7.4-x86_64: ERRORS linux-3.8-x86_64: ERRORS linux-3.9.2-x86_64: ERRORS linux-3.10.1-x86_64: ERRORS linux-3.11.1-x86_64: ERRORS linux-3.12.23-x86_64: ERRORS linux-3.13.11-x86_64: ERRORS linux-3.14.9-x86_64: ERRORS linux-3.15.2-x86_64: ERRORS linux-3.16.7-x86_64: OK linux-3.17.8-x86_64: OK linux-3.18.7-x86_64: OK linux-3.19-x86_64: OK linux-4.0-x86_64: WARNINGS linux-4.1-rc1-x86_64: WARNINGS apps: OK spec-git: OK sparse: WARNINGS smatch: ERRORS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Saturday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Saturday.tar.bz2 The Media Infrastructure API from this daily build is here: http://www.xs4all.nl/~hverkuil/spec/media.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] media: Fix regression in some more dib0700 based devices.
Fix an oops during device initialization by correctly setting size_of_priv
instead of leaving it 0.
The regression was introduced by 8abe4a0a3f6d4217b16a ([media] dib7000:
export just one symbol) and only fixed for one type of dib0700 based
devices in 9e334c75642b6e5bfb95 ([media] Fix regression in some dib0700
based devices).
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=92301
Fixes: 8abe4a0a3f6d4217b16a ([media] dib7000: export just one symbol)
Signed-off-by: Thomas Reitmayr treitm...@devbase.at
---
drivers/media/usb/dvb-usb/dib0700_devices.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/media/usb/dvb-usb/dib0700_devices.c
b/drivers/media/usb/dvb-usb/dib0700_devices.c
index 90cee38..e87ce83 100644
--- a/drivers/media/usb/dvb-usb/dib0700_devices.c
+++ b/drivers/media/usb/dvb-usb/dib0700_devices.c
@@ -3944,6 +3944,8 @@ struct dvb_usb_device_properties dib0700_devices[] = {
DIB0700_DEFAULT_STREAMING_CONFIG(0x02),
}},
+ .size_of_priv = sizeof(struct
+ dib0700_adapter_state),
}, {
.num_frontends = 1,
.fe = {{
@@ -3956,6 +3958,8 @@ struct dvb_usb_device_properties dib0700_devices[] = {
DIB0700_DEFAULT_STREAMING_CONFIG(0x03),
}},
+ .size_of_priv = sizeof(struct
+ dib0700_adapter_state),
}
},
@@ -4009,6 +4013,8 @@ struct dvb_usb_device_properties dib0700_devices[] = {
DIB0700_DEFAULT_STREAMING_CONFIG(0x02),
}},
+ .size_of_priv = sizeof(struct
+ dib0700_adapter_state),
},
},
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] staging: media: omap4iss: Constify platform_device_id
Hi Krzysztof,
Thank you for the patch.
On Saturday 02 May 2015 00:43:07 Krzysztof Kozlowski wrote:
The platform_device_id is not modified by the driver and core uses it as
const.
Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
and applied to my tree. I'll send a pull request for v4.2.
---
drivers/staging/media/omap4iss/iss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/omap4iss/iss.c
b/drivers/staging/media/omap4iss/iss.c index e0ad5e520e2d..68867f286afd
100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -1478,7 +1478,7 @@ static int iss_remove(struct platform_device *pdev)
return 0;
}
-static struct platform_device_id omap4iss_id_table[] = {
+static const struct platform_device_id omap4iss_id_table[] = {
{ omap4iss, 0 },
{ },
};
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[linuxtv-media:master 880/883] drivers/media/i2c/sr030pc30.c:526:33: warning: array subscript is below array bounds
tree: git://linuxtv.org/media_tree.git master
head: ebf984bb151e9952cccd060d3aba0b4d30a87e81
commit: 717fd5b4907ada90ceb069d484068aaa01c58bb0 [880/883] [media] v4l2:
replace try_mbus_fmt by set_fmt
config: x86_64-randconfig-ib0-05020929 (attached as .config)
reproduce:
git checkout 717fd5b4907ada90ceb069d484068aaa01c58bb0
# save the attached .config to linux build tree
make ARCH=x86_64
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
All warnings:
drivers/media/i2c/sr030pc30.c: In function 'sr030pc30_set_fmt':
drivers/media/i2c/sr030pc30.c:526:33: warning: array subscript is below
array bounds [-Warray-bounds]
mf-code = sr030pc30_formats[i].code;
^
drivers/media/i2c/sr030pc30.c:526:30: warning: array subscript is below
array bounds [-Warray-bounds]
mf-code = sr030pc30_formats[i].code;
^
vim +526 drivers/media/i2c/sr030pc30.c
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 510
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 511
return 0;
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 512 }
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 513
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 514 /*
Return nearest media bus frame format. */
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 515
static const struct sr030pc30_format *try_fmt(struct v4l2_subdev *sd,
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 516
struct v4l2_mbus_framefmt *mf)
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 517 {
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 518
int i = ARRAY_SIZE(sr030pc30_formats);
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 519
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 520
sr030pc30_try_frame_size(mf);
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 521
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 522
while (i--)
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 523
if (mf-code == sr030pc30_formats[i].code)
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 524
break;
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 525
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 @526
mf-code = sr030pc30_formats[i].code;
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 527
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 528
return sr030pc30_formats[i];
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 529 }
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 530
3e9c2b84 drivers/media/video/sr030pc30.c Sylwester Nawrocki 2010-10-11 531 /*
Return nearest media bus frame format. */
717fd5b4 drivers/media/i2c/sr030pc30.c Hans Verkuil 2015-04-09 532
static int sr030pc30_set_fmt(struct v4l2_subdev *sd,
717fd5b4 drivers/media/i2c/sr030pc30.c Hans Verkuil 2015-04-09 533
struct v4l2_subdev_pad_config *cfg,
717fd5b4 drivers/media/i2c/sr030pc30.c Hans Verkuil 2015-04-09 534
struct v4l2_subdev_format *format)
:: The code at line 526 was first introduced by commit
:: 3e9c2b8477059c3ae39ed9373fddd23e4c754acc [media] Add driver for
Siliconfile SR030PC30 VGA camera
:: TO: Sylwester Nawrocki s.nawro...@samsung.com
:: CC: Mauro Carvalho Chehab mche...@redhat.com
---
0-DAY kernel test infrastructureOpen Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
#
# Automatically generated file; DO NOT EDIT.
# Linux/x86_64 4.1.0-rc1 Kernel Configuration
#
CONFIG_64BIT=y
CONFIG_X86_64=y
CONFIG_X86=y
CONFIG_INSTRUCTION_DECODER=y
CONFIG_PERF_EVENTS_INTEL_UNCORE=y
CONFIG_OUTPUT_FORMAT=elf64-x86-64
CONFIG_ARCH_DEFCONFIG=arch/x86/configs/x86_64_defconfig
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_HAVE_LATENCYTOP_SUPPORT=y
CONFIG_MMU=y
CONFIG_NEED_DMA_MAP_STATE=y
CONFIG_NEED_SG_DMA_LENGTH=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_BUG=y
CONFIG_GENERIC_BUG_RELATIVE_POINTERS=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_ARCH_HAS_CPU_RELAX=y
CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y
CONFIG_HAVE_SETUP_PER_CPU_AREA=y
CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y
CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y
CONFIG_ARCH_HIBERNATION_POSSIBLE=y
CONFIG_ARCH_SUSPEND_POSSIBLE=y
CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y
CONFIG_ARCH_WANT_GENERAL_HUGETLB=y
CONFIG_ZONE_DMA32=y
CONFIG_AUDIT_ARCH=y
Re: Mystique SaTiX-S2 Sky V2 USB (DVBSKY S960 clone) - Linux driver.
On 05/01/2015 04:57 PM, Steve wrote: Hi, I'm trying a direct mail to you as you are associated with this page: http://linuxtv.org/wiki/index.php/DVB-S2_USB_Devices I have bought a Mystique SaTiX-S2 Sky V2 USB (DVBSKY S960 clone) - but it doesn't work with my 3.19 kernel, which I'd assumed it would from the above page. I've tried asking about the problem in various ways - first to AskUbuntu: http://askubuntu.com/questions/613406/absent-frontend0-with-usb-dvbsky-s960-s860-driver-bug ... and, more recently, on the Linux-Media mailing list. Without convincing myself that I've contacted the right person/people to give constructive feedback. By any chance can you offer me some advice about who it is best to approach? (Obviously I'd also be grateful if you can shed any light on this problem.) Steve Hi Steve, The page actually states Support in-kernel is expected in Linux kernel 3.18.. Devil's advocate, but it doesn't say it's actually there or guarantees it ever will. At the time it was written, 3.18 wasn't out yet. Looking at your dmesg output however it seems your kernel is aware of the device. (so the patch made it) As for me, I was offered a bargain for another device so I have no S960. Linux-media mailing list is the right place. (and here we are) A few quick suggestions: Did you really, really, really get the right firmware and are you absolutely positive it's in the right location and has the right filename? Does dmesg mention the firmware being loaded? Get/compile the latest v4l-dvb sources. (http://linuxtv.org/wiki/index.php/How_to_Obtain,_Build_and_Install_V4L-DVB_Device_Drivers) Maybe it's just a bug that has already been fixed. Try another program to access the device. But if even lsusb hangs, this is pretty much moot. Make sure the power supply/device is functioning properly. Try it on another OS to make sure it's not defective. Try another computer, preferably with another chipset. If your RAM is faulty or you have a funky USB-controller, you can experience strange problems. Good luck! Best regards, P. van Gaans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[linuxtv-media:master 834/883] drivers/media/pci/saa7164/saa7164-i2c.c:45:33: sparse: Using plain integer as NULL pointer
tree: git://linuxtv.org/media_tree.git master
head: ebf984bb151e9952cccd060d3aba0b4d30a87e81
commit: 5f954b5be4bf42e85e0a204518499bda8ee2f419 [834/883] [media] saa7164: I2C
improvements for upcoming HVR2255/2205 boards
reproduce:
# apt-get install sparse
git checkout 5f954b5be4bf42e85e0a204518499bda8ee2f419
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by )
drivers/media/pci/saa7164/saa7164-i2c.c:45:33: sparse: Using plain integer
as NULL pointer
vim +45 drivers/media/pci/saa7164/saa7164-i2c.c
29
30 static int i2c_xfer(struct i2c_adapter *i2c_adap, struct i2c_msg *msgs,
int num)
31 {
32 struct saa7164_i2c *bus = i2c_adap-algo_data;
33 struct saa7164_dev *dev = bus-dev;
34 int i, retval = 0;
35
36 dprintk(DBGLVL_I2C, %s(num = %d)\n, __func__, num);
37
38 for (i = 0 ; i num; i++) {
39 dprintk(DBGLVL_I2C, %s(num = %d) addr = 0x%02x len =
0x%x\n,
40 __func__, num, msgs[i].addr, msgs[i].len);
41 if (msgs[i].flags I2C_M_RD) {
42 retval = saa7164_api_i2c_read(bus,
43 msgs[i].addr,
44 0 /* reglen */,
45 0 /* reg */, msgs[i].len, msgs[i].buf);
46 } else if (i + 1 num (msgs[i + 1].flags
I2C_M_RD)
47 msgs[i].addr == msgs[i + 1].addr) {
48 /* write then read from same address */
49
50 retval = saa7164_api_i2c_read(bus, msgs[i].addr,
51 msgs[i].len, msgs[i].buf,
52 msgs[i+1].len, msgs[i+1].buf
53 );
---
0-DAY kernel test infrastructureOpen Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] staging: media: omap4iss: Constify platform_device_id
The platform_device_id is not modified by the driver and core uses it as
const.
Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com
---
drivers/staging/media/omap4iss/iss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/omap4iss/iss.c
b/drivers/staging/media/omap4iss/iss.c
index e0ad5e520e2d..68867f286afd 100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -1478,7 +1478,7 @@ static int iss_remove(struct platform_device *pdev)
return 0;
}
-static struct platform_device_id omap4iss_id_table[] = {
+static const struct platform_device_id omap4iss_id_table[] = {
{ omap4iss, 0 },
{ },
};
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/4] media: platform: s3c-camif: Constify platform_device_id
The platform_device_id is not modified by the driver and core uses it as
const.
Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com
---
drivers/media/platform/s3c-camif/camif-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s3c-camif/camif-core.c
b/drivers/media/platform/s3c-camif/camif-core.c
index 2d5bd3ac7f81..f47b332f0418 100644
--- a/drivers/media/platform/s3c-camif/camif-core.c
+++ b/drivers/media/platform/s3c-camif/camif-core.c
@@ -628,7 +628,7 @@ static struct s3c_camif_drvdata s3c6410_camif_drvdata = {
.bus_clk_freq = 13300UL,
};
-static struct platform_device_id s3c_camif_driver_ids[] = {
+static const struct platform_device_id s3c_camif_driver_ids[] = {
{
.name = s3c2440-camif,
.driver_data= (unsigned long)s3c244x_camif_drvdata,
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4/4] media: platform: sp5: Constify platform_device_id
The platform_device_id is not modified by the driver and core uses it as
const.
Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com
---
drivers/media/platform/s5p-g2d/g2d.c | 2 +-
drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 +-
drivers/media/platform/s5p-tv/hdmi_drv.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/s5p-g2d/g2d.c
b/drivers/media/platform/s5p-g2d/g2d.c
index ec3e1248923d..421a7c3b595b 100644
--- a/drivers/media/platform/s5p-g2d/g2d.c
+++ b/drivers/media/platform/s5p-g2d/g2d.c
@@ -787,7 +787,7 @@ static const struct of_device_id exynos_g2d_match[] = {
};
MODULE_DEVICE_TABLE(of, exynos_g2d_match);
-static struct platform_device_id g2d_driver_ids[] = {
+static const struct platform_device_id g2d_driver_ids[] = {
{
.name = s5p-g2d,
.driver_data = (unsigned long)g2d_drvdata_v3x,
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c
b/drivers/media/platform/s5p-mfc/s5p_mfc.c
index 8333fbc2fe96..fa878cb04004 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
@@ -1463,7 +1463,7 @@ static struct s5p_mfc_variant mfc_drvdata_v8 = {
.fw_name[0] = s5p-mfc-v8.fw,
};
-static struct platform_device_id mfc_driver_ids[] = {
+static const struct platform_device_id mfc_driver_ids[] = {
{
.name = s5p-mfc,
.driver_data = (unsigned long)mfc_drvdata_v5,
diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c
b/drivers/media/platform/s5p-tv/hdmi_drv.c
index 0e74aabf5f9a..e8c069de6238 100644
--- a/drivers/media/platform/s5p-tv/hdmi_drv.c
+++ b/drivers/media/platform/s5p-tv/hdmi_drv.c
@@ -96,7 +96,7 @@ struct hdmi_device {
struct hdmi_resources res;
};
-static struct platform_device_id hdmi_driver_types[] = {
+static const struct platform_device_id hdmi_driver_types[] = {
{
.name = s5pv210-hdmi,
}, {
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/4] media: platform: exynos4-is: Constify platform_device_id
The platform_device_id is not modified by the driver and core uses it as
const.
Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com
---
drivers/media/platform/exynos4-is/media-dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/exynos4-is/media-dev.c
b/drivers/media/platform/exynos4-is/media-dev.c
index f315ef946cd4..4f5586a4cbff 100644
--- a/drivers/media/platform/exynos4-is/media-dev.c
+++ b/drivers/media/platform/exynos4-is/media-dev.c
@@ -1451,7 +1451,7 @@ static int fimc_md_remove(struct platform_device *pdev)
return 0;
}
-static struct platform_device_id fimc_driver_ids[] __always_unused = {
+static const struct platform_device_id fimc_driver_ids[] __always_unused = {
{ .name = s5p-fimc-md },
{ },
};
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/4] media: platform: exynos-gsc: Constify platform_device_id
The platform_device_id is not modified by the driver and core uses it as
const.
Signed-off-by: Krzysztof Kozlowski k.kozlowsk...@gmail.com
---
drivers/media/platform/exynos-gsc/gsc-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c
b/drivers/media/platform/exynos-gsc/gsc-core.c
index fd2891c886a3..9b9e423e4fc4 100644
--- a/drivers/media/platform/exynos-gsc/gsc-core.c
+++ b/drivers/media/platform/exynos-gsc/gsc-core.c
@@ -967,7 +967,7 @@ static struct gsc_driverdata gsc_v_100_drvdata = {
.lclk_frequency = 26600UL,
};
-static struct platform_device_id gsc_driver_ids[] = {
+static const struct platform_device_id gsc_driver_ids[] = {
{
.name = exynos-gsc,
.driver_data= (unsigned long)gsc_v_100_drvdata,
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: issue with TechnoTrend CT2-4650 CI
Hi Olli, thank You very much for your reply, it was misunderstanding on my side, because i thought that this module message: [ 102.005119] dvb_ca adapter 0: DVB CAM detected and initialised successfully means that CAM was initialized ... so i used : dvb-fe-tool -d DVBC/ANNEX_A -- my tuner was originally in DVB-T mode, so gnutv was unsuccessful ... gnutv -timeout 1 -out file /var/tmp/test.ts -channels ... results are that i can tune channels correctly but i'm unable to watch encrypted channels, i used vlc, on wind* i can watch also encrypted :-( please could you help me ? Kind regards, Michal 2015-05-01 15:46 GMT+02:00 Olli Salonen olli.salo...@iki.fi: Hi Michal, I've seen something like this before with some CAMs. It seems that the CAM needs to be initialized if it is plugged in. This does not happen if you use software which does not have CAM support (such as w_scan). The linuxtv.org wiki has the following comment on the CT2-4650 page: Some CAMs require initialization before they will work. Without initialization it's possible that even non-encrypted channels do not work. If there's no CAM inserted, there's no issue. gnutv could be used to initialize the CAM, for example: gnutv -timeout 1 -out file /var/tmp/test.ts -channels ~/channels.conf FOX Of course ideally the CAM should be initialized by the driver... Cheers, -olli On 1 May 2015 at 11:39, Michal B developer...@gmail.com wrote: Hi all, i bought new TechnoTrend CT2-4650 CI , i tried to use it on wind* , successfuly also with encrypted channels with CAM, then i tried on linux with kernel 3.19.6, and i got two behaviors: when CAM is unplugged i'm able to watch unencrypted channels correctly, but when i plugged in CAM i'm unable to find any channel during scan with w_scan, and also i'm unable to tune any channel previously found, and i have second issue: when i have CAM plugged and i unplug TechnoTrend from USB on my computer - my computer freezes - so i have to reset by button on the case, please somebody could help me to get it running with CAM to watch encrypted channels ? here is output when CAM is unplugged: [ 1381.807428] usb 3-10: new high-speed USB device number 4 using xhci_hcd [ 1381.935870] usb 3-10: New USB device found, idVendor=0b48, idProduct=3012 [ 1381.935872] usb 3-10: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 1381.935874] usb 3-10: Product: TechnoTrend USB2.0 [ 1381.935874] usb 3-10: Manufacturer: CityCom GmbH [ 1381.935875] usb 3-10: SerialNumber: 20130422 [ 1382.222836] usb 3-10: dvb_usb_v2: found a 'TechnoTrend TT-connect CT2-4650 CI' in warm state [ 1382.222868] usb 3-10: dvb_usb_v2: will pass the complete MPEG2 transport stream to the software demuxer [ 1382.222875] DVB: registering new adapter (TechnoTrend TT-connect CT2-4650 CI) [ 1382.224114] usb 3-10: dvb_usb_v2: MAC address: bc:ea:2b:65:00:ad [ 1382.245403] i2c i2c-7: Added multiplexed i2c bus 8 [ 1382.245406] si2168 7-0064: Silicon Labs Si2168 successfully attached [ 1382.259984] si2157 8-0060: Silicon Labs Si2147/2148/2157/2158 successfully attached [ 1382.273787] sp2 7-0040: CIMaX SP2 successfully attached [ 1382.273794] usb 3-10: DVB: registering adapter 0 frontend 0 (Silicon Labs Si2168)... [ 1382.310693] Registered IR keymap rc-tt-1500 [ 1382.310744] input: TechnoTrend TT-connect CT2-4650 CI as /devices/pci:00/:00:14.0/usb3/3-10/rc/rc0/input23 [ 1382.310827] rc0: TechnoTrend TT-connect CT2-4650 CI as /devices/pci:00/:00:14.0/usb3/3-10/rc/rc0 [ 1382.310831] usb 3-10: dvb_usb_v2: schedule remote query interval to 300 msecs [ 1382.310832] usb 3-10: dvb_usb_v2: 'TechnoTrend TT-connect CT2-4650 CI' successfully initialized and connected [ 1382.310847] usbcore: registered new interface driver dvb_usb_dvbsky when i start vlc: [ 1485.824805] si2168 7-0064: found a 'Silicon Labs Si2168' in cold state [ 1485.835991] si2168 7-0064: downloading firmware from file 'dvb-demod-si2168-a20-01.fw' [ 1491.074442] si2168 7-0064: found a 'Silicon Labs Si2168' in warm state [ 1491.083144] si2157 8-0060: found a 'Silicon Labs Si2146/2147/2148/2157/2158' in cold state [ 1491.090486] si2157 8-0060: downloading firmware from file 'dvb-tuner-si2158-a20-01.fw' Kind regards, -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: issue with TechnoTrend CT2-4650 CI
Hi Olli, i'm taking back my question ... so i found that vdr is most suitable for me ... thank You for helping me to get through it also running correctly encrypted chans ... thank You again, Kind regards, Michal 2015-05-01 16:52 GMT+02:00 Michal B developer...@gmail.com: Hi Olli, thank You very much for your reply, it was misunderstanding on my side, because i thought that this module message: [ 102.005119] dvb_ca adapter 0: DVB CAM detected and initialised successfully means that CAM was initialized ... so i used : dvb-fe-tool -d DVBC/ANNEX_A -- my tuner was originally in DVB-T mode, so gnutv was unsuccessful ... gnutv -timeout 1 -out file /var/tmp/test.ts -channels ... results are that i can tune channels correctly but i'm unable to watch encrypted channels, i used vlc, on wind* i can watch also encrypted :-( please could you help me ? Kind regards, Michal 2015-05-01 15:46 GMT+02:00 Olli Salonen olli.salo...@iki.fi: Hi Michal, I've seen something like this before with some CAMs. It seems that the CAM needs to be initialized if it is plugged in. This does not happen if you use software which does not have CAM support (such as w_scan). The linuxtv.org wiki has the following comment on the CT2-4650 page: Some CAMs require initialization before they will work. Without initialization it's possible that even non-encrypted channels do not work. If there's no CAM inserted, there's no issue. gnutv could be used to initialize the CAM, for example: gnutv -timeout 1 -out file /var/tmp/test.ts -channels ~/channels.conf FOX Of course ideally the CAM should be initialized by the driver... Cheers, -olli On 1 May 2015 at 11:39, Michal B developer...@gmail.com wrote: Hi all, i bought new TechnoTrend CT2-4650 CI , i tried to use it on wind* , successfuly also with encrypted channels with CAM, then i tried on linux with kernel 3.19.6, and i got two behaviors: when CAM is unplugged i'm able to watch unencrypted channels correctly, but when i plugged in CAM i'm unable to find any channel during scan with w_scan, and also i'm unable to tune any channel previously found, and i have second issue: when i have CAM plugged and i unplug TechnoTrend from USB on my computer - my computer freezes - so i have to reset by button on the case, please somebody could help me to get it running with CAM to watch encrypted channels ? here is output when CAM is unplugged: [ 1381.807428] usb 3-10: new high-speed USB device number 4 using xhci_hcd [ 1381.935870] usb 3-10: New USB device found, idVendor=0b48, idProduct=3012 [ 1381.935872] usb 3-10: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 1381.935874] usb 3-10: Product: TechnoTrend USB2.0 [ 1381.935874] usb 3-10: Manufacturer: CityCom GmbH [ 1381.935875] usb 3-10: SerialNumber: 20130422 [ 1382.222836] usb 3-10: dvb_usb_v2: found a 'TechnoTrend TT-connect CT2-4650 CI' in warm state [ 1382.222868] usb 3-10: dvb_usb_v2: will pass the complete MPEG2 transport stream to the software demuxer [ 1382.222875] DVB: registering new adapter (TechnoTrend TT-connect CT2-4650 CI) [ 1382.224114] usb 3-10: dvb_usb_v2: MAC address: bc:ea:2b:65:00:ad [ 1382.245403] i2c i2c-7: Added multiplexed i2c bus 8 [ 1382.245406] si2168 7-0064: Silicon Labs Si2168 successfully attached [ 1382.259984] si2157 8-0060: Silicon Labs Si2147/2148/2157/2158 successfully attached [ 1382.273787] sp2 7-0040: CIMaX SP2 successfully attached [ 1382.273794] usb 3-10: DVB: registering adapter 0 frontend 0 (Silicon Labs Si2168)... [ 1382.310693] Registered IR keymap rc-tt-1500 [ 1382.310744] input: TechnoTrend TT-connect CT2-4650 CI as /devices/pci:00/:00:14.0/usb3/3-10/rc/rc0/input23 [ 1382.310827] rc0: TechnoTrend TT-connect CT2-4650 CI as /devices/pci:00/:00:14.0/usb3/3-10/rc/rc0 [ 1382.310831] usb 3-10: dvb_usb_v2: schedule remote query interval to 300 msecs [ 1382.310832] usb 3-10: dvb_usb_v2: 'TechnoTrend TT-connect CT2-4650 CI' successfully initialized and connected [ 1382.310847] usbcore: registered new interface driver dvb_usb_dvbsky when i start vlc: [ 1485.824805] si2168 7-0064: found a 'Silicon Labs Si2168' in cold state [ 1485.835991] si2168 7-0064: downloading firmware from file 'dvb-demod-si2168-a20-01.fw' [ 1491.074442] si2168 7-0064: found a 'Silicon Labs Si2168' in warm state [ 1491.083144] si2157 8-0060: found a 'Silicon Labs Si2146/2147/2148/2157/2158' in cold state [ 1491.090486] si2157 8-0060: downloading firmware from file 'dvb-tuner-si2158-a20-01.fw' Kind regards, -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
issue with TechnoTrend CT2-4650 CI
Hi all, i bought new TechnoTrend CT2-4650 CI , i tried to use it on wind* , successfuly also with encrypted channels with CAM, then i tried on linux with kernel 3.19.6, and i got two behaviors: when CAM is unplugged i'm able to watch unencrypted channels correctly, but when i plugged in CAM i'm unable to find any channel during scan with w_scan, and also i'm unable to tune any channel previously found, and i have second issue: when i have CAM plugged and i unplug TechnoTrend from USB on my computer - my computer freezes - so i have to reset by button on the case, please somebody could help me to get it running with CAM to watch encrypted channels ? here is output when CAM is unplugged: [ 1381.807428] usb 3-10: new high-speed USB device number 4 using xhci_hcd [ 1381.935870] usb 3-10: New USB device found, idVendor=0b48, idProduct=3012 [ 1381.935872] usb 3-10: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 1381.935874] usb 3-10: Product: TechnoTrend USB2.0 [ 1381.935874] usb 3-10: Manufacturer: CityCom GmbH [ 1381.935875] usb 3-10: SerialNumber: 20130422 [ 1382.222836] usb 3-10: dvb_usb_v2: found a 'TechnoTrend TT-connect CT2-4650 CI' in warm state [ 1382.222868] usb 3-10: dvb_usb_v2: will pass the complete MPEG2 transport stream to the software demuxer [ 1382.222875] DVB: registering new adapter (TechnoTrend TT-connect CT2-4650 CI) [ 1382.224114] usb 3-10: dvb_usb_v2: MAC address: bc:ea:2b:65:00:ad [ 1382.245403] i2c i2c-7: Added multiplexed i2c bus 8 [ 1382.245406] si2168 7-0064: Silicon Labs Si2168 successfully attached [ 1382.259984] si2157 8-0060: Silicon Labs Si2147/2148/2157/2158 successfully attached [ 1382.273787] sp2 7-0040: CIMaX SP2 successfully attached [ 1382.273794] usb 3-10: DVB: registering adapter 0 frontend 0 (Silicon Labs Si2168)... [ 1382.310693] Registered IR keymap rc-tt-1500 [ 1382.310744] input: TechnoTrend TT-connect CT2-4650 CI as /devices/pci:00/:00:14.0/usb3/3-10/rc/rc0/input23 [ 1382.310827] rc0: TechnoTrend TT-connect CT2-4650 CI as /devices/pci:00/:00:14.0/usb3/3-10/rc/rc0 [ 1382.310831] usb 3-10: dvb_usb_v2: schedule remote query interval to 300 msecs [ 1382.310832] usb 3-10: dvb_usb_v2: 'TechnoTrend TT-connect CT2-4650 CI' successfully initialized and connected [ 1382.310847] usbcore: registered new interface driver dvb_usb_dvbsky when i start vlc: [ 1485.824805] si2168 7-0064: found a 'Silicon Labs Si2168' in cold state [ 1485.835991] si2168 7-0064: downloading firmware from file 'dvb-demod-si2168-a20-01.fw' [ 1491.074442] si2168 7-0064: found a 'Silicon Labs Si2168' in warm state [ 1491.083144] si2157 8-0060: found a 'Silicon Labs Si2146/2147/2148/2157/2158' in cold state [ 1491.090486] si2157 8-0060: downloading firmware from file 'dvb-tuner-si2158-a20-01.fw' Kind regards, -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] media: i2c: ov2659: add VIDEO_V4L2_SUBDEV_API dependency
Em Fri, 10 Apr 2015 22:28:33 +0100 Lad Prabhakar prabhakar.cse...@gmail.com escreveu: From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch adds dependency of VIDEO_V4L2_SUBDEV_API for VIDEO_OV2659 so that it doesn't complain for random config builds. Actually, this doesn't seem right. Why should this driver depend on an optional API? It should be possible to use it on some bridge driver that doesn't expose the subdev API. So, please fix it the other way, by making subdev API optional on it. Regards, Mauro Reported-by: Randy Dunlap rdun...@infradead.org Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/media/i2c/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index 6f30ea7..8b05681 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -468,7 +468,7 @@ config VIDEO_SMIAPP_PLL config VIDEO_OV2659 tristate OmniVision OV2659 sensor support - depends on VIDEO_V4L2 I2C + depends on VIDEO_V4L2 I2C VIDEO_V4L2_SUBDEV_API depends on MEDIA_CAMERA_SUPPORT ---help--- This is a Video4Linux2 sensor-level driver for the OmniVision -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL FOR v4.2] Two patches
Two more patches for 4.2. The marvell-ccic depended on the marvell pull request to be applied first and the ov2659 patch depended on the new v4l2_of_alloc_parse_endpoint() call to be merged. Regards, Hans The following changes since commit 90ca75fd1945d9e51e21cbde0aae1aad68730dc5: [media] marvell-ccic: fix memory leak on failure path in cafe_smbus_setup() (2015-05-01 07:50:54 -0300) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v4.2g for you to fetch changes up to 55fc08d901fb5f96efb6bdc32dd056ad872fd5dc: marvell-ccic: fix RGB444 format (2015-05-01 13:11:43 +0200) Hans Verkuil (1): marvell-ccic: fix RGB444 format Lad, Prabhakar (1): media: i2c: ov2659: Use v4l2_of_alloc_parse_endpoint() drivers/media/i2c/ov2659.c | 19 ++- drivers/media/platform/marvell-ccic/mcam-core.c | 9 - 2 files changed, 18 insertions(+), 10 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [git:media_tree/master] saa7164: Fix CodingStyle issues added on previous patches
On Fri, May 1, 2015 at 6:33 AM, Mauro Carvalho Chehab
mche...@osg.samsung.com wrote:
This is an automatic generated email to let you know that the following patch
were queued at the
http://git.linuxtv.org/cgit.cgi/media_tree.git tree:
Subject: saa7164: Fix CodingStyle issues added on previous patches
Author: Mauro Carvalho Chehab mche...@osg.samsung.com
Date:Fri May 1 07:30:40 2015 -0300
The patches that added support for HVR2255 and HVR2205 added
some CodingStyle issues.
Better to fix it sooner than latter.
Cc: Steven Toth st...@kernellabs.com
Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com
Acked-By: Steven Toth st...@kernellabs.com
drivers/media/pci/saa7164/saa7164-api.c |3 +-
drivers/media/pci/saa7164/saa7164-dvb.c | 34 ++
2 files changed, 22 insertions(+), 15 deletions(-)
---
http://git.linuxtv.org/cgit.cgi/media_tree.git/commit/?id=3600433f19f59410010770d61ead509d785b8a6e
diff --git a/drivers/media/pci/saa7164/saa7164-api.c
b/drivers/media/pci/saa7164/saa7164-api.c
index a992af6..e807703 100644
--- a/drivers/media/pci/saa7164/saa7164-api.c
+++ b/drivers/media/pci/saa7164/saa7164-api.c
@@ -1467,7 +1467,8 @@ int saa7164_api_i2c_write(struct saa7164_i2c *bus, u8
addr, u32 datalen,
return -EIO;
}
- dprintk(DBGLVL_API, %s() len = %d bytes unitid=0x%x\n, __func__,
len, unitid);
+ dprintk(DBGLVL_API, %s() len = %d bytes unitid=0x%x\n, __func__,
+ len, unitid);
/* Prepare the send buffer */
/* Bytes 00-03 dest register length
diff --git a/drivers/media/pci/saa7164/saa7164-dvb.c
b/drivers/media/pci/saa7164/saa7164-dvb.c
index 0fdc944..c68ce26 100644
--- a/drivers/media/pci/saa7164/saa7164-dvb.c
+++ b/drivers/media/pci/saa7164/saa7164-dvb.c
@@ -629,11 +629,13 @@ int saa7164_dvb_register(struct saa7164_port *port)
if (port-dvb.frontend != NULL) {
if (port-nr == 0) {
- si2157_attach(port,
dev-i2c_bus[0].i2c_adap, port-dvb.frontend,
- 0xc0,
hauppauge_hvr2255_tuner_config);
+ si2157_attach(port, dev-i2c_bus[0].i2c_adap,
+ port-dvb.frontend, 0xc0,
+
hauppauge_hvr2255_tuner_config);
} else {
- si2157_attach(port,
dev-i2c_bus[1].i2c_adap, port-dvb.frontend,
- 0xc0,
hauppauge_hvr2255_tuner_config);
+ si2157_attach(port, dev-i2c_bus[1].i2c_adap,
+ port-dvb.frontend, 0xc0,
+
hauppauge_hvr2255_tuner_config);
}
}
break;
@@ -650,10 +652,11 @@ int saa7164_dvb_register(struct saa7164_port *port)
info.addr = 0xc8 1;
info.platform_data = si2168_config;
request_module(info.type);
- client_demod =
i2c_new_device(dev-i2c_bus[2].i2c_adap, info);
- if (client_demod == NULL || client_demod-dev.driver
== NULL) {
+ client_demod =
i2c_new_device(dev-i2c_bus[2].i2c_adap,
+ info);
+ if (!client_demod || !client_demod-dev.driver)
goto frontend_detach;
- }
+
if (!try_module_get(client_demod-dev.driver-owner))
{
i2c_unregister_device(client_demod);
goto frontend_detach;
@@ -668,8 +671,9 @@ int saa7164_dvb_register(struct saa7164_port *port)
info.addr = 0xc0 1;
info.platform_data = si2157_config;
request_module(info.type);
- client_tuner =
i2c_new_device(dev-i2c_bus[0].i2c_adap, info);
- if (client_tuner == NULL || client_tuner-dev.driver
== NULL) {
+ client_tuner =
i2c_new_device(dev-i2c_bus[0].i2c_adap,
+ info);
+ if (!client_tuner || !client_tuner-dev.driver) {
module_put(client_demod-dev.driver-owner);
i2c_unregister_device(client_demod);
goto frontend_detach;
@@ -692,10 +696,11 @@ int saa7164_dvb_register(struct saa7164_port *port)
info.addr = 0xcc 1;
info.platform_data = si2168_config;
request_module(info.type);
- client_demod =
[linuxtv-media:master 841/883] drivers/media/pci/saa7164/saa7164-dvb.c:704 saa7164_dvb_register() error: potential null dereference 'client_demod'. (i2c_new_device returns null)
tree: git://linuxtv.org/media_tree.git master
head: ebf984bb151e9952cccd060d3aba0b4d30a87e81
commit: 3600433f19f59410010770d61ead509d785b8a6e [841/883] saa7164: Fix
CodingStyle issues added on previous patches
drivers/media/pci/saa7164/saa7164-dvb.c:704 saa7164_dvb_register() error:
potential null dereference 'client_demod'. (i2c_new_device returns null)
vim +/client_demod +704 drivers/media/pci/saa7164/saa7164-dvb.c
504b29cbb0 Steven Toth 2015-03-23 688} else {
504b29cbb0 Steven Toth 2015-03-23 689/*
attach frontend */
504b29cbb0 Steven Toth 2015-03-23 690
memset(si2168_config, 0, sizeof(si2168_config));
504b29cbb0 Steven Toth 2015-03-23 691
si2168_config.i2c_adapter = adapter;
504b29cbb0 Steven Toth 2015-03-23 692
si2168_config.fe = port-dvb.frontend;
504b29cbb0 Steven Toth 2015-03-23 693
si2168_config.ts_mode = SI2168_TS_SERIAL;
504b29cbb0 Steven Toth 2015-03-23 694
memset(info, 0, sizeof(struct i2c_board_info));
504b29cbb0 Steven Toth 2015-03-23 695
strlcpy(info.type, si2168, I2C_NAME_SIZE);
504b29cbb0 Steven Toth 2015-03-23 696
info.addr = 0xcc 1;
504b29cbb0 Steven Toth 2015-03-23 697
info.platform_data = si2168_config;
504b29cbb0 Steven Toth 2015-03-23 698
request_module(info.type);
3600433f19 Mauro Carvalho Chehab 2015-05-01 699
client_demod = i2c_new_device(dev-i2c_bus[2].i2c_adap,
3600433f19 Mauro Carvalho Chehab 2015-05-01 700
info);
3600433f19 Mauro Carvalho Chehab 2015-05-01 701if
(!client_tuner || !client_tuner-dev.driver)
504b29cbb0 Steven Toth 2015-03-23 702
goto frontend_detach;
3600433f19 Mauro Carvalho Chehab 2015-05-01 703
504b29cbb0 Steven Toth 2015-03-23 @704if
(!try_module_get(client_demod-dev.driver-owner)) {
504b29cbb0 Steven Toth 2015-03-23 705
i2c_unregister_device(client_demod);
504b29cbb0 Steven Toth 2015-03-23 706
goto frontend_detach;
504b29cbb0 Steven Toth 2015-03-23 707}
504b29cbb0 Steven Toth 2015-03-23 708
port-i2c_client_demod = client_demod;
504b29cbb0 Steven Toth 2015-03-23 709
504b29cbb0 Steven Toth 2015-03-23 710/*
attach tuner */
504b29cbb0 Steven Toth 2015-03-23 711
memset(si2157_config, 0, sizeof(si2157_config));
504b29cbb0 Steven Toth 2015-03-23 712
si2157_config.fe = port-dvb.frontend;
:: The code at line 704 was first introduced by commit
:: 504b29cbb0cc0fb7169c276054a72110b57660c0 [media] saa7164: Add Digital TV
support for the HVR2255 and HVR2205
:: TO: Steven Toth st...@kernellabs.com
:: CC: Mauro Carvalho Chehab mche...@osg.samsung.com
---
0-DAY kernel test infrastructureOpen Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFC PATCH 3/3] videodev2.h: add entity_id to struct v4l2_capability
From: Hans Verkuil hans.verk...@cisco.com
Export the entity ID (if any) of the video device.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
Documentation/DocBook/media/v4l/vidioc-querycap.xml | 16 +++-
drivers/media/v4l2-core/v4l2-ioctl.c| 7 +++
include/uapi/linux/videodev2.h | 5 -
3 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/Documentation/DocBook/media/v4l/vidioc-querycap.xml
b/Documentation/DocBook/media/v4l/vidioc-querycap.xml
index c1ed844..4a7737c 100644
--- a/Documentation/DocBook/media/v4l/vidioc-querycap.xml
+++ b/Documentation/DocBook/media/v4l/vidioc-querycap.xml
@@ -154,7 +154,14 @@ printf (Version: %u.%u.%u\n,
/row
row
entry__u32/entry
- entrystructfieldreserved/structfield[3]/entry
+ entrystructfieldentity_id/structfield/entry
+ entryThe media controller entity ID of the device. This is only
valid if
+ the constantV4L2_CAP_ENTITY/constant capability is set.
+ /entry
+ /row
+ row
+ entry__u32/entry
+ entrystructfieldreserved/structfield[2]/entry
entryReserved for future extensions. Drivers must set
this array to zero./entry
/row
@@ -308,6 +315,13 @@ modulator programming see
fields./entry
/row
row
+ entryconstantV4L2_CAP_ENTITY/constant/entry
+ entry0x0040/entry
+ entryThe device is a media controller entity and
+ the structfieldentity_id/structfield field of v4l2-capability;
+ is valid./entry
+ /row
+ row
entryconstantV4L2_CAP_READWRITE/constant/entry
entry0x0100/entry
entryThe device supports the link
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c
b/drivers/media/v4l2-core/v4l2-ioctl.c
index 1476602..5179611 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -1011,6 +1011,7 @@ static void v4l_sanitize_format(struct v4l2_format *fmt)
static int v4l_querycap(const struct v4l2_ioctl_ops *ops,
struct file *file, void *fh, void *arg)
{
+ struct video_device *vfd = video_devdata(file);
struct v4l2_capability *cap = (struct v4l2_capability *)arg;
int ret;
@@ -1019,6 +1020,12 @@ static int v4l_querycap(const struct v4l2_ioctl_ops *ops,
ret = ops-vidioc_querycap(file, fh, cap);
cap-capabilities |= V4L2_CAP_EXT_PIX_FORMAT;
+#if defined(CONFIG_MEDIA_CONTROLLER)
+ if (vfd-entity.parent) {
+ cap-capabilities |= V4L2_CAP_ENTITY;
+ cap-entity_id = vfd-entity.id;
+ }
+#endif
/*
* Drivers MUST fill in device_caps, so check for this and
* warn if it was forgotten.
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index fa376f7..af7a667 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -307,6 +307,7 @@ struct v4l2_fract {
* @version: KERNEL_VERSION
* @capabilities: capabilities of the physical device as a whole
* @device_caps: capabilities accessed via this particular device (node)
+ * @entity_id:the media controller entity ID
* @reserved:reserved fields for future extensions
*/
struct v4l2_capability {
@@ -316,7 +317,8 @@ struct v4l2_capability {
__u32 version;
__u32 capabilities;
__u32 device_caps;
- __u32 reserved[3];
+ __u32 entity_id;
+ __u32 reserved[2];
};
/* Values for 'capabilities' field */
@@ -348,6 +350,7 @@ struct v4l2_capability {
#define V4L2_CAP_SDR_CAPTURE 0x0010 /* Is a SDR capture device
*/
#define V4L2_CAP_EXT_PIX_FORMAT0x0020 /* Supports the
extended pixel format */
+#define V4L2_CAP_ENTITY 0x0040 /* This is a Media
Controller entity */
#define V4L2_CAP_READWRITE 0x0100 /* read/write systemcalls
*/
#define V4L2_CAP_ASYNCIO0x0200 /* async I/O */
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFC PATCH 1/3] v4l2-subdev: add VIDIOC_SUBDEV_QUERYCAP ioctl
From: Hans Verkuil hans.verk...@cisco.com
While normal video/radio/vbi/swradio nodes have a proper QUERYCAP ioctl
that apps can call to determine that it is indeed a V4L2 device, there
is currently no equivalent for v4l-subdev nodes. Adding this ioctl will
solve that, and it will allow utilities like v4l2-compliance to be used
with these devices as well.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/v4l2-core/v4l2-subdev.c | 19 +++
include/uapi/linux/v4l2-subdev.h | 12
2 files changed, 31 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-subdev.c
b/drivers/media/v4l2-core/v4l2-subdev.c
index 6359606..2ab1f7d 100644
--- a/drivers/media/v4l2-core/v4l2-subdev.c
+++ b/drivers/media/v4l2-core/v4l2-subdev.c
@@ -25,6 +25,7 @@
#include linux/types.h
#include linux/videodev2.h
#include linux/export.h
+#include linux/version.h
#include media/v4l2-ctrls.h
#include media/v4l2-device.h
@@ -187,6 +188,24 @@ static long subdev_do_ioctl(struct file *file, unsigned
int cmd, void *arg)
#endif
switch (cmd) {
+ case VIDIOC_SUBDEV_QUERYCAP: {
+ struct v4l2_subdev_capability *cap = arg;
+
+ cap-version = LINUX_VERSION_CODE;
+ cap-device_caps = 0;
+ cap-pads = 0;
+ cap-entity_id = 0;
+#if defined(CONFIG_MEDIA_CONTROLLER)
+ if (sd-entity.parent) {
+ cap-device_caps = V4L2_SUBDEV_CAP_ENTITY;
+ cap-pads = sd-entity.num_pads;
+ cap-entity_id = sd-entity.id;
+ }
+#endif
+ memset(cap-reserved, 0, sizeof(cap-reserved));
+ break;
+ }
+
case VIDIOC_QUERYCTRL:
return v4l2_queryctrl(vfh-ctrl_handler, arg);
diff --git a/include/uapi/linux/v4l2-subdev.h b/include/uapi/linux/v4l2-subdev.h
index dbce2b5..e48b9fd 100644
--- a/include/uapi/linux/v4l2-subdev.h
+++ b/include/uapi/linux/v4l2-subdev.h
@@ -154,9 +154,21 @@ struct v4l2_subdev_selection {
__u32 reserved[8];
};
+struct v4l2_subdev_capability {
+ __u32 version;
+ __u32 device_caps;
+ __u32 pads;
+ __u32 entity_id;
+ __u32 reserved[48];
+};
+
+/* This v4l2_subdev is also a media entity and the entity_id field is valid */
+#define V4L2_SUBDEV_CAP_ENTITY (1 0)
+
/* Backwards compatibility define --- to be removed */
#define v4l2_subdev_edid v4l2_edid
+#define VIDIOC_SUBDEV_QUERYCAP _IOR('V', 0, struct
v4l2_subdev_capability)
#define VIDIOC_SUBDEV_G_FMT_IOWR('V', 4, struct
v4l2_subdev_format)
#define VIDIOC_SUBDEV_S_FMT_IOWR('V', 5, struct
v4l2_subdev_format)
#define VIDIOC_SUBDEV_G_FRAME_INTERVAL _IOWR('V', 21, struct
v4l2_subdev_frame_interval)
--
2.1.4
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFC PATCH 2/3] DocBook/media: document VIDIOC_SUBDEV_QUERYCAP
From: Hans Verkuil hans.verk...@cisco.com Add documentation for the new VIDIOC_SUBDEV_QUERYCAP ioctl. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- Documentation/DocBook/media/v4l/v4l2.xml | 1 + .../DocBook/media/v4l/vidioc-querycap.xml | 2 +- .../DocBook/media/v4l/vidioc-subdev-querycap.xml | 140 + 3 files changed, 142 insertions(+), 1 deletion(-) create mode 100644 Documentation/DocBook/media/v4l/vidioc-subdev-querycap.xml diff --git a/Documentation/DocBook/media/v4l/v4l2.xml b/Documentation/DocBook/media/v4l/v4l2.xml index e98caa1..23607bc 100644 --- a/Documentation/DocBook/media/v4l/v4l2.xml +++ b/Documentation/DocBook/media/v4l/v4l2.xml @@ -669,6 +669,7 @@ and discussions on the V4L mailing list./revremark sub-subdev-g-fmt; sub-subdev-g-frame-interval; sub-subdev-g-selection; +sub-subdev-querycap; sub-subscribe-event; !-- End of ioctls. -- sub-mmap; diff --git a/Documentation/DocBook/media/v4l/vidioc-querycap.xml b/Documentation/DocBook/media/v4l/vidioc-querycap.xml index 20fda75..c1ed844 100644 --- a/Documentation/DocBook/media/v4l/vidioc-querycap.xml +++ b/Documentation/DocBook/media/v4l/vidioc-querycap.xml @@ -54,7 +54,7 @@ kernel devices compatible with this specification and to obtain information about driver and hardware capabilities. The ioctl takes a pointer to a v4l2-capability; which is filled by the driver. When the driver is not compatible with this specification the ioctl returns an -EINVAL;./para +ENOTTY;./para table pgwide=1 frame=none id=v4l2-capability titlestruct structnamev4l2_capability/structname/title diff --git a/Documentation/DocBook/media/v4l/vidioc-subdev-querycap.xml b/Documentation/DocBook/media/v4l/vidioc-subdev-querycap.xml new file mode 100644 index 000..a1cbb36 --- /dev/null +++ b/Documentation/DocBook/media/v4l/vidioc-subdev-querycap.xml @@ -0,0 +1,140 @@ +refentry id=vidioc-subdev-querycap + refmeta +refentrytitleioctl VIDIOC_SUBDEV_QUERYCAP/refentrytitle +manvol; + /refmeta + + refnamediv +refnameVIDIOC_SUBDEV_QUERYCAP/refname +refpurposeQuery sub-device capabilities/refpurpose + /refnamediv + + refsynopsisdiv +funcsynopsis + funcprototype + funcdefint functionioctl/function/funcdef + paramdefint parameterfd/parameter/paramdef + paramdefint parameterrequest/parameter/paramdef + paramdefstruct v4l2_subdev_capability *parameterargp/parameter/paramdef + /funcprototype +/funcsynopsis + /refsynopsisdiv + + refsect1 +titleArguments/title + +variablelist + varlistentry + termparameterfd/parameter/term + listitem + parafd;/para + /listitem + /varlistentry + varlistentry + termparameterrequest/parameter/term + listitem + paraVIDIOC_SUBDEV_QUERYCAP/para + /listitem + /varlistentry + varlistentry + termparameterargp/parameter/term + listitem + para/para + /listitem + /varlistentry +/variablelist + /refsect1 + + refsect1 +titleDescription/title + +paraAll V4L2 sub-devices support the +constantVIDIOC_SUBDEV_QUERYCAP/constant ioctl. It is used to identify +kernel devices compatible with this specification and to obtain +information about driver and hardware capabilities. The ioctl takes a +pointer to a v4l2-subdev-capability; which is filled by the driver. When the +driver is not compatible with this specification the ioctl returns an +ENOTTY;./para + +table pgwide=1 frame=none id=v4l2-subdev-capability + titlestruct structnamev4l2_subdev_capability/structname/title + tgroup cols=3 + cs-str; + tbody valign=top + row + entry__u32/entry + entrystructfieldversion/structfield/entry + entryparaVersion number of the driver./para +paraThe version reported is provided by the +V4L2 subsystem following the kernel numbering scheme. However, it +may not always return the same version as the kernel if, for example, +a stable or distribution-modified kernel uses the V4L2 stack from a +newer kernel./para +paraThe version number is formatted using the +constantKERNEL_VERSION()/constant macro:/para/entry + /row + row + entry spanname=hspanpara +programlisting +#define KERNEL_VERSION(a,b,c) (((a) lt;lt; 16) + ((b) lt;lt; 8) + (c)) + +__u32 version = KERNEL_VERSION(0, 8, 1); + +printf (Version: %u.%u.%u\n, + (version gt;gt; 16) amp; 0xFF, + (version gt;gt; 8) amp; 0xFF, +version amp; 0xFF); +/programlisting/para/entry + /row + row + entry__u32/entry + entrystructfielddevice_caps/structfield/entry + entrySub-device capabilities of the opened device, see xref + linkend=subdevice-capabilities /. + /entry + /row + row + entry__u32/entry + entrystructfieldpads/structfield/entry +
[linuxtv-media:master 841/883] drivers/media/pci/saa7164/saa7164-dvb.c:701:7: warning: 'client_tuner' may be used uninitialized in this function
tree: git://linuxtv.org/media_tree.git master
head: ebf984bb151e9952cccd060d3aba0b4d30a87e81
commit: 3600433f19f59410010770d61ead509d785b8a6e [841/883] saa7164: Fix
CodingStyle issues added on previous patches
config: x86_64-rhel (attached as .config)
reproduce:
git checkout 3600433f19f59410010770d61ead509d785b8a6e
# save the attached .config to linux build tree
make ARCH=x86_64
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings:
drivers/media/pci/saa7164/saa7164-dvb.c: In function 'saa7164_dvb_register':
drivers/media/pci/saa7164/saa7164-dvb.c:701:7: warning: 'client_tuner' may
be used uninitialized in this function [-Wmaybe-uninitialized]
if (!client_tuner || !client_tuner-dev.driver)
^
vim +/client_tuner +701 drivers/media/pci/saa7164/saa7164-dvb.c
685 goto frontend_detach;
686 }
687 port-i2c_client_tuner = client_tuner;
688 } else {
689 /* attach frontend */
690 memset(si2168_config, 0,
sizeof(si2168_config));
691 si2168_config.i2c_adapter = adapter;
692 si2168_config.fe = port-dvb.frontend;
693 si2168_config.ts_mode = SI2168_TS_SERIAL;
694 memset(info, 0, sizeof(struct i2c_board_info));
695 strlcpy(info.type, si2168, I2C_NAME_SIZE);
696 info.addr = 0xcc 1;
697 info.platform_data = si2168_config;
698 request_module(info.type);
699 client_demod =
i2c_new_device(dev-i2c_bus[2].i2c_adap,
700info);
701 if (!client_tuner || !client_tuner-dev.driver)
702 goto frontend_detach;
703
704 if
(!try_module_get(client_demod-dev.driver-owner)) {
705 i2c_unregister_device(client_demod);
706 goto frontend_detach;
707 }
708 port-i2c_client_demod = client_demod;
709
---
0-DAY kernel test infrastructureOpen Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
#
# Automatically generated file; DO NOT EDIT.
# Linux/x86_64 4.1.0-rc1 Kernel Configuration
#
CONFIG_64BIT=y
CONFIG_X86_64=y
CONFIG_X86=y
CONFIG_INSTRUCTION_DECODER=y
CONFIG_PERF_EVENTS_INTEL_UNCORE=y
CONFIG_OUTPUT_FORMAT=elf64-x86-64
CONFIG_ARCH_DEFCONFIG=arch/x86/configs/x86_64_defconfig
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_HAVE_LATENCYTOP_SUPPORT=y
CONFIG_MMU=y
CONFIG_NEED_DMA_MAP_STATE=y
CONFIG_NEED_SG_DMA_LENGTH=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_BUG=y
CONFIG_GENERIC_BUG_RELATIVE_POINTERS=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_ARCH_HAS_CPU_RELAX=y
CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y
CONFIG_HAVE_SETUP_PER_CPU_AREA=y
CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y
CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y
CONFIG_ARCH_HIBERNATION_POSSIBLE=y
CONFIG_ARCH_SUSPEND_POSSIBLE=y
CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y
CONFIG_ARCH_WANT_GENERAL_HUGETLB=y
CONFIG_ZONE_DMA32=y
CONFIG_AUDIT_ARCH=y
CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING=y
CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC=y
CONFIG_HAVE_INTEL_TXT=y
CONFIG_X86_64_SMP=y
CONFIG_X86_HT=y
CONFIG_ARCH_HWEIGHT_CFLAGS=-fcall-saved-rdi -fcall-saved-rsi -fcall-saved-rdx
-fcall-saved-rcx -fcall-saved-r8 -fcall-saved-r9 -fcall-saved-r10
-fcall-saved-r11
CONFIG_ARCH_SUPPORTS_UPROBES=y
CONFIG_FIX_EARLYCON_MEM=y
CONFIG_PGTABLE_LEVELS=4
CONFIG_DEFCONFIG_LIST=/lib/modules/$UNAME_RELEASE/.config
CONFIG_IRQ_WORK=y
CONFIG_BUILDTIME_EXTABLE_SORT=y
#
# General setup
#
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_CROSS_COMPILE=
# CONFIG_COMPILE_TEST is not set
CONFIG_LOCALVERSION=
CONFIG_LOCALVERSION_AUTO=y
CONFIG_HAVE_KERNEL_GZIP=y
CONFIG_HAVE_KERNEL_BZIP2=y
CONFIG_HAVE_KERNEL_LZMA=y
CONFIG_HAVE_KERNEL_XZ=y
CONFIG_HAVE_KERNEL_LZO=y
CONFIG_HAVE_KERNEL_LZ4=y
CONFIG_KERNEL_GZIP=y
# CONFIG_KERNEL_BZIP2 is not set
# CONFIG_KERNEL_LZMA is not set
# CONFIG_KERNEL_XZ is not set
# CONFIG_KERNEL_LZO is not set
# CONFIG_KERNEL_LZ4 is not set
CONFIG_DEFAULT_HOSTNAME=(none)
CONFIG_SWAP=y
CONFIG_SYSVIPC=y
CONFIG_SYSVIPC_SYSCTL=y
CONFIG_POSIX_MQUEUE=y
CONFIG_POSIX_MQUEUE_SYSCTL=y
CONFIG_CROSS_MEMORY_ATTACH=y
CONFIG_FHANDLE=y
CONFIG_USELIB=y
CONFIG_AUDIT=y
CONFIG_HAVE_ARCH_AUDITSYSCALL=y
CONFIG_AUDITSYSCALL=y
CONFIG_AUDIT_WATCH=y
CONFIG_AUDIT_TREE=y
#
# IRQ subsystem
#
CONFIG_GENERIC_IRQ_PROBE=y
CONFIG_GENERIC_IRQ_SHOW=y
CONFIG_GENERIC_IRQ_LEGACY_ALLOC_HWIRQ=y
[RFC PATCH 0/3] Add VIDIOC_SUBDEV_QUERYCAP
From: Hans Verkuil hans.verk...@cisco.com This patch series adds the VIDIOC_SUBDEV_QUERYCAP ioctl for v4l-subdev devices as discussed during the ELC in San Jose and as discussed here: http://www.spinics.net/lists/linux-media/msg88009.html It also adds the entity_id to v4l2_capability. Hans Verkuil (3): v4l2-subdev: add VIDIOC_SUBDEV_QUERYCAP ioctl DocBook/media: document VIDIOC_SUBDEV_QUERYCAP videodev2.h: add entity_id to struct v4l2_capability Documentation/DocBook/media/v4l/v4l2.xml | 1 + .../DocBook/media/v4l/vidioc-querycap.xml | 18 ++- .../DocBook/media/v4l/vidioc-subdev-querycap.xml | 140 + drivers/media/v4l2-core/v4l2-ioctl.c | 7 ++ drivers/media/v4l2-core/v4l2-subdev.c | 19 +++ include/uapi/linux/v4l2-subdev.h | 12 ++ include/uapi/linux/videodev2.h | 5 +- 7 files changed, 199 insertions(+), 3 deletions(-) create mode 100644 Documentation/DocBook/media/v4l/vidioc-subdev-querycap.xml -- 2.1.4 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 0/3] Add VIDIOC_SUBDEV_QUERYCAP
On 05/01/2015 01:33 PM, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com This patch series adds the VIDIOC_SUBDEV_QUERYCAP ioctl for v4l-subdev devices as discussed during the ELC in San Jose and as discussed here: http://www.spinics.net/lists/linux-media/msg88009.html It also adds the entity_id to v4l2_capability. Question: why do we have CONFIG_VIDEO_V4L2_SUBDEV_API? I don't really see the point of this and I would propose to remove this config option and instead use CONFIG_MEDIA_CONTROLLER. I don't see the use-case of having MEDIA_CONTROLLER defined but not VIDEO_V4L2_SUBDEV_API. Comments? Hans Hans Verkuil (3): v4l2-subdev: add VIDIOC_SUBDEV_QUERYCAP ioctl DocBook/media: document VIDIOC_SUBDEV_QUERYCAP videodev2.h: add entity_id to struct v4l2_capability Documentation/DocBook/media/v4l/v4l2.xml | 1 + .../DocBook/media/v4l/vidioc-querycap.xml | 18 ++- .../DocBook/media/v4l/vidioc-subdev-querycap.xml | 140 + drivers/media/v4l2-core/v4l2-ioctl.c | 7 ++ drivers/media/v4l2-core/v4l2-subdev.c | 19 +++ include/uapi/linux/v4l2-subdev.h | 12 ++ include/uapi/linux/videodev2.h | 5 +- 7 files changed, 199 insertions(+), 3 deletions(-) create mode 100644 Documentation/DocBook/media/v4l/vidioc-subdev-querycap.xml -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] saa7164: fix compiler warning
drivers/media/pci/saa7164/saa7164-dvb.c: In function ‘saa7164_dvb_register’:
drivers/media/pci/saa7164/saa7164-dvb.c:701:7: warning: ‘client_tuner’ may be
used uninitialized in this function [-Wmaybe-uninitialized]
if (!client_tuner || !client_tuner-dev.driver)
^
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
diff --git a/drivers/media/pci/saa7164/saa7164-dvb.c
b/drivers/media/pci/saa7164/saa7164-dvb.c
index c68ce26..9969800 100644
--- a/drivers/media/pci/saa7164/saa7164-dvb.c
+++ b/drivers/media/pci/saa7164/saa7164-dvb.c
@@ -698,7 +698,7 @@ int saa7164_dvb_register(struct saa7164_port *port)
request_module(info.type);
client_demod = i2c_new_device(dev-i2c_bus[2].i2c_adap,
info);
- if (!client_tuner || !client_tuner-dev.driver)
+ if (!client_demod || !client_demod-dev.driver)
goto frontend_detach;
if (!try_module_get(client_demod-dev.driver-owner)) {
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: issue with TechnoTrend CT2-4650 CI
Hi Michal, I've seen something like this before with some CAMs. It seems that the CAM needs to be initialized if it is plugged in. This does not happen if you use software which does not have CAM support (such as w_scan). The linuxtv.org wiki has the following comment on the CT2-4650 page: Some CAMs require initialization before they will work. Without initialization it's possible that even non-encrypted channels do not work. If there's no CAM inserted, there's no issue. gnutv could be used to initialize the CAM, for example: gnutv -timeout 1 -out file /var/tmp/test.ts -channels ~/channels.conf FOX Of course ideally the CAM should be initialized by the driver... Cheers, -olli On 1 May 2015 at 11:39, Michal B developer...@gmail.com wrote: Hi all, i bought new TechnoTrend CT2-4650 CI , i tried to use it on wind* , successfuly also with encrypted channels with CAM, then i tried on linux with kernel 3.19.6, and i got two behaviors: when CAM is unplugged i'm able to watch unencrypted channels correctly, but when i plugged in CAM i'm unable to find any channel during scan with w_scan, and also i'm unable to tune any channel previously found, and i have second issue: when i have CAM plugged and i unplug TechnoTrend from USB on my computer - my computer freezes - so i have to reset by button on the case, please somebody could help me to get it running with CAM to watch encrypted channels ? here is output when CAM is unplugged: [ 1381.807428] usb 3-10: new high-speed USB device number 4 using xhci_hcd [ 1381.935870] usb 3-10: New USB device found, idVendor=0b48, idProduct=3012 [ 1381.935872] usb 3-10: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 1381.935874] usb 3-10: Product: TechnoTrend USB2.0 [ 1381.935874] usb 3-10: Manufacturer: CityCom GmbH [ 1381.935875] usb 3-10: SerialNumber: 20130422 [ 1382.222836] usb 3-10: dvb_usb_v2: found a 'TechnoTrend TT-connect CT2-4650 CI' in warm state [ 1382.222868] usb 3-10: dvb_usb_v2: will pass the complete MPEG2 transport stream to the software demuxer [ 1382.222875] DVB: registering new adapter (TechnoTrend TT-connect CT2-4650 CI) [ 1382.224114] usb 3-10: dvb_usb_v2: MAC address: bc:ea:2b:65:00:ad [ 1382.245403] i2c i2c-7: Added multiplexed i2c bus 8 [ 1382.245406] si2168 7-0064: Silicon Labs Si2168 successfully attached [ 1382.259984] si2157 8-0060: Silicon Labs Si2147/2148/2157/2158 successfully attached [ 1382.273787] sp2 7-0040: CIMaX SP2 successfully attached [ 1382.273794] usb 3-10: DVB: registering adapter 0 frontend 0 (Silicon Labs Si2168)... [ 1382.310693] Registered IR keymap rc-tt-1500 [ 1382.310744] input: TechnoTrend TT-connect CT2-4650 CI as /devices/pci:00/:00:14.0/usb3/3-10/rc/rc0/input23 [ 1382.310827] rc0: TechnoTrend TT-connect CT2-4650 CI as /devices/pci:00/:00:14.0/usb3/3-10/rc/rc0 [ 1382.310831] usb 3-10: dvb_usb_v2: schedule remote query interval to 300 msecs [ 1382.310832] usb 3-10: dvb_usb_v2: 'TechnoTrend TT-connect CT2-4650 CI' successfully initialized and connected [ 1382.310847] usbcore: registered new interface driver dvb_usb_dvbsky when i start vlc: [ 1485.824805] si2168 7-0064: found a 'Silicon Labs Si2168' in cold state [ 1485.835991] si2168 7-0064: downloading firmware from file 'dvb-demod-si2168-a20-01.fw' [ 1491.074442] si2168 7-0064: found a 'Silicon Labs Si2168' in warm state [ 1491.083144] si2157 8-0060: found a 'Silicon Labs Si2146/2147/2148/2157/2158' in cold state [ 1491.090486] si2157 8-0060: downloading firmware from file 'dvb-tuner-si2158-a20-01.fw' Kind regards, -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
