Re: [PATCH 1/1] smiapp: Remove useless rval assignment in smiapp_get_pdata()

Hi Sakari, Thank you for the patch. On Saturday 11 April 2015 01:42:47 Sakari Ailus wrote: > The value is not used after the assignment. > > Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart and applied to my tree. > --- >

Re: [RFC/PATCH] media: omap3isp: Set maximum DMA segment size

Hello everybody, Ping ? On Tuesday 13 October 2015 16:18:36 Laurent Pinchart wrote: > The maximum DMA segment size controls the IOMMU mapping granularity. Its > default value is 64kB, resulting in potentially non-contiguous IOMMU > mappings. Configure it to 4GB to ensure that buffers get mapped

Re: [PATCH 1/3] [media] mt9v032: Add reset and standby gpios

Hi Markus, Thank you for the patch. On Friday 06 November 2015 14:13:43 Markus Pargmann wrote: > Add optional reset and standby gpios. The reset gpio is used to reset > the chip in power_on(). > > The standby gpio is not used currently. It is just unset, so the chip is > not in standby. We

Re: [PATCH 2/3] [media] mt9v032: Do not unset master_mode

Hi Markus, Thank you for the patch. On Friday 06 November 2015 14:13:44 Markus Pargmann wrote: > The power_on function of the driver resets the chip and sets the > CHIP_CONTROL register to 0. This switches the operating mode to slave. > The s_stream function sets the correct mode. But this

Re: [PATCH 3/3] [media] mt9v032: Add V4L2 controls for AEC and AGC

Hi Markus, Thank you for the patch. On Friday 06 November 2015 14:13:45 Markus Pargmann wrote: > This patch adds V4L2 controls for Auto Exposure Control and Auto Gain > Control settings. These settings include low pass filter, update > frequency of these settings and the update interval for

Re: [PATCH v6 1/3] iommu: Implement common IOMMU ops for DMA mapping

On 04/11/15 05:12, Tomasz Figa wrote: On Wed, Nov 4, 2015 at 2:41 AM, Robin Murphy wrote: Hi Tomasz, On 02/11/15 13:43, Tomasz Figa wrote: I'd like to know what is the boundary mask and what hardware imposes requirements like this. The cost here is not only

[v4l-utils PATCH 0/4] List supported formats in libv4l2subdev

Hi, This set moves libv4l2subdev to use media bus format definitions instead of the old V4L2 mbus formats. In addition, support is added to all existing formats, as the format list is generated instead of manually adding formats to the list. The media-ctl test program is amended by the list of

[v4l-utils PATCH 4/4] media-ctl: List supported media bus formats

Add a new topic option for -h to allow listing supported media bus codes in conversion functions. This is useful in figuring out which media bus codes are actually supported by the library. The numeric values of the codes are listed as well. Signed-off-by: Sakari Ailus

[v4l-utils PATCH 1/4] libv4l2subdev: Switch to media bus formats

No longer use the old V4L2 based MBUS_FMT definitions. Instead, use the newer media bus format definitions. Signed-off-by: Sakari Ailus --- utils/media-ctl/libv4l2subdev.c | 54 - 1 file changed, 27 insertions(+), 27

[v4l-utils PATCH 2/4] libv4l2subdev: Use generated format definitions in libv4l2subdev

Instead of manually adding each and every new media bus pixel code to libv4l2subdev, generate the list automatically. The pre-existing formats that do not match the list are not modified so that existing users are unaffected by this change, with the exception of converting codes to strings, which

Re: [PATCH] [media] mt9v032: Remove duplicate test for I2C_FUNC_SMBUS_WORD_DATA functionality

Hi Axel, Thank you for the patch. On Sunday 10 August 2014 17:41:49 Axel Lin wrote: > Since commit b42261078a91 ("regmap: i2c: fallback to SMBus if the adapter > does not support standard I2C"), regmap-i2c will check the > I2C_FUNC_SMBUS_[BYTE|WORD]_DATA functionality based on the regmap_config

Re: [PATCH] [media] mt9t001: constify v4l2_subdev_internal_ops structure

Hi Julia, Thank you for the patch. On Sunday 11 October 2015 13:57:13 Julia Lawall wrote: > This v4l2_subdev_internal_ops structure is never modified. All other > v4l2_subdev_internal_ops structures are declared as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall

Re: [PATCH 2/3] [media] mt9v032: Do not unset master_mode

Hi Laurent, On Monday 09 November 2015 14:46:42 Laurent Pinchart wrote: > Hi Markus, > > Thank you for the patch. > > On Friday 06 November 2015 14:13:44 Markus Pargmann wrote: > > The power_on function of the driver resets the chip and sets the > > CHIP_CONTROL register to 0. This switches the

[v4l-utils PATCH 3/4] libv4l2subdev: Add a function to list library supported pixel codes

Also mark which format definitions are compat definitions for the pre-existing codes. This way we don't end up listing the same formats twice. Signed-off-by: Sakari Ailus --- utils/media-ctl/libv4l2subdev.c | 63 +++--

[PATCH 2/2] media: omap4iss: csi2: Fix IRQ handling when stopping module

When stopping the CSI2 receiver the s_stream handler will wait for the IRQ handler to notice the stop request. The receiver, automatically disabled by the hardware after each frame, is then not reenabled by the IRQ handler as it returns immediately. As the IRQ handler check is performed before

Re: [PATCH] /media/davinci_vpfe/dm365_resizer.c:Bug containing more than 80 characters in a line is fixed.

Hi Ravinder, Thank you for the patch. I'm afraid the patch doesn't apply on top of the mainline kernel. On Wednesday 19 August 2015 21:14:56 Ravinder Atla wrote: > Signed-off-by: Ravinder Atla > --- > drivers/staging/media/davinci_vpfe/dm365_resizer.c | 8 > 1

[PATCH 1/2] media: omap4iss: Make module stop timeout print a warning message

Module stop timeouts are serious enough that they deserve a proper warning message, not a debug message that will go unnoticed. Signed-off-by: Laurent Pinchart --- drivers/staging/media/omap4iss/iss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[GIT PULL FOR v4.5] Davinci staging fixes

Hi Mauro, I've collected the pending Davinci staging fixes from patchwork and prepared a branch for you. Prabhakar, is that fine with you ? Do you still maintain the driver ? If so, do you expect patches to be picked up when you ack them, or can you collect them in a branch somewhere and send

Re: [PATCH] v4l: Clarify RGB666 pixel format definition

Hi Sylwester, Reviving a "slightly" old discussion. On Wednesday 29 October 2014 13:45:46 Laurent Pinchart wrote: > On Tuesday 09 September 2014 16:45:17 Sylwester Nawrocki wrote: > > On 09/09/14 15:18, Laurent Pinchart wrote: > >> On Tuesday 22 July 2014 00:44:34 Hans Verkuil wrote: > >>> On

Re: [PATCH 25/38] staging: media: davinci_vpfe: fix ipipe_mode type

Hi Andrzej, Thank you for the patch. On Monday 21 September 2015 15:33:57 Andrzej Hajda wrote: > The variable can take negative values. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]:

Re: [PATCH v3 2/2] [media] uvcvideo: Remain runtime-suspended at sleeps

Hi Tomeu, On Monday 20 April 2015 09:11:36 Tomeu Vizoso wrote: > On 17 April 2015 at 19:32, Alan Stern wrote: > > On Fri, 17 Apr 2015, Tomeu Vizoso wrote: > >> When the system goes to sleep and afterwards resumes, a significant > >> amount of time is spent suspending

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Nov 10 04:00:19 CET 2015 git branch: test git hash: 79f5b6ae960d380c829fb67d5dadcd1d025d2775 gcc

Re: [PATCH] USB: uvc: add support for the Microsoft Surface Pro 3 Cameras

Hi Denis, On Thursday 11 June 2015 13:13:30 Dennis Chen wrote: > > Could you please send me the output of 'lsusb -v -d 045e:07be' and > > 'lsusb -v - > > d 045e:07bf' (running as root if possible) ? > > Bus 001 Device 004: ID 045e:07bf Microsoft Corp. > Device Descriptor: > bLength

Re: [PATCH] add interface protocol 1 for Surface Pro 3 cameras

Hi Zvi, Thank you for the patch. On Monday 24 August 2015 15:57:42 Zvi Effron wrote: > The cameras on the Surface Pro 3 report interface protocol of 1. > The generic USB video class doesn't work for them. > This adds entries for the front and rear camera. This doesn't need to be restricted to

Re: [PATCH 1/2] ARM: OMAP2+: Remove legacy OMAP3 ISP instantiation

Hi Tony, On Monday 12 October 2015 10:05:59 Tony Lindgren wrote: > * Tony Lindgren [150914 09:37]: > > * Suman Anna [150914 09:33]: > >> On 09/03/2015 05:34 PM, Suman Anna wrote: > >>> On 07/16/2015 07:58 AM, Tony Lindgren wrote: > * Laurent Pinchart

[PATCH] uvcvideo: Enable UVC 1.5 device detection

UVC 1.5 devices report a bInterfaceProtocol value set to 1 in their interface descriptors. The uvcvideo driver only matches on bInterfaceProtocol 0, preventing those devices from being detected. More changes to the driver are needed for full UVC 1.5 compatibility. However, at least the UVC 1.5

Re: [RFC 1/2] uvc: Add a quirk flag for cameras that do not produce correct timestamps

Hi Sakari, On Wednesday 05 November 2014 18:12:33 Sakari Ailus wrote: > The UVC devices do produce hardware timestamps according to the spec, but > not all cameras implement it or implement it correctly. Add a quirk flag for > such devices, and use monotonic timestamp from the end of the frame >

Re: [RFC/PATCH] media: omap3isp: Set maximum DMA segment size

Hi Laurent, On 09/11/15 14:18, Laurent Pinchart wrote: Hello everybody, Ping ? Apologies, I did start writing a response a while ago, but it ended up getting subsumed into the bigger DMA API discussion thread. On Tuesday 13 October 2015 16:18:36 Laurent Pinchart wrote: The maximum DMA

Re: [PATCH 1/3] [media] mt9v032: Add reset and standby gpios

Hi, On Monday 09 November 2015 14:28:56 Laurent Pinchart wrote: > Hi Markus, > > Thank you for the patch. > > On Friday 06 November 2015 14:13:43 Markus Pargmann wrote: > > Add optional reset and standby gpios. The reset gpio is used to reset > > the chip in power_on(). > > > > The standby

Re: [PATCH 1/3] [media] mt9v032: Add reset and standby gpios

Hi Markus, On Monday 09 November 2015 16:33:03 Markus Pargmann wrote: > On Monday 09 November 2015 14:28:56 Laurent Pinchart wrote: > > On Friday 06 November 2015 14:13:43 Markus Pargmann wrote: > >> Add optional reset and standby gpios. The reset gpio is used to reset > >> the chip in

Re: [PATCH 3/3] [media] mt9v032: Add V4L2 controls for AEC and AGC

Hi, On Monday 09 November 2015 15:22:06 Laurent Pinchart wrote: > Hi Markus, > > Thank you for the patch. > > On Friday 06 November 2015 14:13:45 Markus Pargmann wrote: > > This patch adds V4L2 controls for Auto Exposure Control and Auto Gain > > Control settings. These settings include low

Re: [PATCH 12/13] [media] omap3isp: Support for deferred probing when requesting DMA channel

Hi Peter, Thank you for the patch. What happened to this patch series ? It looks like dma_request_slave_channel_compat_reason() isn't in mainline, so I can't apply this patch. I'll mark this patch as deferred in patchwork, please resubmit it if you resubmit the series (and by the look of it

Re: [PATCH v2 9/9] [media] omap3isp: support 64-bit version of omap3isp_stat_data

Hi Arnd, Thank you for the patch. On Thursday 17 September 2015 23:19:40 Arnd Bergmann wrote: > C libraries with 64-bit time_t use an incompatible format for > struct omap3isp_stat_data. This changes the kernel code to > support either version, by moving over the normal handling > to the 64-bit

Re: [PATCH 1/9] drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c: use correct structure type name in sizeof

Hi Julia, Thank you for the patch. On Tuesday 29 July 2014 17:16:43 Julia Lawall wrote: > From: Julia Lawall > > Correct typo in the name of the type given to sizeof. Because it is the > size of a pointer that is wanted, the typo has no impact on compilation or >

Re: [PATCH 3/3] omap3isp: Return buffers back to videobuf2 if pipeline streamon fails

Hi Sakari, Thank you for the patch. On Friday 19 September 2014 00:57:49 Sakari Ailus wrote: > When the video buffer queue was stopped before the stream source was started > in omap3isp_streamon(), the buffers were not returned back to videobuf2. > > Signed-off-by: Sakari Ailus

Re: [PATCH 04/19] v4l: omap3isp: fix handling platform_get_irq result

Hi Andrzej, Thank you for the patch. On Thursday 24 September 2015 16:00:12 Andrzej Hajda wrote: > The function can return negative value. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]:

Re: [PATCH v2] Staging: media: davinci_vpfe: Fix over 80 characters coding style issue

Hello Junsu, Thank you for the patch. On Monday 10 August 2015 16:40:59 Junsu Shin wrote: > This is a patch to the dm365_ipipe.c that fixes over 80 characters warning > detected. It's a bit ironic to submit a patch fixing a 80 characters limit issue and having a commit message that is larger

Re: [Y2038] [PATCH v2 9/9] [media] omap3isp: support 64-bit version of omap3isp_stat_data

On Monday 09 November 2015 22:09:26 Laurent Pinchart wrote: > Hi Arnd, > > Thank you for the patch. > > On Thursday 17 September 2015 23:19:40 Arnd Bergmann wrote: > > C libraries with 64-bit time_t use an incompatible format for > > struct omap3isp_stat_data. This changes the kernel code to > >

Re: [PATCH 2/3] omap3isp: Move starting the sensor from streamon IOCTL handler to VB2 QOP

Hi Sakari, Thank you for the patch. On Friday 19 September 2014 00:57:48 Sakari Ailus wrote: > Move the starting of the sensor from the VIDIOC_STREAMON handler to the > videobuf2 queue op start_streaming. This avoids failing starting the stream > after vb2_streamon() has already finished. > >

Re: [PATCH] media: omap3isp: use vb2_buffer_state enum for vb2 buffer state

Hi Prabhakar, Thank you for the patch. On Wednesday 25 February 2015 15:58:14 Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > use the vb2_buffer_state enum for assigning the state > of the vb2 buffer, along side making isp_pipeline_state > state variable local to

Re: [PATCH 12/13] [media] omap3isp: Support for deferred probing when requesting DMA channel

Hi Laurent, On 11/09/2015 09:50 PM, Laurent Pinchart wrote: > Hi Peter, > > Thank you for the patch. > > What happened to this patch series ? It looks like > dma_request_slave_channel_compat_reason() isn't in mainline, so I can't apply > this patch. > > I'll mark this patch as deferred in

Re: [PATCH 04/19] v4l: omap3isp: fix handling platform_get_irq result

On 11/09/2015 09:16 PM, Laurent Pinchart wrote: > Hi Andrzej, > > Thank you for the patch. > > On Thursday 24 September 2015 16:00:12 Andrzej Hajda wrote: >> The function can return negative value. >> >> The problem has been detected using proposed semantic patch >>

Re: [Y2038] [PATCH v2 9/9] [media] omap3isp: support 64-bit version of omap3isp_stat_data

Hi Arnd, On Monday 09 November 2015 21:30:41 Arnd Bergmann wrote: > On Monday 09 November 2015 22:09:26 Laurent Pinchart wrote: > > On Thursday 17 September 2015 23:19:40 Arnd Bergmann wrote: > > > C libraries with 64-bit time_t use an incompatible format for > > > struct omap3isp_stat_data. This

[PATCH] omap4iss: Fix overlapping luma/chroma planes

From: Nate Weibley The chroma data base address for NV12 formatted data should begin offset rows*bytes_per_row from the base address for luminance data. We were OBO causing a stripe of green pixels at the bottom of the frame. Signed-off-by: Nate Weibley

Re: DVBSky T330 DVB-C regression Linux 4.1.12 to 4.3

Hi Stephan, I had a look at recent changes to si2168 and dvb-usb-dvbsky drivers that are the ones most relevant here. si2157 is probably not the issue here as your demod does lock. si2168: 2015-08-11[media] dvb-frontends: Drop owner assignment from i2c_driver 2015-06-09[media] dvb: Get