[PATCH] [media] radio-si470x-i2c: Delete owner assignment

2016-08-14 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 15 Aug 2016 07:01:56 +0200 The field "owner" is set by core. Thus delete an extra initialisation. Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Markus Elfring ---

Re: [PATCH] vcodec: mediatek: bug fix and code refine for mt8173 v4l2 Encoder

2016-08-14 Thread Tiffany Lin
Hi Hans, On Sun, 2016-08-14 at 13:40 +0200, Hans Verkuil wrote: > On 08/12/2016 04:35 PM, Tiffany Lin wrote: > > This patch include fixs: > > 1. Remove unused include in mtk_vcodec_drv.h > > 2. Fix visible_height larger than coded_height issue in s_fmt_out > > 3. Add timestamp and

[PATCH for v4.8] vcodec:mediatek: Refine VP8 encoder driver

2016-08-14 Thread Tiffany Lin
This patch remove field and function that unused anymore Signed-off-by: Tiffany Lin --- .../media/platform/mtk-vcodec/venc/venc_vp8_if.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git

[PATCH for v4.8] vcodec:mediatek: Refine H264 encoder driver

2016-08-14 Thread Tiffany Lin
This patch : 1. remove field and function that unused anymore 2. add support V4L2_MPEG_VIDEO_H264_LEVEL_4_2 Signed-off-by: Tiffany Lin --- .../media/platform/mtk-vcodec/venc/venc_h264_if.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[PATCH for v4.8] vcodec:mediatek: change H264 profile default to profile high

2016-08-14 Thread Tiffany Lin
This patch change default H264 profile from V4L2_MPEG_VIDEO_H264_PROFILE_MAIN to V4L2_MPEG_VIDEO_H264_PROFILE_HIGH Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH for v4.8] vcodec:mediatek: Add timestamp and timecode copy for V4L2 Encoder

2016-08-14 Thread Tiffany Lin
This patch add copying timestamp and timecode from src buffer to dst buffer Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 23 1 file changed, 19 insertions(+), 4 deletions(-) diff --git

[PATCH for v4.8] vcodec:mediatek: Fix visible_height larger than coded_height issue in s_fmt_out

2016-08-14 Thread Tiffany Lin
The original code add extra 32 line to visible_height. It is incorrect, 32 line should be add to coded_height. The purpose is that user space could calcuate real buffer size needed by using coded_width * coded_height. But this method will make v4l2-compliance test fail, since g_fmt != s_fmt(g_fmt)

cron job: media_tree daily build: WARNINGS

2016-08-14 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Aug 15 04:00:18 CEST 2016 git branch: test git hash: b6aa39228966e0d3f0bc3306be1892f87792903a gcc

[PATCH for v4.8] vcodec:mediatek: Fix fops_vcodec_release flow for V4L2 Encoder

2016-08-14 Thread Tiffany Lin
This patch fix that mtk_vcodec_venc_release should be called after v4l2_m2m_ctx_release Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c |7 ++- .../media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c |6 +- 2 files changed,

[PATCH for v4.8] vcodec:mediatek:code refine for v4l2 Encoder driver

2016-08-14 Thread Tiffany Lin
This patch remove unused header and define from haeder files Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h |1 - .../media/platform/mtk-vcodec/mtk_vcodec_intr.h|1 - 2 files changed, 2 deletions(-) diff --git

[PATCH v6] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-08-14 Thread Tiffany Lin
This patch add g/s_selection for MT8173 V4L2 Encoder. Only output queue support g/s_selection to configure crop. The top/left of active rectangle should always be (0,0) Signed-off-by: Tiffany Lin --- v6: - remove unused err variable from s_selection v5: - remove

ERROR: "bad_dma_ops" [drivers/media/platform/mtk-vpu/mtk-vpu.ko] undefined!

2016-08-14 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 118253a593bd1c57de2d1193df1ccffe1abe745b commit: 3003a180ef6b9462f32a89884ef2332d2a1c [media] VPU: mediatek: support Mediatek VPU date: 5 weeks ago config: m32r-allmodconfig (attached as .config)

[PATCH] media/i2c: Delete owner assignment

2016-08-14 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 14 Aug 2016 22:20:26 +0200 The field "owner" is set by core. Thus delete an extra initialisation. Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Markus Elfring ---

[PATCH v2] Documentation: add support for V4L touch devices

2016-08-14 Thread Nick Dyer
[v2: Fix minor issues and document V4L2_INPUT_TYPE_TOUCH and V4L2_CAP_TOUCH] Signed-off-by: Nick Dyer --- Documentation/media/uapi/mediactl/media-types.rst | 24 +++-- Documentation/media/uapi/v4l/dev-touch.rst| 56 +++

Re: [PATCH v3 02/14] media: mt9m111: prevent module removal while in use

2016-08-14 Thread Robert Jarzmik
Hans Verkuil writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: >> The mt9m111 can be a removable module : the only case where the module >> should be kept loaded is while it is used, ie. while an active >> transation is ongoing on it. >> >> The notion of active

Re: [PATCH v3 10/14] media: platform: pxa_camera: remove set_crop

2016-08-14 Thread Robert Jarzmik
Hans Verkuil writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: >> This is to be seen as a regression as the set_crop function is >> removed. This is a temporary situation in the v4l2 porting, and will >> have to be added later. > > This is a bit confusing, since in the

Re: [PATCH v3 11/14] media: platform: pxa_camera: make a standalone v4l2 device

2016-08-14 Thread Robert Jarzmik
Hans Verkuil writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: > >> +pcdev->sensor = subdev; >> +pcdev->vdev.queue = >vb2_vq; >> +pcdev->vdev.v4l2_dev = >v4l2_dev; > > You're missing this line here: > > pcdev->vdev.ctrl_handler = subdev->ctrl_handler;

Re: [PATCH v3 12/14] media: platform: pxa_camera: add debug register access

2016-08-14 Thread Robert Jarzmik
Hans Verkuil writes: > On 08/08/2016 09:30 PM, Robert Jarzmik wrote: >> Add pxa_camera registers access through advanced video debugging. >> +static int pxac_vidioc_g_chip_info(struct file *file, void *fh, >> + struct v4l2_dbg_chip_info *chip) >

Re: [PATCH] doc-rst: customize RTD theme, drop padding of inline literal

2016-08-14 Thread Jonathan Corbet
On Fri, 5 Aug 2016 11:27:07 +0200 Hans Verkuil wrote: > On 08/05/2016 11:19 AM, Markus Heiser wrote: > > From: Markus Heiser > > > > Remove the distracting (left/right) padding of inline literals. (HTML > > ). Requested and discussed in [1]. > >

Re: [PATCH 0/7] doc-rst: sphinx sub-folders & parseheaders directive

2016-08-14 Thread Jonathan Corbet
On Sat, 13 Aug 2016 16:12:41 +0200 Markus Heiser wrote: > this series is a consolidation on Jon's docs-next branch. It merges the > "sphinx > sub-folders" patch [1] and the "parseheaders directive" patch [2] on top of > Jon's docs-next. > > In sense of consolidation,

[PATCH] cec-core.rst: convert old cec.txt to sphinx.

2016-08-14 Thread Hans Verkuil
Convert the old ascii CEC kapi documentation to sphinx documentation. No textual changes, just an initial conversion. Signed-off-by: Hans Verkuil --- Documentation/{cec.txt => media/kapi/cec-core.rst} | 202 - Documentation/media/media_kapi.rst

[PATCH] helene: fix memory leak when heleno_x_pon fails

2016-08-14 Thread Colin King
From: Colin Ian King The error return path of failed calls to heleno_x_pon leak memory because priv is not kfree'd. Fix this by kfree'ing priv before returning. Signed-off-by: Colin Ian King --- drivers/media/dvb-frontends/helene.c | 8

[GIT PULL FOR v4.8] fixes and updates (mostly cec-related) (v2)

2016-08-14 Thread Hans Verkuil
Hi Mauro, These are (regression) fixes for 4.8, mostly related to the cec framework. It fixes some dubious locking code, two typos in cec-funcs.h, a missing reply for the Record On/Off messages, improves the documentation, adds a TODO line, adds a flag to explicitly allow fallback to

[PATCH for v4.8] cec: set unclaimed addresses to CEC_LOG_ADDR_INVALID

2016-08-14 Thread Hans Verkuil
Up to 4 logical addresses can be claimed. Make sure that any unclaimed logical addresses are set to CEC_LOG_ADDR_INVALID as per the documentation. Take special care in the unregistered case: when falling back to unregistered num_log_addrs may be > 1, so mark those as invalid. Signed-off-by: Hans

Re: [PATCH] vcodec: mediatek: bug fix and code refine for mt8173 v4l2 Encoder

2016-08-14 Thread Hans Verkuil
On 08/12/2016 04:35 PM, Tiffany Lin wrote: > This patch include fixs: > 1. Remove unused include in mtk_vcodec_drv.h > 2. Fix visible_height larger than coded_height issue in s_fmt_out > 3. Add timestamp and timecode copy > 4. Fix mtk_vcodec_vdec_release should be called after

[PATCHv2 for v4.8] cec: add CEC_LOG_ADDRS_FL_ALLOW_UNREG_FALLBACK flag

2016-08-14 Thread Hans Verkuil
Currently if none of the requested logical addresses can be claimed, the framework will fall back to the Unregistered logical address. Add a flag to enable this explicitly. By default it will just go back to the unconfigured state. Usually Unregistered is not something you want since the

[PATCH for v4.8] cec: ignore messages when log_addr_mask == 0

2016-08-14 Thread Hans Verkuil
Most CEC adapters will still receive broadcast messages, even if no logical addresses are claimed. But those messages should only be passed on for monitoring purposes, but not for processing by either kernel or userspace if userspace didn't call CEC_ADAP_S_LOG_ADDRS first. So if

[GIT PULL FOR v4.8] fixes and updates (mostly cec-related)

2016-08-14 Thread Hans Verkuil
Hi Mauro, These are (regression) fixes for 4.8, mostly related to the cec framework. It fixes some dubious locking code, two typos in cec-funcs.h, a missing reply for the Record On/Off messages, improves the documentation, adds a TODO line, adds a flag to explicitly allow fallback to

[PATCH] for v4.8 mtk-vcodec: add HAS_DMA dependency

2016-08-14 Thread Hans Verkuil
This fixes this kbuild test robot error: tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 329f4152911c276b074bec75a0443f88821afdb7 commit: c1023ba74fc77dc56dc317bd98f5060aab889ac1 [media] drivers/media/platform/Kconfig: fix VIDEO_MEDIATEK_VCODEC

[GIT PULL FOR v4.9] New tw5864 driver (v2)

2016-08-14 Thread Hans Verkuil
Passed v4l2-compliance, see https://patchwork.linuxtv.org/patch/35671/ for more details about the device. Regards, Hans Change since v2: fix Kconfig dependency. The following changes since commit b6aa39228966e0d3f0bc3306be1892f87792903a: Merge tag 'v4.8-rc1' into patchwork

[PATCH] tw5864: add missing HAS_DMA dependency

2016-08-14 Thread Hans Verkuil
Fix this warning: warning: (VIDEO_TW5864 && VIDEO_MEDIATEK_VCODEC) selects VIDEOBUF2_DMA_CONTIG which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA) This driver depends on HAS_DMA. Signed-off-by: Hans Verkuil --- drivers/media/pci/tw5864/Kconfig | 1 + 1

Re: [PATCH v3 00/14] pxa_camera transition to v4l2 standalone device

2016-08-14 Thread Hans Verkuil
On 08/08/2016 09:30 PM, Robert Jarzmik wrote: > Hi Hans, > > We're leaving the domain of the RFC to a proper submission. > > This is very alike to what you reviewed earlier, the code is very close, and : > - the split between patches is done to better isolate cleanups from real code > -

cron job: media_tree daily build: WARNINGS

2016-08-14 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun Aug 14 04:00:18 CEST 2016 git branch: test git hash: b6aa39228966e0d3f0bc3306be1892f87792903a gcc

Re: [PATCH v3 11/14] media: platform: pxa_camera: make a standalone v4l2 device

2016-08-14 Thread Hans Verkuil
On 08/08/2016 09:30 PM, Robert Jarzmik wrote: > +static int pxa_camera_sensor_bound(struct v4l2_async_notifier *notifier, > + struct v4l2_subdev *subdev, > + struct v4l2_async_subdev *asd) > +{ > + int err; > + struct v4l2_device *v4l2_dev =

Re: [PATCH v3 10/14] media: platform: pxa_camera: remove set_crop

2016-08-14 Thread Hans Verkuil
On 08/08/2016 09:30 PM, Robert Jarzmik wrote: > This is to be seen as a regression as the set_crop function is > removed. This is a temporary situation in the v4l2 porting, and will > have to be added later. This is a bit confusing, since in the next patch you say in the commit log: - the

Re: [PATCH v3 12/14] media: platform: pxa_camera: add debug register access

2016-08-14 Thread Hans Verkuil
On 08/08/2016 09:30 PM, Robert Jarzmik wrote: > Add pxa_camera registers access through advanced video debugging. > > Signed-off-by: Robert Jarzmik > --- > drivers/media/platform/soc_camera/pxa_camera.c | 57 > ++ > 1 file changed, 57

Re: [PATCH v3 02/14] media: mt9m111: prevent module removal while in use

2016-08-14 Thread Hans Verkuil
On 08/08/2016 09:30 PM, Robert Jarzmik wrote: > The mt9m111 can be a removable module : the only case where the module > should be kept loaded is while it is used, ie. while an active > transation is ongoing on it. > > The notion of active transaction is mapped on the power state of the > module

drivers/media/v4l2-core/videobuf2-dma-contig.c:486:2: error: implicit declaration of function 'dma_get_cache_alignment'

2016-08-14 Thread kbuild test robot
Hi Hans, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 329f4152911c276b074bec75a0443f88821afdb7 commit: c1023ba74fc77dc56dc317bd98f5060aab889ac1 [media] drivers/media/platform/Kconfig: fix VIDEO_MEDIATEK_VCODEC

Re: [PATCH] helene: fix memory leak when heleno_x_pon fails

2016-08-14 Thread Abylay Ospan
Hi Colin, It's really possible memory leak here. thanks for fix. Acked-by: Abylay Ospan 2016-08-13 14:16 GMT-04:00 Colin King : > From: Colin Ian King > > The error return path of failed calls to heleno_x_pon leak > memory