cron job: media_tree daily build: WARNINGS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Sep 20 04:00:17 CEST 2016 git branch: test git hash: 142a0e11b52c18a82c4fe55132b762005dda05c0 gcc

Re: Null pointer dereference in ngene-core.c

On Mon, Sep 19, 2016 at 8:51 PM, Alexandre-Xavier Labonté-Lamoureux wrote: > Hi people, > > In the file "/linux/drivers/media/pci/ngene/ngene-core.c", there is a > null pointer dereference at line 1480. > > Code in the function "static int init_channel(struct ngene_channel

Re: Null pointer dereference in ngene-core.c

On Mon, Sep 19, 2016 at 8:51 PM, Alexandre-Xavier Labonté-Lamoureux wrote: > Hi people, > > In the file "/linux/drivers/media/pci/ngene/ngene-core.c", there is a > null pointer dereference at line 1480. > > Code in the function "static int init_channel(struct ngene_channel

Summary of the discussion about Rockchip VPU in Gstreamer

Hello all media staff Dear Mr.Verkuil Dear Mr.Osciak I talked with Nicolas and Mr.ceyusa in the yesterday and early morning of today. I think I have made them get the situation of state-less Video Acceleration Unit(VPU) and Rockchip for VA-API driver. We both agree that creating a new C API

Null pointer dereference in ngene-core.c

Hi people, In the file "/linux/drivers/media/pci/ngene/ngene-core.c", there is a null pointer dereference at line 1480. Code in the function "static int init_channel(struct ngene_channel *chan)" == if (io & NGENE_IO_TSIN) { chan->fe = NULL;

Re: [PATCH v3 00/18] More smiapp cleanups, fixes

Hi, On Tue, Sep 20, 2016 at 01:02:33AM +0300, Sakari Ailus wrote: > This set further cleans up the smiapp driver and prepares for > later changes. > > since v2: > > - Fix badly formatted debug message on wrong frame format model type > > - Add a debug message on faulty frame descriptor (image

Re: [PATCH 2/5] smiapp: Set device for pixel array and binner

Hi, On Thu, Sep 15, 2016 at 02:29:18PM +0300, Sakari Ailus wrote: > The dev field of the v4l2_subdev was left NULL for the pixel array and > binner sub-devices. Fix this. > > Signed-off-by: Sakari Ailus Reviewed-By: Sebastian Reichel --

Re: [PATCH 3/5] smiapp: Set use suspend and resume ops for other functions

Hi, On Thu, Sep 15, 2016 at 02:29:19PM +0300, Sakari Ailus wrote: > Use the suspend and resume ops for freeze, thaw, poweroff and restore > callbacks as well. > > Signed-off-by: Sakari Ailus Reviewed-By: Sebastian Reichel -- Sebastian

Re: [PATCH v1.1 4/5] smiapp: Use runtime PM

Hi, On Fri, Sep 16, 2016 at 01:53:29AM +0300, Sakari Ailus wrote: > [...] > > diff --git a/drivers/media/i2c/smiapp/smiapp-regs.c > b/drivers/media/i2c/smiapp/smiapp-regs.c > index 1e501c0..a9c7baf 100644 > --- a/drivers/media/i2c/smiapp/smiapp-regs.c > +++

[PATCH] v4l-utils: ir-ctl: give proper error message if transmitter does not exist

If a transmitter does not exist when setting using -e, you get the error: warning: /dev/lirc0: failed to set send transmitters: Success Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH] [media] rc: rc6 decoder should report protocol correctly

When reporting decoded protocol use the enum rather than the bitmap. Signed-off-by: Sean Young --- drivers/media/rc/ir-rc6-decoder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/rc/ir-rc6-decoder.c b/drivers/media/rc/ir-rc6-decoder.c

[PATCH] [media] rc: Hauppauge z8f0811 can decode RC6

The hardware does not decode the 16, 20 or 24 bit variety. Signed-off-by: Sean Young --- drivers/media/i2c/ir-kbd-i2c.c | 90 ++-- drivers/media/pci/cx18/cx18-i2c.c| 3 +- drivers/media/pci/cx88/cx88-input.c | 3 +-

[PATCH] v4l-utils: ir-ctl: deal with consecutive pulses or spaces correctly

When sending a pulse-space file with consecutive spaces or pulses, add them together correctly. For example: pulse 100 space 150 space 100 pulse 150 pulse 200 Would send pulse 100, space 250, and pulse 350. Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.c | 4 ++-- 1 file

[PATCH v3 07/18] smiapp: Always initialise the sensor in probe

Initialise the sensor in probe. The reason why it wasn't previously done in case of platform data was that the probe() of the driver that provided the clock through the set_xclk() callback would need to finish before the probe() function of the smiapp driver. The set_xclk() callback no longer

[PATCH v3 03/18] smiapp: Initialise media entity after sensor init

This allows determining the number of pads in the entity based on the sensor. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v3 11/18] smiapp: Unify setting up sub-devices

The initialisation of the source sub-device is somewhat different as it's not created by the smiapp driver itself. Remove redundancy in initialising the two kind of sub-devices. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 5 + 1

[PATCH v3 10/18] smiapp: Read frame format earlier

The information gathered during frame format reading will be required earlier in the initialisation when it was available. Also return an error if frame format cannot be obtained. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 8 ++--

[PATCH v3 04/18] smiapp: Split off sub-device registration into two

Remove the loop in sub-device registration and create each sub-device explicitly instead. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 82 +++--- 1 file changed, 45 insertions(+), 37 deletions(-) diff --git

[PATCH v3 08/18] smiapp: Fix resource management in registration failure

If the registered() callback failed, resources were left unaccounted for. Fix this, as well as add unregistering the sub-devices in driver unregistered() callback. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 22 +- 1

[PATCH v3 05/18] smiapp: Provide a common function to obtain native pixel array size

The same pixel array size is required for the active format of each sub-device sink pad and try format of each sink pad of each opened file handle as well as for the native size rectangle. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 39

[PATCH v3 18/18] smiapp-pll: Don't complain aloud about failing PLL calculation

Don't complain about a failure to compute the pre_pll divisor. The function is used to determine whether a particular combination of bits per sample value and a link frequency can be used, in which case there are lots of unnecessary driver messages. During normal operation the failure generally

[PATCH v3 17/18] smiapp: Drop a debug print on frame size and bit depth

The first time the sensor is powered on, the information is not yet available. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/media/i2c/smiapp/smiapp-core.c

[PATCH v3 14/18] smiapp: Improve debug messages from frame layout reading

Provide more debugging information on reading the frame layout. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/media/i2c/smiapp/smiapp-core.c

[PATCH v3 12/18] smiapp: Use SMIAPP_PADS when referring to number of pads

Replace plain value 2 with SMIAPP_PADS when referring to the number of pads. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/smiapp/smiapp.h

[PATCH v3 06/18] smiapp: Remove unnecessary BUG_ON()'s

Instead, calculate how much is needed and then allocate the memory dynamically. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 24 ++-- drivers/media/i2c/smiapp/smiapp.h | 8 ++-- 2 files changed, 20

[PATCH v3 15/18] smiapp: Remove useless newlines and other small cleanups

The code probably has been unindented at some point but rewrapping has not been done. Do it now. Also remove a useless memory allocation failure message. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 33 +

[PATCH v3 16/18] smiapp: Obtain correct media bus code for try format

The media bus code obtained for try format may have been a code that the sensor did not even support. Use a supported code with the current pixel order. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 4 +--- 1 file changed, 1 insertion(+),

[PATCH v3 13/18] smiapp: Obtain frame layout from the frame descriptor

Besides the image data, SMIA++ compliant sensors also provide embedded data in form of registers used to capture the image. Store this information for later use in frame descriptor and routing. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c

[PATCH v3 02/18] smiapp: Explicitly define number of pads in initialisation

Define the number of pads explicitly in initialising the sub-devices. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git

[PATCH v3 09/18] smiapp: Merge smiapp_init() with smiapp_probe()

The smiapp_probe() is the sole caller of smiapp_init(). Unify the two. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 423 - 1 file changed, 204 insertions(+), 219 deletions(-) diff --git

[PATCH v3 00/18] More smiapp cleanups, fixes

Hi, This set further cleans up the smiapp driver and prepares for later changes. since v2: - Fix badly formatted debug message on wrong frame format model type - Add a debug message on faulty frame descriptor (image data lines are among embedded data lines) - Fix error handling in

[PATCH v3 01/18] smiapp: Move sub-device initialisation into a separate function

Simplify smiapp_init() by moving the initialisation of individual sub-devices to a separate function. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 110 +++-- 1 file changed, 51 insertions(+), 59 deletions(-)

Re: [PATCH v2 03/17] smiapp: Initialise media entity after sensor init

Hi, On Thu, Sep 15, 2016 at 02:22:17PM +0300, Sakari Ailus wrote: > This allows determining the number of pads in the entity based on the > sensor. > > Signed-off-by: Sakari Ailus > --- > drivers/media/i2c/smiapp/smiapp-core.c | 10 +- > 1 file changed, 5

Re: [PATCH v2 17/17] smiapp-pll: Don't complain aloud about failing PLL calculation

Hi, On Thu, Sep 15, 2016 at 02:22:31PM +0300, Sakari Ailus wrote: > Don't complain about a failure to compute the pre_pll divisor. The > function is used to determine whether a particular combination of bits per > sample value and a link frequency can be used, in which case there are > lots of

Re: [PATCH v2 16/17] smiapp: Drop a debug print on frame size and bit depth

Hi, On Thu, Sep 15, 2016 at 02:22:30PM +0300, Sakari Ailus wrote: > The first time the sensor is powered on, the information is not yet > available. > > Signed-off-by: Sakari Ailus Reviewed-By: Sebastian Reichel -- Sebastian signature.asc

Re: [PATCH v2 15/17] smiapp: Obtain correct media bus code for try format

Hi, On Thu, Sep 15, 2016 at 02:22:29PM +0300, Sakari Ailus wrote: > The media bus code obtained for try format may have been a code that the > sensor did not even support. Use a supported code with the current pixel > order. Reviewed-By: Sebastian Reichel -- Sebastian

Re: [PATCH v2 14/17] smiapp: Remove useless newlines and other small cleanups

Hi, On Thu, Sep 15, 2016 at 02:22:28PM +0300, Sakari Ailus wrote: > The code probably has been unindented at some point but rewrapping has not > been done. Do it now. > > Also remove a useless memory allocation failure message. Reviewed-By: Sebastian Reichel -- Sebastian

Re: [PATCH v2 13/17] smiapp: Improve debug messages from frame layout reading

Hi, On Thu, Sep 15, 2016 at 02:22:27PM +0300, Sakari Ailus wrote: > Provide more debugging information on reading the frame layout. > > [...] > > @@ -130,7 +127,7 @@ static int smiapp_read_frame_fmt(struct smiapp_sensor > *sensor) > pixels = desc &

Re: [PATCH v2 09/17] smiapp: Read frame format earlier

Hi, On Tue, Sep 20, 2016 at 12:19:54AM +0300, Sakari Ailus wrote: > Hi Sebastian, > > Sebastian Reichel wrote: > > Hi, > > > > On Thu, Sep 15, 2016 at 02:22:23PM +0300, Sakari Ailus wrote: > > > The information gathered during frame format reading will be required > > > earlier in the

Re: [PATCH v2 12/17] smiapp: Obtain frame layout from the frame descriptor

Hi, On Thu, Sep 15, 2016 at 02:22:26PM +0300, Sakari Ailus wrote: > Besides the image data, SMIA++ compliant sensors also provide embedded > data in form of registers used to capture the image. Store this > information for later use in frame descriptor and routing. Reviewed-By: Sebastian Reichel

Re: [PATCH v2 09/17] smiapp: Read frame format earlier

Hi Sebastian, Sebastian Reichel wrote: Hi, On Thu, Sep 15, 2016 at 02:22:23PM +0300, Sakari Ailus wrote: The information gathered during frame format reading will be required earlier in the initialisation when it was available. Also return an error if frame format cannot be obtained.

Re: [PATCH v2 11/17] smiapp: Use SMIAPP_PADS when referring to number of pads

Hi, On Thu, Sep 15, 2016 at 02:22:25PM +0300, Sakari Ailus wrote: > Replace plain value 2 with SMIAPP_PADS when referring to the number of > pads. Reviewed-By: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 10/17] smiapp: Unify setting up sub-devices

Hi, On Thu, Sep 15, 2016 at 02:22:24PM +0300, Sakari Ailus wrote: > The initialisation of the source sub-device is somewhat different as it's > not created by the smiapp driver itself. Remove redundancy in initialising > the two kind of sub-devices. Reviewed-By: Sebastian Reichel

Re: [PATCH v2 09/17] smiapp: Read frame format earlier

Hi, On Thu, Sep 15, 2016 at 02:22:23PM +0300, Sakari Ailus wrote: > The information gathered during frame format reading will be required > earlier in the initialisation when it was available. Also return an error > if frame format cannot be obtained. > > Signed-off-by: Sakari Ailus

Re: [PATCH v2 08/17] smiapp: Merge smiapp_init() with smiapp_probe()

Hi, On Thu, Sep 15, 2016 at 02:22:22PM +0300, Sakari Ailus wrote: > The smiapp_probe() is the sole caller of smiapp_init(). Unify the two. Reviewed-By: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 07/17] smiapp: Always initialise the sensor in probe

Sebastian Reichel wrote: Hi, On Thu, Sep 15, 2016 at 02:22:21PM +0300, Sakari Ailus wrote: Initialise the sensor in probe. The reason why it wasn't previously done in case of platform data was that the probe() of the driver that provided the clock through the set_xclk() callback would need to

Re: [PATCH v2 04/17] smiapp: Split off sub-device registration into two

Hi, On Mon, Sep 19, 2016 at 11:50:02PM +0300, Sakari Ailus wrote: > Hi Sebastian, > > Sebastian Reichel wrote: > > Hi, > > > > On Thu, Sep 15, 2016 at 02:22:18PM +0300, Sakari Ailus wrote: > > > Remove the loop in sub-device registration and create each sub-device > > > explicitly instead. > >

Re: [PATCH v2 07/17] smiapp: Always initialise the sensor in probe

Hi, On Thu, Sep 15, 2016 at 02:22:21PM +0300, Sakari Ailus wrote: > Initialise the sensor in probe. The reason why it wasn't previously done > in case of platform data was that the probe() of the driver that provided > the clock through the set_xclk() callback would need to finish before the >

Re: [PATCH v2 01/17] smiapp: Move sub-device initialisation into a separate function

Hi Sebastian, Thank you for the review! Sebastian Reichel wrote: Hi, On Thu, Sep 15, 2016 at 02:22:15PM +0300, Sakari Ailus wrote: Simplify smiapp_init() by moving the initialisation of individual sub-devices to a separate function. Reviewed-By: Sebastian Reichel

Re: [PATCH v2 04/17] smiapp: Split off sub-device registration into two

Hi Sebastian, Sebastian Reichel wrote: Hi, On Thu, Sep 15, 2016 at 02:22:18PM +0300, Sakari Ailus wrote: Remove the loop in sub-device registration and create each sub-device explicitly instead. Reviewed-By: Sebastian Reichel Thanks! +static int

Re: [PATCH 1/6] arcmsr: use pci_alloc_irq_vectors

> "Christoph" == Christoph Hellwig writes: Christoph> Switch the arcmsr driver to use pci_alloc_irq_vectors. We Christoph> need to two calls to pci_alloc_irq_vectors as arcmsr only Christoph> supports multiple MSI-X vectors, but not multiple MSI Christoph> vectors. Christoph>

Re: [PATCH 2/6] ipr: use pci_irq_allocate_vectors

> "Christoph" == Christoph Hellwig writes: Christoph> Switch the ipr driver to use pci_alloc_irq_vectors. We need Christoph> to two calls to pci_alloc_irq_vectors as ipr only supports Christoph> multiple MSI-X vectors, but not multiple MSI vectors. Christoph> Otherwise this

Re: [PATCH v2 06/17] smiapp: Remove unnecessary BUG_ON()'s

Hi, On Thu, Sep 15, 2016 at 02:22:20PM +0300, Sakari Ailus wrote: > Instead, calculate how much is needed and then allocate the memory > dynamically. Reviewed-By: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 05/17] smiapp: Provide a common function to obtain native pixel array size

Hi, On Thu, Sep 15, 2016 at 02:22:19PM +0300, Sakari Ailus wrote: > The same pixel array size is required for the active format of each > sub-device sink pad and try format of each sink pad of each opened file > handle as well as for the native size rectangle. Reviewed-By: Sebastian Reichel

Re: [PATCH v2 04/17] smiapp: Split off sub-device registration into two

Hi, On Thu, Sep 15, 2016 at 02:22:18PM +0300, Sakari Ailus wrote: > Remove the loop in sub-device registration and create each sub-device > explicitly instead. Reviewed-By: Sebastian Reichel > +static int smiapp_register_subdevs(struct smiapp_sensor *sensor) > +{ > + int

Re: [PATCH v2 02/17] smiapp: Explicitly define number of pads in initialisation

Hi, On Thu, Sep 15, 2016 at 02:22:16PM +0300, Sakari Ailus wrote: > Define the number of pads explicitly in initialising the sub-devices. Reviewed-By: Sebastian Reichel -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 01/17] smiapp: Move sub-device initialisation into a separate function

Hi, On Thu, Sep 15, 2016 at 02:22:15PM +0300, Sakari Ailus wrote: > Simplify smiapp_init() by moving the initialisation of individual > sub-devices to a separate function. Reviewed-By: Sebastian Reichel > Signed-off-by: Sakari Ailus > --- >

Re: [PATCH for v4.8] cx23885/saa7134: assign q->dev to the PCI device

On Sun, 18 Sep 2016, Hans Verkuil wrote: Fix a regression caused by commit 2bc46b3a (media/pci: convert drivers to use the new vb2_queue dev field). Three places where q->dev should be set were missed, causing a WARN. Signed-off-by: Hans Verkuil Reported-by: Marton

Re: [PATCH] [media] vsp1: fix CodingStyle violations on multi-line comments

Em Mon, 19 Sep 2016 21:35:36 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > > On Monday 19 Sep 2016 15:26:19 Mauro Carvalho Chehab wrote: > > Several multi-line comments added at the vsp1 patch series > > violate the Kernel

Re: [PATCH 06/13] v4l: vsp1: Disable cropping on WPF sink pad

Em Mon, 19 Sep 2016 21:33:13 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Monday 19 Sep 2016 15:26:15 Mauro Carvalho Chehab wrote: > > Em Mon, 19 Sep 2016 20:59:56 +0300 Laurent Pinchart escreveu: > > > On Monday 19 Sep 2016 14:55:43 Mauro Carvalho

Re: [PATCH] [media] vsp1: fix CodingStyle violations on multi-line comments

Hi Mauro, Thank you for the patch. On Monday 19 Sep 2016 15:26:19 Mauro Carvalho Chehab wrote: > Several multi-line comments added at the vsp1 patch series > violate the Kernel CodingStyle. Fix them. > > Signed-off-by: Mauro Carvalho Chehab I prefer the current style

Re: [PATCH 06/13] v4l: vsp1: Disable cropping on WPF sink pad

Hi Mauro, On Monday 19 Sep 2016 15:26:15 Mauro Carvalho Chehab wrote: > Em Mon, 19 Sep 2016 20:59:56 +0300 Laurent Pinchart escreveu: > > On Monday 19 Sep 2016 14:55:43 Mauro Carvalho Chehab wrote: > >> Em Wed, 14 Sep 2016 02:16:59 +0300 Laurent Pinchart escreveu: > >>> Cropping on the WPF sink

[PATCH] [media] vsp1: fix CodingStyle violations on multi-line comments

Several multi-line comments added at the vsp1 patch series violate the Kernel CodingStyle. Fix them. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/vsp1/vsp1_bru.c| 3 ++- drivers/media/platform/vsp1/vsp1_clu.c| 3 ++-

Re: [PATCH 06/13] v4l: vsp1: Disable cropping on WPF sink pad

Em Mon, 19 Sep 2016 20:59:56 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Monday 19 Sep 2016 14:55:43 Mauro Carvalho Chehab wrote: > > Em Wed, 14 Sep 2016 02:16:59 +0300 Laurent Pinchart escreveu: > > > Cropping on the WPF sink pad restricts the left

Re: TW2866 i2c driver and solo6x10

I'm going to have quite constrained time for participation in this driver development, but still I think this is perspective project which is in line with trend of exposing internal details of complex media hardware for configuration by V4L2 framework. Also tw286x are used in both tw5864 and

Re: [PATCH 06/13] v4l: vsp1: Disable cropping on WPF sink pad

Hi Mauro, On Monday 19 Sep 2016 14:55:43 Mauro Carvalho Chehab wrote: > Em Wed, 14 Sep 2016 02:16:59 +0300 Laurent Pinchart escreveu: > > Cropping on the WPF sink pad restricts the left and top coordinates to > > 0-255. The same result can be obtained by cropping on the RPF without > > any such

Re: [PATCH 06/13] v4l: vsp1: Disable cropping on WPF sink pad

Em Wed, 14 Sep 2016 02:16:59 +0300 Laurent Pinchart escreveu: > Cropping on the WPF sink pad restricts the left and top coordinates to > 0-255. The same result can be obtained by cropping on the RPF without > any such restriction, this feature isn't

Re: [PATCH] [media] videodev2.h.rst.exceptions: fix warnings

On 09/19/2016 07:32 PM, Mauro Carvalho Chehab wrote: > Changeset ab6343956f9c ("[media] V4L2: Add documentation for SDI timings > and related flags") added documentation for new V4L2 defines, but > it forgot to update videodev2.h.rst.exceptions to point to where > the documentation for those new

[PATCH] [media] gs1662: make checkpatch happy

WARNING: line over 80 characters +GS_HEIGHT_MAX, GS_PIXELCLOCK_MIN, GS_PIXELCLOCK_MAX, WARNING: line over 80 characters + if (v4l2_match_dv_timings(timings, _fmt[i].format, 0, false)) WARNING: Block comments use a trailing */ on a separate line +

[PATCH] [media] videodev2.h.rst.exceptions: fix warnings

Changeset ab6343956f9c ("[media] V4L2: Add documentation for SDI timings and related flags") added documentation for new V4L2 defines, but it forgot to update videodev2.h.rst.exceptions to point to where the documentation for those new values will be inside the book, causing those warnings:

Re: [PATCH v4 0/8] adv7180 subdev fixes, v4

On 09/19/2016 04:19 PM, Jack Mitchell wrote: > > > On 03/08/16 19:03, Steve Longerbeam wrote: >> Steve Longerbeam (8): >> media: adv7180: fix field type >> media: adv7180: define more registers >> media: adv7180: add support for NEWAVMODE >> media: adv7180: add power pin control >>

Re: [PATCH v2 0/3] doc-rst:c-domain: fix some issues in the c-domain

Em Mon, 19 Sep 2016 13:36:55 +0200 Markus Heiser escreveu: > Hi Mauro, > > sorry for my late reply (so much work to do) .. > > Am 09.09.2016 um 14:25 schrieb Markus Heiser : > > >> Using either this approach or my kernel-doc patch, I'm

Re: [PATCH v4 0/8] adv7180 subdev fixes, v4

On 03/08/16 19:03, Steve Longerbeam wrote: Steve Longerbeam (8): media: adv7180: fix field type media: adv7180: define more registers media: adv7180: add support for NEWAVMODE media: adv7180: add power pin control media: adv7180: implement g_parm media: adv7180: change mbus format

Re: [v4l-utils PATCH 2/2] Add --with-static-binaries option to link binaries statically

Hi Mauro, On Mon, Sep 19, 2016 at 11:21:50AM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 19 Sep 2016 16:22:30 +0300 > Sakari Ailus escreveu: > > > Add a new variable STATIC_LDFLAGS to add the linker flags required for > > static linking for each binary built. > >

Re: [v4l-utils PATCH 2/2] Add --with-static-binaries option to link binaries statically

Em Mon, 19 Sep 2016 16:22:30 +0300 Sakari Ailus escreveu: > Add a new variable STATIC_LDFLAGS to add the linker flags required for > static linking for each binary built. > > Static and dynamic libraries are built by default but the binaries are > otherwise linked

Re: [v4l-utils PATCH 1/1] Fix static linking of v4l2-compliance and v4l2-ctl

Em Mon, 19 Sep 2016 16:21:30 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On 09/19/16 14:22, Mauro Carvalho Chehab wrote: > > Em Mon, 19 Sep 2016 13:50:25 +0300 > > Sakari Ailus escreveu: > > > >> v4l2-compliance and v4l2-ctl

[v4l-utils PATCH 2/2] Add --with-static-binaries option to link binaries statically

Add a new variable STATIC_LDFLAGS to add the linker flags required for static linking for each binary built. Static and dynamic libraries are built by default but the binaries are otherwise linked dynamically. --with-static-binaries requires that static libraries are built. Signed-off-by: Sakari

Re: [v4l-utils PATCH 1/1] Fix static linking of v4l2-compliance and v4l2-ctl

Hi Mauro, On 09/19/16 14:22, Mauro Carvalho Chehab wrote: > Em Mon, 19 Sep 2016 13:50:25 +0300 > Sakari Ailus escreveu: > >> v4l2-compliance and v4l2-ctl depend on librt and libpthread. The symbols >> are found by the linker only if these libraries are specified

[ANN] Codec & Request API Brainstorm meeting Oct 10 & 11

On October 10 and 11 we will have a Codec & Request API brainstorm meeting. It will be held in room 'Salon 13 Paris' located on level 1 of the Maritim Berlin Hotel from 9am to 5pm each day. The main reason for doing this is that we have at least two codec drivers that are blocked due to the

[PATCH] [media] platform: pxa_camera: add VIDEO_V4L2 dependency

Moving the pxa_camera driver from soc_camera lots the implied VIDEO_V4L2 Kconfig dependency, and building the driver without V4L2 results in a kernel that cannot link: drivers/media/platform/pxa_camera.o: In function `pxa_camera_remove': pxa_camera.c:(.text.pxa_camera_remove+0x10): undefined

Re: [PATCH v2 0/3] doc-rst:c-domain: fix some issues in the c-domain

Hi Mauro, sorry for my late reply (so much work to do) .. Am 09.09.2016 um 14:25 schrieb Markus Heiser : >> Using either this approach or my kernel-doc patch, I'm now getting >> only two warnings: >> >> 1) at media-entity.h, even without nitpick mode: >> >>

Re: [v4l-utils PATCH 1/1] Fix static linking of v4l2-compliance and v4l2-ctl

Em Mon, 19 Sep 2016 13:50:25 +0300 Sakari Ailus escreveu: > v4l2-compliance and v4l2-ctl depend on librt and libpthread. The symbols > are found by the linker only if these libraries are specified after the > objects that depend on them. > > As LDFLAGS variable end

[v4l-utils PATCH 1/1] Fix static linking of v4l2-compliance and v4l2-ctl

v4l2-compliance and v4l2-ctl depend on librt and libpthread. The symbols are found by the linker only if these libraries are specified after the objects that depend on them. As LDFLAGS variable end up expanded on libtool command line before LDADD, move the libraries to LDADD after local objects.

Re: [PATCH v2 0/8] Qualcomm video decoder/encoder driver

Hi Stanimir, I've finished my review of this patch series. I'll be traveling for the next three weeks, so you can take your time with making a v3 since it is very unlikely I'll be able to review it before I'm back mid-October. Thanks for working on this! Regards, Hans On 09/07/2016

Re: [PATCH v2 7/8] media: vidc: add Makefiles and Kconfig files

On 09/07/2016 01:37 PM, Stanimir Varbanov wrote: > Makefile and Kconfig files to build the video codec driver. > > Signed-off-by: Stanimir Varbanov > --- > drivers/media/platform/qcom/Kconfig | 8 > drivers/media/platform/qcom/Makefile | 6

Re: [PATCH v2 4/8] media: vidc: encoder: add video encoder files

Many of my review comments for the decoder apply to the encoder as well, so I won't repeat those. On 09/07/2016 01:37 PM, Stanimir Varbanov wrote: > This adds encoder part of the driver plus encoder controls. > > Signed-off-by: Stanimir Varbanov > --- >

Re: [PATCH v2 3/8] media: vidc: decoder: add video decoder files

On 09/07/2016 01:37 PM, Stanimir Varbanov wrote: > This consists of video decoder implementation plus decoder > controls. > > Signed-off-by: Stanimir Varbanov > --- > drivers/media/platform/qcom/vidc/vdec.c | 1091 > + >

Re: [PATCH v2 3/8] media: vidc: decoder: add video decoder files

On 09/07/2016 01:37 PM, Stanimir Varbanov wrote: > This consists of video decoder implementation plus decoder > controls. > > Signed-off-by: Stanimir Varbanov > --- > drivers/media/platform/qcom/vidc/vdec.c | 1091 > + >

Re: [PATCH] pixfmt-reserved.rst: Improve MT21C documentation

Hi Hans, On Mon, 2016-09-19 at 09:22 +0200, Hans Verkuil wrote: > Improve the MT21C documentation, making it clearer that this format requires > the MDP > for further processing. > > Also fix the fourcc (it was a fivecc :-) ) > reviewed-by: Tiffany Lin Thanks. I did

Re: [PATCH] mtk-mdp: fix double mutex_unlock

On Mon, 2016-09-19 at 10:00 +0200, Hans Verkuil wrote: > Fix smatch error: > > media-git/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c:100 > mtk_mdp_vpu_send_msg() error: double unlock 'mutex:>mdp_dev->vpulock' > > Signed-off-by: Hans Verkuil Reviewed-by: Minghsiu Tsai

[PATCH] mtk-mdp: fix double mutex_unlock

Fix smatch error: media-git/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c:100 mtk_mdp_vpu_send_msg() error: double unlock 'mutex:>mdp_dev->vpulock' Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c

[PATCH] pixfmt-reserved.rst: Improve MT21C documentation

Improve the MT21C documentation, making it clearer that this format requires the MDP for further processing. Also fix the fourcc (it was a fivecc :-) ) Signed-off-by: Hans Verkuil --- diff --git a/Documentation/media/uapi/v4l/pixfmt-reserved.rst

Re: [PATCH 1/3] ARM: dts: r8a7793: Enable VIN0, VIN1

Hi Ulrich, On Fri, Sep 16, 2016 at 3:09 PM, Ulrich Hecht wrote: > Signed-off-by: Ulrich Hecht Reviewed-by: Geert Uytterhoeven > --- a/arch/arm/boot/dts/r8a7793.dtsi > +++ b/arch/arm/boot/dts/r8a7793.dtsi

[GIT PULL v2 FOR v4.10] Media IOCTL handling rework

Hi Mauro, These four patches rework Media controller IOCTL handling for cleanups and preparation for variable sized IOCTL arguments. What's changed since the previous set is

[PATCH 2/2] media: mtk-mdp: fix build error

This patch fix build error without CONFIG_PM_RUNTIME and CONFIG_PM_SLEEP Signed-off-by: Minghsiu Tsai --- drivers/media/platform/mtk-mdp/mtk_mdp_core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 1/2] media: mtk-mdp: fix build warning in arch x86

This patch fix build warning in arch x86 Signed-off-by: Minghsiu Tsai --- drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c |1 + drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c | 10 ++ 2 files changed, 7 insertions(+), 4 deletions(-) diff --git

[PATCH 0/2] Fix build warning and error in Mediatek MDP driver

- Fix build warning in arch x86 - Fix build warning in kzalloc() and kfree() in arch x86 - Fix build error without CONFIG_PM_RUNTIME and CONFIG_PM_SLEEP v4l2-compliance test output: v4l2-compliance SHA : abc1453dfe89f244dccd3460d8e1a2e3091cbadb Driver Info: Driver name : mtk-mdp

Re: [PATCH] Potential fix for "[BUG] process stuck when closing saa7146 [dvb_ttpci]"

Hello Andrey, Am 16.09.2016 um 12:00 schrieb Andrey Utkin: > Please try this patch. It is purely speculative as I don't have the hardware, > but I hope my approach is right. Thanks you for the patch; I've built a new kernel but didn't have the time to test it yet; I'll mail you again as soon as

[PATCH] [media] st-hva: fix a copy-and-paste variable name error

From: Colin Ian King The second check for an error on hva->lmi_err_reg appears to be a copy-and-paste error, it should be hva->emi_err_reg instead. Signed-off-by: Colin Ian King --- drivers/media/platform/sti/hva/hva-hw.c | 2 +- 1 file