Darlehen Angebot von 3%
Schönen Tag, Dies ist Lloyds TSB Bank plc Kredite anbieten. Lloyds TSB bietet flexible und günstige Kredite für jeden Zweck Sie Ihre Ziele erreichen zu helfen. wir bei niedrigen Zinssatz von 3% Darlehen. Hier sind einige wichtige Merkmale der persönlichen Kredit angeboten durch Lloyds TSB. Hier sind die Darlehen Faktoren, die wir mit den führenden britischen Makler arbeiten, die Zugang zu Top-Kreditgeber haben und sind in der Lage, die beste finanzielle Lösung zu einem erschwinglichen price.Please zu finden, wenn Sie daran interessiert sind, uns freundlich über diese E-Mail an: lloyds26...@gmail.com Nach der Reaktion wird eine Anwendung für Darlehen füllen erhalten. Keine soziale Sicherheit und keine Bonitätsprüfung, 100% garantiert. Es wird uns eine Ehre, wenn Sie uns erlauben, zu Ihren Diensten zu sein. erforderlichen Informationen, um Deine Namen: Adresse: ... Telefon: ... Benötigte Menge: Dauer: ... Beruf: ... Monatliches Einkommen Level: Geschlecht: ... Geburtsdatum: Bundesland: .. Land: .. Zweck: . Treffen Sie Ihre finanziellen Bedürfnisse ist unser Stolz. Dr.John Mahama. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
cron job: media_tree daily build: ERRORS
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Oct 11 05:00:18 CEST 2016 media-tree git hash:9fce0c226536fc36c7fb0a8ca38a995be43e media_build git hash: ecfc9bfca3012b0c6e19967ce90f621f71a6da94 v4l-utils git hash: 7c2664b9a9b411d8b183009146e4f8548ca1d81a gcc version:i686-linux-gcc (GCC) 6.2.0 sparse version: v0.5.0-3553-g78b2ea6 smatch version: v0.5.0-3553-g78b2ea6 host hardware: x86_64 host os:4.7.0-164 linux-git-arm-at91: ERRORS linux-git-arm-davinci: ERRORS linux-git-arm-multi: ERRORS linux-git-arm-pxa: OK linux-git-blackfin-bf561: OK linux-git-i686: OK linux-git-m32r: WARNINGS linux-git-mips: ERRORS linux-git-powerpc64: OK linux-git-sh: OK linux-git-x86_64: OK linux-2.6.36.4-i686: WARNINGS linux-2.6.37.6-i686: WARNINGS linux-2.6.38.8-i686: ERRORS linux-2.6.39.4-i686: WARNINGS linux-3.0.60-i686: WARNINGS linux-3.1.10-i686: ERRORS linux-3.2.37-i686: ERRORS linux-3.3.8-i686: ERRORS linux-3.4.27-i686: WARNINGS linux-3.5.7-i686: WARNINGS linux-3.6.11-i686: WARNINGS linux-3.7.4-i686: WARNINGS linux-3.8-i686: WARNINGS linux-3.9.2-i686: WARNINGS linux-3.10.1-i686: WARNINGS linux-3.11.1-i686: OK linux-3.13.11-i686: WARNINGS linux-3.14.9-i686: WARNINGS linux-3.15.2-i686: WARNINGS linux-3.16.7-i686: WARNINGS linux-3.17.8-i686: WARNINGS linux-3.18.7-i686: WARNINGS linux-3.19-i686: WARNINGS linux-4.0.9-i686: WARNINGS linux-4.1.33-i686: WARNINGS linux-4.2.8-i686: WARNINGS linux-4.3.6-i686: WARNINGS linux-4.4.22-i686: WARNINGS linux-4.5.7-i686: WARNINGS linux-4.6.7-i686: WARNINGS linux-4.7.5-i686: WARNINGS linux-4.8-i686: OK linux-2.6.36.4-x86_64: WARNINGS linux-2.6.37.6-x86_64: WARNINGS linux-2.6.38.8-x86_64: ERRORS linux-2.6.39.4-x86_64: WARNINGS linux-3.0.60-x86_64: WARNINGS linux-3.1.10-x86_64: ERRORS linux-3.2.37-x86_64: ERRORS linux-3.3.8-x86_64: ERRORS linux-3.4.27-x86_64: WARNINGS linux-3.5.7-x86_64: WARNINGS linux-3.6.11-x86_64: WARNINGS linux-3.7.4-x86_64: WARNINGS linux-3.8-x86_64: WARNINGS linux-3.9.2-x86_64: WARNINGS linux-3.10.1-x86_64: WARNINGS linux-3.11.1-x86_64: OK linux-3.13.11-x86_64: WARNINGS linux-3.14.9-x86_64: WARNINGS linux-3.15.2-x86_64: WARNINGS linux-3.16.7-x86_64: WARNINGS linux-3.17.8-x86_64: WARNINGS linux-3.18.7-x86_64: WARNINGS linux-3.19-x86_64: WARNINGS linux-4.0.9-x86_64: WARNINGS linux-4.1.33-x86_64: WARNINGS linux-4.2.8-x86_64: WARNINGS linux-4.3.6-x86_64: WARNINGS linux-4.4.22-x86_64: WARNINGS linux-4.5.7-x86_64: WARNINGS linux-4.6.7-x86_64: WARNINGS linux-4.7.5-x86_64: WARNINGS linux-4.8-x86_64: OK apps: WARNINGS spec-git: OK smatch: ERRORS sparse: WARNINGS Detailed results are available here: http://www.xs4all.nl/~hverkuil/logs/Tuesday.log Full logs are available here: http://www.xs4all.nl/~hverkuil/logs/Tuesday.tar.bz2 The Media Infrastructure API from this daily build is here: http://www.xs4all.nl/~hverkuil/spec/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [Patch 00/35] media: ti-vpe: fixes and enhancements
Hans, Mauro, Ping. Benoit -Original Message- From: Parrot, Benoit Sent: Wednesday, September 28, 2016 4:16 PM To: Hans Verkuil Cc: linux-media@vger.kernel.org; linux-ker...@vger.kernel.org; Parrot, Benoit Subject: [Patch 00/35] media: ti-vpe: fixes and enhancements This patch series is to publish a number of enhancements we have been carrying for a while. A number of bug fixes and feature enhancements have been included. We also need to prepare the way for the introduction of the VIP (Video Input Port) driver (coming soon) which has internal IP module in common with VPE. The relevant modules (vpdma, sc and csc) are therefore converted into individual kernel modules. Archit Taneja (1): media: ti-vpe: Use line average de-interlacing for first 2 frames Benoit Parrot (16): media: ti-vpe: vpdma: Make vpdma library into its own module media: ti-vpe: vpdma: Add multi-instance and multi-client support media: ti-vpe: vpdma: Add helper to set a background color media: ti-vpe: vpdma: Fix bus error when vpdma is writing a descriptor media: ti-vpe: vpe: Added MODULE_DEVICE_TABLE hint media: ti-vpe: vpdma: Corrected YUV422 data type label. media: ti-vpe: vpdma: RGB data type yield inverted data media: ti-vpe: vpe: Fix vb2 buffer cleanup media: ti-vpe: vpe: Enable DMABUF export media: ti-vpe: Make scaler library into its own module media: ti-vpe: scaler: Add debug support for multi-instance media: ti-vpe: vpe: Make sure frame size dont exceed scaler capacity media: ti-vpe: vpdma: Add RAW8 and RAW16 data types media: ti-vpe: Make colorspace converter library into its own module media: ti-vpe: csc: Add debug support for multi-instance media: ti-vpe: vpe: Add proper support single and multi-plane buffer Harinarayan Bhatta (2): media: ti-vpe: Increasing max buffer height and width media: ti-vpe: Free vpdma buffers in vpe_release Nikhil Devshatwar (16): media: ti-vpe: vpe: Do not perform job transaction atomically media: ti-vpe: Add support for SEQ_TB buffers media: ti-vpe: vpe: Return NULL for invalid buffer type media: ti-vpe: vpdma: Add support for setting max width height media: ti-vpe: vpdma: Add abort channel desc and cleanup APIs media: ti-vpe: vpdma: Make list post atomic operation media: ti-vpe: vpdma: Clear IRQs for individual lists media: ti-vpe: vpe: configure line mode separately media: ti-vpe: vpe: Setup srcdst parameters in start_streaming media: ti-vpe: vpe: Post next descriptor only for list complete IRQ media: ti-vpe: vpe: Add RGB565 and RGB5551 support media: ti-vpe: vpdma: allocate and maintain hwlist media: ti-vpe: sc: Fix incorrect optimization media: ti-vpe: vpdma: Fix race condition for firmware loading media: ti-vpe: vpdma: Use bidirectional cached buffers media: ti-vpe: vpe: Fix line stride for output motion vector drivers/media/platform/Kconfig | 14 + drivers/media/platform/ti-vpe/Makefile | 10 +- drivers/media/platform/ti-vpe/csc.c| 18 +- drivers/media/platform/ti-vpe/csc.h| 2 +- drivers/media/platform/ti-vpe/sc.c | 28 +- drivers/media/platform/ti-vpe/sc.h | 11 +- drivers/media/platform/ti-vpe/vpdma.c | 349 +++--- drivers/media/platform/ti-vpe/vpdma.h | 85 +- drivers/media/platform/ti-vpe/vpdma_priv.h | 130 - drivers/media/platform/ti-vpe/vpe.c| 450 - 10 files changed, 891 insertions(+), 206 deletions(-) -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [16/22] ARM: dts: nitrogen6x: Add dtsi for BD_HDMI_MIPI HDMI to MIPI CSI-2 receiver board
Hi Philipp, All, On Fri, Oct 07, 2016 at 06:01:01PM +0200, Philipp Zabel wrote: > Add device tree nodes for the BD_HDMI_MIPI HDMI to MIPI CSI-2 receiver > board with a TC358743 connected to the Nitrogen6X MIPI CSI-2 input > connector. I've tested this series on my Nitrogen6x + BD_HDMI_MIPI daughter board and have a few questions. First, why is the tc358743 node in a separate dtsi file? Is this in order to avoid a failed probe during bootup if the daughter board is not present? Is this what should be done for every capture device that targets this platform (like the OV5640 or OV5642)? Can you provide some details on your testing procedure? In my case I've reached a point where I get the same 'media-ctl --print-dot' output as the one from your cover letter but I can't seem to set the EDID nor to have a gstreamer pipeline (to fakesink). All the EDID v4l2-ctl commands return "Inappropriate ioctl for device". Do not hesitate to CC me to Boundary Devices related patches so I can test them and give some feedback. Regards, Gary -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v10 0/3] Secure Memory Allocation Framework
On Fri, Oct 07, 2016 at 10:42:17AM -0400, Rob Clark wrote: > probably should keep the discussion on github (USAGE.md was updated a > bit more and merged into https://github.com/cubanismo/allocator so > look there for the latest).. > > but briefly: > > 1) my expectation is if the user is implementing some use-case, it > knows what devices and APIs are involved, otherwise it wouldn't be > able to pass a buffer to that device/API.. As I described at Linaro Connect late-connected devices could cause new constrains to appear. I.e. some (additonal) HDMI connection or WiFi Display etc. Including all the might-happen devices might lead to unoptimal buffers just to be able to handle some rarely-happen events. I guess the easy resolve here is for the user to do a reallocation with the new constraints added and replace the buffer(s) in question, but with a slight lag in enabling the new device. John -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/26] Don't use stack for DMA transers on dvb-usb drivers
Antti makes a very good point. If we consider a situation where we are streaming data while concurrently checking frontend status and polling for IR codes, some locking will certainly be required in all of these drivers. -Mike Krufky On Mon, Oct 10, 2016 at 7:24 AM, Antti Palosaari wrote: > Hello > If you use usb buffers from the state you will need add lock in order to > protect concurrent access to buffer. There may have multiple concurrent > operations from rc-polling/demux/frontend. Lets say you are reading ber and > it sets data to buffer (state), then context switch to remote controller > polling => buffer in state is overwritten, then context is changed back to > ber reading and now there is bad data. > > regards > Antti > > > > On 10/07/2016 08:24 PM, Mauro Carvalho Chehab wrote: >> >> Sending URB control messages from stack was never supported. Yet, on x86, >> the stack was usually at a memory region that allows DMA transfer. >> >> So, several drivers got it wrong. On Kernel 4.9, if VMAP_STACK=y, none of >> those drivers will work, as the stack won't be on a DMA-able area anymore. >> >> So, fix the dvb-usb drivers that requre it. >> >> Please notice that, while all those patches compile, I don't have devices >> using those drivers to test. So, I really appreciate if people with >> devices >> using those drivers could test and report if they don't break anything. >> >> Thanks! >> Mauro >> >> Mauro Carvalho Chehab (26): >> af9005: don't do DMA on stack >> cinergyT2-core: don't do DMA on stack >> cinergyT2-core:: handle error code on RC query >> cinergyT2-fe: cache stats at cinergyt2_fe_read_status() >> cinergyT2-fe: don't do DMA on stack >> cxusb: don't do DMA on stack >> dib0700: be sure that dib0700_ctrl_rd() users can do DMA >> dib0700_core: don't use stack on I2C reads >> dibusb: don't do DMA on stack >> dibusb: handle error code on RC query >> digitv: don't do DMA on stack >> dtt200u-fe: don't do DMA on stack >> dtt200u-fe: handle errors on USB control messages >> dtt200u: don't do DMA on stack >> dtt200u: handle USB control message errors >> dtv5100: : don't do DMA on stack >> gp8psk: don't do DMA on stack >> gp8psk: don't go past the buffer size >> nova-t-usb2: don't do DMA on stack >> pctv452e: don't do DMA on stack >> pctv452e: don't call BUG_ON() on non-fatal error >> technisat-usb2: use DMA buffers for I2C transfers >> dvb-usb: warn if return value for USB read/write routines is not >> checked >> nova-t-usb2: handle error code on RC query >> dw2102: return error if su3000_power_ctrl() fails >> digitv: handle error code on RC query >> >> drivers/media/usb/dvb-usb/af9005.c | 211 >> +++- >> drivers/media/usb/dvb-usb/cinergyT2-core.c | 52 --- >> drivers/media/usb/dvb-usb/cinergyT2-fe.c| 91 >> drivers/media/usb/dvb-usb/cxusb.c | 20 +-- >> drivers/media/usb/dvb-usb/cxusb.h | 5 + >> drivers/media/usb/dvb-usb/dib0700_core.c| 31 +++- >> drivers/media/usb/dvb-usb/dib0700_devices.c | 25 ++-- >> drivers/media/usb/dvb-usb/dibusb-common.c | 112 +++ >> drivers/media/usb/dvb-usb/dibusb.h | 5 + >> drivers/media/usb/dvb-usb/digitv.c | 26 ++-- >> drivers/media/usb/dvb-usb/digitv.h | 3 + >> drivers/media/usb/dvb-usb/dtt200u-fe.c | 90 >> drivers/media/usb/dvb-usb/dtt200u.c | 80 +++ >> drivers/media/usb/dvb-usb/dtv5100.c | 10 +- >> drivers/media/usb/dvb-usb/dvb-usb.h | 6 +- >> drivers/media/usb/dvb-usb/dw2102.c | 2 +- >> drivers/media/usb/dvb-usb/gp8psk.c | 25 +++- >> drivers/media/usb/dvb-usb/nova-t-usb2.c | 25 +++- >> drivers/media/usb/dvb-usb/pctv452e.c| 118 >> drivers/media/usb/dvb-usb/technisat-usb2.c | 16 ++- >> 20 files changed, 577 insertions(+), 376 deletions(-) >> > > -- > http://palosaari.fi/ > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/26] Don't use stack for DMA transers on dvb-usb drivers
Hello If you use usb buffers from the state you will need add lock in order to protect concurrent access to buffer. There may have multiple concurrent operations from rc-polling/demux/frontend. Lets say you are reading ber and it sets data to buffer (state), then context switch to remote controller polling => buffer in state is overwritten, then context is changed back to ber reading and now there is bad data. regards Antti On 10/07/2016 08:24 PM, Mauro Carvalho Chehab wrote: Sending URB control messages from stack was never supported. Yet, on x86, the stack was usually at a memory region that allows DMA transfer. So, several drivers got it wrong. On Kernel 4.9, if VMAP_STACK=y, none of those drivers will work, as the stack won't be on a DMA-able area anymore. So, fix the dvb-usb drivers that requre it. Please notice that, while all those patches compile, I don't have devices using those drivers to test. So, I really appreciate if people with devices using those drivers could test and report if they don't break anything. Thanks! Mauro Mauro Carvalho Chehab (26): af9005: don't do DMA on stack cinergyT2-core: don't do DMA on stack cinergyT2-core:: handle error code on RC query cinergyT2-fe: cache stats at cinergyt2_fe_read_status() cinergyT2-fe: don't do DMA on stack cxusb: don't do DMA on stack dib0700: be sure that dib0700_ctrl_rd() users can do DMA dib0700_core: don't use stack on I2C reads dibusb: don't do DMA on stack dibusb: handle error code on RC query digitv: don't do DMA on stack dtt200u-fe: don't do DMA on stack dtt200u-fe: handle errors on USB control messages dtt200u: don't do DMA on stack dtt200u: handle USB control message errors dtv5100: : don't do DMA on stack gp8psk: don't do DMA on stack gp8psk: don't go past the buffer size nova-t-usb2: don't do DMA on stack pctv452e: don't do DMA on stack pctv452e: don't call BUG_ON() on non-fatal error technisat-usb2: use DMA buffers for I2C transfers dvb-usb: warn if return value for USB read/write routines is not checked nova-t-usb2: handle error code on RC query dw2102: return error if su3000_power_ctrl() fails digitv: handle error code on RC query drivers/media/usb/dvb-usb/af9005.c | 211 +++- drivers/media/usb/dvb-usb/cinergyT2-core.c | 52 --- drivers/media/usb/dvb-usb/cinergyT2-fe.c| 91 drivers/media/usb/dvb-usb/cxusb.c | 20 +-- drivers/media/usb/dvb-usb/cxusb.h | 5 + drivers/media/usb/dvb-usb/dib0700_core.c| 31 +++- drivers/media/usb/dvb-usb/dib0700_devices.c | 25 ++-- drivers/media/usb/dvb-usb/dibusb-common.c | 112 +++ drivers/media/usb/dvb-usb/dibusb.h | 5 + drivers/media/usb/dvb-usb/digitv.c | 26 ++-- drivers/media/usb/dvb-usb/digitv.h | 3 + drivers/media/usb/dvb-usb/dtt200u-fe.c | 90 drivers/media/usb/dvb-usb/dtt200u.c | 80 +++ drivers/media/usb/dvb-usb/dtv5100.c | 10 +- drivers/media/usb/dvb-usb/dvb-usb.h | 6 +- drivers/media/usb/dvb-usb/dw2102.c | 2 +- drivers/media/usb/dvb-usb/gp8psk.c | 25 +++- drivers/media/usb/dvb-usb/nova-t-usb2.c | 25 +++- drivers/media/usb/dvb-usb/pctv452e.c| 118 drivers/media/usb/dvb-usb/technisat-usb2.c | 16 ++- 20 files changed, 577 insertions(+), 376 deletions(-) -- http://palosaari.fi/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RFC] [media] dib0700: remove redundant else
On Mon, 10 Oct 2016 06:30:35 -0300
Mauro Carvalho Chehab wrote:
> > drivers/media/usb/dvb-usb/dib0700_devices.c | 10 +++---
> > 1 file changed, 3 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/media/usb/dvb-usb/dib0700_devices.c
> > b/drivers/media/usb/dvb-usb/dib0700_devices.c index
> > 0857b56..3cd8566 100644 ---
> > a/drivers/media/usb/dvb-usb/dib0700_devices.c +++
> > b/drivers/media/usb/dvb-usb/dib0700_devices.c @@ -1736,13 +1736,9
> > @@ static int dib809x_tuner_attach(struct dvb_usb_adapter *adap)
> > struct dib0700_adapter_state *st = adap->priv; struct i2c_adapter
> > *tun_i2c = st->dib8000_ops.get_i2c_master(adap->fe_adap[0].fe,
> > DIBX000_I2C_INTERFACE_TUNER, 1);
> > - if (adap->id == 0) {
> > - if (dvb_attach(dib0090_register,
> > adap->fe_adap[0].fe, tun_i2c, &dib809x_dib0090_config) == NULL)
> > - return -ENODEV;
> > - } else {
> > - if (dvb_attach(dib0090_register,
> > adap->fe_adap[0].fe, tun_i2c, &dib809x_dib0090_config) == NULL)
> > - return -ENODEV;
> > - }
> > + if (dvb_attach(dib0090_register, adap->fe_adap[0].fe,
> > + tun_i2c, &dib809x_dib0090_config) == NULL)
> > + return -ENODEV;
>
>
> I suspect that this patch is wrong. It should be, instead, using
> fe_adap[1] on the else.
>
> Patrick,
>
> Could you please take a look?
I think you're right, it should be fe_adap[1], but I have lost track of
these devices and don't know the correct answer.
However, this code was introduced by
commit 91be260faaf8561dc51e72033c346f6ab28d40d8
Author: Nicolas Sugino
Date: Thu Nov 26 19:00:28 2015 -0200
[media] dib8000: Add support for Mygica/Geniatech S2870
MyGica/Geniatech S2870 is very similar to the S870 but with dual tuner. The
card is recognised as Geniatech STK8096-PVR.
[mche...@osg.samsung.com: Fix some checkpatch.pl issues]
Signed-off-by: Nicolas Sugino
Signed-off-by: Mauro Carvalho Chehab
diff --git a/drivers/media/usb/dvb-usb/dib0700_devices.c
b/drivers/media/usb/dvb-usb/dib0700_devices.c
index 7ed4964..ea0391e 100644
--- a/drivers/media/usb/dvb-usb/dib0700_devices.c
+++ b/drivers/media/usb/dvb-usb/dib0700_devices.c
@@ -1736,8 +1736,13 @@ static int dib809x_tuner_attach(struct dvb_usb_adapter
*adap)
struct dib0700_adapter_state *st = adap->priv;
struct i2c_adapter *tun_i2c =
st->dib8000_ops.get_i2c_master(adap->fe_adap[0].fe,
DIBX000_I2C_INTERFACE_TUNER, 1);
- if (dvb_attach(dib0090_register, adap->fe_adap[0].fe, tun_i2c,
&dib809x_dib0090_config) == NULL)
- return -ENODEV;
+ if (adap->id == 0) {
+ if (dvb_attach(dib0090_register, adap->fe_adap[0].fe, tun_i2c,
&dib809x_dib0090_config) == NULL)
+ return -ENODEV;
+ } else {
+ if (dvb_attach(dib0090_register, adap->fe_adap[0].fe, tun_i2c,
&dib809x_dib0090_config) == NULL)
+ return -ENODEV;
+ }
st->set_param_save = adap->fe_adap[0].fe->ops.tuner_ops.set_params;
adap->fe_adap[0].fe->ops.tuner_ops.set_params =
dib8096_set_param_override;
[..]
Maybe Nicolas can help (and test).
--
Patrick.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RFC] [media] dib0700: remove redundant else
Em Sat, 8 Oct 2016 14:03:19 +0200
Nicholas Mc Guire escreveu:
> The if and else are identical and can be consolidated here.
>
> Fixes: commit 91be260faaf8 ("[media] dib8000: Add support for
> Mygica/Geniatech S2870")
>
> Signed-off-by: Nicholas Mc Guire
> ---
>
> Problem found by coccinelle script
>
> Based only on reviewing this driver it seems that the dib0090_config
> is not an array and thus this is a cut&past bug - but not having access
> to the driver I can not say. Other cases that have the
> conditioning on (adap->id == 0) e.g. dib7070p_dib0070 actually have
> a config array (dib7070p_dib0070_config[]). So the if/else here most
> likely is unnecessary.
>
> The patch is actually a partial revert of commit 91be260faaf8 ("[media]
> dib8000: Add support for Mygica/Geniatech S2870") where this if/else
> was deliberately introduced but without any specific comments.
>
> This needs a review by someone that has access to the details of the driver.
>
> Patch was compile tested with: x86_64_defconfig + CONFIG_MEDIA_SUPPORT=m,
> CONFIG_MEDIA_USB_SUPPORT=y, CONFIG_MEDIA_DIGITAL_TV_SUPPORT=y,
> CONFIG_DVB_USB=m, CONFIG_DVB_USB_V2=m, CONFIG_MEDIA_RC_SUPPORT=y,
> CONFIG_DVB_USB_DIB0700=m
>
> Patch is against 4.8.0 (localversion-next is -next-20161006)
>
> drivers/media/usb/dvb-usb/dib0700_devices.c | 10 +++---
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb/dib0700_devices.c
> b/drivers/media/usb/dvb-usb/dib0700_devices.c
> index 0857b56..3cd8566 100644
> --- a/drivers/media/usb/dvb-usb/dib0700_devices.c
> +++ b/drivers/media/usb/dvb-usb/dib0700_devices.c
> @@ -1736,13 +1736,9 @@ static int dib809x_tuner_attach(struct dvb_usb_adapter
> *adap)
> struct dib0700_adapter_state *st = adap->priv;
> struct i2c_adapter *tun_i2c =
> st->dib8000_ops.get_i2c_master(adap->fe_adap[0].fe,
> DIBX000_I2C_INTERFACE_TUNER, 1);
>
> - if (adap->id == 0) {
> - if (dvb_attach(dib0090_register, adap->fe_adap[0].fe, tun_i2c,
> &dib809x_dib0090_config) == NULL)
> - return -ENODEV;
> - } else {
> - if (dvb_attach(dib0090_register, adap->fe_adap[0].fe, tun_i2c,
> &dib809x_dib0090_config) == NULL)
> - return -ENODEV;
> - }
> + if (dvb_attach(dib0090_register, adap->fe_adap[0].fe,
> +tun_i2c, &dib809x_dib0090_config) == NULL)
> + return -ENODEV;
I suspect that this patch is wrong. It should be, instead, using
fe_adap[1] on the else.
Patrick,
Could you please take a look?
Regards,
Thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
