[PATCH] drivers: media: i2c: constify v4l2_subdev_* structures

2016-12-11 Thread Bhumika Goyal
v4l2_subdev_{core/pad/video}_ops structures are stored in the fields of the v4l2_subdev_ops structure which are of type const. Also, v4l2_subdev_ops structure is passed to a function having its argument of type const. As these structures are never modified, so declare them as const. Done using

Re: [media] bt8xx: One function call less in bttv_input_init() after error detection

2016-12-11 Thread Daniele Nicolodi
On 12/12/16 00:33, SF Markus Elfring wrote: >>> I would prefer a safer coding style for the corresponding >>> exception handling. >> >> Can you please point out what is wrong in the current code > > Is it useful to reconsider the software situation that another memory > allocation is attempted

Re: [media] bt8xx: One function call less in bttv_input_init() after error detection

2016-12-11 Thread SF Markus Elfring
>> I would prefer a safer coding style for the corresponding >> exception handling. > > Can you please point out what is wrong in the current code Is it useful to reconsider the software situation that another memory allocation is attempted when it could be determined that a previous one failed

[PATCH v4l-utils] ir-ctl: `strndupa' undefined with --disable-nls

2016-12-11 Thread Greg Whiteley
Signed-off-by: Greg Whiteley --- utils/ir-ctl/ir-ctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/utils/ir-ctl/ir-ctl.c b/utils/ir-ctl/ir-ctl.c index f19bd05..707aa1f 100644 --- a/utils/ir-ctl/ir-ctl.c +++ b/utils/ir-ctl/ir-ctl.c @@ -37,6 +37,7 @@ # include

cron job: media_tree daily build: WARNINGS

2016-12-11 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Dec 12 05:00:18 CET 2016 media-tree git hash:365fe4e0ce218dc5ad10df17b150a366b6015499 media_build

Re: [PATCH v8 2/4] vcodec: mediatek: Add Mediatek JPEG Decoder Driver

2016-12-11 Thread Ricky Liang
Hi Rick, On Wed, Nov 30, 2016 at 11:08 AM, Rick Chang wrote: > Add v4l2 driver for Mediatek JPEG Decoder > > Signed-off-by: Rick Chang > Signed-off-by: Minghsiu Tsai > +static bool

Re: [media] bt8xx: One function call less in bttv_input_init() after error detection

2016-12-11 Thread Daniele Nicolodi
On 10/12/16 15:10, SF Markus Elfring wrote: >> Despite that, you have found several instances of similar constructs: > > Yes. - Special source code search pattern can point such places out > for further considerations. This is one of the things that makes reviewing the patches you submit quire

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-11 Thread mahasler
Sorry about the broken formatting. Here's the diff once more: diff --git a/drivers/media/usb/stk1160/stk1160-ac97.c b/drivers/media/usb/stk1160/stk1160-ac97.c index 95648ac..708792b 100644 --- a/drivers/media/usb/stk1160/stk1160-ac97.c +++ b/drivers/media/usb/stk1160/stk1160-ac97.c @@ -23,11

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-11 Thread Marcel Hasler
Hello 2016-12-06 13:56 GMT+01:00 Mauro Carvalho Chehab : > Em Mon, 5 Dec 2016 22:06:59 +0100 > Marcel Hasler escreveu: > >> Hello >> >> 2016-12-05 16:38 GMT+01:00 Ezequiel Garcia : >> > On 5 December 2016 at 09:12,

[linux-next:master 7186/11555] htmldocs: Documentation/doc-guide/sphinx.rst:110: ERROR: Unknown target name: "sphinx c domain".

2016-12-11 Thread kbuild test robot
Hi Mauro, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 4a71e4389b1f8bbf02f43522c234143fd571dcb8 commit: 1dc4bbf0b268246f6202c761016735933b6f0b99 [7186/11555] docs-rst: doc-guide: split the

[PATCH] media: platform: xilinx: xilinx-tpg: constify v4l2_subdev_* structures

2016-12-11 Thread Bhumika Goyal
v4l2_subdev_{core/pad/video}_ops structures are stored in the fields of the v4l2_subdev_ops structure which are of type const. Also, v4l2_subdev_ops structure is passed to a function having its argument of type const. As these structures are never modified, so declare them as const. Done using

[PATCH] drivers: media: i2c: mt9t001: constify v4l2_subdev_* structures

2016-12-11 Thread Bhumika Goyal
v4l2_subdev_{core/pad/video}_ops structures are stored in the fields of the v4l2_subdev_ops structure which are of type const. Also, v4l2_subdev_ops structure is passed to a function having its argument of type const. As these structures are never modified, so declare them as const. Done using