cron job: media_tree daily build: ERRORS

2017-03-10 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Mar 11 05:00:20 CET 2017 media-tree git hash:700ea5e0e0dd70420a04e703ff264cc133834cba media_build

[PATCH V2] Staging: bcm2835: Fixed style of block comments

2017-03-10 Thread Derek Robson
Fixed style of block comments across whole driver Found using checkpatch Signed-off-by: Derek Robson --- Version #1 had ugly long subject name. .../media/platform/bcm2835/bcm2835-camera.c| 24 ++ drivers/staging/media/platform/bcm2835/controls.c

Re: [PATCH] libv4lconvert: by default, offer the original format to the client

2017-03-10 Thread Troy Kisky
On 3/10/2017 12:53 PM, Mauro Carvalho Chehab wrote: > The libv4lconvert part of libv4l was meant to provide a common > place to handle weird proprietary formats. With time, we also > added support to other standard formats, in order to help > V4L2 applications that are not performance sensitive to

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-10 Thread Steve Longerbeam
On 03/10/2017 03:30 PM, Pavel Machek wrote: On Fri 2017-03-10 10:37:21, Steve Longerbeam wrote: Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-10 Thread Pavel Machek
On Fri 2017-03-10 10:37:21, Steve Longerbeam wrote: > Hi Hans, > > On 03/10/2017 04:03 AM, Hans Verkuil wrote: > >On 10/03/17 05:52, Steve Longerbeam wrote: > >>Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or > >>output device has measured an interval between the reception

Re: [PATCH v5 22/39] media: Add userspace header file for i.MX

2017-03-10 Thread Pavel Machek
Hi! > diff --git a/include/uapi/media/Kbuild b/include/uapi/media/Kbuild > index aafaa5a..fa78958 100644 > --- a/include/uapi/media/Kbuild > +++ b/include/uapi/media/Kbuild > @@ -1 +1,2 @@ > # UAPI Header export list > +header-y += imx.h > diff --git a/include/uapi/media/imx.h

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-10 Thread Steve Longerbeam
On 03/10/2017 12:13 PM, Russell King - ARM Linux wrote: Version 5 gives me no v4l2 controls exposed through the video device interface. Just like with version 4, version 5 is completely useless with IMX219: imx6-mipi-csi2: LP-11 timeout, phy_state = 0x0200 ipu1_csi0: pipeline start

Re: [PATCH] v4l2-fwnode: Fix clock lane parsing

2017-03-10 Thread Sakari Ailus
On Mon, Mar 06, 2017 at 08:23:24AM +0100, Pavel Machek wrote: > Fix clock lane parsing in v4l2-fwnode. > > Signed-off-by: Pavel Machek > > diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c > b/drivers/media/v4l2-core/v4l2-fwnode.c > index dd3..44036b8 100644 > ---

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-10 Thread Sakari Ailus
Hi Mauro (and others), On Fri, Mar 10, 2017 at 12:53:42PM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 10 Mar 2017 15:20:48 +0100 > Hans Verkuil escreveu: > > > > > > As I've already mentioned, from talking about this with Mauro, it seems > > > Mauro is in agreement with

Re: [PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-03-10 Thread Fabio Estevam
On Fri, Mar 10, 2017 at 6:57 PM, Pavel Machek wrote: > And it should not depend on configuration. Hardware vendor should be > able to ship board with working device tree... We are talking about pin conflict here. Please read the commit log of this patch for details.

Re: [PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-03-10 Thread Pavel Machek
On Fri 2017-03-10 16:17:28, Fabio Estevam wrote: > On Fri, Mar 10, 2017 at 3:59 PM, Troy Kisky > wrote: > > On 3/9/2017 8:52 PM, Steve Longerbeam wrote: > >> There is a pin conflict with GPIO_6. This pin functions as a power > >> input pin to the OV5642 camera

Re: [PATCH] libv4lconvert: by default, offer the original format to the client

2017-03-10 Thread Sakari Ailus
Hi Mauro, On Fri, Mar 10, 2017 at 05:53:26PM -0300, Mauro Carvalho Chehab wrote: > The libv4lconvert part of libv4l was meant to provide a common > place to handle weird proprietary formats. With time, we also > added support to other standard formats, in order to help > V4L2 applications that

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-10 Thread Pavel Machek
Hi! > Argh! that is indeed a bug at libv4l (and maybe at gstreamer). > > I guess that the always_needs_conversion logic was meant to be used to > really odd proprietary formats, e. g: > > /* Vendor-specific formats */ > #define V4L2_PIX_FMT_CPIA1v4l2_fourcc('C', 'P', 'I', 'A') /*

[PATCH] libv4lconvert: by default, offer the original format to the client

2017-03-10 Thread Mauro Carvalho Chehab
The libv4lconvert part of libv4l was meant to provide a common place to handle weird proprietary formats. With time, we also added support to other standard formats, in order to help V4L2 applications that are not performance sensitive to support all V4L2 formats. Yet, the hole idea is to let

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-10 Thread Mauro Carvalho Chehab
Em Fri, 10 Mar 2017 15:57:09 + Russell King - ARM Linux escreveu: > On Fri, Mar 10, 2017 at 12:26:34PM -0300, Mauro Carvalho Chehab wrote: > > Hi Russell, > > > > Em Fri, 10 Mar 2017 13:07:33 + > > Russell King - ARM Linux escreveu: > >

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-10 Thread Russell King - ARM Linux
Version 5 gives me no v4l2 controls exposed through the video device interface. Just like with version 4, version 5 is completely useless with IMX219: imx6-mipi-csi2: LP-11 timeout, phy_state = 0x0200 ipu1_csi0: pipeline start failed with -110 imx6-mipi-csi2: LP-11 timeout, phy_state =

Re: [PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-03-10 Thread Fabio Estevam
On Fri, Mar 10, 2017 at 3:59 PM, Troy Kisky wrote: > On 3/9/2017 8:52 PM, Steve Longerbeam wrote: >> There is a pin conflict with GPIO_6. This pin functions as a power >> input pin to the OV5642 camera sensor, but ENET uses it as the h/w >> workaround for erratum

Re: [PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

2017-03-10 Thread Troy Kisky
On 3/9/2017 8:52 PM, Steve Longerbeam wrote: > There is a pin conflict with GPIO_6. This pin functions as a power > input pin to the OV5642 camera sensor, but ENET uses it as the h/w > workaround for erratum ERR006687, to wake-up the ARM cores on normal > RX and TX packet done events. So we need

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-10 Thread Steve Longerbeam
Hi Hans, On 03/10/2017 04:03 AM, Hans Verkuil wrote: On 10/03/17 05:52, Steve Longerbeam wrote: Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured an interval between the reception or transmit completion of two consecutive frames of video that is

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-10 Thread Russell King - ARM Linux
On Fri, Mar 10, 2017 at 03:57:09PM +, Russell King - ARM Linux wrote: > Enabling debug output in gstreamer's v4l2src plugin confirms that > the kernel's bayer format are totally hidden from gstreamer when > linked with libv4l2, but are present when it isn't linked with > libv4l2. Here's the

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-10 Thread Laura Abbott
On 03/10/2017 06:27 AM, Brian Starkey wrote: > On Fri, Mar 10, 2017 at 11:46:42AM +, Robin Murphy wrote: >> On 10/03/17 10:31, Brian Starkey wrote: >>> Hi, >>> >>> On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: >>> >>> [snip]

Re: [PATCH] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

2017-03-10 Thread Anton Sviridenko
On Thu, Mar 09, 2017 at 06:58:45PM -0300, Ismael Luceno wrote: > On 08/Mar/2017 21:59, Andrey Utkin wrote: > > Signed-off-by: Andrey Utkin > > Signed-off-by: Andrey Utkin > > > > Please welcome Anton who is now in charge of solo6x10

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-10 Thread Russell King - ARM Linux
On Fri, Mar 10, 2017 at 12:26:34PM -0300, Mauro Carvalho Chehab wrote: > Hi Russell, > > Em Fri, 10 Mar 2017 13:07:33 + > Russell King - ARM Linux escreveu: > > > The idea that the v4l libraries should intercept the format negotiation > > between the application and

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-10 Thread Mauro Carvalho Chehab
Em Fri, 10 Mar 2017 15:20:48 +0100 Hans Verkuil escreveu: > > > As I've already mentioned, from talking about this with Mauro, it seems > > Mauro is in agreement with permitting the control inheritence... I wish > > Mauro would comment for himself, as I can't quote our

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-10 Thread Mauro Carvalho Chehab
Hi Russell, Em Fri, 10 Mar 2017 13:07:33 + Russell King - ARM Linux escreveu: > The idea that the v4l libraries should intercept the format negotiation > between the application and kernel is a particularly painful one - the > default gstreamer build detects the v4l

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-10 Thread Mauro Carvalho Chehab
Em Fri, 10 Mar 2017 13:54:28 +0100 Hans Verkuil escreveu: > > Devices that have complex pipeline that do essentially require using the > > Media controller interface to configure them are out of that scope. > > > > Way too much of how the MC devices should be used is in

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-10 Thread Brian Starkey
On Fri, Mar 10, 2017 at 11:46:42AM +, Robin Murphy wrote: On 10/03/17 10:31, Brian Starkey wrote: Hi, On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: [snip] For me those patches are going in the right direction. I still

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-10 Thread Hans Verkuil
On 10/03/17 15:01, Russell King - ARM Linux wrote: > On Fri, Mar 10, 2017 at 02:22:29PM +0100, Hans Verkuil wrote: >> And nobody of the media core developers has the time to work on the docs, >> utilities and libraries you need to make this all work cleanly and reliably. > > Well, talking about

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-10 Thread Russell King - ARM Linux
On Fri, Mar 10, 2017 at 02:22:29PM +0100, Hans Verkuil wrote: > And nobody of the media core developers has the time to work on the docs, > utilities and libraries you need to make this all work cleanly and reliably. Well, talking about docs, and in connection to control inheritence, this is

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-10 Thread Rob Clark
On Fri, Mar 10, 2017 at 7:40 AM, Daniel Vetter wrote: > On Fri, Mar 10, 2017 at 10:31:13AM +, Brian Starkey wrote: >> Hi, >> >> On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: >> > On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: >> >> [snip] >> >> > > >> > >

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-10 Thread Helen Koike
Hi Hans, On 2017-03-10 10:08 AM, Hans Verkuil wrote: Hi Helen, On 11/01/17 02:30, Helen Koike wrote: > > Thank you for the review, I'll update the patch accordingly and re-submit it. > > Helen Do you know when you have a v7 ready? Thanks for your interest. I don't have the next version

Re: [RFC] omap3isp: add support for CSI1 bus

2017-03-10 Thread Pavel Machek
On Mon 2017-03-06 08:56:59, Pavel Machek wrote: > omap3isp: add rest of CSI1 support > > CSI1 needs one more bit to be set up. Do just that. > > Signed-off-by: Pavel Machek > > --- > > Hmm. Looking at that... num_data_lanes probably should be modified in > local variable, not

[PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout()

2017-03-10 Thread simran singhal
The function atomisp_set_stop_timeout on being called, simply returns back. The function hasn't been mentioned in the TODO and doesn't have FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been removed. This was done using Coccinelle. @@ identifier f; @@ void f(...) {

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-10 Thread Hans Verkuil
On 10/03/17 14:07, Russell King - ARM Linux wrote: > On Fri, Mar 10, 2017 at 01:54:28PM +0100, Hans Verkuil wrote: >> But there was always meant to be a layer (libv4l plugin) that could be >> used to setup a 'default scenario' that existing applications could use, >> but that was never enforced,

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-10 Thread Russell King - ARM Linux
On Fri, Mar 10, 2017 at 01:54:28PM +0100, Hans Verkuil wrote: > But there was always meant to be a layer (libv4l plugin) that could be > used to setup a 'default scenario' that existing applications could use, > but that was never enforced, sadly. However, there's other painful issues lurking in

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-10 Thread Hans Verkuil
Hi Helen, On 11/01/17 02:30, Helen Koike wrote: > > Thank you for the review, I'll update the patch accordingly and re-submit it. > > Helen Do you know when you have a v7 ready? We really need a vimc driver so people without hardware can actually fiddle around with the MC. See also my rant

[PATCH 0/2] staging: media: Remove parentheses from return arguments

2017-03-10 Thread simran singhal
This patch-series removes unnecessary parantheses from return arguments. simran singhal (2): staging: css2400/sh_css: Remove parentheses from return arguments staging: sh_css_firmware: Remove parentheses from return arguments .../media/atomisp/pci/atomisp2/css2400/sh_css.c | 20

[PATCH 2/2] staging: sh_css_firmware: Remove parentheses from return arguments

2017-03-10 Thread simran singhal
The sematic patch used for this is: @@ identifier i; constant c; @@ return - ( \(i\|-i\|i(...)\|c\) - ) ; Signed-off-by: simran singhal Acked-by: Julia Lawall --- drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 2 +-

[PATCH 1/2] staging: css2400/sh_css: Remove parentheses from return arguments

2017-03-10 Thread simran singhal
The sematic patch used for this is: @@ identifier i; constant c; @@ return - ( \(i\|-i\|i(...)\|c\) - ) ; Signed-off-by: simran singhal Acked-by: Julia Lawall --- .../media/atomisp/pci/atomisp2/css2400/sh_css.c | 20

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-10 Thread Hans Verkuil
On 04/03/17 14:13, Sakari Ailus wrote: > Hi Russell, > > On Fri, Mar 03, 2017 at 11:06:45PM +, Russell King - ARM Linux wrote: >> On Thu, Mar 02, 2017 at 06:02:57PM +0200, Sakari Ailus wrote: >>> Hi Steve, >>> >>> On Wed, Feb 15, 2017 at 06:19:16PM -0800, Steve Longerbeam wrote:

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-10 Thread Daniel Vetter
On Fri, Mar 10, 2017 at 10:31:13AM +, Brian Starkey wrote: > Hi, > > On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: > > On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: > > [snip] > > > > > > > For me those patches are going in the right direction. > > > > > > I still have

Re: [PATCH v5 16/39] [media] v4l2: add a new-frame before end-of-frame event

2017-03-10 Thread Hans Verkuil
On 10/03/17 05:52, Steve Longerbeam wrote: > Add a NEW_FRAME_BEFORE_EOF event to signal that a video capture or > output device has signaled a new frame is ready before a previous > frame has completed reception or transmission. This usually indicates > a DMA read/write channel is having trouble

Re: [PATCH v5 15/39] [media] v4l2: add a frame interval error event

2017-03-10 Thread Hans Verkuil
On 10/03/17 05:52, Steve Longerbeam wrote: > Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or > output device has measured an interval between the reception or transmit > completion of two consecutive frames of video that is outside the nominal > frame interval by some

Re: [PATCHv3 07/15] atmel-isi: remove dependency of the soc-camera framework

2017-03-10 Thread Sakari Ailus
Hi Hans, On Fri, Mar 10, 2017 at 12:25:54PM +0100, Hans Verkuil wrote: > Slight problem with this. If I make this change, then the of_node_put below > changes as well: > > @@ -1193,7 +1176,7 @@ static int isi_graph_init(struct atmel_isi *isi) > done: > if (ret < 0) { >

Re: [PATCH v5 22/39] media: Add userspace header file for i.MX

2017-03-10 Thread Hans Verkuil
On 10/03/17 05:53, Steve Longerbeam wrote: > This adds a header file for use by userspace programs wanting to interact > with the i.MX media driver. It defines custom v4l2 controls for the > i.MX v4l2 subdevices. > > Signed-off-by: Steve Longerbeam I would not

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-10 Thread Robin Murphy
On 10/03/17 10:31, Brian Starkey wrote: > Hi, > > On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: >> On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: > > [snip] > >>> >>> For me those patches are going in the right direction. >>> >>> I still have few questions: >>> - since

Re: [PATCH v5 17/39] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-10 Thread Hans Verkuil
On 10/03/17 05:52, Steve Longerbeam wrote: > v4l2_pipeline_inherit_controls() will add the v4l2 controls from > all subdev entities in a pipeline to a given video device. > > Signed-off-by: Steve Longerbeam > --- > drivers/media/v4l2-core/v4l2-mc.c | 48 >

[PATCH 8/8] atomisp: remove FPGA defines

2017-03-10 Thread Alan Cox
These are not relevant to an upstream kernel driver. Signed-off-by: Alan Cox --- .../host/hive_isp_css_hrt_modified.h | 16 1 file changed, 16 deletions(-) diff --git

[PATCH 6/8] atomisp: tidy firmware loading code a little

2017-03-10 Thread Alan Cox
The FWNAME define is never used so can be removed. The option to skip firmware loading isn't really Cherrytrail specific so remove this and complete the merging of the two driver versions for this file. Signed-off-by: Alan Cox ---

[PATCH 5/8] atomisp: eliminate intel_mid_pm.h

2017-03-10 Thread Alan Cox
We can do this because the only thing it is used for is identifying the platform for power management purposes. The driver only supports Baytrail and Cherrytrail and both of those always need the IPU to be power managed directly not via PCI D3 states. Signed-off-by: Alan Cox

[PATCH 7/8] atomisp: remove pdaf kernel

2017-03-10 Thread Alan Cox
This is not used on either Baytrail or Cherrytrail so can simply be deleted Signed-off-by: Alan Cox --- .../staging/media/atomisp/pci/atomisp2/Makefile|2 .../css2400/isp/kernels/pdaf/ia_css_pdaf.host.c| 84

[PATCH 3/8] atomisp: remove HIVECC

2017-03-10 Thread Alan Cox
We are only going to be building for Linux with gcc, so we can lose bits of material related to other build targets. Signed-off-by: Alan Cox --- .../css2400/hive_isp_css_common/dma_global.h | 52

[PATCH 4/8] atomisp: remove C_RUN define and code

2017-03-10 Thread Alan Cox
We are not going to be building for anything but Linux so the code bracketed by C_RUN is not used and not needed. Signed-off-by: Alan Cox --- .../css_2400_system/hrt/isp2400_mamoiada_params.h |4 -- .../pci/atomisp2/css2400/css_2400_system/hrt/var.h | 25

[PATCH 2/8] atomisp: remove unused code and unify a header

2017-03-10 Thread Alan Cox
KLOCWORK is never defined so we can remove the workarounds for this in the code. Signed-off-by: Alan Cox --- .../css2400/hive_isp_css_include/assert_support.h | 11 --- .../atomisp2/css2400/runtime/rmgr/src/rmgr_vbuf.c | 32 +--- 2 files changed,

[PATCH 1/8] atomisp: remove dead code for SSSE3

2017-03-10 Thread Alan Cox
This is another define which is never used and references a header that doesn't exist, so consider it dead. Our memcpy is pretty smart anyway. Signed-off-by: Alan Cox --- .../staging/media/atomisp/pci/atomisp2/hmm/hmm.c | 32 +--- 1 file changed, 1

Re: [PATCHv3 07/15] atmel-isi: remove dependency of the soc-camera framework

2017-03-10 Thread Hans Verkuil
On 10/03/17 11:39, Sakari Ailus wrote: > Hi Hans, > > Thanks! It's very nice to see one more driver converted to stand-alone one! > > Speaking of which --- this seems to be the second last one. The only > remaining one is sh_mobile_ceu_camera.c! > > On Mon, Mar 06, 2017 at 03:56:08PM +0100,

Re: [PATCHv3 06/15] atmel-isi: document device tree bindings

2017-03-10 Thread Sakari Ailus
Hi Hans, On Mon, Mar 06, 2017 at 03:56:07PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Document the device tree bindings for this hardware. > > Mostly copied from the atmel-isc bindings. > > Signed-off-by: Hans Verkuil > --- >

Re: [PATCHv4 12/15] ov2640: add MC support

2017-03-10 Thread Hans Verkuil
On 10/03/17 12:15, Sakari Ailus wrote: > Hi Hans, > > On Fri, Mar 10, 2017 at 11:26:11AM +0100, Hans Verkuil wrote: >> From: Hans Verkuil >> >> The MC support is needed by the em28xx driver. >> >> Signed-off-by: Hans Verkuil >> --- >>

Re: [PATCHv4 09/15] ov2640: update bindings

2017-03-10 Thread Sakari Ailus
On Fri, Mar 10, 2017 at 11:26:08AM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Update the bindings for this device based on a working DT example. > > Signed-off-by: Hans Verkuil > Acked-by: Rob Herring Acked-by: Sakari

Re: [PATCHv4 12/15] ov2640: add MC support

2017-03-10 Thread Sakari Ailus
Hi Hans, On Fri, Mar 10, 2017 at 11:26:11AM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > The MC support is needed by the em28xx driver. > > Signed-off-by: Hans Verkuil > --- > drivers/media/i2c/ov2640.c | 21 +++-- > 1

Re: [PATCHv3 07/15] atmel-isi: remove dependency of the soc-camera framework

2017-03-10 Thread Hans Verkuil
On 10/03/17 11:39, Sakari Ailus wrote: > Hi Hans, > > Thanks! It's very nice to see one more driver converted to stand-alone one! > > Speaking of which --- this seems to be the second last one. The only > remaining one is sh_mobile_ceu_camera.c! > > On Mon, Mar 06, 2017 at 03:56:08PM +0100,

Re: [PATCHv4 11/15] ov2640: use standard clk and enable it.

2017-03-10 Thread Sakari Ailus
On Fri, Mar 10, 2017 at 11:26:10AM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Convert v4l2_clk to normal clk and enable the clock. > > Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus -- Sakari Ailus

Re: [PATCHv4 10/15] ov2640: convert from soc-camera to a standard subdev sensor driver.

2017-03-10 Thread Sakari Ailus
Hi Hans, On Fri, Mar 10, 2017 at 11:26:09AM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Convert ov2640 to a standard subdev driver. The soc-camera driver no longer > uses this driver, so it can safely be converted. > > Note: the s_power op has been dropped: this

Re: [PATCHv4 00/15] atmel-isi/ov7670/ov2640: convert to standalone drivers

2017-03-10 Thread Sakari Ailus
Hi Hans, On Fri, Mar 10, 2017 at 11:25:59AM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > This patch series converts the soc-camera atmel-isi to a standalone V4L2 > driver. > > The same is done for the ov7670 and ov2640 sensor drivers: the ov7670 was > used to

Re: [PATCH v6 2/2] [media] s5p-mfc: Handle 'v4l2_pix_format:field' in try_fmt and g_fmt

2017-03-10 Thread Hans Verkuil
On 01/03/17 12:51, Thibault Saunier wrote: > It is required by the standard that the field order is set by the > driver, default to NONE in case any is provided, but we can basically > accept any value provided by the userspace as we will anyway not > be able to do any deinterlacing. > > In this

Re: [PATCHv3 13/15] em28xx: drop last soc_camera link

2017-03-10 Thread Sakari Ailus
On Mon, Mar 06, 2017 at 03:56:14PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > The em28xx driver still used the soc_camera.h header for the ov2640 > driver. Since this driver no longer uses soc_camera, that include can > be removed. > > Signed-off-by: Hans

Re: [PATCHv3 08/15] atmel-isi: move out of soc_camera to atmel

2017-03-10 Thread Sakari Ailus
On Mon, Mar 06, 2017 at 03:56:09PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Move this out of the soc_camera directory into the atmel directory > where it belongs. > > Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus

Re: [PATCHv3 05/15] ov7670: add devicetree support

2017-03-10 Thread Sakari Ailus
On Fri, Mar 10, 2017 at 10:32:41AM +0100, Hans Verkuil wrote: > On 09/03/17 21:45, Sakari Ailus wrote: > > Hi Hans, > > > > On Mon, Mar 06, 2017 at 03:56:06PM +0100, Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> Add DT support. Use it to get the reset and pwdn

Re: [PATCHv3 07/15] atmel-isi: remove dependency of the soc-camera framework

2017-03-10 Thread Sakari Ailus
Hi Hans, Thanks! It's very nice to see one more driver converted to stand-alone one! Speaking of which --- this seems to be the second last one. The only remaining one is sh_mobile_ceu_camera.c! On Mon, Mar 06, 2017 at 03:56:08PM +0100, Hans Verkuil wrote: > From: Hans Verkuil

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-10 Thread Brian Starkey
Hi, On Thu, Mar 09, 2017 at 09:38:49AM -0800, Laura Abbott wrote: On 03/09/2017 02:00 AM, Benjamin Gaignard wrote: [snip] For me those patches are going in the right direction. I still have few questions: - since alignment management has been remove from ion-core, should it be also

Re: [PATCH v6 1/2] [media] exynos-gsc: Use user configured colorspace if provided

2017-03-10 Thread Hans Verkuil
On 01/03/17 12:51, Thibault Saunier wrote: > Use colorspace provided by the user as we are only doing scaling and > color encoding conversion, we won't be able to transform the colorspace > itself and the colorspace won't mater in that operation. > > Also always use output colorspace on the

[PATCHv4 09/15] ov2640: update bindings

2017-03-10 Thread Hans Verkuil
From: Hans Verkuil Update the bindings for this device based on a working DT example. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- .../devicetree/bindings/media/i2c/ov2640.txt | 23 +- 1 file

[PATCHv4 11/15] ov2640: use standard clk and enable it.

2017-03-10 Thread Hans Verkuil
From: Hans Verkuil Convert v4l2_clk to normal clk and enable the clock. Signed-off-by: Hans Verkuil --- drivers/media/i2c/ov2640.c | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git

[PATCHv4 10/15] ov2640: convert from soc-camera to a standard subdev sensor driver.

2017-03-10 Thread Hans Verkuil
From: Hans Verkuil Convert ov2640 to a standard subdev driver. The soc-camera driver no longer uses this driver, so it can safely be converted. Note: the s_power op has been dropped: this never worked. When the last open() is closed, then the power is turned off, and

[PATCHv4 07/15] atmel-isi: remove dependency of the soc-camera framework

2017-03-10 Thread Hans Verkuil
From: Hans Verkuil This patch converts the atmel-isi driver from a soc-camera driver to a driver that is stand-alone. Signed-off-by: Hans Verkuil --- drivers/media/i2c/soc_camera/ov2640.c | 23 +-

[PATCHv4 12/15] ov2640: add MC support

2017-03-10 Thread Hans Verkuil
From: Hans Verkuil The MC support is needed by the em28xx driver. Signed-off-by: Hans Verkuil --- drivers/media/i2c/ov2640.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ov2640.c

[PATCHv4 15/15] at91-sama5d3_xplained.dts: select ov2640

2017-03-10 Thread Hans Verkuil
From: Hans Verkuil This patch replaces the ov7670 with the ov2640. This patch is not meant to be merged but is for demonstration purposes only. Signed-off-by: Hans Verkuil --- arch/arm/boot/dts/at91-sama5d3_xplained.dts | 16 1

[PATCHv4 01/15] ov7670: document device tree bindings

2017-03-10 Thread Hans Verkuil
From: Hans Verkuil Add binding documentation and add that file to the MAINTAINERS entry. Signed-off-by: Hans Verkuil --- .../devicetree/bindings/media/i2c/ov7670.txt | 43 ++ MAINTAINERS

[PATCHv4 03/15] ov7670: fix g/s_parm

2017-03-10 Thread Hans Verkuil
From: Hans Verkuil Drop unnecesary memset. Drop the unnecessary extendedmode check and set the V4L2_CAP_TIMEPERFRAME capability. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus --- drivers/media/i2c/ov7670.c | 4

[PATCHv4 04/15] ov7670: get xclk

2017-03-10 Thread Hans Verkuil
From: Hans Verkuil Get the clock for this sensor. Signed-off-by: Hans Verkuil --- drivers/media/i2c/ov7670.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov7670.c

[PATCHv4 08/15] atmel-isi: move out of soc_camera to atmel

2017-03-10 Thread Hans Verkuil
From: Hans Verkuil Move this out of the soc_camera directory into the atmel directory where it belongs. Signed-off-by: Hans Verkuil --- drivers/media/platform/Makefile | 1 + drivers/media/platform/atmel/Kconfig

[PATCHv4 05/15] ov7670: add devicetree support

2017-03-10 Thread Hans Verkuil
From: Hans Verkuil Add DT support. Use it to get the reset and pwdn pins (if there are any). Tested with one sensor requiring reset/pwdn and one sensor that doesn't have reset/pwdn pins. Signed-off-by: Hans Verkuil --- drivers/media/i2c/ov7670.c

[PATCHv4 06/15] atmel-isi: document device tree bindings

2017-03-10 Thread Hans Verkuil
From: Hans Verkuil Document the device tree bindings for this hardware. Mostly copied from the atmel-isc bindings. Signed-off-by: Hans Verkuil --- .../devicetree/bindings/media/atmel-isi.txt| 96 +- 1 file changed,

[PATCHv4 13/15] em28xx: drop last soc_camera link

2017-03-10 Thread Hans Verkuil
From: Hans Verkuil The em28xx driver still used the soc_camera.h header for the ov2640 driver. Since this driver no longer uses soc_camera, that include can be removed. Signed-off-by: Hans Verkuil --- drivers/media/usb/em28xx/em28xx-camera.c | 9

[PATCHv4 00/15] atmel-isi/ov7670/ov2640: convert to standalone drivers

2017-03-10 Thread Hans Verkuil
From: Hans Verkuil This patch series converts the soc-camera atmel-isi to a standalone V4L2 driver. The same is done for the ov7670 and ov2640 sensor drivers: the ov7670 was used to test the atmel-isi driver. The ov2640 is needed because the em28xx driver has a

[PATCHv4 14/15] sama5d3 dts: enable atmel-isi

2017-03-10 Thread Hans Verkuil
From: Hans Verkuil This illustrates the changes needed to the dts in order to hook up the ov7670. I don't plan on merging this. Signed-off-by: Hans Verkuil --- arch/arm/boot/dts/at91-sama5d3_xplained.dts | 59 ++---

[PATCHv4 02/15] ov7670: call v4l2_async_register_subdev

2017-03-10 Thread Hans Verkuil
From: Hans Verkuil Add v4l2-async support for this driver. Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus --- drivers/media/i2c/ov7670.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-)

Re: [PATCHv3 05/15] ov7670: add devicetree support

2017-03-10 Thread Hans Verkuil
On 09/03/17 21:45, Sakari Ailus wrote: > Hi Hans, > > On Mon, Mar 06, 2017 at 03:56:06PM +0100, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Add DT support. Use it to get the reset and pwdn pins (if there are any). >> Tested with one sensor requiring reset/pwdn and one

Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event

2017-03-10 Thread Russell King - ARM Linux
On Thu, Mar 09, 2017 at 06:38:18PM -0800, Steve Longerbeam wrote: > On 03/05/2017 02:41 PM, Russell King - ARM Linux wrote: > >I'm not sure that statement is entirely accurate. With the IMX219 > >camera, I _could_ (with previous iterations of the iMX capture code) > >stop it streaming, wait a

Re: [PATCH] [media] coda: fix warnings when compiling with 64 bits

2017-03-10 Thread Hans Verkuil
On 09/03/17 21:17, Mauro Carvalho Chehab wrote: > drivers/media/platform/coda/coda-common.c: In function ‘coda_alloc_aux_buf’: > ./include/linux/kern_levels.h:4:18: warning: format ‘%u’ expects argument of > type ‘unsigned int’, but argument 4 has type ‘size_t {aka long unsigned int}’ >

Re: [PATCHv3 04/15] ov7670: get xclk

2017-03-10 Thread Hans Verkuil
On 10/03/17 10:11, Sakari Ailus wrote: > Hi Hans, > > On Fri, Mar 10, 2017 at 09:55:53AM +0100, Hans Verkuil wrote: >> On 09/03/17 21:38, Sakari Ailus wrote: >>> Hi Hans, >>> >>> On Mon, Mar 06, 2017 at 03:56:05PM +0100, Hans Verkuil wrote: From: Hans Verkuil

Re: [PATCHv3 01/15] ov7670: document device tree bindings

2017-03-10 Thread Hans Verkuil
On 09/03/17 19:01, Sakari Ailus wrote: > Hi Hans, > > On Mon, Mar 06, 2017 at 03:56:02PM +0100, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Add binding documentation and add that file to the MAINTAINERS entry. >> >> Signed-off-by: Hans Verkuil

Re: [PATCHv3 04/15] ov7670: get xclk

2017-03-10 Thread Sakari Ailus
Hi Hans, On Fri, Mar 10, 2017 at 09:55:53AM +0100, Hans Verkuil wrote: > On 09/03/17 21:38, Sakari Ailus wrote: > > Hi Hans, > > > > On Mon, Mar 06, 2017 at 03:56:05PM +0100, Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> Get the clock for this sensor. > >> > >>

Re: [PATCHv3 04/15] ov7670: get xclk

2017-03-10 Thread Hans Verkuil
On 09/03/17 21:38, Sakari Ailus wrote: > Hi Hans, > > On Mon, Mar 06, 2017 at 03:56:05PM +0100, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Get the clock for this sensor. >> >> Signed-off-by: Hans Verkuil >> --- >> drivers/media/i2c/ov7670.c

Re: [RFC PATCH 08/12] cma: Store a name in the cma structure

2017-03-10 Thread Sumit Semwal
Hi Laura, Thanks for the patch. On 3 March 2017 at 03:14, Laura Abbott wrote: > > Frameworks that may want to enumerate CMA heaps (e.g. Ion) will find it > useful to have an explicit name attached to each region. Store the name > in each CMA structure. > > Signed-off-by:

Re: [PATCH 1/3] [media] platform: compile VIDEO_CODA with COMPILE_TEST

2017-03-10 Thread Hans Verkuil
On 03/09/2017 09:08 PM, Mauro Carvalho Chehab wrote: > Currently, IMX_VDOA and VIDEO_CODA only builds on ARCH_MXC. > > That prevented me to build-test the driver, causing a bad patch > to be applied, and to see other warnings on this driver. Huh, must be the time of year. I just made a similar