cron job: media_tree daily build: ERRORS

2017-03-24 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Mar 25 05:00:17 CET 2017 media-tree git hash:c3d4fb0fb41f4b5eafeee51173c14e50be12f839 media_build

[PATCH v3] staging: media: davinci_vpfe: Replace a bit shift.

2017-03-24 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- changes in v3 - change the subject. - remove extra parenthesis.

[PATCH] Staging: atomisp - octal permissions, style fix

2017-03-24 Thread Derek Robson
Changed permissions to octal style Found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_drvfs.c | 9 +++-- drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c | 8 2 files changed, 7 insertions(+), 10

Re: [PATCH v6] [media] vimc: Virtual Media Controller core, capture and sensor

2017-03-24 Thread Helen Koike
Hi Sakari, Thanks for your review, I have some questions below: On 2017-01-25 11:03 AM, Sakari Ailus wrote: Hi Helen, My apologies for the long review time! Please see my comments below. On Sun, Sep 04, 2016 at 05:02:18PM -0300, Helen Koike wrote: From: Helen Fornazier

Re: [PATCH 2/2] em28xx: simplify ID-reading from Micron sensors

2017-03-24 Thread Mauro Carvalho Chehab
Em Thu, 23 Mar 2017 19:03:20 +0100 Frank Schäfer escreveu: > Am 23.03.2017 um 13:56 schrieb Mauro Carvalho Chehab: > > Em Thu, 23 Mar 2017 13:01:32 +0100 > > Frank Schäfer escreveu: > > > >> Am 22.03.2017 um 15:46 schrieb Mauro

Re: [Outreachy kernel] [PATCH v2] staging: media: davinci_vpfe:Replace a bit shift.

2017-03-24 Thread Julia Lawall
There should be a spac after every colon in the subject. Please pay attention to these small details, so you don't have to send the same patch over and over. julia On Fri, 24 Mar 2017, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with

[no subject]

2017-03-24 Thread Scott Tisdale
Greetings Linux http://trevorroth.com/calcloan.php?sets=mz25y2rpda7g4wsb Scott

[PATCH v2 12/12] [media] ddbridge: support STV0367-based cards and modules

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller This adds detection and activation for STV0367-based tuner hardware (namely CineCTv6 bridge cards and older DuoFlex CT addon modules). Utilises the extended stv0367 demod driver. TDA18212 i2c_client/regmap-api code was originally implemented by Antti

[PATCH v2 00/12] stv0367/ddbridge: support CTv6/FlexCT hardware

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller These patches enhance the functionality of dvb-frontends/stv0367 to work with Digital Devices hardware driven by the ST STV0367 demodulator chip and adds probe & attach bits to ddbridge to make use of them, effectively enabling full support for CineCTv6

[PATCH v2 04/12] [media] dvb-frontends/stv0367: move out tables, support multiple tab variants

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller Move the *ter and *cab st_register tables into a separate header file and additionally organize them via a multidimensional array, allowing to add more tables with differing init values, and also prepare for a base init table which should contain general

[PATCH v2 06/12] [media] dvb-frontends/stv0367: make full reinit on set_frontend() optional

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller Every time dvb_frontend_ops.set_frontend() is called, an almost full reinit of the demodulator will be performed. While this might cause a slight delay when switching channels due to all involved tables being rewritten, it can even be dangerous in

[PATCH v2 10/12] [media] dvb-frontends/stv0367: add defaults for use w/DD-branded devices

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller Digital Devices uses defaults tables in their stv0367dd demod driver variant which differ in a few registers, at least enough that no stable operation can be provided with the tables already present in the driver (init succeeds and DVB reception works

[PATCH v2 05/12] [media] dvb-frontends/stv0367: make PLLSETUP a function, add 58MHz IC speed

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller This moves the PLL SETUP code from stv0367ter_init() into a dedicated function, and also make it possible to configure 58Mhz IC speed at 27MHz Xtal (used on STV0367-based DDB cards/modules in QAM mode). Signed-off-by: Daniel Scheller

[PATCH v2 11/12] [media] dvb-frontends/stv0367: add Digital Devices compatibility

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller This - in conjunction with the previous changes - makes it possible to use the STV0367 DVB-C/T demodulator driver with Digital Devices hardware having this demodulator soldered on them (namely CineCTv6 bridges and some earlier DuoFlex CT addon modules).

[PATCH v2 03/12] [media] dvb-frontends/stv0367: refactor defaults table handling

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller Change defaults table writing so tables can be of dynamic length without having to keep track of their lengths by adding and evaluating an end marker (reg 0x), also move table writing to a dedicated function to remove code duplication. Additionally

[PATCH v2 01/12] [media] dvb-frontends/stv0367: add flag to make i2c_gatectrl optional

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller Some hardware and bridges (namely ddbridge) require that tuner access is limited to one concurrent access and wrap i2c gate control with a mutex_lock when attaching frontends. According to vendor information, this is required as concurrent tuner

[PATCH v2 07/12] [media] dvb-frontends/stv0367: support reading if_khz from tuner config

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller Currently, if_khz is set and provided using the configuration var in struct stv0367_config. However, in some constellations, the value might be different for differing channel bandwidths or even -T and -C operation. When e.g. used in conjunction with

[PATCH v2 08/12] [media] dvb-frontends/stv0367: selectable QAM FEC Lock status register

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller In some configurations (due to different PIN config, wiring or so), the QAM FECLock might be signalled using a different register than F367CAB_QAMFEC_LOCK (e.g. F367CAB_DESCR_SYNCSTATE on Digital Devices hw), so make that register selectable.

[PATCH v2 09/12] [media] dvb-frontends/stv0367: fix symbol rate conditions in cab_SetQamSize()

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller The values used for comparing symbol rates and the resulting conditional reg writes seem wrong (rates multiplied by ten), so fix those values. While this doesn't seem to influence operation, it should be fixed anyway. Signed-off-by: Daniel Scheller

[PATCH v2 02/12] [media] dvb-frontends/stv0367: print CPAMP status only if stv_debug is enabled

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller The CPAMP log lines generated in stv0367_ter_check_cpamp() are printed everytime tuning succeeds or fails, quite cluttering the normal kernel log. Use dprintk() instead of printk(KERN_ERR...) so that if the information is needed, it'll be printed when

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-24 Thread Nicolas Dufresne
Le vendredi 24 mars 2017 à 15:41 +0100, Hans Verkuil a écrit : > > +static const struct venus_format vdec_formats[] = { > > + { > > + .pixfmt = V4L2_PIX_FMT_NV12, > > + .num_planes = 1, > > + .type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE, > > Just curious: is

Re: [PATCH] staging: media: lirc: coding style fix use octal instead of symbolic permission

2017-03-24 Thread Sean Young
On Sun, Feb 12, 2017 at 03:39:42PM +0900, Chetan Sethi wrote: > This is a patch to the lirc_sir.c file that fixes coding style warning > found by checkpatch.pl > > Signed-off-by: Chetan Sethi Another patch was merged which already fixed this, I'm sorry. Sean > --- >

[PATCH 2/8] [media] staging: st-cec: Use cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Use helper function to get driver private data from CEC adapter. Signed-off-by: Jose Abreu Cc: Benjamin Gaignard --- drivers/staging/media/st-cec/stih-cec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 0/8] Add cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Hi, This series introduces a new helper function called cec_get_drvdata() which returns the adapter private data and can be used by drivers that use CEC. Best regards, Jose Miguel Abreu Jose Abreu (8): [media] cec: Add cec_get_drvdata() [media] staging: st-cec: Use cec_get_drvdata()

[PATCH 5/8] [media] i2c: adv7604: Use cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Use helper function to get driver private data from CEC adapter. Signed-off-by: Jose Abreu Cc: Hans Verkuil --- drivers/media/i2c/adv7604.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/adv7604.c

[PATCH 4/8] [media] i2c: adv7511: Use cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Use helper function to get driver private data from CEC adapter. Signed-off-by: Jose Abreu Cc: Hans Verkuil --- drivers/media/i2c/adv7511.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/adv7511.c

[PATCH 3/8] [media] staging: s5p-cec: Use cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Use helper function to get driver private data from CEC adapter. Signed-off-by: Jose Abreu Cc: Kamil Debski --- drivers/staging/media/s5p-cec/s5p_cec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 6/8] [media] i2c: adv7842: Use cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Use helper function to get driver private data from CEC adapter. Signed-off-by: Jose Abreu Cc: Hans Verkuil --- drivers/media/i2c/adv7842.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/adv7842.c

[PATCH 7/8] [media] usb: pulse8-cec: Use cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Use helper function to get driver private data from CEC adapter. Signed-off-by: Jose Abreu Cc: Hans Verkuil --- drivers/media/usb/pulse8-cec/pulse8-cec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 8/8] [media] platform: vivid: Use cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Use helper function to get driver private data from CEC adapter. Signed-off-by: Jose Abreu Cc: Hans Verkuil --- drivers/media/platform/vivid/vivid-cec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 1/8] [media] cec: Add cec_get_drvdata()

2017-03-24 Thread Jose Abreu
Add a helper function to get driver private data from CEC adapter. This helps the readability a little bit and allows to change the 'priv' field name to something else without needing to touch all drivers. Signed-off-by: Jose Abreu Cc: Hans Verkuil

[PATCH v2] staging: media: omap4iss: Replace a bit shift by a use of BIT.

2017-03-24 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- changes in v2 -Remove unnecessary parenthesis drivers/staging/media/omap4iss/iss_csi2.c| 2 +-

[PATCH v2] staging: media: davinci_vpfe:Replace a bit shift.

2017-03-24 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- changes in v2 -Remove unnecessary parenthesis. drivers/staging/media/davinci_vpfe/dm365_ipipe.c |

[PATCH v2] staging: media: atomisp:Replace a bit shift.

2017-03-24 Thread Arushi Singhal
This patch replaces bit shifting on 1 with the BIT(x) macro. This was done with coccinelle: @@ constant c; @@ -1 << c +BIT(c) Signed-off-by: Arushi Singhal --- changes in v2 -remove the unnecessary parenthesis.

Re: [PATCH v7 9/9] media: venus: enable building of Venus video driver

2017-03-24 Thread Stanimir Varbanov
Thanks for the comments! On 03/24/2017 04:49 PM, Hans Verkuil wrote: > On 03/13/17 17:37, Stanimir Varbanov wrote: >> This adds Venus driver Makefile and changes v4l2 platform >> Makefile/Kconfig in order to enable building of the driver. >> >> Signed-off-by: Stanimir Varbanov

Re: [PATCH v7 9/9] media: venus: enable building of Venus video driver

2017-03-24 Thread Hans Verkuil
On 03/13/17 17:37, Stanimir Varbanov wrote: > This adds Venus driver Makefile and changes v4l2 platform > Makefile/Kconfig in order to enable building of the driver. > > Signed-off-by: Stanimir Varbanov > --- > drivers/media/platform/Kconfig | 14

Re: [PATCH v7 5/9] media: venus: vdec: add video decoder files

2017-03-24 Thread Hans Verkuil
Some comments and questions below: On 03/13/17 17:37, Stanimir Varbanov wrote: > This consists of video decoder implementation plus decoder > controls. > > Signed-off-by: Stanimir Varbanov > --- > drivers/media/platform/qcom/venus/vdec.c | 1091 >

Re: [PATCH v7 4/9] media: venus: adding core part and helper functions

2017-03-24 Thread Hans Verkuil
Some review comments below: On 03/13/17 17:37, Stanimir Varbanov wrote: > * core.c has implemented the platform dirver methods, file dirver -> driver > operations and v4l2 registration. > > * helpers.c has implemented common helper functions for: >- buffer management > >- vb2_ops

[PATCH] [media] ivtv: use for_each_sg

2017-03-24 Thread Geliang Tang
Use for_each_sg() instead of open-coding it. Signed-off-by: Geliang Tang --- drivers/media/pci/ivtv/ivtv-udma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/ivtv/ivtv-udma.c b/drivers/media/pci/ivtv/ivtv-udma.c index

Re: [PATCH v7 0/9] Qualcomm video decoder/encoder driver

2017-03-24 Thread Hans Verkuil
On 03/24/17 15:06, Hans Verkuil wrote: > On 03/13/17 17:37, Stanimir Varbanov wrote: >> Hi all, >> >> Here is seventh version of the patch-set - no functional changes in >> v4l2 APIs. >> >> The changes since v6 are. >> * changes in DT binding document - moved memory-region DT property >> in

Re: [PATCH v7 0/9] Qualcomm video decoder/encoder driver

2017-03-24 Thread Hans Verkuil
On 03/13/17 17:37, Stanimir Varbanov wrote: > Hi all, > > Here is seventh version of the patch-set - no functional changes in > v4l2 APIs. > > The changes since v6 are. > * changes in DT binding document - moved memory-region DT property > in video-codec node - see 2/9. > * improved

Re: [PATCH] staging: media: atomisp: remove ifdef around HMM_BO_ION

2017-03-24 Thread Greg Kroah-Hartman
On Fri, Mar 24, 2017 at 02:20:24PM +0100, Arnd Bergmann wrote: > The revert reintroduced a build failure without CONFIG_ION: > > media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: error: excess elements in array > initializer [-Werror] > media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: note: (near

[PATCH] staging: media: atomisp: remove ifdef around HMM_BO_ION

2017-03-24 Thread Arnd Bergmann
The revert reintroduced a build failure without CONFIG_ION: media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: error: excess elements in array initializer [-Werror] media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: note: (near initialization for 'hmm_bo_type_strings') We should really be able to build in any

Re: [PATCH 0/3] Handling of reduced FPS in V4L2

2017-03-24 Thread Hans Verkuil
On 03/24/17 13:21, Jose Abreu wrote: > Hi Hans, > > > On 24-03-2017 12:12, Hans Verkuil wrote: >> On 03/24/17 12:52, Jose Abreu wrote: >>> Hi Hans, >>> >>> > Can you please review this series, when possible? And if you > could test it on cobalt it would be great :) Hopefully next

Re: [PATCH 0/3] Handling of reduced FPS in V4L2

2017-03-24 Thread Jose Abreu
Hi Hans, On 24-03-2017 12:12, Hans Verkuil wrote: > On 03/24/17 12:52, Jose Abreu wrote: >> Hi Hans, >> >> Can you please review this series, when possible? And if you could test it on cobalt it would be great :) >>> Hopefully next week. >> Thanks :) >> >>> Did you have some

Re: [PATCH 0/3] Handling of reduced FPS in V4L2

2017-03-24 Thread Hans Verkuil
On 03/24/17 12:52, Jose Abreu wrote: > Hi Hans, > > >>> Can you please review this series, when possible? And if you >>> could test it on cobalt it would be great :) >> Hopefully next week. > > Thanks :) > >> Did you have some real-world numbers w.r.t. measured >> pixelclock frequencies and

Re: [PATCH 0/3] Handling of reduced FPS in V4L2

2017-03-24 Thread Jose Abreu
Hi Hans, >> Can you please review this series, when possible? And if you >> could test it on cobalt it would be great :) > Hopefully next week. Thanks :) > Did you have some real-world numbers w.r.t. measured > pixelclock frequencies and 60 vs 59.94 Hz and 24 vs 23.976 Hz? I did make some

Re: [PATCH 0/3] Handling of reduced FPS in V4L2

2017-03-24 Thread Hans Verkuil
On 03/24/17 12:03, Jose Abreu wrote: > Hi Hans, > > > On 21-03-2017 11:49, Jose Abreu wrote: >> Hi all, >> >> This is a follow up patch from this discussion [1]. It should be >> seen more as a starting point to introduce better handling of >> time per frame in v4l2. Quoting Hans Verkuil from

Re: [PATCH 0/3] Handling of reduced FPS in V4L2

2017-03-24 Thread Jose Abreu
Hi Hans, On 21-03-2017 11:49, Jose Abreu wrote: > Hi all, > > This is a follow up patch from this discussion [1]. It should be > seen more as a starting point to introduce better handling of > time per frame in v4l2. Quoting Hans Verkuil from [1]: > > 1) "Add a flag

[GIT PULL for v4.11-rc4] media fixes

2017-03-24 Thread Mauro Carvalho Chehab
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v4.11-3 for a series of fixes: - dvb-usb-firmware: don't do DMA on stack - coda/imx-vdoa: platform_driver should not be const - bdisp: Clean up file handle in open() error path

Re: JVC camera and Hauppauge PVR-150 framegrabber.

2017-03-24 Thread Mauro Carvalho Chehab
Em Thu, 23 Mar 2017 17:04:21 -0700 pe...@easthope.ca escreveu: > With a manual setting of the device path and ID, the V4L2 Test Bench > produced this image from a JVC TK-1070U camera on a microscope. > http://easthope.ca/JVCtoPVR150screen.jpg > > Setting the device in the Test Bench each time

Re: [PATCH] drivers/staging/media: atomisp: Removing redundant information from dev_err

2017-03-24 Thread Dan Carpenter
On Fri, Mar 24, 2017 at 11:18:33AM +0530, Pushkar Jambhlekar wrote: > Removing hardcoded function name as code is already using __func__ > > Signed-off-by: Pushkar Jambhlekar > --- > drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 2 +- > 1 file changed, 1