Re: [PATCH v2] dw9714: Initial driver for dw9714 VCM

2017-05-10 Thread Tomasz Figa
Hi Raj, On Thu, May 11, 2017 at 12:12 PM, Mani, Rajmohan wrote: > Hi Tomasz, > Thanks for the reviews. Please see comments inline. > >> -Original Message- >> From: Tomasz Figa [mailto:tf...@chromium.org] >> Sent: Tuesday, May 09, 2017 4:44 PM >> To: Mani,

[PATCH v4] dw9714: Initial driver for dw9714 VCM

2017-05-10 Thread Rajmohan Mani
DW9714 is a 10 bit DAC, designed for linear control of voice coil motor. This driver creates a V4L2 subdevice and provides control to set the desired focus. Signed-off-by: Rajmohan Mani --- Changes in v4: - Addressed review comments from Tomasz Changes in v3:

cron job: media_tree daily build: WARNINGS

2017-05-10 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu May 11 05:00:34 CEST 2017 media-tree git hash:3622d3e77ecef090b5111e3c5423313f11711dfa media_build

RE: [PATCH v2] dw9714: Initial driver for dw9714 VCM

2017-05-10 Thread Mani, Rajmohan
Hi Tomasz, Thanks for the reviews. Please see comments inline. > -Original Message- > From: Tomasz Figa [mailto:tf...@chromium.org] > Sent: Tuesday, May 09, 2017 4:44 PM > To: Mani, Rajmohan > Cc: linux-media@vger.kernel.org; mche...@kernel.org; Hans Verkuil >

Re: [PATCH] v4l2-subdev: Remove of_node

2017-05-10 Thread Sakari Ailus
Hi Kieran, Thanks for the patch. On Wed, May 10, 2017 at 05:45:54PM +0100, Kieran Bingham wrote: > From: Kieran Bingham > > With the fwnode implementation, of_node is no longer used. > > Remove it. > > Signed-off-by: Kieran Bingham

[PATCH] v4l2-subdev: Remove of_node

2017-05-10 Thread Kieran Bingham
From: Kieran Bingham With the fwnode implementation, of_node is no longer used. Remove it. Signed-off-by: Kieran Bingham --- include/media/v4l2-subdev.h | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCH] TW686x: Fix OOPS on buffer alloc failure

2017-05-10 Thread Ezequiel Garcia
Hi Krzysztof, On 10 May 2017 at 06:51, Krzysztof Hałasa wrote: > Signed-off-by: Krzysztof Hałasa > > diff --git a/drivers/media/pci/tw686x/tw686x-video.c > b/drivers/media/pci/tw686x/tw686x-video.c > index c3fafa9..d637f47 100644 > ---

Re: [PATCH 12/16] rcar-vin: allow switch between capturing modes when stalling

2017-05-10 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:53 Niklas Söderlund wrote: > If userspace can't feed the driver with buffers as fast as the driver > consumes them the driver will stop video capturing and wait for more > buffers from userspace, the driver is stalled. Once it have

Re: [PATCH 16/16] rcar-vin: fix bug in pixelformat selection

2017-05-10 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:57 Niklas Söderlund wrote: > If the requested pixelformat is not supported only revert to the current > pixelformat, do not revert the entire format. Also if the pixelformat > needs to be reverted the pixel information needs to be

Re: [PATCH 13/16] rcar-vin: refactor and fold in function after stall handling rework

2017-05-10 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:54 Niklas Söderlund wrote: > With the driver stopping and starting the stream each time the driver is > stalled rvin_capture_off() can be folded in to the only caller. > > Signed-off-by: Niklas Söderlund

Re: [PATCH 15/16] rcar-vin: add missing error check to propagate error

2017-05-10 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:56 Niklas Söderlund wrote: > The return value of __rvin_try_format_source is not checked, add a check > and propagate the error. > > Signed-off-by: Niklas Söderlund Reviewed-by: Laurent

Re: [PATCH 14/16] rcar-vin: make use of video_device_alloc() and video_device_release()

2017-05-10 Thread Laurent Pinchart
Hi Niklas, On Tuesday 14 Mar 2017 19:59:55 Niklas Söderlund wrote: > Make use of the helper functions video_device_alloc() and > video_device_release() to control the lifetime of the struct > video_device. It's nice to see you considering lifetime management issues, but this isn't enough. The

Re: [PATCH 11/16] rcar-vin: select capture mode based on free buffers

2017-05-10 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:52 Niklas Söderlund wrote: > Instead of selecting single or continuous capture mode based on how many > buffers userspace intends to give us select capture mode based on number > of free buffers we can allocate to hardware when the

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-05-10 Thread Marek Szyprowski
Hi Daniel, On 2017-05-10 09:55, Daniel Vetter wrote: On Wed, May 10, 2017 at 03:27:02PM +0900, Inki Dae wrote: Hi Tomasz, 2017년 05월 10일 14:38에 Tomasz Figa 이(가) 쓴 글: Hi Everyone, On Wed, May 10, 2017 at 9:24 AM, Inki Dae wrote: 2017년 04월 26일 07:21에 Sakari Ailus 이(가)

Re: [PATCH 10/16] rcar-vin: move functions which acts on hardware

2017-05-10 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:51 Niklas Söderlund wrote: > This only moves whole structs, defines and functions around, no code is > changed inside any function. The reason for moving this code around is > to prepare for refactoring and fixing of a start/stop

Re: [PATCH 09/16] rcar-vin: decrease buffers needed to capture

2017-05-10 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:50 Niklas Söderlund wrote: > It's possible to grab frames using only one buffer, this should never > have been set to anything else then 1. > > Signed-off-by: Niklas Söderlund Reviewed-by:

Re: [PATCH 08/16] rcar-vin: use pad information when verifying media bus format

2017-05-10 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:49 Niklas Söderlund wrote: > Use information about pad index when enumerating mbus codes. > > Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart

Re: [PATCH 07/16] rcar-vin: move pad lookup to async bound handler

2017-05-10 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:48 Niklas Söderlund wrote: > Information about pads will be needed when enumerating the media bus > codes in the async complete handler which is run before > rvin_v4l2_probe(). Move the pad lookup to the async bound handler so >

Re: [PATCH 03/16] rcar-vin: fix how pads are handled for v4l2 subdevice operations

2017-05-10 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:44 Niklas Söderlund wrote: > The rcar-vin driver only uses one pad, pad number 0. > > - All v4l2 operations that did not check that the requested operation > was for pad 0 have been updated with a check to enforce this. > > -

Re: [PATCH 02/16] rcar-vin: use rvin_reset_format() in S_DV_TIMINGS

2017-05-10 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:43 Niklas Söderlund wrote: > Use rvin_reset_format() in rvin_s_dv_timings() instead of just resetting > a few fields. This fixes an issue where the field format was not > properly set after S_DV_TIMINGS. > > Signed-off-by: Niklas

Re: [PATCH 04/16] rcar-vin: fix standard in input enumeration

2017-05-10 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:45 Niklas Söderlund wrote: > If the subdevice supports dv_timings_cap the driver should not fill in > the standard. A subdev could have analog TV and digital TV inputs. However, as the rcar-vin driver supports a single input

Re: [PATCH 01/16] rcar-vin: reset bytesperline and sizeimage when resetting format

2017-05-10 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:42 Niklas Söderlund wrote: > These two where forgotten when refactoring the format reset code. If > they are not also reset at the same time as width and height the format > returned from G_FMT will not match reality. > >

Re: [PATCH 05/16] rcar-vin: move subdev source and sink pad index to rvin_graph_entity

2017-05-10 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:46 Niklas Söderlund wrote: > It makes more sens to store the sink and source pads in struct > rvin_graph_entity since that contains other subdevice related > information. > > The data type to store pad information in is unsigned

Re: [PATCH 06/16] rcar-vin: refactor pad lookup code

2017-05-10 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Tuesday 14 Mar 2017 19:59:47 Niklas Söderlund wrote: > The pad lookup code can be broken out to increase readability and to > reduce code duplication. > > Signed-off-by: Niklas Söderlund > --- >

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-05-10 Thread Daniel Vetter
On Wed, May 10, 2017 at 12:29 PM, Inki Dae wrote: >> This kind of contradicts with response Marek received from DRM >> community about his proposal. Which drivers in particular you have in >> mind? > > You can check vmw_overlay_ioctl of vmwgfx driver and >

Re: [PATCH v9 3/4] arm: dts: mt2701: Add node for Mediatek JPEG Decoder

2017-05-10 Thread Matthias Brugger
On 14/12/16 09:04, Rick Chang wrote: Signed-off-by: Rick Chang Signed-off-by: Minghsiu Tsai --- This patch depends on: CCF "Add clock support for Mediatek MT2701"[1] iommu and smi "Add the dtsi node of iommu and smi for mt2701"[2]

Re: [RFC v4 13/18] vb2: Don't sync cache for a buffer if so requested

2017-05-10 Thread Tomasz Figa
Hi Sakari, Few comments inline. On Mon, May 8, 2017 at 11:03 PM, Sakari Ailus wrote: > From: Samu Onkalo > > The user may request to the driver (vb2) to skip the cache maintenance > operations in case the buffer does not need cache

Re: [RFC v4 10/18] vb2: dma-contig: Fix DMA attribute and cache management

2017-05-10 Thread Tomasz Figa
Hi Sakari, Some comments inline. On Mon, May 8, 2017 at 11:03 PM, Sakari Ailus wrote: > Patch ccc66e73 ("ARM: 8508/2: videobuf2-dc: Let drivers specify DMA > attrs") added support for driver specific DMA attributes to > videobuf2-dma-contig but it had several

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-05-10 Thread Inki Dae
2017년 05월 10일 16:55에 Daniel Vetter 이(가) 쓴 글: > On Wed, May 10, 2017 at 03:27:02PM +0900, Inki Dae wrote: >> Hi Tomasz, >> >> 2017년 05월 10일 14:38에 Tomasz Figa 이(가) 쓴 글: >>> Hi Everyone, >>> >>> On Wed, May 10, 2017 at 9:24 AM, Inki Dae wrote: 2017년 04월 26일

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-05-10 Thread Inki Dae
2017년 05월 10일 15:38에 Tomasz Figa 이(가) 쓴 글: > On Wed, May 10, 2017 at 2:27 PM, Inki Dae wrote: >> Hi Tomasz, >> >> 2017년 05월 10일 14:38에 Tomasz Figa 이(가) 쓴 글: >>> Hi Everyone, >>> >>> On Wed, May 10, 2017 at 9:24 AM, Inki Dae wrote:

Re: [RFC v4 07/18] vb2: dma-contig: Remove redundant sgt_base field

2017-05-10 Thread Tomasz Figa
Hi Sakari, Some comments inline. On Mon, May 8, 2017 at 11:03 PM, Sakari Ailus wrote: > The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and > dma_sgt. The former is used by DMA-BUF buffers whereas the latter is used > by USERPTR. > > Unify the

[PATCH] TW686x: Fix OOPS on buffer alloc failure

2017-05-10 Thread Krzysztof Hałasa
Signed-off-by: Krzysztof Hałasa diff --git a/drivers/media/pci/tw686x/tw686x-video.c b/drivers/media/pci/tw686x/tw686x-video.c index c3fafa9..d637f47 100644 --- a/drivers/media/pci/tw686x/tw686x-video.c +++ b/drivers/media/pci/tw686x/tw686x-video.c @@ -1190,6 +1190,13 @@ int

Re: [PCIE device driver: tw686x] I have some problems with tw686x and I need help.

2017-05-10 Thread Krzysztof Hałasa
Hello Singh, I've added linux-media as well as the current TW686x driver maintainer to Cc: list. Perhaps they will be better prepared to help you, the driver differs much from what it was when I originally wrote it. writes: > First, I download source code from website >

Re: [PATCH v5 3/7] media: i2c: max2175: Add MAX2175 support

2017-05-10 Thread Sakari Ailus
Hi Ramesh, On Tue, May 09, 2017 at 02:37:34PM +0100, Ramesh Shanmugasundaram wrote: ... > +#include > +#include > +#include Could you rebase this on the V4L2 fwnode patchset here, please? It depends on other patches which

Re: [PATCH[ v4l2-ioctl.c: always copy G/S_EDID result

2017-05-10 Thread Sakari Ailus
Hi Hans, On Wed, May 10, 2017 at 08:36:56AM +0200, Hans Verkuil wrote: > The VIDIOC_G/S_EDID ioctls can return valid data even if an error is returned. > > Mark those ioctls accordingly. Rather than using an explicit 'if' to check > for the > ioctl (as was done until now for

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-05-10 Thread Daniel Vetter
On Wed, May 10, 2017 at 03:27:02PM +0900, Inki Dae wrote: > Hi Tomasz, > > 2017년 05월 10일 14:38에 Tomasz Figa 이(가) 쓴 글: > > Hi Everyone, > > > > On Wed, May 10, 2017 at 9:24 AM, Inki Dae wrote: > >> > >> > >> 2017년 04월 26일 07:21에 Sakari Ailus 이(가) 쓴 글: > >>> Hi Marek, > >>>

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-05-10 Thread Tomasz Figa
On Wed, May 10, 2017 at 2:27 PM, Inki Dae wrote: > Hi Tomasz, > > 2017년 05월 10일 14:38에 Tomasz Figa 이(가) 쓴 글: >> Hi Everyone, >> >> On Wed, May 10, 2017 at 9:24 AM, Inki Dae wrote: >>> >>> >>> 2017년 04월 26일 07:21에 Sakari Ailus 이(가) 쓴 글: Hi Marek,

[PATCH[ v4l2-ioctl.c: always copy G/S_EDID result

2017-05-10 Thread Hans Verkuil
The VIDIOC_G/S_EDID ioctls can return valid data even if an error is returned. Mark those ioctls accordingly. Rather than using an explicit 'if' to check for the ioctl (as was done until now for VIDIOC_QUERY_DV_TIMINGS) just set a new flag in the v4l2_ioctls array. Signed-off-by: Hans Verkuil

Re: [RFC 0/4] Exynos DRM: add Picture Processor extension

2017-05-10 Thread Inki Dae
Hi Tomasz, 2017년 05월 10일 14:38에 Tomasz Figa 이(가) 쓴 글: > Hi Everyone, > > On Wed, May 10, 2017 at 9:24 AM, Inki Dae wrote: >> >> >> 2017년 04월 26일 07:21에 Sakari Ailus 이(가) 쓴 글: >>> Hi Marek, >>> >>> On Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski wrote: Hi