RE: [PATCH v4 1/1] i2c: Add Omnivision OV5670 5M sensor support

2017-07-13 Thread Rapolu, Chiranjeevi
Raj, Removed duplicate const. Thanks, Chiran -Original Message- From: Mani, Rajmohan Sent: Friday, July 7, 2017 3:49 PM To: Rapolu, Chiranjeevi ; linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; tf...@chromium.org Cc: Zheng, Jian Xu

RE: [PATCH v4 1/1] i2c: Add Omnivision OV5670 5M sensor support

2017-07-13 Thread Rapolu, Chiranjeevi
Sakari, Thanks for the review. Submitted v5, responses embedded below. Thanks, Chiran. -Original Message- >Hi Chiranjeevi, > >A few relatively minor comments below. > >On Sat, Jul 01, 2017 at 01:49:06PM -0700, chiranjeevi.rap...@intel.com wrote: >> From: Chiranjeevi Rapolu

cron job: media_tree daily build: ERRORS

2017-07-13 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Jul 14 05:00:23 CEST 2017 media-tree git hash:2748e76ddb2967c4030171342ebdd3faa6a5e8e8 media_build

Re: [PATCH 1/1 V2] media: usb: uvc: Fix incorrect timeout for Get Request

2017-07-13 Thread Jim Lin
On 2017年07月11日 03:47, Laurent Pinchart wrote: Hi Jim, Thank you for the patch. On Monday 10 Jul 2017 14:43:49 Jim Lin wrote: Section 9.2.6.4 of USB 2.0/3.x specification describes that "device must be able to return the first data packet to host within 500 ms of receipt of the request. For

[PATCH v5 1/1] i2c: Add Omnivision OV5670 5M sensor support

2017-07-13 Thread Chiranjeevi Rapolu
Provides single source pad with up to 2592x1944 pixels at 10-bit raw bayer format over MIPI CSI2 two lanes at 840Mbps/lane. The driver supports following features: - up to 30fps at 5M pixels - manual exposure - digital/analog gain - V-blank/H-blank - test pattern - media controller - runtime pm

rc-core: how to use hid (hardware) decoder?

2017-07-13 Thread Antti Palosaari
Moikka! Some remote controller receivers uses HID interface. I looked rc-core implementation, but failed to find how it could be used for hid. I need somehow get scancodes and keycodes out from rc-core and write those to hardware which then generate hid events. Also, I am not sure if kernel

Re: [PATCH v2 00/14] Renesas R-Car VSP: Add H3 ES2.0 support

2017-07-13 Thread Laurent Pinchart
Hi Kieran, On Thursday 13 Jul 2017 13:25:55 Kieran Bingham wrote: > Hi Laurent, > > Thank you for these patches, bringing life to the outputs of my ES2.0 target > board. > > I have tested them on my board, and including the VSP unit test suite, and > kmscube utilities. > > Feel free to add a

[PATCH v2.1 08/14] v4l: vsp1: Add support for new VSP2-BS, VSP2-DL and VSP2-D instances

2017-07-13 Thread Laurent Pinchart
New Gen3 SoCs come with two new VSP2 variants names VSP2-BS and VSP2-DL, as well as a new VSP2-D variant on V3M and V3H SoCs. Add new entries for them in the VSP device info table. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham

Re: [PATCH v2 08/14] v4l: vsp1: Add support for new VSP2-BS, VSP2-DL and VSP2-D instances

2017-07-13 Thread Laurent Pinchart
Hi Kieran, On Thursday 13 Jul 2017 18:49:19 Kieran Bingham wrote: > On 26/06/17 19:12, Laurent Pinchart wrote: > > New Gen3 SoCs come with two new VSP2 variants names VSP2-BS and VSP2-DL, > > as well as a new VSP2-D variant on V3M and V3H SoCs. Add new entries for > > them in the VSP device info

Re: [PATCH v2 06/14] v4l: vsp1: Add pipe index argument to the VSP-DU API

2017-07-13 Thread Laurent Pinchart
Hi Kieran, On Thursday 13 Jul 2017 14:16:03 Kieran Bingham wrote: > On 26/06/17 19:12, Laurent Pinchart wrote: > > In the H3 ES2.0 SoC the VSP2-DL instance has two connections to DU > > channels that need to be configured independently. Extend the VSP-DU API > > with a pipeline index to identify

Re: [PATCH] [media] staging: media: davinci_vpfe: fix spelling mistake in variable

2017-07-13 Thread Laurent Pinchart
Hi Colin, Thank you for the patch. On Thursday 13 Jul 2017 23:34:16 Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake, rename the function name > resizer_configure_in_continious_mode to > resizer_configure_in_continuous_mode and also remove

[PATCH] [media] staging: media: davinci_vpfe: fix spelling mistake in variable

2017-07-13 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake, rename the function name resizer_configure_in_continious_mode to resizer_configure_in_continuous_mode and also remove an extraneous space. Signed-off-by: Colin Ian King ---

Re: [PATCH 0/2] OMAP3ISP CCP2 support

2017-07-13 Thread Sakari Ailus
On Thu, Jul 13, 2017 at 11:38:06PM +0200, Pavel Machek wrote: > On Fri 2017-07-14 00:26:52, Sakari Ailus wrote: > > On Thu, Jul 13, 2017 at 11:13:35PM +0200, Pavel Machek wrote: > > > Hi! > > > > > > > I took the liberty of changing your patch a bit. I added another to > > > > extract > > > >

Re: [PATCH 0/2] OMAP3ISP CCP2 support

2017-07-13 Thread Pavel Machek
On Fri 2017-07-14 00:26:52, Sakari Ailus wrote: > On Thu, Jul 13, 2017 at 11:13:35PM +0200, Pavel Machek wrote: > > Hi! > > > > > I took the liberty of changing your patch a bit. I added another to > > > extract > > > the number of lanes from the endpoint instead as it's not really a > > >

Re: [PATCH 0/2] OMAP3ISP CCP2 support

2017-07-13 Thread Sakari Ailus
On Thu, Jul 13, 2017 at 11:13:35PM +0200, Pavel Machek wrote: > Hi! > > > I took the liberty of changing your patch a bit. I added another to extract > > the number of lanes from the endpoint instead as it's not really a property > > of the PHY. (Not tested yet, will check with N9.) > > No

Re: [PATCH 0/2] OMAP3ISP CCP2 support

2017-07-13 Thread Pavel Machek
Hi! > I took the liberty of changing your patch a bit. I added another to extract > the number of lanes from the endpoint instead as it's not really a property > of the PHY. (Not tested yet, will check with N9.) No problem. Notice that the 1/2 does not apply on top of ccp2 branch; my merge

Re: [PATCH v2 09/14] v4l: vsp1: Add support for multiple LIF instances

2017-07-13 Thread Kieran Bingham
Hi Laurent, On 26/06/17 19:12, Laurent Pinchart wrote: > The VSP2-DL instance (present in the H3 ES2.0 and M3-N SoCs) has two LIF > instances. Adapt the driver infrastructure to support multiple LIFs. > Support for multiple display pipelines will be added separately. > > The change to the entity

Re: [PATCH v2 08/14] v4l: vsp1: Add support for new VSP2-BS, VSP2-DL and VSP2-D instances

2017-07-13 Thread Kieran Bingham
Hi Laurent, On 26/06/17 19:12, Laurent Pinchart wrote: > New Gen3 SoCs come with two new VSP2 variants names VSP2-BS and VSP2-DL, > as well as a new VSP2-D variant on V3M and V3H SoCs. Add new entries for > them in the VSP device info table. > > Signed-off-by: Laurent Pinchart

Re: [PATCH v2 02/14] v4l: vsp1: Don't recycle active list at display start

2017-07-13 Thread Kieran Bingham
Hi Laurent, On 26/06/17 19:12, Laurent Pinchart wrote: > When the display start interrupt occurs, we know that the hardware has > finished loading the active display list. The driver then proceeds to > recycle the list, assuming it won't be needed anymore. > > This assumption holds true for

[PATCH v3] staging: lirc_zilog: Clean up lirc zilog error codes

2017-07-13 Thread Yves Lemée
According the coding style guidelines, the ENOSYS error code must be returned in case of a non existent system call. This code has been replaced with the ENOTTY error code indicating a missing functionality. Signed-off-by: Yves Lemée --- v3: Fixed patch subject

[PATCH 1/2] omap3isp: Explicitly set the number of CSI-2 lanes used in lane cfg

2017-07-13 Thread Sakari Ailus
The omap3isp driver extracts the CSI-2 lane configuration from the V4L2 fwnode endpoint but misses the number of lanes itself. Get this information and use it in PHY configuration. Signed-off-by: Sakari Ailus --- drivers/media/platform/omap3isp/isp.c | 5

[PATCH 0/2] OMAP3ISP CCP2 support

2017-07-13 Thread Sakari Ailus
Hi Pavel, I took the liberty of changing your patch a bit. I added another to extract the number of lanes from the endpoint instead as it's not really a property of the PHY. (Not tested yet, will check with N9.) Pavel Machek (1): omap3isp: add CSI1 support Sakari Ailus (1): omap3isp:

[PATCH 2/2] omap3isp: add CSI1 support

2017-07-13 Thread Sakari Ailus
From: Pavel Machek CSI-2 PHY power management is only needed for major version 15 of the ISP. Additionally, set the CCP2 PHY for previous ISP versions as well. These changes are necessary for CCP2 support. Signed-off-by: Pavel Machek Signed-off-by: Sakari Ailus

[PATCH] [media] staging/atomisp: fix minor coding style issue

2017-07-13 Thread Shy More
Below was the minor issue flagged by checkpatch.pl: - ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Shy More --- .../atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 2/2] staging: atomisp2: hmm: Alignment code (rebased)

2017-07-13 Thread Sakari Ailus
On Thu, Jul 13, 2017 at 08:55:43AM +0200, Philipp Guendisch wrote: > This patch fixed code alignment to open paranthesis. > Semantic should not be affected by this patch. > > It has been rebased on top of media_tree atomisp branch > > Signed-off-by: Philipp Guendisch >

Re: [PATCH] media: vimc: cleanup a few warnings

2017-07-13 Thread Javier Martinez Canillas
On Thu, Jul 13, 2017 at 5:38 PM, Sakari Ailus wrote: [snip] >> >> -static const struct platform_device_id vimc_sen_driver_ids[] = { >> +static const __maybe_unused >> +struct platform_device_id vimc_sen_driver_ids[] = { >> { >> .name =

Re: [PATCH] media: vimc: cleanup a few warnings

2017-07-13 Thread Sakari Ailus
Hi Mauro, On Wed, Jul 12, 2017 at 08:46:30AM -0300, Mauro Carvalho Chehab wrote: > The const structs uded by MODULE_DEVICE_TABLE() > may never be used with COMPILE_TEST: > > drivers/media/platform/vimc/vimc-capture.c:528:40: warning: > 'vimc_cap_driver_ids' defined but not used

[PATCH v2 3/6] omap3isp: Remove misleading comment

2017-07-13 Thread Sakari Ailus
The intent of the check the comment is related to is to ensure we are streaming --- still. Not that streaming wouldn't be enabled yet. Remove it. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Reviewed-by: Laurent Pinchart

[PATCH v2 6/6] media: devnode: Rename mdev argument as devnode

2017-07-13 Thread Sakari Ailus
Historically, mdev argument name was being used on both struct media_device and struct media_devnode. Recently most occurrences of mdev referring to struct media_devnode were replaced by devnode, which makes more sense. Fix the last remaining occurrence. Fixes: 163f1e93e9950 ("[media]

[PATCH v2 5/6] media: Remove useless curly braces and parentheses

2017-07-13 Thread Sakari Ailus
Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Reviewed-by: Laurent Pinchart --- drivers/media/media-device.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH v2 1/6] omap3isp: Don't rely on devm for memory resource management

2017-07-13 Thread Sakari Ailus
devm functions are fine for managing resources that are directly related to the device at hand and that have no other dependencies. However, a process holding a file handle to a device created by a driver for a device may result in the file handle left behind after the device is long gone. This

[PATCH v2 0/6] Media controller and omap3isp cleanups

2017-07-13 Thread Sakari Ailus
Hi folks, These patches prepare for media device refcounting but do not bring those changes yet. They're worthwhile on their own merits. since v1: - Use IS_ERR_OR_NULL() check in error handling for omap3isp_hist_init() instead of IS_ERR() --- the argument may be NULL as well. Sakari Ailus

[PATCH v2 2/6] omap3isp: Call video_unregister_device() unconditionally

2017-07-13 Thread Sakari Ailus
video_unregister_device() can be called on a never or an already unregistered device. Drop the redundant check. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Reviewed-by: Laurent Pinchart ---

[PATCH v2 4/6] omap3isp: Disable streaming at driver unbind time

2017-07-13 Thread Sakari Ailus
Once the driver is unbound accessing the hardware is not allowed anymore. Due to this, disable streaming when the device driver is unbound. The states of the associated objects related to Media controller and videobuf2 frameworks are updated as well, just like if the application disabled streaming

Re: [PATCH] [media] staging/atomisp: fix minor coding style warnings

2017-07-13 Thread Greg KH
On Thu, Jul 13, 2017 at 08:06:21AM -0700, smklearn wrote: > Below were the minor issues flagged by checkpatch.pl: > - WARNING: Block comments use * on subsequent lines > - ERROR: space prohibited after that open parenthesis '(' Don't do multiple things in the same patch please, this should be

[PATCH] [media] staging/atomisp: fix minor coding style warnings

2017-07-13 Thread smklearn
Below were the minor issues flagged by checkpatch.pl: - WARNING: Block comments use * on subsequent lines - ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Shy More --- .../css2400/runtime/isys/src/ibuf_ctrl_rmgr.c | 26 +++--- 1

Re: [PATCH] staging drivers fixed coding style error

2017-07-13 Thread Greg KH
On Thu, Jul 13, 2017 at 07:17:56AM -0700, smklearn wrote: > Fixed coding style error flagged checkpatch.pl: > - ERROR: space prohibited after that open parenthesis '(' > - WARNING: Block comments use * on subsequent lines > > Signed-off-by: Shy More > > Output

[PATCH] staging drivers fixed coding style error

2017-07-13 Thread smklearn
Fixed coding style error flagged checkpatch.pl: - ERROR: space prohibited after that open parenthesis '(' - WARNING: Block comments use * on subsequent lines Signed-off-by: Shy More Output after fixing coding style issues: $KERN/scripts/checkpatch.pl -f

Re: [PATCH v2 07/14] v4l: vsp1: Add support for the BRS entity

2017-07-13 Thread Kieran Bingham
On 26/06/17 19:12, Laurent Pinchart wrote: > The Blend/ROP Sub Unit (BRS) is a stripped-down version of the BRU found > in several VSP2 instances. Compared to a regular BRU, it supports two > inputs only, and thus has no ROP unit. > > Add support for the BRS by modeling it as a new entity type,

Re: [PATCH v3 0/2] [media] videobuf2-dc: Add support for cacheable MMAP

2017-07-13 Thread Christoph Hellwig
On Thu, Jul 13, 2017 at 02:21:53PM +0100, Russell King - ARM Linux wrote: > My conclusion of the dma_alloc_noncoherent() and dma_cache_sync() API > when it was introduced is that it's basically a completely broken > interface, and I've never seen any point to it. Maybe some of that is > because

Re: [PATCH v3 0/2] [media] videobuf2-dc: Add support for cacheable MMAP

2017-07-13 Thread Russell King - ARM Linux
On Thu, Jul 13, 2017 at 01:13:28PM +0200, Marek Szyprowski wrote: > Hi Christoph, > > On 2017-07-05 19:33, Christoph Hellwig wrote: > >On Mon, Jul 03, 2017 at 11:27:32AM +0200, Marek Szyprowski wrote: > >>The main question here if we want to merge incomplete solution or not. As > >>for now, there

Re: [PATCH v2 06/14] v4l: vsp1: Add pipe index argument to the VSP-DU API

2017-07-13 Thread Kieran Bingham
On 26/06/17 19:12, Laurent Pinchart wrote: > In the H3 ES2.0 SoC the VSP2-DL instance has two connections to DU > channels that need to be configured independently. Extend the VSP-DU API > with a pipeline index to identify which pipeline the caller wants to > operate on. > > Signed-off-by:

Re: [PATCH v2 05/14] v4l: vsp1: Don't create links for DRM pipeline

2017-07-13 Thread Kieran Bingham
On 26/06/17 19:12, Laurent Pinchart wrote: > When the VSP1 is used in a DRM pipeline the driver doesn't register the > media device. Links between entities are not exposed to userspace, but > are still used internally for the sole purpose of setting up internal > source to sink pointers through

Re: [PATCH v2 04/14] v4l: vsp1: Store source and sink pointers as vsp1_entity

2017-07-13 Thread Kieran Bingham
Hi Laurent, This looks like a good simplification/removal of obfuscation to me! On 26/06/17 19:12, Laurent Pinchart wrote: > The internal VSP entity source and sink pointers are stored as > media_entity pointers, which are then cast to a vsp1_entity. As all > sources and sinks are vsp1_entity

Re: [PATCH v2 03/14] v4l: vsp1: Don't set WPF sink pointer

2017-07-13 Thread Kieran Bingham
On 26/06/17 19:12, Laurent Pinchart wrote: > The sink pointer is used to configure routing inside the VSP, and as > such must point to the next VSP entity in the pipeline. The WPF being a > pipeline terminal sink, its output route can't be configured. The > routing configuration code already

Re: [PATCH v2 01/14] v4l: vsp1: Fill display list headers without holding dlm spinlock

2017-07-13 Thread Kieran Bingham
Hi Laurent, Starts easy ... (I haven't gone through these in numerical order of course :D) On 26/06/17 19:12, Laurent Pinchart wrote: > The display list headers are filled using information from the display > list only. Lower the display list manager spinlock contention by filling > the headers

Re: [PATCH v2 00/14] Renesas R-Car VSP: Add H3 ES2.0 support

2017-07-13 Thread Kieran Bingham
Hi Laurent, Thankyou for these patches, bringing life to the outputs of my ES2.0 target board. I have tested them on my board, and including the VSP unit test suite, and kmscube utilities. Feel free to add a Tested-by: Kieran Bingham to all of the

[PATCH] [media] dib0090: make const array dib0090_tuning_table_cband_7090e_aci static

2017-07-13 Thread Colin King
From: Colin Ian King Don't populate array dib0090_tuning_table_cband_7090e_aci on the stack but instead make it static. Makes the object code smaller by over 180 bytes: Before: textdata bss dec hex filename 400527320 192 47564b9cc

[PATCH] [media] drxj: make several const arrays static

2017-07-13 Thread Colin King
From: Colin Ian King Don't populate const arrays on the stack but instead make them static. Makes the object code smaller by over 1800 bytes: Before: textdata bss dec hex filename 941009160 0 103260 1935c drxj.o After: textdata

[PATCH] [media] drxd: make const arrays slowIncrDecLUT and fastIncrDecLUT static

2017-07-13 Thread Colin King
From: Colin Ian King Don't populate arrays slowIncrDecLUT and fastIncrDecLUT on the stack but instead make them static. Makes the object code smaller by over 100 bytes: textdata bss dec hex filename 27776 832 64 286727000 drxd_hard.o

Re: [PATCH v3 0/2] [media] videobuf2-dc: Add support for cacheable MMAP

2017-07-13 Thread Marek Szyprowski
Hi Christoph, On 2017-07-05 19:33, Christoph Hellwig wrote: On Mon, Jul 03, 2017 at 11:27:32AM +0200, Marek Szyprowski wrote: The main question here if we want to merge incomplete solution or not. As for now, there is no support in ARM/ARM64 for NON_CONSISTENT attribute. Also none of the v4l2

Re: [PATCH 7/8] omap3isp: Check for valid port in endpoints

2017-07-13 Thread Pavel Machek
Hi! > > On Thu, Jul 06, 2017 at 02:00:18AM +0300, Sakari Ailus wrote: > > > Check that we do have a valid port in an endpoint, return an error if not. > > > > > > Signed-off-by: Sakari Ailus > > > > Reviewed-by: Sebastian Reichel

[PATCH] omap3isp: add CSI1 support

2017-07-13 Thread Pavel Machek
omap3isp: add CSI1 support Use proper code path for csi1/ccp2 support. Signed-off-by: Pavel Machek diff --git a/drivers/media/platform/omap3isp/ispccp2.c b/drivers/media/platform/omap3isp/ispccp2.c index 24a9fc5..47210b1 100644 ---

Re: [patch] propagating controls in libv4l2 was Re: support autofocus / autogain in libv4l2

2017-07-13 Thread Pavel Machek
Hi! > > Now. There is autogain support in libv4lconvert, but it expects to use > > same fd for camera and for the gain... which does not work with > > subdevs. > > > > Of course, opening subdevs by name like this is not really > > acceptable. But can you suggest a method that is? > > There are

Re: [PATCH v4 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-07-13 Thread Sakari Ailus
Hi Tomasz, On Thu, Jul 13, 2017 at 05:31:33PM +0900, Tomasz Figa wrote: > On Thu, Jul 13, 2017 at 5:21 PM, Sakari Ailus wrote: > >> >> + ret = v4l2_async_notifier_register(>v4l2_dev, > >> >> >notifier); > >> >> + if (ret) { > >> >> +

Re: [patch, libv4l]: add sdlcam example for testing digital still camera functionality

2017-07-13 Thread Pavel Machek
Hi! > > Utilities like v4l2-ctl are tied closely to the kernel and are updated > > whenever > > new APIs appear. But yet another viewer? > > > > Mauro, I find that v4l-utils is a bit polluted with non-core utilities. > > IMHO it should only contain the core libv4l2, core utilities and > >

Re: [PATCH v4 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-07-13 Thread Tomasz Figa
On Thu, Jul 13, 2017 at 5:21 PM, Sakari Ailus wrote: >> >> + ret = v4l2_async_notifier_register(>v4l2_dev, >> >> >notifier); >> >> + if (ret) { >> >> + cio2->notifier.num_subdevs = 0; >> > >> > No need to assign num_subdevs as 0. >> > >> > [YZ]

Re: [PATCH v4 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-07-13 Thread Sakari Ailus
Hi Tomasz and Yong, On Thu, Jul 13, 2017 at 01:51:18PM +0900, Tomasz Figa wrote: > Hi Yong, > > On Thu, Jul 13, 2017 at 8:20 AM, Zhi, Yong wrote: > > Hi, Sakari, > > > > Thanks for the time spent on code review, acks to all the comments, except > > two places: > > > >> +/*

Re: [patch] autogain support for bayer10 format (was Re: [patch] propagating controls in libv4l2)

2017-07-13 Thread Pavel Machek
Hi! > Oh, somehow I got confused that this is kernel code :) > > >But I'd say NEON conversion is not neccessary anytime soon. First, > >this is just trying to get average luminosity. We can easily skip > >quite a lot of pixels, and still get reasonable answer. > > > >Second, omap3isp actually

Re: [PATCH v2] [media] lirc_zilog: Clean up lirc zilog error codes

2017-07-13 Thread Frans Klaver
Almost there on the subject. Stuff between brackets is removed by git, so you should rather use something like [PATCH v2] staging: lirc: Clean up zilog error codes On Wed, Jul 12, 2017 at 9:17 PM, Yves Lemée wrote: > According the coding style guidelines, the ENOSYS

Re: [PATCH V2 4/9] [media] dvb-core/dvb_ca_en50221.c: Fixed block comments

2017-07-13 Thread Jasmin J.
Hello Antti! > actually it reports, when run --strict mode I checked this once, but I thought this would be too aggressive changes. >> * many cases where if (ret != 0), which generally should be written as if >> (ret). If you expect it is just error ret value, then prefer if (ret), but >> if>

[PATCH] cec: move cec_register_cec_notifier to cec-notifier.h

2017-07-13 Thread Hans Verkuil
The cec_register_cec_notifier function was in media/cec.h, but it has to be in cec-notifier.h. While we are at it, also document it and add a stub function for when the notifier is disabled or the CEC core code is unreachable. Based on an earlier patch from Jose Abreu .

Re: [PATCH v8 1/5] [media] cec.h: Add stub function for cec_register_cec_notifier()

2017-07-13 Thread Hans Verkuil
On 10/07/17 17:46, Jose Abreu wrote: > Add a new stub function for cec_register_cec_notifier() so that > we can still call this function when CONFIG_CEC_NOTIFIER and > CONFIG_CEC_CORE are not set. > > Signed-off-by: Jose Abreu > Cc: Carlos Palminha >

[PATCH v2 2/2] staging: atomisp2: hmm: Alignment code (rebased)

2017-07-13 Thread Philipp Guendisch
This patch fixed code alignment to open paranthesis. Semantic should not be affected by this patch. It has been rebased on top of media_tree atomisp branch Signed-off-by: Philipp Guendisch Signed-off-by: Chris Baller ---

[PATCH v2 1/2] staging: atomisp2: hmm: Fixed comment style

2017-07-13 Thread Philipp Guendisch
This patch fixed comment style. Semantic should not be affected. There are also two warnings left about too long lines, which reduce readability if changed. Signed-off-by: Philipp Guendisch Signed-off-by: Chris Baller ---

Re: [PATCH v7 2/3] media: i2c: adv748x: add adv748x driver

2017-07-13 Thread Niklas Söderlund
Hi Kieran, Thanks for your hard work. On 2017-07-06 12:01:16 +0100, Kieran Bingham wrote: > From: Kieran Bingham > > Provide support for the ADV7481 and ADV7482. > > The driver is modelled with 4 subdevices to allow simultaneous streaming > from the