cron job: media_tree daily build: ERRORS

2017-08-22 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Aug 23 05:25:33 CEST 2017 media-tree git hash:0779b8855c746c90b85bfe6e16d5dfa2a6a46655 media_build

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-08-22 Thread Yong
On Mon, 21 Aug 2017 22:21:45 +0200 Maxime Ripard wrote: > Hi Baruch, > > On Sun, Jul 30, 2017 at 09:08:01AM +0300, Baruch Siach wrote: > > On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > > > Hi, > > > > > > Thanks for the second iteration! >

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-08-22 Thread Yong
On Tue, 22 Aug 2017 19:43:39 +0200 Maxime Ripard wrote: > Hi Yong, > > On Mon, Jul 31, 2017 at 11:16:40AM +0800, Yong wrote: > > > > @@ -143,6 +143,7 @@ source "drivers/media/platform/am437x/Kconfig" > > > > source "drivers/media/platform/xilinx/Kconfig" > > >

RE: [PATCH 0/3] DW9714 DT support

2017-08-22 Thread Mani, Rajmohan
Hi Sakari, Thanks for the patches. I have verified that the dw9714 driver gets probed via DT bindings, with these patches on 4.13-rc6 kernel. Feel free to add Tested-by: Rajmohan Mani Raj > -Original Message- > From: Sakari Ailus

Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

2017-08-22 Thread Rob Herring
On Sun, Aug 20, 2017 at 12:24:08AM +0300, Sakari Ailus wrote: > From: Sakari Ailus Commit msg? > Signed-off-by: Sakari Ailus Shouldn't author and SoB be the same email? > --- > .../devicetree/bindings/leds/ams,as3645a.txt | 71 >

[PATCH] docs-rst: fix pdf build with Spinx 1.6

2017-08-22 Thread Mauro Carvalho Chehab
Sphinx 1.6 generates some LaTeX code before each table, starting its own environment before calling tabulary, apparently to improve table layout. The problem is that such environment is incompatible with adjustbox. While, in thesis, it should be possible to override it or to redefine tabulary, I

[PATCH v6 05/25] rcar-vin: change name of video device

2017-08-22 Thread Niklas Söderlund
The rcar-vin driver needs to be part of a media controller to support Gen3. Give each VIN instance a unique name so it can be referenced from userspace. Signed-off-by: Niklas Söderlund Reviewed-by: Kieran Bingham

[PATCH v6 09/25] rcar-vin: do not allow changing scaling and composing while streaming

2017-08-22 Thread Niklas Söderlund
It is possible on Gen2 to change the registers controlling composing and scaling while the stream is running. Is however not a good idea to do so and could result in trouble. There are also no good reason to allow this, remove immediate reflection in hardware registers from vidioc_s_selection and

[PATCH v6 04/25] rcar-vin: move max width and height information to chip information

2017-08-22 Thread Niklas Söderlund
On Gen3 the max supported width and height will be different from Gen2. Move the limits to the struct rvin_info to prepare for Gen3 support. Signed-off-by: Niklas Söderlund Reviewed-by: Kieran Bingham ---

[PATCH v6 08/25] rcar-vin: do not reset crop and compose when setting format

2017-08-22 Thread Niklas Söderlund
It was a bad idea to reset the crop and compose settings when a new format is set. This would overwrite any crop/compose set by s_select and cause unexpected behaviors, remove it. Also fold the reset helper in to the only remaining caller. Signed-off-by: Niklas Söderlund

[PATCH v6 23/25] rcar-vin: extend {start,stop}_streaming to work with media controller

2017-08-22 Thread Niklas Söderlund
The procedure to start or stop streaming using the none MC single subdevice and the MC graph and multiple subdevices are quiet different. Create a new function to abstract which method is used based on which mode the driver is running in and add logic to start the MC graph. Signed-off-by: Niklas

[PATCH v6 15/25] rcar-vin: add flag to switch to media controller mode

2017-08-22 Thread Niklas Söderlund
On Gen3 a media controller API needs to be used to allow userspace to configure the subdevices in the pipeline instead of directly controlling a single source subdevice, which is and will continue to be the mode of operation on Gen2. Prepare for these two modes of operation by adding a flag to

[PATCH v6 22/25] rcar-vin: add link notify for Gen3

2017-08-22 Thread Niklas Söderlund
Add the ability to process media device link change request. Link enablement are a bit complicated on Gen3, if it's possible to enable a link depends on what other links already are enabled. On Gen3 the 8 VIN are split into two subgroups (VIN0-3 and VIN4-7) and from a routing perspective these two

[PATCH v6 06/25] rcar-vin: move functions regarding scaling

2017-08-22 Thread Niklas Söderlund
In preparation of refactoring the scaling code move the code regarding scaling to to the top of the file to avoid the need to add forward declarations. No code is changed in this commit only whole functions moved inside the same file. Signed-off-by: Niklas Söderlund

[PATCH v6 25/25] rcar-vin: enable support for r8a7796

2017-08-22 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a7796. Signed-off-by: Niklas Söderlund --- .../devicetree/bindings/media/rcar_vin.txt | 1 + drivers/media/platform/rcar-vin/rcar-core.c| 64 ++ 2 files changed, 65

[PATCH v6 17/25] rcar-vin: use different v4l2 operations in media controller mode

2017-08-22 Thread Niklas Söderlund
When the driver runs in media controller mode it should not directly control the subdevice instead userspace will be responsible for configuring the pipeline. To be able to run in this mode a different set of v4l2 operations needs to be used. Add a new set of v4l2 operations to support the

[PATCH v6 18/25] rcar-vin: prepare for media controller mode initialization

2017-08-22 Thread Niklas Söderlund
When running in media controller mode a media pad is needed, register one. Also set the media bus format to CSI-2. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-core.c | 23 ++-

[PATCH v6 20/25] rcar-vin: add chsel information to rvin_info

2017-08-22 Thread Niklas Söderlund
Each Gen3 SoC has a limited set of predefined routing possibilities for which CSI-2 device and virtual channel can be routed to which VIN instance. Prepare to store this information in the struct rvin_info. Signed-off-by: Niklas Söderlund ---

[PATCH v6 24/25] rcar-vin: enable support for r8a7795

2017-08-22 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a7795. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/Kconfig | 2 +- drivers/media/platform/rcar-vin/rcar-core.c | 145 2 files changed, 146

[PATCH v6 12/25] rcar-vin: move media bus configuration to struct rvin_info

2017-08-22 Thread Niklas Söderlund
Bus configuration will once the driver is extended to to support Gen3 contain information not specific to only the directly connected parallel subdevice. Move it to struct rvin_info to show it's not always coupled to the parallel subdevice. Signed-off-by: Niklas Söderlund

[PATCH v6 19/25] rcar-vin: add group allocator functions

2017-08-22 Thread Niklas Söderlund
In media controller mode all VIN instances needs to be part of the same media graph. There is also a need to each VIN instance to know and in some cases be able to communicate with other VIN instances. Add a allocator framework where the first VIN instance to be probed creates a shared data

[PATCH v6 10/25] rcar-vin: read subdevice format for crop only when needed

2017-08-22 Thread Niklas Söderlund
Instead of caching the subdevice format each time the video device format is set read it directly when its needed. As it turns out the format is only needed when figuring out the max rectangle for cropping. This simplify the code and makes it clearer what the source format is used for.

[PATCH v6 14/25] rcar-vin: add functions to manipulate Gen3 CHSEL value

2017-08-22 Thread Niklas Söderlund
On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One feature of this register is that it's only present in the VIN0 and VIN4 instances. The register in VIN0 controls the routing for VIN0-3 and the register in VIN4 controls routing for VIN4-7. To be able to control routing from

[PATCH v6 21/25] rcar-vin: parse Gen3 OF and setup media graph

2017-08-22 Thread Niklas Söderlund
Parse the VIN Gen3 OF graph and register all CSI-2 devices in the VIN group common media device. Once all CSI-2 subdevice is added to the common media device create links between them. The parsing and registering CSI-2 subdevices with the v4l2 async framework is a collaborative effort shared

[PATCH v6 13/25] rcar-vin: enable Gen3 hardware configuration

2017-08-22 Thread Niklas Söderlund
Add the register needed to work with Gen3 hardware. This patch adds the logic for how to work with the Gen3 hardware. More work is required to enable the subdevice structure needed to configure capturing. Signed-off-by: Niklas Söderlund ---

[PATCH v6 11/25] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

2017-08-22 Thread Niklas Söderlund
It was never proper support in the VIN driver to deliver ALTERNATING field format to user-space, remove this field option. For sources using this field format instead use the VIN hardware feature of combining the fields to an interlaced format. This mode of operation was previously the default

[PATCH v6 16/25] rcar-vin: break out format alignment and checking

2017-08-22 Thread Niklas Söderlund
Part of the format aliment and checking can be shared with the Gen3 format handling. Break that part out to it's own function. While doing this clean up the checking and add more checks. Signed-off-by: Niklas Söderlund ---

[PATCH v6 07/25] rcar-vin: all Gen2 boards can scale simplify logic

2017-08-22 Thread Niklas Söderlund
The logic to preserve the requested format width and height are too complex and come from a premature optimization for Gen3. All Gen2 SoC can scale and the Gen3 implementation will not use these functions at all so simply preserve the width and hight when interacting with the subdevice much like

[PATCH v6 03/25] rcar-vin: move chip information to own struct

2017-08-22 Thread Niklas Söderlund
When Gen3 support is added to the driver more then chip id will be different for the different Soc. To avoid a lot of if statements in the code create a struct chip_info to contain this information. Signed-off-by: Niklas Söderlund Reviewed-by: Kieran

[PATCH v6 01/25] rcar-vin: add Gen3 devicetree bindings documentation

2017-08-22 Thread Niklas Söderlund
Document the devicetree bindings for the CSI-2 inputs available on Gen3. There is a need to add a custom property 'renesas,id' and to define which CSI-2 input is described in which endpoint under the port@1 node. This information is needed since there are a set of predefined routes between each

[PATCH v6 02/25] rcar-vin: register the video device at probe time

2017-08-22 Thread Niklas Söderlund
The driver registers the video device from the async complete callback and unregistered in the async unbind callback. This creates problems if if the subdevice is bound, unbound and later rebound. The second time video_register_device() is called it fails: kobject (eb3be918): tried to init an

[PATCH v6 00/25] rcar-vin: Add Gen3 with media controller

2017-08-22 Thread Niklas Söderlund
Hi, This series adds Gen3 VIN support to rcar-vin driver for Renesas r8a7795 and r8a7796. It is based on the media-tree. The driver is tested on both Renesas H3 (r8a7795, ES1.x + ES2.0) and M3-W (r8a7796) together with the rcar-csi2 driver (posted separately and not yet upstream) and the

Re: [PATCH v2 1/2] dt-bindings: media: Add Cadence MIPI-CSI2 RX Device Tree bindings

2017-08-22 Thread Laurent Pinchart
Hi Cyprian, On Tuesday, 22 August 2017 22:25:49 EEST Cyprian Wronka wrote: > On 22/08/2017, 02:01, Laurent Pinchart wrote: >> On Tuesday, 22 August 2017 11:53:20 EEST Maxime Ripard wrote: >>> On Mon, Aug 07, 2017 at 11:18:03PM +0300, Laurent Pinchart wrote: On Thursday 20 Jul 2017 11:23:01

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-08-22 Thread Laurent Pinchart
Hello, On Tuesday, 22 August 2017 23:17:31 EEST Maxime Ripard wrote: > On Tue, Aug 22, 2017 at 08:43:35AM +0200, Hans Verkuil wrote: > +static int sun6i_video_link_setup(struct media_entity *entity, > + const struct media_pad *local, > +

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-08-22 Thread Maxime Ripard
On Tue, Aug 22, 2017 at 08:43:35AM +0200, Hans Verkuil wrote: > >>> +static int sun6i_video_link_setup(struct media_entity *entity, > >>> + const struct media_pad *local, > >>> + const struct media_pad *remote, u32 flags) > >>> +{ > >>> + struct

Re: [PATCH v2] venus: fix copy/paste error in return_buf_error

2017-08-22 Thread Gustavo A. R. Silva
On 08/21/2017 04:14 AM, Stanimir Varbanov wrote: Thanks Gustavo! Glad to help. :) On 08/18/2017 07:07 PM, Gustavo A. R. Silva wrote: Call function v4l2_m2m_dst_buf_remove_by_buf() instead of v4l2_m2m_src_buf_remove_by_buf() Addresses-Coverity-ID: 1415317 Cc: Stanimir Varbanov

Re: [PATCH v2] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-22 Thread Rob Herring
On Tue, Aug 22, 2017 at 10:00 AM, Niklas Söderlund wrote: > Hi Rob, > > On 2017-08-22 09:49:35 -0500, Rob Herring wrote: >> On Mon, Aug 21, 2017 at 7:19 PM, Niklas Söderlund >> wrote: >> > Using CONFIG_OF_DYNAMIC=y uncovered

Re: adv7281m and rcar-vin problem

2017-08-22 Thread Niklas Söderlund
Hi Naman, On 2017-08-23 00:15:41 +0530, Naman Jain wrote: > Hi Niklas, > > adv7281m driver powers up the CSI transmitter in s_power(), which is > called before setting up of D-PHY layer of R-Car CSI-2 Receiver. > I shifted the part of code which enables CSI transmitter in adv7281m > (Low Power

Re: [PATCH v2 1/2] dt-bindings: media: Add Cadence MIPI-CSI2 RX Device Tree bindings

2017-08-22 Thread Cyprian Wronka
Hi Laurent, On 22/08/2017, 02:01, "Laurent Pinchart" wrote: EXTERNAL MAIL Hi Maxime, On Tuesday, 22 August 2017 11:53:20 EEST Maxime Ripard wrote: > On Mon, Aug 07, 2017 at 11:18:03PM +0300, Laurent Pinchart wrote: > > On

Re: adv7281m and rcar-vin problem

2017-08-22 Thread Naman Jain
Hi Niklas, adv7281m driver powers up the CSI transmitter in s_power(), which is called before setting up of D-PHY layer of R-Car CSI-2 Receiver. I shifted the part of code which enables CSI transmitter in adv7281m (Low Power state to High Speed state) to s_stream() - if (state->chip_info->flags

Re: [PATCH v2 1/3] dt: bindings: Document DT bindings for Analog devices as3645a

2017-08-22 Thread Jacek Anaszewski
Hi Sakari, Thanks for the update. On 08/19/2017 11:24 PM, Sakari Ailus wrote: > From: Sakari Ailus > > Signed-off-by: Sakari Ailus > --- > .../devicetree/bindings/leds/ams,as3645a.txt | 71 > ++ > 1 file changed,

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-08-22 Thread Maxime Ripard
Hi Yong, On Mon, Jul 31, 2017 at 11:16:40AM +0800, Yong wrote: > > > @@ -143,6 +143,7 @@ source "drivers/media/platform/am437x/Kconfig" > > > source "drivers/media/platform/xilinx/Kconfig" > > > source "drivers/media/platform/rcar-vin/Kconfig" > > > source

Re: [PATCH 1/4] i2c: busses: make i2c_adapter const

2017-08-22 Thread David Daney
On 08/19/2017 03:34 AM, Bhumika Goyal wrote: Make these const as they are only used in a copy operation. Done using Coccinelle. Signed-off-by: Bhumika Goyal i2c-octeon-platdrv.c and i2c-thunderx-pcidrv.c changes: Acked-by: David Daney Thanks.

Possible memory leak in cafe_ccic.ko

2017-08-22 Thread Anton Volkov
Hello. While searching for races in the Linux kernel I've come across "drivers/media/platform/marvell-ccic/cafe_ccic.ko" module. Here are questions that I came up with while analyzing results. Lines are given using the info from Linux v4.12. Consider the following case: Thread 1:

Re: [PATCH] [media] ddbridge: add IOCTLs

2017-08-22 Thread Daniel Scheller
Am Tue, 22 Aug 2017 16:05:21 +0200 schrieb Ralph Metzler : > Daniel Scheller writes: > > Am Sun, 20 Aug 2017 08:53:56 -0300 > > schrieb Mauro Carvalho Chehab : > > > > > Em Sun, 20 Aug 2017 13:08:55 +0200 > > > Daniel Scheller

Re: [PATCH v2] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-22 Thread Niklas Söderlund
Hi Rob, On 2017-08-22 09:49:35 -0500, Rob Herring wrote: > On Mon, Aug 21, 2017 at 7:19 PM, Niklas Söderlund > wrote: > > Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the usecount of the > > node being passed to of_fwnode_graph_get_port_parent().

Re: [PATCH v2] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-22 Thread Geert Uytterhoeven
Hi Rob, On Tue, Aug 22, 2017 at 4:49 PM, Rob Herring wrote: > On Mon, Aug 21, 2017 at 7:19 PM, Niklas Söderlund > wrote: >> Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the usecount of the >> node being passed to

Re: [PATCH v2] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-22 Thread Rob Herring
On Mon, Aug 21, 2017 at 7:19 PM, Niklas Söderlund wrote: > Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the usecount of the > node being passed to of_fwnode_graph_get_port_parent(). Preserve the > usecount by using of_get_parent() instead of

[PATCH v2 1/4] [media] stm32-dcmi: catch dma submission error

2017-08-22 Thread Hugues Fruchet
Test cookie return by dmaengine_submit() and return error if any. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/platform/stm32/stm32-dcmi.c

[PATCH v2 2/4] [media] stm32-dcmi: revisit control register handling

2017-08-22 Thread Hugues Fruchet
Simplify bits handling of DCMI_CR register. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/media/platform/stm32/stm32-dcmi.c

[PATCH v2 3/4] [media] stm32-dcmi: cleanup variable/fields namings

2017-08-22 Thread Hugues Fruchet
Uniformize "pixfmt" variables to "pix". Change "current_fmt" & "dcmi_fmt" variables to variables with "sd_" prefix to explicitly refer to subdev format. Signed-off-by: Hugues Fruchet --- drivers/media/platform/stm32/stm32-dcmi.c | 103 -- 1

[PATCH v2 4/4] [media] stm32-dcmi: g_/s_selection crop support

2017-08-22 Thread Hugues Fruchet
Implements g_/s_selection crop support by using DCMI crop hardware feature. User can first get the maximum supported resolution of the sensor by calling g_selection(V4L2_SEL_TGT_CROP_BOUNDS). Then user call to s_selection(V4L2_SEL_TGT_CROP) will reset sensor to its maximum resolution and crop

[PATCH v2 0/4] STM32 DCMI camera interface crop support

2017-08-22 Thread Hugues Fruchet
This patchset implements crop feature of Digital Camera Memory Interface (DCMI) of STMicroelectronics STM32 SoC series, allowing user to crop at pixel level inside sensor captured frame. This patchset follows discussions initiated from a first submission of DCMI crop support, see [1]. First part

[PATCH] [media] em28xx: calculate left volume level correctly

2017-08-22 Thread Colin King
From: Colin Ian King The calculation of the left volume looks suspect, the value of 0x1f - ((val << 8) & 0x1f) is always 0x1f. The debug prior to the assignemnt of value[1] prints the left volume setting using the calculation 0x1f - (val >> 8) & 0x1f which looks correct

Re: [PATCH] [media] ddbridge: add IOCTLs

2017-08-22 Thread Ralph Metzler
Daniel Scheller writes: > Am Sun, 20 Aug 2017 08:53:56 -0300 > schrieb Mauro Carvalho Chehab : > > > Em Sun, 20 Aug 2017 13:08:55 +0200 > > Daniel Scheller escreveu: > > > > > From: Daniel Scheller > > > > > >

Re: [PATCH 15/15] usb: make device_type const

2017-08-22 Thread Heikki Krogerus
On Sat, Aug 19, 2017 at 01:52:26PM +0530, Bhumika Goyal wrote: > Make this const as it is only stored in the type field of a device > structure, which is const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal Acked-by: Heikki Krogerus

[PATCH 1/4] [media] saa7146: constify videobuf_queue_ops structures

2017-08-22 Thread Arvind Yadav
videobuf_queue_ops are not supposed to change at runtime. All functions working with videobuf_queue_ops provided by work with const videobuf_queue_ops. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/media/common/saa7146/saa7146_vbi.c

[PATCH 0/4] constify videobuf_queue_ops structures

2017-08-22 Thread Arvind Yadav
videobuf_queue_ops are not supposed to change at runtime. All functions working with videobuf_queue_ops provided by work with const videobuf_queue_ops. So mark the non-const structs as const. Arvind Yadav (4): [PATCH 1/4] [media] saa7146: constify videobuf_queue_ops structures [PATCH 2/4]

[PATCH 4/4] [media] usb: constify videobuf_queue_ops structures

2017-08-22 Thread Arvind Yadav
videobuf_queue_ops are not supposed to change at runtime. All functions working with videobuf_queue_ops provided by work with const videobuf_queue_ops. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/media/usb/cx231xx/cx231xx-417.c |

[PATCH 3/4] [media] platform: constify videobuf_queue_ops structures

2017-08-22 Thread Arvind Yadav
videobuf_queue_ops are not supposed to change at runtime. All functions working with videobuf_queue_ops provided by work with const videobuf_queue_ops. So mark the non-const structs as const. Signed-off-by: Arvind Yadav ---

[PATCH 2/4] [media] pci: constify videobuf_queue_ops structures

2017-08-22 Thread Arvind Yadav
videobuf_queue_ops are not supposed to change at runtime. All functions working with videobuf_queue_ops provided by work with const videobuf_queue_ops. So mark the non-const structs as const. Signed-off-by: Arvind Yadav --- drivers/media/pci/bt8xx/bttv-driver.c | 2

Re: [PATCH v3 3/3] v4l: fwnode: Support generic parsing of graph endpoints in a single port

2017-08-22 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Friday, 18 August 2017 14:23:17 EEST Sakari Ailus wrote: > This is the preferred way to parse the endpoints. > > Signed-off-by: Sakari Ailus > --- > drivers/media/v4l2-core/v4l2-fwnode.c | 51

Re: [PATCH v3 2/3] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-08-22 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Friday, 18 August 2017 14:23:16 EEST Sakari Ailus wrote: > The current practice is that drivers iterate over their endpoints and > parse each endpoint separately. This is very similar in a number of > drivers, implement a generic function for the job.

Re: [PATCH v3 1/3] omap3isp: Drop redundant isp->subdevs field and ISP_MAX_SUBDEVS

2017-08-22 Thread Sakari Ailus
On Tue, Aug 22, 2017 at 03:30:22PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Friday, 18 August 2017 14:23:15 EEST Sakari Ailus wrote: > > struct omap3isp.subdevs field and ISP_MAX_SUBDEVS macro are both unused. > > Remove them. > > > > Signed-off-by: Sakari

[PATCH v4 3/3] v4l: fwnode: Support generic parsing of graph endpoints in a single port

2017-08-22 Thread Sakari Ailus
This is the preferred way to parse the endpoints. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-fwnode.c | 51 +++ include/media/v4l2-fwnode.h | 7 + 2 files changed, 58 insertions(+) diff --git

[PATCH v4 1/3] omap3isp: Drop redundant isp->subdevs field and ISP_MAX_SUBDEVS

2017-08-22 Thread Sakari Ailus
struct omap3isp.subdevs field and ISP_MAX_SUBDEVS macro are both unused. Remove them. Signed-off-by: Sakari Ailus --- drivers/media/platform/omap3isp/isp.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/platform/omap3isp/isp.h

[PATCH v4 2/3] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-08-22 Thread Sakari Ailus
The current practice is that drivers iterate over their endpoints and parse each endpoint separately. This is very similar in a number of drivers, implement a generic function for the job. Driver specific matters can be taken into account in the driver specific callback. Convert the omap3isp as

[PATCH v4 0/3] Unified fwnode endpoint parser

2017-08-22 Thread Sakari Ailus
Hi folks, We have a large influx of new, unmerged, drivers that are now parsing fwnode endpoints and each one of them is doing this a little bit differently. The needs are still exactly the same for the graph data structure is device independent. This is still a non-trivial task and the majority

Re: [PATCH v3 1/3] omap3isp: Drop redundant isp->subdevs field and ISP_MAX_SUBDEVS

2017-08-22 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Friday, 18 August 2017 14:23:15 EEST Sakari Ailus wrote: > struct omap3isp.subdevs field and ISP_MAX_SUBDEVS macro are both unused. > Remove them. > > Signed-off-by: Sakari Ailus The field and macro are still used, you only

Re: [PATCH v2 1/2] docs-rst: media: Document s_stream() video op usage for MC enabled devices

2017-08-22 Thread Sakari Ailus
Hi Hans, On 08/21/17 13:14, Hans Verkuil wrote: ... > +The ``.s_stream()`` op in :c:type:`v4l2_subdev_video_ops` is responsible > +for starting and stopping the stream on the sub-device it is called > +on. A device driver is only responsible for calling the ``.s_stream()`` > ops

Re: [PATCHv2 0/9] omapdrm: hdmi4: add CEC support

2017-08-22 Thread Tomi Valkeinen
Hi Hans, >> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 11/08/17 13:57, Tomi Valkeinen wrote: >> >>> I'm doing some testing with this series on my panda. One issue I see is >>> that when I unload the display

Re: [PATCH v2 1/2] dt-bindings: media: Add Cadence MIPI-CSI2 RX Device Tree bindings

2017-08-22 Thread Laurent Pinchart
Hi Maxime, On Tuesday, 22 August 2017 11:53:20 EEST Maxime Ripard wrote: > On Mon, Aug 07, 2017 at 11:18:03PM +0300, Laurent Pinchart wrote: > > On Thursday 20 Jul 2017 11:23:01 Maxime Ripard wrote: > >> The Cadence MIPI-CSI2 RX controller is a CSI2RX bridge that supports up > >> to 4 CSI-2

Re: [PATCH v2 1/2] dt-bindings: media: Add Cadence MIPI-CSI2 RX Device Tree bindings

2017-08-22 Thread Maxime Ripard
Hi Laurent, Thanks a lot for reviewing those patches. On Mon, Aug 07, 2017 at 11:18:03PM +0300, Laurent Pinchart wrote: > Hi Maxime, > > Thank you for the patch. > > On Thursday 20 Jul 2017 11:23:01 Maxime Ripard wrote: > > The Cadence MIPI-CSI2 RX controller is a CSI2RX bridge that supports

Re: [PATCH v2 1/2] docs-rst: media: Document s_stream() video op usage for MC enabled devices

2017-08-22 Thread Philipp Zabel
On Mon, 2017-08-21 at 11:01 -0300, Mauro Carvalho Chehab wrote: > Em Mon, 21 Aug 2017 15:52:17 +0200 > Hans Verkuil escreveu: > > > On 08/21/2017 02:07 PM, Mauro Carvalho Chehab wrote: > > > Em Mon, 21 Aug 2017 12:14:18 +0200 > > > Hans Verkuil escreveu:

[GIT PULL for 4.14] Fix fwnode lane-polarities property parsing

2017-08-22 Thread Sakari Ailus
Hi Mauro, Fwnode property parings was recently broken by a smatch warning fix. Fix this. Please pull. The following changes since commit 0779b8855c746c90b85bfe6e16d5dfa2a6a46655: media: ddbridge: fix semicolon.cocci warnings (2017-08-20 10:25:22 -0400) are available in the git repository

[GIT PULL for 4.14] DW9714 DT support

2017-08-22 Thread Sakari Ailus
Hi Mauro, This set adds Devicetree support for DW9714. Please pull. The following changes since commit ec0c3ec497cabbf3bfa03a9eb5edcc252190a4e0: media: ddbridge: split code into multiple files (2017-08-09 12:17:01 -0400) are available in the git repository at:

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-08-22 Thread Yong
On Tue, 22 Aug 2017 08:43:35 +0200 Hans Verkuil wrote: > On 08/22/2017 05:01 AM, Yong wrote: > > Hi Hans, > > > > On Mon, 21 Aug 2017 16:37:41 +0200 > > Hans Verkuil wrote: > > > >> Hi Yong, > >> > >> First two high-level comments before I start the

Re: [PATCH 3/3] media: atmel-isc: Add more format configurations

2017-08-22 Thread Yang, Wenyou
Hi Hans, On 2017/8/22 14:54, Hans Verkuil wrote: On 08/17/2017 09:16 AM, Wenyou Yang wrote: Add the configuration of formats: GREY, ARGB444, ARGB555 and ARGB32. Signed-off-by: Wenyou Yang --- drivers/media/platform/atmel/atmel-isc.c | 22 --

RE: [PATCH 1/3] media: atmel-isc: Not support RBG format from sensor.

2017-08-22 Thread Wenyou.Yang
Hi Hans, > -Original Message- > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: 2017年8月22日 15:00 > To: Wenyou Yang - A41535 ; Mauro Carvalho > Chehab > Cc: Nicolas Ferre - M43238 ; linux- >

cron job: media_tree daily build: ERRORS

2017-08-22 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Aug 22 08:34:26 CEST 2017 media-tree git hash:0779b8855c746c90b85bfe6e16d5dfa2a6a46655 media_build

Re: [PATCH 1/3] media: atmel-isc: Not support RBG format from sensor.

2017-08-22 Thread Hans Verkuil
On 08/22/2017 03:18 AM, Yang, Wenyou wrote: > Hi Hans, > > On 2017/8/21 22:07, Hans Verkuil wrote: >> On 08/17/2017 09:16 AM, Wenyou Yang wrote: >>> The 12-bit parallel interface supports the Raw Bayer, YCbCr, >>> Monochrome and JPEG Compressed pixel formats from the external >>> sensor, not

Re: [PATCH 3/3] media: atmel-isc: Add more format configurations

2017-08-22 Thread Hans Verkuil
On 08/17/2017 09:16 AM, Wenyou Yang wrote: > Add the configuration of formats: GREY, ARGB444, ARGB555 and ARGB32. > > Signed-off-by: Wenyou Yang > --- > > drivers/media/platform/atmel/atmel-isc.c | 22 -- > 1 file changed, 20 insertions(+), 2

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-08-22 Thread Hans Verkuil
On 08/22/2017 05:01 AM, Yong wrote: > Hi Hans, > > On Mon, 21 Aug 2017 16:37:41 +0200 > Hans Verkuil wrote: > >> Hi Yong, >> >> First two high-level comments before I start the review: >> >> 1) Can you provide the v4l2-compliance output? I can't merge this unless I >>see