Re: [PATCH v8 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-10-04 Thread Sakari Ailus
On Wed, Oct 04, 2017 at 05:06:21PM -0700, Leon Luo wrote: > The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. > It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface > is 4-lane MIPI CSI-2 running at 1.44Gbps each. > > This driver has been tested on Xilinx ZCU102 plat

Re: [PATCH v15 00/32] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS

2017-10-04 Thread Sakari Ailus
On Thu, Oct 05, 2017 at 12:50:19AM +0300, Sakari Ailus wrote: > Hi folks, > > I've dropped the full set from devicetree and linux-acpi lists; > let me know if you want it back. The entire set is posted to > linux-media list. Here's the diff between v14 and v15. The patches can b

cron job: media_tree daily build: ERRORS

2017-10-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Oct 5 05:00:07 CEST 2017 media-tree git hash:a8c779eb056e9874c6278151ade857c3ac227db9 media_build gi

[PATCH] staging/atomisp: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman Cc: Alan Cox Cc: Daeseok Youn Cc: Arnd Bergmann Cc: li

[PATCH] media/saa7146: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. This requires adding a pointer to hold the timer's target file, as there won't be a way to pass this in the f

[PATCH] media: saa7134: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Mauro Carvalho Chehab Cc: Sakari Ailus Cc: Sean Young Cc: Geliang Tang Cc: Hans Verkuil Cc: linux-m

[PATCH] media: saa7146: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Cc: Thomas Gleixner Signed-off

[PATCH] media: serial_ir: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Sean Young Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Cc: Thomas Gleixner Signed-off-b

[PATCH] input: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. One input_dev user hijacks the input_dev software autorepeat timer to perform its own repeat management. How

[PATCH v8 1/2] media:imx274 device tree binding file

2017-10-04 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo Acked-by: Sören Brinkmann Acked-by: Rob Herring --- v8: - no changes v7: - no changes v6: - no changes v5: - add 'port' and 'endpoint' information v4: - no changes v3: - remove redundant properties and references

[PATCH v8 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-10-04 Thread Leon Luo
The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface is 4-lane MIPI CSI-2 running at 1.44Gbps each. This driver has been tested on Xilinx ZCU102 platform with a Leopard LI-IMX274MIPI-FMC camera board. Support for the

[PATCH v15 05/32] v4l: async: Correctly serialise async sub-device unregistration

2017-10-04 Thread Sakari Ailus
The check whether an async sub-device is bound to a notifier was performed without list_lock held, making it possible for another process to unbind the async sub-device before the sub-device unregistration function proceeds to take the lock. Fix this by first acquiring the lock and then proceeding

[PATCH v15 25/32] v4l: fwnode: Add convenience function for parsing common external refs

2017-10-04 Thread Sakari Ailus
Add v4l2_fwnode_parse_reference_sensor_common for parsing common sensor properties that refer to adjacent devices such as flash or lens driver chips. As this is an association only, there's little a regular driver needs to know about these devices as such. Signed-off-by: Sakari Ailus Acked-by: H

[PATCH v15 04/32] v4l: async: Fix notifier complete callback error handling

2017-10-04 Thread Sakari Ailus
The notifier complete callback may return an error. This error code was simply returned to the caller but never handled properly. Move calling the complete callback function to the caller from v4l2_async_test_notify and undo the work that was done either in async sub-device or async notifier regis

[PATCH v15 17/32] v4l: async: Prepare for async sub-device notifiers

2017-10-04 Thread Sakari Ailus
Refactor the V4L2 async framework a little in preparation for async sub-device notifiers. This avoids making some structural changes in the patch actually implementing sub-device notifiers, making that patch easier to review. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/

[PATCH v15 10/32] rcar-vin: Use generic parser for parsing fwnode endpoints

2017-10-04 Thread Sakari Ailus
Instead of using a custom driver implementation, use v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints of the device. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-core.c | 107 +--

[PATCH v15 21/32] dt: bindings: Add lens-focus binding for image sensors

2017-10-04 Thread Sakari Ailus
The lens-focus property contains a phandle to the lens voice coil driver that is associated to the sensor; typically both are contained in the same camera module. Signed-off-by: Sakari Ailus Cc: Rob Herring Cc: devicet...@vger.kernel.org Acked-by: Pavel Machek Reviewed-by: Sebastian Reichel Ac

[PATCH v15 30/32] ov5670: Add support for flash and lens devices

2017-10-04 Thread Sakari Ailus
Parse async sub-devices related to the sensor by switching the async sub-device registration function. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/i2c/ov5670.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov5670.c b/drivers/media

[PATCH v15 02/32] v4l: async: Don't set sd->dev NULL in v4l2_async_cleanup

2017-10-04 Thread Sakari Ailus
v4l2_async_cleanup() is called when the async sub-device is unbound from the media device. As the pointer is set by the driver registering the async sub-device, leave the pointer as set by the driver. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-async.c | 1 - 1 file changed, 1 d

[PATCH v15 29/32] et8ek8: Add support for flash and lens devices

2017-10-04 Thread Sakari Ailus
Parse async sub-devices related to the sensor by switching the async sub-device registration function. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/i2c/et8ek8/et8ek8_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/et8ek8/et8

[PATCH v15 06/32] v4l: async: Use more intuitive names for internal functions

2017-10-04 Thread Sakari Ailus
Rename internal functions to make the names of the functions better describe what they do. Old nameNew name v4l2_async_test_notify v4l2_async_match_notify v4l2_async_belongs v4l2_async_find_match Signed-off-by: Sakari Ailus Acked-by: Hans Ver

[PATCH v15 08/32] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-10-04 Thread Sakari Ailus
Add two functions for parsing devices graph endpoints: v4l2_async_notifier_parse_fwnode_endpoints and v4l2_async_notifier_parse_fwnode_endpoints_by_port. The former iterates over all endpoints whereas the latter only iterates over the endpoints in a given port. The former is mostly useful for exis

[PATCH v15 07/32] v4l: async: Add V4L2 async documentation to the documentation build

2017-10-04 Thread Sakari Ailus
The V4L2 async wasn't part of the documentation build. Fix this. Signed-off-by: Sakari Ailus Reviewed-by: Niklas Söderlund Acked-by: Hans Verkuil Reviewed-by: Laurent Pinchart --- Documentation/media/kapi/v4l2-async.rst | 3 +++ Documentation/media/kapi/v4l2-core.rst | 1 + 2 files changed,

[PATCH v15 14/32] v4l: async: Introduce helpers for calling async ops callbacks

2017-10-04 Thread Sakari Ailus
Add three helper functions to call async operations callbacks. Besides simplifying callbacks, this allows async notifiers to have no ops set, i.e. it can be left NULL. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek --- drivers/media/v4l2-core/v4l2-async.c | 56 ++

[PATCH v15 16/32] v4l: async: Allow async notifier register call succeed with no subdevs

2017-10-04 Thread Sakari Ailus
The information on how many async sub-devices would be bindable to a notifier is typically dependent on information from platform firmware and it's not driver's business to be aware of that. Many V4L2 main drivers are perfectly usable (and useful) without async sub-devices and so if there aren't a

[PATCH v15 20/32] dt: bindings: Add a binding for flash LED devices associated to a sensor

2017-10-04 Thread Sakari Ailus
Camera flash drivers (and LEDs) are separate from the sensor devices in DT. In order to make an association between the two, provide the association information to the software. Signed-off-by: Sakari Ailus Cc: Rob Herring Cc: devicet...@vger.kernel.org Acked-by: Hans Verkuil Acked-by: Pavel Mac

[PATCH v15 01/32] v4l: async: Remove re-probing support

2017-10-04 Thread Sakari Ailus
Remove V4L2 async re-probing support. The re-probing support has been there to support cases where the sub-devices require resources provided by the main driver's hardware to function, such as clocks. Reprobing has allowed unbinding and again binding the main driver without explicilty unbinding th

[PATCH v15 13/32] v4l: async: Move async subdev notifier operations to a separate structure

2017-10-04 Thread Sakari Ailus
From: Laurent Pinchart The async subdev notifier .bound(), .unbind() and .complete() operations are function pointers stored directly in the v4l2_async_subdev structure. As the structure isn't immutable, this creates a potential security risk as the function pointers are mutable. To fix this, mo

[PATCH v15 22/32] v4l: fwnode: Move KernelDoc documentation to the header

2017-10-04 Thread Sakari Ailus
In V4L2 the practice is to have the KernelDoc documentation in the header and not in .c source code files. This consequently makes the V4L2 fwnode function documentation part of the Media documentation build. Also correct the link related function and argument naming in documentation and add an as

[PATCH v15 19/32] v4l: async: Ensure only unique fwnodes are registered to notifiers

2017-10-04 Thread Sakari Ailus
While registering a notifier, check that each newly added fwnode is unique, and return an error if it is not. Also check that a newly added notifier does not have the same fwnodes twice. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-async.c | 82 +++

[PATCH v15 31/32] ov13858: Add support for flash and lens devices

2017-10-04 Thread Sakari Ailus
Parse async sub-devices related to the sensor by switching the async sub-device registration function. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/i2c/ov13858.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov13858.c b/drivers/med

[PATCH v15 23/32] v4l: fwnode: Add a helper function for parsing generic references

2017-10-04 Thread Sakari Ailus
Add function v4l2_fwnode_reference_parse() for parsing them as async sub-devices. This can be done on e.g. flash or lens async sub-devices that are not part of but are associated with a sensor. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-fwnode.c | 69 +++

[PATCH v15 28/32] smiapp: Add support for flash and lens devices

2017-10-04 Thread Sakari Ailus
Parse async sub-devices related to the sensor by switching the async sub-device registration function. These types devices aren't directly related to the sensor, but are nevertheless handled by the smiapp driver due to the relationship of these component to the main part of the camera module --- t

[PATCH v15 24/32] v4l: fwnode: Add a helper function to obtain device / integer references

2017-10-04 Thread Sakari Ailus
v4l2_fwnode_reference_parse_int_prop() will find an fwnode such that under the device's own fwnode, it will follow child fwnodes with the given property-value pair and return the resulting fwnode. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-fwnode.c | 207 +++

[PATCH v15 15/32] v4l: async: Register sub-devices before calling bound callback

2017-10-04 Thread Sakari Ailus
Register the sub-device before calling the notifier's bound callback. Doing this the other way around is problematic as the struct v4l2_device has not assigned for the sub-device yet and may be required by the bound callback. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/

[PATCH v15 09/32] omap3isp: Use generic parser for parsing fwnode endpoints

2017-10-04 Thread Sakari Ailus
Instead of using a custom driver implementation, use v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints of the device. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Reviewed-by: Laurent Pinchart --- drivers/media/platform/omap3isp/isp.c | 121 +++---

[PATCH v15 11/32] omap3isp: Fix check for our own sub-devices

2017-10-04 Thread Sakari Ailus
We only want to link sub-devices that were bound to the async notifier the isp driver registered but there may be other sub-devices in the v4l2_device as well. Check for the correct async notifier. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek --- drivers/media/plat

[PATCH v15 32/32] arm: dts: omap3: N9/N950: Add flash references to the camera

2017-10-04 Thread Sakari Ailus
Add flash and indicator LED phandles to the sensor node. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek --- arch/arm/boot/dts/omap3-n9.dts | 1 + arch/arm/boot/dts/omap3-n950-n9.dtsi | 4 ++-- arch/arm/boot/dts/omap3-n950.dts | 1 + 3 files changed, 4 inser

[PATCH v15 26/32] v4l: fwnode: Add a convenience function for registering sensors

2017-10-04 Thread Sakari Ailus
Add a convenience function for parsing firmware for information on related devices using v4l2_async_notifier_parse_fwnode_sensor_common() registering the notifier and finally the async sub-device itself. This should be useful for sensor drivers that do not have device specific requirements related

[PATCH v15 18/32] v4l: async: Allow binding notifiers to sub-devices

2017-10-04 Thread Sakari Ailus
Registering a notifier has required the knowledge of struct v4l2_device for the reason that sub-devices generally are registered to the v4l2_device (as well as the media device, also available through v4l2_device). This information is not available for sub-device drivers at probe time. What this

[PATCH v15 12/32] omap3isp: Print the name of the entity where no source pads could be found

2017-10-04 Thread Sakari Ailus
If no source pads are found in an entity, print the name of the entity. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek --- drivers/media/platform/omap3isp/isp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/omap3isp/is

[PATCH v15 27/32] dt: bindings: smiapp: Document lens-focus and flash-leds properties

2017-10-04 Thread Sakari Ailus
Document optional lens-focus and flash-leds properties for the smiapp driver. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek --- Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/

[PATCH v15 03/32] v4l: async: fix unbind error in v4l2_async_notifier_unregister()

2017-10-04 Thread Sakari Ailus
From: Niklas Söderlund The call to v4l2_async_cleanup() will set sd->asd to NULL so passing it to notifier->unbind() have no effect and leaves the notifier confused. Call the unbind() callback prior to cleaning up the subdevice to avoid this. Signed-off-by: Niklas Söderlund Signed-off-by: Sakar

[PATCH v15 00/32] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS

2017-10-04 Thread Sakari Ailus
Hi folks, I've dropped the full set from devicetree and linux-acpi lists; let me know if you want it back. The entire set is posted to linux-media list. We have a large influx of new, unmerged, drivers that are now parsing fwnode endpoints and each one of them is doing thi

Re: [PATCH v6 2/2] media: rc: Add driver for tango HW IR decoder

2017-10-04 Thread Sean Young
On Wed, Oct 04, 2017 at 06:00:47PM +0200, Marc Gonzalez wrote: > On 26/09/2017 10:51, Marc Gonzalez wrote: > > > From: Mans Rullgard > > > > The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. > > > > Signed-off-by: Marc Gonzalez > > --- > > Changes between v5 and v6 > > * Move "regist

Re: [PATCH 2/4] media: dt-bindings: Add bindings for TDA1997X

2017-10-04 Thread Rob Herring
On Fri, Sep 22, 2017 at 03:24:11PM -0700, Tim Harvey wrote: > Signed-off-by: Tim Harvey You need a commit msg. Otherwise, maintainers get publicly shamed. > --- > .../devicetree/bindings/media/i2c/tda1997x.txt | 159 > + > 1 file changed, 159 insertions(+) > create mod

Re: [PATCH v3 10/15] [media] vb2: add 'ordered' property to queues

2017-10-04 Thread Gustavo Padovan
On Mon, 2017-10-02 at 14:43 +0100, Brian Starkey wrote: > Hi, > > On Thu, Sep 07, 2017 at 03:42:21PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > For explicit synchronization (and soon for HAL3/Request API) we > > need > > the v4l2-driver to guarantee the ordering in which the

Re: [PATCH v3 02/15] [media] vb2: add explicit fence user API

2017-10-04 Thread Gustavo Padovan
On Mon, 2017-10-02 at 14:42 +0100, Brian Starkey wrote: > Hi, > > On Thu, Sep 07, 2017 at 03:42:13PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Turn the reserved2 field into fence_fd that we will use to send > > an in-fence to the kernel and return an out-fence from the kern

Re: [PATCH v3 00/15] V4L2 Explicit Synchronization support

2017-10-04 Thread Gustavo Padovan
Hi Brian, On Mon, 2017-10-02 at 14:41 +0100, Brian Starkey wrote: > Hi Gustavo, > > On Thu, Sep 07, 2017 at 03:42:11PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Hi, > > > > Refer to the documentation on the first patch for the details. The > > previous > > iteration is he

Re: [ANN] Call for topics for the media mini-summit on Friday Oct 27 in Prague

2017-10-04 Thread Gustavo Padovan
Hi Hans, On Fri, Sep 1, 2017 at 6:46 AM, Hans Verkuil wrote: > Hi all, > > We are organizing a media mini-summit on Friday October 27 in Prague, > co-located > with the ELCE conference: > > http://events.linuxfoundation.org/events/embedded-linux-conference-europe > > This is a call for topics

IT MAINTENANCE

2017-10-04 Thread IT service Team
ITS service maintenance team will be working online today for cleanup. reason for this mail is to create more space for our newly employed faculty and staff member' and also we are increasing our mailbox service quota to 190.06GB for more space and to empty all spam and junk folder. all our curr

Re: [PATCH 07/19] lirc_dev: remove kmalloc in lirc_dev_fop_read()

2017-10-04 Thread Mauro Carvalho Chehab
Em Sun, 25 Jun 2017 14:31:50 +0200 David Härdeman escreveu: > lirc_zilog uses a chunk_size of 2 and ir-lirc-codec uses sizeof(int). > > Therefore, using stack memory should be perfectly fine. > > Signed-off-by: David Härdeman > --- > drivers/media/rc/lirc_dev.c |8 +--- > 1 file chang

Re: [PATCH v6 2/2] media: rc: Add driver for tango HW IR decoder

2017-10-04 Thread Marc Gonzalez
On 26/09/2017 10:51, Marc Gonzalez wrote: > From: Mans Rullgard > > The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. > > Signed-off-by: Marc Gonzalez > --- > Changes between v5 and v6 > * Move "register fields" macros to top of file > * Restore IRQ pending writes > --- > drivers/me

Re: Regression on 4.10 with Logitech Quickcam Sphere

2017-10-04 Thread Florian Echtler
Hello again, solved it myself, posting here for the record. Solution is to install uvcdynctrl and running uvcdynctrl -i /usr/share/uvcdynctrl/data/046d/logitech.xml And voila, custom controls back again. Not well documented, but hey. Best regards, Florian On Sun, 1 Oct 2017, Florian Echtler

[PATCH] [STABLE-4.13] [media] imx-media-of: avoid uninitialized variable warning

2017-10-04 Thread Arnd Bergmann
Replaces upstream commit 0b2e9e7947e7 ("media: staging/imx: remove confusing IS_ERR_OR_NULL usage") We get a harmless warning about a potential uninitialized variable use in the driver: drivers/staging/media/imx/imx-media-of.c: In function 'of_parse_subdev': drivers/staging/media/imx/imx-media-of

Re: [PATCH v7 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-10-04 Thread Sakari Ailus
Hi Leon, One more question below. On Mon, Oct 02, 2017 at 01:26:49PM -0700, Leon Luo wrote: ... > +/* > + * imx274_set_frame_interval - Function called when setting frame interval > + * @priv: Pointer to device structure > + * @frame_interval: Variable for frame interval > + * > + * Change frame

Re: [PATCH v10 00/24] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS

2017-10-04 Thread Sakari Ailus
Hi Rafael, On Tue, Oct 03, 2017 at 02:04:50AM +0200, Rafael J. Wysocki wrote: > Hi, > > On Mon, Sep 11, 2017 at 9:59 AM, Sakari Ailus > wrote: > > Hi folks, > > > > We have a large influx of new, unmerged, drivers that are now parsing > > fwnode endpoints and each one of them is doing this a lit

Re: [PATCH v2] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-10-04 Thread Sakari Ailus
Hi Rob, On Tue, Oct 03, 2017 at 08:40:10AM -0500, Rob Herring wrote: > On Sun, Aug 27, 2017 at 5:40 PM, Sakari Ailus > wrote: > > Hi Rob, > > > > On Tue, Aug 22, 2017 at 02:42:10PM -0500, Rob Herring wrote: > >> On Tue, Aug 22, 2017 at 10:00 AM, Niklas Söderlund > >> wrote: > >> > Hi Rob, > >> >

[PATCH v3 03/17] docs: kernel-doc.rst: improve function documentation section

2017-10-04 Thread Mauro Carvalho Chehab
Move its contents to happen earlier and improve the description of return values, adding a subsection to it. Most of the contents there came from kernel-doc-nano-HOWTO.txt. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 100 - 1

[PATCH v3 14/17] scripts: kernel-doc: print the declaration name on warnings

2017-10-04 Thread Mauro Carvalho Chehab
The logic at create_parameterlist()'s ancillary push_parameter() function has already a way to output the declaration name, with would help to discover what declaration is missing. However, currently, the logic is utterly broken, as it uses the var $type with a wrong meaning. With the current code

[PATCH v3 06/17] docs: kernel-doc.rst: add documentation about man pages

2017-10-04 Thread Mauro Carvalho Chehab
kernel-doc-nano-HOWTO.txt has a chapter about man pages production. While we don't have a working "make manpages" target, add it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 34 ++ 1 file changed, 34 insertions(+) diff --git

[PATCH v3 12/17] scripts: kernel-doc: parse next structs/unions

2017-10-04 Thread Mauro Carvalho Chehab
There are several places within the Kernel tree with nested structs/unions, like this one: struct ingenic_cgu_clk_info { const char *name; enum { CGU_CLK_NONE = 0, CGU_CLK_EXT = BIT(0), CGU_CLK_PLL = BIT(1), CGU_CLK_GATE = BIT(2), CGU_CLK_MUX = BIT(3),

[PATCH v3 09/17] scripts: kernel-doc: improve argument handling

2017-10-04 Thread Mauro Carvalho Chehab
Right now, if one uses "--rst" instead of "-rst", it just ignore the argument and produces a man page. Change the logic to accept both "-cmd" and "--cmd". Also, if "cmd" doesn't exist, print the usage information and exit. Signed-off-by: Mauro Carvalho Chehab --- scripts/kernel-doc | 34

[PATCH v3 15/17] scripts: kernel-doc: handle nested struct function arguments

2017-10-04 Thread Mauro Carvalho Chehab
Function arguments are different than usual ones. So, an special logic is needed in order to handle such arguments on nested structs. Signed-off-by: Mauro Carvalho Chehab --- scripts/kernel-doc | 38 ++ 1 file changed, 26 insertions(+), 12 deletions(-) diff -

[PATCH v3 00/17] kernel-doc: add supported to document nested structs/

2017-10-04 Thread Mauro Carvalho Chehab
Right now, it is not possible to document nested struct and nested unions. kernel-doc simply ignore them. Add support to document them. Patches 1 to 6 improve kernel-doc documentation to reflect what kernel-doc currently supports and import some stuff from the old kernel-doc-nano-HOWTO.txt. Pat

[PATCH v3 01/17] docs: kernel-doc.rst: better describe kernel-doc arguments

2017-10-04 Thread Mauro Carvalho Chehab
Add a new section to describe kernel-doc arguments, adding examples about how identation should happen, as failing to do that causes Sphinx to do the wrong thing. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 44 +++--- 1 file chang

[PATCH v3 11/17] scripts: kernel-doc: replace tabs by spaces

2017-10-04 Thread Mauro Carvalho Chehab
Sphinx has a hard time dealing with tabs, causing it to misinterpret paragraph continuation. As we're now mainly focused on supporting ReST output, replace tabs by spaces, in order to avoid troubles when the output is parsed by Sphinx. Signed-off-by: Mauro Carvalho Chehab --- scripts/kernel-doc

[PATCH v3 08/17] scripts: kernel-doc: get rid of unused output formats

2017-10-04 Thread Mauro Carvalho Chehab
Since there isn't any docbook code anymore upstream, we can get rid of several output formats: - docbook/xml, html, html5 and list formats were used by the old build system; - As ReST is text, there's not much sense on outputting on a different text format. After this patch, only man and rst

[PATCH v3 04/17] docs: kernel-doc.rst: improve structs chapter

2017-10-04 Thread Mauro Carvalho Chehab
There is a mess on this chapter: it suggests that even enums and unions should be documented with "struct". That's not the way it should be ;-) Fix it and move it to happen earlier. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 48 +---

[PATCH v3 17/17] w1_netlink.h: add support for nested structs

2017-10-04 Thread Mauro Carvalho Chehab
Now that kernel-doc can hanle nested structs/unions, describe such fields at w1_netlink_message_types. Acked-by: Evgeniy Polyakov Signed-off-by: Mauro Carvalho Chehab --- drivers/w1/w1_netlink.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/w1/w1_netlink.h b/d

[PATCH v3 02/17] docs: kernel-doc.rst: improve private members description

2017-10-04 Thread Mauro Carvalho Chehab
The private members section can now be moved to be together with the arguments section. Move it there and add an example about the usage of public: Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 56 ++ 1 file changed, 30 insertio

[PATCH v3 07/17] docs: get rid of kernel-doc-nano-HOWTO.txt

2017-10-04 Thread Mauro Carvalho Chehab
Everything there is already described at Documentation/doc-guide/kernel-doc.rst. So, there's no reason why to keep it anymore. Signed-off-by: Mauro Carvalho Chehab --- Documentation/00-INDEX | 2 - Documentation/kernel-doc-nano-HOWTO.txt | 322

[PATCH v3 05/17] docs: kernel-doc.rst: improve typedef documentation

2017-10-04 Thread Mauro Carvalho Chehab
Add documentation about typedefs for function prototypes and move it to happen earlier. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/Documentation/doc-guide/k

[PATCH v3 13/17] scripts: kernel-doc: get rid of $nested parameter

2017-10-04 Thread Mauro Carvalho Chehab
The check_sections() function has a $nested parameter, meant to identify when a nested struct is present. As we now have a logic that handles it, get rid of such parameter. Suggested-by: Markus Heiser Signed-off-by: Mauro Carvalho Chehab --- scripts/kernel-doc | 19 --- 1 file c

[PATCH v3 16/17] scripts: kernel-doc: improve nested logic to handle multiple identifiers

2017-10-04 Thread Mauro Carvalho Chehab
It is possible to use nested structs like: struct { struct { void *arg1; } st1, st2, *st3, st4; }; Handling it requires to split each parameter. Change the logic to allow such definitions. In order to test the new nested logic, the following file was used to test

[PATCH v3 10/17] scripts: kernel-doc: change default to ReST format

2017-10-04 Thread Mauro Carvalho Chehab
Right now, if kernel-doc is called without arguments, it defaults to man pages. IMO, it makes more sense to default to ReST, as this is the output that it is most used nowadays, and it easier to check if everything got parsed fine on an enriched text mode format. Signed-off-by: Mauro Carvalho Cheh

Re: [PATCH] [media] ov5645: I2C address change

2017-10-04 Thread Laurent Pinchart
CC'ing the I2C mainling list and the I2C maintainer. On Wednesday, 4 October 2017 13:30:08 EEST Sakari Ailus wrote: > Hi Todor, > > On Mon, Oct 02, 2017 at 04:28:45PM +0300, Todor Tomov wrote: > > As soon as the sensor is powered on, change the I2C address to the one > > specified in DT. This all

Re: [PATCH] [media] ov5645: I2C address change

2017-10-04 Thread Sakari Ailus
Hi Todor, On Mon, Oct 02, 2017 at 04:28:45PM +0300, Todor Tomov wrote: > As soon as the sensor is powered on, change the I2C address to the one > specified in DT. This allows to use multiple physical sensors connected > to the same I2C bus. > > Signed-off-by: Todor Tomov The smiapp driver does

Re: [PATCH] [media] ov5645: I2C address change (fwd)

2017-10-04 Thread Todor Tomov
Hello, On 4.10.2017 12:06, Julia Lawall wrote: > Hello, > > It seems that an unlock is missing on line 764. Yes, this is true. I'll add an unlock there. Thank you for noticing this. Best regards, Todor > > julia > > -- Forwarded message -- > Date: Wed, 4 Oct 2017 05:59:09 +0

Re: platform: coda: how to use firmware-imx binary releases?

2017-10-04 Thread Philipp Zabel
Hi Martin, On Wed, 2017-10-04 at 10:44 +0200, Martin Kepplinger wrote: > Hi, > > Commit > >  be7f1ab26f42 media: coda: mark CODA960 firmware versions 2.3.10 and  > 3.1.1 as supported > > says firmware version 3.1.1 revision 46072 is contained in  > "firmware-imx-5.4.bin", that's probably >

Re: [PATCH] [media] ov5645: I2C address change (fwd)

2017-10-04 Thread Julia Lawall
Hello, It seems that an unlock is missing on line 764. julia -- Forwarded message -- Date: Wed, 4 Oct 2017 05:59:09 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH] [media] ov5645: I2C address change CC: kbuild-...@01.org In-Reply-To: <1506

platform: coda: how to use firmware-imx binary releases?

2017-10-04 Thread Martin Kepplinger
Hi, Commit be7f1ab26f42 media: coda: mark CODA960 firmware versions 2.3.10 and 3.1.1 as supported says firmware version 3.1.1 revision 46072 is contained in "firmware-imx-5.4.bin", that's probably sha1 78a416ae88ff01420260205ce1d567f60af6847e firmware-imx-5.4.bin How do I use th

Re: [PATCH 4/7] media: exynos4-is: Remove dependency on obsolete SoC support

2017-10-04 Thread Krzysztof Kozlowski
On Wed, Oct 4, 2017 at 8:38 AM, Marek Szyprowski wrote: > Support for Exynos4212 SoCs has been removed by commit bca9085e0ae9 ("ARM: > dts: exynos: remove Exynos4212 support (dead code)"), so there is no need > to keep remaining dead code related to this SoC version. > > Signed-off-by: Marek Szypr