Re: [PATCH] media: ov13858: select V4L2_FWNODE

On Tue, Nov 28, 2017 at 11:38:00AM +0100, Arnd Bergmann wrote: > v4l2_async_register_subdev_sensor_common() is only provided when > CONFIG_V4L2_FWNODE is enabled, otherwise we get a link failure: > > drivers/media/i2c/ov13858.o: In function `ov13858_probe': > ov13858.c:(.text+0xf74): undefined

Re: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Em Wed, 22 Nov 2017 13:17:14 +0900 "Takiguchi, Yasunari" escreveu: Hi Takiguchi-san, > Hi, all > > I sent the patch series of Sony CXD2880 DVB-T2/T tuner + demodulator driver > version 4 on 13th/Oct. > I'd like to get better understanding of current review status

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Nov 29 05:00:19 CET 2017 media-tree git hash:04226916d2360f56d57ad00bc48d2d1854d1e0b0 media_build

Re: [PATCH v2 1/3] media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings.

On Tue, Nov 28, 2017 at 11:33:37PM +, Jeremy Sowden wrote: > On 2017-11-28, at 17:15:24 +0300, Dan Carpenter wrote: > > On Mon, Nov 27, 2017 at 12:44:48PM +, Jeremy Sowden wrote: > > > The "address" member of struct ia_css_host_data is a > > > pointer-to-char, so define default as NULL. >

Re: [PATCH v2 1/3] media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings.

On 2017-11-28, at 17:15:24 +0300, Dan Carpenter wrote: > On Mon, Nov 27, 2017 at 12:44:48PM +, Jeremy Sowden wrote: > > The "address" member of struct ia_css_host_data is a > > pointer-to-char, so define default as NULL. > > > > --- > >

[PATCHv2 1/4] staging: add missing blank line after declarations in atomisp-ov5693

Fix "Missing a blank line after declarations" warning reported by checkpatch. Signed-off-by: Riccardo Schirone --- drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c | 13 + 1 file changed, 13 insertions(+) diff --git

[PATCHv2 0/4] fix some checkpatch style issues in atomisp driver

This patch series fixes some coding style issues in atomisp driver reported by checkpatch, like: missing blank lines after declarations, comments style, comparisons and indentation. It is based on next-20171128. Changes since v1: - Add commit message to first patch as reported by Jacopo Mondi

[PATCHv2 4/4] staging: fix indentation in atomisp-ov5693

Fix "suspect code indent for conditional statements" checkpatch issue Signed-off-by: Riccardo Schirone --- drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCHv2 2/4] staging: improve comments usage in atomisp-ov5693

- Fix "Block comments use a trailing */ on a separate line" checkpatch issue - Fix "Block comments use * on subsequent lines" checkpatch issue Signed-off-by: Riccardo Schirone --- .../media/atomisp/i2c/ov5693/atomisp-ov5693.c | 38 ++ 1 file

[PATCHv2 3/4] staging: improves comparisons readability in atomisp-ov5693

Fix "Comparisons should place the constant on the right side of the test" checkpatch issue. Signed-off-by: Riccardo Schirone --- drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [GIT PULL] SAA716x DVB driver

Em Mon, 25 Sep 2017 00:17:00 +0200 Soeren Moch escreveu: > > What I'm saying is that, > > if we're adding it on staging, we need to have a plan to reimplement > > it to whatever API replaces the DVB video API, as this API likely > > won't stay upstream much longer. > AFAIK it is

[PATCH Resend] staging: media: lirc: style fix - replace hard-coded function names

This patch fixes the remaining coding style warnings in the lirc module. Instead of hard coding the function name the __func__ variable should be used. It fixes the following checkpatch.pl warning: WARNING: Prefer using '"%s...", __func__' to using 'read', this function's name, in a string

Re: [PATCH 2/3 v7] uvcvideo: add extensible device information

Hi Laurent, Thanks for reviewing. On Tue, 28 Nov 2017, Laurent Pinchart wrote: > Hi Guennadi, > > Thank you for the patch. > > On Wednesday, 8 November 2017 18:00:13 EET Guennadi Liakhovetski wrote: > > From: Guennadi Liakhovetski > > > > Currently the UVC

Re: [PATCH v1 3/4] media: ov5640: add support of DVP parallel interface

Thanks Sakari for review, On 11/24/2017 03:06 PM, Sakari Ailus wrote: > Hi Hugues, > > On Thu, Nov 16, 2017 at 02:41:41PM +0100, Hugues Fruchet wrote: >> @@ -2185,7 +2262,11 @@ static int ov5640_s_stream(struct v4l2_subdev *sd, >> int enable) >> goto out; >>

Re: [PATCH 2/3 v7] uvcvideo: add extensible device information

Hi Guennadi, Thank you for the patch. On Wednesday, 8 November 2017 18:00:13 EET Guennadi Liakhovetski wrote: > From: Guennadi Liakhovetski > > Currently the UVC driver assigns a quirk bitmask to the .driver_info > field of struct usb_device_id. This patch

Re: [PATCH v1 4/4] media: ov5640: add support of RGB565 and YUYV formats

Thanks for review Sakari, On 11/24/2017 03:09 PM, Sakari Ailus wrote: > Hi Hugues, > > On Thu, Nov 16, 2017 at 02:41:42PM +0100, Hugues Fruchet wrote: >> Add RGB565 (LE & BE) and YUV422 YUYV format in addition >> to existing YUV422 UYVY format. >> >> Signed-off-by: Hugues Fruchet

Re: [linux-sunxi] Cedrus driver

Hi, On Tue, Nov 28, 2017 at 03:51:14PM +0100, Thomas van Kleef wrote: > On 28-11-17 13:26, Maxime Ripard wrote: > > On Tue, Nov 28, 2017 at 12:20:59PM +0100, Thomas van Kleef wrote: > >>> So, I have been rebasing to 4.14.0 and have the cedrus driver working. > >> I have pulled linux-mainline

Re: [PATCH v6 0/9] i2c: document DMA handling and add helpers for it

On Mon, Nov 27, 2017 at 07:51:16PM +0100, Wolfram Sang wrote: > On Wed, Nov 08, 2017 at 10:50:37PM +, Mark Brown wrote: > > We pretty much assume everything is DMA safe already, the majority of > > transfers go to/from kmalloc()ed scratch buffers so actually are DMA > > safe but for bulk

Re: [PATCH 1/3 v7] V4L: Add a UVC Metadata format

Hi Laurent, Thanks for the review. On Tue, 28 Nov 2017, Laurent Pinchart wrote: > Hi Guennadi, > > Thank you for the patch. > > Overall this looks good to me. Please see below for one small comment. Yes, looks good to me, feel free to use your wording. Thanks Guennadi > On Wednesday, 8

Re: [PATCH 1/3 v7] V4L: Add a UVC Metadata format

Hi Guennadi, Thank you for the patch. Overall this looks good to me. Please see below for one small comment. On Wednesday, 8 November 2017 18:00:12 EET Guennadi Liakhovetski wrote: > From: Guennadi Liakhovetski > > Add a pixel format, used by the UVC driver to

Re: [linux-sunxi] Cedrus driver

Il 28/11/2017 16:17, Maxime Ripard ha scritto: On Tue, Nov 28, 2017 at 02:12:31PM +0100, Giulio Benetti wrote: And really, just develop against 4.14. sunxi-next is rebased, and it's just not something you can base some work on. Where do we can work on then? Should Thomas setup his own github

Re: [linux-sunxi] Cedrus driver

On Tue, Nov 28, 2017 at 02:12:31PM +0100, Giulio Benetti wrote: > > > > And really, just develop against 4.14. sunxi-next is rebased, and it's > > > > just not something you can base some work on. > > > > > > Where do we can work on then? > > > Should Thomas setup his own github repo? > > > What

Re: [linux-sunxi] Cedrus driver

On 28-11-17 13:26, Maxime Ripard wrote: > On Tue, Nov 28, 2017 at 12:20:59PM +0100, Thomas van Kleef wrote: >>> So, I have been rebasing to 4.14.0 and have the cedrus driver working. >> I have pulled linux-mainline 4.14.0. Then pulled the requests2 branch from >> Hans >> Verkuil's media_tree. I

Re: [PATCH v2 1/3] media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings.

On Mon, Nov 27, 2017 at 12:44:48PM +, Jeremy Sowden wrote: > The "address" member of struct ia_css_host_data is a pointer-to-char, so > define default as NULL. > > Signed-off-by: Jeremy Sowden > --- > .../css2400/runtime/isp_param/interface/ia_css_isp_param_types.h

Re: [PATCH] media: i2c: adv748x: Restore full DT paths in kernel messages

Hi Geert, Thanks for the patch. On 28/11/17 13:01, Geert Uytterhoeven wrote: > As of_node_full_name() now returns only the basename, the endpoint > information printed became useless: > > adv748x 4-0070: Endpoint endpoint on port 7 > adv748x 4-0070: Endpoint endpoint on port 8 >

Re: [PATCH v5 1/2] media: ov7740: Document device tree bindings

On Tue, Nov 28, 2017 at 01:22:58PM +0800, Wenyou Yang wrote: > Add the device tree binding documentation for the ov7740 sensor driver. > > Signed-off-by: Wenyou Yang > --- > > Changes in v5: None > Changes in v4: None > Changes in v3: > - Explicitly document the

Re: [PATCH] media: i2c: adv748x: Restore full DT paths in kernel messages

Hi Geert, Thanks for your patch. On 2017-11-28 14:01:24 +0100, Geert Uytterhoeven wrote: > As of_node_full_name() now returns only the basename, the endpoint > information printed became useless: > > adv748x 4-0070: Endpoint endpoint on port 7 > adv748x 4-0070: Endpoint endpoint on port

Re: [PATCH v2 2/4] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

On 2017-11-16 18:22:49 +, Fabrizio Castro wrote: > Add compatible strings for r8a7743 and r8a7745. No driver change > is needed as "renesas,rcar-gen2-vin" will activate the right code. > However, it is good practice to document compatible strings for the > specific SoC as this allows SoC

Re: [PATCH v2 1/4] dt-bindings: media: rcar_vin: Reverse SoC part number list

On 2017-11-16 18:22:48 +, Fabrizio Castro wrote: > Change the sorting of the part numbers from descending to ascending to > match with other documentation. > > Signed-off-by: Fabrizio Castro > Reviewed-by: Biju Das Acked-by: Niklas

Re: [PATCH] staging/media: lirc: style fix - replace hard-coded function names

On Sun, Nov 26, 2017 at 08:49:42PM +0100, Martin Homuth wrote: > This patch fixes the remaining coding style warnings in the lirc module. > > It fixes the following checkpatch.pl warning: > > WARNING: Prefer using '"%s...", __func__' to using 'read', this > function's name, in a string > >From

Re: [linux-sunxi] Cedrus driver

Il 28/11/2017 14:07, Maxime Ripard ha scritto: On Tue, Nov 28, 2017 at 02:03:43PM +0100, Giulio Benetti wrote: Hi, Il giorno 28 nov 2017, alle ore 13:52, Maxime Ripard ha scritto: On Tue, Nov 28, 2017 at 12:54:08PM +0100, Giulio Benetti wrote: Should I be

Re: [linux-sunxi] Cedrus driver

On Tue, Nov 28, 2017 at 02:03:43PM +0100, Giulio Benetti wrote: > Hi, > > > Il giorno 28 nov 2017, alle ore 13:52, Maxime Ripard > > ha scritto: > > > > On Tue, Nov 28, 2017 at 12:54:08PM +0100, Giulio Benetti wrote: > > Should I be working in sunxi-next I

Re: [linux-sunxi] Cedrus driver

Hi, > Il giorno 28 nov 2017, alle ore 13:52, Maxime Ripard > ha scritto: > > On Tue, Nov 28, 2017 at 12:54:08PM +0100, Giulio Benetti wrote: > Should I be working in sunxi-next I wonder? Yes, this is the best way, cedrus is very specific to

[PATCH] media: i2c: adv748x: Restore full DT paths in kernel messages

As of_node_full_name() now returns only the basename, the endpoint information printed became useless: adv748x 4-0070: Endpoint endpoint on port 7 adv748x 4-0070: Endpoint endpoint on port 8 adv748x 4-0070: Endpoint endpoint on port 10 adv748x 4-0070: Endpoint endpoint on port 11

Re: [linux-sunxi] Cedrus driver

On Tue, Nov 28, 2017 at 12:54:08PM +0100, Giulio Benetti wrote: > > > > Should I be working in sunxi-next I wonder? > > > > > > Yes, this is the best way, cedrus is very specific to sunxi. > > > So before working on mainline, I think the best is to work un sunxi-next > > > branch. > > > > Is the

Re: [linux-sunxi] Cedrus driver

Hi Giulio On 28-11-17 12:54, Giulio Benetti wrote: > Hi Thomas, > > Il 28/11/2017 12:29, Thomas van Kleef ha scritto: >> Hi, >> >> On 28-11-17 12:26, Giulio Benetti wrote: >>> Hi Thomas, >>> >>> Il 28/11/2017 12:20, Thomas van Kleef ha scritto: On 28-11-17 10:50, Giulio Benetti wrote: >

[PATCH v3 1/2] media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings.

The "address" member of struct ia_css_host_data is a pointer-to-char, so define default as NULL. Signed-off-by: Jeremy Sowden --- .../css2400/runtime/isp_param/interface/ia_css_isp_param_types.h| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 0/3] Sparse fixes for the Atom ISP Staging Driver

Fixed some sparse warnings in the Atom ISP staging driver. This time with longer commit messages. :) I've chosen to ignore checkpatch.pl's suggestion to change the types of the arrays in the second patch from int16_t to s16. Jeremy Sowden (2): media: staging: atomisp: fix for sparse "using

Re: [linux-sunxi] Cedrus driver

On Tue, Nov 28, 2017 at 12:20:59PM +0100, Thomas van Kleef wrote: > > So, I have been rebasing to 4.14.0 and have the cedrus driver working. > I have pulled linux-mainline 4.14.0. Then pulled the requests2 branch from > Hans > Verkuil's media_tree. I have a patch available of the merge between

Re: [PATCH v5 2/2] media: i2c: Add the ov7740 image sensor driver

Hi Wenyou, Thanks for the patch. Some comments below. On Tue, Nov 28, 2017 at 01:22:59PM +0800, Wenyou Yang wrote: > The ov7740 (color) image sensor is a high performance VGA CMOS > image snesor, which supports for output formats: RAW RGB and YUV > and image sizes: VGA, and QVGA, CIF and any

[PATCH] media: ov13858: select V4L2_FWNODE

v4l2_async_register_subdev_sensor_common() is only provided when CONFIG_V4L2_FWNODE is enabled, otherwise we get a link failure: drivers/media/i2c/ov13858.o: In function `ov13858_probe': ov13858.c:(.text+0xf74): undefined reference to `v4l2_async_register_subdev_sensor_common' This adds a

Re: [linux-sunxi] Cedrus driver

Hi Thomas, Il 28/11/2017 12:29, Thomas van Kleef ha scritto: Hi, On 28-11-17 12:26, Giulio Benetti wrote: Hi Thomas, Il 28/11/2017 12:20, Thomas van Kleef ha scritto: On 28-11-17 10:50, Giulio Benetti wrote: Hi Maxime, Il 28/11/2017 09:35, Maxime Ripard ha scritto: On Tue, Nov 28, 2017

[PATCH] media: dvb_usb_pctv452e: module refcount changes were unbalanced

dvb_frontend will call dvb_detach for: - stb0899_detach in dvb_frontend_release and - stb0899_release in __dvb_frontend_free But we only do dvb_attach(stb0899_attach). Increment the module refcount instead. Signed-off-by: Wolfgang Rohdewald ---

Re: [linux-sunxi] Cedrus driver

Hi, On 28-11-17 12:26, Giulio Benetti wrote: > Hi Thomas, > > Il 28/11/2017 12:20, Thomas van Kleef ha scritto: >> On 28-11-17 10:50, Giulio Benetti wrote: >>> Hi Maxime, >>> >>> Il 28/11/2017 09:35, Maxime Ripard ha scritto: On Tue, Nov 28, 2017 at 01:03:59AM +0100, Giulio Benetti wrote:

Re: [linux-sunxi] Cedrus driver

On 28-11-17 10:50, Giulio Benetti wrote: > Hi Maxime, > > Il 28/11/2017 09:35, Maxime Ripard ha scritto: >> On Tue, Nov 28, 2017 at 01:03:59AM +0100, Giulio Benetti wrote: >>> Hi Maxime, >>> >>> Il 16/11/2017 14:42, Giulio Benetti ha scritto: Hi, Il 16/11/2017 14:39, Maxime Ripard

Re: [linux-sunxi] Cedrus driver

Hi Thomas, Il 28/11/2017 12:20, Thomas van Kleef ha scritto: On 28-11-17 10:50, Giulio Benetti wrote: Hi Maxime, Il 28/11/2017 09:35, Maxime Ripard ha scritto: On Tue, Nov 28, 2017 at 01:03:59AM +0100, Giulio Benetti wrote: Hi Maxime, Il 16/11/2017 14:42, Giulio Benetti ha scritto: Hi,

Re: [PATCH 1/4] staging: add missing blank line after declarations in atomisp-ov5693

On 11/28, jacopo mondi wrote: > Hi Riccardo, > > On Mon, Nov 27, 2017 at 10:44:10PM +0100, Riccardo Schirone wrote: > > Signed-off-by: Riccardo Schirone > > No patch can be accepted without a commit message. I know subject is > self-explanatory here, but please add some lines

[PATCH v3 2/2] media: staging: atomisp: fixes for "symbol was not declared. Should it be static?" sparse warnings.

Defined some const arrays as static since they don't need external linkage. Signed-off-by: Jeremy Sowden --- .../isp/kernels/eed1_8/ia_css_eed1_8.host.c| 24 +++--- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

Re: [PATCH 1/4] staging: add missing blank line after declarations in atomisp-ov5693

Hi Riccardo, On Mon, Nov 27, 2017 at 10:44:10PM +0100, Riccardo Schirone wrote: > Signed-off-by: Riccardo Schirone No patch can be accepted without a commit message. I know subject is self-explanatory here, but please add some lines eg. reporting checkpatch warnings. Thanks

Re: [PATCH 3/4] staging: improves comparisons readability in atomisp-ov5693

Hi Riccardo, thanks for the patch On Mon, Nov 27, 2017 at 10:44:12PM +0100, Riccardo Schirone wrote: > Fix "Comparisons should place the constant on the right side of the > test" issue. > > Signed-off-by: Riccardo Schirone > --- >

Re: [linux-sunxi] Cedrus driver

Hi Maxime, Il 28/11/2017 09:35, Maxime Ripard ha scritto: On Tue, Nov 28, 2017 at 01:03:59AM +0100, Giulio Benetti wrote: Hi Maxime, Il 16/11/2017 14:42, Giulio Benetti ha scritto: Hi, Il 16/11/2017 14:39, Maxime Ripard ha scritto: On Thu, Nov 16, 2017 at 02:17:08PM +0100, Giulio Benetti

Re: [linux-sunxi] Cedrus driver

On Tue, Nov 28, 2017 at 01:03:59AM +0100, Giulio Benetti wrote: > Hi Maxime, > > Il 16/11/2017 14:42, Giulio Benetti ha scritto: > > Hi, > > > > Il 16/11/2017 14:39, Maxime Ripard ha scritto: > > > On Thu, Nov 16, 2017 at 02:17:08PM +0100, Giulio Benetti wrote: > > > > Hi Hans, > > > > > > > >