Re: [PATCH 15/22] media: soc_camera: fix a kernel-doc markup

2017-11-29 Thread Guennadi Liakhovetski
On Wed, 29 Nov 2017, Mauro Carvalho Chehab wrote: > Remove this warning: > drivers/media/platform/soc_camera/soc_scale_crop.c:309: warning: Cannot > understand * @icd - soc-camera device >on line 309 - I thought it was a doc line > > Signed-off-by: Mauro Carvalho

cron job: media_tree daily build: ERRORS

2017-11-29 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Nov 30 05:00:17 CET 2017 media-tree git hash:04226916d2360f56d57ad00bc48d2d1854d1e0b0 media_build

Re: [PATCH v4 4/5] ARM: dts: imx: Add TDA19971 HDMI Receiver to GW54xx

2017-11-29 Thread Shawn Guo
On Wed, Nov 29, 2017 at 01:19:56PM -0800, Tim Harvey wrote: > The GW54xx has a front-panel microHDMI connector routed to a TDA19971 > which is connected the the IPU CSI when using IMX6Q. > > Signed-off-by: Tim Harvey > --- > v2: > - add HDMI audio input support > --- >

[PATCH v4 0/5] TDA1997x HDMI video receiver

2017-11-29 Thread Tim Harvey
This is a v4l2 subdev driver supporting the TDA1997x HDMI video receiver. I've tested this on a Gateworks GW54xx/GW551x with an IMX6Q which uses the TDA19971 with 16bits connected to the IMX6 CSI. For this configuration I've tested both 16bit YUV422 and 8bit BT656 parallel video bus modes. While

[PATCH v4 1/5] MAINTAINERS: add entry for NXP TDA1997x driver

2017-11-29 Thread Tim Harvey
Signed-off-by: Tim Harvey --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index aa71ab52f..502bc97 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13244,6 +13244,14 @@ T: git git://linuxtv.org/mkrufky/tuners.git S:

[PATCH v4 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-29 Thread Tim Harvey
Add support for the TDA1997x HDMI receivers. Cc: Hans Verkuil Signed-off-by: Tim Harvey --- v4: - move include/dt-bindings/media/tda1997x.h to bindings patch - fix typos - fix default quant range for VGA - fix quant range handling and conv matrix

[PATCH v4 4/5] ARM: dts: imx: Add TDA19971 HDMI Receiver to GW54xx

2017-11-29 Thread Tim Harvey
The GW54xx has a front-panel microHDMI connector routed to a TDA19971 which is connected the the IPU CSI when using IMX6Q. Signed-off-by: Tim Harvey --- v2: - add HDMI audio input support --- arch/arm/boot/dts/imx6q-gw54xx.dts| 102 ++

[PATCH v4 5/5] ARM: dts: imx: Add TDA19971 HDMI Receiver to GW551x

2017-11-29 Thread Tim Harvey
Signed-off-by: Tim Harvey --- arch/arm/boot/dts/imx6qdl-gw551x.dtsi | 85 +++ 1 file changed, 85 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi index 30d4662..8ce0b15 100644 ---

[PATCH v4 2/5] media: dt-bindings: Add bindings for TDA1997X

2017-11-29 Thread Tim Harvey
Cc: Rob Herring Cc: Sakari Ailus Signed-off-by: Tim Harvey --- v4: - move include/dt-bindings/media/tda1997x.h to bindings patch - clarify port node details v3: - fix typo v2: - add vendor prefix and remove _ from vidout-portcfg

[PATCH 1/2] ir-ctl: fix multiple scancodes in one file

2017-11-29 Thread Sean Young
A file with contents: scancode sony12:0x100015 space 25000 scancode sony12:0x100015 Will produce bogus results. Reported-by: Matthias Reichl Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

[PATCH 2/2] ir-ctl: specify the gap between scancodes or files

2017-11-29 Thread Sean Young
When sending multiple scancodes, or pulse space files, by default there is 125ms gap between them. Allow this to be specified. Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.1.in | 5 + utils/ir-ctl/ir-ctl.c| 18 +- 2 files changed, 18 insertions(+), 5

Re: [BUG] ir-ctl: error sending file with multiple scancodes

2017-11-29 Thread Sean Young
Hi Matthias, On Wed, Nov 29, 2017 at 03:44:00PM +0100, Matthias Reichl wrote: > Hi Sean! > > According to the ir-ctl manpage it should be possible to send a file > containing multiple scancodes, but when trying to do this I get > a warning and an error message. > > I initially noticed that on

[PATCH v8 03/28] rcar-vin: unregister video device on driver removal

2017-11-29 Thread Niklas Söderlund
If the video device was registered by the complete() callback it should be unregistered when the driver is removed. Protect from printing a uninitialized video device node name by adding a checking in rvin_v4l2_unregister() by checking that the video device is registered. Signed-off-by: Niklas

[PATCH v8 04/28] rcar-vin: move subdevice handling to async callbacks

2017-11-29 Thread Niklas Söderlund
In preparation for Gen3 support move the subdevice initialization and clean up from rvin_v4l2_{register,unregister}() directly to the async callbacks. This simplifies the addition of Gen3 support as the rvin_v4l2_register() can be shared for both Gen2 and Gen3 while direct subdevice control are

[PATCH v8 02/28] rcar-vin: rename poorly named initialize and cleanup functions

2017-11-29 Thread Niklas Söderlund
The functions to initialize and cleanup the hardware and video device where poorly named from the start. Rename them to better describe there intended function. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-core.c | 10 +-

[PATCH v8 06/28] rcar-vin: move max width and height information to chip information

2017-11-29 Thread Niklas Söderlund
On Gen3 the max supported width and height will be different from Gen2. Move the limits to the struct rvin_info to prepare for Gen3 support. Signed-off-by: Niklas Söderlund Reviewed-by: Kieran Bingham Reviewed-by:

[PATCH v8 01/28] rcar-vin: add Gen3 devicetree bindings documentation

2017-11-29 Thread Niklas Söderlund
Document the devicetree bindings for the CSI-2 inputs available on Gen3. There is a need to add a custom property 'renesas,id' and to define which CSI-2 input is described in which endpoint under the port@1 node. This information is needed since there are a set of predefined routes between each

[PATCH v8 12/28] rcar-vin: read subdevice format for crop only when needed

2017-11-29 Thread Niklas Söderlund
Instead of caching the subdevice format each time the video device format is set read it directly when it's needed. As it turns out the format is only needed when figuring out the max rectangle for cropping. This simplifies the code and makes it clearer what the source format is used for.

[PATCH v8 10/28] rcar-vin: do not reset crop and compose when setting format

2017-11-29 Thread Niklas Söderlund
It was a bad idea to reset the crop and compose settings when a new format is set. This would overwrite any crop/compose set by s_select and cause unexpected behaviors, remove it. Also fold the reset helper in to the only remaining caller. Signed-off-by: Niklas Söderlund

[PATCH v8 14/28] rcar-vin: move media bus configuration to struct rvin_info

2017-11-29 Thread Niklas Söderlund
Bus configuration will once the driver is extended to support Gen3 contain information not specific to only the directly connected parallel subdevice. Move it to struct rvin_info to show it's not always coupled to the parallel subdevice. Signed-off-by: Niklas Söderlund

[PATCH v8 11/28] rcar-vin: do not allow changing scaling and composing while streaming

2017-11-29 Thread Niklas Söderlund
It is possible on Gen2 to change the registers controlling composing and scaling while the stream is running. It is however not a good idea to do so and could result in trouble. There are also no good reasons to allow this, remove immediate reflection in hardware registers from vidioc_s_selection

[PATCH v8 07/28] rcar-vin: change name of video device

2017-11-29 Thread Niklas Söderlund
The rcar-vin driver needs to be part of a media controller to support Gen3. Give each VIN instance a unique name so it can be referenced from userspace. Signed-off-by: Niklas Söderlund Reviewed-by: Kieran Bingham

[PATCH v8 13/28] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

2017-11-29 Thread Niklas Söderlund
There was never proper support in the VIN driver to deliver ALTERNATING field format to user-space, remove this field option. For sources using this field format instead use the VIN hardware feature of combining the fields to an interlaced format. This mode of operation was previously the default

[PATCH v8 16/28] rcar-vin: add function to manipulate Gen3 chsel value

2017-11-29 Thread Niklas Söderlund
On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One feature of this register is that it's only present in the VIN0 and VIN4 instances. The register in VIN0 controls the routing for VIN0-3 and the register in VIN4 controls routing for VIN4-7. To be able to control routing from

[PATCH v8 05/28] rcar-vin: move chip information to own struct

2017-11-29 Thread Niklas Söderlund
When Gen3 support is added to the driver more than chip ID will be different for the different SoCs. To avoid a lot of if statements in the code create a struct chip_info to store this information. And while we are at it sort the compatible string entries and make use of

[PATCH v8 15/28] rcar-vin: enable Gen3 hardware configuration

2017-11-29 Thread Niklas Söderlund
Add the register needed to work with Gen3 hardware. This patch adds the logic for how to work with the Gen3 hardware. More work is required to enable the subdevice structure needed to configure capturing. Signed-off-by: Niklas Söderlund Reviewed-by: Hans

[PATCH v8 17/28] rcar-vin: add flag to switch to media controller mode

2017-11-29 Thread Niklas Söderlund
On Gen3 a media controller API needs to be used to allow userspace to configure the subdevices in the pipeline instead of directly controlling a single source subdevice, which is and will continue to be the mode of operation on Gen2. Prepare for these two modes of operation by adding a flag to

[PATCH v8 26/28] rcar-vin: enable support for r8a7795

2017-11-29 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a7795 ES1.x and ES2.0. Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil --- drivers/media/platform/rcar-vin/Kconfig | 2 +- drivers/media/platform/rcar-vin/rcar-core.c |

[PATCH v8 23/28] rcar-vin: parse Gen3 OF and setup media graph

2017-11-29 Thread Niklas Söderlund
Parse the VIN Gen3 OF graph and register all CSI-2 devices in the VIN group common media device. Once all CSI-2 subdevices are added to the common media device create links between them. The parsing and registering CSI-2 subdevices with the v4l2 async framework is a collaborative effort shared

[PATCH v8 19/28] rcar-vin: use different v4l2 operations in media controller mode

2017-11-29 Thread Niklas Söderlund
When the driver runs in media controller mode it should not directly control the subdevice instead userspace will be responsible for configuring the pipeline. To be able to run in this mode a different set of v4l2 operations needs to be used. Add a new set of v4l2 operations to support the

[PATCH v8 27/28] rcar-vin: enable support for r8a7796

2017-11-29 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a7796. Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil --- .../devicetree/bindings/media/rcar_vin.txt | 1 + drivers/media/platform/rcar-vin/rcar-core.c| 64

[PATCH v8 18/28] rcar-vin: break out format alignment and checking

2017-11-29 Thread Niklas Söderlund
Part of the format alignment and checking can be shared with the Gen3 format handling. Break that part out to its own function. While doing this clean up the checking and add more checks. Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil

[PATCH v8 21/28] rcar-vin: add group allocator functions

2017-11-29 Thread Niklas Söderlund
In media controller mode all VIN instances needs to be part of the same media graph. There is also a need to each VIN instance to know and in some cases be able to communicate with other VIN instances. Add an allocator framework where the first VIN instance to be probed creates a shared data

[PATCH v8 22/28] rcar-vin: add chsel information to rvin_info

2017-11-29 Thread Niklas Söderlund
Each Gen3 SoC has a limited set of predefined routing possibilities for which CSI-2 device and virtual channel can be routed to which VIN instance. Prepare to store this information in the struct rvin_info. Signed-off-by: Niklas Söderlund Reviewed-by: Hans

[PATCH v8 24/28] rcar-vin: add link notify for Gen3

2017-11-29 Thread Niklas Söderlund
Add the ability to process media device link change request. Link enabling is a bit complicated on Gen3, whether or not it's possible to enable a link depends on what other links already are enabled. On Gen3 the 8 VINs are split into two subgroup's (VIN0-3 and VIN4-7) and from a routing

[PATCH v8 25/28] rcar-vin: extend {start,stop}_streaming to work with media controller

2017-11-29 Thread Niklas Söderlund
The procedure to start or stop streaming using the non-MC single subdevice and the MC graph and multiple subdevices are quite different. Create a new function to abstract which method is used based on which mode the driver is running in and add logic to start the MC graph. Signed-off-by: Niklas

[PATCH v8 08/28] rcar-vin: move functions regarding scaling

2017-11-29 Thread Niklas Söderlund
In preparation of refactoring the scaling code move the code regarding scaling to to the top of the file to avoid the need to add forward declarations. No code is changed in this commit only whole functions moved inside the same file. Signed-off-by: Niklas Söderlund

[PATCH v8 28/28] rcar-vin: enable support for r8a77970

2017-11-29 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a77970. Signed-off-by: Niklas Söderlund --- .../devicetree/bindings/media/rcar_vin.txt | 1 + drivers/media/platform/rcar-vin/rcar-core.c| 40 ++ 2 files changed, 41

[PATCH v8 00/28] rcar-vin: Add Gen3 with media controller

2017-11-29 Thread Niklas Söderlund
Hi, This series adds Gen3 VIN support to rcar-vin driver for Renesas r8a7795, r8a7796 and r8a77970. It is based on the media-tree and depends on some of Fabrizio Castro patches as they touches the order of the compatible strings in the documentation to reduce merge conflicts. The dependencies

[PATCH v8 20/28] rcar-vin: prepare for media controller mode initialization

2017-11-29 Thread Niklas Söderlund
When running in media controller mode a media pad is needed, register one. Also set the media bus format to CSI-2. Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil --- drivers/media/platform/rcar-vin/rcar-core.c | 24

[PATCH v8 09/28] rcar-vin: all Gen2 boards can scale simplify logic

2017-11-29 Thread Niklas Söderlund
The logic to preserve the requested format width and height are too complex and come from a premature optimization for Gen3. All Gen2 SoC can scale and the Gen3 implementation will not use these functions at all so simply preserve the width and height when interacting with the subdevice much like

[PATCH v12 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2017-11-29 Thread Niklas Söderlund
A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver supports the rcar-vin driver on R-Car Gen3 SoCs where separate CSI-2 hardware blocks are connected between the video sources and the video grabbers (VIN). Driver is based on a prototype by Koji Matsuoka in the Renesas BSP.

[PATCH v12 1/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver documentation

2017-11-29 Thread Niklas Söderlund
Documentation for Renesas R-Car MIPI CSI-2 receiver. The CSI-2 receivers are located between the video sources (CSI-2 transmitters) and the video grabbers (VIN) on Gen3 of Renesas R-Car SoC. Each CSI-2 device is connected to more then one VIN device which simultaneously can receive video from the

[PATCH v12 0/2] rcar-csi2: add Renesas R-Car MIPI CSI-2

2017-11-29 Thread Niklas Söderlund
Hi, This is the latest incarnation of R-Car MIPI CSI-2 receiver driver. It's based on top of the media-tree and are tested on Renesas Salvator-X together with the out-of-tree patches for rcar-vin to add support for Gen3 VIN. I hope this is the last incarnation of this patch-set, I do think it is

[PATCH 06/22] media: s5k6a3: document some fields at struct s5k6a3

2017-11-29 Thread Mauro Carvalho Chehab
drivers/media/i2c/s5k6a3.c:68: warning: No description found for parameter 'clock' drivers/media/i2c/s5k6a3.c:68: warning: No description found for parameter 'clock_frequency' drivers/media/i2c/s5k6a3.c:68: warning: No description found for parameter 'power_count' Signed-off-by: Mauro Carvalho

[PATCH 01/22] media: sta2x11: document missing function parameters

2017-11-29 Thread Mauro Carvalho Chehab
As warned: drivers/media/pci/sta2x11/sta2x11_vip.c:414: warning: No description found for parameter 'priv' drivers/media/pci/sta2x11/sta2x11_vip.c:442: warning: No description found for parameter 'priv' drivers/media/pci/sta2x11/sta2x11_vip.c:476: warning: No description found for

[PATCH 13/22] media: radio-wl1273: fix a parameter name at kernel-doc macro

2017-11-29 Thread Mauro Carvalho Chehab
Solve those warnings: drivers/media/radio/radio-wl1273.c:1337: warning: No description found for parameter 'radio' drivers/media/radio/radio-wl1273.c:1337: warning: Excess function parameter 'core' description in 'wl1273_fm_set_tx_power' Signed-off-by: Mauro Carvalho Chehab

[PATCH 02/22] media: pxa_camera: get rid of kernel_doc warnings

2017-11-29 Thread Mauro Carvalho Chehab
Get rid of the following warnings: drivers/media/platform/pxa_camera.c:247: warning: No description found for parameter 'layout' drivers/media/platform/pxa_camera.c:867: warning: No description found for parameter 'buf' drivers/media/platform/pxa_camera.c:867: warning: No description

[PATCH 20/22] media: dvb_frontends: fix kernel-doc macros

2017-11-29 Thread Mauro Carvalho Chehab
Now, the Kernel checks for kernel_doc format issues. Weird enough, it didn't get any of those troubles. Shssst! Well, let's fix it, as a preventive way to avoid having hundreds of new warnings on some next Linux version. Tested by adding all files under dvb-frontends that have "/**" on them.

[PATCH 15/22] media: soc_camera: fix a kernel-doc markup

2017-11-29 Thread Mauro Carvalho Chehab
Remove this warning: drivers/media/platform/soc_camera/soc_scale_crop.c:309: warning: Cannot understand * @icd - soc-camera device on line 309 - I thought it was a doc line Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 11/22] media: mtk-vpu: add description for wdt fields at struct mtk_vpu

2017-11-29 Thread Mauro Carvalho Chehab
Fix those warnings: drivers/media/platform/mtk-vpu/mtk_vpu.c:223: warning: No description found for parameter 'wdt' drivers/media/platform/mtk-vpu/mtk_vpu.c:223: warning: No description found for parameter 'wdt_refcnt' Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 10/22] media: vdec: fix some kernel-doc warnings

2017-11-29 Thread Mauro Carvalho Chehab
Fix those warnings: drivers/media/platform/mtk-vcodec/vdec/vdec_h264_if.c:69: warning: No description found for parameter 'reserved' drivers/media/platform/mtk-vcodec/vdec/vdec_vp8_if.c:175: warning: Excess struct member 'dev' description in 'vdec_vp8_inst' Signed-off-by: Mauro Carvalho

[PATCH 22/22] media: dvb-frontends: complete kernel-doc markups

2017-11-29 Thread Mauro Carvalho Chehab
For the dvb-frontends that are now part of the documentation, complete the kernel-doc markups, in order for them to be properly used at the driver's kAPI documentation. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/af9013.h | 24 +++--

[PATCH 16/22] media: vsp1: add a missing kernel-doc parameter

2017-11-29 Thread Mauro Carvalho Chehab
Fix this warning: drivers/media/platform/vsp1/vsp1_dl.c:87: warning: No description found for parameter 'has_chain' Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/vsp1/vsp1_dl.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 08/22] media: netup_unidvb: fix a bad kernel-doc markup

2017-11-29 Thread Mauro Carvalho Chehab
There is a bad kernel-doc markup, producing the following warnings: drivers/media/pci/netup_unidvb/netup_unidvb_core.c:85: warning: bad line: Bits [0-7]: DMA packet size, 188 bytes drivers/media/pci/netup_unidvb/netup_unidvb_core.c:86: warning: bad line:

[PATCH 21/22] media: docs: add documentation for frontend attach info

2017-11-29 Thread Mauro Carvalho Chehab
Add to the media book the attachment kAPI for the DVB frontend drivers that have already some kernel-doc markup. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/dvb-drivers/frontends.rst | 30 +++

[PATCH 04/22] media: ix2505v: get rid of /** comments

2017-11-29 Thread Mauro Carvalho Chehab
As warned: drivers/media/dvb-frontends/ix2505v.c:24: warning: cannot understand function prototype: 'int ix2505v_debug; ' drivers/media/dvb-frontends/ix2505v.c:59: warning: No description found for parameter 'state' drivers/media/dvb-frontends/ix2505v.c:128: warning: No description found

[PATCH 12/22] media: s3c-camif: add missing description at s3c_camif_find_format()

2017-11-29 Thread Mauro Carvalho Chehab
Fix this warning: drivers/media/platform/s3c-camif/camif-core.c:112: warning: No description found for parameter 'vp' Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/s3c-camif/camif-core.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 03/22] media: tw68: fix kernel-doc markups

2017-11-29 Thread Mauro Carvalho Chehab
There are a few mistakes on the existing markups: drivers/media/pci/tw68/tw68-risc.c:32: warning: Cannot understand * @rp pointer to current risc program position on line 32 - I thought it was a doc line drivers/media/pci/tw68/tw68-risc.c:144: warning: No description found

[PATCH 18/22] media: lm3560: add a missing kernel-doc parameter

2017-11-29 Thread Mauro Carvalho Chehab
Fix this warning: drivers/media/i2c/lm3560.c:69: warning: No description found for parameter 'dev' Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/lm3560.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/lm3560.c

[PATCH 05/22] media: radio-si476x: fix kernel-doc markups

2017-11-29 Thread Mauro Carvalho Chehab
get rid of the following warnings: drivers/media/radio/radio-si476x.c:317: warning: No description found for parameter 'v4l2dev' drivers/media/radio/radio-si476x.c:317: warning: No description found for parameter 'ctrl_handler' drivers/media/radio/radio-si476x.c:317: warning: No

[PATCH 07/22] media: s5k6aa: describe some function parameters

2017-11-29 Thread Mauro Carvalho Chehab
as warned: drivers/media/i2c/s5k6aa.c:429: warning: No description found for parameter 's5k6aa' drivers/media/i2c/s5k6aa.c:679: warning: No description found for parameter 's5k6aa' drivers/media/i2c/s5k6aa.c:733: warning: No description found for parameter 's5k6aa'

[PATCH 19/22] media: drivers: remove "/**" from non-kernel-doc comments

2017-11-29 Thread Mauro Carvalho Chehab
Several comments are wrongly tagged as kernel-doc, causing those warnings: drivers/media/rc/st_rc.c:98: warning: No description found for parameter 'irq' drivers/media/rc/st_rc.c:98: warning: No description found for parameter 'data' drivers/media/pci/solo6x10/solo6x10-enc.c:183: warning:

[PATCH 17/22] media: rcar_jpu: fix two kernel-doc markups

2017-11-29 Thread Mauro Carvalho Chehab
On kernel-doc, struct declarations should be declared as "struct foo". Fix the following warnings: drivers/media/platform/rcar_jpu.c:265: warning: cannot understand function prototype: 'struct jpu_q_data ' drivers/media/platform/rcar_jpu.c:281: warning: cannot understand

[PATCH 09/22] media: tvp514x: fix kernel-doc parameters

2017-11-29 Thread Mauro Carvalho Chehab
There are some struct fields that aren't documented, and some consts whose comments start with /**, but they aren't kernel-doc annotations. So, fix it: drivers/media/i2c/tvp514x.c:127: warning: No description found for parameter 'hdl' drivers/media/i2c/tvp514x.c:127: warning: No description

[PATCH 14/22] media: mt2063: fix some kernel-doc warnings

2017-11-29 Thread Mauro Carvalho Chehab
Fix those warnings: drivers/media/tuners/mt2063.c:1413: warning: No description found for parameter 'f_ref' drivers/media/tuners/mt2063.c:1413: warning: Excess function parameter 'f_Ref' description in 'MT2063_fLO_FractionalTerm' drivers/media/tuners/mt2063.c:1476:

[PATCH v3 0/4] introduce get_user_pages_longterm()

2017-11-29 Thread Dan Williams
Changes since v2 [1]: * Add a comment for the vma_is_fsdax() check in get_vaddr_frames() (Jan) * Collect Jan's Reviewed-by. * Rebased on v4.15-rc1 [1]: https://lists.01.org/pipermail/linux-nvdimm/2017-November/013295.html The summary text below is unchanged from v2. --- Andrew, Here is a new

[PATCH v3 2/4] mm: fail get_vaddr_frames() for filesystem-dax mappings

2017-11-29 Thread Dan Williams
Until there is a solution to the dma-to-dax vs truncate problem it is not safe to allow V4L2, Exynos, and other frame vector users to create long standing / irrevocable memory registrations against filesytem-dax vmas. Cc: Inki Dae Cc: Seung-Woo Kim

[PATCH v3 3/4] [media] v4l2: disable filesystem-dax mapping support

2017-11-29 Thread Dan Williams
V4L2 memory registrations are incompatible with filesystem-dax that needs the ability to revoke dma access to a mapping at will, or otherwise allow the kernel to wait for completion of DMA. The filesystem-dax implementation breaks the traditional solution of truncate of active file backed mappings

[PATCH v2 3/4] media: ov5640: add support of DVP parallel interface

2017-11-29 Thread Hugues Fruchet
Add support of DVP parallel mode in addition of existing MIPI CSI mode. The choice between two modes and configuration is made through device tree. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 101 + 1 file

[PATCH v2 4/4] media: ov5640: add support of RGB565 and YUYV formats

2017-11-29 Thread Hugues Fruchet
Add RGB565 (LE & BE) and YUV422 YUYV format in addition to existing YUV422 UYVY format. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 74 +- 1 file changed, 67 insertions(+), 7 deletions(-) diff --git

[PATCH v2 1/4] media: ov5640: switch to gpiod_set_value_cansleep()

2017-11-29 Thread Hugues Fruchet
Switch gpiod_set_value to gpiod_set_value_cansleep to avoid warnings when powering sensor. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov5640.c

[PATCH v2 0/4] Add OV5640 parallel interface and RGB565/YUYV support

2017-11-29 Thread Hugues Fruchet
Enhance OV5640 CSI driver to support also DVP parallel interface. Add RGB565 (LE & BE) and YUV422 YUYV format in addition to existing YUV422 UYVY format. Some other improvements on chip identifier check and removal of warnings in powering phase around gpio handling. === = history =

[PATCH v2 2/4] media: ov5640: check chip id

2017-11-29 Thread Hugues Fruchet
Verify that chip identifier is correct before starting streaming Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov5640.c

[PATCH] media: exynos4-is: Use PTR_ERR_OR_ZERO()

2017-11-29 Thread Vasyl Gomonovych
Fix ptr_ret.cocci warnings: drivers/media/platform/exynos4-is/fimc-lite.c:1465:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Signed-off-by: Vasyl Gomonovych ---

Re: [PATCH 2/5] media: dt-bindings: Add bindings for TDA1997X

2017-11-29 Thread Tim Harvey
On Thu, Nov 23, 2017 at 12:25 AM, Sakari Ailus wrote: > On Wed, Nov 22, 2017 at 08:37:04PM -0800, Tim Harvey wrote: >> On Tue, Nov 21, 2017 at 11:36 PM, Sakari Ailus wrote: >> > Hi Tim, >> > >> > On Thu, Nov 09, 2017 at 10:45:33AM -0800, Tim Harvey

Re: [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-29 Thread Tim Harvey
On Thu, Nov 23, 2017 at 12:08 AM, Hans Verkuil wrote: > On 11/23/2017 05:27 AM, Tim Harvey wrote: >> On Mon, Nov 20, 2017 at 7:39 AM, Hans Verkuil wrote: >>> Hi Tim, >>> >>> Some more review comments: >>> >>> On 11/09/2017 07:45 PM, Tim Harvey wrote:

[PATCH Resend] staging: media: cxd2099: style fix - replace hard-coded function names

2017-11-29 Thread Martin Homuth
This patch fixes the remaining coding style warnings in the cxd2099 module. Instead of hard coding the function name the __func__ variable should be used. It fixes the following checkpatch.pl warning: WARNING: Prefer using '"%s...", __func__' to using 'i2c_read_reg', this function's name, in a

Re: [PATCH Resend] staging: media: cxd2099: style fix - replace hard-coded function names

2017-11-29 Thread Martin Homuth
This patch fixes the remaining coding style warnings in the cxd2099 module. Instead of hard coding the function name the __func__ variable should be used. It fixes the following checkpatch.pl warning: WARNING: Prefer using '"%s...", __func__' to using 'i2c_read_reg', this function's name, in a

Re: [linux-sunxi] Cedrus driver

2017-11-29 Thread Thomas van Kleef
Hi Maxime, > > So there's a couple of issues with those patches (the pull request > itself is fine though :)) > > I'll try to break them down as much as possible. > > A) If you want to have proper commit logs, you will usually do two >things: first create a commit title, which is what

[PATCH] staging: media: cxd2099: style fix - replace hard-coded function names

2017-11-29 Thread Martin Homuth
This patch fixes the remaining coding style warnings in the lirc module. Instead of hard coding the function name the __func__ variable should be used. It fixes the following checkpatch.pl warning: WARNING: Prefer using '"%s...", __func__' to using 'read', this function's name, in a string

[BUG] ir-ctl: error sending file with multiple scancodes

2017-11-29 Thread Matthias Reichl
Hi Sean! According to the ir-ctl manpage it should be possible to send a file containing multiple scancodes, but when trying to do this I get a warning and an error message. I initially noticed that on version 1.12.3 but 1.12.5 and master (rev 85f8e5a99) give the same error. Sending a file with

Re: [PATCH 12/12] media: videobuf2: don't use kernel-doc "/**" markups

2017-11-29 Thread Marek Szyprowski
Hi Mauro, On 2017-11-29 11:46, Mauro Carvalho Chehab wrote: While it would be very cool to have those functions using kernel-doc markups, the reality right now is that they don't follow kernel-doc rules, as parameters aren't documented. So, stop abusing on "/**" markups. Signed-off-by: Mauro

Re: [PATCH v2 1/3] media: staging: atomisp: fix for sparse "using plain integer as NULL pointer" warnings.

2017-11-29 Thread Alan Cox
> There are 35 defaults defined by macros like this, most of them much > more complicated that IA_CSS_DEFAULT_ISP_MEM_PARAMS, and a few members > are initialized to non-zero values. My plan, therefore, is to convert > everything to use designated initializers, and then start removing the > zeroes

[PATCH 2/2] venus: venc: set correctly GOP size and number of B-frames

2017-11-29 Thread Stanimir Varbanov
This change fixes the calculation of B-frames and GOP size by adopt v4l2 controls with the firmware interface expectations. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/venc.c | 15 ---

[PATCH 1/2] venus: cleanup set_property controls

2017-11-29 Thread Stanimir Varbanov
Move ptype (property type) initialization out of switch case and save few lines of code. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_cmds.c | 73 +--- 1 file changed, 2 insertions(+), 71 deletions(-) diff

Re: [PATCH 1/7] media: atomisp: stop producing hundreds of kernel-doc warnings

2017-11-29 Thread Sakari Ailus
On Wed, Nov 29, 2017 at 10:28:26AM -0200, Mauro Carvalho Chehab wrote: > Em Wed, 29 Nov 2017 10:24:57 -0200 > Mauro Carvalho Chehab escreveu: > > > Em Wed, 29 Nov 2017 14:14:54 +0200 > > Sakari Ailus escreveu: > > > > > Hi Mauro, > > > >

Re: notifier is skipped in some situations

2017-11-29 Thread Sakari Ailus
Hi Jacob, On Mon, Nov 27, 2017 at 03:03:59PM +0800, Jacob Chen wrote: > Hi, > > On 2017年11月25日星期六 CST 下午1:05:42 you wrote: > > Hi, > > > > On 2017年11月24日星期五 CST 下午6:19:36 you wrote: > > > On Fri, Nov 24, 2017 at 6:17 PM, Sakari Ailus > > > > > > wrote: > > > > Hi

Re: [PATCH 1/7] media: atomisp: stop producing hundreds of kernel-doc warnings

2017-11-29 Thread Mauro Carvalho Chehab
Em Wed, 29 Nov 2017 10:24:57 -0200 Mauro Carvalho Chehab escreveu: > Em Wed, 29 Nov 2017 14:14:54 +0200 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > Thanks for the patch. > > > > On Wed, Nov 29, 2017 at 07:08:04AM -0500, Mauro

Re: [PATCH 1/7] media: atomisp: stop producing hundreds of kernel-doc warnings

2017-11-29 Thread Mauro Carvalho Chehab
Em Wed, 29 Nov 2017 14:14:54 +0200 Sakari Ailus escreveu: > Hi Mauro, > > Thanks for the patch. > > On Wed, Nov 29, 2017 at 07:08:04AM -0500, Mauro Carvalho Chehab wrote: > > A recent change on Kernel 4.15-rc1 causes all tags with > > /** to be handled as

Re: [PATCH 1/7] media: atomisp: stop producing hundreds of kernel-doc warnings

2017-11-29 Thread Sakari Ailus
Hi Mauro, Thanks for the patch. On Wed, Nov 29, 2017 at 07:08:04AM -0500, Mauro Carvalho Chehab wrote: > A recent change on Kernel 4.15-rc1 causes all tags with > /** to be handled as kernel-doc markups. Well, several > atomisp modules, it doesn't use kernel-doc, but some other > documentation

[PATCH 3/7] media: v4l2-core: Fix kernel-doc markups

2017-11-29 Thread Mauro Carvalho Chehab
There are some troubles on kernel-doc markups, as warned: drivers/media/v4l2-core/v4l2-dv-timings.c:259: warning: No description found for parameter 't1' drivers/media/v4l2-core/v4l2-dv-timings.c:259: warning: No description found for parameter 't2'

[PATCH 7/7] media: m5mols: fix some kernel-doc markups

2017-11-29 Thread Mauro Carvalho Chehab
Fix those warnings: drivers/media/i2c/m5mols/m5mols_capture.c:42: warning: No description found for parameter 'sd' drivers/media/i2c/m5mols/m5mols_capture.c:42: warning: No description found for parameter 'addr_num' drivers/media/i2c/m5mols/m5mols_capture.c:42: warning:

[PATCH 6/7] media: exynos4-is: fix kernel-doc warnings

2017-11-29 Thread Mauro Carvalho Chehab
Fix those kernel-doc warnings: drivers/media/platform/exynos4-is/mipi-csis.c:229: warning: No description found for parameter 'clk_frequency' drivers/media/platform/exynos4-is/mipi-csis.c:229: warning: Excess struct member 'clock_frequency' description in 'csis_state'

[PATCH 5/7] media: venc: don't use kernel-doc for undescribed enums

2017-11-29 Thread Mauro Carvalho Chehab
There are no descriptions for some enums, with produces lots of warnings: drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warning: Enum value 'VENC_VP8_VPU_WORK_BUF_LUMA' not described in enum 'venc_vp8_vpu_work_buf' drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55:

[PATCH 2/7] media: rc: fix kernel-doc parameter names

2017-11-29 Thread Mauro Carvalho Chehab
There are several parameters there that are named wrong, as reported by those warnings: drivers/media/rc/ir-sharp-decoder.c:47: warning: No description found for parameter 'ev' drivers/media/rc/ir-sharp-decoder.c:47: warning: Excess function parameter 'duration' description in

[PATCH 4/7] media: davinci: fix kernel-doc warnings

2017-11-29 Thread Mauro Carvalho Chehab
There are several of kernel-doc warnings: drivers/media/platform/davinci/vpif_display.c:114: warning: No description found for parameter 'sizes' drivers/media/platform/davinci/vpif_display.c:165: warning: No description found for parameter 'vq'

Re: [PATCH Resend] staging: media: lirc: style fix - replace hard-coded function names

2017-11-29 Thread Sean Young
On Tue, Nov 28, 2017 at 06:47:08PM +0100, Martin Homuth wrote: > This patch fixes the remaining coding style warnings in the lirc module. > Instead of hard coding the function name the __func__ variable > should be used. > > It fixes the following checkpatch.pl warning: > > WARNING: Prefer using

Re: [RFC] v4l: i2c: ov7670: Implement mbus configuration

2017-11-29 Thread jacopo mondi
Hi Sakari, thanks for the reply On Wed, Nov 29, 2017 at 01:06:49PM +0200, Sakari Ailus wrote: > On Wed, Nov 29, 2017 at 01:04:30PM +0200, Sakari Ailus wrote: > > Hi Jacopo, > > > > On Mon, Nov 27, 2017 at 11:26:53AM +0100, Jacopo Mondi wrote: > > > ov7670 currently supports configuration of a

Re: [RFC] v4l: i2c: ov7670: Implement mbus configuration

2017-11-29 Thread Sakari Ailus
On Wed, Nov 29, 2017 at 01:04:30PM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Mon, Nov 27, 2017 at 11:26:53AM +0100, Jacopo Mondi wrote: > > ov7670 currently supports configuration of a few parameters only through > > platform data. Implement media bus configuration by parsing DT properties >

  1   2   >