[RFC PATCH 2/9] media: request: add generic queue

2017-12-14 Thread Alexandre Courbot
Add a generic request queue that supports most use-case and should be usable as-is by drivers without special hardware features. The generic queue stores the requests into a FIFO list and executes them sequentially. Signed-off-by: Alexandre Courbot ---

[RFC PATCH 4/9] videodev2.h: Add request field to v4l2_buffer

2017-12-14 Thread Alexandre Courbot
From: Hans Verkuil When queuing buffers allow for passing the request ID that should be associated with this buffer. Signed-off-by: Hans Verkuil [acour...@chromium.org: make request ID 32-bit] Signed-off-by: Alexandre Courbot

[RFC PATCH 1/9] media: add request API core and UAPI

2017-12-14 Thread Alexandre Courbot
The request API provides a way to group buffers and device parameters into units of work to be queued and executed. This patch introduces the UAPI and core framework. This patch is based on the previous work by Laurent Pinchart. The core has changed considerably, but the UAPI is mostly untouched.

[RFC PATCH 8/9] media: vim2m: add media device

2017-12-14 Thread Alexandre Courbot
Request API requires a media node. Add one to the vim2m driver so we can use requests with it. Signed-off-by: Alexandre Courbot --- drivers/media/platform/vim2m.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/media/platform/vim2m.c

[RFC PATCH 6/9] media: vb2: add support for requests in QBUF ioctl

2017-12-14 Thread Alexandre Courbot
Support the request argument of the QBUF ioctl. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-ioctl.c | 93 +++- 1 file changed, 92 insertions(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c

[RFC PATCH 5/9] media: vb2: add support for requests

2017-12-14 Thread Alexandre Courbot
Add throttling support for buffers when requests are in use on a given queue. Buffers associated to a request are kept into the vb2 queue until the request becomes active, at which point all the buffers are passed to the driver. The queue can also signal that is has processed all of a request's

[RFC PATCH 7/9] media: v4l2-mem2mem: add request support

2017-12-14 Thread Alexandre Courbot
Support request API in the mem2mem framework. Drivers that specify ops for the queue and entities can support requests seamlessly. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-mem2mem.c | 34 ++

[RFC PATCH 9/9] media: vim2m: add request support

2017-12-14 Thread Alexandre Courbot
Set the necessary ops for supporting requests in vim2m. Signed-off-by: Alexandre Courbot --- drivers/media/platform/vim2m.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c index

[RFC PATCH 3/9] media: request: add generic entity ops

2017-12-14 Thread Alexandre Courbot
Add skeleton ops for generic entities. The intent is to provide a generic mechanism to apply request parameters to entities using regular media/v4l2 functions. Signed-off-by: Alexandre Courbot --- drivers/media/Makefile | 3 +-

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

2017-12-14 Thread Edgar Thier
Hi, Another month, another mail. Are there still issues keeping this from being merged? Regards, Edgar On 11/15/2017 12:54 PM, Kieran Bingham wrote: > Hi Edgar, > > Thanks for addressing my concerns in this updated patch. > > On 12/10/17 08:54, Edgar Thier wrote: >> >> Use flags the device

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

2017-12-14 Thread Dhaval Shah
Hi Laurent/Mauro/Greg, On Fri, Dec 15, 2017 at 3:32 AM, Laurent Pinchart wrote: > Hi Mauro, > > On Thursday, 14 December 2017 23:50:03 EET Mauro Carvalho Chehab wrote: >> Em Thu, 14 Dec 2017 21:57:06 +0100 Greg KH escreveu: >> > On Thu, Dec 14, 2017 at

cron job: media_tree daily build: ERRORS

2017-12-14 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Dec 15 05:00:29 CET 2017 media-tree git hash:0ca4e3130402caea8731a7b54afde56a6edb17c9 media_build

[RFC PATCH] media: v4l2-device: Link subdevices to their parent devices if available

2017-12-14 Thread Tomasz Figa
Currently v4l2_device_register_subdev_nodes() does not initialize the dev_parent field of the video_device structs it creates for subdevices being registered. This leads to __video_register_device() falling back to the parent device of associated v4l2_device struct, which often does not match the

Re: [bug report] drx: add initial drx-d driver

2017-12-14 Thread Devin Heitmueller
> I think I wrote the driver more than 10 years ago and somebody later > submitted it > to the kernel. I'm pretty sure that was me, or perhaps I was the first person to get it to work with a device upstream - it was so long ago. > I don't know if there is a anybody still maintaining this. Is it

[PATCH v2 5/9] media: staging/imx: pass fwnode handle to find/add async subdev

2017-12-14 Thread Steve Longerbeam
Pass the subdev's fwnode_handle to imx_media_find_async_subdev() and imx_media_add_async_subdev(), instead of a device_node. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-dev.c | 20 ++--

[PATCH v2 6/9] media: staging/imx: remove static subdev arrays

2017-12-14 Thread Steve Longerbeam
For more complex OF graphs, there will be more async subdevices registered. Remove the static subdev[IMX_MEDIA_MAX_SUBDEVS] array, so that imx-media places no limits on the number of async subdevs that can be added and registered. There were two uses for 'struct imx_media_subdev'. First was to

[PATCH v2 1/9] media: staging/imx: get CSI bus type from nearest upstream entity

2017-12-14 Thread Steve Longerbeam
The imx-media driver currently supports a device tree graph of limited complexity. This patch is a first step in allowing imx-media to work with more general OF graphs. The CSI subdevice assumes the originating upstream subdevice (the "sensor") is connected directly to either the CSI mux or the

[PATCH v2 0/9] media: imx: Add better OF graph support

2017-12-14 Thread Steve Longerbeam
This is a set of patches that improve support for more complex OF graphs. Currently the imx-media driver only supports a single device with a single port connected directly to either the CSI muxes or the MIPI CSI-2 receiver input ports. There can't be a multi-port device in between. This patch set

[PATCH v2 4/9] media: staging/imx: remove devname string from imx_media_subdev

2017-12-14 Thread Steve Longerbeam
A separate string for the device name, for DEVNAME async match, was never needed. Just assign the asd device name to the passed platform device name pointer in imx_media_add_async_subdev(). Signed-off-by: Steve Longerbeam ---

[PATCH v2 2/9] media: staging/imx: remove static media link arrays

2017-12-14 Thread Steve Longerbeam
Remove the static list of media links that were formed at probe time. These links can instead be created after all registered async subdevices have been bound in imx_media_probe_complete(). The media links between subdevices that exist in the device tree, can be created post-async completion by

[PATCH v2 9/9] media: staging/imx: update TODO

2017-12-14 Thread Steve Longerbeam
Update TODO file: - Remove TODO info about the OV564x driver, while this still needs to be done (add a OV5642 driver or merge with OV5640 driver), it is not relevant here. - Update TODO about methods for retrieving CSI bus config. - Add some TODO's about OF graph parsing restrictions.

[PATCH v2 7/9] media: staging/imx: convert static vdev lists to list_head

2017-12-14 Thread Steve Longerbeam
Although not technically necessary because imx-media has only a maximum of 8 video devices, and once setup the video device lists are static, in anticipation of moving control ineritance to v4l2-core, make the vdev lists more generic by converting to dynamic list_head's. After doing that, 'struct

[PATCH v2 8/9] media: staging/imx: reorder function prototypes

2017-12-14 Thread Steve Longerbeam
Re-order some of the function prototypes in imx-media.h to group them correctly by source file. No functional changes. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media.h | 21 - 1 file changed, 12 insertions(+), 9

[PATCH v2 3/9] media: staging/imx: of: allow for recursing downstream

2017-12-14 Thread Steve Longerbeam
Calling of_parse_subdev() recursively to a downstream path that has already been followed is ok, it just means that call will return immediately since the subdevice was already added to the async list. With that there is no need to determine whether a subdevice's port is a sink or source, so

Re: [media] hdpvr: Fix an error handling path in hdpvr_probe()

2017-12-14 Thread Andrey Konovalov
On Fri, Dec 15, 2017 at 12:25 AM, Guenter Roeck wrote: > On Fri, Sep 22, 2017 at 06:37:06PM +0530, Arvind Yadav wrote: >> Here, hdpvr_register_videodev() is responsible for setup and >> register a video device. Also defining and initializing a worker. >>

Re: [PATCH/RFC v2 14/15] adv748x: csi2: add get_routing support

2017-12-14 Thread Kieran Bingham
Hi Niklas, On 14/12/17 19:08, Niklas Söderlund wrote: > To support multiplexed streams the internal routing between the > adv748x sink pad and its source pad needs to be described. The adv748x has quite a few sink and source pads... I presume here you mean the adv748x csi2 sink and source pad :D

Re: [media] hdpvr: Fix an error handling path in hdpvr_probe()

2017-12-14 Thread Guenter Roeck
On Fri, Sep 22, 2017 at 06:37:06PM +0530, Arvind Yadav wrote: > Here, hdpvr_register_videodev() is responsible for setup and > register a video device. Also defining and initializing a worker. > hdpvr_register_videodev() is calling by hdpvr_probe at last. > So No need to flash any work here. >

Re: [PATCH/RFC v2 13/15] adv748x: csi2: only allow formats on sink pads

2017-12-14 Thread Kieran Bingham
Hi Niklas, On 14/12/17 19:08, Niklas Söderlund wrote: > The driver is now pad and stream aware, only allow to get/set format on > sink pads. Ok - I can see the patch is doing this ... > Also record a different format for each sink pad since it's > no longer true that they are all the same But

Re: [PATCH/RFC v2 12/15] adv748x: csi2: switch to pad and stream aware s_stream

2017-12-14 Thread Kieran Bingham
Hi Niklas, On 14/12/17 19:08, Niklas Söderlund wrote: > Switch the driver to implement the pad and stream aware s_stream > operation. This is needed to enable to support to start and stop > individual streams on a multiplexed pad "This is needed to enable support for starting and stopping

Re: [PATCH/RFC v2 15/15] adv748x: afe: add routing support

2017-12-14 Thread Kieran Bingham
One more ... On 14/12/17 22:56, Kieran Bingham wrote: > Hi Niklas, > > On 14/12/17 19:08, Niklas Söderlund wrote: >> The adv748x afe have eight analog sink pads, currently one of them is > > s/have/has/ > >> chosen to be the active route based on device tree configuration. Whit > >

Re: [PATCH/RFC v2 15/15] adv748x: afe: add routing support

2017-12-14 Thread Kieran Bingham
Hi Niklas, On 14/12/17 19:08, Niklas Söderlund wrote: > The adv748x afe have eight analog sink pads, currently one of them is s/have/has/ > chosen to be the active route based on device tree configuration. Whit s/Whit/With/ > the new routeing API it's possible to control which of the eight

Re: [PATCH/RFC v2 10/15] adv748x: csi2: add translation from pixelcode to CSI-2 datatype

2017-12-14 Thread Kieran Bingham
Hi Niklas, On 14/12/17 19:08, Niklas Söderlund wrote: > This will be needed to fill out the frame descriptor information > correctly. > > Signed-off-by: Niklas Söderlund > --- > drivers/media/i2c/adv748x/adv748x-csi2.c | 22 ++ > 1

Re: [PATCH/RFC v2 09/15] adv748x: csi2: add module param for virtual channel

2017-12-14 Thread Kieran Bingham
Hi Niklas, On 14/12/17 19:08, Niklas Söderlund wrote: > The hardware can output on any of the 4 (0-3) Virtual Channels of the > CSI-2 bus. Add a module parameter each for TXA and TXB to allow the user > to specify which channel should be used. This patch only configures the channel at

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

2017-12-14 Thread Laurent Pinchart
Hi Mauro, On Thursday, 14 December 2017 23:50:03 EET Mauro Carvalho Chehab wrote: > Em Thu, 14 Dec 2017 21:57:06 +0100 Greg KH escreveu: > > On Thu, Dec 14, 2017 at 10:44:16PM +0200, Laurent Pinchart wrote: > >> On Thursday, 14 December 2017 22:08:51 EET Greg KH wrote: > >>> On Thu, Dec 14, 2017

[bug report] drx: add initial drx-d driver

2017-12-14 Thread Ralph Metzler
Hello Dan Carpenter, Dan Carpenter writes: > Hello Ralph Metzler, > > The patch 126f1e618870: "drx: add initial drx-d driver" from Mar 12, > 2011, leads to the following static checker warning: > > drivers/media/dvb-frontends/drxd_hard.c:1305 SC_WaitForReady() > info: return a

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

2017-12-14 Thread Mauro Carvalho Chehab
Em Thu, 14 Dec 2017 21:57:06 +0100 Greg KH escreveu: > On Thu, Dec 14, 2017 at 10:44:16PM +0200, Laurent Pinchart wrote: > > Hi Greg, > > > > On Thursday, 14 December 2017 22:08:51 EET Greg KH wrote: > > > On Thu, Dec 14, 2017 at 09:05:27PM +0200, Laurent Pinchart

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

2017-12-14 Thread Greg KH
On Thu, Dec 14, 2017 at 10:44:16PM +0200, Laurent Pinchart wrote: > Hi Greg, > > On Thursday, 14 December 2017 22:08:51 EET Greg KH wrote: > > On Thu, Dec 14, 2017 at 09:05:27PM +0200, Laurent Pinchart wrote: > > > On Thursday, 14 December 2017 20:54:39 EET Joe Perches wrote: > > >> On Thu,

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

2017-12-14 Thread Laurent Pinchart
Hi Greg, On Thursday, 14 December 2017 22:08:51 EET Greg KH wrote: > On Thu, Dec 14, 2017 at 09:05:27PM +0200, Laurent Pinchart wrote: > > On Thursday, 14 December 2017 20:54:39 EET Joe Perches wrote: > >> On Thu, 2017-12-14 at 20:37 +0200, Laurent Pinchart wrote: > >>> On Thursday, 14 December

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

2017-12-14 Thread Greg KH
On Thu, Dec 14, 2017 at 09:05:27PM +0200, Laurent Pinchart wrote: > Hi Joe, > > (CC'ing Greg and adding context for easier understanding) > > On Thursday, 14 December 2017 20:54:39 EET Joe Perches wrote: > > On Thu, 2017-12-14 at 20:37 +0200, Laurent Pinchart wrote: > > > On Thursday, 14

[PATCH/RFC v2 07/15] rcar-csi2: use frame description information to configure CSI-2 bus

2017-12-14 Thread Niklas Söderlund
The driver now have access to frame descriptor information, use it. Only enable the virtual channels which are described in the frame descriptor and calculate the link based on all enabled streams. With multiplexed stream support it's now possible to have different formats on the different source

[RFC 2/2] v4l2-ctl: add ROUTING get and set options

2017-12-14 Thread Niklas Söderlund
Signed-off-by: Niklas Söderlund --- utils/v4l2-ctl/Android.mk | 2 +- utils/v4l2-ctl/Makefile.am | 2 +- utils/v4l2-ctl/v4l2-ctl-routing.cpp | 154 utils/v4l2-ctl/v4l2-ctl.cpp | 10 +++

[PATCH/RFC v2 05/15] rcar-csi2: count usage for each source pad

2017-12-14 Thread Niklas Söderlund
The R-Car CSI-2 hardware can output the same virtual channel simultaneously to more then one R-Car VIN. For this reason we need to move the usage counting from the global device to each source pad. If a source pads usage count go from 0 to 1 we need to signal that a new stream should start,

[PATCH/RFC v2 08/15] rcar-csi2: add get_routing support

2017-12-14 Thread Niklas Söderlund
To support multiplexed streams the internal routing between the rcar-csi2 sink pad and its source pads needs to be described. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-csi2.c | 54 + 1 file

[RFC 0/2] v4l2-ctl: add ROUTING get and set options

2017-12-14 Thread Niklas Söderlund
Hi, This small series adds support for the [GS]_ROUTING subdev ioctls introduced in Sakari's vc branch. git://linuxtv.org/sailus/media_tree.git#vc The use-case for this is to control the internal routing between pads inside a subdevice. Currently this is used on the ADV7482 to select which

[PATCH/RFC v2 12/15] adv748x: csi2: switch to pad and stream aware s_stream

2017-12-14 Thread Niklas Söderlund
Switch the driver to implement the pad and stream aware s_stream operation. This is needed to enable to support to start and stop individual streams on a multiplexed pad. Signed-off-by: Niklas Söderlund --- drivers/media/i2c/adv748x/adv748x-csi2.c | 16

[PATCH/RFC v2 11/15] adv748x: csi2: implement get_frame_desc

2017-12-14 Thread Niklas Söderlund
Provide CSI-2 bus information for the multiplexed source pad using the frame descriptor. Signed-off-by: Niklas Söderlund --- drivers/media/i2c/adv748x/adv748x-csi2.c | 28 1 file changed, 28 insertions(+) diff --git

[PATCH/RFC v2 14/15] adv748x: csi2: add get_routing support

2017-12-14 Thread Niklas Söderlund
To support multiplexed streams the internal routing between the adv748x sink pad and its source pad needs to be described. Signed-off-by: Niklas Söderlund --- drivers/media/i2c/adv748x/adv748x-csi2.c | 22 ++ 1 file changed, 22

[PATCH/RFC v2 04/15] rcar-csi2: switch to pad and stream aware s_stream

2017-12-14 Thread Niklas Söderlund
Switch the driver to implement the pad and stream aware s_stream operation. This is needed to enable to support to start and stop individual streams on a multiplexed pad. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-csi2.c | 13

[PATCH/RFC v2 01/15] v4l2-subdev.h: add pad and stream aware s_stream

2017-12-14 Thread Niklas Söderlund
To be able to start and stop individual streams of a multiplexed pad the s_stream operation needs to be both pad and stream aware. Add a new operation to pad ops to facilitate this. Signed-off-by: Niklas Söderlund --- include/media/v4l2-subdev.h | 5 +

[RFC 1/2] Synchronize with the Kernel headers for routing operations

2017-12-14 Thread Niklas Söderlund
Signed-off-by: Niklas Söderlund --- include/linux/v4l2-subdev.h | 41 + 1 file changed, 41 insertions(+) diff --git a/include/linux/v4l2-subdev.h b/include/linux/v4l2-subdev.h index dbce2b554e026869..e19ee64075d6cbdf

[PATCH/RFC v2 15/15] adv748x: afe: add routing support

2017-12-14 Thread Niklas Söderlund
The adv748x afe have eight analog sink pads, currently one of them is chosen to be the active route based on device tree configuration. Whit the new routeing API it's possible to control which of the eight sink pads are routed to the source pad. Signed-off-by: Niklas Söderlund

[PATCH/RFC v2 06/15] rcar-csi2: use frame description information when propagating .s_stream()

2017-12-14 Thread Niklas Söderlund
Use the frame description from the remote subdevice of the rcar-csi2's sink pad to get the remote pad and stream pad needed to propagate the .s_stream() operation. The CSI-2 virtual channel which should be acted upon can be determined by looking at which of the rcar-csi2 source pad the

[PATCH/RFC v2 09/15] adv748x: csi2: add module param for virtual channel

2017-12-14 Thread Niklas Söderlund
The hardware can output on any of the 4 (0-3) Virtual Channels of the CSI-2 bus. Add a module parameter each for TXA and TXB to allow the user to specify which channel should be used. Signed-off-by: Niklas Söderlund ---

[PATCH/RFC v2 03/15] rcar-vin: use the pad and stream aware s_stream

2017-12-14 Thread Niklas Söderlund
To work with multiplexed streams the pad and stream aware s_stream operation needs to be used. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-dma.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH/RFC v2 00/15] Add multiplexed pad streaming support

2017-12-14 Thread Niklas Söderlund
Hi, This is the second attempt to add streaming support to multiplexed pads. The first attempt was not aware of Sakari's work. His work have now been taken into account and this series depends on his series together with the master of media-tree. git://linuxtv.org/sailus/media_tree.git#vc

[PATCH/RFC v2 13/15] adv748x: csi2: only allow formats on sink pads

2017-12-14 Thread Niklas Söderlund
The driver is now pad and stream aware, only allow to get/set format on sink pads. Also record a different format for each sink pad since it's no longer true that they are all the same Signed-off-by: Niklas Söderlund ---

[PATCH/RFC v2 02/15] rcar-vin: use pad as the starting point for a pipeline

2017-12-14 Thread Niklas Söderlund
The pipeline will be moved from the entity to the pads; reflect this in the media pipeline function API. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-dma.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH/RFC v2 10/15] adv748x: csi2: add translation from pixelcode to CSI-2 datatype

2017-12-14 Thread Niklas Söderlund
This will be needed to fill out the frame descriptor information correctly. Signed-off-by: Niklas Söderlund --- drivers/media/i2c/adv748x/adv748x-csi2.c | 22 ++ 1 file changed, 22 insertions(+) diff --git

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

2017-12-14 Thread Laurent Pinchart
Hi Joe, (CC'ing Greg and adding context for easier understanding) On Thursday, 14 December 2017 20:54:39 EET Joe Perches wrote: > On Thu, 2017-12-14 at 20:37 +0200, Laurent Pinchart wrote: > > On Thursday, 14 December 2017 20:32:20 EET Joe Perches wrote: > >> On Thu, 2017-12-14 at 20:28 +0200,

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

2017-12-14 Thread Joe Perches
On Thu, 2017-12-14 at 20:37 +0200, Laurent Pinchart wrote: > Hi Joe, Hi Laurent. > On Thursday, 14 December 2017 20:32:20 EET Joe Perches wrote: > > Adding a comment line that describes an implicit or > > explicit license is different than removing the license > > text itself. > > The SPDX

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

2017-12-14 Thread Laurent Pinchart
Hi Joe, On Thursday, 14 December 2017 20:32:20 EET Joe Perches wrote: > On Thu, 2017-12-14 at 20:28 +0200, Laurent Pinchart wrote: > > On Thursday, 14 December 2017 19:05:27 EET Mauro Carvalho Chehab wrote: > >> Em Fri, 8 Dec 2017 18:05:37 +0530 Dhaval Shah escreveu: > >>>

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

2017-12-14 Thread Joe Perches
On Thu, 2017-12-14 at 20:28 +0200, Laurent Pinchart wrote: > Hi Mauro, > > On Thursday, 14 December 2017 19:05:27 EET Mauro Carvalho Chehab wrote: > > Em Fri, 8 Dec 2017 18:05:37 +0530 Dhaval Shah escreveu: > > > SPDX-License-Identifier is used for the Xilinx Video IP and > > > related drivers.

Re: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

2017-12-14 Thread Philippe Ombredanne
On Thu, Dec 14, 2017 at 7:04 PM, Mauro Carvalho Chehab wrote: > Em Thu, 14 Dec 2017 17:32:34 + > "Bird, Timothy" escreveu: > >> > -Original Message- >> > From: Philippe on Thursday, December 14, 2017 6:25 AM >> > Dear Mauro, >> > >> > On

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

2017-12-14 Thread Laurent Pinchart
Hi Mauro, On Thursday, 14 December 2017 19:05:27 EET Mauro Carvalho Chehab wrote: > Em Fri, 8 Dec 2017 18:05:37 +0530 Dhaval Shah escreveu: > > SPDX-License-Identifier is used for the Xilinx Video IP and > > related drivers. > > > > Signed-off-by: Dhaval Shah > > Hi

Re: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

2017-12-14 Thread Philippe Ombredanne
Tim, On Thu, Dec 14, 2017 at 6:32 PM, Bird, Timothy wrote: > > >> -Original Message- >> From: Philippe on Thursday, December 14, 2017 6:25 AM >> Dear Mauro, >> >> On Thu, Dec 14, 2017 at 11:55 AM, Mauro Carvalho Chehab >> wrote: >> >> > SPDX

Re: [RESEND PATCH] partial revert of "[media] tvp5150: add HW input connectors support"

2017-12-14 Thread Mauro Carvalho Chehab
Em Thu, 14 Dec 2017 18:37:30 +0100 Javier Martinez Canillas escreveu: > Hello Mauro, > > On 12/14/2017 06:02 PM, Mauro Carvalho Chehab wrote: > > Em Wed, 6 Dec 2017 01:33:05 +0100 > > Javier Martinez Canillas escreveu: > > > >> Commit f7b4b54e6364

Re: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

2017-12-14 Thread Mauro Carvalho Chehab
Em Thu, 14 Dec 2017 17:32:34 + "Bird, Timothy" escreveu: > > -Original Message- > > From: Philippe on Thursday, December 14, 2017 6:25 AM > > Dear Mauro, > > > > On Thu, Dec 14, 2017 at 11:55 AM, Mauro Carvalho Chehab > > wrote: > > >

Re: [RESEND PATCH] partial revert of "[media] tvp5150: add HW input connectors support"

2017-12-14 Thread Javier Martinez Canillas
Hello Mauro, On 12/14/2017 06:02 PM, Mauro Carvalho Chehab wrote: > Em Wed, 6 Dec 2017 01:33:05 +0100 > Javier Martinez Canillas escreveu: > >> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") >> added input signals support for the tvp5150, but the

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

2017-12-14 Thread Mauro Carvalho Chehab
Em Thu, 14 Dec 2017 09:26:27 -0800 Joe Perches escreveu: > On Thu, 2017-12-14 at 15:05 -0200, Mauro Carvalho Chehab wrote: > > Em Fri, 8 Dec 2017 18:05:37 +0530 > > Dhaval Shah escreveu: > > > > > SPDX-License-Identifier is used for the Xilinx

RE: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

2017-12-14 Thread Bird, Timothy
> -Original Message- > From: Philippe on Thursday, December 14, 2017 6:25 AM > Dear Mauro, > > On Thu, Dec 14, 2017 at 11:55 AM, Mauro Carvalho Chehab > wrote: > > > SPDX is a new requirement that started late on Kernel 4.14 development > > cycle (and whose

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

2017-12-14 Thread Joe Perches
On Thu, 2017-12-14 at 15:05 -0200, Mauro Carvalho Chehab wrote: > Em Fri, 8 Dec 2017 18:05:37 +0530 > Dhaval Shah escreveu: > > > SPDX-License-Identifier is used for the Xilinx Video IP and > > related drivers. > > > > Signed-off-by: Dhaval Shah

[PATCH 03/10] media: imon: remove unused function tv2int

2017-12-14 Thread Sean Young
Since commit 9c7fd60e951d ("media: rc: Replace timeval with ktime_t in imon.c"), the function tv2int() is no longer used. Remove it. Signed-off-by: Sean Young --- drivers/media/rc/imon.c | 23 --- 1 file changed, 23 deletions(-) diff --git

[PATCH 04/10] media: rc: bang in ir_do_keyup

2017-12-14 Thread Sean Young
rc_keydown() can be called from interrupt context, by e.g. an rc scancode driver. Since commit b2c96ba352b5 ("media: cec: move cec autorepeat handling to rc-core"), the del_timer_sync() call is not happy about being called in interrupt connect. del_timer() will suffice. WARNING: CPU: 0 PID: 0 at

[PATCH 08/10] media: lirc: no need to recalculate duration

2017-12-14 Thread Sean Young
This is code existed for when drivers would send less than the whole buffer; no driver does this any more, so this is redundant. Drivers should return -EINVAL if they cannot send the entire buffer. Signed-off-by: Sean Young --- drivers/media/rc/lirc_dev.c | 10 +- 1 file

[PATCH 05/10] media: lirc: when transmitting scancodes, block until transmit is done

2017-12-14 Thread Sean Young
The semantics for lirc IR transmit with raw IR is that the write call should block until the IR is transmitted. Some drivers have no idea when this actually is (e.g. mceusb), so there is a wait. This is useful for userspace, as it might want to send a IR button press, a gap of a predefined number

[PATCH 09/10] media: lirc: release lock before sleep

2017-12-14 Thread Sean Young
There is no reason to hold the lock while we wait for the IR to transmit. Reported-by: Dan Carpenter Signed-off-by: Sean Young --- drivers/media/rc/lirc_dev.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH 06/10] media: rc: iguanair: simplify tx loop

2017-12-14 Thread Sean Young
Signed-off-by: Sean Young --- drivers/media/rc/iguanair.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c index 30e24da67226..7daac8bab83b 100644 --- a/drivers/media/rc/iguanair.c

[PATCH 07/10] media: lirc: do not pass ERR_PTR to kfree

2017-12-14 Thread Sean Young
If memdup_user() fails, txbuf will be an error pointer and passed to kfree. Reported-by: Dan Carpenter Signed-off-by: Sean Young --- drivers/media/rc/lirc_dev.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-)

[PATCH 01/10] media: imon: auto-config ffdc 26 device

2017-12-14 Thread Sean Young
Another device with the 0xffdc device id, this one with 0x26 in the config byte. Its an iMON Inside + iMON IR. It does respond to rc-6, but seems to produce random garbage rather than a scancode. Signed-off-by: Sean Young --- drivers/media/rc/imon.c | 5 + 1 file changed, 5

[PATCH 02/10] media: rc: mce_kbd: simplify key up

2017-12-14 Thread Sean Young
For key up, rather than iterating over 224 keys, just remember which key was pressed. Signed-off-by: Sean Young --- drivers/media/rc/ir-mce_kbd-decoder.c | 23 ++- drivers/media/rc/rc-core-priv.h | 1 + 2 files changed, 15 insertions(+), 9 deletions(-)

[PATCH 10/10] media: ir-spi: add SPDX identifier

2017-12-14 Thread Sean Young
From: Andi Shyti Replace the original license statement with the SPDX identifier. Update also the copyright owner adding myself as co-owner of the copyright. Signed-off-by: Andi Shyti Signed-off-by: Sean Young ---

Re: [PATCH] em28xx: split up em28xx_dvb_init to reduce stack size

2017-12-14 Thread Mauro Carvalho Chehab
Em Mon, 11 Dec 2017 13:05:02 +0100 Arnd Bergmann escreveu: > With CONFIG_KASAN, the init function uses a large amount of kernel stack: > > drivers/media/usb/em28xx/em28xx-dvb.c: In function 'em28xx_dvb_init.part.4': > drivers/media/usb/em28xx/em28xx-dvb.c:2061:1: error: the frame

Re: [GIT PULL FOR v4.16] media: imx: Add better OF graph support

2017-12-14 Thread Steve Longerbeam
On 12/14/2017 04:13 AM, Hans Verkuil wrote: On 08/12/17 23:48, Steve Longerbeam wrote: On 12/08/2017 08:38 AM, Mauro Carvalho Chehab wrote: Em Fri, 8 Dec 2017 11:56:58 +0100 Hans Verkuil escreveu: Note: the new v4l2-async work makes it possible to simplify this. That

Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier

2017-12-14 Thread Mauro Carvalho Chehab
Em Fri, 8 Dec 2017 18:05:37 +0530 Dhaval Shah escreveu: > SPDX-License-Identifier is used for the Xilinx Video IP and > related drivers. > > Signed-off-by: Dhaval Shah Hi Dhaval, You're not listed as one of the Xilinx driver maintainers.

Re: [RESEND PATCH] partial revert of "[media] tvp5150: add HW input connectors support"

2017-12-14 Thread Mauro Carvalho Chehab
Em Wed, 6 Dec 2017 01:33:05 +0100 Javier Martinez Canillas escreveu: > Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") > added input signals support for the tvp5150, but the approach was found > to be incorrect so the corresponding DT binding commit

Re: camss: camera controls missing on vfe interfaces

2017-12-14 Thread Mauro Carvalho Chehab
Em Mon, 20 Nov 2017 11:59:59 +0100 Daniel Mack escreveu: > Hi Todor, > > Thanks for following up! > > On Monday, November 20, 2017 09:32 AM, Todor Tomov wrote: > > On 15.11.2017 21:31, Daniel Mack wrote: > >> Todor et all, > >> > >> Any hint on how to tackle this? > >> >

Re: [PATCH v9 07/28] rcar-vin: change name of video device

2017-12-14 Thread Laurent Pinchart
Hi Sakari, On Thursday, 14 December 2017 16:25:00 EET Sakari Ailus wrote: > On Fri, Dec 08, 2017 at 10:17:36AM +0200, Laurent Pinchart wrote: > > On Friday, 8 December 2017 03:08:21 EET Niklas Söderlund wrote: > > > The rcar-vin driver needs to be part of a media controller to support > > > Gen3.

Re: [PATCH] Fix for hanging si2168 in PCTV 292e, making the code match

2017-12-14 Thread Mauro Carvalho Chehab
Em Tue, 19 Sep 2017 13:13:52 +0100 Nigel Kettlewell escreveu: > [re-sending as plain text] > > Fix for hanging si2168 in PCTV 292e USB, making the code match the comment. > > Using firmware v4.0.11 the 292e would work once and then hang on > subsequent

Re: [PATCH v4 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-12-14 Thread Hans Verkuil
On 14/12/17 00:35, Tim Harvey wrote: >>> Close. What is missing is a check of the AVI InfoFrame: if it has an >>> explicit >>> colorimetry then use that. E.g. check for HDMI_COLORIMETRY_ITU_601 or >>> ITU_709 >>> and set the colorspace accordingly. Otherwise fall back to what you have >>> here.

Re: [PATCH v4 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

2017-12-14 Thread Philippe Ombredanne
Dear Mauro, On Thu, Dec 14, 2017 at 11:55 AM, Mauro Carvalho Chehab wrote: > SPDX is a new requirement that started late on Kernel 4.14 development > cycle (and whose initial changes were merged directly at Linus tree). > Not all existing files have it yet, as

Re: [PATCH v9 07/28] rcar-vin: change name of video device

2017-12-14 Thread Sakari Ailus
On Fri, Dec 08, 2017 at 10:17:36AM +0200, Laurent Pinchart wrote: > Hi Niklas, > > (CC'ing Sakari) > > Thank you for the patch. > > On Friday, 8 December 2017 03:08:21 EET Niklas Söderlund wrote: > > The rcar-vin driver needs to be part of a media controller to support > > Gen3. Give each VIN

Re: [PATCH v2] media: s5p-mfc: Add support for V4L2_MEMORY_DMABUF type

2017-12-14 Thread Marek Szyprowski
Hi Hans, I would like to get your opinion on this patch. Do you think it makes sense to: 1. add limited support for USERPTR and DMA-buf import? (limited means driver will accept setting buffer pointer/fd only once after reqbufs for each buffer index) 2. add a V4L2 device flag to let

Re: [PATCH] pvrusb2: correctly return V4L2_PIX_FMT_MPEG in enum_fmt

2017-12-14 Thread Sakari Ailus
On Thu, Dec 14, 2017 at 12:44:42AM +0100, Hans Verkuil wrote: > The pvrusb2 code appears to have a some old workaround code for xawtv that > causes a > WARN() due to an unrecognized pixelformat 0 in v4l2_ioctl.c. > > Since all other MPEG drivers fill this in correctly, it is a safe assumption >

Re: Kernel Oopses from v4l_enum_fmt

2017-12-14 Thread Sakari Ailus
On Wed, Dec 13, 2017 at 05:04:28PM -0500, Nicolas Dufresne wrote: > Le mercredi 13 décembre 2017 à 22:33 +0100, Oleksandr Ostrenko a > écrit : > > Dear all, > > > > There is an issue in v4l_enum_fmt leading to kernel panic under > > certain > > circumstance. It happens while I try to capture

Re: [PATCH] [media] vb2: clear V4L2_BUF_FLAG_LAST when filling vb2_buffer

2017-12-14 Thread Sakari Ailus
Hi Philipp, On Fri, Dec 08, 2017 at 03:01:28PM +0100, Philipp Zabel wrote: > V4L2_BUF_FLAG_LAST is a signal from the driver to userspace for buffers > on the capture queue. When userspace queues back a capture buffer with > the flag set, we should clear it. > > Otherwise, if userspace restarts

Re: [RFC 1/1] v4l: async: Use endpoint node, not device node, for fwnode match

2017-12-14 Thread Sakari Ailus
Hi Jacopo, On Thu, Dec 14, 2017 at 12:44:38PM +0100, jacopo mondi wrote: > Hi Sakari, > > On Thu, Dec 14, 2017 at 12:53:42PM +0200, Sakari Ailus wrote: > > Hi Jacopo, > > > > On Thu, Dec 07, 2017 at 03:29:40PM +0100, jacopo mondi wrote: > > > Hi Sakari! > > > thanks for proposing this > > >

Re: [PATCH/RFC 1/2] v4l: v4l2-dev: Add infrastructure to protect device unplug race

2017-12-14 Thread Sakari Ailus
Hi Laurent, On Tue, Dec 12, 2017 at 04:42:23PM +0200, Laurent Pinchart wrote: ... > > > diff --git a/drivers/media/v4l2-core/v4l2-dev.c > > > b/drivers/media/v4l2-core/v4l2-dev.c index c647ba648805..c73c6d49e7cf > > > 100644 > > > --- a/drivers/media/v4l2-core/v4l2-dev.c > > > +++

Re: [GIT PULL FOR v4.16] media: imx: Add better OF graph support

2017-12-14 Thread Hans Verkuil
On 08/12/17 23:48, Steve Longerbeam wrote: > > > On 12/08/2017 08:38 AM, Mauro Carvalho Chehab wrote: >> Em Fri, 8 Dec 2017 11:56:58 +0100 >> Hans Verkuil escreveu: >> >>> Note: the new v4l2-async work makes it possible to simplify this. That >>> will be done in follow-up

Re: [PATCH v2 08/26] media: v4l2-async: shut up an unitialized symbol warning

2017-12-14 Thread Sakari Ailus
Hi folks, On Tue, Dec 12, 2017 at 12:13:59AM +0200, Laurent Pinchart wrote: > Hi Mauro, > > On Monday, 11 December 2017 20:10:58 EET Mauro Carvalho Chehab wrote: > > Em Thu, 02 Nov 2017 04:51:40 +0200 Laurent Pinchart escreveu: > > > On Wednesday, 1 November 2017 23:05:45 EET Mauro Carvalho

Re: [PATCH 2/2] Added timers for dvb_ca_en50221_write_data

2017-12-14 Thread Mauro Carvalho Chehab
Em Sun, 17 Sep 2017 03:27:22 +0200 "Jasmin J." escreveu: > From: Jasmin Jessich > > Some (older) CAMs are really slow in accepting data. The CI interface > specification doesn't define a handshake for accepted data. Thus, the > en50221 protocol driver can't

  1   2   >