Re: [PATCH] media: atomisp: convert default struct values to use compound-literals with designated initializers.

Hi Jeremy, On Tue, Dec 19, 2017 at 04:35:13PM +, Jeremy Sowden wrote: > diff --git > a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isp_param/interface/ia_css_isp_param_types.h > >

Re: [PATCH] media: ttpci/ttusb: add extra parameter to filter callbacks

Hi Mauro, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.16-rc3 next-20180223] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] media: ttpci/ttusb: add extra parameter to filter callbacks

Hi Mauro, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.16-rc3 next-20180223] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

cron job: media_tree daily build: WARNINGS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Feb 26 05:00:12 CET 2018 media-tree git hash:a7bc5773cd166032e35e343dfb6067a93d8402d1 media_build

[PATCH v3] media: radio: Critical interrupt bugfix for si470x over i2c

Fixed si470x_start() disabling the interrupt signal, causing tune operations to never complete. This does not affect USB radios because they poll the registers instead of using the IRQ line. Stylistic and comment changes from v2. Signed-off-by: Douglas Fischer ---

[PATCH v3] media: radio: Critical v4l2 registration bugfix for si470x over i2c

Added the call to v4l2_device_register() required to add a new radio device. Without this patch, it is impossible for the driver to load. This does not affect USB devices. Fixed cleanup order from v2. Signed-off-by: Douglas Fischer --- diff -uprN

[PATCH v3] media: radio: Tuning bugfix for si470x over i2c

Fixed si470x_set_channel() trying to tune before chip is turned on, which causes warnings in dmesg and when probing, makes driver wait for 3s for tuning timeout. This issue did not affect USB devices because they have a different probing sequence. Changed from v2: radio power check returns if

RE: [PATCH v5 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

Hi, all I sent the patch series of Sony CXD2880 DVB-T2/T tuner + demodulator driver version 5 on 18th/Jan. I'd like to get better understanding of current review status for our drivers. Are there any comments, advices and review results for them? Thanks, Takiguchi

drivers/media/common/videobuf2/videobuf2-core.c:1737: undefined reference to `v4l_vb2q_enable_media_source'

Hi Hans, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3664ce2d930983966d2aac0e167f1332988c4e25 commit: 7952be9b6ece3d3c4d61f9811d7e5a984580064a media: drivers/media/common/videobuf2: rename from videobuf date:

[PATCH] [media] ngene: add proper polling to the dvbdev_ci file ops

From: Daniel Scheller Implement the poll callback for the dvbdev_ci file ops. The ts_poll() function queries the DVB ring buffers for available data and space, and reports this as appropriate. Also, set the dvb_device readers, writers and users to proper values (one reader,

Startup delay playing radio channel from DVB-C

Hello I just recently acquired two pctv 292e triplestick USB DVB-C dongles for testing audio/video streaming on a Raspberry Pi 3. For a simple test I wanted to play back a radio station with mpg123 like: dvbv5-zap -c dvb_channel.conf "Sky Radio NL" -o - | ffmpeg -i - -c:a copy -f mp2 - |

[PATCH v2 12/12] [media] ngene: compensate for TS buffer offset shifts

From: Daniel Scheller A possible hardware bug was discovered when using CA addon hardware attached to the ngene hardware, in that the TS input buffer much likely will shift and thus become unaligned to 188 byte blocks (a full TS frame) when things like CA module

[PATCH v2 10/12] [media] ngene: don't treat non-existing demods as error

From: Daniel Scheller When probing the I2C busses in cineS2_probe(), it's no error when there's no hardware connected to the probed expansion connector, so print this informal message with info severity. Signed-off-by: Daniel Scheller ---

[PATCH v2 11/12] [media] ngene: move the tsin_exchange() stripcopy block into a function

From: Daniel Scheller Move the copy logic that will skip previously inserted TS NULL frames when moving data to the DVB ring buffers into an own function. This is done to not duplicate code all over the place with the following TS offset shift fixup patch. Signed-off-by:

[PATCH v2 06/12] [media] ngene: add support for Sony CXD28xx-based DuoFlex modules

From: Daniel Scheller Recognize (probe) and support (attach) all Sony CXD28xx based DuoFlex addon modules/cards, namely the DuoFlex CT2 (CXD2837), ISDB-T (CXD2838), C2T2 (CXD2843) and C2T2I (CXD2854). Since all these modules are equipped with a MachXO2 interface, that support

[PATCH v2 07/12] [media] ngene: add support for DuoFlex S2 V4 addon modules

From: Daniel Scheller Add support for the STV0910/STV6111/LNBH25 based DuoFlex S2 V4 DVB-S2 addon modules by recognizing them from their XO2 type value and using the auxiliary stv0910, stv6111 and lnbh25 driver to form a complete DVB frontend. This also adds autoselection

[PATCH v2 08/12] [media] ngene: deduplicate I2C adapter evaluation

From: Daniel Scheller The I2C adapter evaluation (based on chan->number) is duplicated at several places (tuner_attach_() functions, demod_attach_stv0900() and cineS2_probe()). Clean this up by wrapping that construct in a separate function which all users of that can pass

[PATCH v2 09/12] [media] ngene: check for CXD2099AR presence before attaching

From: Daniel Scheller Currently, if there's no CXD2099AR attached to any expansion connector of the ngene hardware, it will complain with this on every module load: cxd2099 1-0040: No CXD2099AR detected at 0x40 cxd2099: probe of 1-0040 failed with error -5 ngene

[PATCH v2 03/12] [media] ngene: use defines to identify the demod_type

From: Daniel Scheller Make it more clear which demod_type is used for which hardware by having defines for the possible demod_type values. With that, change the demod_type evaluation in tuner_attach_probe() to a switch-case instead of an if() for each possible value.

[PATCH v2 04/12] [media] ngene: support STV0367 DVB-C/T DuoFlex addons

From: Daniel Scheller Add support for STV0367+TDA18212 based DuoFlex CT addon modules. For this, add a demod probe function and all necessary demod/tuner attach functions which use existing auxiliary drivers (stv0367 and tda18212) to support this hardware. As tda18212 is an

[PATCH v2 00/12] ngene-updates: Hardware support, TS buffer shift fix

From: Daniel Scheller Sorry for this quick V2 of this series and thus sorry for the traffic, spam and noise. V1 missed a 188-byte clamping in tsin_find_offset() and a recheck for the remaining size of the TS buffer to copy after offset correction. Some love for the ngene

[PATCH v2 01/12] [media] ngene: add two additional PCI IDs

From: Daniel Scheller Add two more device IDs for cards supported by the ngene driver. Signed-off-by: Daniel Scheller --- drivers/media/pci/ngene/ngene-cards.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/pci/ngene/ngene-cards.c

[PATCH v2 02/12] [media] ngene: convert kernellog printing from printk() to dev_*() macros

From: Daniel Scheller Convert all printk() and pr_*() kernel log printing to rather use the dev_*() macros. Not only is it discouraged to use printk() (checkpatch even complains about that), but also this helps identifying the exact PCI device for any printed event, and it

[PATCH v2 05/12] [media] ngene: add XO2 module support

From: Daniel Scheller Detect and initialise modules equipped with XO2 interfaces (Lattice MachXO2). This requires a few more I2C transfer functions which this adds aswell. Defines for the different possible (available) module types are added to ngene.h. The support for the

[PATCH for 4.16] atomisp_fops.c: disable atomisp_compat_ioctl32

The atomisp_compat_ioctl32() code has problems. This patch disables the compat_ioctl32 support until those issues have been fixed. Contact Sakari or me for more details. Signed-off-by: Hans Verkuil Cc: # for v4.12 and up --- diff --git

Re: Bug: Two device nodes created in /dev for a single UVC webcam

Hi Alexandre-Xavier, On Sunday, 25 February 2018 10:19:51 EET Alexandre-Xavier Labonté-Lamoureux wrote: > Hi Laurent, > > Sorry for the late reply. > > I've been trying to reproduce the issue again. I cloned the entire > media repository later during the week and I haven't been able to >

drivers/media/dvb-frontends/stb0899_drv.h:151:36: error: weak declaration of 'stb0899_attach' being applied to a already existing, static definition

Hi Wolfgang, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3664ce2d930983966d2aac0e167f1332988c4e25 commit: 6cdeaed3b1420bd2569891be0c4123ff59628e9e media: dvb_usb_pctv452e: module refcount changes were

Re: Bug: Two device nodes created in /dev for a single UVC webcam

Hi Laurent, Sorry for the late reply. I've been trying to reproduce the issue again. I cloned the entire media repository later during the week and I haven't been able to reproduce the issue after I installed the modules. A metadata node is no longer created for my webcam. The four commits that