Re: [PATCH v5 0/2] media: video-i2c: add video-i2c driver support

On Mon, Mar 19, 2018 at 5:31 PM, Hans Verkuil wrote: > On 03/16/2018 03:47 AM, Matt Ranostay wrote: >> On Fri, Mar 9, 2018 at 10:26 AM, Matt Ranostay >> wrote: >>> On Fri, Mar 9, 2018 at 4:45 AM, Hans Verkuil wrote: Hi

cron job: media_tree daily build: WARNINGS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Mar 22 05:00:14 CET 2018 media-tree git hash:e68854a2588a923b31eebce348f8020374843f8e media_build

[trivial PATCH V2] treewide: Align function definition open/close braces

Some functions definitions have either the initial open brace and/or the closing brace outside of column 1. Move those braces to column 1. This allows various function analyzers like gnu complexity to work properly for these modified functions. Signed-off-by: Joe Perches

Re: [PATCH] media: uvcvideo: Prevent setting unavailable flags

Hi Kieran, Thank you for the patch. On Wednesday, 21 March 2018 17:43:08 EET Kieran Bingham wrote: > The addition of an extra operation to use the GET_INFO command > overwrites all existing flags from the uvc_ctrls table. This includes > setting all controls as supporting GET_MIN, GET_MAX,

Re: [PATCH] media: v4l2-common: fix a compilation breakage

Hi Mauro, On Wed, Mar 21, 2018 at 04:08:29PM -0400, Mauro Carvalho Chehab wrote: > Clearly, changeset 95ce9c28601a ("media: v4l: common: Add a > function to obtain best size from a list") was never tested, as it > broke compilation with: > > drivers/media/platform/vivid/vivid-vid-cap.c: In

[PATCH] media: v4l2-common: fix a compilation breakage

Clearly, changeset 95ce9c28601a ("media: v4l: common: Add a function to obtain best size from a list") was never tested, as it broke compilation with: drivers/media/platform/vivid/vivid-vid-cap.c: In function ‘vivid_try_fmt_vid_cap’: drivers/media/platform/vivid/vivid-vid-cap.c:565:34: error:

Re: uvcvideo: Unknown video format,00000032-0002-0010-8000-00aa00389b71

Le mercredi 21 mars 2018 à 10:55 +0200, Laurent Pinchart a écrit : > Hi Nicolas, > > On Wednesday, 21 March 2018 05:38:59 EET Nicolas Dufresne wrote: > > Le mardi 20 mars 2018 à 20:04 +0200, Laurent Pinchart a écrit : > > > On Tuesday, 20 March 2018 19:45:51 EET Nicolas Dufresne wrote: > > > > Le

Re: [PATCH 0/5] SPDX license identifiers in all DD drivers

On Wed, Mar 21, 2018 at 06:29:48PM +0100, Daniel Scheller wrote: > Hi Greg, > > Am Wed, 21 Mar 2018 10:49:32 +0100 > schrieb Greg KH : > > > On Tue, Mar 20, 2018 at 10:01:27PM +0100, Daniel Scheller wrote: > > > From: Daniel Scheller > > > > > >

[GIT PULL v2 FOR v4.17] cec: add error injection support + other improvements

Same as the previous git pull except for moving and slightly editing the CEC Pin Error Injection documentation and adding debugfs-cec-error-inj. Regards, Hans The following changes since commit 3f127ce11353fd1071cae9b65bc13add6aec6b90: media: em28xx-cards: fix em28xx_duplicate_dev()

[PATCH] media: doc: fix ReST link syntax

There is a ':' i excess, resulting in an unwanted ':' in the rendered output. Signed-off-by: Luca Ceresoli --- Documentation/media/kapi/v4l2-dev.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/media/kapi/v4l2-dev.rst

[PATCH] debugfs-cec-error-inj: document CEC error inj debugfs ABI

Document the core of the debugfs CEC error injection ABI. The driver specific commands are documented elsewhere and this file points to that documentation. Signed-off-by: Hans Verkuil --- Documentation/ABI/testing/debugfs-cec-error-inj | 40 +

Re: [PATCH 0/5] SPDX license identifiers in all DD drivers

Hi Greg, Am Wed, 21 Mar 2018 10:49:32 +0100 schrieb Greg KH : > On Tue, Mar 20, 2018 at 10:01:27PM +0100, Daniel Scheller wrote: > > From: Daniel Scheller > > > > This series adds SPDX license identifiers to all source files which are > >

[PATCHv3] cec-pin-error-inj.rst: document CEC Pin Error Injection

The CEC Pin framework adds support for Error Injection. Document all the error injections commands and how to use it. Signed-off-by: Hans Verkuil --- Changes since v2: - replace '.. code-block:: none' by :: - wrap to 80 columns - move to uapi/cec ---

Re: [PATCH 11/12] media: ov5640: Add 60 fps support

Hi Hugues, Thanks for all your feedback, I'll merge your suggested changes in the next iteration. On Tue, Mar 13, 2018 at 02:32:14PM +, Hugues FRUCHET wrote: > > if (fi->numerator == 0) { > > fi->denominator = maxfps; > > fi->numerator = 1; > > - return

Re: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

Hi Andy, On Wed, Mar 21, 2018 at 03:58:42PM +, Yeh, Andy wrote: > Thanks for the comments. A quick question first. For the reset we need some > time to address. > > -Original Message- > From: jacopo mondi [mailto:jac...@jmondi.org] > Sent: Tuesday, March 20, 2018 6:28 PM > To: Yeh,

RE: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

Thanks for the comments. A quick question first. For the reset we need some time to address. -Original Message- From: jacopo mondi [mailto:jac...@jmondi.org] Sent: Tuesday, March 20, 2018 6:28 PM To: Yeh, Andy Cc: linux-media@vger.kernel.org;

Re: [PATCHv2 6/7] cec-pin-error-inj.rst: document CEC Pin Error Injection

Em Mon, 5 Mar 2018 14:51:38 +0100 Hans Verkuil escreveu: > From: Hans Verkuil > > The CEC Pin framework adds support for Error Injection. > > Document all the error injections commands and how to use it. Please notice that all debugfs/sysfs

[PATCH] media: uvcvideo: Prevent setting unavailable flags

The addition of an extra operation to use the GET_INFO command overwrites all existing flags from the uvc_ctrls table. This includes setting all controls as supporting GET_MIN, GET_MAX, GET_RES, and GET_DEF regardless of whether they do or not. Move the initialisation of these control

Re: [PATCH 0/5] SPDX license identifiers in all DD drivers

Em Tue, 20 Mar 2018 22:01:27 +0100 Daniel Scheller escreveu: > Ralph, Manfred, I'm Cc'ing you on these five patches aswell, so if there > are any concerns left regarding the changes proposed by these patches, > please raise them. It should be the reverse:

Re: uvcvideo: Unknown video format,00000032-0002-0010-8000-00aa00389b71

Dear Laurent, On 03/21/2018 10:25 AM, Laurent Pinchart wrote: On Tuesday, 20 March 2018 18:46:24 EET Paul Menzel wrote: On 03/20/18 14:30, Laurent Pinchart wrote: On Tuesday, 20 March 2018 14:20:14 EET Paul Menzel wrote: On the Dell XPS 13 9370, Linux 4.16-rc6 outputs the messages below.

Re: [Linaro-mm-sig] [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

Am 21.03.2018 um 09:28 schrieb Daniel Vetter: On Tue, Mar 20, 2018 at 06:47:57PM +0100, Christian König wrote: Am 20.03.2018 um 15:08 schrieb Daniel Vetter: [SNIP] For the in-driver reservation path (CS) having a slow-path that grabs a temporary reference, drops the vram lock and then locks

Re: [PATCH v2] media: omap3isp: fix unbalanced dma_iommu_mapping

Hi Suman, Thank you for the patch. On Wednesday, 14 March 2018 17:41:36 EET Suman Anna wrote: > The OMAP3 ISP driver manages its MMU mappings through the IOMMU-aware > ARM DMA backend. The current code creates a dma_iommu_mapping and > attaches this to the ISP device, but never detaches the

Re: Double-free in /drivers/media/usb/zr364xx driver

Hi Linux Media Devs, There is a double free on error in zr364xx_probe(). The bug report explains it pretty well. v4l2_device_unregister() calls zr364xx_release() which frees "cam" but we also to another kfree(cam); before the "return err;". Please give reported by credit to: Reported-by:

Re: [PATCH 0/5] SPDX license identifiers in all DD drivers

On Tue, Mar 20, 2018 at 10:01:27PM +0100, Daniel Scheller wrote: > From: Daniel Scheller > > This series adds SPDX license identifiers to all source files which are > copyright by either Digital Devices GmbH or Metzlerbros GbR, who are > the original authors of the ddbridge,

Re: [PATCH 1/5] [media] stv0910/stv6111: add SPDX license headers

On Tue, Mar 20, 2018 at 10:01:28PM +0100, Daniel Scheller wrote: > From: Daniel Scheller > > Add SPDX license headers to the stv0910 and stv6111 DVB frontend > drivers. Both drivers are licensed as GPL-2.0-only, so fix this in the > MODULE_LICENSE while at it. Also, the

Re: [Linaro-mm-sig] [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

Am 21.03.2018 um 09:18 schrieb Daniel Vetter: [SNIP] They're both in i915_gem_userptr.c, somewhat interleaved. Would be interesting if you could show what you think is going wrong in there compared to amdgpu_mn.c. i915 implements only one callback: static const struct mmu_notifier_ops

Re: uvcvideo: Unknown video format,00000032-0002-0010-8000-00aa00389b71

Hi Paul, On Tuesday, 20 March 2018 18:46:24 EET Paul Menzel wrote: > On 03/20/18 14:30, Laurent Pinchart wrote: > > On Tuesday, 20 March 2018 14:20:14 EET Paul Menzel wrote: > >> On the Dell XPS 13 9370, Linux 4.16-rc6 outputs the messages below. > >> > >> ``` > > […] > > >> [2.340736]

Re: uvcvideo: Unknown video format,00000032-0002-0010-8000-00aa00389b71

Hi Nicolas, On Wednesday, 21 March 2018 05:38:59 EET Nicolas Dufresne wrote: > Le mardi 20 mars 2018 à 20:04 +0200, Laurent Pinchart a écrit : > > On Tuesday, 20 March 2018 19:45:51 EET Nicolas Dufresne wrote: > > > Le mardi 20 mars 2018 à 13:20 +0100, Paul Menzel a écrit : > > > > Dear Linux

[PATCH] media: ov5645: Use v4l2_find_nearest_size

Use v4l2_find_nearest_size instead of a driver specific function to find nearest matching size. Signed-off-by: Todor Tomov --- This depends on [1] from Sakari. Thank you, Sakari, this is nice. [1]

Re: [Linaro-mm-sig] [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

On Tue, Mar 20, 2018 at 06:47:57PM +0100, Christian König wrote: > Am 20.03.2018 um 15:08 schrieb Daniel Vetter: > > [SNIP] > > For the in-driver reservation path (CS) having a slow-path that grabs a > > temporary reference, drops the vram lock and then locks the reservation > > normally (using

Re: [Linaro-mm-sig] [PATCH 1/5] dma-buf: add optional invalidate_mappings callback v2

On Tue, Mar 20, 2018 at 06:47:57PM +0100, Christian König wrote: > Am 20.03.2018 um 15:08 schrieb Daniel Vetter: > > [SNIP] > > For the in-driver reservation path (CS) having a slow-path that grabs a > > temporary reference, drops the vram lock and then locks the reservation > > normally (using

Re: [PATCH] media: ov5645: add missing of_node_put() in error path

Thank you Akinobu. Acked-by: Todor Tomov On 20.03.2018 00:14, Akinobu Mita wrote: > The device node obtained with of_graph_get_next_endpoint() should be > released by calling of_node_put(). But it was not released when > v4l2_fwnode_endpoint_parse() failed. > > This

Re: [PATCH v3 2/2] staging: media: davinci_vpfe: add kfree() on goto err statement

Looks good. Thanks! regards, dan carpenter