RE: [RESEND PATCH v9 1/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil

2018-05-07 Thread Yeh, Andy
Dear reviewers, As the dt-binding patch has been accepted, would any help set the driver patch be accepted too? Any missing action from my side blocked the process. Thanks in advance. media: dw9807: Add dw9807 vcm driver https://patchwork.linuxtv.org/patch/49159/ Regards, Andy -Original

cron job: media_tree daily build: ERRORS

2018-05-07 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue May 8 05:00:12 CEST 2018 media-tree git hash:f10379aad39e9da8bc7d1822e251b5f0673067ef media_build

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

2018-05-07 Thread Sam Bobrowicz
> Hi, > > Here is a "small" series that mostly cleans up the ov5640 driver code, > slowly getting rid of the big data array for more understandable code > (hopefully). > > The biggest addition would be the clock rate computation at runtime, > instead of relying on those arrays to setup the clock

Re: [PATCH] [RESEND] [media] omap3isp: support 64-bit version of omap3isp_stat_data

2018-05-07 Thread Arnd Bergmann
On Mon, May 7, 2018 at 5:33 PM, Sakari Ailus wrote: > On Mon, May 07, 2018 at 04:36:45PM -0400, Arnd Bergmann wrote: >> On Mon, May 7, 2018 at 9:19 AM, Sakari Ailus wrote: >> > On Mon, May 07, 2018 at 04:17:32PM +0300, Laurent Pinchart wrote: >> >> On

Re: [PATCH 00/28] Venus updates

2018-05-07 Thread Stanimir Varbanov
Hi Hans, On 7.05.2018 13:41, Hans Verkuil wrote: On 24/04/18 14:44, Stanimir Varbanov wrote: Hello, This patch set aims to: * add initial support for Venus version 4xx (found on sdm845). * introduce a common capability parser to enumerate better supported uncompressed formats,

[PATCH][media-next] media: ddbridge: avoid out-of-bounds write on array demod_in_use

2018-05-07 Thread Colin King
From: Colin Ian King In function stop there is a check to see if state->demod is a stopped value of 0xff, however, later on, array demod_in_use is indexed with this value causing an out-of-bounds write error. Avoid this by only writing to array demod_in_use if

Re: [PATCH v2] media: media-device: fix ioctl function types

2018-05-07 Thread Sakari Ailus
On Mon, May 07, 2018 at 11:09:46AM -0700, Sami Tolvanen wrote: > This change fixes function types for media device ioctls to avoid > indirect call mismatches with Control-Flow Integrity checking. > > Signed-off-by: Sami Tolvanen Kiitos! Acked-by: Sakari Ailus

Re: [PATCH] [RESEND] [media] omap3isp: support 64-bit version of omap3isp_stat_data

2018-05-07 Thread Sakari Ailus
On Mon, May 07, 2018 at 04:36:45PM -0400, Arnd Bergmann wrote: > On Mon, May 7, 2018 at 9:19 AM, Sakari Ailus wrote: > > On Mon, May 07, 2018 at 04:17:32PM +0300, Laurent Pinchart wrote: > >> On Thursday, 26 April 2018 00:30:10 EEST Arnd Bergmann wrote: > >> > +int

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-05-07 Thread Arnd Bergmann
On Mon, May 7, 2018 at 5:05 AM, Hans Verkuil wrote: > On 25/04/18 19:22, Mauro Carvalho Chehab wrote: >> Em Wed, 25 Apr 2018 17:58:25 +0200 >> Arnd Bergmann escreveu: >> >>> On Wed, Apr 25, 2018 at 5:26 PM, Christoph Hellwig >>> wrote:

[PATCH v2] media: v4l2-ioctl: fix function types for IOCTL_INFO_STD

2018-05-07 Thread Sami Tolvanen
This change fixes indirect call mismatches with Control-Flow Integrity checking, which are caused by calling standard ioctls using a function pointer that doesn't match the type of the actual function. Signed-off-by: Sami Tolvanen ---

Re: [PATCH] [RESEND] [media] omap3isp: support 64-bit version of omap3isp_stat_data

2018-05-07 Thread Arnd Bergmann
On Mon, May 7, 2018 at 9:19 AM, Sakari Ailus wrote: > On Mon, May 07, 2018 at 04:17:32PM +0300, Laurent Pinchart wrote: >> On Thursday, 26 April 2018 00:30:10 EEST Arnd Bergmann wrote: >> > +int omap3isp_stat_request_statistics_time32(struct ispstat *stat, >> > +

Re: [PATCH 28/28] venus: add HEVC codec support

2018-05-07 Thread Stanimir Varbanov
Hi Hans, On 7.05.2018 13:39, Hans Verkuil wrote: On 24/04/18 14:44, Stanimir Varbanov wrote: This add HEVC codec support for venus versions 3xx and 4xx. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 3 +++

Re: [PATCH 0/2] media: imx: add capture support for RGB565_2X8 on parallel bus

2018-05-07 Thread Steve Longerbeam
On 05/07/2018 07:23 AM, Jan Lübbe wrote: Hi Steve, thanks for reviewing! On Sat, 2018-05-05 at 15:22 -0700, Steve Longerbeam wrote: I reviewed this patch series, and while I don't have any objections to the code-level changes, but my question is more specifically about how the IPU/CSI deals

[PATCH v2] media: media-device: fix ioctl function types

2018-05-07 Thread Sami Tolvanen
This change fixes function types for media device ioctls to avoid indirect call mismatches with Control-Flow Integrity checking. Signed-off-by: Sami Tolvanen --- drivers/media/media-device.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-)

Re: [PATCHv13 12/28] v4l2-ctrls: add core request support

2018-05-07 Thread Mauro Carvalho Chehab
Em Thu, 3 May 2018 16:53:02 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Integrate the request support. This adds the v4l2_ctrl_request_complete > and v4l2_ctrl_request_setup functions to complete a request and (as a > helper function) to

Re: [PATCH v3 11/14] media: platform: Add Sunxi-Cedrus VPU decoder driver

2018-05-07 Thread kbuild test robot
Hi Paul, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.17-rc4 next-20180507] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v5 0/8] Add support for multi-planar formats and 10 bit formats

2018-05-07 Thread Hyun Kwon
Hi Hans, Thanks for the comment. On Mon, 2018-05-07 at 05:59:39 -0700, Hans Verkuil wrote: > Hi Satish, > > On 03/05/18 04:42, Satish Kumar Nagireddy wrote: > > The patches are for xilinx v4l. The patcheset enable support to handle > > multiplanar > > formats and 10 bit formats. Single

Re: [PATCHv13 09/28] v4l2-ctrls: prepare internal structs for request API

2018-05-07 Thread Mauro Carvalho Chehab
Em Thu, 3 May 2018 16:52:59 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Embed and initialize a media_request_object in struct v4l2_ctrl_handler. > > Add a p_req field to struct v4l2_ctrl_ref that will store the > request value. > >

Re: [PATCHv13 06/28] v4l2-dev: lock req_queue_mutex

2018-05-07 Thread Mauro Carvalho Chehab
Em Thu, 3 May 2018 16:52:56 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > We need to serialize streamon/off with queueing new requests. > These ioctls may trigger the cancellation of a streaming > operation, and that should not be mixed with

Re: [PATCHv13 05/28] media-request: add media_request_object_find

2018-05-07 Thread Mauro Carvalho Chehab
Em Fri, 4 May 2018 15:43:07 +0300 Sakari Ailus escreveu: > On Thu, May 03, 2018 at 04:52:55PM +0200, Hans Verkuil wrote: > > From: Hans Verkuil > > > > Add media_request_object_find to find a request object inside a > > request based on ops and/or

Re: [PATCHv13 04/28] media-request: add media_request_get_by_fd

2018-05-07 Thread Mauro Carvalho Chehab
Em Thu, 3 May 2018 16:52:54 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Add media_request_get_by_fd() to find a request based on the file > descriptor. > > The caller has to call media_request_put() for the returned > request since this

Re: [PATCH v3 00/13] media: imx: Switch to subdev notifiers

2018-05-07 Thread Steve Longerbeam
On 05/07/2018 07:20 AM, Hans Verkuil wrote: Steve, Sakari, Any progress on this? The imx7 patch series depends on this so that can't move forward until this is merged. Hi Hans, I've been working on the updates and will submit v4 today. Steve On 21/03/18 01:37, Steve Longerbeam wrote:

Re: [PATCH v2 08/15] media: dt-bindings: add bindings for i.MX7 media driver

2018-05-07 Thread Rui Miguel Silva
Hi Rob, Thanks for the review and sorry for the late reply. Meanwhile I have send v3 of this series with some of yours comments incorporated. On Fri 27 Apr 2018 at 19:06, Rob Herring wrote: On Mon, Apr 23, 2018 at 02:47:43PM +0100, Rui Miguel Silva wrote: Add bindings documentation for

[PATCH v3 14/14] media: staging/imx: add i.MX7 entries to TODO file

2018-05-07 Thread Rui Miguel Silva
Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5ca5324

[PATCH v3 13/14] media: imx7.rst: add documentation for i.MX7 media driver

2018-05-07 Thread Rui Miguel Silva
Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva --- Documentation/media/v4l-drivers/imx7.rst | 157 ++

[PATCH v3 11/14] ARM: dts: imx7s: add capture subsystem

2018-05-07 Thread Rui Miguel Silva
Add media capture subsystem device to i.MX7 definitions. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index 0bae41f2944c..058e0cbf8ee7

[PATCH v3 12/14] ARM: dts: imx7s-warp: add ov2680 sensor node

2018-05-07 Thread Rui Miguel Silva
Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Add the needed regulator to the analog voltage supply. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s-warp.dts | 27

[PATCH v3 07/14] media: dt-bindings: add bindings for i.MX7 media driver

2018-05-07 Thread Rui Miguel Silva
Add bindings documentation for i.MX7 media drivers. Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/imx7.txt| 152 ++ 1 file changed, 152 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/imx7.txt diff

[PATCH v3 05/14] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2018-05-07 Thread Rui Miguel Silva
Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1154 2 files changed, 1155

[PATCH v3 02/14] media: staging/imx7: add imx7 CSI subdev driver

2018-05-07 Thread Rui Miguel Silva
This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Kconfig |9 +- drivers/staging/media/imx/Makefile |2 +

[PATCH v3 10/14] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2018-05-07 Thread Rui Miguel Silva
This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Also add the pin control related with the mipi_csi in that board. Signed-off-by: Rui Miguel Silva

[PATCH v3 06/14] media: staging/imx: add imx7 capture subsystem

2018-05-07 Thread Rui Miguel Silva
Add imx7 capture subsystem to imx-media core to allow the use some of the existing modules for i.MX5/6 with i.MX7 SoC. Since i.MX7 does not have an IPU, add driver data with unset ipu_present flag that change some runtime behaviors. Signed-off-by: Rui Miguel Silva ---

[PATCH v3 03/14] clk: imx7d: fix mipi dphy div parent

2018-05-07 Thread Rui Miguel Silva
Fix the mipi dphy root divider to mipi_dphy_pre_div, this would remove a orphan clock and set the correct parent. before: cat clk_orphan_summary enable prepare protect clock countcountcountrate accuracy phase

[PATCH v3 09/14] ARM: dts: imx7s: add multiplexer controls

2018-05-07 Thread Rui Miguel Silva
The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 8 +++- 1 file

[PATCH v3 04/14] clk: imx7d: reset parent for mipi csi root

2018-05-07 Thread Rui Miguel Silva
To guarantee that we do not get Overflow in image FIFO the outer bandwidth has to be faster than inputer bandwidth. For that it must be possible to set a faster frequency clock. So set new parent to sys_pfd3 clock for the mipi csi block. Cc: linux-...@vger.kernel.org Acked-by: Shawn Guo

[PATCH v3 08/14] ARM: dts: imx7s: add mipi phy power domain

2018-05-07 Thread Rui Miguel Silva
Add power domain index 0 related with mipi-phy to imx7s. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi index 4d42335c0dee..67450ad89940

[PATCH v3 01/14] media: staging/imx: add support to media dev for no IPU systems

2018-05-07 Thread Rui Miguel Silva
Some i.MX SoC do not have IPU, like the i.MX7, add to the the media device infrastructure support to be used in this type of systems that do not have internal subdevices besides the CSI. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/imx-media-dev.c | 38

[PATCH v3 00/14] media: staging/imx7: add i.MX7 media driver

2018-05-07 Thread Rui Miguel Silva
Hi, This series introduces the Media driver to work with the i.MX7 SoC. it uses the already existing imx media core drivers but since the i.MX7, contrary to i.MX5/6, do not have an IPU and because of that some changes in the imx media core are made along this series to make it support that case.

Re: [PATCH v3 1/3] [media] dvb_frontend: add S2X and misc. other enums

2018-05-07 Thread Daniel Scheller
Am Fri, 4 May 2018 12:51:02 -0300 schrieb Mauro Carvalho Chehab : > Em Tue, 13 Mar 2018 23:18:03 +0100 > Daniel Scheller escreveu: > > > From: Daniel Scheller > > > > Additional enums: > > * FEC ratios 1/4 and 1/3 > >

[PATCH 4/4] media: ov2680: add regulators to supply control

2018-05-07 Thread Rui Miguel Silva
Add the code to control the regulators for the analogue and digital power supplies. Signed-off-by: Rui Miguel Silva --- drivers/media/i2c/ov2680.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/media/i2c/ov2680.c

[PATCH 3/4] media: ov2680: rename powerdown gpio and fix polarity

2018-05-07 Thread Rui Miguel Silva
Rename the power control gpio to reset, since it is the same, and fix the polarity code since this gpio is active at low and not at high as controlled before. Signed-off-by: Rui Miguel Silva --- drivers/media/i2c/ov2680.c | 20 ++-- 1 file changed, 10

[PATCH 1/4] media: ov2680: dt: add voltage supplies as required

2018-05-07 Thread Rui Miguel Silva
The ov2680 needs to control 3 regulators for the voltage supplies and that was missing by the first description, added their description and example here. Signed-off-by: Rui Miguel Silva --- Documentation/devicetree/bindings/media/i2c/ov2680.txt | 8 +++- 1 file

[PATCH 2/4] media: ov2680: dt: rename gpio to reset and fix polarity

2018-05-07 Thread Rui Miguel Silva
Since the GPIO 3 controls both reset and powerdown, we rename it to reset. Fix the polarity of this, as it is a low active signal and not an high active. As at it, rename the mipi endpoint in the example to be coherent with the a real case that will be introduce for imx7 media driver.

[PATCH 0/4] media: ov2680: follow up from initial version

2018-05-07 Thread Rui Miguel Silva
Sorry I have Out-of-Office some part of last week, I had v6 of the original series ready but since I have received the notification from patchwork that the v5 was accepted, I am sending this as a follow up tha address Fabio comments. - this adds the power supplies to this sensor - fix gpio

Re: [PATCH v2 7/7] media: rc: mceusb: allow the timeout to be configurable

2018-05-07 Thread Matthias Reichl
Hi Sean! [ I trimmed the Cc list, as this is mceusb specific ] On Sat, Apr 21, 2018 at 07:41:21PM +0200, Matthias Reichl wrote: > On Sat, Apr 21, 2018 at 03:18:52PM +0200, Matthias Reichl wrote: > > Another bug report came in, button press results in multiple > > key down/up events > >

Re: [PATCHv13 01/28] v4l2-device.h: always expose mdev

2018-05-07 Thread Mauro Carvalho Chehab
Em Fri, 4 May 2018 13:51:28 +0300 Sakari Ailus escreveu: > On Thu, May 03, 2018 at 04:52:51PM +0200, Hans Verkuil wrote: > > From: Hans Verkuil > > > > The mdev field is only present if CONFIG_MEDIA_CONTROLLER is set. > > But since we will need to

Re: [PATCH v3 11/14] media: platform: Add Sunxi-Cedrus VPU decoder driver

2018-05-07 Thread Maxime Ripard
On Mon, May 07, 2018 at 02:44:57PM +0200, Paul Kocialkowski wrote: > +#define SYSCON_SRAM_CTRL_REG00x0 > +#define SYSCON_SRAM_C1_MAP_VE0x7fff This isn't needed anymore > + dev->ahb_clk = devm_clk_get(dev->dev, "ahb"); > + if (IS_ERR(dev->ahb_clk)) { > +

Re: [PATCH] media: vsp1: cleanup a false positive warning

2018-05-07 Thread Mauro Carvalho Chehab
Em Mon, 07 May 2018 17:05:24 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > Thank you for the patch. > > On Friday, 4 May 2018 15:13:58 EEST Mauro Carvalho Chehab wrote: > > With the new vsp1 code changes introduced by changeset > > f81f9adc4ee1 ("media:

Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

2018-05-07 Thread Laurent Pinchart
Hi Guennadi, On Monday, 7 May 2018 18:12:14 EEST Guennadi Liakhovetski wrote: > On Mon, 7 May 2018, Laurent Pinchart wrote: > > On Tuesday, 10 April 2018 14:31:35 EEST Guennadi Liakhovetski wrote: > >> On Fri, 23 Mar 2018, Laurent Pinchart wrote: > >>> On Friday, 23 March 2018 11:24:00 EET

Re: Are media drivers abusing of GFP_DMA? - was: Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

2018-05-07 Thread Mauro Carvalho Chehab
Em Mon, 07 May 2018 16:26:08 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Saturday, 5 May 2018 19:08:15 EEST Mauro Carvalho Chehab wrote: > > There was a recent discussion about the use/abuse of GFP_DMA flag when > > allocating memories at LSF/MM 2018

Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

2018-05-07 Thread Guennadi Liakhovetski
Hi Laurent, Thanks for the replies. One follow-up question: On Mon, 7 May 2018, Laurent Pinchart wrote: > Hi Guennadi, > > On Tuesday, 10 April 2018 14:31:35 EEST Guennadi Liakhovetski wrote: > > On Fri, 23 Mar 2018, Laurent Pinchart wrote: > > > On Friday, 23 March 2018 11:24:00 EET Laurent

Re: [PATCH v7 2/2] uvcvideo: handle control pipe protocol STALLs

2018-05-07 Thread Laurent Pinchart
Hi Guennadi, On Wednesday, 11 April 2018 15:44:00 EEST Guennadi Liakhovetski wrote: > On Sat, 7 Apr 2018, Laurent Pinchart wrote: > > On Friday, 23 March 2018 11:24:01 EEST Laurent Pinchart wrote: > >> From: Guennadi Liakhovetski > >> > >> When a command ends up in a

Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

2018-05-07 Thread Laurent Pinchart
Hi Guennadi, On Thursday, 26 April 2018 12:28:42 EEST Guennadi Liakhovetski wrote: > On Tue, 10 Apr 2018, Guennadi Liakhovetski wrote: > > [snip] > > >>> @@ -1488,6 +1591,25 @@ int uvc_ctrl_set(struct uvc_video_chain *chain, > >>> return -EINVAL; > >>> if (!(ctrl->info.flags &

Re: [PATCH v5 08/14] media: ov772x: support device tree probing

2018-05-07 Thread Akinobu Mita
2018-05-07 18:26 GMT+09:00 Sakari Ailus : > Dear Mita-san, > > On Sun, May 06, 2018 at 11:19:23PM +0900, Akinobu Mita wrote: >> The ov772x driver currently only supports legacy platform data probe. >> This change enables device tree probing. >> >> Note that the

Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

2018-05-07 Thread Laurent Pinchart
Hi Guennadi, On Tuesday, 10 April 2018 14:31:35 EEST Guennadi Liakhovetski wrote: > On Fri, 23 Mar 2018, Laurent Pinchart wrote: > > On Friday, 23 March 2018 11:24:00 EET Laurent Pinchart wrote: > >> From: Guennadi Liakhovetski > >> > >> UVC defines a method of handling

Re: [PATCH v3 00/14] Sunxi-Cedrus driver for the Allwinner Video Engine, using media requests

2018-05-07 Thread Paul Kocialkowski
[...] On Mon, 2018-05-07 at 14:44 +0200, Paul Kocialkowski wrote: > Remaining tasks: > * cleaning up registers description and documenting the fields used; > * removing the assigned-clocks property and setting the clock rate > in the driver directly; > * checking the series with checkpatch and

Re: [PATCH 0/2] media: imx: add capture support for RGB565_2X8 on parallel bus

2018-05-07 Thread Jan Lübbe
Hi Steve, thanks for reviewing! On Sat, 2018-05-05 at 15:22 -0700, Steve Longerbeam wrote: > I reviewed this patch series, and while I don't have any > objections to the code-level changes, but my question > is more specifically about how the IPU/CSI deals with > receiving RGB565 over a parallel

Re: [PATCH v3 00/13] media: imx: Switch to subdev notifiers

2018-05-07 Thread Hans Verkuil
Steve, Sakari, Any progress on this? The imx7 patch series depends on this so that can't move forward until this is merged. Regards, Hans On 21/03/18 01:37, Steve Longerbeam wrote: > This patchset converts the imx-media driver and its dependent > subdevs to use subdev notifiers. > >

Re: [PATCH v3 10/14] dt-bindings: media: Document bindings for the Sunxi-Cedrus VPU driver

2018-05-07 Thread Rob Herring
On Mon, May 07, 2018 at 02:44:56PM +0200, Paul Kocialkowski wrote: > This adds a device-tree binding document that specifies the properties > used by the Sunxi-Cedurs VPU driver, as well as examples. > > Signed-off-by: Paul Kocialkowski > --- >

Re: [PATCH] media: vsp1: cleanup a false positive warning

2018-05-07 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Friday, 4 May 2018 15:13:58 EEST Mauro Carvalho Chehab wrote: > With the new vsp1 code changes introduced by changeset > f81f9adc4ee1 ("media: v4l: vsp1: Assign BRU and BRS to pipelines > dynamically"), smatch complains with: >

Re: [PATCH v3 11/14] media: platform: Add Sunxi-Cedrus VPU decoder driver

2018-05-07 Thread Hans Verkuil
On 07/05/18 14:44, Paul Kocialkowski wrote: > This introduces the Sunxi-Cedrus VPU driver that supports the VPU found > in Allwinner SoCs, also known as Video Engine. It is implemented through > a v4l2 m2m decoder device and a media device (used for media requests). > So far, it only supports

Re: [PATCH] dma-buf: Remove unneeded stubs around sync_debug interfaces

2018-05-07 Thread Daniel Vetter
On Fri, May 04, 2018 at 03:00:37PM -0300, Ezequiel Garcia wrote: > The sync_debug.h header is internal, and only used by > sw_sync.c. Therefore, SW_SYNC is always defined and there > is no need for the stubs. Remove them and make the code > simpler. > > Signed-off-by: Ezequiel Garcia

Re: [PATCH v3 08/14] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-05-07 Thread Paul Kocialkowski
Hi Hans, On Mon, 2018-05-07 at 15:49 +0200, Hans Verkuil wrote: > On 07/05/18 14:44, Paul Kocialkowski wrote: > > From: Florent Revest > > > > Stateless video decoding engines require both the MPEG slices and > > associated metadata from the video stream in

Re: [PATCH v3 09/14] media: v4l: Add definition for Allwinner's MB32-tiled NV12 format

2018-05-07 Thread Hans Verkuil
On 07/05/18 14:44, Paul Kocialkowski wrote: > This introduces support for Allwinner's MB32-tiled NV12 format, where > each plane is divided into macroblocks of 32x32 pixels. Hence, the size > of each plane has to be aligned to 32 bytes. The pixels inside each > macroblock are coded as they would

Re: [PATCH v3 08/14] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-05-07 Thread Hans Verkuil
On 07/05/18 14:44, Paul Kocialkowski wrote: > From: Florent Revest > > Stateless video decoding engines require both the MPEG slices and > associated metadata from the video stream in order to decode frames. > > This introduces definitions for a new pixel

Re: [PATCH v9 07/15] v4l: mark unordered formats

2018-05-07 Thread Hans Verkuil
On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan > > Now that we've introduced the V4L2_FMT_FLAG_UNORDERED flag, > mark the appropriate formats. > > Signed-off-by: Gustavo Padovan > --- >

Re: Are media drivers abusing of GFP_DMA? - was: Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

2018-05-07 Thread Laurent Pinchart
Hi Mauro, On Saturday, 5 May 2018 19:08:15 EEST Mauro Carvalho Chehab wrote: > There was a recent discussion about the use/abuse of GFP_DMA flag when > allocating memories at LSF/MM 2018 (see Luis notes enclosed). > > The idea seems to be to remove it, using CMA instead. Before doing that, >

Re: [PATCH 2/2] omap3isp: Don't use GFP_DMA

2018-05-07 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Monday, 7 May 2018 15:47:23 EEST Sakari Ailus wrote: > The isp stat driver allocates memory for DMA and uses GFP_DMA flag for > dev_alloc_coherent. The flag is no longer needed as the DMA mask is used > for the purpose. Remove it. > > Reported-by: Mauro

Re: [PATCH 1/2] omap3isp: Remove useless NULL check in omap3isp_stat_config

2018-05-07 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Monday, 7 May 2018 15:47:22 EEST Sakari Ailus wrote: > The omap3isp driver checked whether the second argument (the new > configuration) to the ISP statistics is NULL. This is the pointer to the > user-given argument and is never NULL. Remove the check. >

Re: [PATCH] [RESEND] [media] omap3isp: support 64-bit version of omap3isp_stat_data

2018-05-07 Thread Sakari Ailus
On Mon, May 07, 2018 at 04:17:32PM +0300, Laurent Pinchart wrote: > Hi Arnd, > > Thank you for the patch. > > On Thursday, 26 April 2018 00:30:10 EEST Arnd Bergmann wrote: > > C libraries with 64-bit time_t use an incompatible format for > > struct omap3isp_stat_data. This changes the kernel

Re: [PATCH] [RESEND] [media] omap3isp: support 64-bit version of omap3isp_stat_data

2018-05-07 Thread Laurent Pinchart
Hi Arnd, Thank you for the patch. On Thursday, 26 April 2018 00:30:10 EEST Arnd Bergmann wrote: > C libraries with 64-bit time_t use an incompatible format for > struct omap3isp_stat_data. This changes the kernel code to > support either version, by moving over the normal handling > to the

Re: [PATCH v5 0/8] Add support for multi-planar formats and 10 bit formats

2018-05-07 Thread Hans Verkuil
Hi Satish, On 03/05/18 04:42, Satish Kumar Nagireddy wrote: > The patches are for xilinx v4l. The patcheset enable support to handle > multiplanar > formats and 10 bit formats. Single planar implementation is removed as > mplane can > handle both. If I understand the format correctly, then

Re: [PATCH v9 15/15] v4l: Document explicit synchronization behavior

2018-05-07 Thread Hans Verkuil
On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan > > Add section to VIDIOC_QBUF and VIDIOC_QUERY_BUF about it > > v8: amend querybuf documentation. > > v7: minor issues and English improvements (Hans Verkuil) > > v6: Close some gaps in the docs

[PATCH v3 04/14] ARM: dts: sun7i-a20: Use dedicated SRAM controller compatible

2018-05-07 Thread Paul Kocialkowski
Use the newly-introduced SRAM controller compatible for the A20 instead of its A10 fashion. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun7i-a20.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi

[PATCH v3 00/14] Sunxi-Cedrus driver for the Allwinner Video Engine, using media requests

2018-05-07 Thread Paul Kocialkowski
This presents a third iteration of the updated Sunxi-Cedrus driver, that supports the Video Engine found in most Allwinner SoCs, starting with the A10. It was tested on the A13, A20 and A33. The initial version of this driver[0] was originally written and submitted by Florent Revest using a

[PATCH v3 12/14] ARM: dts: sun5i: Add Video Engine and reserved memory nodes

2018-05-07 Thread Paul Kocialkowski
This adds nodes for the Video Engine and the associated reserved memory for sun5i-based platforms. Up to 96 MiB of memory are dedicated to the CMA pool. The VPU can only map the first 256 MiB of DRAM, so the reserved memory pool has to be located in that area. Following Allwinner's decision in

[PATCH v3 01/14] drivers: soc: sunxi: Add support for the C1 SRAM region

2018-05-07 Thread Paul Kocialkowski
From: Maxime Ripard This introduces support for the SRAM C1 section, that is controlled by the system controller. This SRAM area can be muxed either to the CPU or the Video Engine, that needs this area to store various tables (e.g. the Huffman VLD decoding tables).

[PATCH v3 11/14] media: platform: Add Sunxi-Cedrus VPU decoder driver

2018-05-07 Thread Paul Kocialkowski
This introduces the Sunxi-Cedrus VPU driver that supports the VPU found in Allwinner SoCs, also known as Video Engine. It is implemented through a v4l2 m2m decoder device and a media device (used for media requests). So far, it only supports MPEG2 decoding. Since this VPU is stateless,

[PATCH v3 13/14] ARM: dts: sun7i-a20: Add Video Engine and reserved memory nodes

2018-05-07 Thread Paul Kocialkowski
This adds nodes for the Video Engine and the associated reserved memory for the A20. Up to 96 MiB of memory are dedicated to the CMA pool. The VPU can only map the first 256 MiB of DRAM, so the reserved memory pool has to be located in that area. Following Allwinner's decision in downstream

[PATCH v3 02/14] drivers: soc: sunxi: Add dedicated compatibles for the A13, A20 and A33

2018-05-07 Thread Paul Kocialkowski
This introduces platform-specific compatibles for the A13, A20 and A33 SRAM driver. No particular adaptation for these platforms is required at this point, although this might become the case in the future. Signed-off-by: Paul Kocialkowski ---

[PATCH v3 14/14] ARM: dts: sun8i-a33: Add Video Engine and reserved memory nodes

2018-05-07 Thread Paul Kocialkowski
This adds nodes for the Video Engine and the associated reserved memory for the A33. Up to 96 MiB of memory are dedicated to the CMA pool. The VPU can only map the first 256 MiB of DRAM, so the reserved memory pool has to be located in that area. Following Allwinner's decision in downstream

[PATCH v3 03/14] ARM: dts: sun5i: Use dedicated SRAM controller compatible

2018-05-07 Thread Paul Kocialkowski
Use the newly-introduced SRAM controller compatible for the A13 and other sun5i platforms instead of its A10 fashion. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun5i.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 05/14] ARM: sun5i: Add support for the C1 SRAM region with the SRAM controller

2018-05-07 Thread Paul Kocialkowski
From: Maxime Ripard This adds support for the C1 SRAM region (to be used with the SRAM controller driver) for sun5i-based platforms. The region is shared between the Video Engine and the CPU. Signed-off-by: Maxime Ripard Signed-off-by: Paul

[PATCH v3 09/14] media: v4l: Add definition for Allwinner's MB32-tiled NV12 format

2018-05-07 Thread Paul Kocialkowski
This introduces support for Allwinner's MB32-tiled NV12 format, where each plane is divided into macroblocks of 32x32 pixels. Hence, the size of each plane has to be aligned to 32 bytes. The pixels inside each macroblock are coded as they would be if the macroblock was a single plane, line after

[PATCH v3 07/14] ARM: sun8i-a33: Add SRAM controller node and C1 SRAM region

2018-05-07 Thread Paul Kocialkowski
From: Maxime Ripard This adds a SRAM controller node for the A33, with support for the C1 SRAM region that is shared between the Video Engine and the CPU. Signed-off-by: Maxime Ripard Signed-off-by: Paul Kocialkowski

[PATCH v3 10/14] dt-bindings: media: Document bindings for the Sunxi-Cedrus VPU driver

2018-05-07 Thread Paul Kocialkowski
This adds a device-tree binding document that specifies the properties used by the Sunxi-Cedurs VPU driver, as well as examples. Signed-off-by: Paul Kocialkowski --- .../devicetree/bindings/media/sunxi-cedrus.txt | 58 ++ 1 file changed, 58

[PATCH v3 06/14] ARM: sun7i-a20: Add support for the C1 SRAM region with the SRAM controller

2018-05-07 Thread Paul Kocialkowski
From: Maxime Ripard This adds support for the C1 SRAM region (to be used with the SRAM controller driver) for the A20 platform. The region is shared between the Video Engine and the CPU. Signed-off-by: Maxime Ripard Signed-off-by: Paul

[PATCH v3 08/14] media: v4l: Add definitions for MPEG2 frame format and header metadata

2018-05-07 Thread Paul Kocialkowski
From: Florent Revest Stateless video decoding engines require both the MPEG slices and associated metadata from the video stream in order to decode frames. This introduces definitions for a new pixel format, describing buffers with MPEG2 slice data, as well as

[PATCH 1/2] omap3isp: Remove useless NULL check in omap3isp_stat_config

2018-05-07 Thread Sakari Ailus
The omap3isp driver checked whether the second argument (the new configuration) to the ISP statistics is NULL. This is the pointer to the user-given argument and is never NULL. Remove the check. Reported-by: "Gustavo A. R. Silva" Suggested-by: Laurent Pinchart

[PATCH 2/2] omap3isp: Don't use GFP_DMA

2018-05-07 Thread Sakari Ailus
The isp stat driver allocates memory for DMA and uses GFP_DMA flag for dev_alloc_coherent. The flag is no longer needed as the DMA mask is used for the purpose. Remove it. Reported-by: Mauro Carvalho Chehab Signed-off-by: Sakari Ailus

[PATCH 0/2] omap3isp cleanups

2018-05-07 Thread Sakari Ailus
Hi, These patches fix a useless check in ispstat as well as get rid of the GFP_DMA. Sakari Ailus (2): omap3isp: Remove useless NULL check in omap3isp_stat_config omap3isp: Don't use GFP_DMA drivers/media/platform/omap3isp/ispstat.c | 8 +--- 1 file changed, 1 insertion(+), 7

Re: [PATCH v9 14/15] v4l: Add V4L2_CAP_FENCES to drivers

2018-05-07 Thread Hans Verkuil
On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan > > Drivers that use videobuf2 are capable of using fences and > should report that to userspace. > > v9: Add in the core. > > Signed-off-by: Gustavo Padovan >

[GIT PULL for 4.18] IPU3 CIO2 fix

2018-05-07 Thread Sakari Ailus
Hi Mauro, Here's a fix for the IPU3 CIO2 driver. Please pull. The following changes since commit f10379aad39e9da8bc7d1822e251b5f0673067ef: media: include/video/omapfb_dss.h: use IS_ENABLED() (2018-05-05 11:45:51 -0400) are available in the git repository at:

[GIT PULL for 4.18] Cadence CSI-2 TX and RX drivers

2018-05-07 Thread Sakari Ailus
Hi Mauro, Here are the drivers for Cadence CSI-2 TX and RX hardware blocks. Please pull. The following changes since commit f10379aad39e9da8bc7d1822e251b5f0673067ef: media: include/video/omapfb_dss.h: use IS_ENABLED() (2018-05-05 11:45:51 -0400) are available in the git repository at:

[GIT PULL for 4.18] Sensor driver patches

2018-05-07 Thread Sakari Ailus
Hi Mauro, Here's a regular bunch of sensor and lens driver patches for 4.18. Fixes, cleanups and preparation for new functionality (imx274 and ov5640) as well as DT bindings and a new driver for ov7251 and imx258 camera sensors and dw9807 voice coil. Please pull. The following changes since

Re: [PATCH v9 12/15] vb2: add out-fence support to QBUF

2018-05-07 Thread Hans Verkuil
On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan > > If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create > an out_fence and send its fd to userspace in the fence_fd field as a > return arg for the QBUF call. > > The fence is

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-07 Thread Hans Verkuil
On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan > > Receive in-fence from userspace and add support for waiting on them > before queueing the buffer to the driver. Buffers can't be queued to the > driver before its fences signal. And a buffer

Re: atomisp: drop from staging ?

2018-05-07 Thread Sakari Ailus
On Fri, May 04, 2018 at 11:17:30AM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 3 May 2018 11:30:50 +0300 > Sakari Ailus escreveu: > > > On Mon, Apr 30, 2018 at 12:41:00PM +0300, Sakari Ailus wrote: > > > Hi Alan, > > > > > > On Sun, Apr 29, 2018 at 01:18:37AM +0100, Alan

Re: [PATCH v9 10/15] vb2: add explicit fence user API

2018-05-07 Thread Hans Verkuil
On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan > > Turn the reserved2 field into fence_fd that we will use to send > an in-fence to the kernel or return an out-fence from the kernel to > userspace. > > Two new flags were added,

Re: [PATCH v9 08/15] cobalt: set queue as unordered

2018-05-07 Thread Hans Verkuil
On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan > > The cobalt driver may reorder the capture buffers so we need to report > it as such. > > v3: set unordered as a property > v2: use vb2_ops_set_unordered() helper > > Signed-off-by: Gustavo

  1   2   >