Re: [RFC] Request API and V4L2 capabilities

2018-08-28 Thread Tomasz Figa
On Fri, Aug 24, 2018 at 4:30 PM Hans Verkuil wrote: > > On 08/23/2018 07:37 PM, Nicolas Dufresne wrote: > > Le jeudi 23 août 2018 à 16:31 +0200, Hans Verkuil a écrit : > >>> I propose adding these capabilities: > >>> > >>> #define V4L2_BUF_CAP_HAS_REQUESTS 0x0001 > >>> #define

Re: [RFC] Request API and V4L2 capabilities

2018-08-28 Thread Tomasz Figa
On Fri, Aug 24, 2018 at 2:33 AM Nicolas Dufresne wrote: > > Le jeudi 23 août 2018 à 10:05 +0200, Paul Kocialkowski a écrit : > > Hi, > > > > On Wed, 2018-08-22 at 14:33 -0300, Ezequiel Garcia wrote: > > > On Wed, 2018-08-22 at 16:10 +0200, Paul Kocialkowski wrote: > > > > Hi, > > > > > > > > On

cron job: media_tree daily build: ERRORS

2018-08-28 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Aug 29 05:00:14 CEST 2018 media-tree git hash:5b394b2ddf0347bef56e50c69a58773c94343ff3 media_build

Re: [RFC] Request API and V4L2 capabilities

2018-08-28 Thread Tomasz Figa
On Wed, Aug 22, 2018 at 11:10 PM Paul Kocialkowski wrote: > > Hi, > > On Tue, 2018-08-21 at 17:52 +0900, Tomasz Figa wrote: > > Hi Hans, Paul, > > > > On Mon, Aug 6, 2018 at 6:29 PM Paul Kocialkowski > > wrote: > > > > > > On Mon, 2018-08-06 at 11:23 +0200, Hans Verkuil wrote: > > > > On

Re: [PATCH v3 6/7] media: Add controls for JPEG quantization tables

2018-08-28 Thread Tomasz Figa
On Wed, Aug 29, 2018 at 11:50 AM Ezequiel Garcia wrote: > > On Mon, 2018-08-27 at 09:47 +0200, Paul Kocialkowski wrote: > > Hi, > > > > On Wed, 2018-08-22 at 13:59 -0300, Ezequiel Garcia wrote: > > > From: Shunqian Zheng > > > > > > Add V4L2_CID_JPEG_LUMA/CHROMA_QUANTIZATION controls to allow

Re: [PATCH v3 6/7] media: Add controls for JPEG quantization tables

2018-08-28 Thread Ezequiel Garcia
On Mon, 2018-08-27 at 09:47 +0200, Paul Kocialkowski wrote: > Hi, > > On Wed, 2018-08-22 at 13:59 -0300, Ezequiel Garcia wrote: > > From: Shunqian Zheng > > > > Add V4L2_CID_JPEG_LUMA/CHROMA_QUANTIZATION controls to allow userspace > > configure the JPEG quantization tables. > > How about

Re: [PATCH v2 00/23] V4L2 fwnode rework; support for default configuration

2018-08-28 Thread Steve Longerbeam
Hi Sakari, On 08/27/2018 02:29 AM, Sakari Ailus wrote: Hello everyone, I've long thought the V4L2 fwnode framework requires some work (it's buggy and it does not adequately serve common needs). This set should address in particular these matters: - Most devices support a particular media bus

Re: [PATCH v2 04/23] dt-bindings: media: Specify bus type for MIPI D-PHY, others, explicitly

2018-08-28 Thread Rob Herring
On Mon, 27 Aug 2018 12:29:41 +0300, Sakari Ailus wrote: > Allow specifying the bus type explicitly for MIPI D-PHY, parallel and > Bt.656 busses. This is useful for devices that can make use of different > bus types. There are CSI-2 transmitters and receivers but the PHY > selection needs to be

Re: [PATCHv2 06/10] media-request: add media_request_(un)lock_for_access

2018-08-28 Thread Hans Verkuil
On 28/08/18 15:49, Hans Verkuil wrote: > From: Hans Verkuil > > Add helper functions to prevent a completed request from being > re-inited while it is being accessed. > > Signed-off-by: Hans Verkuil > --- > drivers/media/media-request.c | 10 > include/media/media-request.h | 46

Waiting for

2018-08-28 Thread Ruby
We provide photoshop services to some of the companies from around the world. We have worked on tons of images ever since our team establishment in 2009. Many online retail companies use our services for retouching electronics, jewelry, apparels, furniture etc. by getting the images of their

Re: [PATCH v3 0/2] media: i2c: ov5640: Re-work MIPI startup sequence

2018-08-28 Thread Loic Poulain
On 15 August 2018 at 12:28, Jacopo Mondi wrote: > Hello ov5640 people, >this driver has received a lot of attention recently, and this series aims > to fix the CSI-2 interface startup on i.Mx6Q platforms. > > Please refer to the v2 cover letters for more background informations: >

[PATCH] media: rc: ir-rc6-decoder: enable toggle bit for Kathrein RCU-676 remote

2018-08-28 Thread Matthias Reichl
The Kathrein RCU-676 remote uses the 32-bit rc6 protocol and toggles bit 15 (0x8000) on repeated button presses, like MCE remotes. Add it's customer code 0x8046 to the 32-bit rc6 toggle handling code to get proper scancodes and toggle reports. Signed-off-by: Matthias Reichl --- Here's the

[PATCHv2 10/10] media-request: update documentation

2018-08-28 Thread Hans Verkuil
From: Hans Verkuil Various clarifications and readability improvements based on Laurent Pinchart's review of the documentation. Signed-off-by: Hans Verkuil --- .../uapi/mediactl/media-ioc-request-alloc.rst | 3 +- .../uapi/mediactl/media-request-ioc-queue.rst | 7 +--

[PATCHv2 03/10] buffer.rst: only set V4L2_BUF_FLAG_REQUEST_FD for QBUF

2018-08-28 Thread Hans Verkuil
From: Hans Verkuil Document that V4L2_BUF_FLAG_REQUEST_FD should only be used with VIDIOC_QBUF and cleared otherwise. Signed-off-by: Hans Verkuil Reviewed-by: Tomasz Figa --- Documentation/media/uapi/v4l/buffer.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCHv2 00/10] Post-v18: Request API updates

2018-08-28 Thread Hans Verkuil
From: Hans Verkuil Hi all, This patch series sits on top of my v18 series for the Request API. It makes some final (?) changes as discussed in: https://www.mail-archive.com/linux-media@vger.kernel.org/msg134419.html and: https://www.spinics.net/lists/linux-media/msg138596.html The combined

[PATCHv2 06/10] media-request: add media_request_(un)lock_for_access

2018-08-28 Thread Hans Verkuil
From: Hans Verkuil Add helper functions to prevent a completed request from being re-inited while it is being accessed. Signed-off-by: Hans Verkuil --- drivers/media/media-request.c | 10 include/media/media-request.h | 46 +++ 2 files changed, 56

[PATCHv2 09/10] media-request: EPERM -> EACCES

2018-08-28 Thread Hans Verkuil
From: Hans Verkuil If requests are not supported by the driver, then return EACCES, not EPERM. This is consistent with the error that an invalid request_fd will give, and if requests are not supported, then all request_fd values are invalid. Signed-off-by: Hans Verkuil ---

[PATCHv2 08/10] v4l2-ctrls: improve media_request_(un)lock_for_update

2018-08-28 Thread Hans Verkuil
From: Hans Verkuil The request reference count was decreased again once a reference to the request object was taken. Postpone this until we finished using the object. In theory I think it is possible that the request_fd can be closed by the application from another thread. In that case when

[PATCHv2 04/10] videodev2.h: add new capabilities for buffer types

2018-08-28 Thread Hans Verkuil
From: Hans Verkuil VIDIOC_REQBUFS and VIDIOC_CREATE_BUFFERS will return capabilities telling userspace what the given buffer type is capable of. Signed-off-by: Hans Verkuil --- .../media/uapi/v4l/vidioc-create-bufs.rst | 14 ++- .../media/uapi/v4l/vidioc-reqbufs.rst | 42

[PATCHv2 02/10] v4l2-ctrls: return -EACCES if request wasn't completed

2018-08-28 Thread Hans Verkuil
From: Hans Verkuil For now (this might be relaxed in the future) we do not allow getting controls from a request that isn't completed. In that case we return -EACCES. Update the documentation accordingly. Signed-off-by: Hans Verkuil Reviewed-by: Tomasz Figa ---

[PATCHv2 05/10] vb2: set reqbufs/create_bufs capabilities

2018-08-28 Thread Hans Verkuil
From: Hans Verkuil Set the capabilities field of v4l2_requestbuffers and v4l2_create_buffers. The various mapping modes were easy, but for signaling the request capability a new 'supports_requests' bitfield was added to videobuf2-core.h (and set in vim2m and vivid). Drivers have to set this

[PATCHv2 07/10] v4l2-ctrls: use media_request_(un)lock_for_access

2018-08-28 Thread Hans Verkuil
From: Hans Verkuil When getting control values from a completed request, we have to protect the request against being re-inited why it is being accessed by calling media_request_(un)lock_for_access. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ctrls.c | 21

[PATCHv2 01/10] media-request: return -EINVAL for invalid request_fds

2018-08-28 Thread Hans Verkuil
From: Hans Verkuil Instead of returning -ENOENT when a request_fd was not found (VIDIOC_QBUF and VIDIOC_G/S/TRY_EXT_CTRLS), we now return -EINVAL. This is in line with what we do when invalid dmabuf fds are passed to e.g. VIDIOC_QBUF. Also document that EINVAL is returned for invalid m.fd

This is it

2018-08-28 Thread Jason
Do you have photos for cutting out,or adding clipping path? We are here to help you for that also including retouching. Both for product photos and portrait photos. Yours, Jason

This is it

2018-08-28 Thread Jason
Do you have photos for cutting out,or adding clipping path? We are here to help you for that also including retouching. Both for product photos and portrait photos. Yours, Jason

Re: [PATCH] media: ov5640: fix mode change regression

2018-08-28 Thread jacopo mondi
On Tue, Aug 28, 2018 at 02:57:11PM +0200, jacopo mondi wrote: > Hi Hugues, >thanks for the patch > > On Thu, Aug 16, 2018 at 11:46:53AM +0200, Hugues Fruchet wrote: > > fixes: 6949d864776e ("media: ov5640: do not change mode if format or frame > > interval is unchanged"). > > > > Symptom was

Re: [PATCH] media: ov5640: fix mode change regression

2018-08-28 Thread jacopo mondi
Hi Hugues, thanks for the patch On Thu, Aug 16, 2018 at 11:46:53AM +0200, Hugues Fruchet wrote: > fixes: 6949d864776e ("media: ov5640: do not change mode if format or frame > interval is unchanged"). > > Symptom was fuzzy image because of JPEG default format > not being changed according to

Re: [PATCH 4/5] videodev2.h: add new capabilities for buffer types

2018-08-28 Thread Hans Verkuil
On 24/08/18 16:36, Tomasz Figa wrote: > Hi Hans, > > On Fri, Aug 24, 2018 at 5:22 PM Hans Verkuil wrote: >> >> From: Hans Verkuil >> >> VIDIOC_REQBUFS and VIDIOC_CREATE_BUFFERS will return capabilities >> telling userspace what the given buffer type is capable of. >> > > Please see my comments

Re: [PATCH] media: v4l2-subdev.h: allow V4L2_FRMIVAL_TYPE_CONTINUOUS & _STEPWISE

2018-08-28 Thread Hans Verkuil
On 28/08/18 12:40, Philippe De Muyter wrote: > Hi Hans, > > On Tue, Aug 28, 2018 at 12:29:21PM +0200, Hans Verkuil wrote: >> On 28/08/18 12:26, Philippe De Muyter wrote: >>> Hi Hans, >>> >>> On Tue, Aug 28, 2018 at 12:03:25PM +0200, Hans Verkuil wrote: This is a bit too magical for my

Re: [PATCH] media: v4l2-subdev.h: allow V4L2_FRMIVAL_TYPE_CONTINUOUS & _STEPWISE

2018-08-28 Thread Philippe De Muyter
Hi Hans, On Tue, Aug 28, 2018 at 12:29:21PM +0200, Hans Verkuil wrote: > On 28/08/18 12:26, Philippe De Muyter wrote: > > Hi Hans, > > > > On Tue, Aug 28, 2018 at 12:03:25PM +0200, Hans Verkuil wrote: > >> This is a bit too magical for my tastes. I'd add a type field: > >> > >> #define

Re: [PATCH] media: v4l2-subdev.h: allow V4L2_FRMIVAL_TYPE_CONTINUOUS & _STEPWISE

2018-08-28 Thread Hans Verkuil
On 28/08/18 12:26, Philippe De Muyter wrote: > Hi Hans, > > On Tue, Aug 28, 2018 at 12:03:25PM +0200, Hans Verkuil wrote: >> Hi Philippe, >> >> On 28/08/18 09:55, Philippe De Muyter wrote: >>> add max_interval and step_interval to struct >>> v4l2_subdev_frame_interval_enum. >> >> Yeah, I never

Re: [PATCH] media: v4l2-subdev.h: allow V4L2_FRMIVAL_TYPE_CONTINUOUS & _STEPWISE

2018-08-28 Thread Philippe De Muyter
Hi Hans, On Tue, Aug 28, 2018 at 12:03:25PM +0200, Hans Verkuil wrote: > Hi Philippe, > > On 28/08/18 09:55, Philippe De Muyter wrote: > > add max_interval and step_interval to struct > > v4l2_subdev_frame_interval_enum. > > Yeah, I never understood why this wasn't supported when this API was

Re: [PATCH] media: v4l2-subdev.h: allow V4L2_FRMIVAL_TYPE_CONTINUOUS & _STEPWISE

2018-08-28 Thread Hans Verkuil
Hi Philippe, On 28/08/18 09:55, Philippe De Muyter wrote: > add max_interval and step_interval to struct > v4l2_subdev_frame_interval_enum. Yeah, I never understood why this wasn't supported when this API was designed. Clearly an oversight. > > When filled correctly by the sensor driver, those

Re: [PATCH v1 2/2] v4l: Document Intel IPU3 meta data uAPI

2018-08-28 Thread Sakari Ailus
Hi Tomasz, On Tue, Aug 28, 2018 at 05:56:37PM +0900, Tomasz Figa wrote: > On Tue, Aug 14, 2018 at 5:50 AM Mauro Carvalho Chehab > wrote: > > > > Em Mon, 13 Aug 2018 15:42:34 +0200 > > Hans Verkuil escreveu: > > > > > On 15/06/18 05:29, Yong Zhi wrote: > > > > These meta formats are used on

Re: [PATCH v1 2/2] v4l: Document Intel IPU3 meta data uAPI

2018-08-28 Thread Tomasz Figa
On Tue, Aug 14, 2018 at 5:50 AM Mauro Carvalho Chehab wrote: > > Em Mon, 13 Aug 2018 15:42:34 +0200 > Hans Verkuil escreveu: > > > On 15/06/18 05:29, Yong Zhi wrote: > > > These meta formats are used on Intel IPU3 ImgU video queues > > > to carry 3A statistics and ISP pipeline parameters. > > >

cron job: media_tree daily build: ERRORS

2018-08-28 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Aug 28 09:08:16 CEST 2018 media-tree git hash:da2048b7348a0be92f706ac019e022139e29495e media_build

[PATCH] media: v4l2-subdev.h: allow V4L2_FRMIVAL_TYPE_CONTINUOUS & _STEPWISE

2018-08-28 Thread Philippe De Muyter
add max_interval and step_interval to struct v4l2_subdev_frame_interval_enum. When filled correctly by the sensor driver, those fields must be used as follows by the intermediate level : struct v4l2_frmivalenum *fival; struct v4l2_subdev_frame_interval_enum fie; if

[PATCH 0/2] HEVC/H.265 stateless support for V4L2 and Cedrus

2018-08-28 Thread Paul Kocialkowski
This introduces the required bits for supporting HEVC/H.265 both in the V4L2 framework and the Cedrus VPU driver that concerns Allwinner devices. A specific pixel format is introduced for the HEVC slice format and controls are provided to pass the bitstream metadata to the decoder. Some bitstream