[PATCH 1/4] media: ov5640: fix resolution update

2018-10-08 Thread Sam Bobrowicz
set_fmt was not properly triggering a mode change when a new mode was set that happened to have the same format as the previous mode (for example, when only changing the frame dimensions). Fix this. Signed-off-by: Sam Bobrowicz --- drivers/media/i2c/ov5640.c | 8 1 file changed, 4 inser

[PATCH 3/4] media: ov5640: Don't access ctrl regs when off

2018-10-08 Thread Sam Bobrowicz
Add a check to g_volatile_ctrl to prevent trying to read registers when the sensor is not powered. Signed-off-by: Sam Bobrowicz --- drivers/media/i2c/ov5640.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index f183222..a50d884

[PATCH 0/4] ov5640: small fixes for compatibility

2018-10-08 Thread Sam Bobrowicz
These patches include fixes for some minor annoyances and also help increase compatibility with some CSI2 drivers. Based on latest media_tree commit: "media: ov5640: fix framerate update" Sam Bobrowicz (4): media: ov5640: fix resolution update media: ov5640: fix get_light_freq on auto medi

[PATCH 4/4] media: ov5640: Add additional media bus formats

2018-10-08 Thread Sam Bobrowicz
Add support for 1X16 yuv media bus formats (v4l2_mbus_framefmt). These formats are equivalent to the 2X8 formats that are already supported, both of which accurately describe the data present on the CSI2 interface. This change will increase compatibility with CSI2 RX drivers that only advertise sup

[PATCH 2/4] media: ov5640: fix get_light_freq on auto

2018-10-08 Thread Sam Bobrowicz
Light frequency was not properly returned when in auto mode and the detected frequency was 60Hz. Fix this. Signed-off-by: Sam Bobrowicz --- drivers/media/i2c/ov5640.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index 5031aab..f18322

Re: [PATCH 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-10-08 Thread Hans Verkuil
On 10/09/2018 06:23 AM, Tomasz Figa wrote: > On Mon, Oct 8, 2018 at 9:22 PM Hans Verkuil wrote: >> >> On 09/19/2018 12:17 PM, Tomasz Figa wrote: >>> Hi Hans, >>> >>> On Thu, Jul 26, 2018 at 7:20 PM Tomasz Figa wrote: Hi Hans, On Wed, Jul 25, 2018 at 8:59 PM Hans Verkuil wrote

Re: [PATCH] media: vivid: Support 480p for webcam capture

2018-10-08 Thread Hans Verkuil
On 10/09/2018 08:01 AM, Keiichi Watanabe wrote: > Let me back to the topic about interval. > I'd like to send a nex version of this patch to avoid duplication of > intervals. > > We need to choose two intervals from the three options: 1/20, 2/25 and 1/40. > As Mauro said, we would want to have 2/

Re: [PATCH] media: vivid: Support 480p for webcam capture

2018-10-08 Thread Keiichi Watanabe
Let me back to the topic about interval. I'd like to send a nex version of this patch to avoid duplication of intervals. We need to choose two intervals from the three options: 1/20, 2/25 and 1/40. As Mauro said, we would want to have 2/25 for a fractional rate. Then, I think adding 2/25 and 1/40

Re: [RFC PATCH v2] media: docs-rst: Document m2m stateless video decoder interface

2018-10-08 Thread Tomasz Figa
Hi Paul, On Thu, Oct 4, 2018 at 9:40 PM Paul Kocialkowski wrote: > > Hi Alexandre, > > Thanks for submitting this second version of the RFC, it is very > appreciated! I will try to provide useful feedback here and hopefully > be more reactive than during v1 review! > > Most of it looks good to me

Re: [RFC PATCH v2] media: docs-rst: Document m2m stateless video decoder interface

2018-10-08 Thread Tomasz Figa
Hi Alex, On Thu, Oct 4, 2018 at 5:11 PM Alexandre Courbot wrote: > > This patch documents the protocol that user-space should follow when > communicating with stateless video decoders. It is based on the > following references: > > * The current protocol used by Chromium (converted from config st

Re: [PATCH 03/21] media: davinci_vpfe: fix vpfe_ipipe_init() error handling

2018-10-08 Thread Joel Fernandes
On Fri, Apr 06, 2018 at 10:23:04AM -0400, Mauro Carvalho Chehab wrote: > As warned: > drivers/staging/media/davinci_vpfe/dm365_ipipe.c:1834 vpfe_ipipe_init() > error: we previously assumed 'res' could be null (see line 1797) > > There's something wrong at vpfe_ipipe_init(): > > 1) it cache

Re: [PATCH 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-10-08 Thread Tomasz Figa
On Mon, Oct 8, 2018 at 9:22 PM Hans Verkuil wrote: > > On 09/19/2018 12:17 PM, Tomasz Figa wrote: > > Hi Hans, > > > > On Thu, Jul 26, 2018 at 7:20 PM Tomasz Figa wrote: > >> > >> Hi Hans, > >> > >> On Wed, Jul 25, 2018 at 8:59 PM Hans Verkuil wrote: > >>> > >>> Hi Tomasz, > >>> > >>> Many, many

Re: [PATCH 4/7] mfd: ds90ux9xx: add TI DS90Ux9xx de-/serializer MFD driver

2018-10-08 Thread kbuild test robot
Hi Vladimir, I love your patch! Perhaps something to improve: [auto build test WARNING on ljones-mfd/for-mfd-next] [also build test WARNING on v4.19-rc7 next-20181008] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

cron job: media_tree daily build: ERRORS

2018-10-08 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Oct 9 05:00:10 CEST 2018 media-tree git hash:9e5b5081fa117ae34eca94b63b1cb6d43dc28f10 media_build gi

Re: [PATCH v4 11/11] media: imx.rst: Update doc to reflect fixes to interlaced capture

2018-10-08 Thread Steve Longerbeam
On 10/05/2018 03:52 AM, Philipp Zabel wrote: Hi Steve, On Thu, 2018-10-04 at 11:54 -0700, Steve Longerbeam wrote: +or bottom-top or alternate, and the capture interface field type is set +to interlaced (t-b, b-t, or unqualified interlaced). The capture interface +will enforce the same field

Re: [PATCH v4 10/11] media: imx: Allow interweave with top/bottom lines swapped

2018-10-08 Thread Steve Longerbeam
Hi Philipp, On 10/05/2018 03:43 AM, Philipp Zabel wrote: Hi Steve, On Thu, 2018-10-04 at 11:54 -0700, Steve Longerbeam wrote: Allow sequential->interlaced interweaving but with top/bottom lines swapped to the output buffer. This can be accomplished by adding one line length to IDMAC output c

Re: [PATCH 1/7] dt-bindings: mfd: ds90ux9xx: add description of TI DS90Ux9xx ICs

2018-10-08 Thread Marek Vasut
On 10/08/2018 11:11 PM, Vladimir Zapolskiy wrote: > From: Sandeep Jain > > The change adds device tree binding description of TI DS90Ux9xx > series of serializer and deserializer controllers which support video, > audio and control data transmission over FPD-III Link connection. > > Signed-off-b

Re: [PATCH v4 03/11] gpu: ipu-v3: Add planar support to interlaced scan

2018-10-08 Thread Steve Longerbeam
On 10/05/2018 02:48 AM, Philipp Zabel wrote: On Thu, 2018-10-04 at 11:53 -0700, Steve Longerbeam wrote: To support interlaced scan with planar formats, cpmem SLUV must be programmed with the correct chroma line stride. For full and partial planar 4:2:2 (YUV422P, NV16), chroma line stride must

Re: [PATCH] vivid: fix kernel oops when enabling HFLIP and OSD

2018-10-08 Thread Hans Verkuil
On 10/08/2018 09:08 PM, Hans Verkuil wrote: > When the OSD is on (i.e. vivid displays text on top of the test pattern), and > you enable hflip, then the driver crashes. > > The cause turned out to be a division of a negative number by an unsigned > value. > You expect that -8 / 2 would be -4, but

[PATCH] media: tc358743: Remove unnecessary self assignment

2018-10-08 Thread Nathan Chancellor
Clang warns when a variable is assigned to itself. drivers/media/i2c/tc358743.c:1921:7: warning: explicitly assigning value of variable of type 'int' to itself [-Wself-assign] ret = ret; ~~~ ^ ~~~ 1 warning generated. Signed-off-by: Nathan Chancellor --- drivers/

Re: [PATCH v4 02/11] gpu: ipu-csi: Swap fields according to input/output field types

2018-10-08 Thread Steve Longerbeam
Hi Philipp, On 10/05/2018 02:44 AM, Philipp Zabel wrote: Hi Steve, On Thu, 2018-10-04 at 11:53 -0700, Steve Longerbeam wrote: + + /* framelines for NTSC / PAL */ + height = (std & V4L2_STD_525_60) ? 525 : 625; I think this is a bit convoluted. Instead of initial

[PATCH 0/7] mfd/pinctrl: add initial support of TI DS90Ux9xx ICs

2018-10-08 Thread Vladimir Zapolskiy
The published drivers describe the essential and generic parts of TI DS90Ux9xx series of ICs, which allow to transfer video, audio and control signals between FPD-Link III serializers and deserializers. The placement of TI DS90Ux9xx I2C client driver was selected to be drivers/mfd as the most natu

[PATCH 3/7] dt-bindings: pinctrl: ds90ux9xx: add description of TI DS90Ux9xx pinmux

2018-10-08 Thread Vladimir Zapolskiy
From: Vladimir Zapolskiy TI DS90Ux9xx de-/serializers have a capability to multiplex pin functions, in particular a pin may have selectable functions of GPIO, GPIO line transmitter, one of I2S lines, one of RGB24 video signal lines and so on. The change adds a description of DS90Ux9xx pin multip

[PATCH 7/7] MAINTAINERS: add entry for TI DS90Ux9xx FPD-Link III drivers

2018-10-08 Thread Vladimir Zapolskiy
Record TI DS90Ux9xx series of serializer and deserializer ICs and IC subcontrollers as maintained. Signed-off-by: Vladimir Zapolskiy --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 29c08106bd22..3952035b6b71 100644 --- a/MAINTAINERS

[PATCH 2/7] dt-bindings: mfd: ds90ux9xx: add description of TI DS90Ux9xx I2C bridge

2018-10-08 Thread Vladimir Zapolskiy
From: Vladimir Zapolskiy TI DS90Ux9xx de-/serializers are capable to route I2C messages to I2C slave devices connected to a remote de-/serializer in a pair, the change adds description of device tree bindings of the subcontroller to configure and enable this functionality. Signed-off-by: Vladimi

[PATCH 4/7] mfd: ds90ux9xx: add TI DS90Ux9xx de-/serializer MFD driver

2018-10-08 Thread Vladimir Zapolskiy
From: Vladimir Zapolskiy The change adds I2C device driver for TI DS90Ux9xx de-/serializers, support of subdevice controllers is done in separate drivers, because not all IC functionality may be needed in particular situations, and this can be fine grained controlled in device tree. The developm

[PATCH 6/7] pinctrl: ds90ux9xx: add TI DS90Ux9xx pinmux and GPIO controller driver

2018-10-08 Thread Vladimir Zapolskiy
From: Vladimir Zapolskiy The change adds an MFD cell driver for managing pin functions on TI DS90Ux9xx de-/serializers. Signed-off-by: Vladimir Zapolskiy --- drivers/pinctrl/Kconfig | 11 + drivers/pinctrl/Makefile| 1 + drivers/pinctrl/pinctrl-ds90ux9xx.c | 970

[PATCH 1/7] dt-bindings: mfd: ds90ux9xx: add description of TI DS90Ux9xx ICs

2018-10-08 Thread Vladimir Zapolskiy
From: Sandeep Jain The change adds device tree binding description of TI DS90Ux9xx series of serializer and deserializer controllers which support video, audio and control data transmission over FPD-III Link connection. Signed-off-by: Sandeep Jain [vzapolskiy: various updates and corrections of

[PATCH 5/7] mfd: ds90ux9xx: add I2C bridge/alias and link connection driver

2018-10-08 Thread Vladimir Zapolskiy
From: Vladimir Zapolskiy The change adds TI DS90Ux9xx I2C bridge/alias subdevice driver and FPD Link connection handling mechanism. Access to I2C devices connected to a remote de-/serializer is done in a transparent way, on established link detection event such devices are registered on an I2C b

Re: [PATCHv2] media: rc: add driver for Xbox DVD Movie Playback Kit

2018-10-08 Thread Sean Young
Hi Benjamin, Thanks for your driver, I have some comments below. On Thu, Oct 04, 2018 at 01:52:54PM +0200, Benjamin Valentin wrote: > The Xbox DVD Movie Playback Kit is a USB dongle with an IR remote for the > Original Xbox. > > Historically it has been supported by the out-of-tree lirc_xbox dri

Re: [RFC] Informal meeting during ELCE to discuss userspace support for stateless codecs

2018-10-08 Thread Kieran Bingham
Hi Hans On 08/10/18 12:53, Hans Verkuil wrote: > Hi all, > > I would like to meet up somewhere during the ELCE to discuss userspace support > for stateless (and perhaps stateful as well?) codecs. > > It is also planned as a topic during the summit, but I would prefer to prepare > for that in adv

Re: [PATCH] vivid: fix kernel oops when enabling HFLIP and OSD

2018-10-08 Thread Hans Verkuil
On 10/08/2018 09:08 PM, Hans Verkuil wrote: > When the OSD is on (i.e. vivid displays text on top of the test pattern), and > you enable hflip, then the driver crashes. > > The cause turned out to be a division of a negative number by an unsigned > value. > You expect that -8 / 2 would be -4, but

[PATCH] vivid: fix kernel oops when enabling HFLIP and OSD

2018-10-08 Thread Hans Verkuil
When the OSD is on (i.e. vivid displays text on top of the test pattern), and you enable hflip, then the driver crashes. The cause turned out to be a division of a negative number by an unsigned value. You expect that -8 / 2 would be -4, but in reality it is 2147483644 :-( Signed-off-by: Hans Ver

RE: [PATCH v1 2/2] v4l: Document Intel IPU3 meta data uAPI

2018-10-08 Thread Mani, Rajmohan
Hi Sakari, > -Original Message- > From: sakari.ai...@linux.intel.com [mailto:sakari.ai...@linux.intel.com] > Sent: Thursday, October 04, 2018 12:09 AM > To: Mani, Rajmohan > Cc: Mauro Carvalho Chehab ; Hans Verkuil > ; Zhi, Yong ; linux- > me...@vger.kernel.org; tf...@chromium.org; mche..

Re: [PATCH] media: vivid: Support 480p for webcam capture

2018-10-08 Thread Mauro Carvalho Chehab
Em Mon, 8 Oct 2018 20:31:10 +0200 Hans Verkuil escreveu: > > (gdb) list *vivid_fillbuff+0x1e9b > > 0x1936b is in vivid_fillbuff > > (drivers/media/platform/vivid/vivid-kthread-cap.c:495). > > 490 ms % 1000, > > 491 buf->vb.sequence,

Re: [PATCH] media: vivid: Support 480p for webcam capture

2018-10-08 Thread Hans Verkuil
On 10/08/2018 08:23 PM, Mauro Carvalho Chehab wrote: > Em Mon, 8 Oct 2018 19:53:38 +0200 > Hans Verkuil escreveu: > >> On 10/08/2018 07:03 PM, Mauro Carvalho Chehab wrote: >>> Em Wed, 3 Oct 2018 12:14:22 +0100 >>> Kieran Bingham escreveu: >>> > @@ -75,6 +76,8 @@ static const struct v4l2_f

Re: [PATCH] media: vivid: Support 480p for webcam capture

2018-10-08 Thread Mauro Carvalho Chehab
Em Mon, 8 Oct 2018 19:53:38 +0200 Hans Verkuil escreveu: > On 10/08/2018 07:03 PM, Mauro Carvalho Chehab wrote: > > Em Wed, 3 Oct 2018 12:14:22 +0100 > > Kieran Bingham escreveu: > > > >>> @@ -75,6 +76,8 @@ static const struct v4l2_fract > >>> webcam_intervals[VIVID_WEBCAM_IVALS] = { > >>>

Re: [PATCH] media: vivid: Support 480p for webcam capture

2018-10-08 Thread Hans Verkuil
On 10/08/2018 07:03 PM, Mauro Carvalho Chehab wrote: > Em Wed, 3 Oct 2018 12:14:22 +0100 > Kieran Bingham escreveu: > >>> @@ -75,6 +76,8 @@ static const struct v4l2_fract >>> webcam_intervals[VIVID_WEBCAM_IVALS] = { >>> { 1, 5 }, >>> { 1, 10 }, >>> { 1, 15 }, >>> + { 1, 15 }, >

Re: [GIT PULL for 4.20] Lens driver fixes, imx214 sensor driver

2018-10-08 Thread Sakari Ailus
Hi Mauro, On Mon, Oct 08, 2018 at 12:57:22PM -0300, Mauro Carvalho Chehab wrote: > Em Sun, 7 Oct 2018 16:05:57 +0300 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > This last pull for 4.20 contains dw9714 and dw9807 lens driver probe error > > handling fixes and the Sony imx214 sensor driver.

Re: [PATCH] media: vivid: Support 480p for webcam capture

2018-10-08 Thread Mauro Carvalho Chehab
Em Wed, 3 Oct 2018 12:14:22 +0100 Kieran Bingham escreveu: > > @@ -75,6 +76,8 @@ static const struct v4l2_fract > > webcam_intervals[VIVID_WEBCAM_IVALS] = { > > { 1, 5 }, > > { 1, 10 }, > > { 1, 15 }, > > + { 1, 15 }, > > + { 1, 25 }, As the code requires that VIVID_WEBCA

Re: [PATCH v2 2/3] rcar-vin: add support for UDS (Up Down Scaler)

2018-10-08 Thread Sakari Ailus
Hi Niklas, On Thu, Oct 04, 2018 at 10:04:01PM +0200, Niklas Söderlund wrote: > Some VIN instances have access to a Up Down Scaler (UDS). The UDS are on > most SoCs shared between two VINs, the UDS can of course only be used by > one VIN at a time. > > Add support to configure the UDS registers wh

Re: [PATCH v11 2/2] media: V3s: Add support for Allwinner CSI.

2018-10-08 Thread Sakari Ailus
Hi Yong, On Sat, Sep 29, 2018 at 06:18:44PM +0800, Yong wrote: > Hi Sakari, > > On Fri, 28 Sep 2018 13:19:37 +0300 > Sakari Ailus wrote: > > > Hi Yong, > > > > Thanks for the update! This looks pretty good; some small bits to fix > > still, please see my comments below. > > > > On Wed, Sep 26

Re: [GIT PULL for 4.20] Lens driver fixes, imx214 sensor driver

2018-10-08 Thread Mauro Carvalho Chehab
Em Sun, 7 Oct 2018 16:05:57 +0300 Sakari Ailus escreveu: > Hi Mauro, > > This last pull for 4.20 contains dw9714 and dw9807 lens driver probe error > handling fixes and the Sony imx214 sensor driver. In other words, patches > that have roughly nil changes of breaking something. > > Compile test

Re: [RFC PATCH 00/11] Convert last remaining g/s_crop/cropcap drivers

2018-10-08 Thread Sakari Ailus
Hi Hans, On Fri, Oct 05, 2018 at 09:49:00AM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > This patch series converts the last remaining drivers that use g/s_crop and > cropcap to g/s_selection. > > The first two patches do some minor code cleanup. > > The third patch adds a new video_dev

[GIT PULL FOR v4.20] Various fixes

2018-10-08 Thread Hans Verkuil
Hi Mauro, Final pull request for 4.20 with odd 'n ends. Regards, Hans The following changes since commit 557c97b5133669297be561e6091da9ab6e488e65: media: cec: name for RC passthrough device does not need 'RC for' (2018-10-05 11:28:13 -0400) are available in the Git repository at:

Re: [PATCH v2 1/6] media: video-i2c: avoid accessing released memory area when removing driver

2018-10-08 Thread Akinobu Mita
2018年10月8日(月) 20:21 Hans Verkuil : > > On 10/05/2018 04:59 PM, Akinobu Mita wrote: > > 2018年10月5日(金) 18:36 Sakari Ailus : > >> > >> Hi Hans, > >> > >> On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote: > >>> On 09/23/2018 06:34 PM, Akinobu Mita wrote: > The video_i2c_data is allocat

Re: [Outreachy kernel] [PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`

2018-10-08 Thread Greg KH
On Mon, Oct 08, 2018 at 03:29:03PM +0200, Hans Verkuil wrote: > On 10/08/2018 03:07 PM, Greg KH wrote: > > On Mon, Oct 08, 2018 at 03:06:47PM +0300, Dafna Hirschfeld wrote: > >> Replace calls to `printk` with the appropriate `pr_*` > >> macro. > >> > >> Signed-off-by: Dafna Hirschfeld > >> --- > >

[PATCH] omapdrm/dss/hdmi4_cec.c: simplify clear_tx/rx_fifo functions

2018-10-08 Thread Hans Verkuil
Use REG_GET to avoid the temp variable. Add pr_err_once if hdmi_cec_clear_tx_fifo() fails in hdmi4_cec_irq(). Signed-off-by: Hans Verkuil --- Note: the FIFOs are cleared almost immediately (after just one try), so adding delays is overkill. --- diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.

Re: [PATCH v10 0/5] Venus updates - PIL

2018-10-08 Thread Vikash Garodia
Please ignore this version. Forgot to update the documentation. Updated the same in v11 and posted it. On 2018-10-08 18:52, Vikash Garodia wrote: This version of the series * extends the description of firmware subnode in documentation. * renames the flag suggesting the presence of tz and update

[PATCH v11 5/5] dt-bindings: media: Document bindings for venus firmware device

2018-10-08 Thread Vikash Garodia
Add devicetree binding documentation for firmware loader for video hardware running on qualcomm chip. Signed-off-by: Vikash Garodia Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/media/qcom,venus.txt | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --gi

[PATCH v11 4/5] venus: firmware: add no TZ boot and shutdown routine

2018-10-08 Thread Vikash Garodia
Video hardware is mainly comprised of vcodec subsystem and video control subsystem. Video control has ARM9 which executes the video firmware instructions whereas vcodec does the video frame processing. This change adds support to load the video firmware and bring ARM9 out of reset for platforms whi

[PATCH v11 3/5] venus: firmware: register separate platform_device for firmware loader

2018-10-08 Thread Vikash Garodia
From: Stanimir Varbanov This registers a firmware platform_device and associate it with video-firmware DT subnode. Then calls dma configure to initialize dma and iommu. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.c | 14 +-- drivers/media/platform/qcom/v

[PATCH v11 2/5] venus: firmware: move load firmware in a separate function

2018-10-08 Thread Vikash Garodia
Separate firmware loading part into a new function. Signed-off-by: Vikash Garodia --- drivers/media/platform/qcom/venus/core.c | 4 +- drivers/media/platform/qcom/venus/firmware.c | 55 ++-- drivers/media/platform/qcom/venus/firmware.h | 2 +- 3 files changed, 38 in

[PATCH v11 1/5] venus: firmware: add routine to reset ARM9

2018-10-08 Thread Vikash Garodia
Add routine to reset the ARM9 and brings it out of reset. Also abstract the Venus CPU state handling with a new function. This is in preparation to add PIL functionality in venus driver. Signed-off-by: Vikash Garodia --- drivers/media/platform/qcom/venus/core.h | 2 ++ drivers/media/pla

[PATCH v11 0/5] Venus updates - PIL

2018-10-08 Thread Vikash Garodia
This version of the series * extends the description of firmware subnode in documentation. * renames the flag suggesting the presence of tz and update code accordingly. Stanimir Varbanov (1): venus: firmware: register separate platform_device for firmware loader Vikash Garodia (4): venus: f

Re: [Outreachy kernel] [PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`

2018-10-08 Thread Hans Verkuil
On 10/08/2018 03:07 PM, Greg KH wrote: > On Mon, Oct 08, 2018 at 03:06:47PM +0300, Dafna Hirschfeld wrote: >> Replace calls to `printk` with the appropriate `pr_*` >> macro. >> >> Signed-off-by: Dafna Hirschfeld >> --- >> drivers/media/usb/pvrusb2/pvrusb2-debug.h| 2 +- >> drivers/media/usb/

[PATCH v10 3/5] venus: firmware: register separate platform_device for firmware loader

2018-10-08 Thread Vikash Garodia
From: Stanimir Varbanov This registers a firmware platform_device and associate it with video-firmware DT subnode. Then calls dma configure to initialize dma and iommu. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.c | 14 +-- drivers/media/platform/qcom/v

[PATCH v10 5/5] dt-bindings: media: Document bindings for venus firmware device

2018-10-08 Thread Vikash Garodia
Add devicetree binding documentation for firmware loader for video hardware running on qualcomm chip. Signed-off-by: Vikash Garodia Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/media/qcom,venus.txt | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[PATCH v10 4/5] venus: firmware: add no TZ boot and shutdown routine

2018-10-08 Thread Vikash Garodia
Video hardware is mainly comprised of vcodec subsystem and video control subsystem. Video control has ARM9 which executes the video firmware instructions whereas vcodec does the video frame processing. This change adds support to load the video firmware and bring ARM9 out of reset for platforms whi

[PATCH v10 1/5] venus: firmware: add routine to reset ARM9

2018-10-08 Thread Vikash Garodia
Add routine to reset the ARM9 and brings it out of reset. Also abstract the Venus CPU state handling with a new function. This is in preparation to add PIL functionality in venus driver. Signed-off-by: Vikash Garodia --- drivers/media/platform/qcom/venus/core.h | 2 ++ drivers/media/pla

[PATCH v10 2/5] venus: firmware: move load firmware in a separate function

2018-10-08 Thread Vikash Garodia
Separate firmware loading part into a new function. Signed-off-by: Vikash Garodia --- drivers/media/platform/qcom/venus/core.c | 4 +- drivers/media/platform/qcom/venus/firmware.c | 55 ++-- drivers/media/platform/qcom/venus/firmware.h | 2 +- 3 files changed, 38 in

[PATCH v10 0/5] Venus updates - PIL

2018-10-08 Thread Vikash Garodia
This version of the series * extends the description of firmware subnode in documentation. * renames the flag suggesting the presence of tz and update code accordingly. Stanimir Varbanov (1): venus: firmware: register separate platform_device for firmware loader Vikash Garodia (4): venus: f

Re: [Outreachy kernel] [PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`

2018-10-08 Thread Greg KH
On Mon, Oct 08, 2018 at 03:06:47PM +0300, Dafna Hirschfeld wrote: > Replace calls to `printk` with the appropriate `pr_*` > macro. > > Signed-off-by: Dafna Hirschfeld > --- > drivers/media/usb/pvrusb2/pvrusb2-debug.h| 2 +- > drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8 +++--- > drive

Re: [PATCH 4/5] omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done

2018-10-08 Thread Tomi Valkeinen
On 08/10/18 15:55, Hans Verkuil wrote: > On 10/08/2018 02:45 PM, Tomi Valkeinen wrote: >> Hi Hans, >> >> On 04/10/18 12:08, Hans Verkuil wrote: >>> From: Hans Verkuil >>> >>> The TX FIFO has to be cleared if the transmit failed due to e.g. >>> a NACK condition, otherwise the hardware will keep try

Re: [PATCH 5/5] omapdrm/dss/hdmi4_cec.c: don't set the retransmit count

2018-10-08 Thread Hans Verkuil
On 10/08/2018 02:47 PM, Tomi Valkeinen wrote: > On 04/10/18 12:09, Hans Verkuil wrote: >> From: Hans Verkuil >> >> The HDMI_CEC_DBG_3 register does have a retransmit count, but you >> can't write to it, those bits are read-only. >> >> So drop the attempt to set the retransmit count, since it doesn

Re: [PATCH 4/5] omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done

2018-10-08 Thread Hans Verkuil
On 10/08/2018 02:52 PM, Tomi Valkeinen wrote: > > On 05/10/18 17:13, Hans Verkuil wrote: >> Tomi, >> >> Can you review this patch and the next? They should go to 4.20. >> This patch in particular is a nasty one, hard to reproduce. >> >> This patch should also be Cc-ed to stable for 4.15 and up. >

Re: [PATCH 4/5] omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done

2018-10-08 Thread Hans Verkuil
On 10/08/2018 02:45 PM, Tomi Valkeinen wrote: > Hi Hans, > > On 04/10/18 12:08, Hans Verkuil wrote: >> From: Hans Verkuil >> >> The TX FIFO has to be cleared if the transmit failed due to e.g. >> a NACK condition, otherwise the hardware will keep trying to >> transmit the message. >> >> An attemp

Re: [PATCH 4/5] omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done

2018-10-08 Thread Tomi Valkeinen
On 05/10/18 17:13, Hans Verkuil wrote: > Tomi, > > Can you review this patch and the next? They should go to 4.20. > This patch in particular is a nasty one, hard to reproduce. > > This patch should also be Cc-ed to stable for 4.15 and up. Done. There's no dependency from the omapdrm patches t

Re: [PATCH v2 1/2] media: add SECO cec driver

2018-10-08 Thread ektor5
On Sat, Oct 06, 2018 at 03:49:18PM +0200, jacopo mondi wrote: > Hi Ettore, >some more comments below. > > On Fri, Oct 05, 2018 at 07:33:58PM +0200, ektor5 wrote: > > From: Ettore Chimenti > > > > This patch adds support to the CEC device implemented with a STM32 > > microcontroller in X86 SEC

Re: [PATCH 5/5] omapdrm/dss/hdmi4_cec.c: don't set the retransmit count

2018-10-08 Thread Tomi Valkeinen
On 04/10/18 12:09, Hans Verkuil wrote: > From: Hans Verkuil > > The HDMI_CEC_DBG_3 register does have a retransmit count, but you > can't write to it, those bits are read-only. > > So drop the attempt to set the retransmit count, since it doesn't > work. > > Signed-off-by: Hans Verkuil > --- >

Re: [PATCH 4/5] omapdrm/dss/hdmi4_cec.c: clear TX FIFO before transmit_done

2018-10-08 Thread Tomi Valkeinen
Hi Hans, On 04/10/18 12:08, Hans Verkuil wrote: > From: Hans Verkuil > > The TX FIFO has to be cleared if the transmit failed due to e.g. > a NACK condition, otherwise the hardware will keep trying to > transmit the message. > > An attempt was made to do this, but it was done after the call to

[PATCH 2/2] media: vivid: Add 16-bit bayer to format list

2018-10-08 Thread bwinther
From: Bård Eirik Winther New 16-bit bayer options are available in tpg so enable them in vivid. Signed-off-by: Bård Eirik Winther --- .../media/platform/vivid/vivid-vid-common.c | 28 +++ 1 file changed, 28 insertions(+) diff --git a/drivers/media/platform/vivid/vivid-vid-co

[PATCH 1/2] media: v4l2-tpg-core: Add 16-bit bayer

2018-10-08 Thread bwinther
From: Bård Eirik Winther Add 16-bit bayer formats to the test pattern generator, namely V4L2_PIX_FMT_SRGGB16 V4L2_PIX_FMT_SGRBG16 V4L2_PIX_FMT_SGBRG16 V4L2_PIX_FMT_SBGGR16 Signed-off-by: Bård Eirik Winther --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 28 +++ 1 fi

[PATCH 3/4] qv4l2: Add 16-bit bayer rendering

2018-10-08 Thread bwinther
From: Bård Eirik Winther Add OpenGL support to render all v4l2 16-bit bayer formats Signed-off-by: Bård Eirik Winther --- utils/qv4l2/capture-win-gl.cpp | 24 1 file changed, 24 insertions(+) diff --git a/utils/qv4l2/capture-win-gl.cpp b/utils/qv4l2/capture-win-gl.cpp

[PATCH 2/4] qvidcap: Add 16-bit bayer rendering

2018-10-08 Thread bwinther
From: Bård Eirik Winther Add OpenGL support to render all v4l2 16-bit bayer formats Signed-off-by: Bård Eirik Winther --- utils/qvidcap/capture-win-gl.cpp | 28 utils/qvidcap/v4l2-convert.glsl | 13 + 2 files changed, 37 insertions(+), 4 deletions(-)

[PATCH 1/4] common: utils: Add last 3 16-bit bayer formats

2018-10-08 Thread bwinther
From: Bård Eirik Winther Add the remaining 16-bit bayer formats to rle_calc_bpl, namely: V4L2_PIX_FMT_SGBRG16 V4L2_PIX_FMT_SGRBG16 V4L2_PIX_FMT_SRGGB16 Signed-off-by: Bård Eirik Winther --- utils/common/v4l-stream.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/utils/common/v4l-

[PATCH 4/4] utils: Add qvidcap to configure status report

2018-10-08 Thread bwinther
From: Bård Eirik Winther Add missing build status flag for qvidcap to the configuration report Signed-off-by: Bård Eirik Winther --- configure.ac | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.ac b/configure.ac index 2765fbfc..90ef10aa 100644 --- a/configure.ac +++ b/configure

Re: [PATCH 1/2] media: docs-rst: Document memory-to-memory video decoder interface

2018-10-08 Thread Hans Verkuil
On 09/19/2018 12:17 PM, Tomasz Figa wrote: > Hi Hans, > > On Thu, Jul 26, 2018 at 7:20 PM Tomasz Figa wrote: >> >> Hi Hans, >> >> On Wed, Jul 25, 2018 at 8:59 PM Hans Verkuil wrote: >>> >>> Hi Tomasz, >>> >>> Many, many thanks for working on this! It's a great document and when done >>> it will

Re: [PATCH v2] venus: vdec: fix decoded data size

2018-10-08 Thread Stanimir Varbanov
Hi Vikash, On 10/08/2018 02:09 PM, Vikash Garodia wrote: > Existing code returns the max of the decoded size and buffer size. > It turns out that buffer size is always greater due to hardware > alignment requirement. As a result, payload size given to client > is incorrect. This change ensures tha

[PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`

2018-10-08 Thread Dafna Hirschfeld
Replace calls to `printk` with the appropriate `pr_*` macro. Signed-off-by: Dafna Hirschfeld --- drivers/media/usb/pvrusb2/pvrusb2-debug.h| 2 +- drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8 +++--- drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c | 28 +--- drivers/media/u

[RFC] Informal meeting during ELCE to discuss userspace support for stateless codecs

2018-10-08 Thread Hans Verkuil
Hi all, I would like to meet up somewhere during the ELCE to discuss userspace support for stateless (and perhaps stateful as well?) codecs. It is also planned as a topic during the summit, but I would prefer to prepare for that in advance, esp. since I myself do not have any experience writing u

Re: [PATCH v2 1/6] media: video-i2c: avoid accessing released memory area when removing driver

2018-10-08 Thread Hans Verkuil
On 10/05/2018 04:59 PM, Akinobu Mita wrote: > 2018年10月5日(金) 18:36 Sakari Ailus : >> >> Hi Hans, >> >> On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote: >>> On 09/23/2018 06:34 PM, Akinobu Mita wrote: The video_i2c_data is allocated by kzalloc and released by the video device's

Re: [PATCH] venus: vdec: fix decoded data size

2018-10-08 Thread Vikash Garodia
Hi Stanimir, On 2018-10-05 20:56, Stanimir Varbanov wrote: Hi Vikash, please, increment the version of the patch next time. This one must be v2. On 10/03/2018 02:30 PM, Vikash Garodia wrote: Exisiting code returns the max of the decoded size and buffer size. s/Exisiting/Existing Posted

[PATCH v2] venus: vdec: fix decoded data size

2018-10-08 Thread Vikash Garodia
Existing code returns the max of the decoded size and buffer size. It turns out that buffer size is always greater due to hardware alignment requirement. As a result, payload size given to client is incorrect. This change ensures that the bytesused is assigned to actual payload size, when available

Re: [PATCH v5] media: docs: add glossary.rst with common terms used at V4L2 spec

2018-10-08 Thread Hans Verkuil
On 10/04/2018 05:03 PM, Mauro Carvalho Chehab wrote: > From: Mauro Carvalho Chehab > > Add a glossary of terms used within the media userspace API > documentation, as several concepts are complex enough to cause > misunderstandings. > > Signed-off-by: Mauro Carvalho Chehab With the understandi

Re: [RFC PATCH v2] media: docs-rst: Document m2m stateless video decoder interface

2018-10-08 Thread Hans Verkuil
On 10/04/2018 10:11 AM, Alexandre Courbot wrote: > This patch documents the protocol that user-space should follow when > communicating with stateless video decoders. It is based on the > following references: > > * The current protocol used by Chromium (converted from config store to > request

Re: [RFC PATCH v2] media: docs-rst: Document m2m stateless video decoder interface

2018-10-08 Thread Hans Verkuil
On 10/05/2018 07:10 PM, Paul Kocialkowski wrote: > Hi, > > Le jeudi 04 octobre 2018 à 14:10 -0400, Nicolas Dufresne a écrit : >> Le jeudi 04 octobre 2018 à 14:47 +0200, Paul Kocialkowski a écrit : +Instance of struct v4l2_ctrl_h264_scaling_matrix, containing the scaling +ma

Re: [RFC PATCH] media: docs-rst: Document m2m stateless video decoder interface

2018-10-08 Thread Hans Verkuil
On 10/03/2018 12:10 PM, Tomasz Figa wrote: > On Tue, Sep 11, 2018 at 5:48 PM Hans Verkuil wrote: >> >> On 09/11/18 10:40, Alexandre Courbot wrote: I am not sure whether this should be documented, but there are some additional restrictions w.r.t. reference frames: Since de

Re: [PATCH] media: vivid: Support 480p for webcam capture

2018-10-08 Thread Kieran Bingham
On 08/10/18 10:00, Hans Verkuil wrote: > On 10/08/2018 10:35 AM, Kieran Bingham wrote: >> On 06/10/18 11:29, Keiichi Watanabe wrote: >>> Hi all, >>> >>> On Fri, Oct 5, 2018 at 6:18 PM, Hans Verkuil wrote: On 10/03/18 09:08, Keiichi Watanabe wrote: > I think 480p is a common frame size and

Re: [PATCH] media: vivid: Support 480p for webcam capture

2018-10-08 Thread Hans Verkuil
On 10/08/2018 10:35 AM, Kieran Bingham wrote: > On 06/10/18 11:29, Keiichi Watanabe wrote: >> Hi all, >> >> On Fri, Oct 5, 2018 at 6:18 PM, Hans Verkuil wrote: >>> On 10/03/18 09:08, Keiichi Watanabe wrote: I think 480p is a common frame size and it's worth supporting in vivid. But, my p

Re: [PATCH] media: vivid: Support 480p for webcam capture

2018-10-08 Thread Kieran Bingham
On 06/10/18 11:29, Keiichi Watanabe wrote: > Hi all, > > On Fri, Oct 5, 2018 at 6:18 PM, Hans Verkuil wrote: >> On 10/03/18 09:08, Keiichi Watanabe wrote: >>> I think 480p is a common frame size and it's worth supporting in vivid. >>> But, my patch might be ad-hoc. Actually, I'm not sure which va

Re: [PATCH -next] media: imx-pxp: remove duplicated include from imx-pxp.c

2018-10-08 Thread Philipp Zabel
On Sat, 2018-10-06 at 07:36 +, YueHaibing wrote: > Remove duplicated include. > > Signed-off-by: YueHaibing > --- > drivers/media/platform/imx-pxp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/imx-pxp.c > b/drivers/media/platform/imx-pxp.c > index b76cd0e