Re: [PATCH][media-next] media: sun6i: fix spelling mistake "droped" -> "dropped"

2018-11-29 Thread Maxime Ripard
On Thu, Nov 29, 2018 at 10:50:38AM +, Colin King wrote: > From: Colin Ian King > > There are spelling mistakes in dev_dbg messages, fix them. > > Signed-off-by: Colin Ian King Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin

Re: [PATCH] media: videodev2: add V4L2_FMT_FLAG_NO_SOURCE_CHANGE

2018-11-29 Thread Hans Verkuil
On 11/29/2018 08:35 PM, Tomasz Figa wrote: > On Thu, Nov 29, 2018 at 1:01 AM Hans Verkuil wrote: >> >> On 10/04/2018 03:37 PM, Maxime Jourdan wrote: >>> When a v4l2 driver exposes V4L2_EVENT_SOURCE_CHANGE, some (usually >>> OUTPUT) formats may not be able to trigger this event. >>> >>> Add a enum_

Re: [linux-sunxi] [PATCH v2 2/2] media: cedrus: Add H264 decoding support

2018-11-29 Thread Maxime Ripard
On Tue, Nov 27, 2018 at 05:30:00PM +0100, Jernej Škrabec wrote: > > > > +static void _cedrus_write_ref_list(struct cedrus_ctx *ctx, > > > > + struct cedrus_run *run, > > > > + const u8 *ref_list, u8 num_ref, > > > > +

Re: Possible regression in v4l2-async

2018-11-29 Thread Steve Longerbeam
Hi Niklas, On 11/29/18 6:25 PM, Niklas Söderlund wrote: Hi Sakari, Steve, Thanks for your quick response. On 2018-11-29 22:37:53 +0200, Sakari Ailus wrote: Hi Steve, Niklas, On Thu, Nov 29, 2018 at 11:41:32AM -0800, Steve Longerbeam wrote: On 11/29/18 11:26 AM, Steve Longerbeam wrote: Hi N

cron job: media_tree daily build: ERRORS

2018-11-29 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Nov 30 05:00:11 CET 2018 media-tree git hash:708d75fe1c7c6e9abc5381b6fcc32b49830383d0 media_build git

Re: [PATCH 07/15] arm64: dts: allwinner: h5: Add system-control node with SRAM C1

2018-11-29 Thread Chen-Yu Tsai
On Fri, Nov 16, 2018 at 12:52 AM Chen-Yu Tsai wrote: > > On Thu, Nov 15, 2018 at 10:50 PM Paul Kocialkowski > wrote: > > > > Add the H5-specific system control node description to its device-tree > > with support for the SRAM C1 section, that will be used by the video > > codec node later on. > >

Re: Possible regression in v4l2-async

2018-11-29 Thread Niklas Söderlund
Hi Sakari, Steve, Thanks for your quick response. On 2018-11-29 22:37:53 +0200, Sakari Ailus wrote: > Hi Steve, Niklas, > > On Thu, Nov 29, 2018 at 11:41:32AM -0800, Steve Longerbeam wrote: > > > > > > On 11/29/18 11:26 AM, Steve Longerbeam wrote: > > > Hi Niklas, > > > > > > On 11/29/18 10:4

[GIT PULL FOR v4.21] uvcvideo updates

2018-11-29 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 708d75fe1c7c6e9abc5381b6fcc32b49830383d0: media: dvb-pll: don't re-validate tuner frequencies (2018-11-23 12:27:18 -0500) are available in the Git repository at: git://linuxtv.org/pinchartl/media.git uvc/next for you to fetch changes up to dd3b

[PATCH] v4l2: async: remove locking when initializing async notifier

2018-11-29 Thread Niklas Söderlund
There is no need to hold the list_lock when initializing the local asd_list of a notifier. Remove the lock handling to simplify the code and remove a potential LOCKDEP warning. Signed-off-by: Niklas Söderlund Reported-by: Jacopo Mondi --- drivers/media/v4l2-core/v4l2-async.c | 4 1 file ch

[GIT PULL FOR v4.21] Xilinx media drivers updates

2018-11-29 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 708d75fe1c7c6e9abc5381b6fcc32b49830383d0: media: dvb-pll: don't re-validate tuner frequencies (2018-11-23 12:27:18 -0500) are available in the Git repository at: git://linuxtv.org/pinchartl/media.git xilinx/next for you to fetch changes up to 6

[PATCH v2] media: venus: Support V4L2 QP parameters in Venus encoder

2018-11-29 Thread Kelvin Lawson
Support V4L2 QP parameters in Venus encoder: * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_QP * V4L2_CID_MPEG_VIDEO_H264_B_FRAME_QP * V4L2_CID_MPEG_VIDEO_H264_MIN_QP * V4L2_CID_MPEG_VIDEO_H264_MAX_QP Signed-off-by: Kelvin Lawson --- drivers/media/platform/qcom/venus/venc.c | 19 +++ 1 f

Re: [PATCH] media: venus: Support V4L2 QP parameters in Venus encoder

2018-11-29 Thread Kelvin Lawson
Hi Stanimir, > As functional changes the patch is fine, but it has many coding style > issues. Did you read [1]? Yes, the patch was indented properly but it looks like it got mangled by the webmail interface. I'll re-submit. Thanks, Kelvin --- Kelvin Lawson Embedded Linux Consultant https://lis

Re: [yavta PATCH 1/1] Zero dev in main()

2018-11-29 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Thursday, 22 November 2018 17:29:56 EET Sakari Ailus wrote: > From: Sakari Ailus > > This is necessary since video_open() may not be always called soon Do you mean video_init() ? Isn't it called at the very first line of main() ? > Signed-off-by: Sakari

RE: [PATCH v7 01/16] v4l: Add Intel IPU3 meta buffer formats

2018-11-29 Thread Zhi, Yong
Hi, Laurent, Thanks for the review. > -Original Message- > From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] > Sent: Thursday, November 29, 2018 1:17 PM > To: Zhi, Yong > Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; > tf...@chromium.org; mche...@kernel.o

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-29 Thread Laurent Pinchart
Hi Sakari, On Friday, 9 November 2018 12:09:54 EET Sakari Ailus wrote: > On Wed, Nov 07, 2018 at 12:16:47PM +0800, Bing Bu Cao wrote: > > On 11/01/2018 08:03 PM, Sakari Ailus wrote: > >> On Mon, Oct 29, 2018 at 03:22:54PM -0700, Yong Zhi wrote: [snip] > >>> ImgU media topology print: > >>> > >

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-29 Thread Laurent Pinchart
Hello Bing, On Wednesday, 7 November 2018 06:16:47 EET Bing Bu Cao wrote: > On 11/01/2018 08:03 PM, Sakari Ailus wrote: > > On Mon, Oct 29, 2018 at 03:22:54PM -0700, Yong Zhi wrote: [snip] > >> ImgU media topology print: > >> > >> # media-ctl -d /dev/media0 -p > >> Media controller API version

RE: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

2018-11-29 Thread Zhi, Yong
Hi, Sakari, > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > Sent: Thursday, November 29, 2018 4:46 PM > To: Zhi, Yong > Cc: linux-media@vger.kernel.org; tf...@chromium.org; > mche...@kernel.org; hans.verk...@cisco.com; > laurent.pinch...@ideasonboard.com;

RE: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-29 Thread Mani, Rajmohan
Hi Laurent, Tomasz, Thanks for the reviews. > Subject: Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset > > Hi Tomasz, > > On Thursday, 29 November 2018 21:51:32 EET Tomasz Figa wrote: > > On Thu, Nov 29, 2018 at 6:43 AM Laurent Pinchart wrote: > > > On Tuesday, 30 October 2018 00:22:54 EET Yong Z

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-29 Thread Laurent Pinchart
Hi Tomasz, On Thursday, 29 November 2018 21:51:32 EET Tomasz Figa wrote: > On Thu, Nov 29, 2018 at 6:43 AM Laurent Pinchart wrote: > > On Tuesday, 30 October 2018 00:22:54 EET Yong Zhi wrote: [snip] > >> 1. Link pad flag of video nodes (i.e. ipu3-imgu 0 output) need to be > >> enabled prior to t

Re: [PATCH v7 02/16] doc-rst: Add Intel IPU3 documentation

2018-11-29 Thread Laurent Pinchart
Hello Yong, Thank you for the patch. On Tuesday, 30 October 2018 00:22:56 EET Yong Zhi wrote: > From: Rajmohan Mani > > This patch adds the details about the IPU3 Imaging Unit driver. Strictly speaking this documents both the CIO2 and the IMGU. As they're handled by two separate drivers, shou

[PATCH 1/4] media: lmedm04: Add missing usb_free_urb to free, interrupt urb

2018-11-29 Thread Malcolm Priestley
The interrupt urb is killed but never freed add the function Cc: sta...@vger.kernel.org Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b/drivers/media/usb/dvb-usb-v2/lmedm04.c

[PATCH 2/4] media: lmedm04: Move usb buffer to lme2510_state.

2018-11-29 Thread Malcolm Priestley
lme2510_state exists for the entire duration of driver. Move usb_buffer to lme2510_state removing the need for lme2510_exit_int for removing the buffer. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 35 +++--- 1 file changed, 3 insertions(+),

[PATCH 3/4] media: lmedm04: Move interrupt buffer to priv buffer.

2018-11-29 Thread Malcolm Priestley
Interrupt is always present throught life time of there is no dma element move this buffer to private area of driver. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/driver

[PATCH 4/4] media: lmedm04: use dvb_usbv2_generic_rw_locked

2018-11-29 Thread Malcolm Priestley
Use dvb-usb-v2 generic usb function for bulk transfers and simplify logic. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 42 -- 1 file changed, 12 insertions(+), 30 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b/driver

Re: Possible regression in v4l2-async

2018-11-29 Thread Sakari Ailus
Hi Steve, Niklas, On Thu, Nov 29, 2018 at 11:41:32AM -0800, Steve Longerbeam wrote: > > > On 11/29/18 11:26 AM, Steve Longerbeam wrote: > > Hi Niklas, > > > > On 11/29/18 10:47 AM, Niklas Söderlund wrote: > > > Hi Steve, Sakari and Hans, > > > > > > I have been made aware of a possible regress

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-29 Thread Tomasz Figa
On Thu, Nov 29, 2018 at 6:43 AM Laurent Pinchart wrote: > > Hello Yong, > > On Tuesday, 30 October 2018 00:22:54 EET Yong Zhi wrote: > > Hi, > > > > This series adds support for the Intel IPU3 (Image Processing Unit) > > ImgU which is essentially a modern memory-to-memory ISP. It implements > > ra

Re: Possible regression in v4l2-async

2018-11-29 Thread Steve Longerbeam
On 11/29/18 11:26 AM, Steve Longerbeam wrote: Hi Niklas, On 11/29/18 10:47 AM, Niklas Söderlund wrote: Hi Steve, Sakari and Hans, I have been made aware of a possible regression by a few users of rcar-vin and I'm a bit puzzled how to best handle it. Maybe you can help me out? The issue is

Re: [PATCH v3] media: venus: add support for key frame

2018-11-29 Thread Tomasz Figa
On Thu, Nov 29, 2018 at 3:10 AM wrote: > > > Hi Stan, > > On 2018-11-29 16:01, Stanimir Varbanov wrote: > > Hi Tomasz, > > > > On 11/3/18 5:01 AM, Tomasz Figa wrote: > >> Hi Malathi, > >> > >> On Fri, Nov 2, 2018 at 9:58 PM Malathi Gottam > >> wrote: > >>> > >>> When client requests for a keyfram

Re: [PATCH] media: videodev2: add V4L2_FMT_FLAG_NO_SOURCE_CHANGE

2018-11-29 Thread Tomasz Figa
On Thu, Nov 29, 2018 at 1:01 AM Hans Verkuil wrote: > > On 10/04/2018 03:37 PM, Maxime Jourdan wrote: > > When a v4l2 driver exposes V4L2_EVENT_SOURCE_CHANGE, some (usually > > OUTPUT) formats may not be able to trigger this event. > > > > Add a enum_fmt format flag to tag those specific formats.

Re: Possible regression in v4l2-async

2018-11-29 Thread Steve Longerbeam
Hi Niklas, On 11/29/18 10:47 AM, Niklas Söderlund wrote: Hi Steve, Sakari and Hans, I have been made aware of a possible regression by a few users of rcar-vin and I'm a bit puzzled how to best handle it. Maybe you can help me out? The issue is visible when running with LOCKDEP enabled and it p

Re: [PATCH v7 01/16] v4l: Add Intel IPU3 meta buffer formats

2018-11-29 Thread Laurent Pinchart
Hello Yong, Thank you for the patch. On Tuesday, 30 October 2018 00:22:55 EET Yong Zhi wrote: > Add IPU3-specific meta formats for parameter > processing and 3A, DVS statistics: Unless I'm mistaken DVS support has been removed. You can write this as Add IPU3-specific meta formats for processing

Re: [PATCH v4 1/4] dt-bindings: adv748x: make data-lanes property mandatory for CSI-2 endpoints

2018-11-29 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Thursday, 29 November 2018 04:01:44 EET Niklas Söderlund wrote: > The CSI-2 transmitters can use a different number of lanes to transmit > data. Make the data-lanes mandatory for the endpoints that describe the > transmitters as no good default can be set to

Possible regression in v4l2-async

2018-11-29 Thread Niklas Söderlund
Hi Steve, Sakari and Hans, I have been made aware of a possible regression by a few users of rcar-vin and I'm a bit puzzled how to best handle it. Maybe you can help me out? The issue is visible when running with LOCKDEP enabled and it prints a warning about a possible circular locking depende

Re: [PATCH 0/2] media: ov5640: MIPI fixes on top of Maxime's v5

2018-11-29 Thread Adam Ford
On Thu, Nov 29, 2018 at 8:48 AM Jacopo Mondi wrote: > > Hello ov5640-ers, >these two patches should be applied on top of Maxime's clock tree rework v5 > and 'fix' MIPI CSI-2 clock tree configuration. > > The first patch is a fix that appeard in various forms on the list several > times: if the

Re: Astrometa DVB-T2 2018 update

2018-11-29 Thread Sean Young
On Mon, Nov 05, 2018 at 07:12:52PM +, Bob Goddard wrote: > Enable Sony CXD2837ER slave demon on the Astrometa DVB-T2, known as the 2018 > update. > > Originally based on the patch by kapitanf at > https://github.com/torvalds/linux/pull/567, it was not quite right. This is > more correct, bu

RE: [PATCH 4/5] media: rcar-vin: Enable support for r8a774a1

2018-11-29 Thread Biju Das
Hello Mauro, Does this patch look ok to you? Thanks, Fab > -Original Message- > From: Biju Das > Sent: 10 September 2018 15:31 > To: Mauro Carvalho Chehab > Cc: Biju Das ; Niklas Söderlund > ; linux-media@vger.kernel.org; linux- > renesas-...@vger.kernel.org; Simon Horman ; Geert > Uyt

[PATCH 2/2] media: ov5640: make MIPI clock depend on mode

2018-11-29 Thread Jacopo Mondi
The MIPI clock generation tree uses the MIPI_DIV divider to generate both the MIPI SCALER CLOCK and the PIXEL_CLOCK. It seems the MIPI BIT CLK frequency is generated by either the MIPI SCALER or the PIXEL CLOCK, depending if the currently applied image mode uses the scaler or not. Make the MIPI_DI

[PATCH 0/2] media: ov5640: MIPI fixes on top of Maxime's v5

2018-11-29 Thread Jacopo Mondi
Hello ov5640-ers, these two patches should be applied on top of Maxime's clock tree rework v5 and 'fix' MIPI CSI-2 clock tree configuration. The first patch is a fix that appeard in various forms on the list several times: if the image sizes gets updated but not the image format, the size updat

[PATCH 1/2] media: ov5640: Fix set format regression

2018-11-29 Thread Jacopo Mondi
The set_fmt operations updates the sensor format only when the image format is changed. When only the image sizes gets changed, the format do not get updated causing the sensor to always report the one that was previously in use. Without this patch, updating frame size only fails: [fmt:UYVY8_2X8

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-29 Thread Laurent Pinchart
Hello Yong, On Tuesday, 30 October 2018 00:22:54 EET Yong Zhi wrote: > Hi, > > This series adds support for the Intel IPU3 (Image Processing Unit) > ImgU which is essentially a modern memory-to-memory ISP. It implements > raw Bayer to YUV image format conversion as well as a large number of > oth

Re: [PATCH v3] media: venus: add support for key frame

2018-11-29 Thread mgottam
Hi Stan, On 2018-11-29 16:01, Stanimir Varbanov wrote: Hi Tomasz, On 11/3/18 5:01 AM, Tomasz Figa wrote: Hi Malathi, On Fri, Nov 2, 2018 at 9:58 PM Malathi Gottam wrote: When client requests for a keyframe, set the property to hardware to generate the sync frame. Signed-off-by: Malathi

[PATCH][media-next] media: sun6i: fix spelling mistake "droped" -> "dropped"

2018-11-29 Thread Colin King
From: Colin Ian King There are spelling mistakes in dev_dbg messages, fix them. Signed-off-by: Colin Ian King --- drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_video.c b

Re: [PATCH v3] media: venus: add support for key frame

2018-11-29 Thread Stanimir Varbanov
Hi Tomasz, On 11/3/18 5:01 AM, Tomasz Figa wrote: > Hi Malathi, > > On Fri, Nov 2, 2018 at 9:58 PM Malathi Gottam wrote: >> >> When client requests for a keyframe, set the property >> to hardware to generate the sync frame. >> >> Signed-off-by: Malathi Gottam >> --- >> drivers/media/platform/q

[PATCH] media: pvrusb2: fix spelling mistake "statuss" -> "status"

2018-11-29 Thread Colin King
From: Colin Ian King There is a spelling mistake in a pvr2_trace trace message, fix it. Signed-off-by: Colin Ian King --- drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvr

Re: [PATCH] media: venus: Support V4L2 QP parameters in Venus encoder

2018-11-29 Thread Stanimir Varbanov
Hi Kelvin, Thanks for the patch! On 11/12/18 12:59 PM, Kelvin Lawson wrote: > Support V4L2 QP parameters in Venus encoder: > * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_QP > * V4L2_CID_MPEG_VIDEO_H264_B_FRAME_QP > * V4L2_CID_MPEG_VIDEO_H264_MIN_QP > * V4L2_CID_MPEG_VIDEO_H264_MAX_QP > > Signed-off-by

[GIT PULL FOR v4.21] Various fixes/enhancements

2018-11-29 Thread Hans Verkuil
The following changes since commit 708d75fe1c7c6e9abc5381b6fcc32b49830383d0: media: dvb-pll: don't re-validate tuner frequencies (2018-11-23 12:27:18 -0500) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v4.21g for you to fetch changes up to e5b4a

[PATCHv2] videodev2.h: add V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF/CREATE_BUFS

2018-11-29 Thread Hans Verkuil
Add new buffer capability flags to indicate if the VIDIOC_PREPARE_BUF or VIDIOC_CREATE_BUFS ioctls are supported. The reason for this is that there is currently no way for an application to detect if VIDIOC_PREPARE_BUF is implemented other than trying it, but then the buffer is already prepared. Y

Re: [PATCH] media: cedrus: Remove global IRQ spin lock from the driver

2018-11-29 Thread Paul Kocialkowski
Hi, On Fri, 2018-11-16 at 11:47 +0100, Maxime Ripard wrote: > On Thu, Nov 15, 2018 at 03:39:55PM +0100, Paul Kocialkowski wrote: > > We initially introduced a spin lock to ensure that the VPU registers > > are not accessed concurrently between our setup function and IRQ > > handler. Because the V4

[PATCH v2 1/1] media: cedrus: Remove global IRQ spin lock from the driver

2018-11-29 Thread Paul Kocialkowski
We initially introduced a spin lock to ensure that the VPU registers are not accessed concurrently between our setup function and IRQ handler. The V4L2 M2M API ensures that only one decoding job runs at a time, so the interrupt signaling the end of decoding will not occur while the next picture is

[PATCH v2 0/1] media: cedrus: Remove global IRQ spin lock from the driver

2018-11-29 Thread Paul Kocialkowski
Changes since v1: * Reworked commit message as suggested by Maxime. Paul Kocialkowski (1): media: cedrus: Remove global IRQ spin lock from the driver drivers/staging/media/sunxi/cedrus/cedrus.c | 1 - drivers/staging/media/sunxi/cedrus/cedrus.h | 2 -- drivers/staging/media/sunxi

Re: [PATCH] media: videodev2: add V4L2_FMT_FLAG_NO_SOURCE_CHANGE

2018-11-29 Thread Hans Verkuil
On 10/04/2018 03:37 PM, Maxime Jourdan wrote: > When a v4l2 driver exposes V4L2_EVENT_SOURCE_CHANGE, some (usually > OUTPUT) formats may not be able to trigger this event. > > Add a enum_fmt format flag to tag those specific formats. I think I missed (or forgot) some discussion about this since I

Re: [PATCH] media: v4l: Fix MPEG-2 slice Intra DC Precision validation

2018-11-29 Thread Paul Kocialkowski
Hi, On Sun, 2018-11-25 at 15:21 +, Jonas Karlman wrote: > intra_dc_precision is a 2-bit integer [1] > allow use of all valid options, 8 - 11 bits precision > > [1] ISO/IEC 13818-2 Table 6-13 Thanks for this patch, this is definitely a mistake from my side here! > Fixes: c27bb30e7b6d ("media

[GIT FIXES FOR v4.20] Various fixes

2018-11-29 Thread Hans Verkuil
Hi Mauro, Some more fixes for 4.20. Four of these are related to the new Request API. Found after extending the Request API tests in v4l2-compliance. Most relate to a new test where I check what happens if STREAMON returns an error the first time it is called. v4l2-compliance now has code to det