Re: Remaining BKL users, what to do

net/appletalk: net/ipx/af_ipx.c: net/irda/af_irda.c: Can probably be saved from retirement in drivers/staging if the maintainers still care. IPX and Appletalk both have active users. They also look fairly fixable as the lock_kernel just maps to a stack private mutex, or in

Re: [Ksummit-2010-discuss] [v2] Remaining BKL users, what to do

you still need to switch off preemption. Hm, how would you do that from within a driver? Do we care - unless I misunderstand the current intel DRM driver handles the i810 as well ? -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to

Re: [RFC/PATCH v6 02/12] media: Media device

On Thu, 25 Nov 2010 12:20:31 -0500 Andy Walls awa...@md.metrocast.net wrote: The signedness of char is ambiguous for 8 bit data, which is why an API would normally use u8 (or s8, I guess). Since this is known to be character data, I would think char would be fine. I am assuming C

Re: Summary of the V4L2 discussions during LDS - was: Re: Embedded Linux memory management interest group list

On both cases, the requirement is to pass a framebuffer between two entities, and not a video stream. It may not even be a framebuffer. In many cases you'll pass a framebuffer or some memory target (in DRI think probably a GEM handle), in fact in theory you can do much of this now. use

Re: [PATCH 02/10] lib: genalloc: Generic allocator improvements

I am curious about one thing Why do we need this allocator. Why not use allocate_resource and friends. The kernel generic resource handler already handles object alignment and subranges. It just seems to be a surplus allocator that could perhaps be mostly removed by using the kernel resource

Re: [PATCH 02/10] lib: genalloc: Generic allocator improvements

I plan to replace it with lib/bitmap.c bitmap_* based allocator (similar like it it is used by dma_declare_coherent_memory() and friends in drivers/base/dma-coherent.c). We need something really simple for CMA area management. IMHO allocate_resource and friends a bit too heavy here, but

Re: [PATCH] [media] v4l2 core: return -ENOIOCTLCMD if an ioctl doesn't exist

(In fact, the _correct_ thing to do would probably be to just do #define ENOIOCTLCMD ENOTTY and get rid of any translation - just giving ENOTTY a more appropriate name and less chance for confusion) Some code uses the two to separate 'the driver specific helper code doesn't handle

Re: USB mini-summit at LinuxCon Vancouver

Between two or more kernel drivers, a resource locking mechanism like the one you've proposed works fine, but, when the driver is on userspace, there's one additional issue that needs to be addressed: What happens if, for example, if a camera application using libgphoto2 crashes? The lock

Re: USB mini-summit at LinuxCon Vancouver

instead of using the V4L2 device node to access the stored images, it probably makes more sense to use a separate device for that, that will handle a separate set of ioctl's, and just use read() to retrieve the image data, after selecting the desired image number, via ioctl(). How

Re: [Mjpeg-users] [PATCH] zoran: invalid test on unsigned

On Sun, 26 Apr 2009 17:45:07 +0200 Roel Kluin roel.kl...@gmail.com wrote: fmt-index is unsigned. test doesn't work Signed-off-by: Roel Kluin roel.kl...@gmail.com --- Is there another test required? diff --git a/drivers/media/video/zoran/zoran_driver.c

[PATCH] ivtv: Fix PCI direction

From: Alan Cox a...@linux.intel.com The ivtv stream buffers may be for receive or for send but the attached sg handle is always destined cpu-device. We flush it correctly but the allocation is wrongly done with the same type as the buffers. See bug: http://bugzilla.kernel.org/show_bug.cgi?id

[PATCH 0/2] SE401 clean up

Tidy up the SE401 driver --- Alan Cox (2): se401: Fix unsafe use of sprintf with identical source/destination se401: Fix coding style drivers/media/video/se401.c | 882 ++- drivers/media/video/se401.h |7 2 files changed, 456 insertions

[PATCH 1/2] se401: Fix unsafe use of sprintf with identical source/destination

From: Alan Cox a...@linux.intel.com Closes-bug: http://bugzilla.kernel.org/show_bug.cgi?id=13435 Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/media/video/se401.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/se401.c b/drivers

[PATCH 2/2] se401: Fix coding style

From: Alan Cox a...@linux.intel.com Having fixed the sprintfs I decided a quick clean wouldn't do any harm so it was actually easy to read in future. Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/media/video/se401.c | 876 ++- drivers/media

Re: [PATCH 2/2] se401: Fix coding style

- adr += PAGE_SIZE; - size -= PAGE_SIZE; + adr += PAGE_SIZE; + size -= PAGE_SIZE; Why 2 spaces are better here? Regexps need tweaking a tiny bit I guess. I'll post a follow up patch at some point when I'm back dealing with ultra-low priority

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

BTW, circa 1995 my serial mouse Just Worked in Linux. Sometime around Correct X11 just talked to the serial ports. In fact that is still the way to configure it if you want any sanity in life. and serial connected IRs. It's also too convenient to access USB IR hardware from existing

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

If decoding can *only* be sanely handled in user-space, that's one thing. If it can be handled in kernel, then that would be better. Why ? I can compute fast fourier transforms in the kernel but that doesn't make it better than doing it in user space. I can write web servers in the kernel and

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

Half of the drivers are in user space and there are two different classes of kernel driver - LIRC and V4L. A lot of the hardware doesn't identify itself. There are two types of IR data in use - pulse timing and decoded protocol. IR is an input device. We have a nice evdev input subsystem

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

Jon is asking for an architecture discussion, y'know, with use cases. Maxim seems to be saying it's obvious that what we have today works fine. Except it doesn't appear that we have a consensus that everything is fine, nor an obvious winner for how to reduce the complexity here and keep the

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

So we're just back to the status quo of last year which is to do nothing except some minor clean up. Which in itself is vastly preferable to some grandiose scheme that turns out to be wrong. And no it's not a back to the status quo, it's a request to discuss the actual problems and options not

Re: [PATCH 0/5] Pushdown bkl from v4l ioctls

I much prefer to keep the bkl inside the v4l2 core. One reason is that I think that we can replace the bkl in the core with a mutex. Still not ideal of course, so the next step will be to implement proper locking in I did look at this a long time ago - it doesn't really work becaue the mutex

Re: [PATCH 12/13] [drivers/media] changed ioctls to unlocked

-static int dabusb_ioctl (struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg) +static long dabusb_ioctl (struct file *file, unsigned int cmd, unsigned long arg) { + lock_kernel(); pdabusb_t s = (pdabusb_t) file-private_data; After the variables or

Re: [RFC PATCH 2/3] radio-keene: add a driver for the Keene FM Transmitter.

On Mon, 16 Jan 2012 14:11:20 +0100 Oliver Neukum oneu...@suse.de wrote: Am Montag, 16. Januar 2012, 14:02:05 schrieb Hans Verkuil: +/* Set frequency (if non-0), PA, mute and turn on/off the FM transmitter. */ +static int keene_cmd_main(struct keene_device *radio, unsigned freq, bool

Re: Kernel Display and Video API Consolidation mini-summit at ELC 2012 - Notes

and when doing 2d accel on a 3d core.. it basically amounts to putting a shader compiler in the kernel. Wh! What I did for the GMA500 is to use the GTT to do scrolling by rewriting the framebuffer GTT tables so they work as a circular buffer and doing a bit of alignment of buffers. The

Re: [PATCH] RFC: dma-buf: userspace mmap support

dma-buf file descriptor. Userspace access to the buffer should be bracketed with DMA_BUF_IOCTL_{PREPARE,FINISH}_ACCESS ioctl calls to give the exporting driver a chance to deal with cache synchronization and such for cached userspace mappings without resorting to page There should be

Re: [PATCH] RFC: dma-buf: userspace mmap support

If the API was to also be used for synchronization it would have to include an atomic prepare multiple ioctl which blocked until all the buffers listed by the application were available. In the same Too slow already. You are now serializing stuff while what we want to do really is

Re: dma-buf/fbdev: one-to-many support

The main issue is that fbdev has been designed with the implicit assumption that an fbdev driver will always own the graphics memory it uses. All components in the stack, from drivers to applications, have been designed around that assumption. We could of course fix this, revamp the

[PATCH, RESEND] ov9640: fix missing break

From: Alan Cox a...@linux.intel.com Without this rev2 ends up behaving as rev3 Reported-by: dcb...@hotmail.com Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=44081 Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/media/video/ov9640.c |1 + 1 file changed, 1 insertion

[PATCH, RESEND] cx25821,medusa: incorrect check on decoder type

From: Alan Cox a...@linux.intel.com Unsupported requests should be ignored but in fact affected VDEC_A Reported-by: dcb...@hotmail.com Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=44051 Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/media/video/cx25821/cx25821-medusa

[PATCH, RESEND] az6007: fix incorrect memcpy

From: Alan Cox a...@linux.intel.com Some parts of the C language are subtle and evil. This is one example. Reported-by: dcb...@hotmail.com Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=44041 Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/media/dvb/dvb-usb/az6007.c |2

[PATCH] mantis: fix silly crash case

From: Alan Cox a...@linux.intel.com If we set mantis-fe to NULL on an error its not a good idea to then try passing NULL to the unregister paths and oopsing really. Signed-off-by: Alan Cox a...@linux.intel.com Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=16473 --- drivers/media

Re: [PATCH] [media] winbond-cir: Fix initialization

+#ifdef CONFIG_SERIAL_8250 Coule be modular + if (!io) { + struct uart_port port = { .iobase = data-sbase }; + int line = serial8250_find_port(port); + if (line = 0) { + serial8250_unregister_port(line); Hmm... Not sure if it makes

Re: [PATCH] dma-buf: mmap support

How do you ensure that no device can do DMA on the buffer while it's mapped into user space in a noncoherent manner? Why do we want to enforce that ? We provide the appropriate base service but you need to know what you are doing. In reality a lot of use cases are going to need far more than a

[PATCH] pvr2: fix minor storage

From: Alan Cox a...@linux.intel.com This should have break statements in it. Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/media/usb/pvrusb2/pvrusb2-hdw.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers

[PATCH] v4l2: sn9c102 incorrectly blocks FMT_SN9C10X

From: Alan Cox a...@linux.intel.com Missing break Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/media/usb/sn9c102/sn9c102_core.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/sn9c102/sn9c102_core.c b/drivers/media/usb/sn9c102/sn9c102_core.c index

Re: [RFC v2 0/5] Common Display Framework

On Sat, 24 Nov 2012 09:15:51 +0200 Tomi Valkeinen tomi.valkei...@ti.com wrote: On 2012-11-23 21:56, Thierry Reding wrote: On Thu, Nov 22, 2012 at 10:45:31PM +0100, Laurent Pinchart wrote: [...] Display entities are accessed by driver using notifiers. Any driver can register a display

Re: [RFC] vtunerc: virtual DVB device - is it ok to NACK driver because of worrying about possible misusage?

On Thu, 1 Dec 2011 15:58:41 +0100 HoP jpetr...@gmail.com wrote: Hi, let me ask you some details of your interesting idea (how to achieve the same functionality as with vtunerc driver): [...] The driver, as proposed, is not really a driver, as it doesn't support any hardware. The

Re: [RFC] vtunerc: virtual DVB device - is it ok to NACK driver because of worrying about possible misusage?

FWIW, the virtual DVB device we're talking about doesn't have any networking capabilities by itself. It only allows to create virtual DVB adapters and to relay DVB API ioctls to userspace in a transport-agnostic way. Which you can do working from CUSE already, as has been pointed out or with

Re: [RFC] vtunerc: virtual DVB device - is it ok to NACK driver because of worrying about possible misusage?

On Sat, 3 Dec 2011 09:21:23 -0800 VDR User user@gmail.com wrote: On Sat, Dec 3, 2011 at 8:13 AM, Andreas Oberritter o...@linuxtv.org wrote: You could certainly build a library to reach a different goal. The goal of vtuner is to access remote tuners with any existing program

Re: [RFC] vtunerc: virtual DVB device - is it ok to NACK driver because of worrying about possible misusage?

While I agree with your more broad view of the issue, I specifically talked about VDR. AFAIK Klaus has no intention of adding true server/client support to VDR, so for VDR users, this sounds like it could be a working solution without the strict limitations of streamdev. So fix Klaus rather

Re: [RFC] vtunerc: virtual DVB device - is it ok to NACK driver because of worrying about possible misusage?

You know - I'm a bit confused. Somebody are pointing on double data copying (userspace networked daemon - kernel - application) issue and another one warn me to not start network connection from the kernel. But if it works for NFS or CIFS then it should not be so weaky, isn't it? And then

Re: [RFC] vtunerc: virtual DVB device - is it ok to NACK driver because of worrying about possible misusage?

The USB case is quite different because your latency is very tightly bounded, your dead device state is rigidly defined, and your loss of device is accurately and immediately signalled. Quite different. Alan -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of

Re: [RFC] vtunerc: virtual DVB device - is it ok to NACK driver because of worrying about possible misusage?

How can usbip work if networking and usb are so different and what's so different between vtunerc and usbip, that made it possible to put usbip into drivers/staging? Where usbip seems to have remained for a long time without actually being made useful or correct enough to progress. Meanwhile

Re: [Linaro-mm-sig] [RFC v2 1/2] dma-buf: Introduce dma buffer sharing mechanism

I still don't think that's possible. Please explain how you expect to change the semantics of the streaming mapping API to allow multiple mappers without having explicit serialization points that are visible to all users. For simplicity, let's assume a cache coherent system I would agree.

Re: serial device name for smart card reader that is integrated to Anysee DVB USB device

Anyhow, I would like now ask how to proceed. Should I export four new functions as replacement of those leaving old functionality as currently. Or should I change existing ones like adding new pointer for struct usb_serial and use it instead of struct usb_interface when not NULL. I think I

[PATCH] cx88: Fix reset delays

From: Alan Cox a...@linux.intel.com This was reported in March 2011 by Mirek Slugen, and a simple fix posted at the time then never got fixed and applied. The bug is still present. Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=37703 Signed-off-by: Alan Cox a...@linux.intel.com

[PATCH] tlg2300: fix missing check for audio creation

From: Alan Cox a...@linux.intel.com If we fail to set up the capture device we go through negative indexes and badness happens. Add the missing test. Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=44551 Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/media/usb/tlg2300/pd

[PATCH] v4l2: spi modalias is an array

From: Alan Cox a...@linux.intel.com We want to check the contents not the array itself versus NULL Signed-off-by: Alan Cox a...@linux.intel.com --- drivers/media/v4l2-core/v4l2-common.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-common.c

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

On Wed, 3 Oct 2012 23:18:06 +0200 Kay Sievers k...@vrfy.org wrote: On Wed, Oct 3, 2012 at 11:05 PM, Greg KH gre...@linuxfoundation.org wrote: As for the firmware path, maybe we should change that to be modified by userspace (much like /sbin/hotplug was) in a proc file so that distros can

Re: udev breakages -

I don't know how to handle the /dev/ptmx issue properly from within devtmpfs, does anyone? Proposals are always welcome, the last time this came up a week or so ago, I don't recall seeing any proposals, just a general complaint. Is it really a problem - devtmpfs is optional. It's a problem

Re: [PATCH] dma-buf: Use EXPORT_SYMBOL

On Wed, 10 Oct 2012 08:56:32 -0700 Robert Morell rmor...@nvidia.com wrote: EXPORT_SYMBOL_GPL is intended to be used for an internal implementation issue, and not really an interface. The dma-buf infrastructure is explicitly intended as an interface between modules/drivers, so it should use

Re: [PATCH] dma-buf: Use EXPORT_SYMBOL

As long as dmabuf uses EXPORT_SYMBOL_GPL that is definitely correct. Does your statement also hold if dmabuf would use EXPORT_SYMBOL? (Just asking) Yes. The GPL talks about derivative works (as does copyright law). Alan -- To unsubscribe from this list: send the line unsubscribe linux-media in

Re: [PATCH] dma-buf: Use EXPORT_SYMBOL

The whole purpose of this API is to let DRM and V4L drivers share buffers for zero-copy pipelines. Unfortunately it is a fact that several popular DRM drivers are closed source. So we have a choice between keeping the export symbols GPL and forcing those closed-source drivers to make their

Re: [PATCH] dma-buf: Use EXPORT_SYMBOL

So, developers implicitly or explicitly copied in this thread that might be considering the usage of dmabuf on proprietary drivers should consider this email as a formal notification of my viewpoint: e. g. that I consider any attempt of using DMABUF or media core/drivers together with

Re: [Linaro-mm-sig] [PATCH] dma-buf: Use EXPORT_SYMBOL

Then they can accept the risk of ignoring EXPORT_SYMBOL_GPL and calling into it anyway can't they. Your argument makes no rational sense of any kind. But then why object to the change, your objection makes sense, naking the patch makes none, if you believe in your objection. [l/k added

Re: [PATCH] dma-buf: Use EXPORT_SYMBOL

I believe that the developers and maintainers of dma-buf have provided the needed signoff, both in person and in this thread. If there are any objections from that group, I'm happy to discuss any changes necessary to get this merged. You need the permission of the owners of all the dependant

Re: [Linaro-mm-sig] [PATCH] dma-buf: Use EXPORT_SYMBOL

Please go and discuss estoppel, wilful infringement and re-licensing with your corporate attorneys. If you want to relicense components of the code then please take the matter up with the corporate attorneys of the rights holders concerned. Alan please stick with the facts. This isn't a

Re: [Linaro-mm-sig] [PATCH] dma-buf: Use EXPORT_SYMBOL

On Wed, 17 Oct 2012 20:22:04 +1000 Dave Airlie airl...@gmail.com wrote: On Wed, Oct 17, 2012 at 8:25 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: Please go and discuss estoppel, wilful infringement and re-licensing with your corporate attorneys. If you want to relicense components

Re: [PATCH 34/52] devices.txt: add video4linux device for Software Defined Radio

configuration option for old fixed style. Add note to mention that configuration option too. Cc: Hans Verkuil hverk...@xs4all.nl Signed-off-by: Antti Palosaari cr...@iki.fi Acked-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Alan Cox a...@linux.intel.com -- To unsubscribe from this list

Re: [PATCH] staging/atomisp: fix platform_no_drv_owner.cocci warnings

ner field if calls are used which set it automatically > > > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > > > CC: Alan Cox <a...@linux.intel.com> > > Signed-off-by: Fengguang Wu <fengguang...@intel.com> > > > May I as

Re: [PATCH] staging: media: atomisp: remove ifdef around HMM_BO_ION

> > 2 -- > >  1 file changed, 2 deletions(-) > > Ugh, Alan, what's going on here, I thought you fixed this? I sent you a patch that removed the arrays entirely and turned it into a single string as well as removing the define. Not quite sure what happened but I've resynched to -next and I'll

[PATCH 2/5] atomisp: Remove another dead define

HAS_TNR3 is never defined so we can remove it. Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../media/atomisp/pci/atomisp2/css2400/sh_css_sp.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c b/drivers/staging

[PATCH 4/5] drivers/staging/media: atomisp: Removing redundant information from dev_err

From: Pushkar Jambhlekar <pushkar@gmail.com> Removing hardcoded function name as code is already using __func__ Signed-off-by: Pushkar Jambhlekar <pushkar@gmail.com> Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../media/atomisp/pci/atomisp2/hmm/hmm_bo.c

[PATCH 3/5] atomisp: kill another define

We don't need an ifdef for the sake of 8-12 bytes. Avoid the ifdef added by fde469701c7efabebf885e785edf367bfb1a8f3f. Instead turn it into a single const string array at a fixed location thereby saving even more memory. Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../staging/media/a

[PATCH 5/5] Staging: atomisp - octal permissions, style fix

From: Derek Robson <robso...@gmail.com> Changed permissions to octal style Found using checkpatch Signed-off-by: Derek Robson <robso...@gmail.com> Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../media/atomisp/pci/atomisp2/atomisp_drvfs.c |9 +++-- .../sta

[PATCH 1/5] atomisp: remove dead code

HAS_SEC_ISP is never defined so we can scrub all the code that is within the defines for it. Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../atomisp2/css2400/runtime/spctrl/src/spctrl.c |5 - .../media/atomisp/pci/atomisp2/css2400/sh_css.c| 110 .../a

Re: [PATCH 1/2] staging: atomisp: simplify the if condition in atomisp_freq_scaling()

On Thu, 2017-03-30 at 15:24 +0900, Daeseok Youn wrote: > The condition line in if-statement is needed to be shorthen to > improve readability. > > Signed-off-by: Daeseok Youn > --- How about a define for ATOMISP_IS_CHT(isp) instead - as we will need these tests in other

Re: [PATCH] staging: media: atomisp: fix build error

On Thu, 2017-03-23 at 21:12 +0800, Geliang Tang wrote: > Fix the following build error: > >   CC  drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.o > drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: >  error: excess elements in array initializer [-Werror] >   "i", /* ion */ >  

Re: [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs.

On Wed, 2017-03-29 at 09:57 -0700, Daniel Cashman wrote: > From: Dan Cashman > > Signed-off-by: Dan Cashman As the TODO asks - please no whitespace cleanups yet. They make it harder to keep other cleanups that fix (or mostly remove) code

[PATCH 24/24] staging: atomisp: simplify if statement in atomisp_get_sensor_fps()

ed-off-by: Daeseok Youn <daeseok.y...@gmail.com> Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../media/atomisp/pci/atomisp2/atomisp_cmd.c | 22 +--- 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp

[PATCH 01/24] atomisp: remove the iefd2 kernel

While this is included and the headers pulled in nothing actually uses this functionality in the driver, so remove it. Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../staging/media/atomisp/pci/atomisp2/Makefile|3 .../ia_css_isp_params.c

[PATCH 23/24] atomisp: remove a sysfs error message that can be used to log spam

Instead of logging this just report ERANGE as an error, which will give something close to the right user space report. The others of these were already removed by Dan Carpenter's patch. Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../media/atomisp/pci/atomisp2/atomisp_d

[PATCH 05/24] atomisp: ia_css_bh_hmem_encode is a no-op so remove it

This is a do nothing function so we can replace it with nothing and eliminate it entirely. Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../ia_css_isp_params.c|6 -- .../ia_css_isp_params.c

[PATCH 22/24] staging: atomisp: remove redudant condition in if-statement

From: Daeseok Youn <daeseok.y...@gmail.com> The V4L2_FIELD_ANY is zero, so the (!field) is same meaning with (field == V4L2_FIELD_ANY) in if-statement. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../media/at

[PATCH 13/24] staging: media: atomisp: add missing dependencies in Kconfig

to use efivar_entry_get: drivers/built-in.o: In function `gmin_get_config_var': (.text+0xe062b): undefined reference to `efivar_entry_get' Signed-off-by: Jérémy Lefaure <jeremy.lefa...@lse.epita.fr> Signed-off-by: Alan Cox <a...@linux.intel.com> --- drivers/staging/media/atomisp/Kconfig

[PATCH 16/24] stating/atomisp: fix -Wold-style-definition warning

rams.c:3728:6: error: old-style function definition [-Werror=old-style-definition] This adds a 'void' keywork to silence the warning. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: Alan Cox

[PATCH 21/24] staging: atomisp: remove else statement after return

From: Daeseok Youn <daeseok.y...@gmail.com> It doesn't need to have else statement after return. Signed-off-by: Daeseok Youn <daeseok.y...@gmail.com> Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../media/atomisp/pci/atomisp2/atomisp_cmd.c |6 +++--- 1 file cha

Re: [bug report] staging/atomisp: Add support for the Intel IPU v2

>    674   >    675  /* To avoid owerflows when calling the efivar API */ >    676  if (*out_len > ULONG_MAX) > > This is impossible.  Was UINT_MAX intended? I am really not sure. The only case I can imagine is 32bit EFI on a 64bit system,

[PATCH 17/24] staging/atomisp: remove sh_css_lace_stat code

..@arndb.de> Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../staging/media/atomisp/pci/atomisp2/Makefile|1 - .../media/atomisp/pci/atomisp2/css2400/ia_css.h|1 - .../atomisp/pci/atomisp2/css2400/ia_css_buffer.h |1 - .../pci/atomisp2/css2400/ia_c

[PATCH 09/24] atomisp: remove another pair of 2400/2401 differences

The first of these checks the PCI identifier in order to decide what to do so needs no ifdef. The other is simply a variation on what is dumped for debug - so favour dumping the most. Signed-off-by Alan Cox <a...@linux.intel.com> --- .../media/atomisp/pci/atomisp2/atomisp_cmd.c

[PATCH 14/24] staging/atomisp: include linux/io.h where needed

/clock/vlv2_plat_clock.c:209:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration] This includes the required header file. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Arnd Bergmann <a...@arndb.de> S

[PATCH 20/24] staging/atomisp: add ACPI dependency

n <a...@arndb.de> Signed-off-by: Alan Cox <a...@linux.intel.com> --- drivers/staging/media/atomisp/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig index 8b172ed..8eb13c3 100644

[PATCH 03/24] atomisp: remove the unused debug wrapping from the mmgr layer

We don't need this layer of indirection and the debugging information is not used. With this removed we can then go on to try and remove the abstraction layer entirely. Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../memory_access/memory_access.h

[PATCH 02/24] atomisp: remove aa kernel wrappers

The aa kernel is used but it consists of nothing more than a set of wrappers for a memset and an assignment. Replace these at the calling points with the memset and assignment. Keep the structures for now - those should disappear as the next layer up gets unwrapped. Signed-off-by: Alan Cox

[PATCH 04/24] atomisp: remove another layer of allocator indirection

of code so remove this second layer of wrappers and call the hrt methods directly. In time we can remove this layer of indirection as well. Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../atomisp/pci/atomisp2/atomisp_compat_css20.c| 66 .../ia_css_isp_st

[PATCH 10/24] Staging: atomisp: fix locking in alloc_user_pages()

; Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../media/atomisp/pci/atomisp2/hmm/hmm_bo.c|1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c index fd3bd5

[PATCH 18/24] staging/atomisp: add VIDEO_V4L2_SUBDEV_API dependency

tomisp: Add support for the Intel IPU v2") Signed-off-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: Alan Cox <a...@linux.intel.com> --- drivers/staging/media/atomisp/pci/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/at

[PATCH 19/24] staging/atomisp: add PCI dependency

essors should always return something when PCI is enabled. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: Alan Cox <a...@linux.intel.com> --- drivers/staging/media/atomisp/Kconfig

[PATCH 15/24] staging/atomisp: fix empty-body warning

364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: Alan Cox <a...@linux.intel.com> --- drivers/staging/media/atomisp/i2c/ov2680.c | 37 ++-- 1 file changed, 19 insertions(+),

[PATCH 11/24] Staging: atomisp: fix an uninitialized variable bug

gned-off-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../media/atomisp/pci/atomisp2/atomisp_cmd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c b/driv

[PATCH 07/24] ov5693: remove unused function

It's commented out in the tree with a note saying to remove it. So let's remove it. Signed-off-by: Alan Cox <a...@linux.intel.com> --- drivers/staging/media/atomisp/i2c/ov5693/ov5693.c | 23 - 1 file changed, 23 deletions(-) diff --git a/drivers/staging/media/atomi

[PATCH 08/24] atomisp/imx: Fix locking bug on error path

This was reported by Dan Carpenter. When we error with an IMX 227 we don't release the lock and the sensor would then hang. Signed-off-by: Alan Cox <a...@linux.intel.com> --- drivers/staging/media/atomisp/i2c/imx/imx.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH 12/24] staging: media: atomisp: select REGMAP_I2C needed by ap1302.c

From: Jérémy Lefaure <jeremy.lefa...@lse.epita.fr> REGMAP_I2C should be enabled to build the driver ap1302 because it uses regmap functions. Signed-off-by: Jérémy Lefaure <jeremy.lefa...@lse.epita.fr> Signed-off-by: Alan Cox <a...@linux.intel.com> --- drivers/staging/media/a

[PATCH 06/24] atomisp: kill another define

We don't need an ifdef for the sake of 8-12 bytes. This undoes the ifdef added by fde469701c7efabebf885e785edf367bfb1a8f3f. Instead turn it into a single const string array at a fixed location thereby saving even more memory. Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../staging

[PATCH 10/14] atomisp: remove contiguous handling

Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../pci/atomisp2/css2400/ia_css_memory_access.c| 31 ++-- .../atomisp/pci/atomisp2/hrt/hive_isp_css_mm_hrt.c | 11 --- .../atomisp/pci/atomisp2/hrt/hive_isp_css_mm_hrt.h |3 -- .../media/atomisp/pci/atomis

[PATCH 08/14] atomisp: remove indirection from sh_css_malloc

We have one hard coded set of behaviour so unpick the indirection and function pointers. This isn't the whole story. A lot of the callers are known sizes and use cases so we can switch them directly to kmalloc later on. Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../atomisp/pci/at

[PATCH 12/14] atomisp: remove fixedbds kernel code

This is a whole pile of code that wraps a single assignment. Remove it and put the assignment in the caller. Once we have the kernels sorted we should revisit these and remove all the pointless 1 item structs that go with it. Signed-off-by: Alan Cox <a...@linux.intel.

[PATCH 13/14] atomisp: remove xnr3_0_5 and xnr3_0_11

These are not used in the driver so can go away. Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../staging/media/atomisp/pci/atomisp2/Makefile|4 - .../kernels/xnr/xnr3_0_11/ia_css_xnr3_0_11.host.c | 155 .../kernels/xnr/xnr3_0_11/ia_css_xnr3_0_11.

[PATCH 09/14] atomisp: remove sh_css_malloc indirections where we can

Where we know the buffer size is reasonably constrained we can just use kmalloc, and where it will be large vmalloc. This still leaves a pile in the middle. Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../media/atomisp/pci/atomisp2/css2400/sh_css.c

[PATCH 06/14] atomisp: remove most of the uses of atomisp_kernel_malloc

They can be replaced by kmalloc. There are a few that do need to pick kmalloc or vmalloc. Those we leave for the moment. Signed-off-by: Alan Cox <a...@linux.intel.com> --- .../atomisp/pci/atomisp2/atomisp_compat_css20.c|4 -- .../media/atomisp/pci/atomisp2/hmm/hmm_bo.c

  1   2   >