equest API since we need to skip such controls.
TODO: check drivers/staging/media/imx/imx-media-fim.c change.
Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/dvb-frontends/rtl2832_sdr.c| 5 +--
From: Hans Verkuil <hans.verk...@cisco.com>
The next patch needs the reference to a control instead of the
control itself, so change struct v4l2_ctrl_helper accordingly.
Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>
Signed-off-by: Alexandre Courbot <acour...@chromium.or
]
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
Documentation/media/uapi/mediactl/media-funcs.rst | 1 +
.../media/uapi/mediactl/media-ioc-request-cmd.rst | 141 +
2 files changed, 142 insertions(+)
create mode 100644 Documentation/media/uapi/mediactl/media-i
be used.
Alexandre Courbot (9):
media: add request API core and UAPI
media: videobuf2: add support for requests
media: vb2: add support for requests in QBUF ioctl
v4l2: add request API support
videodev2.h: add request_fd field to v4l2_ext_controls
v4l2-ctrls: support requests
On Tue, Jan 30, 2018 at 1:04 AM, Hans Verkuil <hverk...@xs4all.nl> wrote:
> On 01/26/2018 07:02 AM, Alexandre Courbot wrote:
>> From: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
>>
>> The media request API is made of a new ioctl to implemen
Hi Hans,
On Mon, Jan 29, 2018 at 8:21 PM, Hans Verkuil <hverk...@xs4all.nl> wrote:
> On 01/26/2018 07:02 AM, Alexandre Courbot wrote:
>> Howdy. Here is your bi-weekly request API redesign! ;)
>>
>> Again, this is a simple version that only implements the flow of re
On Tue, Jan 30, 2018 at 1:03 AM, Hans Verkuil <hverk...@xs4all.nl> wrote:
> On 01/26/2018 07:02 AM, Alexandre Courbot wrote:
>> Document how the request API can be used along with the existing V4L2
>> interface.
>>
>> Signed-off-by: Alexand
> I also see that variable size IOCTL argument support is no longer included.
Do we need this for the request API?
>
> On Fri, Dec 15, 2017 at 04:56:17PM +0900, Alexandre Courbot wrote:
>> The request API provides a way to group buffers and device parameters
>> into uni
he earlier design documents mentioned this possibility.
Alexandre Courbot (6):
media: add request API core and UAPI
media: videobuf2: add support for requests
media: vb2: add support for requests in QBUF ioctl
v4l2: document the request API interface
media: vim2m: add media device
media:
]
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
Documentation/media/uapi/mediactl/media-funcs.rst | 1 +
.../media/uapi/mediactl/media-ioc-request-cmd.rst | 140 +
2 files changed, 141 insertions(+)
create mode 100644 Documentation/media/uapi/mediactl/media-i
From: Hans Verkuil <hans.verk...@cisco.com>
When queuing buffers allow for passing the request ID that
should be associated with this buffer.
Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>
[acour...@chromium.org: make request ID 32-bit]
Signed-off-by: Alexandre Co
Make vb2 aware of requests. Drivers can specify whether a given queue
can accept requests or not. Queues that accept requests will block on a
buffer that is part of a request until that request is submitted.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/v4l
Request API requires a media node. Add one to the vim2m driver so we can
use requests with it.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/platform/vim2m.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/media/platform/v
Document how the request API can be used along with the existing V4L2
interface.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
Documentation/media/uapi/v4l/buffer.rst | 10 +-
Documentation/media/uapi/v4l/common.rst | 1 +
Documentation/media/uapi/v4l/request-a
Set the necessary ops for supporting requests in vim2m.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/platform/vim2m.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/v
Support the request argument of the QBUF ioctl.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/v4l2-core/v4l2-ioctl.c | 79 +++-
1 file changed, 78 insertions(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l2-ioct
.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/Makefile | 3 +-
drivers/media/media-device.c | 7 +
drivers/media/media-request-mgr.c| 107
drivers/media/media-request.c
On Tue, Jan 16, 2018 at 7:37 PM, Hans Verkuil <hverk...@xs4all.nl> wrote:
> On 01/16/2018 10:39 AM, Alexandre Courbot wrote:
>> On Mon, Jan 15, 2018 at 6:07 PM, Hans Verkuil <hverk...@xs4all.nl> wrote:
>>> On 01/15/2018 09:24 AM, Alexandre Courbot wrote:
>>>
On Mon, Jan 15, 2018 at 6:19 PM, Hans Verkuil <hverk...@xs4all.nl> wrote:
> On 01/15/2018 09:24 AM, Alexandre Courbot wrote:
>> On Fri, Jan 12, 2018 at 8:37 PM, Hans Verkuil <hverk...@xs4all.nl> wrote:
>>> On 12/15/17 08:56, Alexandre Courbot wrote:
>>>>
On Mon, Jan 15, 2018 at 6:07 PM, Hans Verkuil <hverk...@xs4all.nl> wrote:
> On 01/15/2018 09:24 AM, Alexandre Courbot wrote:
>> On Fri, Jan 12, 2018 at 7:49 PM, Hans Verkuil <hverk...@xs4all.nl> wrote:
>>> On 12/15/17 08:56, Alexandre Courbot wrote:
>>>&g
On Mon, Jan 15, 2018 at 9:01 PM, Gustavo Padovan <gust...@padovan.org> wrote:
> 2018-01-15 Alexandre Courbot <acour...@chromium.org>:
>
>> On Thu, Jan 11, 2018 at 1:07 AM, Gustavo Padovan <gust...@padovan.org> wrote:
>> > From: Gustavo Padovan <gustavo
On Fri, Jan 12, 2018 at 7:49 PM, Hans Verkuil <hverk...@xs4all.nl> wrote:
> On 12/15/17 08:56, Alexandre Courbot wrote:
>> Add throttling support for buffers when requests are in use on a given
>> queue. Buffers associated to a request are kept into the vb2 queue until
&
On Fri, Jan 12, 2018 at 7:22 PM, Hans Verkuil <hverk...@xs4all.nl> wrote:
> On 12/15/17 08:56, Alexandre Courbot wrote:
>> From: Hans Verkuil <hans.verk...@cisco.com>
>>
>> When queuing buffers allow for passing the request ID that
>> should be associ
Hi Hans,
On Fri, Jan 12, 2018 at 8:45 PM, Hans Verkuil <hverk...@xs4all.nl> wrote:
> Hi Alexandre,
>
> On 12/15/17 08:56, Alexandre Courbot wrote:
>> Here is a new attempt at the request API, following the UAPI we agreed on in
>> Prague. Hopefully this can be used a
On Fri, Jan 12, 2018 at 8:37 PM, Hans Verkuil <hverk...@xs4all.nl> wrote:
> On 12/15/17 08:56, Alexandre Courbot wrote:
>> Support the request argument of the QBUF ioctl.
>>
>> Signed-off-by: Alexandre Courbot <acour...@chromium.org>
>> ---
>&g
On Thu, Jan 11, 2018 at 1:07 AM, Gustavo Padovan wrote:
> /*
> * vb2_start_streaming() - Attempt to start streaming.
> * @q: videobuf2 queue
> @@ -1489,18 +1562,16 @@ int vb2_core_qbuf(struct vb2_queue *q, unsigned int
> index, void *pb,
> if
On Thu, Jan 11, 2018 at 1:07 AM, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> Explicit synchronization benefits a lot from ordered queues, they fit
> better in a pipeline with DRM for example so create a opt-in way for
> drivers notify
On Tue, Dec 19, 2017 at 5:53 AM, Gustavo Padovan <gust...@padovan.org> wrote:
> Hi Alex,
>
> 2017-12-15 Alexandre Courbot <acour...@chromium.org>:
>
>> Set the necessary ops for supporting requests in vim2m.
>>
>> Signed-off-by: Alexandre Courbot <ac
On Sat, Dec 16, 2017 at 6:04 AM, Nicolas Dufresne <nico...@ndufresne.ca> wrote:
> Le vendredi 15 décembre 2017 à 16:56 +0900, Alexandre Courbot a écrit :
>> Here is a new attempt at the request API, following the UAPI we agreed on in
>> Prague. Hopefully this can be used
On Sat, Dec 16, 2017 at 6:02 AM, Nicolas Dufresne <nico...@ndufresne.ca> wrote:
> Le vendredi 15 décembre 2017 à 16:56 +0900, Alexandre Courbot a écrit :
>> Here is a new attempt at the request API, following the UAPI we agreed on in
>> Prague. Hopefully this can be used
to be sufficient most of the time though).
A very simple test program exercising this API is available here (don't forget
to adapt the /dev/media0 hardcoding):
https://gist.github.com/Gnurou/dbc3776ed97ea7d4ce6041ea15eb0438
Looking forward to your feedback and comments!
Alexandre Courbot (8):
media: add
Add a generic request queue that supports most use-case and should be
usable as-is by drivers without special hardware features.
The generic queue stores the requests into a FIFO list and executes them
sequentially.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers
From: Hans Verkuil <hans.verk...@cisco.com>
When queuing buffers allow for passing the request ID that
should be associated with this buffer.
Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>
[acour...@chromium.org: make request ID 32-bit]
Signed-off-by: Alexandre Co
.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/Makefile | 3 +-
drivers/media/media-device.c | 6 +
drivers/media/media-request.c| 390 +++
drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
include
Request API requires a media node. Add one to the vim2m driver so we can
use requests with it.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/platform/vim2m.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/media/platform/v
Support the request argument of the QBUF ioctl.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/v4l2-core/v4l2-ioctl.c | 93 +++-
1 file changed, 92 insertions(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l2-ioct
buffers.
Also add support for the request parameter when handling the QBUF ioctl.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/v4l2-core/videobuf2-core.c | 59
drivers/media/v4l2-core/videobuf2-v4l2.c | 29 +++-
i
Support request API in the mem2mem framework. Drivers that specify ops
for the queue and entities can support requests seamlessly.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/v4l2-core/v4l2-mem2mem.c | 34 ++
include/medi
Set the necessary ops for supporting requests in vim2m.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/platform/vim2m.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c
Add skeleton ops for generic entities. The intent is to provide a
generic mechanism to apply request parameters to entities using regular
media/v4l2 functions.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/Makefile | 3 +-
drivers/media
On Fri, Nov 17, 2017 at 10:01 PM, Gustavo Padovan <gust...@padovan.org> wrote:
> 2017-11-17 Alexandre Courbot <acour...@chromium.org>:
>
>> Hi Gustavo,
>>
>> I am coming a bit late in this series' review, so apologies if some of my
>> comments have
On Thursday, November 16, 2017 2:10:56 AM JST, Gustavo Padovan wrote:
From: Gustavo Padovan
If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create
an out_fence and send its fd to userspace on the fence_fd field as a
return arg for the QBUF call.
On Friday, November 17, 2017 4:19:00 PM JST, Alexandre Courbot wrote:
On Thursday, November 16, 2017 2:10:55 AM JST, Gustavo Padovan wrote:
From: Gustavo Padovan <gustavo.pado...@collabora.com>
Add vb2_setup_out_fence() and the needed members to struct vb2_buffer.
v3:
- Do no
On Thursday, November 16, 2017 2:10:55 AM JST, Gustavo Padovan wrote:
From: Gustavo Padovan
Add vb2_setup_out_fence() and the needed members to struct vb2_buffer.
v3:
- Do not hold yet another ref to the out_fence (Brian Starkey)
v2: - change it to
On Friday, November 17, 2017 4:02:56 PM JST, Alexandre Courbot wrote:
On Thursday, November 16, 2017 2:10:54 AM JST, Gustavo Padovan wrote:
From: Javier Martinez Canillas <jav...@osg.samsung.com>
Add a videobuf2-fence.h header file that contains different helpers
for DMA buffer s
On Thursday, November 16, 2017 2:10:54 AM JST, Gustavo Padovan wrote:
From: Javier Martinez Canillas
Add a videobuf2-fence.h header file that contains different helpers
for DMA buffer sharing explicit fence support in videobuf2.
v2: - use fence context provided by
Hi Gustavo,
I am coming a bit late in this series' review, so apologies if some of my
comments have already have been discussed in an earlier revision.
On Thursday, November 16, 2017 2:10:53 AM JST, Gustavo Padovan wrote:
From: Gustavo Padovan
Receive in-fence
On Thursday, November 16, 2017 2:10:49 AM JST, Gustavo Padovan wrote:
From: Gustavo Padovan
We use ordered_in_driver property to optimize for the case where
the driver can deliver the buffers in an ordered fashion. When it
is ordered we can use the same fence
On Thu, Nov 16, 2017 at 6:13 PM, Hans Verkuil <hverk...@xs4all.nl> wrote:
> On 16/11/17 09:48, Alexandre Courbot wrote:
>> Hi Hans,
>>
>> On Wed, Nov 15, 2017 at 7:12 PM, Hans Verkuil <hverk...@xs4all.nl> wrote:
>>> Hi Alexandre,
>>>
>>&
Hi Hans,
On Wed, Nov 15, 2017 at 7:12 PM, Hans Verkuil <hverk...@xs4all.nl> wrote:
> Hi Alexandre,
>
> On 15/11/17 10:38, Alexandre Courbot wrote:
>> Hi Hans!
>>
>> Thanks for the patchset! It looks quite good at first sight, a few comments
>> and
>
Hi Hans!
Thanks for the patchset! It looks quite good at first sight, a few comments
and
questions follow though.
On Monday, November 13, 2017 11:34:02 PM JST, Hans Verkuil wrote:
From: Hans Verkuil
Hi Alexandre,
This is a first implementation of the request API in
Hi Sakari, thanks for the feedback!
On Thu, Oct 19, 2017 at 11:43 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote:
> Hi Alexandre,
>
> On Thu, Sep 28, 2017 at 06:50:18PM +0900, Alexandre Courbot wrote:
>> Hi everyone,
>>
>> Here is a new attempt at the "req
h
> the
> media device instead of through the v4l-subdev devices.
>
> Regards,
>
> Hans
>
> On 09/28/2017 11:50 AM, Alexandre Courbot wrote:
>> Hi everyone,
>>
>> Here is a new attempt at the "request" (which I propose to rename "jobs&qu
Hi Hans,
On Mon, Oct 16, 2017 at 7:01 PM, Hans Verkuil wrote:
>> +static long v4l2_jobqueue_device_do_ioctl(struct file *filp, unsigned int
>> cmd,
>> + void *arg)
>> +{
>> + switch (cmd) {
>> + case VIDIOC_JOBQUEUE_INIT:
-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/v4l2-core/videobuf2-core.c | 33
include/media/videobuf2-core.h | 16
2 files changed, 45 insertions(+), 4 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-cor
Add core support code for jobs API. This manages the life cycle of jobs
and creation of a jobs queue, as well as the interface for job states.
It also exposes the user-space jobs API.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/v4l2-core/Makefile
are supported at the
moment.
- No support for try_ctrl yet.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/v4l2-core/Makefile | 3 +-
drivers/media/v4l2-core/v4l2-job-generic.c | 394 +
include/media/v4l2-job-generic.h
controls in jobs.
Doing this properly will probably require more changes to the control
framework, but the current form is enough to demonstrate the general
ideas.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/v4l2-core/v4l2-ctrls.
Add support for jobs in vim2m, using the generic state handler.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/platform/vim2m.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/media/platform/vim2m.c b/drivers/media/pl
Still a work-in-progress, but hopefully conveys the general idea.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
Documentation/media/intro.rst | 2 +
Documentation/media/media_uapi.rst | 1 +
Documentation/media/uapi/jobs/jobs-a
Add a v4l2_mem_ctx_job_init() function that drivers using m2m can call
at init time in order to set the state handler.
Also make sure to call v4l2_jobqueue_job_finish() when the jobs API is
used and all buffers for the current job have been processed.
Signed-off-by: Alexandre Courbot <ac
Add a function that checks whether a given open file is a v4l2 device
instance. This will be useful for job queue creation as we are passed a
set of FDs and we need to make this check.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/v4l2-core/v4l2-dev
Add support for jobs in the vivid capture device, using the generic
state handler.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/platform/vivid/vivid-core.c| 16
drivers/media/platform/vivid/vivid-core.h| 2 ++
drivers/media/pl
derstood immediately. In particular I apologize for not
reusing any of the previous attempts - I was just more comfortable laying down
my ideas from scratch.
If this proposal is not dismissed as complete garbage I will also be happy to
discuss it in-person at the mini-summit in Prague. :)
Cheers,
Alex
Hi!
On Fri, Sep 1, 2017 at 6:46 PM, Hans Verkuil wrote:
> Hi all,
>
> We are organizing a media mini-summit on Friday October 27 in Prague,
> co-located
> with the ELCE conference:
>
> http://events.linuxfoundation.org/events/embedded-linux-conference-europe
>
> This is a
On Tue, Jul 4, 2017 at 2:57 PM, Tomasz Figa wrote:
> Hi Gustavo,
>
> On Tue, Jun 27, 2017 at 12:39 AM, Gustavo Padovan wrote:
>> 2017-06-18 kbuild test robot :
>>
>>> Hi Gustavo,
>>>
>>> [auto build test ERROR on linuxtv-media/master]
>>>
On Fri, Jun 9, 2017 at 2:51 AM, Mauro Carvalho Chehab
<mche...@s-opensource.com> wrote:
> Em Wed, 7 Jun 2017 18:33:02 +0900
> Alexandre Courbot <acour...@chromium.org> escreveu:
>
>> Fix what seems to be a few typos induced by copy/paste.
>>
>>
or
> further testing.
>
> We are interested in merging the API patches as well as these drivers upstream
> (they were posted on this list two years ago), however we've been blocked by
> the
> progress of request API, which is required for this. Alexandre Courbot
> is currently
>
Fix what seems to be a few typos induced by copy/paste.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
Documentation/media/uapi/mediactl/media-ioc-g-topology.rst | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/media/uapi/mediactl/med
On Tue, May 30, 2017 at 5:30 PM, Sylwester Nawrocki
wrote:
> Hi,
>
> On 05/29/2017 09:08 PM, Jacek Anaszewski wrote:
>>
>> This patch seems to have lost somehow. Could you help merging it?
>
>
> It's not lost, it has been on my todo queue. I have applied it now.
Awesome,
tch title should specify the subsystem of your patch. Something
like "[media] vb2: core: Lower the log level of debug outputs"
Otherwise,
Acked-by: Alexandre Courbot <acour...@chromium.org>
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 10 +-
> 1 file change
Hi everyone,
On Thu, Apr 27, 2017 at 4:35 AM, Jacek Anaszewski
<jacek.anaszew...@gmail.com> wrote:
> On 04/26/2017 04:54 AM, Alexandre Courbot wrote:
>> On Wed, Apr 26, 2017 at 4:15 AM, Jacek Anaszewski
>> <jacek.anaszew...@gmail.com> wrote:
>>> Hi Ale
On Wed, Apr 26, 2017 at 4:15 AM, Jacek Anaszewski
<jacek.anaszew...@gmail.com> wrote:
> Hi Alexandre,
>
> Thanks for the patch.
>
> On 04/25/2017 08:19 AM, Alexandre Courbot wrote:
>> v4l2_m2m_job_finish(), which is called from the interrupt handler with
>> slock
v4l2_m2m_job_finish().
This is safe to do as the state of the hardware cannot change before
v4l2_m2m_job_finish() is called anyway.
Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
drivers/media/platform/s5p-jpeg/jpeg-core.c | 12 +---
1 file changed, 9 insertions(+), 3 del
101 - 174 of 174 matches
Mail list logo