Re: [PATCH 08/23] cx25840: Replace memcpy with struct assignment

2012-10-23 Thread Andy Walls
;(from), E); > +to = from; > // > This patch is fine. Signed-off-by: Andy Walls > Signed-off-by: Peter Senna Tschudin > Signed-off-by: Ezequiel Garcia > --- > drivers/media/i2c/cx25840/cx25840-ir.c |6 ++ > 1 files changed, 2 insertions(+), 4 deletions(-)

Re: [PATCH 18/23] cx18: Replace memcpy with struct assignment

2012-10-23 Thread Andy Walls
ilation only. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > identifier struct_name; > struct struct_name to; > struct struct_name from; > expression E; > @@ > -memcpy(&(to), &

Re: [PATCH 17/23] cx23885: Replace memcpy with struct assignment

2012-10-23 Thread Andy Walls
;(from), E); > +to = from; > // > > Signed-off-by: Peter Senna Tschudin > Signed-off-by: Ezequiel Garcia This patch looks OK to me. You forgot to CC: Steven Toth and/or Devin Heitmueller (I can't remember who did the VBI work.) For cx23885-video.c: Reviewed-by: Andy Walls

Re: [PATCH 15/23] ivtv: Replace memcpy with struct assignment

2012-10-23 Thread Andy Walls
(http://coccinelle.lip6.fr/) > > // > @@ > identifier struct_name; > struct struct_name to; > struct struct_name from; > expression E; > @@ > -memcpy(&(to), &(from), E); > +to = from; > // > > Cc: Andy Walls Signed-off-by: Andy Walls > Signed-off-

Re: [Intel-gfx] GPU RC6 breaks PCIe to PCI bridge connected to CPU PCIe slot on SandyBridge systems

2012-10-20 Thread Andy Walls
On Fri, 2012-10-19 at 18:06 +0100, Simon Farnsworth wrote: > On Friday 19 October 2012 17:10:17 Simon Farnsworth wrote: > > Mauro, Linux-Media > > > > I have an issue where an SAA7134-based TV capture card connected via a PCIe > > to > > PCI bridge chip works when the GPU is kept out of RC6 state

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Andy Walls
Linus Torvalds wrote: >On Wed, Oct 3, 2012 at 12:50 PM, Greg KH >wrote: >>> >>> Ok, like this? >> >> This looks good to me. Having udev do firmware loading and tieing it >to >> the driver model may have not been such a good idea so many years >ago. >> Doing it this way makes more sense. > >Ok,

Re: udev breakages - was: Re: Need of an ".async_probe()" type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Andy Walls
Greg KH wrote: >On Wed, Oct 03, 2012 at 10:32:08AM -0700, Linus Torvalds wrote: >> On Wed, Oct 3, 2012 at 10:09 AM, Al Viro >wrote: >> > >> > + if (!S_ISREG(inode->i_mode)) >> > + return false; >> > + size = i_size_read(inode); >> > >> > Probably better to do vfs_getatt

Re: media_build error on header file not present in old linux in ivtv-alsa-pcm.c

2012-09-21 Thread Andy Walls
Jan Hoogenraad wrote: >I try to compile the media_build on an old Ubuntu Lucid system. >2.6.32-42-generic-pae #96-Ubuntu SMP Wed Aug 15 19:12:17 UTC 2012 i686 >GNU/Linux > >The make job stops with > >/home/jhh/dvb/media_build/v4l/ivtv-alsa-pcm.c:29:26: error: >linux/printk.h: No such file or dire

Re: [PATCH TRIVIAL] ivtv-alsa-pcm: remove unnecessary printk.h include

2012-09-19 Thread Andy Walls
>diff --git a/drivers/media/pci/ivtv/ivtv-alsa-pcm.c >b/drivers/media/pci/ivtv/ivtv-alsa-pcm.c >index 82c708e..f7022bd 100644 >--- a/drivers/media/pci/ivtv/ivtv-alsa-pcm.c >+++ b/drivers/media/pci/ivtv/ivtv-alsa-pcm.c >@@ -26,7 +26,6 @@ > #include > #include > #incl

Re: [RFC API] Capture Overlay API ambiguities

2012-09-10 Thread Andy Walls
On Mon, 2012-09-10 at 17:14 +0200, Hans Verkuil wrote: > Hi all, > > While working on making bttv compliant with the V4L2 API I managed to resolve > all v4l2-compliance errors except for two: > > fail: v4l2-test-formats.cpp(339): !fmt.width || !fmt.height > test VIDIOC_G_F

[GIT PATCHES] ivtv-alsa, ivtv: Add initial ivtv-alsa interface driver for ivtv

2012-09-03 Thread Andy Walls
to staging/for_v3.6 (2012-08-03 22:41:33 -0300) are available in the git repository at: ssh://linuxtv.org/git/awalls/media_tree.git ivtv-alsa Andy Walls (3): ivtv, ivtv-alsa: Add initial ivtv-alsa interface driver for ivtv ivtv-alsa, ivtv: Connect ivtv PCM capture stream to ivtv-alsa

Re: RFC: Core + Radio profile

2012-08-26 Thread Andy Walls
On Fri, 2012-08-24 at 14:31 +0200, Hans Verkuil wrote: > Hi Mauro, > > Thanks for your review! > > On Wed August 22 2012 15:42:26 Mauro Carvalho Chehab wrote: > > Em 22-08-2012 07:11, Hans Verkuil escreveu: > > >> Also note that the core profile description is more strict than the spec. > > >

Re: RFC: Core + Radio profile

2012-08-26 Thread Andy Walls
Hi Hans, On Sat, 2012-08-25 at 09:21 +0200, Hans Verkuil wrote: > On Sat August 25 2012 02:37:15 Andy Walls wrote: > > On Wed, 2012-08-22 at 11:40 +0200, Hans Verkuil wrote: > > > This RFC is my attempt to start this process by describing three profiles: > > > the co

Re: question about drivers/media/dvb-frontends/rtl2830.c

2012-08-26 Thread Andy Walls
Julia Lawall wrote: >The function rtl2830_init contains the code: > > buf[0] = tmp << 6; > buf[0] = (if_ctl >> 16) & 0x3f; > buf[1] = (if_ctl >> 8) & 0xff; > buf[2] = (if_ctl >> 0) & 0xff; > >Is there any purpose to initializing buf[0] twice? > >julia >-- >To uns

Re: RFC: Core + Radio profile

2012-08-24 Thread Andy Walls
On Wed, 2012-08-22 at 11:40 +0200, Hans Verkuil wrote: > Hi all! > > The v4l2-compliance utility checks whether device drivers follows the V4L2 > specification. What is missing are 'profiles' detailing what device drivers > should and shouldn't implement for particular device classes. > >This has

Re: RFC: Core + Radio profile

2012-08-23 Thread Andy Walls
On Wed, 2012-08-22 at 15:09 -0300, Mauro Carvalho Chehab wrote: > Em 22-08-2012 12:19, Mike Isely escreveu: > > On Wed, 22 Aug 2012, Mauro Carvalho Chehab wrote: > > > >> Em 22-08-2012 07:11, Hans Verkuil escreveu: > >>> I've added some more core profile requirements. > >> > > Streaming

Re: HVR 1600 - Analog goes south again

2012-08-11 Thread Andy Walls
On Sat, 2012-08-11 at 19:22 -0400, Andy Walls wrote: > On Fri, 2012-08-10 at 18:04 -0400, Bob Lightfoot wrote: > > Dear Media List Members: > > I have been using my Hauppage HVR1600 on Centos 6 for some time > > and getting good analog reception. Now the other day for a

Re: boot slow down

2012-08-11 Thread Andy Walls
On Wed, 2012-08-08 at 13:18 -0400, bjloc...@lockie.ca wrote: > How hard would it be to get an official kernel option not to load firmware Submit a patch for the cx23885 driver to the list. It could add a module option so the user can specify not to load cx23885-av firmware (and maybe CX23417 firm

Re: HVR 1600 - Analog goes south again

2012-08-11 Thread Andy Walls
On Fri, 2012-08-10 at 18:04 -0400, Bob Lightfoot wrote: > Dear Media List Members: > I have been using my Hauppage HVR1600 on Centos 6 for some time > and getting good analog reception. Now the other day for a reason I > have not been able to determine the Analog quit working and I have not >

Re: boot slow down

2012-08-07 Thread Andy Walls
bjloc...@lockie.ca wrote: >> Hi James, >> >> On Mon, Aug 06, 2012 at 12:38:51AM -0400, James wrote: >>> On 08/05/12 17:20, Sakari Ailus wrote: >>> > Hi Andy and James, >>> > >>> > On Sat, Aug 04, 2012 at 06:28:19PM -0400, James w

Re: boot slow down

2012-08-06 Thread Andy Walls
Antti Palosaari wrote: >On 08/06/2012 11:37 AM, Andy Walls wrote: >> James wrote: >> >>> On 08/04/12 13:42, Andy Walls wrote: >>>> James wrote: >>>> >>>>> There's a big pause before the 'unable' >>>>

Re: boot slow down

2012-08-06 Thread Andy Walls
James wrote: >On 08/04/12 13:42, Andy Walls wrote: >> James wrote: >> >>> There's a big pause before the 'unable' >>> >>> [2.243856] usb 4-1: Manufacturer: Logitech >>> [ 62.739097] cx25840 6-0044: unable to open

Re: boot slow down

2012-08-04 Thread Andy Walls
James wrote: >There's a big pause before the 'unable' > >[2.243856] usb 4-1: Manufacturer: Logitech >[ 62.739097] cx25840 6-0044: unable to open firmware >v4l-cx23885-avcore-01.fw > > >I have a cx23885 >cx23885[0]: registered device video0 [v4l2] > >Is there any way to stop it from trying t

Re: Asus PVR-416

2012-08-03 Thread Andy Walls
nd/or mailbox pointer not initialized > or corrupted > cx88-mpeg driver manager :01:01.2: firmware: requesting > v4l-cx2341x-enc.fw > cx88[0]/2-bb: ERROR: Firmware load failed (checksum mismatch). > > > It

Re: 3.5 kernel options for Hauppauge_WinTV-HVR-1250

2012-08-02 Thread Andy Walls
bjloc...@lockie.ca wrote: > >> Heck, even for the 1250 there are eight or ten different versions, so >> most users wouldn't even know the right one to choose. > >Do you mean boards that use different chips? >I hate it when manufacturers do that (ie. with routers). > > >-- >To unsubscribe from this

Re: 3.5 kernel options for Hauppauge_WinTV-HVR-1250

2012-08-02 Thread Andy Walls
bjloc...@lockie.ca wrote: >> On Thu, Aug 2, 2012 at 5:53 AM, Andy Walls >> wrote: >>> You can 'grep MODULE_ drivers/media/video/cx23885/* >>> drivers/media/video/cx25840/* ' and other relevant directories under >>> drivers/media/{dvb, common} t

Re: 3.5 kernel options for Hauppauge_WinTV-HVR-1250

2012-08-02 Thread Andy Walls
Devin Heitmueller wrote: >On Thu, Aug 2, 2012 at 5:53 AM, Andy Walls >wrote: >> You can 'grep MODULE_ drivers/media/video/cx23885/* >drivers/media/video/cx25840/* ' and other relevant directories under >drivers/media/{dvb, common} to find all the parameter options f

Re: 3.5 kernel options for Hauppauge_WinTV-HVR-1250

2012-08-02 Thread Andy Walls
James wrote: >On 08/01/12 07:07, Andy Walls wrote: >> James wrote: >> >>> I got the latest kernel from git and I can't find the kernel options >>> for my tv card. >>> >>> I have: http://linuxtv.org/wiki/index.php/Hauppauge_WinTV-HVR-1250

Re: 3.5 kernel options for Hauppauge_WinTV-HVR-1250

2012-08-01 Thread Andy Walls
James wrote: >I got the latest kernel from git and I can't find the kernel options >for my tv card. > >I have: http://linuxtv.org/wiki/index.php/Hauppauge_WinTV-HVR-1250 >-- >To unsubscribe from this list: send the line "unsubscribe linux-media" >in >the body of a message to majord...@vger.kernel

Re: Asus PVR-416

2012-07-30 Thread Andy Walls
On Mon, 2012-07-30 at 06:57 -0400, Jerry Haggard wrote: > I've been trying to get an ASUS PVR-416 card to work with MythTV .25 on > Scientific Linux 6. I have a bttv card working, my setup works in > general, etc, and the driver attempts to load. But when I check dmesg, > I keep getting firmwa

Re: [PATCH v3] cx18: Declare MODULE_FIRMWARE usage

2012-07-28 Thread Andy Walls
On Fri, 2012-07-27 at 10:45 -0600, Tim Gardner wrote: > Cc: Andy Walls Acked-by: Andy Walls Regards, Andy > Cc: Mauro Carvalho Chehab > Cc: ivtv-de...@ivtvdriver.org > Cc: linux-media@vger.kernel.org > Signed-off-by: Tim Gardner > --- > drivers/media/video/cx18/cx18

Re: [PATCH] ivtv: Declare MODULE_FIRMWARE usage

2012-07-28 Thread Andy Walls
On Fri, 2012-07-27 at 09:45 -0600, Tim Gardner wrote: > On 07/26/2012 04:21 PM, Andy Walls wrote: > > On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote: > >> Cc: Andy Walls > >> Cc: Mauro Carvalho Chehab > >> Cc: ivtv-de...@ivtvdriver.org > >> Cc

Re: [PATCH] cx25840: Declare MODULE_FIRMWARE usage

2012-07-28 Thread Andy Walls
On Fri, 2012-07-27 at 06:06 -0600, Tim Gardner wrote: > On 07/26/2012 03:59 PM, Andy Walls wrote: > > On Thu, 2012-07-26 at 10:44 -0600, Tim Gardner wrote: > >> Cc: Mauro Carvalho Chehab > >> Cc: linux-media@vger.kernel.org > >> Signed-off-by: Tim Gardner

Re: [PATCH] ivtv: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Andy Walls
On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote: > Cc: Andy Walls > Cc: Mauro Carvalho Chehab > Cc: ivtv-de...@ivtvdriver.org > Cc: linux-media@vger.kernel.org > Signed-off-by: Tim Gardner > --- > drivers/media/video/ivtv/ivtv-firmware.c |4 > 1 fi

Re: [PATCH v2] cx18: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Andy Walls
17 00:00:00 2001 > From: Tim Gardner > Date: Thu, 26 Jul 2012 11:03:51 -0600 > Subject: [PATCH v2] cx18: Declare MODULE_FIRMWARE usage > > Cc: Andy Walls > Cc: Mauro Carvalho Chehab > Cc: ivtv-de...@ivtvdriver.org > Cc: linux-media@vger.kernel.org > Signed-off-by: Ti

Re: [PATCH] cx18: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Andy Walls
On Thu, 2012-07-26 at 11:05 -0600, Tim Gardner wrote: > Cc: Andy Walls > Cc: Mauro Carvalho Chehab > Cc: ivtv-de...@ivtvdriver.org > Cc: linux-media@vger.kernel.org > Signed-off-by: Tim Gardner You missed v4l-cx23418-dig.fw, in cx18-av-firmware.c, which is required by all CX2341

Re: [PATCH] cx25840: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Andy Walls
On Thu, 2012-07-26 at 10:44 -0600, Tim Gardner wrote: > Cc: Mauro Carvalho Chehab > Cc: linux-media@vger.kernel.org > Signed-off-by: Tim Gardner > --- > drivers/media/video/cx25840/cx25840-firmware.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/dri

Re: Media summit at the Kernel Summit - was: Fwd: Re: [Ksummit-2012-discuss] Organising Mini Summits within the Kernel Summit

2012-07-24 Thread Andy Walls
Devin Heitmueller wrote: >On Tue, Jul 24, 2012 at 4:05 PM, Rémi Denis-Courmont >wrote: >> If it's of interest to anyone, I could probably present a bunch of >issues with >> V4L2 and DVB from userspace perspective. > >Remi, > >I would strongly be in favor of this. One thing that we get far to >l

Re: [PATCH 2/2] kthread_worker: reimplement flush_kthread_work() to allow freeing the work item being executed

2012-07-24 Thread Andy Walls
On Mon, 2012-07-23 at 10:12 -0700, Tejun Heo wrote: > Hello, > > On Sun, Jul 22, 2012 at 04:46:54PM -0400, Andy Walls wrote: > > Hmmm, I didn't know about the constraint about 'known to be alive' in > > the other email I just sent. > > > > That mi

Re: [PATCH 2/2] kthread_worker: reimplement flush_kthread_work() to allow freeing the work item being executed

2012-07-22 Thread Andy Walls
On Sun, 2012-07-22 at 09:49 -0700, Tejun Heo wrote: > Hello, > > On Sat, Jul 21, 2012 at 02:20:06PM -0400, Andy Walls wrote: > > > + worker->current_work = work; > > > spin_unlock_irq(&worker->lock); > > > > > > if (w

Re: [PATCH 1/2] kthread_worker: reorganize to prepare for flush_kthread_work() reimplementation

2012-07-22 Thread Andy Walls
On Sun, 2012-07-22 at 09:46 -0700, Tejun Heo wrote: > Hello, > > On Sat, Jul 21, 2012 at 01:13:27PM -0400, Andy Walls wrote: > > > +/* insert @work before @pos in @worker */ > > > > Hi Tejun, > > > > Would a comment that the caller should be holdin

Re: [PATCH 2/2] kthread_worker: reimplement flush_kthread_work() to allow freeing the work item being executed

2012-07-22 Thread Andy Walls
Hi Tejun, Thanks for responding to my previous questions. I have one more. On Sat, 2012-07-21 at 14:20 -0400, Andy Walls wrote: > On Thu, 2012-07-19 at 14:16 -0700, Tejun Heo wrote: > > From 06f9a06f4aeecdb9d07014713ab41b548ae219b5 Mon Sep 17 00:00:00 2001 > > From: Tejun Heo &g

Re: [PATCH 2/2] kthread_worker: reimplement flush_kthread_work() to allow freeing the work item being executed

2012-07-21 Thread Andy Walls
On Thu, 2012-07-19 at 14:16 -0700, Tejun Heo wrote: > From 06f9a06f4aeecdb9d07014713ab41b548ae219b5 Mon Sep 17 00:00:00 2001 > From: Tejun Heo > Date: Thu, 19 Jul 2012 13:52:53 -0700 > > kthread_worker provides minimalistic workqueue-like interface for > users which need a dedicated worker thread

Re: [PATCH 1/2] kthread_worker: reorganize to prepare for flush_kthread_work() reimplementation

2012-07-21 Thread Andy Walls
re @pos in @worker */ Hi Tejun, Would a comment that the caller should be holding worker->lock be useful here? Anyway, comment or not: Acked-by: Andy Walls Regards, Andy > +static void insert_kthread_work(struct kthread_worker *worker, > +

Re: staging/for_v3.6 is currently broken

2012-07-14 Thread Andy Walls
Steven Toth wrote: >Looks like the new union in v4l2_ioctl_info breaks things. > >-bash-4.1$ make -j6 >make[1]: Nothing to be done for `all'. > CHK include/linux/version.h > CHK include/generated/utsrelease.h > CALLscripts/checksyscalls.sh > CHK include/generated/compile.h >

Re: Linux equivalent of Windows VBIScope?

2012-07-09 Thread Andy Walls
Tim Stowell wrote: >Hi all, > >I am using the em28xx driver and have been able to extract captions >using zvbi. I would like to visualize the waveform like the DirectShow >VBIScope filter on windows (unfortunately the Windows driver doesn't >expose any VBI pins). Does anyone know of anythings sim

Re: AverTVHD Volar Max (h286DU)

2012-06-29 Thread Andy Walls
On Fri, 2012-06-29 at 15:55 -0400, Devin Heitmueller wrote: > On Fri, Jun 29, 2012 at 3:10 PM, wrote: > > I've found that most, if not all, cable boxes do not pass > > through CC data, because they are meant to interpret it and > > pass it on with customized formatting and whatnot, so another >

Re: Janitor / newbie patches

2012-06-09 Thread Andy Walls
Peter Senna Tschudin wrote: >Dear List, > >I've sent some janitor/newbie patches and I want to know if am I doing >something wrong before continuing with more patches. > >The patches I've submitted: >http://patchwork.linuxtv.org/patch/11576/ > > This one was sent only to the list, I've not cc:

Re: [RFC] file tree rearrangement - was: Re: [RFC PATCH 0/3] Improve Kconfig selection for media devices

2012-05-27 Thread Andy Walls
Hans Verkuil wrote: >On Sun May 27 2012 19:13:38 Mauro Carvalho Chehab wrote: >> Em 27-05-2012 13:56, Mauro Carvalho Chehab escreveu: >> > The Kconfig building system is improperly selecting some drivers, >> > like analog TV tuners even when this is not required. >> > >> > Rearrange the Kconfig

Re: HVR1600 and Centos 6.2 x86_64 -- Strange Behavior

2012-05-22 Thread Andy Walls
Devin Heitmueller wrote: >On Tue, May 22, 2012 at 4:34 PM, Bob Lightfoot >wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Dear LinuxTv and AtRpms Communities: >>     In the most recent three kernels {2.6.32-220.7.1 ; >> 2.6.32-220.13.1 ; 2.6.32-220.17.1} released for CentOS 6.2

Re: Warning in cx24110: how to fix?

2012-05-22 Thread Andy Walls
Hans Verkuil wrote: >On Tue 22 May 2012 13:06:25 Andy Walls wrote: >> Hans Verkuil wrote >> >> >I'm getting this warning in the daily build: >> > >> >v4l-dvb-git/drivers/media/dvb/frontends/cx24110.c: In function >> >‘cx24110_read_ucbloc

Re: Warning in cx24110: how to fix?

2012-05-22 Thread Andy Walls
Hans Verkuil wrote >I'm getting this warning in the daily build: > >v4l-dvb-git/drivers/media/dvb/frontends/cx24110.c: In function >‘cx24110_read_ucblocks’: >v4l-dvb-git/drivers/media/dvb/frontends/cx24110.c:520:40: warning: >value computed is not used [-Wunused-value] > >It comes from this code:

Re: error - cx18 driver

2012-05-05 Thread Andy Walls
Hector Catre wrote: >Note: I’m a relatively n00b trying to set up mythtv and having issues >installing the hauppage hvr-1600 tuner/capture card. > >When I run dmesg, I get the following: > >[ 117.013178] a1ac5dc28d2b4ca78e183229f7c595ffd725241c [media] gspca >- sn9c20x: Change the exposure sett

Re: Hauppage HVR1600 - CX18 Issue with Centos 6.2 - Analog Sound comes and goes

2012-05-03 Thread Andy Walls
On Wed, 2012-05-02 at 00:53 -0400, Bob Lightfoot wrote: > Dear Mailing List linux-media: > > I am attempting to use a Hauppage HVR-1600 purchased new in 2010 as an > analog tv tuner in my HP Pavillion Elite M9040n PC running Centos 6.2 > x86_64. The problem I am experiencing is that with ev

Re: [RFC v3 1/2] v4l: Do not use enums in IOCTL structs

2012-05-03 Thread Andy Walls
On Thu, 2012-05-03 at 07:22 -0300, Mauro Carvalho Chehab wrote: > Em 02-05-2012 21:42, Andy Walls escreveu: > > On Wed, 2012-05-02 at 19:17 -0300, Mauro Carvalho Chehab wrote: > >> I suspect that sizeof() won't work inside a macro. > > > > sizeof()

Re: HVR-1600 QAM recordings with slight glitches in them

2012-05-03 Thread Andy Walls
Devin Heitmueller wrote: >Resending with the ML back on the cc:. > >On Wed, May 2, 2012 at 11:29 PM, Brian J. Murrell > wrote: >> On 12-04-29 08:09 PM, Devin Heitmueller wrote: >>> >>> I don't know why you're not seeing valid data on femon with the >950q. >>> It should be printing out fine, and i

Re: [RFC v3 1/2] v4l: Do not use enums in IOCTL structs

2012-05-02 Thread Andy Walls
On Wed, 2012-05-02 at 19:17 -0300, Mauro Carvalho Chehab wrote: > We can speed-up the conversions, with something like: > > enum foo { > BAR > }; > > if (sizeof(foo) != sizeof(u32)) > call_compat_logic(). > > I suspect that sizeof() won't work inside a macro. sizeof() is evaluated

Re: [GIT PULL FOR v3.5] cpia2: major overhaul to get it in a working state again.

2012-04-29 Thread Andy Walls
On Sun, 2012-04-29 at 13:57 +0200, Hans Verkuil wrote: > Hi all, > > I managed to get hold of a cpia2-based Hanse USB microscope almost a year > ago after reports from Andrea that the driver didn't work properly. > > I finally had time to take a really good look at the driver and it was > broken

Re: [GIT PULL FOR v3.5] An ivtv fix and support suspend/resume in radio-keene

2012-04-29 Thread Andy Walls
change looks OK to me. Even though v4l2_ctrl_fill() fixes up those errors anyway. Reviewed-by: Andy Walls Regards, Andy > > drivers/media/radio/radio-keene.c | 20 > drivers/media/video/ivtv/ivtv-driver.c |4 ++-- > 2 files changed, 22 insertions(

Re: [RFC PATCH 3/8] ivtv/cx18: fix compiler warnings

2012-04-29 Thread Andy Walls
set but not used > [-Wunused-but-set-variable] > media_build/v4l/ivtvfb.c: In function 'ivtvfb_init': > media_build/v4l/ivtvfb.c:1286:6: warning: variable 'err' set but not used > [-Wunused-but-set-variable] > media_build/v4l/ivtvfb.c: In function 'ivtvfb

Re: [RFC PATCH 5/8] v4l: fix compiler warnings.

2012-04-29 Thread Andy Walls
et but not > used [-Wunused-but-set-variable] > media_build/v4l/sn9c102_core.c: In function 'sn9c102_stream_interrupt': > media_build/v4l/sn9c102_core.c:998:7: warning: variable 'timeout' set but not > used [-Wunused-but-set-variable] > > Sign

Re: HVR-1600 QAM recordings with slight glitches in them

2012-04-28 Thread Andy Walls
On Sat, 2012-04-28 at 14:36 -0400, Brian J. Murrell wrote: > One more question... > > On 12-04-28 10:56 AM, Andy Walls wrote: > > > > So I see SNR values from 0x138 to 0x13c ( 31.2 dB to 31.6 dB ) when you > > have problems. For 256-QAM cable signals, I think that

Re: HVR-1600 QAM recordings with slight glitches in them

2012-04-28 Thread Andy Walls
On Sat, 2012-04-28 at 14:08 -0400, Brian J. Murrell wrote: > On 12-04-28 10:56 AM, Andy Walls wrote: > > OK. There are two ways to go here: > > > > 1. We assume your signal is marginal. Take a look here for things to > > check and fix if needed: > > &g

Re: HVR-1600 QAM recordings with slight glitches in them

2012-04-28 Thread Andy Walls
On Tue, 2012-04-24 at 23:07 -0400, Brian J. Murrell wrote: > On 12-04-24 06:42 PM, Andy Walls wrote: > > Run 'femon' on the cx18's dvb frontend when you have a live QAM capture > > ongoing. > > OK. Ran it all evening during the evening capture window. Star

Re: udev rules for persistent symlinks for adapter?/frontend0 devices

2012-04-24 Thread Andy Walls
On Tue, 2012-04-24 at 13:14 -0400, Brian J. Murrell wrote: > Hi, > > I have two DVB devices in my machine that I want to be able to identify > persistently[1]. They are typically on /dev/dvb/adapter{0,1}/frontend0 > but their order is arbitrary and can change from one boot to another. > > So usi

Re: HVR-1600 QAM recordings with slight glitches in them

2012-04-24 Thread Andy Walls
On Sun, 2012-04-22 at 23:30 -0400, Brian J. Murrell wrote: > Hi, > > I have an HVR-1600 on a 3GHz dual-core P4 running linux 3.2.0. > > Whenever I record from clearqam using this card I frequently get small > "glitches" in playback. Playing these same files with mplayer yields > things like: >

Re: HVR-1600: Skipped encoder MPEG, MDL 63, 62 times - it must have dropped out of rotation

2012-04-23 Thread Andy Walls
On Mon, 2012-04-23 at 13:07 -0400, Brian J. Murrell wrote: > On 12-04-22 04:56 PM, Andy Walls wrote: > > > > If, in your system, IRQ service for device A under some circumstances > > has precendence over IRQ service for the CX23418 and hence holds off its > > service;

Re: CX23102 audio; need datasheet

2012-04-23 Thread Andy Walls
On Mon, 2012-04-23 at 20:41 -0400, Dwayne C. Litzenberger wrote: > Hi there, > > I'm working on adding support for another board to the cx231xx driver. I'm > doing this work on my own time as a volunteer, so I don't have an existing > relationship with Conexant. > > I bought an "AVerMedia DVD

Re: HVR-1600: Skipped encoder MPEG, MDL 63, 62 times - it must have dropped out of rotation

2012-04-22 Thread Andy Walls
On Sun, 2012-04-22 at 12:03 -0400, Brian J. Murrell wrote: > I've got an HVR-1600 in a fairly fast machine (P4 3GHz, two cores) on a > 3.2.0 kernel and seem to be getting lots of this sort of thing: > > Apr 19 20:09:10 pvr kernel: [34651.015170] cx18-0: Skipped encoder MPEG, MDL > 63, 62 times -

Re: [PATCH] TDA9887 PAL-Nc fix

2012-04-20 Thread Andy Walls
On Fri, 2012-04-20 at 11:01 -0300, Gonzalo A. de la Vega wrote: > On Thu, Apr 19, 2012 at 8:50 PM, Andy Walls wrote: > > On Wed, 2012-04-18 at 09:22 -0300, Gonzalo de la Vega wrote: > >> The tunner IF for PAL-Nc norm, which AFAIK is used only in Argentina, was > >> be

Re: [GIT PULL FOR v3.5] Various fixes

2012-04-19 Thread Andy Walls
On Thu, 2012-04-19 at 17:48 +0200, Hans Verkuil wrote: > While I was cleaning up some older drivers I came across a few bugs that are > fixed here. The fixes are all trivial one-liners. > > Regards, > > Hans The fixes for ivtv and cx18 look good to me. Thanks Hans.

Re: [PATCH] TDA9887 PAL-Nc fix

2012-04-19 Thread Andy Walls
On Wed, 2012-04-18 at 09:22 -0300, Gonzalo de la Vega wrote: > The tunner IF for PAL-Nc norm, which AFAIK is used only in Argentina, was > being defined as equal to PAL-M but it is not. It actually uses the same > video IF as PAL-BG (and unlike PAL-M) but the audio is at 4.5MHz (same as > PAL-M)

Re: v4l-cx23885-enc.fw

2012-04-19 Thread Andy Walls
On Tue, 2012-04-17 at 16:18 -0500, Britney Fransen wrote: > I am not sure where to report this so if this is the wrong place and > someone can point me in the right direction it would be appreciated. > > http://www.linuxtv.org/downloads/firmware/v4l-cx23885-enc.fw & > http://www.linuxtv.org/downlo

Re: media_build compile errors

2012-04-13 Thread Andy Walls
"Roger Mårtensson" wrote: >Hi! > >I get compile errors when trying to build media_build as of 2012-04-13. > >/home/mythfrontend/media_build/v4l/ivtv-fileops.c: In function >'ivtv_v4l2_enc_poll': >/home/mythfrontend/media_build/v4l/ivtv-fileops.c:751:2: error: >implicit >declaration of function

Re: NTSC_443 problem in v4l and em28x

2012-04-02 Thread Andy Walls
Colin Eby wrote: >All, > >Wondered if someone could advise... I'm from an NTSC and PAL capable >tape deck, in the UK. I believe that means the signal coming from the >deck will be NTSC_443 compliant. What is captured through VLC or XAWTV >is slightly grainy black and white (no green band). It ki

Re: [PATCH for v3.4] Fix ivtv AUDIO_(BILINGUAL_)CHANNEL_SELECT regression

2012-03-31 Thread Andy Walls
> Signed-off-by: Hans Verkuil Looks good. Thanks Martin and Hans. Reviewd-by: Andy Walls > Regards, > > Hans > > diff --git a/drivers/media/video/ivtv/ivtv-ioctl.c > b/drivers/media/video/ivtv/ivtv-ioctl.c > index 5452bee..989e556 100644 > --- a/drivers/med

Re: Compilation problem : too few arguments to function 'kmap_atomic

2012-03-29 Thread Andy Walls
"Loïc Bertron" wrote >Hello, > >I'm running into an issue when compiling the last version of >media_build : > >/usr/src/linux-headers-2.6.32-5-common/include/linux/kernel.h:366:1: >warning: this is the location of the previous definition > CC [M] /home/toto/sources/media_build/v4l/hdpvr-contro

Re: ViXS XCode 2100 Series TV NTSC/ATSC FM Tuner Card

2012-03-25 Thread Andy Walls
Vikas N Kumar wrote: >On Sat, Mar 24, 2012 at 8:33 AM, Andy Walls >wrote: >> >> Hi, >> >> ivtv will never support this chip;  the hardware is not even close to >a CX23415/6. >> >> ViXS has never openly released any documentation. >> >>

Re: ViXS XCode 2100 Series TV NTSC/ATSC FM Tuner Card

2012-03-24 Thread Andy Walls
Vikas N Kumar wrote: >Hi >I am interested to know if there exists any support for the ViXS XCode >2100 Series cards ? I have looked and not found any viable support for >the card chipset except for some forums mentioning "ivtv" as a driver. > >If there is anyone working on this or if there is som

Re: [Q] v4l buffer format inside isoc

2012-03-20 Thread Andy Walls
On Tue, 2012-03-20 at 21:05 -0300, Ezequiel García wrote: > Hello, > > I'm a little lost while writing a driver for an easycap device > (saa7113 capture device). > I have my isoc handler, and the isoc urb flying OK. > I also have the videobuf2 queue setup (or at least I think so), and I > underst

Re: 320cx analog part

2012-03-20 Thread Andy Walls
On Tue, 2012-03-20 at 20:05 +0400, volokh wrote: > Hi, can somebody help me with developing analog driver part. > I`m looking for any docs or code. > CX25840/1/2/3 datasheet: http://dl.ivtvdriver.org/datasheets/video/cx25840.pdf V4L2 framework for drivers to use: http://git.linuxtv.org/media_tre

Re: Hauppauge HVR-1600 potential bug or model issue

2012-03-17 Thread Andy Walls
ally depends on people's personal requirements. If linux support is important for you though, there is a very short list of companies that provide decent Linux support for TV capture. Buy one of their devices. Regards, Andy > Thanks for all the help, > Matt > > On Wed, Mar 14,

Re: Hauppauge HVR-1600 potential bug or model issue

2012-03-14 Thread Andy Walls
Hi Matt, On Sun, 2012-03-11 at 13:45 -0400, Matt Berglund wrote: > Hello all, > > I'm having trouble with my 1600 listed as: Hauppauge model 74541, rev C6A3 > The firmware is installed. Both using yum and manually. > Based on the LTV wiki, it seems this is less well tested model. If > this is so,

Re: [PATCH v3 09/10] v4l: Aptina-style sensor PLL support

2012-03-04 Thread Andy Walls
On Sun, 2012-03-04 at 11:20 +0100, Laurent Pinchart wrote: > Hi Andy, > > Thanks for the review. > > On Saturday 03 March 2012 12:35:09 Andy Walls wrote: > > On Sat, 2012-03-03 at 16:28 +0100, Laurent Pinchart wrote: > > > Add a generic helper function to compute P

Re: [PATCH v3 09/10] v4l: Aptina-style sensor PLL support

2012-03-03 Thread Andy Walls
On Sat, 2012-03-03 at 12:35 -0500, Andy Walls wrote: > On Sat, 2012-03-03 at 16:28 +0100, Laurent Pinchart wrote: > > Add a generic helper function to compute PLL parameters for PLL found in > > several Aptina sensors. > > > > Signed-off-by: Laurent Pinchart >

Re: [PATCH v3 09/10] v4l: Aptina-style sensor PLL support

2012-03-03 Thread Andy Walls
On Sat, 2012-03-03 at 16:28 +0100, Laurent Pinchart wrote: > Add a generic helper function to compute PLL parameters for PLL found in > several Aptina sensors. > > Signed-off-by: Laurent Pinchart > --- > drivers/media/video/Kconfig |3 + > drivers/media/video/Makefile |4 + > dr

Re: audio is not working

2012-03-01 Thread Andy Walls
Steven Dahlin wrote: >I am running an athlon ii 945 with a hauppauge wintv 1600 capture >card. I have a version of mythtv installed (0.24) in which I >downloaded the latest V4L-DVB Device Drivers from >git://linuxtv.org/media_build.git, built them, and then installed. >Everything is up to date w

Re: [question] v4l read() operation

2012-02-25 Thread Andy Walls
"Ezequiel García" wrote: >Hi, > >If I register a video device with this fops: > >static const struct v4l2_file_operations v4l2_fops = { >.owner = THIS_MODULE, >.open= xxx_open, >.unlocked_ioctl = xxx_unlocked_ioctl, >.poll = xxx_poll, >

Re: SDR FM demodulation

2012-02-11 Thread Andy Walls
On Fri, 2012-02-10 at 20:29 -0600, David Hagood wrote: > On Fri, 2012-02-10 at 21:08 -0500, Andy Walls wrote: > > > > Randomly checking some of the data with GNUplot, if 2.5 Msps is the > > sampling rate, then the fastest freq I saw was about 50 kHz. > How'd you ana

Re: SDR FM demodulation

2012-02-10 Thread Andy Walls
On Thu, 2012-02-09 at 17:21 +0200, Antti Palosaari wrote: > On 09.02.2012 17:11, Patrick Boettcher wrote: > > On Thursday 09 February 2012 16:01:12 Antti Palosaari wrote: > >> I have taken radio sniffs from FM capable Realtek DVB-T device. Looks > >> like demodulator ADC samples IF frequency and pa

Re: SDR FM demodulation

2012-02-09 Thread Andy Walls
Antti Palosaari wrote: >On 09.02.2012 17:11, Patrick Boettcher wrote: >> On Thursday 09 February 2012 16:01:12 Antti Palosaari wrote: >>> I have taken radio sniffs from FM capable Realtek DVB-T device. >Looks >>> like demodulator ADC samples IF frequency and pass all the sampled >>> data to the a

Re: [PATCH v2 08/16] ivtv-driver: fix handling of 'radio' module parameter

2012-01-31 Thread Andy Walls
Danny Kukawka wrote: >On Dienstag, 31. Januar 2012, Andy Walls wrote: >> On Mon, 2012-01-30 at 20:40 +0100, Danny Kukawka wrote: >> > Fixed handling of 'radio' module parameter from module_param_array >> > to module_param_named to fix these compiler war

Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter

2012-01-31 Thread Andy Walls
Danny Kukawka wrote: >On Dienstag, 31. Januar 2012, Andy Walls wrote: >> On Tue, 2012-01-31 at 05:01 -0500, Andy Walls wrote: >> > On Mon, 2012-01-30 at 20:40 +0100, Danny Kukawka wrote: >> > > Fixed handling of 'radio' module parameter from >module_

Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter

2012-01-31 Thread Andy Walls
On Tue, 2012-01-31 at 05:01 -0500, Andy Walls wrote: > On Mon, 2012-01-30 at 20:40 +0100, Danny Kukawka wrote: > > Fixed handling of 'radio' module parameter from module_param_array > > to module_param_named to fix these compiler warnings in cx18-driver.c: > > NA

Re: [PATCH v2 08/16] ivtv-driver: fix handling of 'radio' module parameter

2012-01-31 Thread Andy Walls
On Mon, 2012-01-30 at 20:40 +0100, Danny Kukawka wrote: > Fixed handling of 'radio' module parameter from module_param_array > to module_param_named to fix these compiler warnings in ivtv-driver.c: > > In function ‘__check_radio’: > 113:1: warning: return from incompatible pointer type [enabled by

Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter

2012-01-31 Thread Andy Walls
On Mon, 2012-01-30 at 20:40 +0100, Danny Kukawka wrote: > Fixed handling of 'radio' module parameter from module_param_array > to module_param_named to fix these compiler warnings in cx18-driver.c: NACK. "radio" is an array of tristate values (-1, 0, 1) per installed card: static int rad

Re: [PATCH 1/5] Driver core: driver_find() drops reference before returning

2012-01-24 Thread Andy Walls
. >Hence the patch will not introduce any new bugs. The existing callers >all seem to be okay in this respect, however I don't understand the >video drivers well enough to be certain about them. > >Signed-off-by: Alan Stern >CC: Dmitry Torokhov >CC: Kyungmin Park >CC: Andy

Re: cx18-0: Could not find buf 90 for stream TS

2012-01-18 Thread Andy Walls
On Wed, 2012-01-18 at 09:22 -0500, Brian J. Murrell wrote: > [ Apologies if this ends up as a duplicate post but my first posting > (via gmane) a couple of hours ago is still not on the list ] > > I have an HVR-1600 on a 2.6.32[-33 Ubuntu] kernel (modinfo says the > cx18 driver is version 1.2.0

Re: Strange problem, help needed

2012-01-16 Thread Andy Walls
On Mon, 2012-01-16 at 11:55 -0600, David Engel wrote: > Hi, > > I have a MythTV backend with a Hauppauge HVR-2250 (dual tuner, > ATSC?QAM, PCIe) and a Ceton InfiniTV4 (quad tuner, QAM/cable card, > PCIe). Over the weekend, I started intermittently seeing corrupt > recordings that were painful to

Re: cx25840: improve audio for cx2388x drivers

2012-01-14 Thread Andy Walls
On Sat, 2012-01-14 at 19:44 +0100, Miroslav Slugeň wrote: > Searching for testers, this patch is big one, it was more then week of > work and testing, so i appriciate any comments and recommendations. Hi Miroslav, I have not exhaustively revied this patch, but some general comments: 1. This patc

<    1   2   3   4   5   6   7   8   9   10   >