Re: [PATCH] hdpvr: enable IR part

2011-01-15 Thread Andy Walls
With my newly hacked lirc_zilog, try using the 'tx_only' parameter please. It's not quite ready yet, but I'd like to know if it can bind. If you already loaded a lirc_zilog without my latest patches, the i2c subsystem might have bogus crud still registered. A reboot might be needed for a valid

Re: [PATCH] hdpvr: enable IR part

2011-01-14 Thread Andy Walls
On Fri, 2011-01-14 at 21:30 -0500, Jarod Wilson wrote: > On Jan 14, 2011, at 5:08 PM, Jarod Wilson wrote: > >>> Registered IR keymap rc-hauppauge-new > >>> input: i2c IR (HD PVR) as /devices/virtual/rc/rc1/input6 > >>> rc1: i2c IR (HD PVR) as /devices/virtual/rc/rc1 > >>> ir-kbd-i2c: i2c IR (HD PV

VIDIOC_INT_RESET still needed in ivtv for the moment

2011-01-14 Thread Andy Walls
Hans, A few weeks ago you asked if VIDIOC_INT_RESET is still needed in ivtv. I can now say for certain, that yes, it is still needed. See this from 2008: http://www.mail-archive.com/ivtv-users@ivtvdriver.org/msg08613.html It will not be needed after I get two things done: 1. patch ivtv to issu

[PATCH] ir-kbd-i2c: Add debug to examine received data in get_key_haup_common()

2011-01-14 Thread Andy Walls
Add a hex dump of the received bytes for tester reporting of actual data received from the hardware. Signed-off-by: Andy Walls --- My heart won't be broken if this never makes it into the kernel. Regards, Andy diff --git a/drivers/media/video/ir-kbd-i2c.c b/drivers/media/video/ir-kbd-

Re: [PATCH] hdpvr: enable IR part

2011-01-14 Thread Andy Walls
y testing, and I do have a reason for that, > and will post a v2 after testing this weekend, if need be)... As discussed on IRC 1. no need to probe for the Z8 as HD PVR always has one. 2. accessing the chip at address 0x54 directly should eventually be reworked with nicer i2c subsystem metho

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-13 Thread Andy Walls
Jean, Yes, however, I asked because ivtv and cx18 use i2c-algo-bit and also provide Zilog z8 IR I2C clients for lirc_zilog to use. So if those get clock stretch handling "for free", that's great. Regards, Andy Jean Delvare wrote: >On Thu, 13 Jan 2011 11:34:42 -0500

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-13 Thread Andy Walls
Devin, You've seen the clock stretch with your I2C analyzer? Jean, How should clock stretches by slaves be handled using i2c-algo-bit? Regards, Andy Devin Heitmueller wrote: >On Thu, Jan 13, 2011 at 8:21 AM, Jean Delvare wrote: >> My bet is that register at 0x00 is a control register, and w

RE: Enable IR on hdpvr

2011-01-12 Thread Andy Walls
On Thu, 2011-01-13 at 02:16 +, Jason Gauthier wrote: > >> I've got two hdpvrs. Whenever you're ready to extend your testing, > >> I'm happy to extend that functional testing. I didn't get a chance to > >> look at the FC14 patch yet (busy couple of days), but I will hold off > >> now, anyway!

RE: Enable IR on hdpvr

2011-01-12 Thread Andy Walls
On Wed, 2011-01-12 at 18:45 -0500, Andy Walls wrote: > If all goes well, with Jarrod's change, you should be able to test the > hdpvr module with the ir-kbd-i2c module and test IR Rx. FYI, I have (re)confirmed that ir-kbd-i2c and cx18, in a bleeding-edge development kernel, still wo

RE: Enable IR on hdpvr

2011-01-12 Thread Andy Walls
the F14 2.6.35.10 kernel, which has a fairly recent v4l/dvb > >> backport on top of it, so it should be pretty close to matching the > >> current v4l/dvb code... > > >With the help of Andy Walls and Jean Delvare, I think we've hashed > out an updated patch that

Re: [GIT PATCHES FOR 2.6.38] Implement core priority handling

2011-01-11 Thread Andy Walls
On Tue, 2011-01-11 at 09:21 +0100, Hans Verkuil wrote: > This implements core support for priority handling. This is basically the same > as my RFCv3 patch series, except without some of the driver changes (I want to > do that for 2.6.39) and with the single fix to patch 05/16 I posted to the > li

Re: [REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864

2011-01-10 Thread Andy Walls
On Mon, 2011-01-10 at 13:56 +0100, Lawrence Rust wrote: > On Mon, 2011-01-10 at 07:39 -0500, Andy Walls wrote: > You know what, life's too short. I've spent far too long on this at the > expense of far more interesting projects. Every time I put some effort > in someone sa

Re: [REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864

2011-01-10 Thread Andy Walls
On Sat, 2011-01-08 at 19:45 +0100, Lawrence Rust wrote: > On Sat, 2011-01-08 at 09:22 -0500, Andy Walls wrote: > Thanks for the info on the PVR-150. It largely confirmed what I had > surmised - that the two cards disagree about serial audio data format. > Before my patch, th

Maybe I'll hack on lirc_zilog.c this coming weekend (Re: Enable IR on hdpvr)

2011-01-10 Thread Andy Walls
On Mon, 2011-01-10 at 01:05 -0500, Jarod Wilson wrote: > On Jan 9, 2011, at 7:36 PM, Jason Gauthier wrote: > There's a bit more to it than just the one line change. Here's the patch we're > carrying in the Fedora kernels to enable it: > > http://wilsonet.com/jarod/lirc_misc/hdpvr-ir/hdpvr-ir-enab

Re: Enable IR on hdpvr

2011-01-10 Thread Andy Walls
On Mon, 2011-01-10 at 01:05 -0500, Jarod Wilson wrote: > On Jan 9, 2011, at 7:36 PM, Jason Gauthier wrote: > Janne, I've heard many success stories w/the hdpvr IR lately, and almost no > reports > of lockups, so I'm thinking a firmware update may have helped out here, and > thus, > maybe its tim

Re: user accesses in ivtv-fileops.c:ivtv_v4l2_write ?

2011-01-08 Thread Andy Walls
On Sun, 2011-01-09 at 00:34 +, Dr. David Alan Gilbert wrote: > Hi Andy, > It looks like we missed something in that copy from user > patch from the end of last year: > > +void ivtv_write_vbi_from_user(struct ivtv *itv, > + const struct v4l2_sliced_vbi_data __user

Re: [PATCH 11/32] v4l/cx18: update workqueue usage

2011-01-08 Thread Andy Walls
m > memory, allocate the workqueue with alloc_ordered_workqueue() without > WQ_MEM_RECLAIM. > > Signed-off-by: Tejun Heo > Cc: Andy Walls > Cc: linux-media@vger.kernel.org > --- > Only compile tested. Please feel free to take it into the subsystem > tree or simply ack - I&

Re: zilog and IR

2011-01-08 Thread Andy Walls
On Sat, 2011-01-08 at 10:44 -0500, Jason Gauthier wrote: > Andy, > >Firstly, I apologize for reaching out to you directly. The list could have answered this, so I adding the Cc:. BTW, I normally ignore direct emails asking for free support, as the N-to-1 free support problem is too costly fo

Re: [REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864

2011-01-08 Thread Andy Walls
On Sat, 2011-01-08 at 13:09 +0100, Lawrence Rust wrote: > On Mon, 2011-01-03 at 17:34 -0500, Andy Walls wrote: > > On Sun, 2011-01-02 at 23:00 -0500, Eric Sharkey wrote: > > > On Fri, Dec 31, 2010 at 7:55 PM, Andy Walls > > > wrote: > > > > Mauro, >

Re: [RFC/PATCH v7 01/12] media: Media device node support

2011-01-06 Thread Andy Walls
Yeah well, lame-o default email client on my Android phone. -Andy Greg KH wrote: > > >A: No. >Q: Should I include quotations after my reply? > >http://daringfireball.net/2007/07/on_top > >On Thu, Jan 06, 2011 at 07:24:27PM -0500, Andy Walls wrote: >> Why, yes, th

Re: [RFC/PATCH v7 01/12] media: Media device node support

2011-01-06 Thread Andy Walls
Why, yes, there is a standard: http://pubs.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_03.html A somewhat verbose description of the errnos is in section 2.3. -Andy Hans Verkuil wrote: >On Thursday, January 06, 2011 23:19:12 Greg KH wrote: > > > >> > > > +static ssize_t media_read

Re: [RFC] Cropping and scaling with subdev pad-level operations

2011-01-06 Thread Andy Walls
On Thu, 2011-01-06 at 16:33 +0100, Laurent Pinchart wrote: > Hi everybody, > > I ran into an issue when implementing cropping and scaling on the OMAP3 ISP > resizer sub-device using the pad-level operations. As nobody seems to be > happy > with the V4L2 crop ioctls, I thought I would ask for co

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-05 Thread Andy Walls
On Wed, 2011-01-05 at 20:02 -0200, Mauro Carvalho Chehab wrote: > Em 05-01-2011 19:51, Jean Delvare escreveu: > > Hi Mauro, > > > > On Wed, 05 Jan 2011 15:34:28 -0200, Mauro Carvalho Chehab wrote: > >> Hi Jean, > >> > >> Thanks for your acks for patches 1 and 2. I've already applied the patches >

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-05 Thread Andy Walls
On Wed, 2011-01-05 at 15:45 +0100, Jean Delvare wrote: > Hi Andy, > > On Tue, 28 Dec 2010 20:49:50 -0500, Andy Walls wrote: > > Remove use of deprecated struct i2c_adapter.id field. In the process, > > perform different detection of the HD PVR's Z8 IR microcontr

Re: [PATCH 1/3] hdpvr: Add I2C and ir-kdb-i2c registration of the Zilog Z8 IR chip

2011-01-05 Thread Andy Walls
On Wed, 2011-01-05 at 13:50 +0100, Jean Delvare wrote: > On Tue, 28 Dec 2010 20:46:13 -0500, Andy Walls wrote: > > > > Add I2C registration of the Zilog Z8F0811 IR microcontroller for either > > lirc_zilog or ir-kbd-i2c to use. This is a required step in removing > &

Re: [PATCH 11/32] v4l/cx18: update workqueue usage

2011-01-04 Thread Andy Walls
On Tue, 2011-01-04 at 09:36 +0100, Tejun Heo wrote: > Hello, > > On Mon, Jan 03, 2011 at 07:54:56PM -0500, Andy Walls wrote: > > 2. To prevent work items being handled by keventd/n from being delayed > > too long, as the deferred work in question can involve a bit o

Re: [REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864

2011-01-04 Thread Andy Walls
On Tue, 2011-01-04 at 08:10 +0100, Hans Verkuil wrote: > On Monday, January 03, 2011 23:34:16 Andy Walls wrote: > > On Sun, 2011-01-02 at 23:00 -0500, Eric Sharkey wrote: > > > On Fri, Dec 31, 2010 at 7:55 PM, Andy Walls > > > wrote: > > > > Mauro, >

Re: [PATCH 11/32] v4l/cx18: update workqueue usage

2011-01-03 Thread Andy Walls
m > memory, allocate the workqueue with alloc_ordered_workqueue() without > WQ_MEM_RECLAIM. > > Signed-off-by: Tejun Heo > Cc: Andy Walls > Cc: linux-media@vger.kernel.org Tejun, I have a question about cmwq, but to ask it, I need to give the context. The non-system out_work_queue

Re: Summary of REGRESSIONS which are being ignored?! (Re: Summary of the pending patches up to Dec, 31 (26 patches))

2011-01-03 Thread Andy Walls
On Mon, 2011-01-03 at 09:49 -0200, Mauro Carvalho Chehab wrote: > Em 02-01-2011 17:30, Andy Walls escreveu: > > I don't see this patch on it's way upstream: > > > > https://patchwork.kernel.org/patch/376612/ (Sent on 5 Dec 2010) > > http://www.spinics.net/li

Re: [REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864

2011-01-03 Thread Andy Walls
On Sun, 2011-01-02 at 23:00 -0500, Eric Sharkey wrote: > On Fri, Dec 31, 2010 at 7:55 PM, Andy Walls wrote: > > Mauro, > > > > Please revert at least the wm8775.c portion of commit > > fcb9757333df37cf4a7feccef7ef6f5300643864: > > > > http://git.kernel.org

Summary of REGRESSIONS which are being ignored?! (Re: Summary of the pending patches up to Dec, 31 (26 patches))

2011-01-02 Thread Andy Walls
On Fri, 2010-12-31 at 10:41 -0200, Mauro Carvalho Chehab wrote: > Dear Developers, > > I'm enclosing the current list of patches that I have on my queue. I did > an effort to apply a large amount of patches during the past two weeks, in > order to be ready for the 2.6.38 merge window, expected to

Re: [PATCH 14/18] cx25840: Fix subdev registration in cx25840-core.c

2011-01-01 Thread Andy Walls
Igor, The proper fix is here: https://patchwork.kernel.org/patch/376612/ So, NAK on your particular patch. Mauro, I do not see the above patch at linux next. And I couldn't find it in your kernel.org tree. What is its status? This fixes a regression that is known to break cx23885 hardware

[REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864

2010-12-31 Thread Andy Walls
Mauro, Please revert at least the wm8775.c portion of commit fcb9757333df37cf4a7feccef7ef6f5300643864: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fcb9757333df37cf4a7feccef7ef6f5300643864 It completely trashes baseband line-in audio for PVR-150 cards, and like

Adaptec AVC-2410 remote codes

2010-12-31 Thread Andy Walls
Mauro, Here is the lirc config file for the Adaptec AVC-2410: http://lirc.git.sourceforge.net/git/gitweb.cgi?p=lirc/lirc;a=blob;f=remotes/adaptec/lircd.conf.AVC-2410;h=3f6c5f08c8fef187d6015f4c1abe930464aa0d78;hb=HEAD The 16 bit button codes are obviously in a command:command' data payload like s

Re: [PATCH 11/15]drivers:media:video:cx18:cx23418.h Typo change diable to disable.

2010-12-31 Thread Andy Walls
On Thu, 2010-12-30 at 15:08 -0800, Justin P. Mattock wrote: > The below patch fixes a typo "diable" to "disable". Please let me know if > this > is correct or not. ^^ What, else could it be? The "diablo" chroma spatial filter type

Re: [PATCH 3/4] [media] ivtv: Add Adaptec Remote Controller

2010-12-30 Thread Andy Walls
On Thu, 2010-12-30 at 11:30 -0200, Mauro Carvalho Chehab wrote: > Em 30-12-2010 10:36, Andy Walls escreveu: > Thanks for the review. Version 3 of the patch enclosed. Still one little mistake that matters, otherwise it looks good. See below... > commit 8576bd14361ec75c91ddfb49cc2df38

Re: [PATCH 3/4] [media] ivtv: Add Adaptec Remote Controller

2010-12-30 Thread Andy Walls
On Thu, 2010-12-30 at 11:29 -0200, Mauro Carvalho Chehab wrote: > Em 30-12-2010 10:46, Andy Walls escreveu: > > On Thu, 2010-12-30 at 09:45 -0200, Mauro Carvalho Chehab wrote: > > > > > > > >> As we'll remove lirc_i2c from kernel, move the getkey code

Re: [PATCH v2] [media] ivtv: Add Adaptec Remote Controller

2010-12-30 Thread Andy Walls
On Thu, 2010-12-30 at 11:05 -0200, Mauro Carvalho Chehab wrote: > >From f4b19dd8ac2d15666975f262cc1bdf461d48e687 Mon Sep 17 00:00:00 2001 > From: Mauro Carvalho Chehab > Date: Thu, 30 Dec 2010 09:31:10 -0200 > Subject: [PATCH] [media] ivtv: Add Adaptec Remote Controller > > lirc-i2c implements a

Re: [PATCH 3/4] [media] ivtv: Add Adaptec Remote Controller

2010-12-30 Thread Andy Walls
On Thu, 2010-12-30 at 09:45 -0200, Mauro Carvalho Chehab wrote: > As we'll remove lirc_i2c from kernel, move the getkey code to ivtv driver, and > use it for AVC2410. > > Signed-off-by: Mauro Carvalho Chehab > > diff --git a/drivers/media/video/ivtv/ivtv-i2c.c > b/drivers/media/video/ivtv/iv

Re: [PATCH 3/4] [media] ivtv: Add Adaptec Remote Controller

2010-12-30 Thread Andy Walls
On Thu, 2010-12-30 at 09:45 -0200, Mauro Carvalho Chehab wrote: > lirc-i2c implements a get key logic for the Adaptec Remote > Controller, at address 0x6b. The only driver that seems to have > an Adaptec device is ivtv: > > $ git grep -i adaptec drivers/media > drivers/media/video/cs53l32a.c: * cs

Re: [PATCH 2/3] ir-kbd-i2c: Add HD PVR IR Rx support to ir-kbd-i2c

2010-12-29 Thread Andy Walls
On Wed, 2010-12-29 at 09:12 -0200, Mauro Carvalho Chehab wrote: > Em 28-12-2010 23:47, Andy Walls escreveu: > > > > Add HD PVR IR Rx support to ir-kbd-i2c > > Hmm... I know nothing about the hardware designs used on hd-pvr, but > it seems wrong to have both lirc-zilog an

Re: [PATCH 1/3] hdpvr: Add I2C and ir-kdb-i2c registration of the Zilog Z8 IR chip

2010-12-29 Thread Andy Walls
On Wed, 2010-12-29 at 09:08 -0200, Mauro Carvalho Chehab wrote: > Em 28-12-2010 23:46, Andy Walls escreveu: > > > > Add I2C registration of the Zilog Z8F0811 IR microcontroller for either > > lirc_zilog or ir-kbd-i2c to use. This is a required step in removing > &

[PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2010-12-28 Thread Andy Walls
ff-by: Andy Walls --- drivers/staging/lirc/lirc_zilog.c | 47 1 files changed, 31 insertions(+), 16 deletions(-) diff --git a/drivers/staging/lirc/lirc_zilog.c b/drivers/staging/lirc/lirc_zilog.c index 52be6de..ad29bb1 100644 --- a/drivers/staging/lirc/lirc_zi

[PATCH 2/3] ir-kbd-i2c: Add HD PVR IR Rx support to ir-kbd-i2c

2010-12-28 Thread Andy Walls
Add HD PVR IR Rx support to ir-kbd-i2c Signed-off-by: Andy Walls --- drivers/media/video/ir-kbd-i2c.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/ir-kbd-i2c.c b/drivers/media/video/ir-kbd-i2c.c index dd54c3d..c87b6bc 100644 --- a/drivers/media

[PATCH 1/3] hdpvr: Add I2C and ir-kdb-i2c registration of the Zilog Z8 IR chip

2010-12-28 Thread Andy Walls
Add I2C registration of the Zilog Z8F0811 IR microcontroller for either lirc_zilog or ir-kbd-i2c to use. This is a required step in removing lirc_zilog's use of the deprecated struct i2c_adapter.id field. Signed-off-by: Andy Walls --- drivers/media/video/hdpvr/hdpvr-core.c |5 +++ dr

Re: [PATCH 0/8] Fix V4L/DVB/RC warnings

2010-12-28 Thread Andy Walls
On Tue, 2010-12-28 at 12:45 -0200, Mauro Carvalho Chehab wrote: > Em 28-12-2010 12:14, Andy Walls escreveu: > > On Tue, 2010-12-28 at 01:12 -0200, Mauro Carvalho Chehab wrote: > >> Em 27-12-2010 21:55, Andy Walls escreveu: > >>> I have hardware for lirc_zilo

Re: [PATCH 0/8] Fix V4L/DVB/RC warnings

2010-12-28 Thread Andy Walls
On Tue, 2010-12-28 at 01:12 -0200, Mauro Carvalho Chehab wrote: > Em 27-12-2010 21:55, Andy Walls escreveu: > > I have hardware for lirc_zilog. I can look later this week. > > That would be great! It shouldn't be hard to fix up the lirc_zilog.c use of adap->id but it may

Re: [PATCH 0/8] Fix V4L/DVB/RC warnings

2010-12-27 Thread Andy Walls
I have hardware for lirc_zilog. I can look later this week. I also have hardware that lirc_i2c handles but not all the hardware it handles. IIRC lirc_i2c is very much like ir-kbd-i2c, so do we need it anymore? I'm not able to check for myself at the moment. Regards, Andy Mauro Carvalho Cheha

[RFC/PATCH] v4l2-ctrls: eliminate lockdep false alarms for struct v4l2_ctrl_handler.lock

2010-12-23 Thread Andy Walls
ffa045f490] cx2341x:1534:(hdl)->lock irq_context: 0 [a04fbc80] wm8775:246:(&state->hdl)->lock [a045f490] cx2341x:1534:(hdl)->lock Signed-off-by: Andy Walls diff --git a/drivers/media/video/v4l2-ctrls.c b/drivers/media/video/v4l2-ctrls.c index 9d2502c..8b7de

Re: smatch report: cx231xx: incorrect check in cx231xx_write_i2c_data()

2010-12-23 Thread Andy Walls
On Thu, 2010-12-23 at 19:43 +0300, Dan Carpenter wrote: > Hi, > > I was doing an audit and I came across this. > > drivers/media/video/cx231xx/cx231xx-core.c +1644 cx231xx_write_i2c_data(14) > warn: 'saddr_len' is non-zero. Did you mean 'saddr' > > 1642 if (saddr_len == 0) > 1

[GIT PULL for 2.6.38] ivtv and cx18 fixes

2010-12-23 Thread Andy Walls
Fix a merge conflict with v4l2_i2c_new_subdev_board changes (2010-12-11 09:07:52 -0200) are available in the git repository at: ssh://linuxtv.org/git/awalls/media_tree.git ivtv-cx18-for-38 Andy Walls (4): ivtv, cx18: Make ioremap failure messages more useful for users cx18: Only alloc

Re: [GIT PULL FOR 2.6.37] uvcvideo: BKL removal

2010-12-23 Thread Andy Walls
On Thu, 2010-12-23 at 10:02 +0100, Laurent Pinchart wrote: > Hi Hans, > > On Monday 20 December 2010 14:09:40 Hans Verkuil wrote: > > On Monday, December 20, 2010 13:48:51 Laurent Pinchart wrote: > > > > > > What if the application wants to change the resolution during capture ? > > > It will have

Re: Power frequency detection.

2010-12-19 Thread Andy Walls
On Sun, 2010-12-19 at 18:13 -0600, Theodore Kilgore wrote: > > On Sun, 19 Dec 2010, Andy Walls wrote: > > The Software for our Sakar branded Jeilin camera was a little smarter. > > Oh. So _you_ had a Sakar branded camera. This was one of the things that > causes problems r

Re: Power frequency detection.

2010-12-19 Thread Andy Walls
On Sun, 2010-12-19 at 18:21 -0600, Theodore Kilgore wrote: > If the controls are locked while the workqueue is doing the streaming, > then probably that does fix the problem? Most likely, that is the simplest > thing to do. Drivers are allowed to return -EBUSY per the V4L2 spec. http://linuxt

[RESEND] [PATCH for 2.6.37] cx23885, cx25840: Provide IR Rx timeout event reports

2010-12-19 Thread Andy Walls
: Andy Walls --- drivers/media/video/cx23885/cx23888-ir.c | 12 drivers/media/video/cx25840/cx25840-ir.c | 12 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/media/video/cx23885/cx23888-ir.c b/drivers/media/video/cx23885/cx23888-ir.c index

[RESEND] [PATCH for 2.6.37 REGRESSION] cx25840: Prevent device probe failure due to volume control ERANGE error

2010-12-19 Thread Andy Walls
driver has an unusual mapping from register values to v4l2 volume control values. Enforce the mapping limits, so that the default volume control setting does not fall out of bounds to prevent the cx25840 module device probe from failing. Signed-off-by: Andy Walls Cc: Hans Verkuil Cc: Mauro Carvalho

Re: Power frequency detection.

2010-12-19 Thread Andy Walls
On Sun, 2010-12-19 at 17:00 -0500, Andy Walls wrote: > On Sun, 2010-12-19 at 14:51 -0600, Theodore Kilgore wrote: Just a few more details... > So I might not be able to provide too much help. I have 2 ideas for you > coming from the perspective of me being a USB idiot: > >

Re: Power frequency detection.

2010-12-19 Thread Andy Walls
On Sun, 2010-12-19 at 14:51 -0600, Theodore Kilgore wrote: > > On Sun, 19 Dec 2010, Andy Walls wrote: > > > Theodore, > > > > Aside from detect measurment of the power line, isn't a camera the best > > sort of sensor for this measurment anyway? &

Re: Power frequency detection.

2010-12-19 Thread Andy Walls
On Sun, 2010-12-19 at 13:21 -0500, Andy Walls wrote: > Theodore, Gah. I need to learn how to type or wear my glasses more often. > Aside from detect measurment of the power line, isn't a camera the ^ direct measurement > best sort of s

Re: Power frequency detection.

2010-12-19 Thread Andy Walls
Theodore, Aside from detect measurment of the power line, isn't a camera the best sort of sensor for this measurment anyway? Just compute the average image luminosity over several frames and look for (10 Hz ?) periodic variation (beats), indicating a mismatch. Sure you could just ask the user,

Re: TeVii S470 dvb-s2 issues - 2nd try ,)

2010-12-18 Thread Andy Walls
On Sat, 2010-12-18 at 14:40 +0100, Boris Cuber wrote: > Am Friday 17 December 2010 schrieben Sie: > > On Fri, 2010-12-17 at 12:19 +0100, Boris Cuber wrote: > > > Hello linux-media people! > > > > > > I have to problems with my dvb card ("TeVii S470"). I already > > > filed 2 bug reports some time

Re: Volunteers needed: BKL removal: replace .ioctl by .unlocked_ioctl

2010-12-18 Thread Andy Walls
ere I do not know who can do the conversion. > If you can tackle one or more of those, please respond. Unfortunately, those > are among the hardest to convert :-( > Driver list: > > saa7146 (Hans Verkuil) > mem2mem_testdev (Pawel Osciak or Marek Szyprowski) > cx23885 (St

Re: tm6000 and IR

2010-12-18 Thread Andy Walls
On Fri, 2010-12-17 at 22:24 -0200, Mauro Carvalho Chehab wrote: > Despite all discussions, we didn't reach an agreement yet. > > There are some points to consider whatever solution we do: > > 1) A keycode table should be able to work with a generic raw decoder. So, on > all > drivers, the bit

Re: [PATCH] [media] cx231xx: Fix inverted bits for RC on PV Hybrid

2010-12-17 Thread Andy Walls
On Fri, 2010-12-17 at 15:22 -0200, Mauro Carvalho Chehab wrote: > At Pixelview SBTVD Hybrid, the bits sent by the IR are inverted. Due to that, > the existing keytables produce wrong codes. > > Signed-off-by: Mauro Carvalho Chehab > > diff --git a/drivers/media/video/cx231xx/cx231xx-input.c > b

Re: TeVii S470 dvb-s2 issues - 2nd try ,)

2010-12-17 Thread Andy Walls
On Fri, 2010-12-17 at 12:19 +0100, Boris Cuber wrote: > Hello linux-media people! > > I have to problems with my dvb card ("TeVii S470"). I already > filed 2 bug reports some time ago, but no one seems to have > noticed/read them, so i'm trying it here now. > If you need a "full" dmesg, then pleas

Re: Simple request : mini-pcie analog TV capture card

2010-12-14 Thread Andy Walls
Fernando, You should send questions to linux-media@vger.kernel.org as the video4linux list is mostly dead. The Yuan MPC718 is supported by the cx18 driver, but it is mini-pci (not mini-pcie) and has hardware mpeg2 encoding, which may be overkill for your needs. Regards, Andy Fernando Laudare

Re: [RFC/PATCH 03/19] cx18: Use the control framework.

2010-12-13 Thread Andy Walls
On Mon, 2010-12-13 at 08:32 +0100, Hans Verkuil wrote: > On Sunday, December 12, 2010 19:46:33 Andy Walls wrote: Hi Hans, > > 1. Why set the vol step to 655, when the volume will actaully step at > > increments of 512? > > The goal of the exercise is to convert to the

Re: [RFC/PATCH 03/19] cx18: Use the control framework.

2010-12-12 Thread Andy Walls
now? I'd prefer a working device without user controls in case of user control init failure. Regards, Andy Hans Verkuil wrote: >On Sunday, December 12, 2010 19:09:36 Andy Walls wrote: >> Hans, >> >> This has at least the same two problems the change for cx25840 had

Re: [RFC/PATCH 03/19] cx18: Use the control framework.

2010-12-12 Thread Andy Walls
Hans, This has at least the same two problems the change for cx25840 had: 1. Volume control init should use 65535 not 65335 2. You cannot trust reg 0x8d4 to have a value in it for the default volume that won't give an ERANGE error when you go to init the volume control. Subdev probe will fail

Re: user accesses in ivtv-fileops.c:ivtv_v4l2_write ?

2010-12-11 Thread Andy Walls
_write_vbi_from_user(), that uses copy_from_user() to read the VBI data provided via user buffers. This should resolve an sparse build warning reported by Dave Gilbert. Reported-by: Dr. David Alan Gilbert Signed-off-by: Andy Walls diff --git a/drivers/media/video/ivtv/ivtv-fileops.c b/d

Re: [stable] [RESEND][PATCH for stable 2.6.36 REGRESSION] cx25840: Prevent device probe failure due to volume control ERANGE error]

2010-12-10 Thread Andy Walls
On Fri, 2010-12-10 at 10:16 -0800, Greg KH wrote: > On Fri, Dec 10, 2010 at 08:19:57AM -0500, Andy Walls wrote: > > Resending, since this didn't appear to make its way into in 2.6.36.2. > > That's because it's not in Linus's tree, right? I have to wait for that

[RESEND][PATCH for stable 2.6.36 REGRESSION] cx25840: Prevent device probe failure due to volume control ERANGE error]

2010-12-10 Thread Andy Walls
Andy The volume control scale in the cx25840 driver has an unusual mapping from register values to v4l2 volume control values. Enforce the mapping limits, so that the default volume control setting does not fall out of bounds to prevent the cx25840 module device probe from failing. Signed-off-by:

Re: Hauppauge HVR-2200 analog

2010-12-07 Thread Andy Walls
On Tue, 2010-12-07 at 12:04 +0100, Julian Scheel wrote: > Hi, > > is there any progress on adding analog support to the HVR-2200? > It seems support for the used chipsets in general is already in the kernel? It appears to be in the media_tree.git repository on the staging/for_v2.6.37-rc1 branch:

[PATCH for 2.6.37] cx23885, cx25840: Provide IR Rx timeout event reports

2010-12-05 Thread Andy Walls
Provide CX2388[578] IR receive timeout (RTO) reports in the final space raw event sent up the chain to the raw IR pulse decoders. This should allow the lirc decoder to actually measure the inter-transmission gap properly. Signed-off-by: Andy Walls --- drivers/media/video/cx23885/cx23888-ir.c

Re: [GIT PATCHES for 2.6.38] broken cx25840 probe and CX2388[578] IR receive timeoouts

2010-12-05 Thread Andy Walls
On Sun, 2010-11-28 at 20:06 -0500, Andy Walls wrote: > Mauro, > > Please pull the following changes for 2.6.38. Hi Mauro, Please disregard this PULL request. I have sent the cx25840 fix as a patch to the list for both 2.6.36 (stable) and 2.6.37. Regards, Andy > The cx25840 modu

[PATCH for 2.6.37 REGRESSION] cx25840: Prevent device probe failure due to volume control ERANGE error

2010-12-05 Thread Andy Walls
control values. Enforce the mapping limits, so that the default volume control setting does not fall out of bounds to prevent the cx25840 module device probe from failing. Signed-off-by: Andy Walls Cc: Hans Verkuil Cc: Mauro Carvalho Chehab --- drivers/media/video/cx25840/cx25840-core.c | 19

[PATCH for stable 2.6.36 REGRESSION] cx25840: Prevent device probe failure due to volume control ERANGE error

2010-12-05 Thread Andy Walls
: Andy Walls Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Cc: sta...@kernel.org --- drivers/media/video/cx25840/cx25840-core.c | 19 +-- 1 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840

Re: [RFC v6 2/9] Documentation:DocBook:v4l: Update the controls.xml for TI FM driver

2010-12-03 Thread Andy Walls
> Em 03-12-2010 10:50, manjunatha_ha...@ti.com escreveu: > > From: Manjunatha Halli > > > > Added entries for following 2 new CID's which are added for TI FM > > driver: > > - V4L2_CID_RSSI_THRESHOLD > > - V4L2_CID_TUNE_AF > > > > Signed-off-by: Manjunatha Halli > > --- > > Documentation/DocBo

Re: [PATCH] media: rc: ir-lirc-codec: fix potential integer overflow

2010-12-02 Thread Andy Walls
64 bit value / 4 = 62 bit value, right? Jarod Wilson wrote: >On Thu, Dec 02, 2010 at 07:51:26AM +0300, Dan Carpenter wrote: >> On Fri, Nov 26, 2010 at 08:06:35PM +0300, Vasiliy Kulikov wrote: >> >count = n / sizeof(int); >> > - if (count > LIRCBUF_SIZE || count % 2 == 0) >> > + if (count

Re: Unsafe to reinsert HVR-1850 kernel modules?

2010-12-02 Thread Andy Walls
On Wed, 2010-12-01 at 21:52 -0800, David Liontooth wrote: > On 11/29/2010 04:38 AM, Andy Walls wrote: > > On Sun, 2010-11-28 at 23:49 -0800, David Liontooth wrote: > > For a quick band-aid, use "pci=nomsi" on your kernel command line, and > > reboot to reset th

Re: [PATCH 3/7] v4l: videobuf2: add vmalloc allocator

2010-12-01 Thread Andy Walls
On Tue, 2010-11-30 at 21:57 +0100, Laurent Pinchart wrote: > Hi Marek, > > On Tuesday 30 November 2010 11:39:41 Marek Szyprowski wrote: > > On Monday, November 29, 2010 10:51 AM Laurent Pinchart wrote: > > > On Friday 19 November 2010 16:55:40 Marek Szyprowski wrote: > > > > From: Pawel Osciak >

Re: user accesses in ivtv-fileops.c:ivtv_v4l2_write ?

2010-11-29 Thread Andy Walls
Dr. David Alan Gilbert wrote: > Hi, > Sparse pointed me at the following line in ivtv-fileops.c's ivtv_v4l2_write: > > ivtv_write_vbi(itv, (const struct v4l2_sliced_vbi_data > *)user_buf, elems); > > Now user_buf is a parameter: > const char __user *user_buf, > > so that is

Re: Unsafe to reinsert HVR-1850 kernel modules?

2010-11-29 Thread Andy Walls
On Sun, 2010-11-28 at 23:49 -0800, David Liontooth wrote: > My HVR-1850 card occasionally jams, meaning it still tunes (according > to gnutv), but no mpeg stream comes through. > > This heals on reboot, but I figured it should also heal on module > reinsertion. > > However, when I remove the C

[GIT PATCHES for 2.6.38] broken cx25840 probe and CX2388[578] IR receive timeoouts

2010-11-28 Thread Andy Walls
emove unnecessary lock around atomic clear_bit" (2010-11-26 18:41:02 -0200) are available in the git repository at: ssh://linuxtv.org/git/awalls/media_tree.git ir-38 Andy Walls (2): cx25840: Prevent device probe failure due to volume control ERANGE error cx23885, cx25840: Provid

Re: [PATCH] ir-nec-decoder: fix extended NEC scancodes

2010-11-26 Thread Andy Walls
You might want to check the handling against this NEC datasheet http://www.datasheetcatalog.org/datasheet/nec/UPD6122G-002.pdf The datasheet calls the address bytes "custom code" (high byte apparently) and "custom code'" (low byte apparently) with both bytes sent lsb first. It appears the high

Re: [RFC/PATCH v6 02/12] media: Media device

2010-11-25 Thread Andy Walls
The signedness of char is ambiguous for 8 bit data, which is why an API would normally use u8 (or s8, I guess). Since this is known to be character data, I would think char would be fine. I am assuming C compilers would never assume multibyte "char"s. Regards, Andy Laurent Pinchart wrote: >

Re: What should poll() return when a device is unregistered ? (was "media: Media device node support")

2010-11-22 Thread Andy Walls
On Mon, 2010-11-22 at 17:19 +0100, Laurent Pinchart wrote: > Hi Andy, > > On Monday 22 November 2010 13:51:37 Andy Walls wrote: > > On Mon, 2010-11-22 at 12:36 +0100, Hans Verkuil wrote: > > > On Monday, November 22, 2010 11:41:27 Laurent Pinchart wrote: > > &g

Re: What should poll() return when a device is unregistered ? (was "media: Media device node support")

2010-11-22 Thread Andy Walls
On Mon, 2010-11-22 at 12:36 +0100, Hans Verkuil wrote: > On Monday, November 22, 2010 11:41:27 Laurent Pinchart wrote: > > Hi Hans, > > > > On Monday 22 November 2010 10:08:06 Hans Verkuil wrote: > > > On Monday, November 22, 2010 00:35:54 Laurent Pinchart wrote: > > > > Hi Jonathan, > > > This d

Re: [linux-dvb] cx23885 crashes with TeVii S470

2010-11-18 Thread Andy Walls
Try reverting the change that enabled MSI in cx23885. R, Andy Hans Houwaard wrote: >My issue was that the only PCIe 1X slot shared an IRQ with the onboard Sound >card and that caused all kinds of problems. Also I had to power off my machine >if I ever had problems with the DVB cards. They wou

Re: An article on the media controller

2010-11-16 Thread Andy Walls
On Tue, 2010-11-16 at 15:18 -0700, Jonathan Corbet wrote: > I've just spent a fair while looking through the September posting of > the media controller code (is there a more recent version?). The > result is a high-level review which interested people can read here: > > http://lwn.net/Subs

Re: [RFCv2 PATCH 15/15] cx18: convert to unlocked_ioctl.

2010-11-16 Thread Andy Walls
On Tue, 2010-11-16 at 22:56 +0100, Hans Verkuil wrote: > Signed-off-by: Hans Verkuil > --- > drivers/media/video/cx18/cx18-streams.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/cx18/cx18-streams.c > b/drivers/media/video/cx18/cx18-streams.c

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Andy Walls
On Tue, 2010-11-16 at 19:38 +0100, Hans Verkuil wrote: > On Tuesday, November 16, 2010 17:49:05 Hans Verkuil wrote: > > On Tuesday, November 16, 2010 17:01:36 Arnd Bergmann wrote: > > > On Tuesday 16 November 2010, Hans Verkuil wrote: > > > > > I think there is a misunderstanding. One V4L device (e

Re: Hauppauge WinTV MiniStick IR in 2.6.36 - [PATCH]

2010-11-15 Thread Andy Walls
On Mon, 2010-11-15 at 16:09 +0100, Richard Zidlicky wrote: > On Mon, Nov 15, 2010 at 07:35:06AM -0500, Andy Walls wrote: > > On Mon, 2010-11-15 at 12:27 +0100, Richard Zidlicky wrote: > > > http://git.linuxtv.org/v4l-utils.git?a=tree;f=utils/keytable;h=e599a8b5288517fc7fe58d96f

Re: Hauppauge WinTV MiniStick IR in 2.6.36 - [PATCH]

2010-11-15 Thread Andy Walls
On Mon, 2010-11-15 at 12:27 +0100, Richard Zidlicky wrote: > Hi, > > for some users (thats at least one user in Italy and me) the following is > required: > > --- linux-2.6.36/drivers/media/dvb/siano/sms-cards.c.rz 2010-11-15 > 11:16:56.0 +0100 > +++ linux-2.6.36/drivers/media/dvb/siano

Re: new_build on ubuntu (dvbdev.c)

2010-11-14 Thread Andy Walls
On Sun, 2010-11-14 at 20:26 +1100, Vincent McIntyre wrote: > On 11/14/10, Andy Walls wrote: > > On Sun, 2010-11-14 at 09:08 +1100, Vincent McIntyre wrote: > > noop_llseek() is a newer kernl function that provided a trivial llseek() > > implmenetation for drivers that don&#

Re: new_build on ubuntu (dvbdev.c)

2010-11-13 Thread Andy Walls
On Sun, 2010-11-14 at 09:08 +1100, Vincent McIntyre wrote: > Hi, > I'm trying to build on 2.6.32 (ubuntu lucid i386). > > I followed the instructions for building from git[1] Shouldn't you be building from: http://git.linuxtv.org/mchehab/new_build.git for backward compat builds? (I'm no

Re: Bounty for the first Open Source driver for Kinect

2010-11-10 Thread Andy Walls
IFixit has a tear down mentioning all the chips and a reference design http://www.ifixit.com/Teardown/Microsoft-Kinect-Teardown/4066/1 There's two camera sensors, an ir illuminator, four microphones, a motor, and apparently a built in usb hub. It supposedly consumes more power than a standard u

RE: Format of /dev/video0 data for HVR-4000 frame grabber

2010-11-09 Thread Andy Walls
r/greyscale into JPEG/PNG/GIF or similar? > >Cheers, > >Mike > >> -Original Message- >> From: Andy Walls [mailto:awa...@md.metrocast.net] >> Sent: 09 November 2010 12:29 >> To: Michael PARKER >> Cc: Daniel Glöckner; linux-media@vger.kernel.org >>

RE: Format of /dev/video0 data for HVR-4000 frame grabber

2010-11-09 Thread Andy Walls
On Tue, 2010-11-09 at 10:34 +0100, Michael PARKER wrote: > Daniel, > > Many thanks for your mail. Please excuse the naivety of my questions - > I'm a h/w guy and a nube to the s/w world. > Do you know which of these is the default format or how to determine > the format I'm seeing coming out of

Re: [PATCH] bttv driver memory corruption

2010-10-30 Thread Andy Walls
On Sun, 2010-10-31 at 01:40 +0200, Daniel Glöckner wrote: > On Mon, Oct 25, 2010 at 11:34:40AM -0400, Laurent Birtz wrote: > > I've observed that the poison was corrupted at some random pages, but > > always in the first four bytes. The value of those bytes is 0x23232323. > > This byte sequence oft

<    1   2   3   4   5   6   7   8   9   10   >