d type casts to what they should have been
in order to avoid the warnings. e0f80d8d62f5 ("[media] mtk-vcodec: fix two
compiler
warnings") fixed some of the problems that were introduced at the same time, but
missed two others.
Signed-off-by: Arnd Bergmann
---
drivers/media/platform/
from integer of
different size [-Werror=int-to-pointer-cast]
struct venc_vpu_inst *vpu = (struct venc_vpu_inst *)msg->venc_inst;
This rearranges the format strings and type casts to what they should have been
in order to avoid the warnings.
Signed-off-by: Arnd Bergmann
---
drivers/media/platform
onica.c: In function 'sd_stopN':
media/usb/gspca/konica.c:246:13: error: unused variable 'sd'
[-Werror=unused-variable]
This converts the #if check into an if(), to let the compiler
see where the variables are used, at the expense of slightly
enlarging the gspca_dev structu
onica.c: In function 'sd_stopN':
media/usb/gspca/konica.c:246:13: error: unused variable 'sd'
[-Werror=unused-variable]
This annotates the variables as __maybe_unused, to let the compiler
know that they are declared intentionally.
Signed-off-by: Arnd Bergmann
Fixes: ee186fd96a5f (
On Friday, July 1, 2016 5:22:32 PM CEST Hans Verkuil wrote:
> > diff --git a/drivers/media/platform/vivid/Kconfig
> > b/drivers/media/platform/vivid/Kconfig
> > index 8e6918c5c87c..8e31146d079a 100644
> > --- a/drivers/media/platform/vivid/Kconfig
> > +++ b/drivers/media/platform/vivid/Kconfig
> >
On Friday, July 1, 2016 4:35:09 PM CEST Hans Verkuil wrote:
> On 07/01/2016 01:19 PM, Arnd Bergmann wrote:
> > The linux/cec.h header file contains empty inline definitions for
> > a subset of the API for the case in which CEC is not enabled,
> > however we have driver that ca
> MEDIA_SUPPORT (just as is done for the media controller code).
> - Add a note to staging that this should be changed once the cec framework
> is moved out of staging.
>
> Signed-off-by: Hans Verkuil
> Reported-by: Arnd Bergmann
>
I see no further build failures with
r=implicit-function-declaration]
drivers/media/i2c/adv7604.c: In function 'adv76xx_probe':
drivers/media/i2c/adv7604.c:3482:20: error: implicit declaration of function
'cec_allocate_adapter' [-Werror=implicit-function-declaration]
This adds stubs for the remaining interface
> MEDIA_SUPPORT (just as is done for the media controller code).
> - Add a note to staging that this should be changed once the cec framework
> is moved out of staging.
>
> Signed-off-by: Hans Verkuil
> Reported-by: Arnd Bergmann
This looks ok, but I'll give it som
ion `vsp1_probe':
:(.text+0xdef44): undefined reference to `rcar_fcp_get'
We already have a conditional dependency on FCP that requires
it for ARM64, so for all others we just have to prevent setting
RENESAS_VSP1=y when RENESAS_FCP=m by extending the FCP dependency.
Signed-off
:12: error: 'vsp1_pm_runtime_suspend'
defined but not used [-Werror=unused-function]
This removes the existing #ifdef and instead marks all four
PM functions as __maybe_unused.
Signed-off-by: Arnd Bergmann
Fixes: 1e6af546ee66 ("[media] v4l: vsp1: Implement runtime PM support")
---
drivers/media
p, to reduce the noise during randconfig
builds.
Signed-off-by: Arnd Bergmann
Fixes: ca684386e6e2 ("[media] cec: add HDMI CEC framework (api)")
---
drivers/staging/media/cec/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/cec/Kconfig
b/drivers/staging/me
304): undefined reference to `rc_register_device'
This adds an explicit dependency to avoid this case. We still
allow building when CONFIG_RC_CORE is disabled completely,
as the driver has checks for this case itself.
Signed-off-by: Arnd Bergmann
---
drivers/staging/media/cec/Kconfig | 1
ng without
having to introduce an extra #ifdef.
Signed-off-by: Arnd Bergmann
---
drivers/staging/media/s5p-cec/s5p_cec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/s5p-cec/s5p_cec.c
b/drivers/staging/media/s5p-cec/s5p_cec.c
index f90b7c4e48fe..78333
p_c')
All of them are trivial to fix without changing the behavior of the
driver, as "static const" is interpreted the same as "const static",
and VPFE_RSZ_INTP_CUBIC is defined as zero, so the initializations
are not really needed.
Signed-off-by: Arnd Bergmann
---
dr
code.
Fortunately, the command code includes the size of the structure,
so the difference gets handled automatically.
Signed-off-by: Arnd Bergmann
---
This patch was originally part of a longer series, along with other patches
that we still have to rewrite for the generic ioctl interface, but the
code.
Fortunately, the command code includes the size of the structure,
so the difference gets handled automatically.
Signed-off-by: Arnd Bergmann
---
This patch was originally part of a longer series, along with other patches
that we still have to rewrite for the generic ioctl interface, but the
tonic time base to avoid both the race and the overflow.
Signed-off-by: Arnd Bergmann
---
I originally submitted this last year along with some other patches that
did not make it and that we have to write again from scratch at some point,
but for all I know, this one could just get applied indepen
On Monday, June 13, 2016 1:47:13 PM CEST Richard Cochran wrote:
> * Kernel Space
>
> 1. Providing frames with a future transmit time. For normal sockets,
>this can be in the CMESG data. For mmap'ed buffers, we will need a
>new format. (I think Arnd is working on a new layout.)
>
After
in the discussion
(fs/gfs2/dir.c) showed up again in the mainline kernel, Linus
asked me to send the whole thing again.
Signed-off-by: Arnd Bergmann
Cc: Andrzej Hajda
Cc: Andrew Morton
Link: https://lkml.org/lkml/2016/1/7/363
Link: https://lkml.org/lkml/2016/5/27/486
---
drivers/acpi/acpi_dbg.c
inline kernels, if at all.
The solution is really easy: this patch changes the Makefile to
link all files into one module. As discussed previously, the
driver has never before used successfully as a loadable module,
but there is no reason to prevent that configuration.
Signed-off-by: Arnd Bergman
the pointer to NULL in case of a lookup failure to fix the issue.
>
> Signed-off-by: Javier Martinez Canillas
>
>
Acked-by: Arnd Bergmann
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Monday 02 May 2016 13:27:54 Javier Martinez Canillas wrote:
> Failing to get the struct s5p_mfc_pm .clock is a non-fatal error so the
> clock field can have a errno pointer value. But s5p_mfc_final_pm() only
> checks if .clock is not NULL before attempting to unprepare and put it.
>
> This lead
#x27;t get
into that situation.
Signed-off-by: Arnd Bergmann
Fixes: 26a7ed9c1819 ("[media] exynos-gsc: remove an always false condition")
---
drivers/media/platform/exynos-gsc/gsc-core.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/ex
tig_cleanup_ctx"
[Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
Specifically, we do look in the samples directory for users of
symbols, but not the Documentation directory.
This solves the build problem by moving the connector sample into
the same directory as the other samples.
Sig
re the location that the variable
is used in.
Signed-off-by: Arnd Bergmann
Fixes: 76e543382bd4 ("staging: media: omap1: Switch to devm_ioremap_resource")
---
drivers/staging/media/omap1/omap1_camera.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media
:32: error: 'stk3000p_dib3000p_config' defined
but not used
This moves the existing #ifdef a few lines up to correctly cover
all the conditional data structures, which gets rid of the warning.
Signed-off-by: Arnd Bergmann
---
drivers/media/usb/dvb-usb/dibusb-common.c | 4 ++--
1 file changed
core/v4l2-mc.c:37:55: error: unused variable 'dtv_demod'
[-Werror=unused-variable]
This removes the unused variable as well.
Signed-off-by: Arnd Bergmann
Fixes: 840f5b0572ea ("media: au0828 disable tuner to demod link in
au0828_media_device_register()")
---
drivers/media/v4l2-
al-compare]
client->adapter->nr == client->adapter->nr) {
^~
This was introduced in a slighly incorrect conversion, and it's
clear that the comparison was meant to compare the iterator
to the current subdev instead, as we do in the line above.
Signed-o
;
drivers/media/built-in.o: In function `cobalt_flash_remove':
:(.text+0xb8bb4): undefined reference to `mtd_device_unregister'
:(.text+0xb8bbe): undefined reference to `map_destroy'
This adds a Kconfig dependency to ensure we can call the API.
Signed-off-by: Arnd Bergmann
---
driver
e.c:262:12: error: 'au0828_enable_source' defined
but not used [-Werror=unused-function]
media/usb/au0828/au0828-core.c:412:13: error: 'au0828_disable_source' defined
but not used [-Werror=unused-function]
This moves the #ifdef so the entire definitions are hidden in this case.
On Thursday 03 March 2016 14:29:53 Mauro Carvalho Chehab wrote:
> Em Sun, 28 Feb 2016 21:51:48 +0100
> Arnd Bergmann escreveu:
>
> > In a configuration that supports all DVB drivers but that disables
> > V4L2 or builds it as a loadable module, we get link errors because
>
'(' before '{'
token
Signed-off-by: Arnd Bergmann
Fixes: a77bf7048add ("v4l2-mc.h: Add stubs for the V4L2 PM/pipeline routines")
---
include/media/v4l2-mc.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/media/v4l2-mc.h b
On Thursday 03 March 2016 21:40:23 Krzysztof Kozlowski wrote:
> >> select MFD_SYSCON
> >> diff --git a/drivers/media/platform/exynos4-is/Kconfig
> >> b/drivers/media/platform/exynos4-is/Kconfig
> >> index 57d42c6172c5..c4317b99d257 100644
> >> --- a/drivers/media/platform/exynos4-is/Kconfi
On Thursday 03 March 2016 13:27:59 Geert Uytterhoeven wrote:
> On Thu, Mar 3, 2016 at 11:55 AM, Arnd Bergmann wrote:
> > On Thursday 03 March 2016 17:03:34 Krzysztof Kozlowski wrote:
> >> index 0da40e2e4280..5c530b6b125d 100644
> >> --- a/drivers/rtc/Kconfig
>
On Thursday 03 March 2016 21:00:57 Krzysztof Kozlowski wrote:
> >
> > Not user visible.
>
> Hmmm... you are right (here and in other patches) but why am I getting
> all these errors:
> warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X
> && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWM
On Thursday 03 March 2016 17:03:40 Krzysztof Kozlowski wrote:
> index 8c20ebbc049c..f759a778d606 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -45,6 +45,7 @@ config USB_XHCI_PLATFORM
>
> config USB_XHCI_MTK
> tristate "xHCI support for Mediatek MT65xx"
> +
On Thursday 03 March 2016 17:03:37 Krzysztof Kozlowski wrote:
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 0a6408a39c66..0f34846ae80d 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -141,6 +141,7 @@ config POWER_RESET_XGENE
>
On Thursday 03 March 2016 17:03:36 Krzysztof Kozlowski wrote:
> The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet
> direct dependencies.
>
> Signed-off-by: Krzysztof Kozlowski
> ---
> drivers/net/ethernet/hisilicon/Kconfig | 1 +
> drivers/net/ethernet/stmicro/stmmac/Kcon
On Thursday 03 March 2016 17:03:35 Krzysztof Kozlowski wrote:
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index 201f5c296a95..e5931e434fa2 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -79,6 +79,7 @@ config VIDEO_OMAP3
On Thursday 03 March 2016 17:03:34 Krzysztof Kozlowski wrote:
> index 0da40e2e4280..5c530b6b125d 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1302,6 +1302,7 @@ config RTC_DRV_AT91RM9200
> config RTC_DRV_AT91SAM9
> tristate "AT91SAM9 RTT as RTC"
> depends on
On Thursday 03 March 2016 17:03:28 Krzysztof Kozlowski wrote:
> index c77f214c9466..7fbf96bff280 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -290,6 +290,7 @@ config LPC18XX_DMAMUX
> bool "NXP LPC18xx/43xx DMA MUX for PL080"
> depends on ARCH_LPC18XX || COMPIL
On Thursday 03 March 2016 17:03:41 Krzysztof Kozlowski wrote:
> Since commit c89c0114955a ("mfd: syscon: Set regmap max_register in
> of_syscon_register") the syscon uses ioremap so it fails on COMPILE_TEST
> without HAS_IOMEM:
>
> drivers/mfd/syscon.c: In function ‘of_syscon_register’:
> drivers/
On Thursday 03 March 2016 17:03:30 Krzysztof Kozlowski wrote:
> config ST_IRQCHIP
> bool
> select REGMAP
> + depends on HAS_IOMEM# For MFD_SYSCON
> select MFD_SYSCON
> help
> Enables SysCfg Controlled IRQs on STi based platforms.
>
Not user vis
On Thursday 03 March 2016 17:03:27 Krzysztof Kozlowski wrote:
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index c346be650892..5927944b46e0 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -239,6 +239,7 @@ config ATMEL_PIT
>
> c
On Thursday 03 March 2016 17:03:31 Krzysztof Kozlowski wrote:
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -225,6 +225,7 @@ config PHY_MT65XX_USB3
> config PHY_HI6220_USB
> tristate "hi6220 USB PHY support"
> depends on (ARCH_HISI && ARM64) || COMPILE_TEST
> +
On Thursday 03 March 2016 17:03:29 Krzysztof Kozlowski wrote:
> diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig
> index 73a401662853..5ab2d51dc147 100644
> --- a/drivers/hwspinlock/Kconfig
> +++ b/drivers/hwspinlock/Kconfig
> @@ -21,6 +21,7 @@ config HWSPINLOCK_OMAP
> config H
we can simply avoid referencing
the structure using an IS_ENABLED() check, and drop all the #ifdef
to avoid all warnings.
Signed-off-by: Arnd Bergmann
---
drivers/media/platform/omap3isp/isp.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/media/platform/omap3
meone rand into
the problem on x86.
There are no dependencies between the patches, so I'd appreciate
subsystem maintainers to put them directly into their git trees.
Arnd
Arnd Bergmann (14):
pinctrl: at91: use __maybe_unused to hide pm functions
irqchip: st: use __maybe_unus
v.c:264:12: warning: 'dvb_create_media_entity' defined but not
used [-Wunused-function]
This moves the #ifdef inside of the two functions to the
outside, to avoid the two warnings.
Signed-off-by: Arnd Bergmann
diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.
On Thursday 17 December 2015 12:58:06 Mauro Carvalho Chehab wrote:
> > Can you clarify how the 'topology_version' is used here? Is that
> > the version of the structure layout that decides how we interpret the
> > rest, or is it a number that is runtime dependent?
>
> No, topology_version is just
On Thursday 17 December 2015 10:45:56 Mauro Carvalho Chehab wrote:
> If I understood well, he's proposing to do is:
>
> struct media_v2_topology {
> __u64 topology_version;
>
> __u32 num_entities;
> __u32 num_interfaces;
> __u32 num_pads;
> __u32 num_links;
akefile to
link all files into one module.
Signed-off-by: Arnd Bergmann
---
diff --git a/drivers/staging/media/davinci_vpfe/Makefile
b/drivers/staging/media/davinci_vpfe/Makefile
index c64515c644cd..3019c9ecd548 100644
--- a/drivers/staging/media/davinci_vpfe/Makefile
+++ b/drivers/stagin
On Tuesday 08 December 2015 17:23:40 Mauro Carvalho Chehab wrote:
> > > +
> > > +struct media_v2_topology {
> > > + __u32 topology_version;
> > > +
> > > + __u32 num_entities;
> > > + struct media_v2_entity *entities;
> >
> > The kernel seems to be moving to using __u64 instead of pointers i
idual Kconfig symbols and they
can only be built as loadable modules if V4L2 or any other of the
dependencies itself is a module.
Signed-off-by: Arnd Bergmann
diff --git a/drivers/media/platform/exynos4-is/Kconfig
b/drivers/media/platform/exynos4-is/Kconfig
index 40423c6c5324..57d42c6172c5 1
line up, as it was creating a 80
character warning.
Build tested it. Also tested it with sparse.
Signed-off-by: Tapasweni Pathak
Reviewed-by: Arnd Bergmann
Signed-off-by: Arnd Bergmann
diff --git a/drivers/staging/media/lirc/lirc_parallel.c
b/drivers/staging/media/lirc/lirc_parallel.c
ind
o_ms() call, it has been
changed to hold nanoseconds by using ktime_to_ns().
Build tested it. Tested with sparse too.
Signed-off-by: Tapasweni Pathak
Reviewed-by: Arnd Bergmann
Signed-off-by: Arnd Bergmann
diff --git a/drivers/staging/media/lirc/lirc_sasem.c
b/drivers/staging/media/lirc/lirc_
igned-off-by: Tapasweni Pathak
Reviewed-by: Arnd Bergmann
Signed-off-by: Arnd Bergmann
---
These three patches were still in my backlog and part of linux-next
but never made it into mainline. Please apply to the v4l tree.
diff --git a/drivers/staging/media/lirc/lirc_serial.c
b/drivers/staging/
On Friday 20 November 2015 14:52:03 Peter Ujfalusi wrote:
>
> >> For legacy the filter function is pretty much needed to handle the
> >> differences
> >> between the platforms as not all of them does the filtering in a same way.
> >> So
> >> the first type of map would be feasible IMHO.
> >
> >
On Friday 20 November 2015 12:25:06 Peter Ujfalusi wrote:
> On 11/19/2015 01:25 PM, Arnd Bergmann wrote:
> >> dma_request_channel(mask); /* memcpy. etc, non slave mostly */
> >>
> >> Not sure how to name this as reusing existing (good, descriptive) function
> >
7; [-Werror=implicit-function-declaration]
This adds explicit Kconfig dependencies so we don't see the
driver options if I2C is turned off.
Signed-off-by: Arnd Bergmann
---
This is a very rare randconfig error, normally I2C is enabled for some reason
already.
diff --git a/drivers/media/pl
On Thursday 19 November 2015 12:34:22 Peter Ujfalusi wrote:
>
> I think we can go with a single API, but I don't really like that:
> dma_request_channel(dev, name, *mask, fn, fn_param);
>
> This would cover all current uses being legacy, DT/ACPI, compat, etc:
> dma_request_channel(NULL, NULL, &ma
On Wednesday 18 November 2015 17:43:04 Andy Shevchenko wrote:
> >
> > I assume that the sst-firmware.c case is a mistake, it should just use a
> > plain DMA_SLAVE and not DMA_MEMCPY.
>
> Other way around.
>
Ok, I see. In that case I guess it also shouldn't call
dmaengine_slave_config(), right? I
On Wednesday 18 November 2015 16:41:35 Peter Ujfalusi wrote:
> On 11/18/2015 04:29 PM, Arnd Bergmann wrote:
> > On Wednesday 18 November 2015 16:21:26 Peter Ujfalusi wrote:
> >> 2. non slave channel requests, where only the functionality matters, like
> >> memcpy, interl
On Wednesday 18 November 2015 16:21:26 Peter Ujfalusi wrote:
> 2. non slave channel requests, where only the functionality matters, like
> memcpy, interleaved, memset, etc.
> We could have a simple:
> dma_request_channel(mask);
>
> But looking at the drivers using dmaengine legacy dma_request_chan
On Tuesday 17 November 2015 17:17:39 Arnd Bergmann wrote:
> The dibusb_read_eeprom_byte function is defined in dibusb-common.c,
> but that file is not compiled for CONFIG_DVB_USB_DIBUSB_MB as it
> is for the other driver using the common functions, so we can
> get a link error:
>
c5124): undefined reference to `dibusb_read_eeprom_byte'
(.text+0x2c5134): undefined reference to `dibusb_read_eeprom_byte'
This changes the Makefile to treat the file like all the others
in this directory, and enforce building dvb-usb-dibusb-common.o
as a dependency.
Signed-off-by: Arnd
On Tuesday 17 November 2015 11:43:27 Anton Bondarenko wrote:
> On 17.11.2015 10:23, Arnd Bergmann wrote:
> > On Tuesday 17 November 2015 07:15:59 Mauro Carvalho Chehab wrote:
> >> Now that media has its own subdirectory inside platform_data,
> >> let's move the h
On Tuesday 17 November 2015 07:15:59 Mauro Carvalho Chehab wrote:
> Now that media has its own subdirectory inside platform_data,
> let's move the headers that are already there to such subdir.
>
>
Acked-by: Arnd Bergmann
--
To unsubscribe from this list: send the line "u
obile_csi2.h include/media/sh_vou.h \
> include/media/si476x.h include/media/soc_mediabus.h \
> include/media/tea575x.h include/media/drv-intf/
>
Acked-by: Arnd Bergmann
I probably would have left soc_mediabus.h where it is, but I can
see there are reasons to move it.
On Monday 16 November 2015 09:00:45 Mauro Carvalho Chehab wrote:
> Let's not mix platform_data headers with the core headers. Instead, let's
> create a subdir at linux/platform_data and move the headers to that
> common place, adding it to MAINTAINERS.
>
Acked-by: Arnd Ber
On Friday 13 November 2015 17:13:41 Mauro Carvalho Chehab wrote:
> Em Wed, 11 Nov 2015 21:26:31 +0100
> Arnd Bergmann escreveu:
>
> include/media/{ => drv-intf}/cx2341x.h | 0
> include/media/{ => drv-intf}/cx25840.h | 0
> inc
On Wednesday 11 November 2015 15:14:48 Mauro Carvalho Chehab wrote:
> rename include/media/{ => platform}/exynos-fimc.h (100%)
> rename include/media/{ => platform}/mmp-camera.h (100%)
> rename include/media/{ => platform}/omap1_camera.h (100%)
> rename include/media/{ => platform}/omap4iss.h (
On Monday 09 November 2015 22:09:26 Laurent Pinchart wrote:
> Hi Arnd,
>
> Thank you for the patch.
>
> On Thursday 17 September 2015 23:19:40 Arnd Bergmann wrote:
> > C libraries with 64-bit time_t use an incompatible format for
> > struct omap3isp_stat_data. This
time_t
> which uses a 64-bit seconds representation and is 2038 safe. This patch
> uses ktime_get_real() preserving the use of wall-clock time in the
> original code.
>
> Signed-off-by: Tina Ruchandani
Reviewed-by: Arnd Bergmann
I've applied it to my y2038 tree for the mom
On Thursday 05 November 2015 10:05:44 Hans Verkuil wrote:
> On 11/05/15 09:36, Arnd Bergmann wrote:
> > On Thursday 05 November 2015 08:41:11 Hans Verkuil wrote:
> >> Hi Arnd,
> >>
> >> We're redesigning the timestamp handling in the video4linux subsystem
On Thursday 05 November 2015 08:41:11 Hans Verkuil wrote:
> Hi Arnd,
>
> We're redesigning the timestamp handling in the video4linux subsystem moving
> away
> from struct timeval to a single timestamp in ns (what ktime_get_ns() gives
> us).
> But I was wondering: ktime_get_ns() gives a s64, so s
On Friday 16 October 2015 23:45:46 Javier Martinez Canillas wrote:
>
> On Fri, Oct 16, 2015 at 10:32 PM, Arnd Bergmann wrote:
> > The 'static inline' version of lnbh25_attach() has an incorrect
> > prototype which results in a build error when
> > CONFIG_DVB_L
t_try_format' [-Werror=implicit-function-declaration]
This adds an explicit dependency.
Signed-off-by: Arnd Bergmann
---
Found on ARM randconfig builds
diff --git a/drivers/media/pci/cobalt/Kconfig b/drivers/media/pci/cobalt/Kconfig
index 1f88ccc174da..a7f750520757 100644
--- a/dri
:86: error: unknown type
name 'dvb_frontend'
This changes the code to have the correct prototype.
Signed-off-by: Arnd Bergmann
Fixes: e025273b86fb ("[media] lnbh25: LNBH25 SEC controller driver")
---
Found on ARM randconfig builds
diff --git a/drivers/media/dvb-frontends
*' but argument is of type 'struct horus3a_config *'
media/pci/netup_unidvb/netup_unidvb_core.c:417:275: error: too many arguments
to function '__a'
This changes the code to have the correct prototype.
Signed-off-by: Arnd Bergmann
Fixes: a5d32b358254 ("[media] horus3a: Sony Hor
0-ocotp.c:(.text+0x2dc190): undefined reference to
`vb2_dma_contig_cleanup_ctx'
This changes the dependency to VIDEOBUF2_DMA_CONTIG instead.
Signed-off-by: Arnd Bergmann
Fixes: 57af3ad59d95 ("[media] sh-vou: convert to vb2")
---
Found on ARM randconfig tests
diff --git a/driver
On Monday 05 October 2015 12:24:40 Sylwester Nawrocki wrote:
> On 03/10/15 00:25, Arnd Bergmann wrote:
> > On Thursday 01 October 2015 19:17:27 Mauro Carvalho Chehab wrote:
> >> > diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c
> >> > b/drivers/medi
On Thursday 01 October 2015 19:17:28 Mauro Carvalho Chehab wrote:
> @@ -1084,10 +1084,10 @@ static void load_dmem_segment(struct c8sectpfei *fei,
> Elf32_Phdr *phdr,
> seg_num, phdr->p_paddr, phdr->p_filesz,
> dst, phdr->p_memsz);
>
> - memcpy((void __iomem
On Thursday 01 October 2015 19:17:27 Mauro Carvalho Chehab wrote:
> diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c
> b/drivers/media/platform/exynos4-is/mipi-csis.c
> index d74e1bec3d86..4b85105dc159 100644
> --- a/drivers/media/platform/exynos4-is/mipi-csis.c
> +++ b/drivers/media/pla
On Friday 18 September 2015 11:49:50 Hans Verkuil wrote:
> *If* the conversion takes place only in v4l2-ioctl.c, then it makes sense
> have these structs + ioctls moved to v4l2-ioctl.h.
Ok.
> I noticed that v4l2-compat-ioctl32.c wasn't changed. Is that right? I have
> unfortunately no time to do
On Friday 18 September 2015 11:52:28 Hans Verkuil wrote:
> On 09/18/15 11:43, Arnd Bergmann wrote:
> > On Friday 18 September 2015 11:27:40 Hans Verkuil wrote:
> >> Ah, OK. Got it.
> >>
> >> I think this is dependent on the upcoming media workshop next
On Friday 18 September 2015 11:27:40 Hans Verkuil wrote:
> Ah, OK. Got it.
>
> I think this is dependent on the upcoming media workshop next month. If we
> decide to redesign v4l2_buffer anyway, then we can avoid timeval completely.
> And the only place where we would need to convert it in the com
On Friday 18 September 2015 09:18:45 Hans Verkuil wrote:
> Hi Arnd,
>
> Thanks once again for working on this! Unfortunately, this approach won't
> work, see my comments below.
>
> BTW, I would expect to see compile errors when compiling for 32 bit. Did
> you try that?
I only tested on 32-bit, b
On Friday 18 September 2015 10:05:06 Hans Verkuil wrote:
> On 09/17/15 23:19, Arnd Bergmann wrote:
> > The v4l2 API uses a 'struct timeval' to communicate time stamps to user
> > space. This is broken on 32-bit architectures as soon as we have a C library
> > that
_timestamp() is more consistent
and reduces the amount of code duplication, and most importantly
simplifies the following changes.
If desired, this patch can easily be split up into one patch per
driver.
Signed-off-by: Arnd Bergmann
---
drivers/media/pci/bt8xx/bttv-driver.c| 5 +---
that adds API compatiblity for both
32-bit and 64-bit time_t. This patch should have no impact on generated
code in either user space or kernel.
Signed-off-by: Arnd Bergmann
---
drivers/media/pci/bt8xx/bttv-driver.c | 2 +-
drivers/media/pci/meye/meye.h | 2 +-
d
The systime function uses struct timespec, which we want to stop
using in the kernel because it overflows in 2038. Fortunately,
this use in dibx000_common is in a function that is never called,
so we can just remove it.
Signed-off-by: Arnd Bergmann
---
drivers/media/dvb-frontends
code.
Fortunately, the command code includes the size of the structure,
so the difference gets handled automatically.
Signed-off-by: Arnd Bergmann
---
drivers/media/platform/omap3isp/isph3a_aewb.c | 2 ++
drivers/media/platform/omap3isp/isph3a_af.c | 2 ++
drivers/media/platform/omap3isp
tonic time base to avoid both the race and the overflow.
Signed-off-by: Arnd Bergmann
---
drivers/media/dvb-core/demux.h | 2 +-
drivers/media/dvb-core/dmxdev.c| 2 +-
drivers/media/dvb-core/dvb_demux.c | 17 ++---
drivers/media/dvb-core/dvb_demux.h | 4 ++--
drivers/medi
rs makes sure
the structure is well-defined and contains no padding that might
leak kernel stack data.
We now need the handling for VIDIOC_DQEVENT32 on both 32-bit
and 64-bit architectures, so the handling for that is moved from
v4l2-compat-ioctl32.c to v4l2-ioctl.c and v4l2-subdev.c.
Signed-off-b
and
remain compatible with all existing user space binaries when time_t
gets changed.
If anybody ever starts using this field, they have to make sure not
to use 1970 based seconds in there, as those overflow in 2038.
Signed-off-by: Arnd Bergmann
---
include/uapi/linux/dvb/video.h | 3 ++-
1 f
the 32-bit compat handling on 64-bit
architectures, but those also have to modify other fields of
the structure. For now, I leave that compat code alone, as it
handles the normal case (32-bit compat_time_t) correctly, this
has to be done as a follow-up.
Signed-off-by: Arnd Bergmann
---
drivers
driver to use the normal v4l2_get_timestamp()
function like all other drivers.
Signed-off-by: Arnd Bergmann
---
drivers/media/platform/exynos4-is/fimc-capture.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/media/platform/exynos4-is/fimc-capture.c
b/drivers
have not added support for the new binary layout of v4l2_timeval
to v4l2-compat-ioctl32 yet, that is something I can do when the
basic approach has been agreed on.
Arnd
Arnd Bergmann (9):
[media] dvb: use ktime_t for internal timeout
[media] dvb: remove unused systime() function
[media
401 - 500 of 791 matches
Mail list logo
