coding the v4l2_get_timestamp() call.
Cc: Laurent Pinchart
Cc: Sakari Ailus
Signed-off-by: Arnd Bergmann
---
I submitted this one in November and asked again in January,
still waiting for a review so it can be applied.
---
drivers/media/platform/omap3isp/isph3a_aewb.c | 2 ++
drivers/media/platfor
On Thu, May 3, 2018 at 8:56 AM, Sakari Ailus wrote:
> On Wed, Apr 25, 2018 at 11:30:10PM +0200, Arnd Bergmann wrote:
>> @@ -165,7 +167,14 @@ struct omap3isp_h3a_aewb_config {
>> * @config_counter: Number of the configuration associated with the data.
>> */
>>
meone rand into
the problem on x86.
There are no dependencies between the patches, so I'd appreciate
subsystem maintainers to put them directly into their git trees.
Arnd
Arnd Bergmann (14):
pinctrl: at91: use __maybe_unused to hide pm functions
irqchip: st: use __maybe_unus
we can simply avoid referencing
the structure using an IS_ENABLED() check, and drop all the #ifdef
to avoid all warnings.
Signed-off-by: Arnd Bergmann
---
drivers/media/platform/omap3isp/isp.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/media/platform/omap3
On Thursday 03 March 2016 17:03:31 Krzysztof Kozlowski wrote:
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -225,6 +225,7 @@ config PHY_MT65XX_USB3
> config PHY_HI6220_USB
> tristate "hi6220 USB PHY support"
> depends on (ARCH_HISI && ARM64) || COMPILE_TEST
> +
On Thursday 03 March 2016 17:03:29 Krzysztof Kozlowski wrote:
> diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig
> index 73a401662853..5ab2d51dc147 100644
> --- a/drivers/hwspinlock/Kconfig
> +++ b/drivers/hwspinlock/Kconfig
> @@ -21,6 +21,7 @@ config HWSPINLOCK_OMAP
> config H
On Thursday 03 March 2016 17:03:28 Krzysztof Kozlowski wrote:
> index c77f214c9466..7fbf96bff280 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -290,6 +290,7 @@ config LPC18XX_DMAMUX
> bool "NXP LPC18xx/43xx DMA MUX for PL080"
> depends on ARCH_LPC18XX || COMPIL
On Thursday 03 March 2016 17:03:41 Krzysztof Kozlowski wrote:
> Since commit c89c0114955a ("mfd: syscon: Set regmap max_register in
> of_syscon_register") the syscon uses ioremap so it fails on COMPILE_TEST
> without HAS_IOMEM:
>
> drivers/mfd/syscon.c: In function ‘of_syscon_register’:
> drivers/
On Thursday 03 March 2016 17:03:30 Krzysztof Kozlowski wrote:
> config ST_IRQCHIP
> bool
> select REGMAP
> + depends on HAS_IOMEM# For MFD_SYSCON
> select MFD_SYSCON
> help
> Enables SysCfg Controlled IRQs on STi based platforms.
>
Not user vis
On Thursday 03 March 2016 17:03:27 Krzysztof Kozlowski wrote:
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index c346be650892..5927944b46e0 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -239,6 +239,7 @@ config ATMEL_PIT
>
> c
On Thursday 03 March 2016 17:03:35 Krzysztof Kozlowski wrote:
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index 201f5c296a95..e5931e434fa2 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -79,6 +79,7 @@ config VIDEO_OMAP3
On Thursday 03 March 2016 17:03:34 Krzysztof Kozlowski wrote:
> index 0da40e2e4280..5c530b6b125d 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1302,6 +1302,7 @@ config RTC_DRV_AT91RM9200
> config RTC_DRV_AT91SAM9
> tristate "AT91SAM9 RTT as RTC"
> depends on
On Thursday 03 March 2016 17:03:36 Krzysztof Kozlowski wrote:
> The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet
> direct dependencies.
>
> Signed-off-by: Krzysztof Kozlowski
> ---
> drivers/net/ethernet/hisilicon/Kconfig | 1 +
> drivers/net/ethernet/stmicro/stmmac/Kcon
On Thursday 03 March 2016 17:03:37 Krzysztof Kozlowski wrote:
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 0a6408a39c66..0f34846ae80d 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -141,6 +141,7 @@ config POWER_RESET_XGENE
>
On Thursday 03 March 2016 17:03:40 Krzysztof Kozlowski wrote:
> index 8c20ebbc049c..f759a778d606 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -45,6 +45,7 @@ config USB_XHCI_PLATFORM
>
> config USB_XHCI_MTK
> tristate "xHCI support for Mediatek MT65xx"
> +
On Thursday 03 March 2016 21:00:57 Krzysztof Kozlowski wrote:
> >
> > Not user visible.
>
> Hmmm... you are right (here and in other patches) but why am I getting
> all these errors:
> warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X
> && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWM
On Thursday 03 March 2016 13:27:59 Geert Uytterhoeven wrote:
> On Thu, Mar 3, 2016 at 11:55 AM, Arnd Bergmann wrote:
> > On Thursday 03 March 2016 17:03:34 Krzysztof Kozlowski wrote:
> >> index 0da40e2e4280..5c530b6b125d 100644
> >> --- a/drivers/rtc/Kconfig
>
On Thursday 03 March 2016 21:40:23 Krzysztof Kozlowski wrote:
> >> select MFD_SYSCON
> >> diff --git a/drivers/media/platform/exynos4-is/Kconfig
> >> b/drivers/media/platform/exynos4-is/Kconfig
> >> index 57d42c6172c5..c4317b99d257 100644
> >> --- a/drivers/media/platform/exynos4-is/Kconfi
'(' before '{'
token
Signed-off-by: Arnd Bergmann
Fixes: a77bf7048add ("v4l2-mc.h: Add stubs for the V4L2 PM/pipeline routines")
---
include/media/v4l2-mc.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/media/v4l2-mc.h b
On Thursday 03 March 2016 14:29:53 Mauro Carvalho Chehab wrote:
> Em Sun, 28 Feb 2016 21:51:48 +0100
> Arnd Bergmann escreveu:
>
> > In a configuration that supports all DVB drivers but that disables
> > V4L2 or builds it as a loadable module, we get link errors because
>
e.c:262:12: error: 'au0828_enable_source' defined
but not used [-Werror=unused-function]
media/usb/au0828/au0828-core.c:412:13: error: 'au0828_disable_source' defined
but not used [-Werror=unused-function]
This moves the #ifdef so the entire definitions are hidden in this case.
;
drivers/media/built-in.o: In function `cobalt_flash_remove':
:(.text+0xb8bb4): undefined reference to `mtd_device_unregister'
:(.text+0xb8bbe): undefined reference to `map_destroy'
This adds a Kconfig dependency to ensure we can call the API.
Signed-off-by: Arnd Bergmann
---
driver
core/v4l2-mc.c:37:55: error: unused variable 'dtv_demod'
[-Werror=unused-variable]
This removes the unused variable as well.
Signed-off-by: Arnd Bergmann
Fixes: 840f5b0572ea ("media: au0828 disable tuner to demod link in
au0828_media_device_register()")
---
drivers/media/v4l2-
al-compare]
client->adapter->nr == client->adapter->nr) {
^~
This was introduced in a slighly incorrect conversion, and it's
clear that the comparison was meant to compare the iterator
to the current subdev instead, as we do in the line above.
Signed-o
:32: error: 'stk3000p_dib3000p_config' defined
but not used
This moves the existing #ifdef a few lines up to correctly cover
all the conditional data structures, which gets rid of the warning.
Signed-off-by: Arnd Bergmann
---
drivers/media/usb/dvb-usb/dibusb-common.c | 4 ++--
1 file changed
re the location that the variable
is used in.
Signed-off-by: Arnd Bergmann
Fixes: 76e543382bd4 ("staging: media: omap1: Switch to devm_ioremap_resource")
---
drivers/staging/media/omap1/omap1_camera.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media
tig_cleanup_ctx"
[Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
Specifically, we do look in the samples directory for users of
symbols, but not the Documentation directory.
This solves the build problem by moving the connector sample into
the same directory as the other samples.
Sig
#x27;t get
into that situation.
Signed-off-by: Arnd Bergmann
Fixes: 26a7ed9c1819 ("[media] exynos-gsc: remove an always false condition")
---
drivers/media/platform/exynos-gsc/gsc-core.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/ex
This one got applied twice, causing a build error with clang:
drivers/media/i2c/et8ek8/et8ek8_driver.c:1499:1: error: redefinition of
'__mod_of__et8ek8_of_table_device_table'
Fixes: 9ae05fd1e791 ("[media] et8ek8: Export OF device ID as module aliases")
Signed-off-by: Arnd Be
On Thu, Jun 8, 2017 at 12:04 PM, Binoy Jayan wrote:
> The semaphore 'cmd_mutex' is used as a simple mutex, so
> it should be written as one. Semaphores are going away in the future.
>
> Signed-off-by: Binoy Jayan
> ---
> @@ -1283,7 +1283,7 @@ static int ngene_load_firm(struct ngene *dev)
>
> st
On Thu, Jun 8, 2017 at 12:04 PM, Binoy Jayan wrote:
> The semaphore 'i2c_switch_mutex' is used as a simple mutex, so
> it should be written as one. Semaphores are going away in the future.
>
> Signed-off-by: Binoy Jayan
This one is obviously correct,
Reviewed-by: Arnd Bergmann
ould be nicer to move the
mutex_lock/unlock() to the caller to avoid repeating the unlock() five
times.
Either way,
Reviewed-by: Arnd Bergmann
On Fri, Jun 9, 2017 at 6:37 AM, Binoy Jayan wrote:
> On 8 June 2017 at 20:40, Arnd Bergmann wrote:
>> On Thu, Jun 8, 2017 at 12:04 PM, Binoy Jayan wrote:
>>> The semaphore 'cmd_mutex' is used as a simple mutex, so
>>> it should be written as one. Se
, by zeroing out the
sensitive data provided by user space. I also fix the type confusion
here. If we think the ioctl has no stable users, we could consider
just removing it instead.
Fixes: 5f15fbb68fd7 ("V4L/DVB (12251): v4l: dm644x ccdc module for vpfe capture
driver")
Signed-off-b
On Tue, Jun 13, 2017 at 10:58 AM, Binoy Jayan wrote:
> These are a set of patches [v2] which removes semaphores from ngene.
> These are part of a bigger effort to eliminate unwanted semaphores
> from the linux kernel.
All three
Acked-by: Arnd Bergmann
I already gave an Ack for one
noinline_if_stackbloat,
we can completely avoid this problem.
Signed-off-by: Arnd Bergmann
---
drivers/media/dvb-frontends/ascot2e.c | 3 ++-
drivers/media/dvb-frontends/cxd2841er.c | 4 ++--
drivers/media/dvb-frontends/drx39xyj/drxj.c | 14 +++---
drivers/media/dvb-frontends
than=]
An earlier patch I tried used an open-coded r820t_write_reg()
implementation that may have been more efficent, while this
version simply adds the annotation, which has a lower risk for
regressions.
Signed-off-by: Arnd Bergmann
---
drivers/media/tuners/r820t.c | 4 ++--
1 file changed, 2
simplifies the code to the point where
gcc notices the behavior is correct.
Fixes: ca33784ba494 ("[media] rainshadow-cec: ensure exit_loop is intialized")
Fixes: ea6a69defd3311 ("[media] rainshadow-cec: avoid -Wmaybe-uninitialized
warning")
Cc: Colin Ian King
Signed-off-b
omatically by the remoteproc drivers.
>
> This does solve problems reported with circular Kconfig dependencies for
> Davinci and Keystone remoteproc drivers.
>
> Signed-off-by: Bjorn Andersson
> ---
Looks good to me,
Acked-by: Arnd Bergmann
On Tue, Jun 27, 2017 at 12:13 PM, Sekhar Nori wrote:
> On Tuesday 20 June 2017 06:36 PM, Lad, Prabhakar wrote:
>> Hi Arnd,
>>
>> Thanks for the patch.
>>
>> On Fri, Jun 9, 2017 at 10:36 PM, Arnd Bergmann wrote:
>>> Now that the davinci driver
7;select' statement again, so we only try to enable
those symbols when the drivers will actually get built.
Fixes: 76724b30f222 ("[media] media: venus: enable building with COMPILE_TEST")
Signed-off-by: Arnd Bergmann
---
drivers/media/platform/Kconfig | 4 ++--
1 file changed, 2 ins
ion]
The problem as usual are incorrect #ifdefs, so the easiest fix
is to do away with the #ifdef completely and mark the suspend/resume
handlers as __maybe_unused, which they are.
Fixes: af2c3834c8ca ("[media] media: venus: adding core part and helper
functions")
Signed-off-by: Arn
he memory once it is no longer
needed is probably better anyway.
Fixes: af2c3834c8ca ("[media] media: venus: adding core part and helper
functions")
Signed-off-by: Arnd Bergmann
---
The same problem exists in the drm driver, as of commit 7c65817e6d38
("drm/msm: gpu: Enable zap sha
On Tue, Jun 27, 2017 at 9:39 PM, Stanimir Varbanov
wrote:
> Hi Arnd,
>
> On 27.06.2017 18:02, Arnd Bergmann wrote:
>>
>> In venus_boot(), we pass a pointer to a phys_addr_t
>> into dmam_alloc_coherent, which the compiler warns about:
>>
>> platform/qcom/ve
either a NULL pointer or an error
code to consistently return error pointers when failing.
Fixes: e130291212df ("[media] media: Add i.MX media core driver")
Signed-off-by: Arnd Bergmann
---
I can't reproduce the original warning any more, but this
patch still makes sense by itsel
On Tue, Jun 27, 2017 at 9:45 PM, Stanimir Varbanov
wrote:
> Hi Arnd,
>
> On 27.06.2017 18:02, Arnd Bergmann wrote:
>>
>> If QCOM_MDT_LOADER is enabled, but ARCH_QCOM is not, we run into
>> a build error:
>>
>> ERROR: "qcom_mdt_load" [drivers/medi
d up reverting the removal and fix it differently.
>
> Note: This patch is on top of [1].
>
> [1] https://patchwork.kernel.org/patch/9779385/
Acked-by: Arnd Bergmann
I think it would be good to backport one or both of the patches to
stable kernels, to close the potential risk of someone abusing the
ioctl.
7;select' statement again, so we only try to enable
those symbols when the drivers will actually get built, and explicitly
test for QCOM_MDT_LOADER to be enabled before calling into it.
Fixes: 76724b30f222 ("[media] media: venus: enable building with COMPILE_TEST")
Signed-off
On Wed, Jul 5, 2017 at 12:18 PM, Chunyan Zhang wrote:
> On 4 July 2017 at 18:51, Arnd Bergmann wrote:
>> On Tue, Jul 4, 2017 at 12:15 PM, Chunyan Zhang
> Like I mentioned, SC2342 includes many functions, this patch is only
> adding FM radio function included in SC2342 to the ker
On Thu, Jul 6, 2017 at 10:36 AM, Tomasz Figa wrote:
> On Thu, Jul 6, 2017 at 5:34 PM, Tomasz Figa wrote:
>> On Thu, Jul 6, 2017 at 5:26 PM, Arnd Bergmann wrote:
>>> On Thu, Jul 6, 2017 at 3:44 AM, Tomasz Figa wrote:
>>
>> I'd say that this is something tha
On Thu, Jul 6, 2017 at 3:31 PM, Tomasz Figa wrote:
> On Thu, Jul 6, 2017 at 9:23 PM, Arnd Bergmann wrote:
>> On Thu, Jul 6, 2017 at 10:36 AM, Tomasz Figa wrote:
>>> On Thu, Jul 6, 2017 at 5:34 PM, Tomasz Figa wrote:
>>>
>>> Sorry, I intended to mean:
&
On Thu, Jul 6, 2017 at 3:49 PM, Tomasz Figa wrote:
> On Thu, Jul 6, 2017 at 10:31 PM, Tomasz Figa wrote:
>> On the other hand, if it's strictly about base/dma-mapping, we might
>> not need it indeed. The driver could call iommu-dma helpers directly,
>> without the need to provide its own DMA ops
On Thu, Jul 6, 2017 at 4:06 PM, Tomasz Figa wrote:
> On Thu, Jul 6, 2017 at 11:02 PM, Arnd Bergmann wrote:
>> On Thu, Jul 6, 2017 at 3:49 PM, Tomasz Figa wrote:
>>> On Thu, Jul 6, 2017 at 10:31 PM, Tomasz Figa wrote:
>>
>>>> On the other hand, if it's
bol.
Fixes: 68803ad4522f ("[media] platform: add video-multiplexer subdevice driver")
Cc: Sascha Hauer
Cc: Philipp Zabel
Signed-off-by: Arnd Bergmann
---
Cc: Russell King
Cc: Steve Longerbeam
Cc: Sakari Ailus
Cc: Pavel Machek
---
drivers/media/platform/Kconfig | 2 +-
1 file
d fold the modified patch.
Fixes: 6a1560ecaa8c ("media: v4l: omap_vout: vrfb: Convert to dmaengine")
Signed-off-by: Arnd Bergmann
---
drivers/media/platform/omap/omap_vout_vrfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/omap/omap_vout_vr
to '0' for success to keep the current behavior,
though returning an error would also make sense there.
Fixes: e130291212df ("[media] media: Add i.MX media core driver")
Signed-off-by: Arnd Bergmann
---
v2: fix type mismatch
v3: rework of_parse_subdev() as well.
---
drivers/stagi
On Thu, Jun 29, 2017 at 11:13 AM, Philipp Zabel wrote:
>> @@ -134,23 +134,26 @@ static void csi_idmac_put_ipu_resources(struct
>> csi_priv *priv)
>> static int csi_idmac_get_ipu_resources(struct csi_priv *priv)
>> {
>> int ch_num, ret;
>> + struct ipu_smfc *smfc, *idmac_ch;
>
> This
On Wed, Jul 12, 2017 at 5:41 AM, Linus Torvalds
wrote:
>
> We also have about a bazillion
>
> warning: ‘*’ in boolean context, suggest ‘&&’ instead
>
> warnings in drivers/ata/libata-core.c, all due to a single macro that
> uses a pattern that gcc-7.1.1 doesn't like. The warning looks a bit
>
On Wed, Jul 12, 2017 at 3:10 PM, Greg Kroah-Hartman
wrote:
> On Tue, Jul 11, 2017 at 03:35:15PM -0700, Linus Torvalds wrote:
>> [ Very random list of maintainers and mailing lists, at least
>> partially by number of warnings generated by gcc-7.1.1 that is then
>> correlated with the get_maintainer
upstream, to
help build-test the stable kernels with gcc-7.
Arnd
Arnd Bergmann (14):
[SUBMITTED 20170511] ide: avoid warning for timings calculation
[SUBMITTED 20170511] ata: avoid gcc-7 warning in ata_timing_quantize
[SUBMITTED 20170314] drm/vmwgfx: avoid gcc-7 parentheses warn
file since the start, but it could
make sense to backport this patch to stable to make it build cleanly
with gcc-7.
Fixes: fb1d9738ca05 ("drm/vmwgfx: Add DRM driver for VMware Virtual GPU")
Reviewed-by: Sinclair Yeh
Signed-off-by: Arnd Bergmann
---
Originally submitted on Nov 16, but for so
This slightly rearranges the macro to simplify the code and avoid
the warning at the same time.
Signed-off-by: Arnd Bergmann
---
drivers/ata/libata-core.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
i
q->setup = EZ(t->setup * 1000, T);
This slightly rearranges the macro to simplify the code and avoid
the warning at the same time.
Signed-off-by: Arnd Bergmann
---
drivers/ide/ide-timings.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/i
ol-context]
This replaces the negation of an integer with an equivalent
comparison to zero, which gets rid of the warning.
Signed-off-by: Arnd Bergmann
---
drivers/isdn/isdnloop/isdnloop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/isdn/isdnloop/isdnloop.c b/dr
inds the two to be identical,
but it no longer warns because it doesn't condider the comparison
"tautological" any more.
Signed-off-by: Arnd Bergmann
---
fs/proc/kcore.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/fs/proc/kcore.c b/fs/proc/kco
mean '<' ? [-Werror=int-in-bool-context]
This converts the test to an explicit comparison with zero,
making it clearer to gcc and the reader what is intended.
Fixes: e27c729219ad ("Input: add driver for ADXL345/346 Digital Accelerometers")
Signed-off-by: Arnd Bergmann
---
d
ol-context]
This turns the integer into a boolean expression by comparing it
to zero.
Signed-off-by: Arnd Bergmann
---
arch/x86/math-emu/fpu_emu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/math-emu/fpu_emu.h b/arch/x86/math-emu/fpu_emu.h
index afbc4d805d66..c9c320dcc
evaluates to true [-Werror=tautological-compare]
By introducing a temporary variable, we can tell gcc that this is
intentional.
Signed-off-by: Arnd Bergmann
---
drivers/acpi/processor_thermal.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/processor_t
]
Using an inline function to do the comparison tells the compiler what is
going on even for preprocessed files, and avoids the warning.
Signed-off-by: Arnd Bergmann
---
drivers/sfi/sfi_core.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/sfi/sfi_core.c b
nal code had 'unsigned short' here, but incorrectly got
converted to 'bool'. This reverts the regression and uses a normal
type instead.
Fixes: 29148543c521 ("staging:iio:resolver:ad2s1210 minimal chan spec
conversion.")
Cc: sta...@vger.kernel.org
Signed-off-by: Arnd
boolean context, suggest '&&'
instead [-Werror=int-in-bool-context]
This is easy to avoid by comparing the timeout to zero instead,
making it a boolean expression.
Signed-off-by: Arnd Bergmann
---
include/linux/iopoll.h | 6 --
include/linux/regmap.h | 2 +-
2 files changed, 5 i
al 'return'
statement.
Fixes: 7632b30e4b8b ("drm/nouveau/clk: namespace + nvidia gpu names (no binary
change)")
Signed-off-by: Arnd Bergmann
---
drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/g
e
length, which avoids the warning.
Fixes: a96e4e2ffe43 ("IB/uverbs: New macro to set pointers to NULL if length is
0 in INIT_UDATA()")
Signed-off-by: Arnd Bergmann
---
drivers/infiniband/core/uverbs.h | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/
In case of simple 'if' checks, adding a temporary variable is
usually ok, and sometimes this can be used to propagate or
print an error code, so I do that.
For the 'while' loops, I ended up adding an otherwise useless
comparison with zero, which unfortunately makes the code
On Fri, Jul 14, 2017 at 11:55 AM, Joe Perches wrote:
> On Fri, 2017-07-14 at 11:31 +0200, Arnd Bergmann wrote:
>> When we pass the result of a multiplication as the timeout, we
>> can get a warning:
>>
>> drivers/mmc/host/bcm2835.c:596:149: error: '*' in bool
On Fri, Jul 14, 2017 at 12:08 PM, Joe Perches wrote:
> On Fri, 2017-07-14 at 11:25 +0200, Arnd Bergmann wrote:
>> We test whether a bit is set in a mask here, which is correct
>> but gcc warns about it as it thinks it might be confusing:
>>
>> drivers/isdn/isdnlo
#x27; output
between 4 and 76 bytes into a destination of size 48
We know this is fine as the template name is always "usbvision", so
we can easily avoid the warning by using this as the format string
directly.
Signed-off-by: Arnd Bergmann
---
drivers/media/usb/usbvision/usbvisi
On Fri, Jul 14, 2017 at 2:05 PM, Dan Carpenter wrote:
> Changing:
>
> - if (!frob()) {
> + if (frob() == 0) {
>
> is a totally pointless change. They're both bad, because they're doing
> success testing instead of failure testing, but probably the second one
> is slightly worse.
>
> This warning
On Fri, Jul 14, 2017 at 3:09 PM, Dan Carpenter wrote:
> On Fri, Jul 14, 2017 at 03:55:26PM +0300, Dan Carpenter wrote:
>> I don't agree with it as a static analysis dev...
>
> What I mean is if it's a macro that returns -ENODEV or a function that
> returns -ENODEV, they should both be treated the
On Fri, Jul 14, 2017 at 9:24 PM, Linus Torvalds
wrote:
> On Fri, Jul 14, 2017 at 2:25 AM, Arnd Bergmann wrote:
>> FIFO_MODE is an macro expression with a '<<' operator, which
>> gcc points out could be misread as a '<':
>
> Yeah, no, NAK again.
On Fri, Jul 14, 2017 at 9:23 PM, Linus Torvalds
wrote:
> On Fri, Jul 14, 2017 at 12:21 PM, Linus Torvalds
> wrote:
>>
>> NAK. This takes unintentionally insane code and turns it intentionally
>> insane. Any non-zero return is considered an error.
>>
>> The right fix is almost certainly to just re
On Tue, Feb 20, 2018 at 1:47 PM, Olof's autobuilder wrote:
> Warnings:
>
> arm64.allmodconfig:
> drivers/media/tuners/r820t.c:1334:1: warning: the frame size of 2896 bytes is
> larger than 2048 bytes [-Wframe-larger-than=]
Hi Greg,
please add
16c3ada89cff ("media: r820t: fix r820t_wri
On Thu, Feb 22, 2018 at 12:38 AM, James Hogan wrote:
> These patches remove the metag architecture and tightly dependent
> drivers from the kernel. With the 4.16 kernel the ancient gcc 4.2.4
> based metag toolchain we have been using is hitting compiler bugs, so
> now seems a good time to drop it
On Fri, Feb 23, 2018 at 12:02 PM, James Hogan wrote:
> On Fri, Feb 23, 2018 at 11:26:58AM +0100, Arnd Bergmann wrote:
>> On Thu, Feb 22, 2018 at 12:38 AM, James Hogan wrote:
>> > So lets call it a day and drop the Meta architecture port from the
>> > kernel. RIP Met
undefined!
This adds the same Kconfig dependency that we have in other
media drivers, using 'select SND_PCM' to ensure that we have
can call snd_pcm_hw_constraint_minmax, while depending on
CONFIG_SND_SOC for registering the codec.
Fixes: 9ac0038db9a7 ("media: i2c: Add TDA1997x HDMI r
.c:1024:12: error: 'ov5695_runtime_resume' defined but
not used [-Werror=unused-function]
static int ov5695_runtime_resume(struct device *dev)
This marks the affected functions as __maybe_unused.
Fixes: 8a77009be4be ("media: ov5695: add support for OV5695 sensor")
Signed-off-b
:12: error: 'ov2685_runtime_resume' defined but
not used [-Werror=unused-function]
static int ov2685_runtime_resume(struct device *dev)
This marks the affected functions as __maybe_unused.
Fixes: e3861d9118c8 ("media: ov2685: add support for OV2685 sensor")
Signed-off-by: Arn
32e5a70dc8f4 ("media: platform: Add Renesas CEU driver")
Signed-off-by: Arnd Bergmann
---
drivers/media/platform/renesas-ceu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/renesas-ceu.c
b/drivers/media/platform/renesas-ceu.c
index 223
On Thu, Feb 22, 2018 at 12:38 AM, James Hogan wrote:
> These patches remove the metag architecture and tightly dependent
> drivers from the kernel. With the 4.16 kernel the ancient gcc 4.2.4
> based metag toolchain we have been using is hitting compiler bugs, so
> now seems a good time to drop it
_WRITE_MAX might
be increased, I'm leaving the check against U8_MAX.
Fixes: bd24fcddf6b8 ("media: cxd2880-spi: Add support for CXD2880 SPI
interface")
Cc: Martin Sebor
Signed-off-by: Arnd Bergmann
---
drivers/media/spi/cxd2880-spi.c | 24 +++-
1 file changed, 7 ins
]
Fixes: 8f0aa38292f2 ("media: v4l: omap_vout: vrfb: Use the wrapper for
prep_interleaved_dma()")
Signed-off-by: Arnd Bergmann
---
drivers/media/platform/omap/omap_vout_vrfb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/omap/omap_vout_vrfb.c
b/drivers/me
d variable 'pdev'
[-Werror=unused-variable]
Fixes: 6795bf626482 ("media: ngene: convert kernellog printing from printk() to
dev_*() macros")
Signed-off-by: Arnd Bergmann
---
drivers/media/pci/ngene/ngene-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
no good way to rewrite this function, as a last
resort, this adds an explicit zero-intialization of the structure.
Fixes: 52e17089d185 ("media: imx: Don't initialize vars that won't be used")
Signed-off-by: Arnd Bergmann
---
drivers/staging/media/imx/imx-media-csi.c | 2 +-
1 fi
iles.
For anything else, I'd keep the removal patches in my asm-generic tree
and will send a pull request for 4.17 along with the actual arch removal.
Arnd
Arnd Bergmann
edac: remove tile driver
net: tile: remove ethernet drivers
net: adi: remove blackfin ethernet drivers
net: 83
The m32r architecture is getting removed, so this one is no longer needed.
Signed-off-by: Arnd Bergmann
---
drivers/media/platform/Kconfig | 20 -
drivers/media/platform/Makefile | 2 -
drivers/media/platform/arv.c| 884
3 files changed, 906
The blackfin architecture is getting removed, so the video
capture driver is also obsolete.
Signed-off-by: Arnd Bergmann
---
drivers/media/platform/Kconfig | 2 -
drivers/media/platform/Makefile| 2 -
drivers/media/platform/blackfin/Kconfig| 16
On Tuesday, January 3, 2017 3:35:44 PM CET Nicolas Dichtel wrote:
> Regularly, when a new header is created in include/uapi/, the developer
> forgets to add it in the corresponding Kbuild file. This error is usually
> detected after the release is out.
>
> In fact, all headers under include/uapi/
On Thursday, January 5, 2017 3:01:58 PM CET Andrew F. Davis wrote:
> @@ -109,7 +109,8 @@ obj-$(CONFIG_SERIO) += input/serio/
> obj-$(CONFIG_GAMEPORT) += input/gameport/
> obj-$(CONFIG_INPUT)+= input/
> obj-$(CONFIG_RTC_LIB) += rtc/
> -obj-y
On Thursday, January 5, 2017 4:35:33 PM CET Andrew F. Davis wrote:
> On 01/05/2017 03:42 PM, Arnd Bergmann wrote:
> > On Thursday, January 5, 2017 3:01:58 PM CET Andrew F. Davis wrote:
> >> @@ -109,7 +109,8 @@ obj-$(CONFIG_SERIO) += input/serio/
> >
On Friday, January 6, 2017 10:43:53 AM CET Nicolas Dichtel wrote:
>
> diff --git a/arch/arm/include/asm/types.h b/arch/arm/include/asm/types.h
> index a53cdb8f068c..c48fee3d7b3b 100644
> --- a/arch/arm/include/asm/types.h
> +++ b/arch/arm/include/asm/types.h
> @@ -1,40 +1,6 @@
> #ifndef _ASM_TYPE
101 - 200 of 791 matches
Mail list logo
