[PATCH v3 13/13] [media] s5p-mfc: fix a race in interrupt flags handling

2014-10-21 Thread Arun Kumar K
. To prevent this, clear the flags only under hw_lock and before running a hardware job. Signed-off-by: Pawel Osciak Signed-off-by: Kiran AVND Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c |2 -- drivers/media/platform/s5p-mfc/s5p_mfc_dec.c|3

[PATCH v3 12/13] [media] s5p-mfc: fix V4L2_CID_MIN_BUFFERS_FOR_CAPTURE on resolution change.

2014-10-21 Thread Arun Kumar K
Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc_dec.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c index a98fe02..de90465 100644 --- a/drivers/media/platform

[PATCH v3 10/13] [media] s5p-mfc: flush dpbs when resolution changes

2014-10-21 Thread Arun Kumar K
new resolution yet, it is simpler to push zero-size buffer until we flush out all dpbs. This is already been done while handling EOS command, and this patch extends the same logic to resolution change as well. Signed-off-by: Kiran AVND Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p

[PATCH v3 11/13] [media] s5p-mfc: Remove unused alloc field from private buffer struct.

2014-10-21 Thread Arun Kumar K
From: Pawel Osciak This field is no longer used as MFC driver doesn't use vb2 alloc contexts anymore. Signed-off-by: Pawel Osciak Signed-off-by: Kiran AVND Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc_common.h |3 --- 1 file changed, 3 deletions(-) diff

[PATCH v3 06/13] [media] s5p-mfc: check mfc bus ctrl before reset

2014-10-21 Thread Arun Kumar K
-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h |1 + drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 25 - 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-mfc/regs-mfc-v6.h b/drivers/media/platform/s5p

[PATCH v3 07/13] [media] s5p-mfc: Don't crash the kernel if the watchdog kicks in.

2014-10-21 Thread Arun Kumar K
n of locking in the driver. Signed-off-by: Pawel Osciak Signed-off-by: Kiran AVND Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c

[PATCH v3 09/13] [media] s5p-mfc: De-init MFC when watchdog kicks in

2014-10-21 Thread Arun Kumar K
From: Arun Mankuzhi If the software watchdog kicks in, we need to de-init MFC before reloading firmware and re-intializing it again. Signed-off-by: Arun Mankuzhi Signed-off-by: Kiran AVND Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc.c |4 1 file changed, 4

[PATCH v3 08/13] [media] s5p-mfc: modify mfc wakeup sequence for V8

2014-10-21 Thread Arun Kumar K
From: Arun Mankuzhi >From MFC V8, the MFC wakeup sequence has changed. MFC wakeup command has to be sent after the host receives firmware load complete status from risc. Signed-off-by: Arun Mankuzhi Signed-off-by: Kiran AVND Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-

[PATCH v3 01/13] [media] s5p-mfc: support MIN_BUFFERS query for encoder

2014-10-21 Thread Arun Kumar K
From: Kiran AVND Add V4L2_CID_MIN_BUFFERS_FOR_OUTPUT query for encoder. Once mfc encoder state is HEAD_PARSED, which is sequence header produced, dpb_count is avaialable. Let user space query this value. Signed-off-by: Kiran AVND Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc

[PATCH v3 04/13] [media] s5p-mfc: Only set timestamp/timecode for new frames.

2014-10-21 Thread Arun Kumar K
: Kiran AVND Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index 79c9537..eb71055 100644 --- a/drivers

[PATCH v3 02/13] [media] s5p-mfc: Fix REQBUFS(0) for encoder.

2014-10-21 Thread Arun Kumar K
From: Pawel Osciak Handle REQBUFS(0) for CAPTURE queue as well. Also use the proper queue to call it on for OUTPUT. Signed-off-by: Pawel Osciak Signed-off-by: Kiran AVND Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 13 + 1 file changed, 13

[PATCH v3 05/13] [media] s5p-mfc: keep RISC ON during reset for V7/V8

2014-10-21 Thread Arun Kumar K
From: Kiran AVND Reset sequence for MFC V7 and V8 do not need RISC_ON to be set to 0, while for MFC V6 it is still needed. Also, remove a couple of register settings during Reset which are not needed from V6 onwards. Signed-off-by: Kiran AVND Signed-off-by: Arun Kumar K --- drivers/media

[PATCH v3 03/13] [media] s5p-mfc: clear 'enter_suspend' flag if suspend fails

2014-10-21 Thread Arun Kumar K
an error on subsequent tries. If clock off fails, disable hw_lock also. Signed-off-by: Prathyush K Signed-off-by: Kiran AVND Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media

[PATCH v3 00/13] Fixes from Chrome OS tree for MFC driver

2014-10-21 Thread Arun Kumar K
Upstreaming the fixes which have gone in to Chrome OS tree for MFC driver. Tested on MFCV8, MFCV7 and MFCV6 based Exynos5 based boards, peach-pi (5800), peach-pit (5420) and snow (5250). Changes from v2: 1) Rebased on latest media-tree 2) Dropped the patch (14/14) from previous set s5p-mfc: Don

Re: [PATCH v2 07/14] [media] s5p-mfc: Don't crash the kernel if the watchdog kicks in.

2014-10-21 Thread Arun Kumar K
Hi Kamil, Kiran will not be available to handle review comments of these patches. So I will be pushing the updated patchset rebased on media-tree. I hope all patches are good to merge except [media] s5p-mfc: Don't change the image size to smaller than the request. I will drop this one patch and

Re: [PATCH 1/3] s5p-mfc: Fix selective sclk_mfc init

2014-07-08 Thread Arun Kumar K
Hi Jacek, On Tue, Jul 8, 2014 at 6:33 PM, Jacek Anaszewski wrote: > fc906b6d "Remove special clock usage in driver" removed > initialization of MFC special clock, arguing that there's > no need to do it explicitly, since it's one of MFC gate clock's > dependencies and gets enabled along with it.

[PATCH v2 3/3] [media] s5p-mfc: Add init buffer cmd to MFCV6

2014-05-21 Thread Arun Kumar K
Latest MFC v6 firmware requires tile mode and loop filter setting to be done as part of Init buffer command, in sync with v7. This patch adds this support for new v6 firmware. Signed-off-by: Arun Kumar K Signed-off-by: Kiran AVND Reviewed-by: Tomasz Figa --- drivers/media/platform/s5p-mfc

[PATCH v2 1/3] [media] s5p-mfc: Remove duplicate function s5p_mfc_reload_firmware

2014-05-21 Thread Arun Kumar K
The function s5p_mfc_reload_firmware is exactly same as s5p_mfc_load_firmware. So removing the duplicate function. Signed-off-by: Arun Kumar K Reviewed-by: Tomasz Figa --- drivers/media/platform/s5p-mfc/s5p_mfc.c |2 +- drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 33

[PATCH v2 2/3] [media] s5p-mfc: Support multiple firmware sub-versions

2014-05-21 Thread Arun Kumar K
binaries for every version with the driver trying to load firmwares starting from latest. This ensures full backward compatibility regardless of which firmware version and kernel version is used. Signed-off-by: Arun Kumar K Reviewed-by: Tomasz Figa --- drivers/media/platform/s5p-mfc/s5p_mfc.c

[PATCH v2 0/3] Support for multiple MFC FW sub-versions

2014-05-21 Thread Arun Kumar K
g-soc/31735 Changes from v1 - Addressed nits pointed by Sachin on PATCH 2/3 Arun Kumar K (3): [media] s5p-mfc: Remove duplicate function s5p_mfc_reload_firmware [media] s5p-mfc: Support multiple firmware sub-versions [media] s5p-mfc: Add init buffer cmd to MFCV6 drivers/media/platform/s5

Re: [PATCH 2/3] [media] s5p-mfc: Support multiple firmware sub-versions

2014-05-21 Thread Arun Kumar K
Hi Sachin, On Tue, May 20, 2014 at 5:15 PM, Sachin Kamat wrote: > Hi Arun, > > On 20 May 2014 15:47, Arun Kumar K wrote: >> For MFC firmwares, improved versions with bug fixes and >> feature additions are released keeping the firmware version >> including major and m

[PATCH 3/3] [media] s5p-mfc: Add init buffer cmd to MFCV6

2014-05-20 Thread Arun Kumar K
Latest MFC v6 firmware requires tile mode and loop filter setting to be done as part of Init buffer command, in sync with v7. This patch adds this support for new v6 firmware. Signed-off-by: Arun Kumar K Signed-off-by: Kiran AVND --- drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c |6

[PATCH 1/3] [media] s5p-mfc: Remove duplicate function s5p_mfc_reload_firmware

2014-05-20 Thread Arun Kumar K
The function s5p_mfc_reload_firmware is exactly same as s5p_mfc_load_firmware. So removing the duplicate function. Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc.c |2 +- drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 33 - 2 files

[PATCH 2/3] [media] s5p-mfc: Support multiple firmware sub-versions

2014-05-20 Thread Arun Kumar K
binaries for every version with the driver trying to load firmwares starting from latest. This ensures full backward compatibility regardless of which firmware version and kernel version is used. Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc.c|9

[PATCH 0/3] Support for multiple MFC FW sub-versions

2014-05-20 Thread Arun Kumar K
g-soc/31735 Arun Kumar K (3): [media] s5p-mfc: Remove duplicate function s5p_mfc_reload_firmware [media] s5p-mfc: Support multiple firmware sub-versions [media] s5p-mfc: Add init buffer cmd to MFCV6 drivers/media/platform/s5p-mfc/s5p_mfc.c| 11 +++--- drivers/media/platform/s5

Re: [PATCH v2] [media] s5p-mfc: Dequeue sequence header after STREAMON

2014-05-19 Thread Arun Kumar K
Hi Kamil, On 05/15/14 20:47, Kamil Debski wrote: > Hi Arun, > >> From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >> ow...@vger.kernel.org] On Behalf Of Arun Kumar K >> Sent: Wednesday, May 14, 2014 10:10 AM >> >> Hi Hans, >> >> On

[PATCH 2/2] [media] s5p-mfc: Core support for v8 encoder

2014-05-19 Thread Arun Kumar K
From: Kiran AVND This patch adds core support for v8 encoder. This patch also adds register definitions and buffer size requirements for H264 & VP8 encoding, needed for new firmware version v8 for MFC Signed-off-by: Kiran AVND Signed-off-by: Pawel Osciak Signed-off-by: Arun Kum

[PATCH 1/2] [media] s5p-mfc: Core support to add v8 decoder

2014-05-19 Thread Arun Kumar K
From: Kiran AVND This patch adds variant data and core support for V8 decoder. This patch also adds the register definition file for new firmware version v8 for MFC. Signed-off-by: Kiran AVND Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- .../devicetree/bindings/media/s5p

[PATCH 0/2] Re-send MFCv8 support patches

2014-05-19 Thread Arun Kumar K
These 2 patches for MFCv8 support are rebased onto [1] with the dependencies as mentioned below. Changes include adding the MFC_V8 version to formats. - Re-send MFC patches https://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg31051.html - Adding version information to formats by Kam

[PATCH 03/10] [media] s5p-mfc: Extract open/close MFC instance commands.

2014-05-19 Thread Arun Kumar K
From: Pawel Osciak This is in preparation for a new flow to fix issues with streamon, which should not be allocating buffer memory. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 19 +--- drivers/media/platform/s5p-mfc

[PATCH 10/10] [media] s5p-mfc: Rename IS_MFCV7 macro

2014-05-19 Thread Arun Kumar K
Renaming the IS_MFCV7 macro to IS_MFCV7_PLUS for the addition of MFCv8 support which reuses the v7 code. Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc_common.h |2 +- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c|2 +- drivers/media/platform/s5p-mfc

[PATCH 07/10] [media] s5p-mfc: Update scratch buffer size for MPEG4

2014-05-19 Thread Arun Kumar K
Update the MPEG4 decoder scratch buffer size as per the new v6 firmware. This updation is increasing the size and so is backward compatible with older v6 firmwares. Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h |3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 05/10] [media] s5p-mfc: Update scratch buffer size for VP8 encoder

2014-05-19 Thread Arun Kumar K
From: Kiran AVND Scratch buffer size updated for vp8 encoding as per the latest v7 firmware. As the new macro increases the scratch buffer size, it is backward compatible with the older firmware too. Signed-off-by: Kiran AVND Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc

[PATCH 08/10] [media] s5p-mfc: Move INIT_BUFFER_OPTIONS from v7 to v6

2014-05-19 Thread Arun Kumar K
The register S5P_FIMV_D_INIT_BUFFER_OPTIONS holds good for v6 firmware too. So moving the definition from v7 regs to v6. Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h|1 + drivers/media/platform/s5p-mfc/regs-mfc-v7.h|2 -- drivers/media/platform

[PATCH 00/10] Re-send MFC patches

2014-05-19 Thread Arun Kumar K
These patches for s5p-mfc are completed review and accepted. These are rebased onto [1] and fixed conflicts for merging. [1] http://git.linuxtv.org/cgit.cgi/kdebski/media_tree_2.git/?h=for-3.16-2 Arun Kumar K (3): [media] s5p-mfc: Update scratch buffer size for MPEG4 [media] s5p-mfc: Move

[PATCH 02/10] [media] s5p-mfc: Fixes for decode REQBUFS.

2014-05-19 Thread Arun Kumar K
. - Only verify state is MFCINST_INIT when allocating, not when freeing. - Refactor and simplify code. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 178 ++ 1 file changed, 99 insertions(+), 79 deletions

[PATCH 04/10] [media] s5p-mfc: Don't allocate codec buffers on STREAMON.

2014-05-19 Thread Arun Kumar K
o move the allocation of private codec buffers to REQBUFS for OUTPUT queue. Also, move MFC instance opening and closing to REQBUFS as well, as it's tied to allocation and deallocation of private codec buffers. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- drivers/media/p

[PATCH 06/10] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-05-19 Thread Arun Kumar K
The only way to make it work is to queue only one frame per buffer from userspace and the check in the kernel is useless and wrong for VP8. So adding VP8 also along with H264 to disallow re-submitting of buffer back to hardware for decode. Signed-off-by: Pawel Osciak Signed-off-by: Ar

[PATCH 01/10] [media] s5p-mfc: Copy timestamps only when a frame is produced.

2014-05-19 Thread Arun Kumar K
ster values are confusing, because in its case "display" means "a frame has been outputted to a destination buffer". We should copy if "decode and display" is returned in it. This also works on <= v6 firmware, which behaves in the same way with regards to de

Re: [PATCH 2/2] v4l: s5p-mfc: Limit enum_fmt to output formats of current version

2014-05-19 Thread Arun Kumar K
Hi Kamil, Only a small correction. On Fri, May 16, 2014 at 5:33 PM, Kamil Debski wrote: > MFC versions support a different set of formats, this specially applies > to the raw YUV formats. This patch changes enum_fmt, so that it only > reports formats that are supported by the used MFC version. >

Re: [PATCH v2] [media] s5p-mfc: Dequeue sequence header after STREAMON

2014-05-14 Thread Arun Kumar K
Hi Hans, On 05/14/14 12:39, Hans Verkuil wrote: > On 05/14/2014 08:29 AM, Arun Kumar K wrote: >> MFCv6 encoder needs specific minimum number of buffers to >> be queued in the CAPTURE plane. This minimum number will >> be known only when the sequence header is generated. &

[PATCH v5 2/2] [media] s5p-mfc: Add support for resolution change event

2014-05-14 Thread Arun Kumar K
From: Pawel Osciak When a resolution change point is reached, queue an event to signal the userspace that a new set of buffers is required before decoding can continue. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc.c |8

[PATCH v5 1/2] [media] v4l: Add source change event

2014-05-14 Thread Arun Kumar K
expected to reallocate buffers before proceeding. The application can subscribe to events on a specific pad or input port which it is interested in. Signed-off-by: Arun Kumar K --- Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 33 ++ .../DocBook/media/v4l/vidioc-subscribe

[PATCH v5 0/2] Add resolution change event

2014-05-14 Thread Arun Kumar K
from v1 --- - Addressed review comments from Hans and Laurent https://patchwork.kernel.org/patch/4000951/ Arun Kumar K (1): [media] v4l: Add source change event Pawel Osciak (1): [media] s5p-mfc: Add support for resolution change event Documentation/DocBook/media/v4l/vidioc

[PATCH v2 4/4] [media] s5p-mfc: Core support for v8 encoder

2014-05-13 Thread Arun Kumar K
From: Kiran AVND This patch adds core support for v8 encoder. This patch also adds register definitions and buffer size requirements for H264 & VP8 encoding, needed for new firmware version v8 for MFC Signed-off-by: Kiran AVND Signed-off-by: Pawel Osciak Signed-off-by: Arun Kum

[PATCH v2 3/4] [media] s5p-mfc: Core support to add v8 decoder

2014-05-13 Thread Arun Kumar K
From: Kiran AVND This patch adds variant data and core support for V8 decoder. This patch also adds the register definition file for new firmware version v8 for MFC. Signed-off-by: Kiran AVND Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- .../devicetree/bindings/media/s5p

[PATCH v2 2/4] [media] s5p-mfc: Rename IS_MFCV7 macro

2014-05-13 Thread Arun Kumar K
Renaming the IS_MFCV7 macro to IS_MFCV7_PLUS for the addition of MFCv8 support which reuses the v7 code. Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc_common.h |2 +- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c|2 +- drivers/media/platform/s5p-mfc

[PATCH v2 0/4] Add MFCv8 support

2014-05-13 Thread Arun Kumar K
rg/patch/23770/ https://patchwork.linuxtv.org/patch/23768/ Arun Kumar K (1): [media] s5p-mfc: Rename IS_MFCV7 macro Kiran AVND (3): [media] s5p-mfc: Add variants to access mfc registers [media] s5p-mfc: Core support to add v8 decoder [media] s5p-mfc: Core support for v8 encoder .../devic

[PATCH] [media] s5p-mfc: Update scratch buffer size for MPEG4

2014-05-13 Thread Arun Kumar K
Update the MPEG4 decoder scratch buffer size as per the new v6 firmware. This updation is increasing the size and so is backward compatible with older v6 firmwares. Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h |3 +-- 1 file changed, 1 insertion(+), 2

[PATCH v2] [media] s5p-mfc: Dequeue sequence header after STREAMON

2014-05-13 Thread Arun Kumar K
also come in earlier MFC firmware versions if the application calls STREAMON on CAPTURE with some delay after doing STREAMON on OUTPUT. So this patch keeps the header buffer until the other frame buffers are ready and dequeues it just before the first frame is ready. Signed-off-by: Arun Kumar K

[PATCH v2] [media] s5p-mfc: Don't allocate codec buffers on STREAMON.

2014-05-13 Thread Arun Kumar K
o move the allocation of private codec buffers to REQBUFS for OUTPUT queue. Also, move MFC instance opening and closing to REQBUFS as well, as it's tied to allocation and deallocation of private codec buffers. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- Posting only p

[PATCH v3] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-05-13 Thread Arun Kumar K
hexadecimal value based on the firmware date. Signed-off-by: avnd kiran Signed-off-by: Arun Kumar K --- Changes from v2 - Addressed Kamil's comment https://patchwork.linuxtv.org/patch/22989/ Changes from v1 - Check for v6 firmware date for differenciating old and new firmware as per com

Re: [PATCH] [media] s5p-mfc: Dequeue sequence header after STREAMON

2014-05-13 Thread Arun Kumar K
Hi Sachin, Thank you for the review. Will address your comments and post updated version. Regards Arun On Thu, May 8, 2014 at 3:09 PM, Sachin Kamat wrote: > Hi Arun, > > Just 2 small nits. > > On 7 May 2014 17:00, Arun Kumar K wrote: >> MFCv6 encoder needs specific mini

Re: [PATCH 1/3] [media] s5p-mfc: Add variants to access mfc registers

2014-05-13 Thread Arun Kumar K
Hi Kamil, On 05/13/14 16:02, Kamil Debski wrote: > Hi, > > One small comment below, > >> -Original Message----- >> From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun >> Kumar K >> Sent: Wednesday, April 23, 2014 2:58 PM >> To:

Re: [PATCH v4 1/2] [media] v4l: Add source change event

2014-05-13 Thread Arun Kumar K
Hi Hans, Will make the changes you suggested. Thanks & regards Arun On Tue, May 13, 2014 at 1:30 PM, Hans Verkuil wrote: > Hi Arun, > > I've got some more comments w.r.t. the documentation: > > On 05/13/14 07:59, Arun Kumar K wrote: >> This event indicates that th

Re: [PATCH v4 2/2] [media] s5p-mfc: Add support for resolution change event

2014-05-13 Thread Arun Kumar K
Hi Hans, On Tue, May 13, 2014 at 1:29 PM, Hans Verkuil wrote: > On 05/13/14 07:59, Arun Kumar K wrote: >> From: Pawel Osciak >> >> When a resolution change point is reached, queue an event to signal the >> userspace that a new set of buffers is required befo

Re: [PATCH v2] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-05-13 Thread Arun Kumar K
Hi Kamil, On Tue, May 13, 2014 at 2:49 PM, Kamil Debski wrote: > Hi, > >> From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun >> Kumar K >> Sent: Tuesday, March 11, 2014 10:16 AM >> >> From: avnd kiran >> >> Latest MFC v6 firmwa

[PATCH v4 1/2] [media] v4l: Add source change event

2014-05-12 Thread Arun Kumar K
expected to reallocate buffers before proceeding. The application can subscribe to events on a specific pad or input port which it is interested in. Signed-off-by: Arun Kumar K --- Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 32 + .../DocBook/media/v4l/vidioc-subscribe

[PATCH v4 2/2] [media] s5p-mfc: Add support for resolution change event

2014-05-12 Thread Arun Kumar K
From: Pawel Osciak When a resolution change point is reached, queue an event to signal the userspace that a new set of buffers is required before decoding can continue. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc.c |7

[PATCH v4 0/2] Add resolution change event

2014-05-12 Thread Arun Kumar K
://patchwork.kernel.org/patch/4135731/ Changes from v2 --- - Event can be subscribed on specific pad / port as suggested by Hans. Changes from v1 --- - Addressed review comments from Hans and Laurent https://patchwork.kernel.org/patch/4000951/ Arun Kumar K (1): [media] v4l

Re: [PATCH v3 1/2] [media] v4l: Add source change event

2014-05-12 Thread Arun Kumar K
Hi Hans, Laurent, On 05/09/14 18:45, Hans Verkuil wrote: > On 05/09/2014 03:09 PM, Laurent Pinchart wrote: >> Hi Arun, >> >> Thank you for the patch. We're slowly getting there :-) >> >> On Thursday 08 May 2014 17:19:15 Arun Kumar K wrote: >>>

[PATCH v2] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-05-12 Thread Arun Kumar K
The only way to make it work is to queue only one frame per buffer from userspace and the check in the kernel is useless and wrong for VP8. So adding VP8 also along with H264 to disallow re-submitting of buffer back to hardware for decode. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K -

Re: [PATCH 1/3] [media] s5p-mfc: Add variants to access mfc registers

2014-05-08 Thread Arun Kumar K
Hi Tomasz, On 05/09/14 10:50, Tomasz Figa wrote: > Hi Arun, Paweł, > > On 09.05.2014 06:49, Arun Kumar K wrote: >> Hi Kamil, >> >> On 05/09/14 06:30, Pawel Osciak wrote: >>> Hi Kamil, >>> >>> On Fri, May 9, 2014 at 1:31 AM, Kamil Debski

Re: [PATCH] [media] s5p-mfc: Add IOMMU support

2014-05-08 Thread Arun Kumar K
Hi Kamil, On 05/08/14 21:54, Kamil Debski wrote: > Hi Arun, > >> From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] >> Sent: Tuesday, April 22, 2014 2:22 PM >> >> Hi Laurent, >> >> Thank you for the review. >> >> On Tue, Apr 22, 20

Re: [PATCH v2] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-05-08 Thread Arun Kumar K
Hi Kamil, On 05/08/14 21:52, Kamil Debski wrote: > Hi, > >> From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun >> Kumar K >> Sent: Tuesday, March 11, 2014 10:16 AM >> >> From: avnd kiran >> >> Latest MFC v6 firmware requires ti

Re: [PATCH] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-05-08 Thread Arun Kumar K
Hi Kamil, On 05/08/14 21:52, Kamil Debski wrote: > Hi, > > >> From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun >> Kumar K >> Sent: Friday, March 07, 2014 9:26 AM >> >> From: Pawel Osciak >> >> Currently, for formats that

[PATCH v3 1/2] [media] v4l: Add source change event

2014-05-08 Thread Arun Kumar K
expected to reallocate buffers before proceeding. The application can subscribe to events on a specific pad or input/output port which it is interested in. Signed-off-by: Arun Kumar K --- Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 32 + .../DocBook/media/v4l/vidioc-subscribe

[PATCH v3 0/2] Add resolution change event

2014-05-08 Thread Arun Kumar K
://patchwork.kernel.org/patch/4023131/ Changes from v2 --- - Event can be subscribed on specific pad / port as suggested by Hans. Changes from v1 --- - Addressed review comments from Hans and Laurent https://patchwork.kernel.org/patch/4000951/ Arun Kumar K (1): [media] v4l

[PATCH v3 2/2] [media] s5p-mfc: Add support for resolution change event

2014-05-08 Thread Arun Kumar K
From: Pawel Osciak When a resolution change point is reached, queue an event to signal the userspace that a new set of buffers is required before decoding can continue. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc.c |7

[PATCH] [media] s5p-mfc: Update scratch buffer size for VP8 encoder

2014-05-07 Thread Arun Kumar K
From: Kiran AVND Scratch buffer size updated for vp8 encoding as per the latest v7 firmware. As the new macro increases the scratch buffer size, it is backward compatible with the older firmware too. Signed-off-by: Kiran AVND Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc

[PATCH] [media] s5p-mfc: Dequeue sequence header after STREAMON

2014-05-07 Thread Arun Kumar K
versions if the application calls STREAMON on CAPTURE with some delay after doing STREAMON on OUTPUT. So this patch keeps the header buffer until the other frame buffers are ready and dequeues it just before the first frame is ready. Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc

Re: [PATCH v2 1/2] v4l: Add resolution change event.

2014-05-05 Thread Arun Kumar K
Hi Hans, On Wed, Apr 30, 2014 at 8:03 PM, Hans Verkuil wrote: > On 04/30/2014 12:38 PM, Arun Kumar K wrote: >> Hi Hans, >> >> >> On 04/22/14 18:22, Hans Verkuil wrote: >>> On 04/21/2014 11:26 AM, Arun Kumar K wrote: >>>> From: Pawel Osciak >

Re: [PATCH v2 1/2] v4l: Add resolution change event.

2014-04-30 Thread Arun Kumar K
Hi Hans, On 04/22/14 18:22, Hans Verkuil wrote: > On 04/21/2014 11:26 AM, Arun Kumar K wrote: >> From: Pawel Osciak >> >> This event indicates that the decoder has reached a point in the stream, >> at which the resolution changes. The userspace is expected to prov

Re: [PATCH 2/3] [media] s5p-mfc: Core support to add v8 decoder

2014-04-29 Thread Arun Kumar K
Hi Sachin, On Wed, Apr 30, 2014 at 11:19 AM, Sachin Kamat wrote: > Hi Arun, > > On 30 April 2014 11:15, Arun Kumar K wrote: >> Hi Sachin, >> >> Thank you for the review. >> >> >> On 04/29/14 22:45, Sachin Kamat wrote: >>> >>&g

Re: [PATCH 2/3] [media] s5p-mfc: Core support to add v8 decoder

2014-04-29 Thread Arun Kumar K
Hi Sachin, Thank you for the review. On 04/29/14 22:45, Sachin Kamat wrote: Hi Arun, On 23 April 2014 18:27, Arun Kumar K wrote: From: Kiran AVND This patch adds variant data and core support for V8 decoder. This patch also adds the register definition file for new firmware version v8 for

[PATCH 3/3] [media] s5p-mfc: Rename IS_MFCV7 macro

2014-04-23 Thread Arun Kumar K
With the inclusion of MFCv8 which reuses the v7 code, the macro IS_MFCV7 is modified to IS_MFCV7_PLUS. Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc_common.h |2 +- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c|2 +- drivers/media/platform/s5p-mfc

[PATCH 0/3] Add MFCv8 support

2014-04-23 Thread Arun Kumar K
buffer for decode. [media] s5p-mfc: Add a control for IVF format for VP8 encoder Arun Kumar K (1): [media] s5p-mfc: Rename IS_MFCV7 macro Kiran AVND (2): [media] s5p-mfc: Add variants to access mfc registers [media] s5p-mfc: Core support to add v8 decoder .../devicetree/bindings/media/s

[PATCH 2/3] [media] s5p-mfc: Core support to add v8 decoder

2014-04-23 Thread Arun Kumar K
From: Kiran AVND This patch adds variant data and core support for V8 decoder. This patch also adds the register definition file for new firmware version v8 for MFC. Signed-off-by: Kiran AVND Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- .../devicetree/bindings/media/s5p

Re: [PATCH] [media] s5p-mfc: Add IOMMU support

2014-04-22 Thread Arun Kumar K
Hi Laurent, Thank you for the review. On Tue, Apr 22, 2014 at 5:23 PM, Laurent Pinchart wrote: > Hi Arun, > > Thank you for the patch. > > On Tuesday 22 April 2014 16:32:48 Arun Kumar K wrote: >> The patch adds IOMMU support for MFC driver. > > I've been working

[PATCH] [media] s5p-mfc: Add IOMMU support

2014-04-22 Thread Arun Kumar K
The patch adds IOMMU support for MFC driver. Signed-off-by: Arun Kumar K --- This patch is tested on IOMMU support series [1] posted by KyonHo Cho. [1] https://lkml.org/lkml/2014/3/14/9 --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 33 ++ 1 file changed, 33

Re: [PATCH v2 1/2] v4l: Add resolution change event.

2014-04-21 Thread Arun Kumar K
Hi Laurent, Thank you for the review. On Mon, Apr 21, 2014 at 3:54 PM, Laurent Pinchart wrote: > Hi Arun, > > Thank you for the patch. > > On Monday 21 April 2014 14:56:01 Arun Kumar K wrote: >> From: Pawel Osciak >> >> This event indicates that the decoder

Re: [PATCH v2 1/2] v4l: Add resolution change event.

2014-04-21 Thread Arun Kumar K
Hi Pawel, On Mon, Apr 21, 2014 at 2:58 PM, Pawel Osciak wrote: > Arun, I think it'd better if you attributed this patch to yourself, I'm not > the author of it. I only wrote patch 2/2 in this series. > Thanks, > Pawel > > Sure I will change it. I kept your name as it was a rework of your patch f

[PATCH v2 1/2] v4l: Add resolution change event.

2014-04-21 Thread Arun Kumar K
involving resolution or format changes at runtime for all kinds of video devices. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- .../DocBook/media/v4l/vidioc-subscribe-event.xml | 16 include/uapi/linux/videodev2.h |6 ++ 2 files changed

[PATCH v2 0/2] Add resolution change event

2014-04-21 Thread Arun Kumar K
This patchset adds the resolution change event to the MFC decoder. This will be used for triggering the runtime resolution change. Changes from v1 --- - Addressed review comments from Hans and Laurent https://patchwork.kernel.org/patch/4000951/ Pawel Osciak (2): v4l: Add resolutio

[PATCH v2 2/2] [media] s5p-mfc: Add support for resolution change event

2014-04-21 Thread Arun Kumar K
From: Pawel Osciak When a resolution change point is reached, queue an event to signal the userspace that a new set of buffers is required before decoding can continue. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc.c |6

Re: [PATCH 1/2] v4l: Add resolution change event.

2014-04-16 Thread Arun Kumar K
Hi Laurent and Hans, Thank you for the review. On Wed, Apr 16, 2014 at 7:46 PM, Hans Verkuil wrote: > On 04/16/2014 04:09 PM, Laurent Pinchart wrote: >> Hi Arun, >> >> Thank you for the patch. >> On Wednesday 16 April 2014 18:29:21 Arun Kumar K wrote: >>> Fr

[PATCH 2/2] [media] s5p-mfc: Add support for resolution change event

2014-04-16 Thread Arun Kumar K
From: Pawel Osciak When a resolution change point is reached, queue an event to signal the userspace that a new set of buffers is required before decoding can continue. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc.c |6

[PATCH 1/2] v4l: Add resolution change event.

2014-04-16 Thread Arun Kumar K
From: Pawel Osciak This event indicates that the decoder has reached a point in the stream, at which the resolution changes. The userspace is expected to provide a new set of CAPTURE buffers for the new format before decoding can continue. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar

[PATCH 0/3] MFC cleanup of reqbuf, streamon, open and close

2014-03-21 Thread Arun Kumar K
This patch series contain some fixes and cleanups done to the s5p-mfc decoder in reqbuf, streamon and open/close commands. These patches are present in the ChromeOS tree and just rebased onto the media-tree and tested. Pawel Osciak (3): [media] s5p-mfc: Fixes for decode REQBUFS. [media] s5p-mf

[PATCH 2/3] [media] s5p-mfc: Extract open/close MFC instance commands.

2014-03-21 Thread Arun Kumar K
From: Pawel Osciak This is in preparation for a new flow to fix issues with streamon, which should not be allocating buffer memory. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 19 +--- drivers/media/platform/s5p-mfc

[PATCH 3/3] [media] s5p-mfc: Don't allocate codec buffers on STREAMON.

2014-03-21 Thread Arun Kumar K
o move the allocation of private codec buffers to REQBUFS for OUTPUT queue. Also, move MFC instance opening and closing to REQBUFS as well, as it's tied to allocation and deallocation of private codec buffers. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- drivers/media/p

[PATCH 1/3] [media] s5p-mfc: Fixes for decode REQBUFS.

2014-03-21 Thread Arun Kumar K
. - Only verify state is MFCINST_INIT when allocating, not when freeing. - Refactor and simplify code. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 178 ++ 1 file changed, 99 insertions(+), 79 deletions

[PATCH] [media] s5p-mfc: Copy timestamps only when a frame is produced.

2014-03-18 Thread Arun Kumar K
ster values are confusing, because in its case "display" means "a frame has been outputted to a destination buffer". We should copy if "decode and display" is returned in it. This also works on <= v6 firmware, which behaves in the same way with regards to de

Re: [PATCH] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-03-11 Thread Arun Kumar K
Hi Kamil, On Tue, Mar 11, 2014 at 4:59 PM, Kamil Debski wrote: > Hi Arun, > >> From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun >> Kumar K >> Sent: Friday, March 07, 2014 9:26 AM >> >> From: Pawel Osciak >> >> Currently, for

[PATCH v2] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-03-11 Thread Arun Kumar K
hexadecimal value based on the firmware date. Signed-off-by: avnd kiran Signed-off-by: Arun Kumar K --- Changes from v1 --- - Check for v6 firmware date for differenciating old and new firmware as per comments from Kamil and Sylwester. --- drivers/media/platform/s5p-mfc/regs-mfc-v6

Re: [PATCH] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-03-09 Thread Arun Kumar K
Hi Kamil, On Fri, Mar 7, 2014 at 6:18 PM, Kamil Debski wrote: > Hi Arun, > >> From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] >> Sent: Friday, March 07, 2014 12:10 PM >> >> Hi Sylwester, >> >> On Fri, Mar 7, 2014 at 2:59 PM, Sylwester Nawrocki >&

Re: [PATCH] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-03-07 Thread Arun Kumar K
Hi Sylwester, On Fri, Mar 7, 2014 at 2:59 PM, Sylwester Nawrocki wrote: > Hi, > > On 07/03/14 09:31, Arun Kumar K wrote: >> From: avnd kiran >> >> Latest MFC v6 firmware requires tile mode and loop filter >> setting to be done as part of Init buffer command, i

[PATCH] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-03-07 Thread Arun Kumar K
-by: Arun Kumar K --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h|1 + drivers/media/platform/s5p-mfc/regs-mfc-v7.h|2 -- drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 11 +++ 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/media/platform/s5p

[PATCH] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-03-07 Thread Arun Kumar K
The only way to make it work is to queue only one frame per buffer from userspace and the check in the kernel is useless and wrong for VP8. MPEG4 still seems to require it, so keep it only for that format. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- drivers/media/platform/s5p-mfc

[PATCH] [media] s5p-mfc: Add a control for IVF format for VP8 encoder

2014-03-05 Thread Arun Kumar K
From: Pawel Osciak Add a control to enable/disable IVF output stream format for VP8 encode. Set the IVF format output to disabled as default. Signed-off-by: Pawel Osciak Signed-off-by: Arun Kumar K --- Documentation/DocBook/media/v4l/controls.xml|8 drivers/media/platform

  1   2   3   4   5   >