Re: [PATCH/RFCv4 0/6] The Contiguous Memory Allocator framework

2010-08-30 Thread Clemens Ladisch
Andrew Morton wrote: It would help (a lot) if we could get more attention and buyin and fedback from the potential clients of this code. rmk's feedback is valuable. Have we heard from the linux-media people? What other subsystems might use it? ieee1394 perhaps? All FireWire controllers

Re: [RFC/PATCH v6 02/12] media: Media device

2010-11-25 Thread Clemens Ladisch
Laurent Pinchart wrote: +struct media_device { ... + u8 model[32]; + u8 serial[40]; + u8 bus_info[32]; All drivers and userspace applications have to treat this as char[], so why u8[]? Regards, Clemens -- To unsubscribe from this list: send the line unsubscribe linux-media in

Re: [RFC/PATCH v6 03/12] [alsa-devel] media: Entities, pads and links

2010-11-25 Thread Clemens Ladisch
Laurent Pinchart wrote: A link is a point-to-point oriented connection between two pads, either on the same entity or on different entities. Data flows from a source pad to a sink pad. Links are stored in the source entity. In the descriptors of USB Audio and HDAudio devices, the links are

Re: [RFC/PATCH v6 03/12] [alsa-devel] media: Entities, pads and links

2010-11-26 Thread Clemens Ladisch
Laurent Pinchart wrote: On Thursday 25 November 2010 10:38:05 Clemens Ladisch wrote: MEDIA_ENTITY_TYPE_NODE_ALSA_PCM MEDIA_ENTITY_TYPE_NODE_ALSA_MIDI MEDIA_ENTITY_TYPE_SUBDEV_ALSA_CONTROL I agree about PCM and MIDI, but I'm not sure about controls. If controls are part

Re: [alsa-devel] [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-13 Thread Clemens Ladisch
. For that, it would be useful to make do without separate identification and let the driver choose the entity ID. Signed-off-by: Clemens Ladisch clem...@ladisch.de --- linux/include/linux/media.h +++ linux/include/linux/media.h @@ -46,16 +46,36 @@ struct media_device_info { #define MEDIA_ENTITY_TYPE_MASK

Re: [alsa-devel] [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-14 Thread Clemens Ladisch
Laurent Pinchart wrote: On Monday 13 December 2010 17:10:51 Clemens Ladisch wrote: TYPE_EXT describes entities that represent some interface to the external world, TYPE_INT those that are internal to the entire device. (I'm not sure if that distinction is very useful, but TYPE_SUBDEV seems

Re: [alsa-devel] [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-14 Thread Clemens Ladisch
Laurent Pinchart wrote: On Tuesday 14 December 2010 13:40:21 Hans Verkuil wrote: On Monday 13 December 2010 17:10:51 Clemens Ladisch wrote: * Entity types TYPE_NODE was renamed to TYPE_DEVICE because node sounds like a node in a graph, which does not distinguish it from other entity

Re: [alsa-devel] [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-14 Thread Clemens Ladisch
Laurent Pinchart wrote: On Tuesday 14 December 2010 14:31:55 Clemens Ladisch wrote: Laurent Pinchart wrote: On Monday 13 December 2010 17:10:51 Clemens Ladisch wrote: EXT_SPEAKER also includes headphones; there might be made a case for having those as a separate subtype

Re: [PATCH] firewire: octlet AT payloads can be stack-allocated

2011-04-26 Thread Clemens Ladisch
sbp2_orb.pointer buffer for 8-byte block write requests on the other hand needs to remain slab-allocated in order to keep the allocation around until end of AT DMA. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de Acked-by: Clemens Ladisch clem...@ladisch.de -- To unsubscribe from this list

[PATCH] media: fix truncated entity specification

2011-11-05 Thread Clemens Ladisch
When enumerating an entity, assign the entire entity specification instead of only the first two words. (This requires giving the specification union a name.) So far, no driver actually uses more than two words, but this will be needed for ALSA entities. Signed-off-by: Clemens Ladisch clem

Re: [PATCH] media: fix truncated entity specification

2011-11-15 Thread Clemens Ladisch
Laurent Pinchart wrote: On Saturday 05 November 2011 22:42:01 Clemens Ladisch wrote: When enumerating an entity, assign the entire entity specification instead of only the first two words. (This requires giving the specification union a name.) What about this (untested) simpler patch

Re: [PATCH] media: fix truncated entity specification

2011-11-15 Thread Clemens Ladisch
Laurent Pinchart wrote: On Saturday 05 November 2011 22:42:01 Clemens Ladisch wrote: When enumerating an entity, assign the entire entity specification instead of only the first two words. (This requires giving the specification union a name.) Your patch looks good then, except

[PATCH] cx88-alsa: prevent out-of-range volume setting

2010-02-22 Thread Clemens Ladisch
Ensure that volume values are always in the allowed range. Otherwise, it would be possible to set other bits in the AUD_VOL_CTL register or to get a wrong sign in the AUD_BAL_CTL register. Signed-off-by: Clemens Ladisch clem...@ladisch.de --- linux/drivers/media/video/cx88/cx88-alsa.c +++ linux

Re: [PATCH 1/3] USB gadget: audio class function driver

2009-09-18 Thread Clemens Ladisch
Laurent Pinchart wrote: +snd_uac_pcm_open(struct snd_pcm_substream *substream, int stream) ... + substream-runtime-hw = stream == SNDRV_PCM_STREAM_PLAYBACK +? snd_uac_playback_hw +: snd_uac_capture_hw; +

Re: [alsa-devel] Fw: Isochronous transfer error on USB3

2014-01-09 Thread Clemens Ladisch
Mauro Carvalho Chehab wrote: I'm getting an weird behavior with em28xx, especially when the device is connected into an audio port. http://git.linuxtv.org/mchehab/experimental.git/blob/refs/heads/em28xx-v4l2-v6:/drivers/media/usb/em28xx/em28xx-audio.c What happens is that, when I

Re: [alsa-devel] [PATCH 1/3] sound: Add a quirk to enforce period_bytes

2014-06-16 Thread Clemens Ladisch
(CC stable dropped; this is not how to submit stable patches.) Mauro Carvalho Chehab wrote: The Auvitek 0828 chip, used on HVR950Q actually need two quirks and not just one. The first one, already implemented, enforces that it won't have channel swaps at the transfers. However, for TV

Re: [alsa-devel] [PATCH 1/3] sound: Add a quirk to enforce period_bytes

2014-06-18 Thread Clemens Ladisch
Mauro Carvalho Chehab wrote: Let's see the au0828 case: 48 kHz, 2 bytes/sample, 2 channels, 256 maxpacksize, 1 ms URB interval (bInterval = 1). In this case, there is 192 bytes per 1ms period. The device's clock and the bus clock are not synchronized, so there will be _approximately_

Re: [alsa-devel] [PATCH 1/3] sound: Add a quirk to enforce period_bytes

2014-06-18 Thread Clemens Ladisch
Mauro Carvalho Chehab wrote: Both xawtv and tvtime use the same code for audio: http://git.linuxtv.org/cgit.cgi/xawtv3.git/tree/common/alsa_stream.c There's an algorithm there that gets the period size form both the capture and the playback cards, trying to find a minimum period that

Re: [alsa-devel] [PATCH] usbtv: add audio support

2014-08-19 Thread Clemens Ladisch
Federico Simoncelli wrote: +++ b/drivers/media/usb/usbtv/usbtv-audio.c ... +#include sound/ac97_codec.h What do you need this header for? +static struct snd_pcm_hardware snd_usbtv_digital_hw = { + ... + .period_bytes_min = 11059, + .period_bytes_max = 13516, +

Re: [alsa-devel] [PATCH 1/2] [media] sound: simplify au0828 quirk table

2014-10-30 Thread Clemens Ladisch
Mauro Carvalho Chehab wrote: Add a macro to simplify au0828 quirk table. That makes easier to check it against the USB IDs at drivers/media/usb/au0828-card.c +++ b/sound/usb/quirks-table.h ... + * This should be kept in sync with drivers/media/usb/au0828-card.c The file does not exist in

Re: [PATCH] media; firewire: Remove no longer needed fix me comment in firedtv-ci.c for the function,fdtv_ca_ioctl

2015-01-09 Thread Clemens Ladisch
Nicholas Krause wrote: Removes the no longer fix me comment for if we need to set the tuner status with the line, avc_tuner_status(fdtv, stat). This line is needed in order to set the tuner status after we have through the switch statement checking what fdtv function we need to call to

Re: [alsa-devel] Linux 4.2 ALSA snd-usb-audio inconsistent lock state warn in PCM nonatomic mode

2015-09-01 Thread Clemens Ladisch
Shuah Khan wrote:> On 09/01/2015 02:42 AM, Clemens Ladisch wrote: >> Shuah Khan wrote: >>> +++ b/sound/usb/stream.c >>> pcm->private_data = as; >>> pcm->private_free = snd_usb_audio_pcm_free; >>> pcm->info_flags = 0; >>> + pcm-&g

[PATCH] libdvbv5: T2 delivery descriptor: fix wrong size of bandwidth field

2017-04-01 Thread Clemens Ladisch
ETSI EN 300 468 V1.11.1 ยง 6.4.4.2 defines the bandwith field as having four bits. Signed-off-by: Clemens Ladisch <clem...@ladisch.de> --- v4l-utils/lib/include/libdvbv5/desc_t2_delivery.h.orig +++ v4l-utils/lib/include/libdvbv5/desc_t2_delivery.h @@ -86,7 +86,7 @@ struct dvb_desc_t2_de