with
Sylwester Nawrocki and the define should actually be (0xf << 28).
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c
b/drivers/media/platform/exynos4-is/mipi-csis.c
index 9fc2af6..31dfc50 100644
--- a/drivers/media/platform/exynos4-is/mipi-csis.c
++
1532 ctx->internal_frames[i].size += ysize/4;
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
board = &board_matrix_ii;
1066 break;
There are several other uses of "go" before it has been initialized.
Probably you will just want to change these back to pr_info(). Some of
the messages are not very useful like:
dev_info(go->dev, "Sensoray 2250 found\n&
We dereference "dev" after it has already been freed.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c
b/drivers/media/usb/cx231xx/cx231xx-cards.c
index e9d017b..528cce9 100644
--- a/drivers/media/usb/cx231xx/cx231xx-cards.c
+++ b/drivers/media/u
8 &mygica_x8506_xc5000_config);
1149 }
1150 cx23885_set_frontend_hook(port, fe0->dvb.frontend);
^
Dereference.
1151 break;
regards,
dan carpe
> I don't take pull requests for staging drivers.
>
Yeah... Pull request get far less review. I never bother reviewing
them, honestly. I feel bad for that.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of
ntity_pipeline_stop(&video->video.entity);
err_media_entity_pipeline_start:
if (video->iss->pdata->set_constraints)
video->iss->pdata->set_constraints(video->iss, false);
video->queue = NULL;
mutex_unlock(&video->stream_lock);
return ret;
}
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
s dereference.
791 break;
792 case CX23885_BOARD_HAUPPAUGE_HVR1255:
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
t use spin_lock_irq().
It's called from __enqueue_in_driver().
Signed-off-by: Dan Carpenter
---
v2: The first version changed everything to irq_save/restore() but that
wasn't right because we wanted IRQs enabled and not simply restored.
diff --git a/drivers/media/platform/soc_camera/
On Sun, Aug 25, 2013 at 02:23:18PM +0200, Sylwester Nawrocki wrote:
> On 08/23/2013 11:46 AM, Dan Carpenter wrote:
> >[ Going through some old warnings... ]
> >
> >Hello Sylwester Nawrocki,
> >
> >This is a semi-automatic email about new static checker warnin
On Fri, Aug 23, 2013 at 11:16:51PM +0200, Guennadi Liakhovetski wrote:
> Hi Dan,
>
> On Fri, 23 Aug 2013, Dan Carpenter wrote:
>
> > There is a return in the middle where we haven't restored the IRQs to
> > their original state.
> >
> > Signed-off
The "i < " part of the "i < ARRAY_SIZE()" condition was missing.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/platform/sh_vou.c b/drivers/media/platform/sh_vou.c
index 7a9c5e9..41f612c 100644
--- a/drivers/media/platform/sh_vou.c
+++ b/drivers/media/p
e = (frame->f_width * frame->f_height * fmt->depth)
/ 8;
^^
Dereference.
461 }
462
463 if (fmt == NULL)
^^^
Check.
464 return -EINVAL;
4
There is a return in the middle where we haven't restored the IRQs to
their original state.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/platform/soc_camera/mx3_camera.c
b/drivers/media/platform/soc_camera/mx3_camera.c
index 1047e3e..4bae910 100644
--- a/drivers/media/pla
Because "i" is unsigned then "i-- >= 0" is always true. If we don't
find what we are looking for then we loop forever.
Signed-off-by: Dan Carpenter
---
Why do we count backwards anyway? Counting upwards is easier.
diff --git a/drivers/media/platform/s3c-camif/c
There is a stray '!' character so the error message never gets printed.
Signed-off-by: Dan Carpenter
---
Static checker stuff. Not tested.
diff --git a/drivers/media/platform/exynos4-is/fimc-is-regs.c
b/drivers/media/platform/exynos4-is/fimc-is-regs.c
index 63c68ec..42f2925 10
98 u32 offset;
699
700 if (status & S5PCSIS_INTSRC_EVEN)
701 offset = S5PCSIS_PKTDATA_EVEN;
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The ">" should be ">=" otherwise we read one space beyond the end of the
array.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c
index 1dbb811..4da90c6 100644
--- a/drivers/media/i2c/ov9650.c
+++ b/drivers/media/i2c/o
The check is off by one so we could read one space past the end of the
array.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/i2c/s5k6aa.c b/drivers/media/i2c/s5k6aa.c
index 789c02a..629a5cd 100644
--- a/drivers/media/i2c/s5k6aa.c
+++ b/drivers/media/i2c/s5k6aa.c
@@ -1003,7 +1003,7
The "|" operation has higher precedence that "?:" so this couldn't
return both flags set at once as intended.
Signed-off-by: Dan Carpenter
---
Static checker stuff. Untested.
diff --git a/drivers/media/radio/radio-sf16fmr2.c
b/drivers/media/radio/radio-sf16fmr2.c
inde
cker warnings without fixing the
bug then we are hiding real problems and making them more difficult
to find.
Just drop this chunk.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.o
On Thu, Jul 25, 2013 at 07:29:09PM +0200, walter harms wrote:
>
>
> Am 25.07.2013 18:46, schrieb Dan Carpenter:
> > p_ca_slot_info was allocated with kmalloc() so we need to clear it
> > before passing it to the user.
> >
> > Signed-off-by: Dan Carpenter
> &
p_ca_slot_info was allocated with kmalloc() so we need to clear it
before passing it to the user.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/pci/bt8xx/dst_ca.c b/drivers/media/pci/bt8xx/dst_ca.c
index 0e788fc..6b9dc3f 100644
--- a/drivers/media/pci/bt8xx/dst_ca.c
+++ b/drivers
On Wed, Jun 26, 2013 at 06:29:12PM +0300, Andy Shevchenko wrote:
> On Wed, 2013-06-26 at 18:10 +0300, Dan Carpenter wrote:
> > On Wed, Jun 26, 2013 at 05:37:36PM +0300, Andy Shevchenko wrote:
> > > From: Dan Carpenter
> > >
> > > We have reorganized the er
On Wed, Jun 26, 2013 at 05:37:36PM +0300, Andy Shevchenko wrote:
> From: Dan Carpenter
>
> We have reorganized the error handling into a simpler and more canonical
> format.
>
> Additionally we removed extra empty lines, switched to devm_kzalloc(), and
> substitute &#
On Wed, Jun 26, 2013 at 11:00:40AM +0300, Andy Shevchenko wrote:
> On Wed, 2013-06-26 at 10:53 +0300, Dan Carpenter wrote:
> > I have reorganized the error handling into a simpler and more canonical
> > format.
>
> Since you reorganize error handling, might be worth to
I have reorganized the error handling into a simpler and more canonical
format.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/media/lirc/lirc_igorplugusb.c
b/drivers/staging/media/lirc/lirc_igorplugusb.c
index 2faa391..4cf3933 100644
--- a/drivers/staging/media/lirc
Ping?
regards,
dan carpenter
On Sat, Apr 13, 2013 at 12:32:15PM +0300, Dan Carpenter wrote:
> These structs have holes and reserved struct members which aren't
> cleared. I've added a memset() so we don't leak stack information.
>
> Signed-off-by: Dan Carpenter
>
On Sun, Apr 21, 2013 at 01:51:56PM +0200, walter harms wrote:
>
>
> Am 21.04.2013 13:10, schrieb Dan Carpenter:
> > The last part of the "u_ent.name" buffer isn't cleared so it still has
> > uninitialized stack memory.
> >
> > Signed-off-by: Da
The last part of the "u_ent.name" buffer isn't cleared so it still has
uninitialized stack memory.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
index 99b80b6..1957c0d 100644
--- a/drivers/media/media-device.c
+++ b/driv
I've moved the kfree(fe->tuner_priv) one line earlier, otherwise it is
a no-op.
Signed-off-by: Dan Carpenter
---
This is a static checker fix and I have not tested it.
diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c
index ba033fd..36ddbf1 100644
--- a/drive
The test as written is always false. It looks like the intent was to
test that the bit was not set.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c
index 905a106..ba033fd 100644
--- a/drivers/media/tuners/r820t.c
+++ b/drivers/media/tuners
ch would not
> be checked.
>
> * Remove code duplication in "si476x_radio_read_rsq_blob" and
> "si476x_radio_read_rsq_primary_blob".
>
> * Add some BUG_ON statements for function pointers that should never be NULL
>
> Signed-off-by: Andrey Smirnov
> Si
Any feedback on this?
I forgot to CC Steven Toth last time because he would know about the
cx24116 driver. I've looked at it again and it still looks like
cx24116_send_diseqc_msg() is copying garbage into the
state->dsec_cmd.args[] array.
regards,
dan carpenter
On Tue, Apr 02, 2013
007/go7007-priv.h:95:31: error: dubious one-bit signed
bitfield
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/media/go7007/go7007-priv.h
b/drivers/staging/media/go7007/go7007-priv.h
index 8bde187..6e16af7 100644
--- a/drivers/staging/media/go7007/go7007-priv.h
+++ b/drivers/stag
Sparse complains that these are "dubious one-bit signed bitfields" and
the comment says it was intended to be 1 and 0 instead of -1 and 0.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/dvb-frontends/lg2160.h
b/drivers/media/dvb-frontends/lg2160.h
index a5f0368..194a07a 10
These structs have holes and reserved struct members which aren't
cleared. I've added a memset() so we don't leak stack information.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
index 99b80b6..450c0d1 100644
--- a/driv
n-NULL.
The one place where that's not true is when we check ->rds_blckcnt
instead of ->rsq_status. In those cases, we would want to call
->rsq_status but we instead return -ENOENT.
Signed-off-by: Dan Carpenter
---
Please review this carefully. I don't have the hardware
^^
Should we be copying "pktlen" bytes on the line before? It seems
inconsistent that it doesn't match the debug code.
My main concern is that we limit the size of "pktlen" but then we only
use it for debug output.
642 break;
regards,
dan carpenter
On Tue, Apr 09, 2013 at 07:20:19AM +0200, Julia Lawall wrote:
> On Tue, 9 Apr 2013, Dan Carpenter wrote:
>
> > We should unlock here and do some cleanup before returning.
> >
> > We can't actually hit this return path with the current code, so this
> > patch i
We should unlock here and do some cleanup before returning.
We can't actually hit this return path with the current code, so this
patch is a basically a cleanup and doesn't change how the code works.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/media/dt3155v4l/dt31
nd_diseqc_msg()
ds3000_send_diseqc_msg()
etc.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/dvb-core/dvb_frontend.c
b/drivers/media/dvb-core/dvb_frontend.c
index 57601c0..3d1eee6 100644
--- a/drivers/media/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb-core/dvb_
On Tue, Mar 26, 2013 at 10:04:15AM +0300, Dan Carpenter wrote:
> On Tue, Mar 26, 2013 at 02:42:47PM +0800, Wei Yongjun wrote:
> > From: Wei Yongjun
> >
> > sizeof() when applied to a pointer typed expression gives the
> > size of the pointer, not that of the pointed da
#x27;t know what
this code is doing. Instead of sizeof(*buf) it should be something
like "buflen", "msg[i].len", "msg[i].len + 1" or "msg[i].len + 3".
I'm not sure which is correct here or what it's doing, sorry.
regards,
dan carpenter
--
To unsubscrib
On Tue, Feb 12, 2013 at 01:20:36PM -0800, Joe Perches wrote:
> His email bounces and he hasn't done work on
> these sections in a couple of years.
>
I've added him to the CC list.
Can we just update MAINTAINERS with the correct email address? It's
been useful to CC him
Smatch complains that "cmdbuf[cmdcount - length]" might go past the end
of the array. It's an easy warning to silence by moving the limit
check earlier.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c
index bdd1ed8..5b5b6e6 10064
return res | POLLIN | POLLRDNORM;
1466 return res;
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
lso invalid and would lead to reading
past the end of the array.
Signed-off-by: Dan Carpenter
---
v2: Moved the check from the caller into the function. Added a check
for odd values. Added an error message. Increment the numinvalid
counter.
diff --git a/drivers/media/usb/ttusb-budget/dvb-ttusb-budge
past the end of the smaller array.
d->msg_len comes from the user.
I don't know if this can result in an information leak?
It's weird that we're copying bogus data into the state->dsec_cmd.args[]
array.
regards,
dan carpenter
--
To unsubscribe from this list: send the lin
This allocation had no error checking. It didn't need to be under
the mutex so I moved it out form there. That makes the error handling
easier and is a potential speed up.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/usb/tm6000/tm6000-core.c
b/drivers/media/usb/tm6000/tm6000-c
are next to each other on the
keyboard.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/media/go7007/wis-saa7113.c
b/drivers/staging/media/go7007/wis-saa7113.c
index 8810c1e..891cde7 100644
--- a/drivers/staging/media/go7007/wis-saa7113.c
+++ b/drivers/staging/media/go7007/wis-s
On Wed, Jan 16, 2013 at 06:00:13PM +0400, Volokh Konstantin wrote:
> On Wed, Jan 16, 2013 at 04:36:08PM +0300, Dan Carpenter wrote:
> > You've added the writes for GO7007_BOARDID_ADLINK_MPG24 but removed
> > them for GO7007_BOARDID_XMEN and GO7007_BOARDID_XMEN_III. Won&#x
You've added the writes for GO7007_BOARDID_ADLINK_MPG24 but removed
them for GO7007_BOARDID_XMEN and GO7007_BOARDID_XMEN_III. Won't
that break those boards?
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of
The problem is that the firmware was being unloaded on disconnect?
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 16, 2013 at 05:00:48PM +0400, Volokh Konstantin wrote:
> Signed-off-by: Volokh Konstantin
Acked-by: Dan Carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo
There is a missing break so we use XC_RF_MODE_CABLE instead of
XC_RF_MODE_AIR.
Signed-off-by: Dan Carpenter
---
Static checker stuff. Untested.
diff --git a/drivers/media/tuners/xc5000.c b/drivers/media/tuners/xc5000.c
index dc93cf3..d6be1b6 100644
--- a/drivers/media/tuners/xc5000.c
+++ b
My static checker complains about the fall through here. From the
context it looks like we should add a break statement.
Signed-off-by: Dan Carpenter
---
Untested.
diff --git a/drivers/media/usb/cx231xx/cx231xx-video.c
b/drivers/media/usb/cx231xx/cx231xx-video.c
index 93dfc18..06376d9 100644
Smatch complains that the "Audio input:" printk isn't reachable. Hiding
the "return 0;" behind another statement is a style violation.
It looks like audio_input is normally configured so I've enabled the
print statement.
Signed-off-by: Dan Carpenter
diff --git
This is a static checker fix. In the ttusb_process_muxpack() we do:
cc = (muxpack[len - 4] << 8) | muxpack[len - 3];
That means if we pass a number less than 4 then we will either trigger a
checksum error message or read before the start of the array.
Signed-off-by: Dan Car
We recently pushed the locking down into this function, but there was
an error path where the unlock was missed.
Signed-off-by: Dan Carpenter
---
Only needed in linux-next.
diff --git a/drivers/media/dvb-core/dvb_ca_en50221.c
b/drivers/media/dvb-core/dvb_ca_en50221.c
index 190e5e0..0aac309
thread.
*shrug*.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ereference it. NULL returns don't imply an error so don't
use IS_ERR_OR_NULL() to check for errors."
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jan 02, 2013 at 06:31:53PM +1300, Tony Prisk wrote:
> On Wed, 2013-01-02 at 08:10 +0300, Dan Carpenter wrote:
> > clk_get() returns NULL if CONFIG_HAVE_CLK is disabled.
> >
> > I told Tony about this but everyone has been gone with end of year
> > holidays
to revert
patches.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Smatch complainst that the call to mantis_evmgr_exit() dereferences "ca"
but then we check it for NULL on the next line. I've moved the NULL
check forward to avoid that.
Signed-off-by: Dan Carpenter
---
There aren't any callers for this function. It is commented out in
mant
On Wed, Nov 28, 2012 at 08:30:04PM +0100, Sylwester Nawrocki wrote:
> On 11/28/2012 01:22 PM, Dan Carpenter wrote:
> > In the end this is just a driver, and I don't especially care. But
> > it's like not just this one which makes me frustrated. I really
> > be
kernel last week so no
one should have expected to merge new drivers this week anyway.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Nov 28, 2012 at 12:56:10PM +0100, Hans Verkuil wrote:
> On Wed 28 November 2012 12:45:37 Dan Carpenter wrote:
> > I wish people wouldn't submit big patches right before the merge
> > window opens... :/ It's better to let it sit in linux-next for a
> > coupl
I wish people wouldn't submit big patches right before the merge
window opens... :/ It's better to let it sit in linux-next for a
couple weeks so people can mess with it a bit.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media&qu
This error path is missing the unlock.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index 601d1ac1..759a40a 100644
--- a/drivers/media/rc/rc-main.c
+++ b/drivers/media/rc/rc-main.c
@@ -890,7 +892,8 @@ static ssize_t store_protocols(struct
We recently introduced a new return -ENODEV in this function but we need
to unlock before returning.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index 601d1ac1..d593bc6 100644
--- a/drivers/media/rc/rc-main.c
+++ b/drivers/media/rc/rc-main.c
registers */
295 dw210x_op_rw(d->udev, 0xc3, 0xd1 , 0,
296 ibuf, msg[1].len + 2, DW210X_READ_MSG);
297 memcpy(msg[1].buf, ibuf + 2, msg[1].len);
298
299 break;
300 }
regards
requency *= -1;
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Sep 29, 2012 at 12:52:38PM +0200, walter harms wrote:
>
>
> Am 29.09.2012 09:12, schrieb Dan Carpenter:
> > ->input_filename could be NULL here. The intent was to test
> > ->_filename.
> >
> > Signed-off-by: Dan Carpenter
> > ---
> >
->input_filename could be NULL here. The intent was to test
->_filename.
Signed-off-by: Dan Carpenter
---
I'm not totally convinced that using /root/vid411.yuv is the right idea.
diff --git a/drivers/media/pci/cx25821/cx25821-video-upstream.c
b/drivers/media/pci/cx25821/cx
p;edid->edid;
2207 *array_size = edid->blocks * 128;
^^
This can overflow.
2208 ret = 1;
2209 }
2210 break;
2211 }
regards,
dan carpenter
--
To
file a bug report and attach
the .jpg.
regards,
dan carpenter
On Fri, Sep 07, 2012 at 09:24:13PM +1000, yvahk-xre...@zacglen.net wrote:
>
> I am getting either a a kernel Oops or freeze (without any console output)
> on recent kernels. I have tested on 2.6.32.26 PAE, 3.1.9 PAE, and 3.4.9 PAE
ould not be numbers because this is not GW-BASIC. The
label should reflect what happens on the next line. Labeling the
place after the goto location where you started from is always
nonsense.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ou had fixed this the same as the others and removed the
goto. Also the printk is redundant and wrong. Remove it too.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
These should be -ENOSYS because not -EINVAL.
Reported-by: Sean Young
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/rc/ir-lirc-codec.c b/drivers/media/rc/ir-lirc-codec.c
index 6ad4a07..c0dc1b9 100644
--- a/drivers/media/rc/ir-lirc-codec.c
+++ b/drivers/media/rc/ir-lirc-codec.c
re subtle. The ->carrier is passed to
mod_freq_to_val() which uses it as a divisor.
Signed-off-by: Dan Carpenter
---
v2: tried to add the check to ir_lirc_ioctl() but that doesn't work.
v3: the same as v1 except that I've added a fix for redrat3 as well.
diff --git a/drivers/media/rc
rl,
> + .querymenu = v4l2_subdev_querymenu,
> + .s_std = tw2804_s_std,
> +};
> +
> +static int tw2804_s_video_routing(struct v4l2_subdev *sd, u32 input, u32
> output,
> + u32 config)
> +{
> + struct wis_tw2804 *dec = to_state(sd);
> + struct i2c_
Several of the drivers use carrier as a divisor in their s_tx_carrier()
functions. We should do a sanity check here like we do for
LIRC_SET_REC_CARRIER.
Signed-off-by: Dan Carpenter
---
v2: Ben Hutchings pointed out that my first patch was not a complete
fix.
diff --git a/drivers/media/rc
"carrier" comes from a get_user() in ir_lirc_ioctl(). We need to test
that it's not zero before using it as a divisor.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/rc/ene_ir.c b/drivers/media/rc/ene_ir.c
index 647dd95..d05ac15 100644
--- a/drivers/media/rc/ene_ir.
curlencheck++;
950 } else {
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Aug 14, 2012 at 07:50:12AM -0300, Ezequiel Garcia wrote:
> Hi Dan,
>
> On Tue, Aug 14, 2012 at 3:58 AM, Dan Carpenter
> wrote:
> > We need to move the unlock before the kfree(dev);
> >
> > Signed-off-by: Dan Carpenter
> > ---
> > Applies t
"card" is a valid pointer here because we checked snd_card_create() for
error returns. Checking after a dereference makes the static checkers
complain.
Signed-off-by: Dan Carpenter
---
Only needed on linux-next.
diff --git a/drivers/media/video/stk1160/stk1160-ac97.c
b/drivers/m
There are some unlocks missing on error.
Signed-off-by: Dan Carpenter
---
Applies on top of linux-next.
diff --git a/drivers/media/video/stk1160/stk1160-v4l.c
b/drivers/media/video/stk1160/stk1160-v4l.c
index 360bdbe..1ad4ac1 100644
--- a/drivers/media/video/stk1160/stk1160-v4l.c
+++ b/drivers
We recently added locking to this function, but there was an error path
which accidentally returned holding a lock. Also we returned zero on
failure on some paths instead of the error code.
Signed-off-by: Dan Carpenter
---
Applies to linux-next.
diff --git a/drivers/media/video
We need to move the unlock before the kfree(dev);
Signed-off-by: Dan Carpenter
---
Applies to linux-next.
diff --git a/drivers/media/video/em28xx/em28xx-video.c
b/drivers/media/video/em28xx/em28xx-video.c
index ecb23df..78d6ebd 100644
--- a/drivers/media/video/em28xx/em28xx-video.c
+++ b
This code looks suspicious, but it turns out that "nv" is an array of u8
so sizeof() is the same as ARRAY_SIZE(). Using ARRAY_SIZE() is more
readable though.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/dvb/frontends/it913x-fe.c
b/drivers/media/dvb/frontends/it913x-
expects this parameter to equal to sizeof(data) or smaller
instead of 265.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
int ret;
1866
1867 if (!fh)
^^^
Old check.
1868 return -ENODEV;
1869 dprintk(4, "%s, vma=0x%08lx\n", __func__, (unsigned long)vma);
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe
qt1010_init_meas2() returns zero on success and negative error codes on
failure so the return type should be int instead of u8.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/common/tuners/qt1010.c
b/drivers/media/common/tuners/qt1010.c
index 2d79b1f..bdc39e1 100644
--- a/drivers
On Mon, Aug 06, 2012 at 05:23:23PM +0300, Dan Carpenter wrote:
> On Sat, Aug 04, 2012 at 08:23:27PM +0200, Julia Lawall wrote:
> > @@ -922,12 +920,7 @@ static int emmaprp_probe(struct platform_device *pdev)
> >
> > platform_set_drvdata(pdev, pcdev);
> >
> >
oremap(&pdev->dev, res_emma);
> if (!pcdev->base_emma)
> goto rel_vdev;
This was in the original code, but there is a "ret = -ENOMEM;"
missing here, and again a couple lines down in the original code.
regards,
dan carpenter
--
To unsubscribe from
We need to do a mutex_unlock(&priv->lock) before returning.
Signed-off-by: Dan Carpenter
diff --git a/drivers/media/common/tuners/tuner-xc2028.c
b/drivers/media/common/tuners/tuner-xc2028.c
index 9e60285..ea0550e 100644
--- a/drivers/media/common/tuners/tuner-xc2028.c
+++ b/driver
We intended to do a compare here, not an assignment.
Signed-off-by: Dan Carpenter
---
Static analysis bug. I don't own the hardware.
diff --git a/drivers/media/common/tuners/tuner-xc2028.c
b/drivers/media/common/tuners/tuner-xc2028.c
index f88f948..9e60285 100644
--- a/drivers/media/c
My static checker complains that we dereference "state" inside the call
to fft_to_mode() before checking for NULL. The comments say that it is
possible for "state" to be NULL so I have moved the dereference after
the check.
Signed-off-by: Dan Carpenter
diff --git a/drivers
eft == 0)
190 packet_type = LAST_PACKET;
191 else
192 packet_type = INTER_PACKET;
193 gspca_frame_add(gspca_dev, packet_type,
194
401 - 500 of 738 matches
Mail list logo
