[PATCH v2 00/19] dddvb/ddbridge-0.9.33

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller This series brings all relevant changes from the upstream dddvb-0.9.33 driver package to the in-kernel ddbridge and stv0910, though a few changes were picked up and merged previously already. Summary of changes: * stv0910: initialisation fixes and fixed CNR reporting

[PATCH v2 06/19] [media] ddbridge: request/free_irq using pci_irq_vector, enable MSI-X

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller Instead of trying to manage IRQ numbers on itself, utilise the pci_irq_vector() function to do this, which will take care of correct IRQ numbering for MSI and non-MSI IRQs. While at it, request and enable MSI-X interrupts for hardware (boards and cards) that support this

[PATCH v2 09/19] [media] ddbridge: improve separated MSI IRQ handling

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller Improve IRQ handling in the separated MSG/I2C and IO/TSDATA handlers by applying a mask for recognized bits immediately upon reading the IRQ mask from the hardware, so only the bits/IRQs that actually were set will be acked. Picked up from the upstream dddvb-0.9.33 release

[PATCH v2 01/19] [media] dvb-frontends/stv0910: add init values for TSINSDELM/L

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller The TSINSDEL registers were lacking initialisation in the stv0910 demod driver. Initialise them (both demods) in the probe() function. Picked up from the upstream dddvb-0.9.33 release. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0910.c | 6

[PATCH v2 04/19] [media] ddbridge: move ddb_wq and the wq+class initialisation to -core

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller Move the ddbridge module initialisation and cleanup code to ddbridge-core and set up the ddb_wq workqueue there, and create and destroy the ddb device class there aswell. Due to this, the prototypes for ddb_wq, ddb_class_create() and ddb_class_destroy() aren't requir

[PATCH v2 03/19] [media] ddbridge: move modparams to ddbridge-core.c

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller Besides the 'msi' module option, all options are used from within ddbridge-core only, so move them over from ddbridge-main, and declare the associated variables static. Since the prototypes in ddbridge.h aren't necessary anymore now, remove them. As a side e

[PATCH v2 16/19] [media] ddbridge/max: implement MCI/MaxSX8 attach function

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller Implement frontend attachment as ddb_fe_attach_mci() into the ddbridge-max module. The MaxSX8 MCI cards are part of the Max card series and make use of the LNB controller driven by the already existing lnb functionality, so here's where this code belongs to. Picked up

[PATCH v2 11/19] [media] ddbridge: fix output buffer check

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller A 188 byte gap has to be left between the writer and the consumer. This requires 2*188 bytes available to be able to write to the output buffers. So, change ddb_output_free() to report free bytes according to this rule. Picked up from the upstream dddvb-0.9.33 release

[PATCH v2 14/19] [media] ddbridge: support dummy tuners with 125MByte/s dummy data stream

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller The Octopus V3 and Octopus Mini devices support set up of a dummy tuner mode on port 0 that will deliver a continuous data stream of 125MBytes per second while raising IRQs and filling the DMA buffers, which comes handy for some stress, PCIe link and IRQ handling testing

[PATCH v2 19/19] [media] ddbridge: set driver version to 0.9.33-integrated

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller Set DDBRIDGE_VERSION in ddbridge.h to 0.9.33-integrated to reflect the updated driver. Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/ddbridge.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/ddbridge/ddbridge.h b

[PATCH v2 10/19] [media] ddbridge: use spin_lock_irqsave() in output_work()

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller Make sure to save IRQ states before taking the dma lock, as already done in it's input_work() counterpart. Picked up from the upstream dddvb-0.9.33 release. Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/ddbridge-core.c | 12 ++-- 1 file ch

[PATCH v2 07/19] [media] ddbridge: add helper for IRQ handler setup

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller Introduce the ddb_irq_set() helper function (along with a matching prototype in ddbridge.h) to improve the set up of the IRQ handlers and handler_data, and rework storing this data into the ddb_link using a new ddb_irq struct. This also does the necessary rework of affected

[PATCH v2 08/19] [media] ddbridge: add macros to handle IRQs in nibble and byte blocks

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller Currently, each IRQ requires one IRQ_HANDLE() line to call each IRQ handler that was set up. Add a IRQ_HANDLE_NIBBLE() and IRQ_HANDLE_BYTE() macro to call all handlers in blocks of four (_NIBBLE) or eight (_BYTE) handlers at a time, to make this construct more compact

[PATCH v2 12/19] [media] ddbridge: set devid entry for link 0

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller Currently, /sys/class/ddbridgeX/devid always reports 0 due to devid not being set at all. Set the devid field alongside while storing all other hardware ID data. Picked up from the upstream dddvb-0.9.33 release. Signed-off-by: Daniel Scheller --- drivers/media/pci

[PATCH v2 18/19] [media] ddbridge: recognize and attach the MaxSX8 cards

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller Add needed logic into dvb_input_attach(), ddb_port_probe() and ddb_ports_init() to initialize and support these new cards. Picked up from the upstream dddvb-0.9.33 release. Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/ddbridge-core.c | 15

[PATCH v2 15/19] [media] ddbridge: initial support for MCI-based MaxSX8 cards

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller This adds initial support for the new MCI-based (micro-code interface) DD cards, with the first one being the MaxSX8 eight-tuner DVB-S/S2/S2X PCIe card. The MCI is basically a generalized interface implemented in the card's FPGA firmware and usable for all kind of

[PATCH v2 13/19] [media] ddbridge: make DMA buffer count and size modparam-configurable

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller Make the number of DMA buffers and their size configurable using module parameters. Being able to set these to a higher number might help on busy systems when handling overall high data rates without having to edit the driver sources and recompile things. Picked up from

[PATCH v2 17/19] [media] ddbridge: add hardware defs and PCI IDs for MCI cards

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller Add PCI IDs and ddb_info for the new MCI-based MaxSX8 cards. Also add needed defines so the cards can be hooked up into ddbridge's probe and attach handling. Picked up from the upstream dddvb-0.9.33 release. Signed-off-by: Daniel Scheller --- drivers/media/pci/ddb

[PATCH v2 05/19] [media] ddbridge: move MSI IRQ cleanup to a helper function

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller Introduce the ddb_msi_exit() helper to be used for cleaning up previously allocated MSI IRQ vectors. Deduplicates code and makes things look cleaner as for all cleanup work the CONFIG_PCI_MSI ifdeffery is only needed in the helper now. Also, replace the call to the

[PATCH v2 02/19] [media] dvb-frontends/stv0910: fix CNR reporting in read_snr()

2018-04-09 Thread Daniel Scheller
From: Daniel Scheller The CNR value determined in read_snr() is reported via the wrong variable. It uses FE_SCALE_DECIBEL, which implies the value to be reported in svalue instead of uvalue. Fix this accordingly. Picked up from the upstream dddvb-0.9.33 release. Signed-off-by: Daniel Scheller

Re: [PATCH] media: ddbridge: better handle optional spin locks at the code

2018-04-11 Thread Daniel Scheller
ing for the dma ptrs at the beginning of the four functions and immediately return if the ptr is invalid. Though I don't know if this may cause side effects as there's data written to the regs pointed by the TS_CONTROL() macros even if there's no dma ptr present. I'd like to hear Ralph's opinion on this, and also like to have this changed (in whatever way) in the upstream (dddvb) repository, too. Please refrain from applying this patch until we agreed on a proper solution that works for everyone. Best regards, Daniel Scheller -- https://github.com/herrnst

Re: [PATCH] media: ddbridge: better handle optional spin locks at the code

2018-04-11 Thread Daniel Scheller
Am Wed, 11 Apr 2018 13:33:02 -0300 schrieb Mauro Carvalho Chehab : > Em Wed, 11 Apr 2018 18:03:15 +0200 > Daniel Scheller escreveu: > > > Am Wed, 11 Apr 2018 08:03:37 -0400 > > schrieb Mauro Carvalho Chehab : > > > > > Currently, ddbridge produces 4 warni

[PATCH] [media] ddbridge: don't uselessly check for dma in start/stop functions

2018-04-16 Thread Daniel Scheller
From: Daniel Scheller The check for a valid ptr in ddb_io->dma isn't really necessary since only devices that do data transport using DMA are supported by the driver, and all previous initialisation code (through input_init(), output_init() and dma_init(), has_dma is always true as it&

Re: [PATCH v2 18/19] media: si470x: allow build both USB and I2C at the same time

2018-04-18 Thread Daniel Scheller
edia_tree/master And, "git revert 58767984..." makes all drivers being built again by media_build. Not sure if there's something other for which this patch acts as the trigger of if this needs adaption in media_build, though I thought reporting this doesn't hurt. Best regards, Daniel Scheller -- https://github.com/herrnst

Re: [PATCH v2 18/19] media: si470x: allow build both USB and I2C at the same time

2018-04-18 Thread Daniel Scheller
Am Wed, 18 Apr 2018 15:53:09 -0300 schrieb Mauro Carvalho Chehab : > Em Wed, 18 Apr 2018 19:07:40 +0200 > Daniel Scheller escreveu: > > > Am Fri, 6 Apr 2018 13:46:03 -0300 > > schrieb Mauro Carvalho Chehab : > > > > > Em Sat, 7 Apr 2018 00:21:07 +08

[PATCH 2/2] [media] ngene: fix ci_tsfix modparam description typo

2018-04-22 Thread Daniel Scheller
From: Daniel Scheller s/shifs/shifts/ Signed-off-by: Daniel Scheller --- drivers/media/pci/ngene/ngene-dvb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/ngene/ngene-dvb.c b/drivers/media/pci/ngene/ngene-dvb.c index fee89b9ed9c1..5147e83397a1 100644

[PATCH 1/2] [media] ngene: cleanup superfluous I2C adapter evaluation

2018-04-22 Thread Daniel Scheller
From: Daniel Scheller Commit ee93340e98bc ("media: ngene: deduplicate I2C adapter evaluation") added a helper to evaluate the I2C adapter to be used for demod/tuner attachment based on the given ngene_channel, and that helper is used in many attach functions to initialise the i

Re: [PATCH] media: stv0910: fix get_algo()'s return type

2018-04-24 Thread Daniel Scheller
frontend *fe) > +static enum dvbfe_algo get_algo(struct dvb_frontend *fe) > { > return DVBFE_ALGO_HW; > } Acked-by: Daniel Scheller Best regards, Daniel Scheller -- https://github.com/herrnst

Re: [PATCH] media: mxl5xx: fix get_algo()'s return type

2018-04-24 Thread Daniel Scheller
> +static enum dvbfe_algo get_algo(struct dvb_frontend *fe) > { > return DVBFE_ALGO_HW; > } Acked-by: Daniel Scheller Best regards, Daniel Scheller -- https://github.com/herrnst

Re: [PATCH v3] media: cxd2841er: avoid too many status inquires

2019-10-05 Thread Daniel Scheller
30 seconds > + */ > + if (!priv->ucb_interval && p->bandwidth_hz) > + priv->ucb_interval = (100 * 204 * 1000 * 8) / p->bandwidth_hz; > + > + if (priv->ucb_interval < 1000) > + priv->ucb_interval = 1000; > + > +// HACK: > +dev_info(&priv->i2c->dev, "UCB interval: %d ms", priv->ucb_interval); > + > + priv->ucb_time = jiffies + msecs_to_jiffies(priv->ucb_interval); > } > > static int cxd2841er_dvbt2_set_profile( > @@ -3360,6 +3421,13 @@ static int cxd2841er_set_frontend_s(struct > dvb_frontend *fe) > p->post_bit_error.stat[0].scale = FE_SCALE_NOT_AVAILABLE; > p->post_bit_count.stat[0].scale = FE_SCALE_NOT_AVAILABLE; > > + /* Reset the wait for jiffies logic */ > + priv->ber_interval = 0; > + priv->ucb_interval = 0; > + priv->ber_time = 0; > + priv->ucb_time = 0; > + priv->snr_time = 0; > + > return ret; > } > Best regards, Daniel Scheller -- https://github.com/herrnst

Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware

2017-06-19 Thread Daniel Scheller
Am Sun, 28 May 2017 23:45:37 +0200 schrieb Daniel Scheller : > Am Sun, 7 May 2017 17:42:12 +0200 > schrieb Daniel Scheller : > > > Am Wed, 12 Apr 2017 21:23:27 +0200 > > schrieb Daniel Scheller : > > > > > Am Wed, 29 Mar 2017 18:43:00

[PATCH] [media] ddbridge: use pr_* macros in favor of printk

2017-06-20 Thread Daniel Scheller
From: Daniel Scheller Side effect: KERN_DEBUG messages aren't written to the kernel log anymore. This also improves the tda18212_ping reporting a bit so users know that if pinging wasn't successful, bad things might happen. Signed-off-by: Daniel Scheller --- drivers/media/pc

[PATCH 2/4] [media] dvb-frontends/stv0367: split SNR determination into functions

2017-06-20 Thread Daniel Scheller
From: Daniel Scheller The read_snr() functions currently do some magic to return relative scale values when called. Split out register readouts into separate functions so the functionality can be reused in some other way. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0367

[PATCH 3/4] [media] dvb-frontends/stv0367: SNR DVBv5 statistics for DVB-C and T

2017-06-20 Thread Daniel Scheller
From: Daniel Scheller Add signal-to-noise-ratio as provided by the demodulator in decibel scale. QAM/DVB-C needs some intlog calculation to have usable dB values, OFDM/ DVB-T values from the demod look alright already and are provided as-is. Signed-off-by: Daniel Scheller --- drivers/media

[PATCH 4/4] [media] dvb-frontends/stv0367: DVB-C signal strength statistics

2017-06-20 Thread Daniel Scheller
From: Daniel Scheller Provide QAM/DVB-C signal strength in decibel scale. Values returned from stv0367cab_get_rf_lvl() are good but need to be multiplied as they're in 1dBm precision. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0367.c | 20 1

[PATCH 0/4] STV0367/DDB DVBv5 signal statistics

2017-06-20 Thread Daniel Scheller
From: Daniel Scheller This series adds DVBv5 statistics support to the new DDB codepath of the stv0367 demodulator driver. The changes utilise already existing functionality (in form of register readouts), but wraps the reads in separate functions so the existing relative scale reporting can be

[PATCH 1/4] [media] dvb-frontends/stv0367: initial DDB DVBv5 stats, implement ucblocks

2017-06-20 Thread Daniel Scheller
From: Daniel Scheller This adds the basics to stv0367ddb_get_frontend() to be able to properly provide signal statistics in DVBv5 format. Also adds UCB readout and provides those values. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0367.c | 59

DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-20 Thread Daniel Scheller
Am Tue, 20 Jun 2017 09:36:45 -0300 schrieb Mauro Carvalho Chehab : Hi Mauro, > Em Mon, 19 Jun 2017 22:18:21 +0200 > Daniel Scheller escreveu: > > > Well. From how things look, these and the cxd2841er+C2T2 ddbridge > > support patches won't make it in time

[PATCH] [media] dvb-frontends/lnbh25: improve kernellog output

2017-06-20 Thread Daniel Scheller
From: Daniel Scheller Use dev_dbg() in conjunction with the %*ph format macro to print the vmon status debug, thus hiding continuous hexdumping from default log levels. Also, change the attach success log line from error to info severity. Signed-off-by: Daniel Scheller --- drivers/media/dvb

Re: [PATCH 1/4] [media] dvb-frontends/stv0367: initial DDB DVBv5 stats, implement ucblocks

2017-06-21 Thread Daniel Scheller
Am Wed, 21 Jun 2017 09:06:22 +0300 schrieb Antti Palosaari : > On 06/20/2017 08:45 PM, Daniel Scheller wrote: > > From: Daniel Scheller > > > > This adds the basics to stv0367ddb_get_frontend() to be able to properly > > provide signal statistics in DVBv5 format

[PATCH] [media] ddbridge: use dev_* macros in favor of printk

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller Side effect: KERN_DEBUG messages aren't written to the kernel log anymore. This also improves the tda18212_ping reporting a bit so users know that if pinging wasn't successful, bad things will happen. Since in module_init_ddbridge() there's no dev yet,

Re: [PATCH 3/4] [media] dvb-frontends/stv0367: SNR DVBv5 statistics for DVB-C and T

2017-06-21 Thread Daniel Scheller
Am Wed, 21 Jun 2017 09:30:27 +0300 schrieb Antti Palosaari : > On 06/20/2017 08:45 PM, Daniel Scheller wrote: > > From: Daniel Scheller > > > > Add signal-to-noise-ratio as provided by the demodulator in decibel scale. > > QAM/DVB-C needs some intlog calculation to

Re: [PATCH] [media] ddbridge: use dev_* macros in favor of printk

2017-06-21 Thread Daniel Scheller
Am Wed, 21 Jun 2017 14:08:08 -0300 schrieb Mauro Carvalho Chehab : > Em Wed, 21 Jun 2017 18:53:47 +0200 > Daniel Scheller escreveu: > > > From: Daniel Scheller > > > > Side effect: KERN_DEBUG messages aren't written to the kernel log anymore. > > This als

[PATCH v2 0/4] STV0367/DDB DVBv5 signal statistics

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller This series adds DVBv5 statistics support to the new DDB codepath of the stv0367 demodulator driver. The changes utilise already existing functionality (in form of register readouts), but wraps the reads in separate functions so the existing relative scale reporting can be

[PATCH v2 2/4] [media] dvb-frontends/stv0367: split SNR determination into functions

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller The read_snr() functions currently do some magic to return relative scale values when called. Split out register readouts into separate functions so the functionality can be reused in some other way. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0367

[PATCH v2 4/4] [media] dvb-frontends/stv0367: DVB-C signal strength statistics

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller Provide QAM/DVB-C signal strength in decibel scale. Values returned from stv0367cab_get_rf_lvl() are good but need to be multiplied as they're in 1dBm precision. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0367.c | 21 + 1

[PATCH v2 1/4] [media] dvb-frontends/stv0367: initial DDB DVBv5 stats, implement ucblocks

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller This adds the basics to stv0367ddb_read_status() to be able to properly provide signal statistics in DVBv5 format. Also adds UCB readout and provides those values. Also, don't return -EINVAL in ddb_read_status() if active_demod_state indicates no delivery system. S

[PATCH v2 3/4] [media] dvb-frontends/stv0367: SNR DVBv5 statistics for DVB-C and T

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller Add signal-to-noise-ratio as provided by the demodulator in decibel scale. QAM/DVB-C needs some intlog calculation to have usable dB values, OFDM/ DVB-T values from the demod look alright already and are provided as-is. Signed-off-by: Daniel Scheller --- drivers/media

Re: [PATCH v2 0/4] STV0367/DDB DVBv5 signal statistics

2017-06-21 Thread Daniel Scheller
Am Wed, 21 Jun 2017 21:45:40 +0200 schrieb Daniel Scheller : > From: Daniel Scheller > > This series adds DVBv5 statistics support to the new DDB codepath of the > stv0367 demodulator driver. > > The changes utilise already existing functionality (in form of register > rea

Re: [PATCH] [media] ddbridge: use dev_* macros in favor of printk

2017-06-21 Thread Daniel Scheller
Am Wed, 21 Jun 2017 22:20:35 +0300 schrieb Antti Palosaari : > On 06/21/2017 08:20 PM, Mauro Carvalho Chehab wrote: > > Em Wed, 21 Jun 2017 19:14:40 +0200 > > Daniel Scheller escreveu: > > > >> I intentionally left this in for the pr_info used in > >>

[PATCH] [media] dvb-frontends/stv0367: deduplicate DDB dvb_frontend_ops caps

2017-06-21 Thread Daniel Scheller
From: Daniel Scheller Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0367.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/media/dvb-frontends/stv0367.c b/drivers/media/dvb-frontends/stv0367.c index e726c2e00460..b42b99ad4d3f

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-21 Thread Daniel Scheller
Am Tue, 20 Jun 2017 16:10:43 -0300 schrieb Mauro Carvalho Chehab : > Em Tue, 20 Jun 2017 20:41:21 +0200 > Daniel Scheller escreveu: > > > Not sure about Thomas, but I know that Jasmin doesn't own and/ore uses > > such cards. However, for upcoming patches, I'll try

[PATCH] [media] dvb-frontends/cxd2841er: require FE_HAS_SYNC for agc readout

2017-06-22 Thread Daniel Scheller
From: Daniel Scheller When the demod driver puts the demod into sleep or shutdown state and it's status is then polled e.g. via "dvb-fe-tool -m", i2c errors are printed to the kernel log. If the last delsys was DVB-T/T2: cxd2841er: i2c wr failed=-5 addr=6c reg=00 len=1 cx

[PATCH] [media] ddbridge: make (ddb)readl in while-loops fail-safe

2017-06-23 Thread Daniel Scheller
From: Daniel Scheller Reported by smatch: drivers/media/pci/ddbridge/ddbridge-core.c:1246 input_tasklet() warn: this loop depends on readl() succeeding drivers/media/pci/ddbridge/ddbridge-core.c:1768 flashio() warn: this loop depends on readl() succeeding drivers/media/pci/ddbridge

[PATCH 0/9] STV0910/STV6111 drivers, ddbridge CineS2 V7 support

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller For Linux 4.14. This series adds drivers for the ST STV0910 DVB-S/S2 demodulator ICs and the ST STV6111 DVB-S/S2 tuners, and utilises them to enable ddbridge to support the current line of Digital Devices DVB-S/S2 hardware (e.g. Cine S2 V7/V7A adapters, DuoFlex S2 V4 addon

[PATCH 2/9] [media] dvb-frontends/stv0910: Fix possible buffer overflow

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller Fixes smatch error: drivers/media/dvb-frontends/stv0910.c:715 DVBS2_nBCH() error: buffer overflow 'nBCH[FECType]' 2 <= 28 Also, fixes the nBCH array table by adding the DUMMY_PLF element at the top to match the enums (table element order was off by one be

[PATCH 3/9] [media] dvb-frontends/stv0910: add multistream (ISI) and PLS capabilities

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller Implements stream_id filter and scrambling code setup in Start() and also sets FE_CAN_MULTISTREAM in frontend_ops. This enables the driver to properly receive and handle multistream transponders, functionality has been reported working fine by testers with access to such

[PATCH 4/9] [media] dvb-frontends/stv0910: Fix signal strength reporting

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller Original code at least has some signed/unsigned issues, resulting in values like 32dBm. Change signal strength readout to work without asking the attached tuner, and use a lookup table instead of log calc. Values reported appear plausible. Obsoletes the INTLOG10X100 calc

[PATCH 6/9] [media] dvb-frontends: add ST STV6111 DVB-S/S2 tuner frontend driver

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller This adds a frontend driver for the ST STV6111 DVB-S/S2 tuners. Like the stv0910 demod frontend driver, this driver originates from the Digital Devices' dddvb vendor driver package as of version 0.9.29, and was cleaned up aswell. No functionality had to be removed t

[PATCH 5/9] [media] dvb-frontends/stv0910: Add missing set_frontend fe-op

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller This was missing from the frontend_ops. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0910.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/dvb-frontends/stv0910.c b/drivers/media/dvb-frontends/stv0910.c index c1875be01631

[PATCH 8/9] [media] ddbridge: support for CineS2 V7(A) and DuoFlex S2 V4 hardware

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller This adds all required glue code to support - in conjunction with the new stv0910 and stv6111 demod/tuner drivers and additionally the lnbh25 LNB controller driver - all current DVB-S/S2 hardware (bridges and flex modules) from Digital Devices like the DD CineS2 V7 and V7A

[PATCH 9/9] [media] ddbridge: stv0910 single demod mode module option

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller Adds a stv0910_single modparm which, when set, configures the stv0910 to run in single demodulator mode, currently intended for high bit rate testing. Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/ddbridge-core.c | 7 +++ 1 file changed, 7 insertions

[PATCH 7/9] [media] ddbridge: return stv09xx id in port_has_stv0900_aa()

2017-06-24 Thread Daniel Scheller
From: Daniel Scheller The returned value is required for further evaluation of the exact demodulator chip (stv090x or stv0910). Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/ddbridge-core.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH] [media] ddbridge: dev_* logging fixup

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller Fixup commit d52786ddd2d5 ("media: ddbridge: make (ddb)readl in while-loops fail-safe") after/wrt commit 11e358bf37e8 ("media: ddbridge: use dev_* macros in favor of printk") Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/ddbri

[PATCH] [media] dvb-frontends/cxd2841er: require STATE_ACTIVE_* for agc readout

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller When the demod driver puts the demod into sleep or shutdown state and it's status is then polled e.g. via "dvb-fe-tool -m", i2c errors are printed to the kernel log. If the last delsys was DVB-T/T2: cxd2841er: i2c wr failed=-5 addr=6c reg=00 len=1 cx

[PATCH v3 2/4] [media] dvb-frontends/stv0367: SNR DVBv5 statistics for DVB-C and T

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller Add signal-to-noise-ratio as provided by the demodulator in decibel scale. QAM/DVB-C needs some intlog calculation to have usable dB values, OFDM/ DVB-T values from the demod look alright already and are provided as-is. Signed-off-by: Daniel Scheller --- drivers/media

[PATCH v3 0/4] STV0367/DDB DVBv5 signal statistics

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller This series adds DVBv5 statistics support to the new DDB codepath of the stv0367 demodulator driver. The changes utilise already existing functionality (in form of register readouts), but wraps the reads in separate functions so the existing relative scale reporting can be

[PATCH v3 1/4] [media] dvb-frontends/stv0367: Improve DVB-C/T frontend status

2017-06-25 Thread Daniel Scheller
valho Chehab Tested-by: Daniel Scheller Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0367.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/stv0367.c b/drivers/media/dvb-frontends/stv0367.c index f266c18

[PATCH v3 3/4] [media] dvb-frontends/stv0367: DVB-C signal strength statistics

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller Provide QAM/DVB-C signal strength in decibel scale. Values returned from stv0367cab_get_rf_lvl() are good but need to be multiplied as they're in 1dBm precision. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0367.c | 21 + 1

[PATCH v3 4/4] [media] dvb-frontends/stv0367: update UCB readout condition logic

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller Since the other statistics are read when fe_status conditions are TRUE, change the ucblocks readout logic to match this aswell. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0367.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-25 Thread Daniel Scheller
m > > OK, we can do that, when adding a driver needing such feature. I might volunteer in adding DVB-C2 support to cxd2841er in porting needed bits over from the cxd2843 driver, but someone else need to do testing on a DVB-C2 enabled coax cable. Best regards, Daniel Scheller [1] http

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-26 Thread Daniel Scheller
meantime a decision should be made if the current in-kernel ddbridge should be kept somewhere or not (ie. as legacy driver). IMHO this is not absolutely neccessary since both driver variants (dddvb directly and the "castrated" one) are in use by people all around and besides MSI (which we can workaround until fixed finally) I don't know of any complaints at all. Best regards, Daniel Scheller -- https://github.com/herrnst

Re: [PATCH 4/9] [media] dvb-frontends/stv0910: Fix signal strength reporting

2017-06-26 Thread Daniel Scheller
Am Mon, 26 Jun 2017 10:55:34 +0200 schrieb Ralph Metzler : > Daniel Scheller writes: > > From: Daniel Scheller > > > > Original code at least has some signed/unsigned issues, resulting > > in values like 32dBm. > > I will look into that. > > &

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-26 Thread Daniel Scheller
rly) random attempt at fixing something which turned out unrelated and even doesn't apply as is anymore. But that patch might be a start to get this done. Best regards, Daniel Scheller -- https://github.com/herrnst

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-26 Thread Daniel Scheller
th the result, I will start a V2 series based on kernel_case naming. Best regards, Daniel Scheller -- https://github.com/herrnst

[PATCH v2 04/10] [media] dvb-frontends/stv0910: Add demod-only signal strength reporting

2017-06-30 Thread Daniel Scheller
From: Daniel Scheller Original code at least has some signed/unsigned issues, resulting in values like 32dBm. Implement signal strength readout to work without asking the attached tuner, and use a lookup table instead of log calc. Values reported appear plausible, gathered from feedback from

[PATCH v2 07/10] [media] ddbridge: return stv09xx id in port_has_stv0900_aa()

2017-06-30 Thread Daniel Scheller
From: Daniel Scheller The returned value is required for further evaluation of the exact demodulator chip (stv090x or stv0910). Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/ddbridge-core.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH v2 06/10] [media] dvb-frontends: add ST STV6111 DVB-S/S2 tuner frontend driver

2017-06-30 Thread Daniel Scheller
From: Daniel Scheller This adds a frontend driver for the ST STV6111 DVB-S/S2 tuners. Like the stv0910 demod frontend driver, this driver originates from the Digital Devices' dddvb vendor driver package as of version 0.9.29, and was cleaned up aswell. No functionality had to be removed t

[PATCH v2 10/10] [media] MAINTAINERS: add entries for stv0910 and stv6111

2017-06-30 Thread Daniel Scheller
From: Daniel Scheller Signed-off-by: Daniel Scheller --- MAINTAINERS | 16 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c4be6d4af7d2..7b85e578d238 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8246,6 +8246,22 @@ T: git git://linuxtv.org

[PATCH v2 08/10] [media] ddbridge: support for CineS2 V7(A) and DuoFlex S2 V4 hardware

2017-06-30 Thread Daniel Scheller
From: Daniel Scheller This adds all required glue code to support - in conjunction with the new stv0910 and stv6111 demod/tuner drivers and additionally the lnbh25 LNB controller driver - all current DVB-S/S2 hardware (bridges and flex modules) from Digital Devices like the DD CineS2 V7 and V7A

[PATCH v2 00/10] STV0910/STV6111 drivers, ddbridge CineS2 V7 support

2017-06-30 Thread Daniel Scheller
From: Daniel Scheller For Linux 4.14. This series adds drivers for the ST STV0910 DVB-S/S2 demodulator ICs and the ST STV6111 DVB-S/S2 tuners, and utilises them to enable ddbridge to support the current line of Digital Devices DVB-S/S2 hardware (e.g. Cine S2 V7/V7A adapters, DuoFlex S2 V4 addon

[PATCH v2 02/10] [media] dvb-frontends/stv0910: Fix possible buffer overflow

2017-06-30 Thread Daniel Scheller
From: Daniel Scheller Fixes smatch error: drivers/media/dvb-frontends/stv0910.c:715 dvbs2_nbch() error: buffer overflow 'nbch[fectype]' 2 <= 28 Also, fixes the nbch array table by adding the DUMMY_PLF element at the top to match the enums (table element order was off by one be

[PATCH v2 05/10] [media] dvb-frontends/stv0910: Add missing set_frontend fe-op

2017-06-30 Thread Daniel Scheller
From: Daniel Scheller This was missing from the frontend_ops. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0910.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/dvb-frontends/stv0910.c b/drivers/media/dvb-frontends/stv0910.c index 045f8f5305ab

[PATCH v2 09/10] [media] ddbridge: stv0910 single demod mode module option

2017-06-30 Thread Daniel Scheller
From: Daniel Scheller Adds a stv0910_single modparm which, when set, configures the stv0910 to run in single demodulator mode, currently intended for high bit rate testing. Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/ddbridge-core.c | 7 +++ 1 file changed, 7 insertions

[PATCH v2 03/10] [media] dvb-frontends/stv0910: add multistream (ISI) and PLS capabilities

2017-06-30 Thread Daniel Scheller
From: Daniel Scheller Implements stream_id filter and scrambling code setup in start() and also sets FE_CAN_MULTISTREAM in frontend_ops. This enables the driver to properly receive and handle multistream transponders, functionality has been reported working fine by testers with access to such

[PATCH v3 02/10] [media] dvb-frontends/stv0910: Fix possible buffer overflow

2017-07-03 Thread Daniel Scheller
From: Daniel Scheller Fixes smatch error: drivers/media/dvb-frontends/stv0910.c:715 dvbs2_nbch() error: buffer overflow 'nbch[fectype]' 2 <= 28 Also, fixes the nbch array table by adding the DUMMY_PLF element at the top to match the enums (table element order was off by one be

[PATCH v3 00/10] STV0910/STV6111 drivers, ddbridge CineS2 V7 support

2017-07-03 Thread Daniel Scheller
From: Daniel Scheller For Linux 4.14. This v3 is a fixup for the previously posted v2. Smatch and W=1 uncovered three additional issues in the stv6111 driver, see the v3 notes below. While at it, few things have been fixed in patch 1 (initial stv0910 driver). Sorry for the noise and the mail

[PATCH v3 10/10] [media] MAINTAINERS: add entries for stv0910 and stv6111

2017-07-03 Thread Daniel Scheller
From: Daniel Scheller Signed-off-by: Daniel Scheller --- MAINTAINERS | 16 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c4be6d4af7d2..7b85e578d238 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8246,6 +8246,22 @@ T: git git://linuxtv.org

[PATCH v3 09/10] [media] ddbridge: stv0910 single demod mode module option

2017-07-03 Thread Daniel Scheller
From: Daniel Scheller Adds a stv0910_single modparm which, when set, configures the stv0910 to run in single demodulator mode, currently intended for high bit rate testing. Signed-off-by: Daniel Scheller Tested-by: Richard Scobie --- drivers/media/pci/ddbridge/ddbridge-core.c | 7 +++ 1

[PATCH v3 06/10] [media] dvb-frontends: add ST STV6111 DVB-S/S2 tuner frontend driver

2017-07-03 Thread Daniel Scheller
From: Daniel Scheller This adds a frontend driver for the ST STV6111 DVB-S/S2 tuners. Like the stv0910 demod frontend driver, this driver originates from the Digital Devices' dddvb vendor driver package as of version 0.9.29, and was cleaned up aswell. No functionality had to be removed t

[PATCH v3 05/10] [media] dvb-frontends/stv0910: Add missing set_frontend fe-op

2017-07-03 Thread Daniel Scheller
From: Daniel Scheller This was missing from the frontend_ops. Signed-off-by: Daniel Scheller Tested-by: Richard Scobie --- drivers/media/dvb-frontends/stv0910.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/dvb-frontends/stv0910.c b/drivers/media/dvb-frontends/stv0910.c

[PATCH v3 04/10] [media] dvb-frontends/stv0910: Add demod-only signal strength reporting

2017-07-03 Thread Daniel Scheller
From: Daniel Scheller Original code at least has some signed/unsigned issues, resulting in values like 32dBm. Implement signal strength readout to work without asking the attached tuner, and use a lookup table instead of log calc. Values reported appear plausible, gathered from feedback from

[PATCH v3 08/10] [media] ddbridge: support for CineS2 V7(A) and DuoFlex S2 V4 hardware

2017-07-03 Thread Daniel Scheller
From: Daniel Scheller This adds all required glue code to support - in conjunction with the new stv0910 and stv6111 demod/tuner drivers and additionally the lnbh25 LNB controller driver - all current DVB-S/S2 hardware (bridges and flex modules) from Digital Devices like the DD CineS2 V7 and V7A

[PATCH v3 03/10] [media] dvb-frontends/stv0910: add multistream (ISI) and PLS capabilities

2017-07-03 Thread Daniel Scheller
From: Daniel Scheller Implements stream_id filter and scrambling code setup in start() and also sets FE_CAN_MULTISTREAM in frontend_ops. This enables the driver to properly receive and handle multistream transponders, functionality has been reported working fine by testers with access to such

[PATCH v3 07/10] [media] ddbridge: return stv09xx id in port_has_stv0900_aa()

2017-07-03 Thread Daniel Scheller
From: Daniel Scheller The returned value is required for further evaluation of the exact demodulator chip (stv090x or stv0910). Signed-off-by: Daniel Scheller Tested-by: Richard Scobie --- drivers/media/pci/ddbridge/ddbridge-core.c | 9 - 1 file changed, 4 insertions(+), 5 deletions

Re: [PATCH v2 01/10] [media] dvb-frontends: add ST STV0910 DVB-S/S2 demodulator frontend driver

2017-07-03 Thread Daniel Scheller
fe.dtv_propcache vars/references to the dummy STR function, fixes bisect" in v3-1/10). Best regards, Daniel Scheller -- https://github.com/herrnst

[PATCH] [media] dvb-frontends/stv0367: DDB frontend status inquiry fixup

2017-07-09 Thread Daniel Scheller
From: Daniel Scheller Return 0 instead of -EINVAL in get_frontend if no demod mode is active. This fixes ie. dvb-fe-tool getting confused and assuming a DVBv3 FE on idle frontends when the FE has been put to sleep using sleep(). Also, in read_status(), don't immediately return when no dem

[PATCH 00/14] ddbridge: bump to ddbridge-0.9.29

2017-07-09 Thread Daniel Scheller
From: Daniel Scheller Preferrably for Linux 4.14 (to get things done). Hard-depends on the STV0910/STV6111 driver patchset as the diff and the updated code depends on the driver and the changes involved with the glue code of the STV/DDCineS2V7 series [1]. Mauro/Media maintainers, this updates

[PATCH 02/14] [media] ddbridge: split code into multiple files

2017-07-09 Thread Daniel Scheller
From: Daniel Scheller As of 0.9.9b, the ddbridge code has been split from one single file (ddbridge-core.c) into multiple files, with the purpose of taking care of different topics, and to be able to reuse code in different kernel modules (ddbridge.ko and octonet.ko). This applies the same code

[PATCH 01/14] [media] ddbridge: move/reorder functions

2017-07-09 Thread Daniel Scheller
From: Daniel Scheller The functions in ddbridge-core.c have been moved to different positions in newer versions of the dddvb vendor driver package (most notably in version 0.9.9b). Perform the same code move to keep the diff of the upcoming code bump simpler. Signed-off-by: Daniel Scheller

<    1   2   3   4   5   6   >