Re: [PATCH 0/5] SPDX license identifiers in all DD drivers

2018-03-21 Thread Daniel Scheller
Hi Greg, Am Wed, 21 Mar 2018 10:49:32 +0100 schrieb Greg KH : > On Tue, Mar 20, 2018 at 10:01:27PM +0100, Daniel Scheller wrote: > > From: Daniel Scheller > > > > This series adds SPDX license identifiers to all source files which are > > copyright by either Digital

Re: Cine CT V6.1 code change request

2017-02-19 Thread Daniel Scheller
ly with the STV and also the CXD28xx-based tuners. The work on this was done in around 2013 or so by Antti Palosaari (see [2]), and it worked out so nicely when I first started tackling things I never cared to pick up the tda18212DD :-) Best regards, Daniel Scheller [1] https://github.com/herrn

[PATCH 02/13] [media] dvb-frontends/stv0367: print CPAMP status only if stv_debug is enabled

2017-03-07 Thread Daniel Scheller
From: Daniel Scheller The CPAMP log lines generated in stv0367_ter_check_cpamp() are printed everytime tuning succeeds or fails, quite cluttering the normal kernel log. Use dprintk() instead of printk(KERN_ERR...) so that if the information is needed, it'll be printed when the stv_debug mod

[PATCH 04/13] [media] dvb-frontends/stv0367: move out tables, support multiple tab variants

2017-03-07 Thread Daniel Scheller
From: Daniel Scheller Move the *ter and *cab st_register tables into a separate header file and additionally organize them via a multidimensional array, allowing to add more tables with differing init values, and also prepare for a base init table which should contain general setup values. Also

[PATCH 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware

2017-03-07 Thread Daniel Scheller
From: Daniel Scheller These patches enhance the functionality of dvb-frontends/stv0367 to work with Digital Devices hardware driven by the ST STV0367 demodulator chip and adds probe & attach bits to ddbridge to make use of them, effectively enabling full support for CineCTv6 PCIe bridges

[PATCH 07/13] [media] dvb-frontends/stv0367: support reading if_khz from tuner config

2017-03-07 Thread Daniel Scheller
From: Daniel Scheller Currently, if_khz is set and provided using the configuration var in struct stv0367_config. However, in some constellations, the value might be different for differing channel bandwidths or even -T and -C operation. When e.g. used in conjunction with TDA18212 tuners, the

[PATCH 08/13] [media] dvb-frontends/stv0367: selectable QAM FEC Lock status register

2017-03-07 Thread Daniel Scheller
From: Daniel Scheller In some configurations (due to different PIN config, wiring or so), the QAM FECLock might be signalled using a different register than F367CAB_QAMFEC_LOCK (e.g. F367CAB_DESCR_SYNCSTATE on Digital Devices hw), so make that register selectable. Signed-off-by: Daniel Scheller

[PATCH 06/13] [media] dvb-frontends/stv0367: make full reinit on set_frontend() optional

2017-03-07 Thread Daniel Scheller
From: Daniel Scheller Every time dvb_frontend_ops.set_frontend() is called, an almost full reinit of the demodulator will be performed. While this might cause a slight delay when switching channels due to all involved tables being rewritten, it can even be dangerous in certain causes in that the

[PATCH 05/13] [media] dvb-frontends/stv0367: make PLLSETUP a function, add 58MHz IC speed

2017-03-07 Thread Daniel Scheller
From: Daniel Scheller This moves the PLL SETUP code from stv0367ter_init() into a dedicated function, and also make it possible to configure 58Mhz IC speed at 27MHz Xtal (used on STV0367-based DDB cards/modules in QAM mode). Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends

[PATCH 13/13] [media] ddbridge: support STV0367-based cards and modules

2017-03-07 Thread Daniel Scheller
From: Daniel Scheller This adds detection and activation for STV0367-based tuner hardware (namely CineCTv6 bridge cards and older DuoFlex CT addon modules). Utilises the extended stv0367 demod driver, and needs the init_retry when attaching the TDA18212 tuner. TDA18212 i2c_client/regmap-api

[PATCH 09/13] [media] dvb-frontends/stv0367: fix symbol rate conditions in cab_SetQamSize()

2017-03-07 Thread Daniel Scheller
From: Daniel Scheller The values used for comparing symbol rates and the resulting conditional reg writes seem wrong (rates multiplied by ten), so fix those values. While this doesn't seem to influence operation, it should be fixed anyway. Signed-off-by: Daniel Scheller --- drivers/medi

[PATCH 03/13] [media] dvb-frontends/stv0367: refactor defaults table handling

2017-03-07 Thread Daniel Scheller
From: Daniel Scheller Change defaults table writing so tables can be of dynamic length without having to keep track of their lengths by adding and evaluating an end marker (reg 0x), also move table writing to a dedicated function to remove code duplication. Additionally mark st_register

[PATCH 10/13] [media] dvb-frontends/stv0367: add defaults for use w/DD-branded devices

2017-03-07 Thread Daniel Scheller
From: Daniel Scheller Digital Devices uses defaults tables in their stv0367dd demod driver variant which differ in a few registers, at least enough that no stable operation can be provided with the tables already present in the driver (init succeeds and DVB reception works but at least when the

[PATCH 12/13] [media] tuners/tda18212: add flag for retrying tuner init on failure

2017-03-07 Thread Daniel Scheller
From: Daniel Scheller Taken from tda18212dd, first read after cold reset sometimes fails on some cards, trying twice shall do the trick. This is the case with the STV0367 demods soldered on the CineCTv6 bridge boards and older DuoFlex CT modules. All other users (configs) of the tda18212 are

[PATCH 11/13] [media] dvb-frontends/stv0367: add Digital Devices compatibility

2017-03-07 Thread Daniel Scheller
From: Daniel Scheller This - in conjunction with the previous changes - makes it possible to use the STV0367 DVB-C/T demodulator driver with Digital Devices hardware having this demodulator soldered on them (namely CineCTv6 bridges and some earlier DuoFlex CT addon modules). The changes do the

[PATCH 01/13] [media] dvb-frontends/stv0367: add flag to make i2c_gatectrl optional

2017-03-07 Thread Daniel Scheller
From: Daniel Scheller There can be use cases (bridges, namely ddbridge) which will care about gate control in a way that involves mutex_locks and remapped i2c_gatectrl FE ops. If the demod driver (additionally) performs it's own gate control and there's something else that already too

Re: [PATCH 12/13] [media] tuners/tda18212: add flag for retrying tuner init on failure

2017-03-14 Thread Daniel Scheller
Am Mon, 13 Mar 2017 16:16:29 +0200 schrieb Antti Palosaari : > On 03/07/2017 08:57 PM, Daniel Scheller wrote: > > From: Daniel Scheller > > > > Taken from tda18212dd, first read after cold reset sometimes fails > > on some cards, trying twice shall do the trick. Th

[PATCH] [media] dvb-frontends/drxk: don't log errors on unsupported operation mode

2017-03-14 Thread Daniel Scheller
From: Daniel Scheller When fe_ops.read_status is called and no channel is tuned (yet), the subsequent calls to get_lock_status() causes the kernel log to be filled with drxk: Error -22 on get_lock_status which either means a NULL pointer was passed for the p_lock_status var, or neither QAM

[PATCH] [media] dvb-frontends/cxd2841er: define symbol_rate_min/max in T/C fe-ops

2017-03-19 Thread Daniel Scheller
From: Daniel Scheller Fixes "w_scan -f c" complaining with This dvb driver is *buggy*: the symbol rate limits are undefined - please report to linuxtv.org) Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/cxd2841er.c | 4 +++- 1 file changed, 3 insertions(+),

Re: [PATCH 11/13] [media] dvb-frontends/stv0367: add Digital Devices compatibility

2017-03-20 Thread Daniel Scheller
Am Tue, 7 Mar 2017 19:57:25 +0100 schrieb Daniel Scheller : > - add a third *_attach function which will make use of a third > frontend_ops struct which announces both -C and -T support (the same > as with DD's own driver stv0367dd). This is necessary to support both > delivery

[PATCH v2 02/12] [media] dvb-frontends/stv0367: print CPAMP status only if stv_debug is enabled

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller The CPAMP log lines generated in stv0367_ter_check_cpamp() are printed everytime tuning succeeds or fails, quite cluttering the normal kernel log. Use dprintk() instead of printk(KERN_ERR...) so that if the information is needed, it'll be printed when the stv_debug mod

[PATCH v2 09/12] [media] dvb-frontends/stv0367: fix symbol rate conditions in cab_SetQamSize()

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller The values used for comparing symbol rates and the resulting conditional reg writes seem wrong (rates multiplied by ten), so fix those values. While this doesn't seem to influence operation, it should be fixed anyway. Signed-off-by: Daniel Scheller --- drivers/medi

[PATCH v2 08/12] [media] dvb-frontends/stv0367: selectable QAM FEC Lock status register

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller In some configurations (due to different PIN config, wiring or so), the QAM FECLock might be signalled using a different register than F367CAB_QAMFEC_LOCK (e.g. F367CAB_DESCR_SYNCSTATE on Digital Devices hw), so make that register selectable. Signed-off-by: Daniel Scheller

[PATCH v2 03/12] [media] dvb-frontends/stv0367: refactor defaults table handling

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller Change defaults table writing so tables can be of dynamic length without having to keep track of their lengths by adding and evaluating an end marker (reg 0x), also move table writing to a dedicated function to remove code duplication. Additionally mark st_register

[PATCH v2 01/12] [media] dvb-frontends/stv0367: add flag to make i2c_gatectrl optional

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller Some hardware and bridges (namely ddbridge) require that tuner access is limited to one concurrent access and wrap i2c gate control with a mutex_lock when attaching frontends. According to vendor information, this is required as concurrent tuner reconfiguration can

[PATCH v2 07/12] [media] dvb-frontends/stv0367: support reading if_khz from tuner config

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller Currently, if_khz is set and provided using the configuration var in struct stv0367_config. However, in some constellations, the value might be different for differing channel bandwidths or even -T and -C operation. When e.g. used in conjunction with TDA18212 tuners, the

[PATCH v2 00/12] stv0367/ddbridge: support CTv6/FlexCT hardware

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller These patches enhance the functionality of dvb-frontends/stv0367 to work with Digital Devices hardware driven by the ST STV0367 demodulator chip and adds probe & attach bits to ddbridge to make use of them, effectively enabling full support for CineCTv6 PCIe bridges

[PATCH v2 04/12] [media] dvb-frontends/stv0367: move out tables, support multiple tab variants

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller Move the *ter and *cab st_register tables into a separate header file and additionally organize them via a multidimensional array, allowing to add more tables with differing init values, and also prepare for a base init table which should contain general setup values. Also

[PATCH v2 06/12] [media] dvb-frontends/stv0367: make full reinit on set_frontend() optional

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller Every time dvb_frontend_ops.set_frontend() is called, an almost full reinit of the demodulator will be performed. While this might cause a slight delay when switching channels due to all involved tables being rewritten, it can even be dangerous in certain causes in that the

[PATCH v2 10/12] [media] dvb-frontends/stv0367: add defaults for use w/DD-branded devices

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller Digital Devices uses defaults tables in their stv0367dd demod driver variant which differ in a few registers, at least enough that no stable operation can be provided with the tables already present in the driver (init succeeds and DVB reception works but at least when the

[PATCH v2 05/12] [media] dvb-frontends/stv0367: make PLLSETUP a function, add 58MHz IC speed

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller This moves the PLL SETUP code from stv0367ter_init() into a dedicated function, and also make it possible to configure 58Mhz IC speed at 27MHz Xtal (used on STV0367-based DDB cards/modules in QAM mode). Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends

[PATCH v2 11/12] [media] dvb-frontends/stv0367: add Digital Devices compatibility

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller This - in conjunction with the previous changes - makes it possible to use the STV0367 DVB-C/T demodulator driver with Digital Devices hardware having this demodulator soldered on them (namely CineCTv6 bridges and some earlier DuoFlex CT addon modules). The changes do the

[PATCH v2 12/12] [media] ddbridge: support STV0367-based cards and modules

2017-03-24 Thread Daniel Scheller
From: Daniel Scheller This adds detection and activation for STV0367-based tuner hardware (namely CineCTv6 bridge cards and older DuoFlex CT addon modules). Utilises the extended stv0367 demod driver. TDA18212 i2c_client/regmap-api code was originally implemented by Antti Palosaari in a

Re: [PATCH v2 12/12] [media] ddbridge: support STV0367-based cards and modules

2017-03-25 Thread Daniel Scheller
Am Fri, 24 Mar 2017 19:24:08 +0100 schrieb Daniel Scheller : > When boards with STV0367 are cold-started, there might be issues with > the I2C gate, causing the TDA18212 detection/probe to fail. For these > demods, a workaround is implemented to do the tuner probe again which > wi

Re: [PATCH v2 01/12] [media] dvb-frontends/stv0367: add flag to make i2c_gatectrl optional

2017-03-26 Thread Daniel Scheller
Am Sun, 26 Mar 2017 10:03:33 +0200 schrieb Matthias Schwarzott : > Am 24.03.2017 um 19:23 schrieb Daniel Scheller: > > From: Daniel Scheller > > > > Some hardware and bridges (namely ddbridge) require that tuner > > access is limited to one concurrent access and wrap

Re: [PATCH v2 12/12] [media] ddbridge: support STV0367-based cards and modules

2017-03-26 Thread Daniel Scheller
> url: > https://github.com/0day-ci/linux/commits/Daniel-Scheller/stv0367-ddbridge-support-CTv6-FlexCT-hardware/20170326-235957 > base: git://linuxtv.org/media_tree.git master config: > x86_64-rhel-7.2 (attached as .config) compiler: gcc-6 (Debian > 6.2.0-3) 6.2.0 20160901 reproduce:

[PATCH v3 07/13] [media] dvb-frontends/stv0367: support reading if_khz from tuner config

2017-03-29 Thread Daniel Scheller
From: Daniel Scheller Currently, if_khz is set and provided using the configuration var in struct stv0367_config. However, in some constellations, the value might be different for differing channel bandwidths or even -T and -C operation. When e.g. used in conjunction with TDA18212 tuners, the

[PATCH v3 05/13] [media] dvb-frontends/stv0367: make PLLSETUP a function, add 58MHz IC speed

2017-03-29 Thread Daniel Scheller
From: Daniel Scheller This moves the PLL SETUP code from stv0367ter_init() into a dedicated function, and also make it possible to configure 58Mhz IC speed at 27MHz Xtal (used on STV0367-based DDB cards/modules in QAM mode). Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends

[PATCH v3 03/13] [media] dvb-frontends/stv0367: refactor defaults table handling

2017-03-29 Thread Daniel Scheller
From: Daniel Scheller Change defaults table writing so tables can be of dynamic length without having to keep track of their lengths by adding and evaluating an end marker (reg 0x), also move table writing to a dedicated function to remove code duplication. Additionally mark st_register

[PATCH v3 02/13] [media] dvb-frontends/stv0367: print CPAMP status only if stv_debug is enabled

2017-03-29 Thread Daniel Scheller
From: Daniel Scheller The CPAMP log lines generated in stv0367_ter_check_cpamp() are printed everytime tuning succeeds or fails, quite cluttering the normal kernel log. Use dprintk() instead of printk(KERN_ERR...) so that if the information is needed, it'll be printed when the stv_debug mod

[PATCH v3 08/13] [media] dvb-frontends/stv0367: selectable QAM FEC Lock status register

2017-03-29 Thread Daniel Scheller
From: Daniel Scheller In some configurations (due to different PIN config, wiring or so), the QAM FECLock might be signalled using a different register than F367CAB_QAMFEC_LOCK (e.g. F367CAB_DESCR_SYNCSTATE on Digital Devices hw), so make that register selectable. Signed-off-by: Daniel Scheller

[PATCH v3 06/13] [media] dvb-frontends/stv0367: make full reinit on set_frontend() optional

2017-03-29 Thread Daniel Scheller
From: Daniel Scheller Every time dvb_frontend_ops.set_frontend() is called, an almost full reinit of the demodulator will be performed. While this might cause a slight delay when switching channels due to all involved tables being rewritten, it can even be dangerous in certain causes in that the

[PATCH v3 11/13] [media] dvb-frontends/stv0367: add Digital Devices compatibility

2017-03-29 Thread Daniel Scheller
From: Daniel Scheller This - in conjunction with the previous changes - makes it possible to use the STV0367 DVB-C/T demodulator driver with Digital Devices hardware having this demodulator soldered on them (namely CineCTv6 bridges and some earlier DuoFlex CT addon modules). The changes do the

[PATCH v3 01/13] [media] dvb-frontends/stv0367: add flag to make i2c_gatectrl optional

2017-03-29 Thread Daniel Scheller
From: Daniel Scheller Some hardware and bridges (namely ddbridge) require that tuner access is limited to one concurrent access and wrap i2c gate control with a mutex_lock when attaching frontends. According to vendor information, this is required as concurrent tuner reconfiguration can

[PATCH v3 10/13] [media] dvb-frontends/stv0367: add defaults for use w/DD-branded devices

2017-03-29 Thread Daniel Scheller
From: Daniel Scheller Digital Devices uses defaults tables in their stv0367dd demod driver variant which differ in a few registers, at least enough that no stable operation can be provided with the tables already present in the driver (init succeeds and DVB reception works but at least when the

[PATCH v3 13/13] [media] ddbridge: support STV0367-based cards and modules

2017-03-29 Thread Daniel Scheller
From: Daniel Scheller This adds detection and activation for STV0367-based tuner hardware (namely CineCTv6 bridge cards and older DuoFlex CT addon modules). Utilises the extended stv0367 demod driver. TDA18212 i2c_client/regmap-api code was originally implemented by Antti Palosaari in a

[PATCH v3 04/13] [media] dvb-frontends/stv0367: move out tables, support multiple tab variants

2017-03-29 Thread Daniel Scheller
From: Daniel Scheller Move the *ter and *cab st_register tables into a separate header file and additionally organize them via a multidimensional array, allowing to add more tables with differing init values, and also prepare for a base init table which should contain general setup values. Also

[PATCH v3 09/13] [media] dvb-frontends/stv0367: fix symbol rate conditions in cab_SetQamSize()

2017-03-29 Thread Daniel Scheller
From: Daniel Scheller The values used for comparing symbol rates and the resulting conditional reg writes seem wrong (rates multiplied by ten), so fix those values. While this doesn't seem to influence operation, it should be fixed anyway. Signed-off-by: Daniel Scheller --- drivers/medi

[PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware

2017-03-29 Thread Daniel Scheller
From: Daniel Scheller Third iteration of the DD CineCTv6/FlexCT support patches with mostly all things cleaned up that popped up so far. Obsoletes V1 and V2 series. These patches enhance the functionality of dvb-frontends/stv0367 to work with Digital Devices hardware driven by the ST STV0367

[PATCH v3 12/13] [media] ddbridge: add i2c_read_regs()

2017-03-29 Thread Daniel Scheller
From: Daniel Scheller Adds new i2c_read_regs() function and make i2c_read_reg() wrap into this with len=1. Required for the tuner_tda18212_ping() and XO2 handling functions (part of the Sony CXD28xx support patch series). Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/ddbridge

[PATCH 02/19] [media] dvb-frontends/cxd2841er: do I2C reads in one go

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller Doing the I2C read operation with two calls to i2c_transfer() causes the exclusive I2C bus lock of the underlying adapter to be released. While this isn't an issue if only one demodulator is attached to the bus, having two or even more causes troubles in that concu

[PATCH 00/19] cxd2841er/ddbridge: support Sony CXD28xx hardware

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller Important note: This series depends on the stv0367/ddbridge series posted earlier (patches 12 [1] and 13 [2], depending on the I2C functions and the TDA18212 attach function). This series improves the cxd2841er demodulator driver and adds some bits to make it more

[PATCH 01/19] [media] dvb-frontends/cxd2841er: remove kernel log spam in non-debug levels

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller This moves the I2C debug dump into the preceding dev_dbg() call by utilising the %*ph format macro and removes the call to print_hex_debug_bytes(). Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/cxd2841er.c | 6 ++ 1 file changed, 2 insertions(+), 4

[PATCH 10/19] [media] dvb-frontends/cxd2841er: make ASCOT use optional

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller The Sony CXD28xx demods may have other tuner types attached to them (e.g. NXP TDA18212), so don't mandatorily configure and enable the ASCOT functionality, but make this conditional by a config flag. Signed-off-by: Daniel Scheller --- drivers/media/dvb-fron

[PATCH 04/19] [media] dvb-frontends/cxd2841er: support CXD2837/38/43ER demods/Chip IDs

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller Those demods are programmed in the same way as the CXD2841ER/54ER and can be handled by this driver. Support added in a way matching the existing code, supported delivery systems are set according to what each demod supports. Updates the type string setting used for

[PATCH 09/19] [media] dvb-frontends/cxd2841er: TS_SERIAL config flag

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller Some constellations work/need a serial TS transport mode. This adds a flag that will toggle set up of such mode. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/cxd2841er.c | 18 -- drivers/media/dvb-frontends/cxd2841er.h | 5 +++-- 2

[PATCH 03/19] [media] dvb-frontends/cxd2841er: immediately unfreeze regs when done

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller Do unfreeze_regs() directly when accessing the demod registers is done, and don't have multiple unfreeze's on different conditions, which even can get prone to errors. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/cxd284

[PATCH 12/19] [media] dvb-frontends/cxd2841er: make lock wait in set_fe_tc() optional

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller Don't wait for FE_HAS_LOCK in set_frontend_tc() and thus don't hammer the lock status register with inquiries when CXD2841ER_NO_WAIT_LOCK is set in the configuration, which also unneccessarily blocks applications until a TS LOCK has been acquired. Rathe

[PATCH 15/19] [media] dvb-frontends/cxd2841er: improved snr reporting

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller On DVB-T/T2 at least, SNR might be reported as >2500dB, which not only is just wrong but also ridiculous, so fix this by improving the conversion of the register value. The INTLOG10X100 function/macro and the way the values are converted were both taken from DD's

[PATCH 06/19] [media] dvb-frontends/cxd2841er: add variable for configuration flags

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller Throughout the patch series some configuration flags will be added to the demod driver. This patch prepares this by adding the flags var to struct cxd2841er_config, which will serve as a bitmask to toggle various options and behaviour in the driver. Signed-off-by: Daniel

[PATCH 14/19] [media] dvb-frontends/cxd2841er: more configurable TSBITS

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller Bits 3 and 4 of the TSCONFIG register are important for certain hardware constellations, in that they need to be zeroed. Add a configuration flag to toggle this. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/cxd2841er.c | 4 drivers/media/dvb

[PATCH 05/19] [media] dvb-frontends/cxd2841er: replace IFFREQ calc macros into functions

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller The way the MAKE_IFFREQ_CONFIG macros are written make it impossible to pass regular integers for iffreq calculation, since this will cause "SSE register return with SSE disabled" compile errors. This changes the calculation into C functions which also might

[PATCH 07/19] [media] dvb-frontends/cxd2841er: make call to i2c_gate_ctrl optional

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller Some cards/bridges wrap i2c_gate_ctrl handling with a mutex_lock(). This is e.g. done in ddbridge to protect against concurrent tuner access with regards to the dual tuner HW, where concurrent tuner reconfiguration can result in tuning fails or bad reception quality. When

[PATCH 13/19] [media] dvb-frontends/cxd2841er: configurable IFAGCNEG

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller Adds a flag to enable or disable the IFAGCNEG bit in cxd2841er_init_tc(). Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/cxd2841er.c | 5 +++-- drivers/media/dvb-frontends/cxd2841er.h | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a

[PATCH 18/19] [media] ddbridge: support for Sony CXD28xx C/C2/T/T2 tuner modules

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller Properly detect and attach Ports and Flex modules with the Sony CXD28xxER series demods. This makes newer Cine cards and most DuoFlex C/C2/T/T2 (or any combination of these systems) work, PCI IDs need to be added though. Note: This utilises the CXD2841ER demod driver

[PATCH 08/19] [media] dvb-frontends/cxd2841er: support IF speed calc from tuner values

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller Add a AUTO_IFHZ flag and a function that will read IF speed values from any attached tuner if the tuner supports this and if AUTO_IFHZ is enabled, and else the passed default value (which probably matches Sony ASCOT tuners) will be passed back. The returned value is then

[PATCH 16/19] [media] ddbridge: board control setup, ts quirk flags

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller This is a backport of the board control setup from the vendor provided dddvb driver package, which does additional device initialisation based on the board_control device info values. Also backports the TS quirk flags which is used to control setup and usage of the tuner

[PATCH 17/19] [media] ddbridge: add I2C functions, add XO2 module support

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller Some Flex modules (mostly with anyof C/C2/T/T2 demods based on the Sony CXD28xxER series) are equipped with an interface named XO2 (which appears to be the Lattice MachXO2). Add functionality to detect such links and initialise them, so any tuner module with such an

[PATCH 19/19] [media] ddbridge: hardware IDs for new C2T2 cards and other devices

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller Adds hardware IDs for all Sony CXD-based Cine-cards and MaxA8 devices, also adds some other yet missing IDs like the Octopus V3, Octopus OEM and Octopus Mini, as well as cards with unknown/deleted sub-ids. Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge

[PATCH 11/19] [media] dvb-frontends/cxd2841er: optionally tune earlier in set_frontend()

2017-04-09 Thread Daniel Scheller
From: Daniel Scheller When AUTO_IFHZ is set and the tuner is supposed to provide proper IF speed values, it should be possible to have the tuner setup take place before the demod is configured, else the demod might be configured with either wrong (old), or even no values at all, which obviously

[PATCH RESEND] media: mxl5xx: fix tuning logic

2017-10-15 Thread Daniel Scheller
From: Mauro Carvalho Chehab The tuning logic is broken with regards to status report: it relies on a previously-cached value that may not be valid if retuned. Change the logic to always read the status. Signed-off-by: Mauro Carvalho Chehab Acked-by: Daniel Scheller --- Resend (ref. https

[PATCH for 4.15] ddbridge update to 0.9.32

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller For the 4.15 merge window. These patches update the mainline ddbridge driver to version 0.9.32, which was released ~3 weeks ago by upstream. Nothing really fancy in this series, in fact upstream applied many of the changes that went into the mainline driver, which was

[PATCH 7/8] [media] stv0910: read and update mod_cod in read_status()

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller Add missing state->modcod update from upstream driver which needs to be done when manage_matype_info() sets is_vcm on certain S2 transponders. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0910.c | 13 + 1 file changed, 13 inserti

[PATCH 2/8] [media] ddbridge: fixup checkpatch-strict issues

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller Fixes several alignment, braces, space-before-cast, camelcase et al issues reported by checkpatch --strict, plus a few more checkpatch didn't report. Three checks are left after this though: - one CamelCase in ddbridge-core, related to defines/vars/enums referenced

[PATCH 1/8] [media] ddbridge: remove unneeded *fe vars from attach functions

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller These are only used in C/T demod attach functions, don't add any real benefit (ie. line length savings) and in case of cxd28xx_attach aren't even used consequently. Remove them. Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/ddbridge-c

[PATCH 3/8] [media] ddbridge: split off CI (common interface) from ddbridge-core

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller Move all CI device support related code from ddbridge-core to ddbridge-ci, following the previously split off MaxS4/8 support. Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/Makefile| 4 +- drivers/media/pci/ddbridge/ddbridge-ci.c | 349

[PATCH 8/8] [media] ddbridge: update driver version number

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller Update the driver version number/string to 0.9.32-integrated. Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/ddbridge.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/ddbridge/ddbridge.h b/drivers/media/pci/ddbridge

[PATCH 4/8] [media] ddbridge/ci: change debug printing to debug severity

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller slot_ts_enable_xo2() logged debug output to info instead of debug, so fix this up. Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/ddbridge-ci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/ddbridge/ddbridge-ci.c b

[PATCH 5/8] [media] ddbridge/max: rename ddbridge-maxs8.[c|h] to ddbridge-max.[c|h]

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller Rename the MaxS4/8 support files following upstream. References to these files and descriptions have been updated aswell. Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/Makefile | 2 +- drivers/media/pci/ddbridge/ddbridge-core.c

[PATCH 6/8] [media] ddbridge/max: prefix lnb_init_fmode() and fe_attach_mxl5xx()

2017-10-15 Thread Daniel Scheller
From: Daniel Scheller Add a ddb_ prefix to the two functions to better avoid conflicts in the global namespace, ie. when building everything into the kernel image. Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/ddbridge-core.c | 4 ++-- drivers/media/pci/ddbridge/ddbridge-max.c

[PATCH] [media] dvb-frontends/stv0910: prevent consecutive mutex_unlock()'s

2017-10-21 Thread Daniel Scheller
From: Daniel Scheller When calling gate_ctrl() with enable=0 if previously the mutex wasn't locked (ie. on enable=1 failure and subdrivers not handling this properly, or by otherwise badly behaving drivers), the i2c_lock could be unlocked consecutively which isn't allowed. Preve

Re: [PATCH] [media] dvb-frontends/stv0910: prevent consecutive mutex_unlock()'s

2017-10-21 Thread Daniel Scheller
Am Sat, 21 Oct 2017 11:28:10 +0200 schrieb Ralph Metzler : > Daniel Scheller writes: > > From: Daniel Scheller > > > > When calling gate_ctrl() with enable=0 if previously the mutex > > wasn't locked (ie. on enable=1 failure and subdrivers not handling >

Re: [PATCH v3 01/10] [media] dvb-frontends: add ST STV0910 DVB-S/S2 demodulator frontend driver

2017-07-20 Thread Daniel Scheller
-l|grep -v MAINT) --strict --fix-inplace > > But you need to review if the results are ok. Thanks for the hints! Best regards, Daniel Scheller -- https://github.com/herrnst

Re: [PATCH 00/14] ddbridge: bump to ddbridge-0.9.29

2017-07-20 Thread Daniel Scheller
Hi Mauro, Am Thu, 20 Jul 2017 12:24:12 -0300 schrieb Mauro Carvalho Chehab : > Em Tue, 11 Jul 2017 17:30:13 +0200 > Daniel Scheller escreveu: > > > Am Tue, 11 Jul 2017 11:11:27 +0200 > > schrieb Ralph Metzler : > > > > > Daniel Scheller writes: >

Re: [PATCH][media-next] media: dvb-frontends/stv0910: make various local variables static

2017-07-22 Thread Daniel Scheller
'padc_lookup' was not declared. Should it be static? > symbol 's1_sn_lookup' was not declared. Should it be static? > symbol 's2_sn_lookup' was not declared. Should it be static? > symbol 'stvlist' was not declared. Should it be static? > > Signed-of

[PATCH 0/7] stv0910/stv6111 updates

2017-07-23 Thread Daniel Scheller
From: Daniel Scheller Several, mostly cosmetic updates and fixes to these two new drivers, and one additional functionality: - Make both drivers 99% checkpatch-strict clean. stv0910_regs.h still has "CHECK: 'VALIDE' may be misspelled - perhaps 'VALID'?", which

[PATCH 1/7] [media] dvb-frontends/stv0910: fix STR assignment, remove unneeded var

2017-07-23 Thread Daniel Scheller
From: Daniel Scheller According to the documentation, FE_SCALE_DECIBEL values should be assigned to .svalue and not .uvalue, so let's do this. While at it, remove the unneeded strength var from read_signal_strength(). Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0

[PATCH 7/7] [media] dvb-frontends/stv{0910,6111}: constify tables

2017-07-23 Thread Daniel Scheller
From: Daniel Scheller Mark lookup tables and fe_ops things const so the compiler can put them into .rodata. While at it, improve name and identifier strings (moddesc, fe_ops). Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0910.c | 24 drivers

[PATCH 2/7] [media] dvb-frontends/stv0910: implement diseqc_send_burst

2017-07-23 Thread Daniel Scheller
From: Daniel Scheller This implements the diseqc_send_burst frontend op to support sending mini-DISEQC bursts. Picked up from dddvb's driver package where this specific block was disabled via #if 0/#endif, but is still working according to feedback from upstream, so add it. Signed-o

[PATCH 5/7] [media] dvb-frontends/stv6111: coding style cleanup

2017-07-23 Thread Daniel Scheller
From: Daniel Scheller Fix up all remainders reported by checkpatch-strict. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv6111.c | 38 --- drivers/media/dvb-frontends/stv6111.h | 7 --- 2 files changed, 26 insertions(+), 19 deletions

[PATCH 3/7] [media] dvb-frontends/stv0910: further coding style cleanup

2017-07-23 Thread Daniel Scheller
From: Daniel Scheller Fixes up all remainders reported by "checkpatch.pl --strict" Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0910.c | 93 +-- drivers/media/dvb-frontends/stv0910.h | 4 +- 2 files changed, 48 insertions(+), 49

[PATCH 6/7] [media] dvb-frontends/stv6111: cosmetics: comments fixup, misc

2017-07-23 Thread Daniel Scheller
From: Daniel Scheller Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv6111.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/media/dvb-frontends/stv6111.c b/drivers/media/dvb-frontends/stv6111.c index 91e24ba44c30

Re: [PATCH] [media] ddbridge: constify i2c_algorithm structure

2017-07-23 Thread Daniel Scheller
Am Mon, 10 Jul 2017 17:12:27 +0200 schrieb Daniel Scheller : > From: Daniel Scheller > > Original patch and issue identified by Gustavo A. R. Silva > via [1] using Coccinelle. While at it, even > mark the struct static again since it isn't referenced anywhere

Re: [PATCH 00/14] ddbridge: bump to ddbridge-0.9.29

2017-07-23 Thread Daniel Scheller
Am Sun, 9 Jul 2017 21:42:07 +0200 schrieb Daniel Scheller : > From: Daniel Scheller > > Preferrably for Linux 4.14 (to get things done). > > [...] > > Mauro/Media maintainers, this updates drivers/media/pci/ddbridge to > the very latest code that DD carry in their

[PATCH] [media] dvb-frontends/cxd2841er: update moddesc wrt new chip support

2017-07-23 Thread Daniel Scheller
From: Daniel Scheller Since the driver now recognizes and supports more chip variants, reflect this fact in the module description accordingly. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/cxd2841er.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH RESEND 00/14] ddbridge: bump to ddbridge-0.9.29

2017-07-23 Thread Daniel Scheller
From: Daniel Scheller Preferrably for Linux 4.14 (to get things done). Resend reasons (resend since no real changes went in): * rebased on latest mediatree-master wrt commit 618e8aac3d7c ("media: ddbridge: constify i2c_algorithm structure") * build error in ddbridge-core.c

[PATCH RESEND 12/14] [media] ddbridge: fix dereference before check

2017-07-23 Thread Daniel Scheller
From: Daniel Scheller Both ts_release() and ts_open() can use "output" before check (smatch): drivers/media/pci/ddbridge/ddbridge-core.c:816 ts_release() warn: variable dereferenced before check 'output' (see line 809) drivers/media/pci/ddbridge/ddbridge-core.c:836 ts_o

[PATCH RESEND 14/14] [media] MAINTAINERS: add entry for ddbridge

2017-07-23 Thread Daniel Scheller
From: Daniel Scheller Signed-off-by: Daniel Scheller --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9826a918d37a..f25f26b5d9f6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8428,6 +8428,14 @@ T: git git://linuxtv.org

[PATCH RESEND 02/14] [media] ddbridge: split code into multiple files

2017-07-23 Thread Daniel Scheller
From: Daniel Scheller As of 0.9.9b, the ddbridge code has been split from one single file (ddbridge-core.c) into multiple files, with the purpose of taking care of different topics, and to be able to reuse code in different kernel modules (ddbridge.ko and octonet.ko). This applies the same code

[PATCH RESEND 04/14] [media] ddbridge: split I/O related functions off from ddbridge.h

2017-07-23 Thread Daniel Scheller
From: Daniel Scheller While it seems valid that headers can carry simple oneline static inline annotated functions, move them into their own header file to have the overall code more readable. Also, keep them as header (and don't put in a separate object) and static inline to help the com

<    1   2   3   4   5   6   >