[PATCH 37/49] rc-core: allow empty keymaps

2014-04-03 Thread David Härdeman
Remove the RC_MAP_EMPTY hack and instead allow for empty keymaps. Signed-off-by: David Härdeman --- drivers/media/i2c/ir-kbd-i2c.c |4 +-- drivers/media/pci/cx88/cx88-input.c|6 - drivers/media/pci/ivtv/ivtv-i2c.c |2 +- drivers/media/rc/gpio-ir

[PATCH 42/49] rc-ir-raw: atomic reads of protocols

2014-04-03 Thread David Härdeman
Use atomic reads to avoid having to take a mutex when getting the bitmask of supported protocols. Signed-off-by: David Härdeman --- drivers/media/rc/rc-core-priv.h |2 +- drivers/media/rc/rc-ir-raw.c| 12 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a

[PATCH 35/49] rc-core: remove redundant spinlock

2014-04-03 Thread David Härdeman
Remove a redundant spinlock from struct rc_map. Signed-off-by: David Härdeman --- drivers/media/rc/rc-keytable.c | 43 +--- include/media/rc-core.h|4 ++-- include/media/rc-map.h |1 - 3 files changed, 20 insertions(+), 28 deletions

[PATCH 32/49] rc-core: prepare for multiple keytables

2014-04-03 Thread David Härdeman
ond to one physical remote controller, each with its own keymap and input device for reporting events to userspace. Signed-off-by: David Härdeman --- drivers/media/rc/rc-core-priv.h | 16 +- drivers/media/rc/rc-keytable.c | 341 ++- drivers/media/rc/rc-

[PATCH 33/49] rc-core: make the keytable of rc_dev an array

2014-04-03 Thread David Härdeman
This is another step towards allowing multiple keytables per rc_dev. struct rc_dev is changed to hold an array of keytables (used later for indexed access to keytables) as well as a list of the same keytables (used for iteration in fast paths). Signed-off-by: David Härdeman --- drivers/media

[PATCH 23/49] rc-loopback: add RCIOCGIRRX ioctl support

2014-04-03 Thread David Härdeman
As an example, this patch adds support for the new RCIOCGIRRX ioctl to rc-loopback. Signed-off-by: David Härdeman --- drivers/media/rc/rc-loopback.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/media/rc/rc-loopback.c b/drivers/media/rc/rc-loopback.c

[PATCH 27/49] rc-loopback: add RCIOCGIRTX ioctl support

2014-04-03 Thread David Härdeman
As an example, this patch adds support for the new RCIOCGIRRX ioctl to rc-loopback. Signed-off-by: David Härdeman --- drivers/media/rc/rc-loopback.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/media/rc/rc-loopback.c b/drivers/media/rc/rc-loopback.c

[PATCH 26/49] rc-core: add an ioctl for getting IR TX settings

2014-04-03 Thread David Härdeman
t out. Signed-off-by: David Härdeman --- drivers/media/rc/rc-main.c | 12 include/media/rc-core.h| 38 ++ 2 files changed, 50 insertions(+) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index 3ad565f..611d24d 100644

[PATCH 31/49] rc-core: split rc-main.c into rc-main.c and rc-keytable.c

2014-04-03 Thread David Härdeman
h the absolute minimum changes (making some methods non-static) because it's nigh impossible to review code changes and this code of split in the same patch. Signed-off-by: David Härdeman --- drivers/media/rc/Makefile |2 drivers/media/rc/rc-core-priv.h | 17 + drivers/m

[PATCH 28/49] rc-core: add an ioctl for setting IR TX settings

2014-04-03 Thread David Härdeman
functionality as an alternative to the old one and another bunch of operations in struct rc_dev are now deprecated. Signed-off-by: David Härdeman --- drivers/media/rc/ir-lirc-codec.c | 42 +- drivers/media/rc/rc-main.c | 13 include/media/rc

[PATCH 25/49] rc-loopback: add RCIOCSIRRX ioctl support

2014-04-03 Thread David Härdeman
As an example, this patch adds support for the new RCIOCSIRRX ioctl to rc-loopback and removes deprecated functions without a loss in functionality (as LIRC will automatically use the new functions). Signed-off-by: David Härdeman --- drivers/media/rc/rc-loopback.c | 84

[PATCH 30/49] rc-core: leave the internals of rc_dev alone

2014-04-03 Thread David Härdeman
xx-input.c Just some debug statements to change drivers/media/video/tm6000/tm6000-input.c Not sure what the driver is trying to do, however, IR handling seems incomplete ATM so deleting the offending parts shouldn't affect functionality Signed-off-by:

[PATCH 24/49] rc-core: add an ioctl for setting IR RX settings

2014-04-03 Thread David Härdeman
several operations in struct rc_dev to be deprecated. Signed-off-by: David Härdeman --- drivers/media/rc/ir-lirc-codec.c | 53 +- drivers/media/rc/rc-core-priv.h |3 ++ drivers/media/rc/rc-main.c | 53 +- include

[PATCH 29/49] rc-loopback: add RCIOCSIRTX ioctl support

2014-04-03 Thread David Härdeman
As an example, this patch adds support for the new RCIOCSIRTX ioctl to rc-loopback and removes deprecated functions without a loss in functionality (as LIRC will automatically use the new functions). Signed-off-by: David Härdeman --- drivers/media/rc/rc-loopback.c | 59

[PATCH 21/49] rc-core: add ioctl support to the rc chardev

2014-04-03 Thread David Härdeman
e ops. Signed-off-by: David Härdeman --- Documentation/ioctl/ioctl-number.txt |1 + drivers/media/rc/rc-main.c | 65 ++ include/media/rc-core.h | 19 ++ 3 files changed, 85 insertions(+) diff --git a/Documentation/ioctl/

[PATCH 22/49] rc-core: add an ioctl for getting IR RX settings

2014-04-03 Thread David Härdeman
etting the appropriate flag as now) or not (in which case it should always be on). Signed-off-by: David Härdeman --- drivers/media/rc/rc-main.c | 28 +++ include/media/rc-core.h| 65 2 files changed, 93 insertions(+) diff --git a/driver

[PATCH 20/49] rc-core: allow chardev to be written

2014-04-03 Thread David Härdeman
Add write functionality to the rc chardev (for use in transmitting remote control commands on capable hardware). The data format of the TX data is probably going to have to be dependent on the rc_driver_type. Signed-off-by: David Härdeman --- drivers/media/rc/rc-main.c | 71

[PATCH 18/49] rc-core: allow chardev to be read

2014-04-03 Thread David Härdeman
will add further events. Signed-off-by: David Härdeman --- drivers/media/rc/rc-main.c | 154 +++- include/media/rc-core.h| 40 +++ 2 files changed, 189 insertions(+), 5 deletions(-) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc

[PATCH 16/49] rc-core: use an IDA rather than a bitmap

2014-04-03 Thread David Härdeman
This patch changes rc-core to use an IDA rather than a bitmap to assign unique numbers to each rc device. This is in preparation for introducing rc-core chardevs. Signed-off-by: David Härdeman --- drivers/media/rc/ir-raw.c |2 +- drivers/media/rc/rc-main.c | 40

[PATCH 19/49] rc-core: use a kfifo for TX data

2014-04-03 Thread David Härdeman
and after this patch. Signed-off-by: David Härdeman --- drivers/media/rc/ene_ir.c| 61 + drivers/media/rc/ene_ir.h|9 +-- drivers/media/rc/iguanair.c | 51 - drivers/media/rc/ir-lirc-codec.c | 100

[PATCH 17/49] rc-core: add chardev

2014-04-03 Thread David Härdeman
This patch lays the groundwork for adding a rc-core chardev. Signed-off-by: David Härdeman --- drivers/media/rc/ir-raw.c |2 drivers/media/rc/rc-main.c | 284 +++- include/media/rc-core.h| 11 +- 3 files changed, 238 insertions(+), 59

[PATCH 13/49] rc-core: remove protocol arrays

2014-04-03 Thread David Härdeman
hes). Signed-off-by: David Härdeman --- drivers/hid/hid-picolcd_cir.c |2 - drivers/media/common/siano/smsir.c |2 - drivers/media/i2c/ir-kbd-i2c.c |4 +- drivers/media/pci/cx23885/cx23885-input.c |2 - drivers/media/pci/cx88/cx88-input.c

[PATCH 14/49] rc-core: rename dev->scanmask to dev->scancode_mask

2014-04-03 Thread David Härdeman
We already have dev->scancode_filter and dev->scancode_wakeup_filter so rename dev->scanmask to dev->scancode_mask for consistency. Signed-off-by: David Härdeman --- drivers/media/pci/cx88/cx88-input.c |2 +- drivers/media/pci/ttpci/budget-ci.c |2 +- drivers

[PATCH 15/49] rc-core: merge rc5 and streamzap decoders

2014-04-03 Thread David Härdeman
that I've seen with e.g. Sony protocols). Signed-off-by: David Härdeman --- drivers/media/rc/Kconfig| 12 -- drivers/media/rc/Makefile |1 drivers/media/rc/ir-rc5-decoder.c | 72 -- drivers/media/rc/ir-rc5-sz-decoder.c|

[PATCH 12/49] rc-core: simplify sysfs code

2014-04-03 Thread David Härdeman
Simplify and cleanup the sysfs code a bit. Signed-off-by: David Härdeman --- drivers/media/rc/ir-raw.c |6 + drivers/media/rc/rc-main.c | 265 2 files changed, 150 insertions(+), 121 deletions(-) diff --git a/drivers/media/rc/ir-raw.c b

[PATCH 07/49] dib0700: NEC scancode cleanup

2014-04-03 Thread David Härdeman
poll_reply->data; Which is the same as the order used in drivers/media/rc/ir-nec-decoder.c. This patch changes the code to match my assumption (the generated scancode should, however, not change). Signed-off-by: David Härdeman CC: Patrick Boettcher --- drivers/media/usb/dvb-usb

[PATCH 11/49] [RFC] rc-core: don't throw away protocol information

2014-04-03 Thread David Härdeman
her patches will also add the ability to communicate the protocol to userspace. This needs review by the input maintainer as well. Signed-off-by: David Härdeman --- drivers/media/rc/ati_remote.c |1 drivers/media/rc/imon.c | 12 ++- drivers/media/rc/rc-main.c| 182

[PATCH 10/49] [RFC] rc-core: use the full 32 bits for NEC scancodes

2014-04-03 Thread David Härdeman
later which makes the protocol explicit (and which expects all NEC scancodes to be 32 bit, thereby removing the need for guesswork). Signed-off-by: David Härdeman --- drivers/media/pci/saa7134/saa7134-input.c |6 +- drivers/media/rc/img-ir/img-ir-nec.c | 79

[PATCH 02/49] rc-core: improve ir-kbd-i2c get_key functions

2014-04-03 Thread David Härdeman
The arguments used for ir-kbd-i2c's get_key() functions are not really suited for rc-core and the ir_raw/ir_key distinction is just confusing. Convert all of them to return a protocol/scancode/toggle triple instead. Signed-off-by: David Härdeman --- drivers/media/i2c/ir-kbd-

[PATCH 01/49] bt8xx: fixup RC5 decoding

2014-04-03 Thread David Härdeman
perfectly backwards compatible). Signed-off-by: David Härdeman --- drivers/media/pci/bt8xx/bttv-input.c | 62 ++- drivers/media/pci/bt8xx/bttvp.h |2 - drivers/media/rc/keymaps/rc-nebula.c | 112 +- 3 files changed, 88 insertions(+), 88

[PATCH 00/49] rc-core: my current patch queue

2014-04-03 Thread David Härdeman
t important one). Lots and lots of cleanups as well. Enjoy :) --- David Härdeman (49): bt8xx: fixup RC5 decoding rc-core: improve ir-kbd-i2c get_key functions rc-core: document the protocol type rc-core: do not change 32bit NEC scancode format for now rc-core: spli

[PATCH 04/49] rc-core: do not change 32bit NEC scancode format for now

2014-04-03 Thread David Härdeman
bitrev8():ed as well Signed-off-by: David Härdeman --- drivers/media/rc/img-ir/img-ir-nec.c | 27 ++- drivers/media/rc/ir-nec-decoder.c|5 -- drivers/media/rc/keymaps/rc-tivo.c | 86 +- 3 files changed, 59 insertions(+), 59 deletions(-) diff -

[PATCH 03/49] rc-core: document the protocol type

2014-04-03 Thread David Härdeman
makes it easier to e.g. support multiple protocols with one decoder (think rc5 and rc-streamzap). The information isn't used yet so there should be no functional changes. Signed-off-by: David Härdeman --- drivers/media/i2c/ir-kbd-i2c.c |5 + drivers/media/pci/bt8xx/bttv-in

[PATCH 09/49] saa7134: NEC scancode fix

2014-04-03 Thread David Härdeman
still a strong hint that the change is correct). Signed-off-by: David Härdeman --- drivers/media/pci/saa7134/saa7134-input.c |2 - drivers/media/rc/keymaps/rc-behold.c | 68 +++-- 2 files changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/media/pci

[PATCH 06/49] rc-core: remove generic scancode filter

2014-04-03 Thread David Härdeman
created in the first place. v2: correct dev->s_filter check Signed-off-by: David Härdeman --- drivers/media/rc/rc-main.c | 67 +--- include/media/rc-core.h|2 + 2 files changed, 46 insertions(+), 23 deletions(-) diff --git a/drivers/media/rc

[PATCH 08/49] lmedm04: NEC scancode cleanup

2014-04-03 Thread David Härdeman
This changes the keymap back to the state before commit 616a4b83 and changes the driver to use full NEC32 scancodes following the instructions provided by Malcolm Priestley . Signed-off-by: David Härdeman --- drivers/media/rc/keymaps/rc-lme2510.c | 132

[PATCH 05/49] rc-core: split dev->s_filter

2014-04-03 Thread David Härdeman
Overloading dev->s_filter to do two different functions (set wakeup filters and generic hardware filters) makes it impossible to tell what the hardware actually supports, so create a separate dev->s_wakeup_filter and make the distinction explicit. Signed-off-by: David Härdeman --- drivers

Re: [GIT PULL for v3.15-rc1] media updates

2014-04-03 Thread David Härdeman
ave overlooked that discussion...or have I missed something? -- David Härdeman -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [ANNOUNCE] git web interface was changed to cgit

2014-04-02 Thread David Härdeman
On Wed, Apr 02, 2014 at 07:26:51PM -0300, Mauro Carvalho Chehab wrote: >I changed today our git web interface from gitweb to cgit, due to seveal >reasons: ... >Please ping me if you fin any problems on it. Hi, one small thing I've noticed is that the repo links from http://linuxtv.org/cvs.php are

Re: [PATCH] rc-core: do not change 32bit NEC scancode format for now

2014-03-31 Thread David Härdeman
On Fri, Mar 28, 2014 at 11:17:09PM +, James Hogan wrote: >On Friday 28 March 2014 01:08:56 David Härdeman wrote: >> On Thu, Mar 27, 2014 at 11:21:23PM +, James Hogan wrote: >>>On Thursday 27 March 2014 22:00:37 David Härdeman wrote:

Re: [PATCH 03/11] rc-core: document the protocol type

2014-03-31 Thread David Härdeman
On Mon, Mar 31, 2014 at 10:54:59AM +0100, James Hogan wrote: >On 29/03/14 16:11, David Härdeman wrote: >> Right now the protocol information is not preserved, rc-core gets handed a >> scancode but has no idea which protocol it corresponds to. >> >> This patch (which r

Re: [PATCH 06/11] rc-core: remove generic scancode filter

2014-03-31 Thread David Härdeman
On Mon, Mar 31, 2014 at 10:29:53AM +0100, James Hogan wrote: >On 29/03/14 16:11, David Härdeman wrote: >> The generic scancode filtering has questionable value and makes it >> impossible to determine from userspace if there is an actual >> scancode hw filter present or not.

Re: [PATCH 10/11] [RFC] rc-core: use the full 32 bits for NEC scancodes

2014-03-31 Thread David Härdeman
t to kernel scancode notation on the fly. That's something userspace anyways has to do today. Consider the 32 bit scancode as simply being the communication protocol between userspace <-> kernel if you like. There's no reason to complicate that with bitsizes and/or multiple protocols when a single 32 bit scancode describes exactly everything that the kernel and userspace needs to know. -- David Härdeman -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 10/11] [RFC] rc-core: use the full 32 bits for NEC scancodes

2014-03-31 Thread David Härdeman
On 2014-03-31 15:15, Mauro Carvalho Chehab wrote: Em Mon, 31 Mar 2014 14:58:10 +0200 David Härdeman escreveu: On 2014-03-31 14:14, Mauro Carvalho Chehab wrote: The 24 or 32 bits variation is actually a violation of the NEC protocol. Violation is a misnomer. NEC created the 24 bit version

Re: [PATCH 10/11] [RFC] rc-core: use the full 32 bits for NEC scancodes

2014-03-31 Thread David Härdeman
On 2014-03-31 12:56, James Hogan wrote: On 31/03/14 11:19, David Härdeman wrote: On 2014-03-31 11:44, James Hogan wrote: On 29/03/14 16:11, David Härdeman wrote: +/* raw encoding : ddDDaaAA -> scan encoding: AAaaDDdd */ +*scancode = swab32((u32)raw); What's the point of

Re: [PATCH 10/11] [RFC] rc-core: use the full 32 bits for NEC scancodes

2014-03-31 Thread David Härdeman
On 2014-03-31 14:14, Mauro Carvalho Chehab wrote: Em Mon, 31 Mar 2014 12:19:10 +0200 David Härdeman escreveu: On 2014-03-31 11:44, James Hogan wrote: > On 29/03/14 16:11, David Härdeman wrote: >> Using the full 32 bits for all kinds of NEC scancodes simplifies >> rc-core >>

Re: [PATCH 10/11] [RFC] rc-core: use the full 32 bits for NEC scancodes

2014-03-31 Thread David Härdeman
On 2014-03-31 11:44, James Hogan wrote: On 29/03/14 16:11, David Härdeman wrote: Using the full 32 bits for all kinds of NEC scancodes simplifies rc-core and the nec decoder without any loss of functionality. In order to maintain backwards compatibility, some heuristics are added in rc

Re: lmedm04 NEC scancode question

2014-03-30 Thread David Härdeman
On Sun, Mar 30, 2014 at 07:18:20PM +0100, Malcolm Priestley wrote: >On 28/03/14 00:38, David Härdeman wrote: >>I'm trying to make sure that the extended NEC parsing is consistent >>across drivers and I have a question regarding >>drivers/media/usb/dvb-usb-v2/lmedm04.c &

Re: [PATCH 1/3] rc-main: Revert generic scancode filtering support

2014-03-29 Thread David Härdeman
On Wed, Mar 26, 2014 at 09:08:31PM +, James Hogan wrote: >This reverts commit b8c7d915087c ([media] rc-main: add generic scancode >filtering), and removes certain parts of commit 6bea25af147f ([media] >rc-main: automatically refresh filter on protocol change) where generic >filtering is taken i

Re: [PATCH] rc-core: do not change 32bit NEC scancode format for now

2014-03-29 Thread David Härdeman
On Fri, Mar 28, 2014 at 11:17:09PM +, James Hogan wrote: >On Friday 28 March 2014 01:08:56 David Härdeman wrote: >> drivers/media/usb/dvb-usb-v2/az6007.c >> drivers/media/usb/dvb-usb-v2/af9035.c >> drivers/media/usb/dvb-usb-v2/rtl28xxu.c >> drivers/media/usb/dvb

[PATCH 00/11] rc-core: My current patch queue

2014-03-29 Thread David Härdeman
n the long run (by treating NEC16, NECX, NEC32 as NEC32 simply...and converting as necessary...also a new ioctl to make the protocol explicit, which has value for all protocols). --- David Härdeman (11): bt8xx: fixup RC5 decoding rc-core: improve ir-kbd-i2c get_key functions

[PATCH 11/11] [RFC] rc-core: don't throw away protocol information

2014-03-29 Thread David Härdeman
her patches will also add the ability to communicate the protocol to userspace. Signed-off-by: David Härdeman --- drivers/media/rc/rc-main.c | 184 include/media/rc-core.h| 20 + include/media/rc-map.h |8 +- 3 files changed, 155 inse

[PATCH 05/11] rc-core: split dev->s_filter

2014-03-29 Thread David Härdeman
Overloading dev->s_filter to do two different functions (set wakeup filters and generic hardware filters) makes it impossible to tell what the hardware actually supports, so create a separate dev->s_wakeup_filter and make the distinction explicit. Signed-off-by: David Härdeman --- drivers

[PATCH 01/11] bt8xx: fixup RC5 decoding

2014-03-29 Thread David Härdeman
perfectly backwards compatible). Signed-off-by: David Härdeman --- drivers/media/pci/bt8xx/bttv-input.c | 62 ++- drivers/media/pci/bt8xx/bttvp.h |2 - drivers/media/rc/keymaps/rc-nebula.c | 112 +- 3 files changed, 88 insertions(+), 88

[PATCH 08/11] lmedm04: NEC scancode cleanup

2014-03-29 Thread David Härdeman
= addr; ibuf[4] = ~cmd = not_cmd; ibuf[5] = ~not_cmd = cmd; And the scancode can then be understood as: addr << 16 | not_addr << 8 | cmd Except for when addr = 0x00 in which case the scancode is simply NEC16: 0x00 << 8 | cmd Si

[PATCH 02/11] rc-core: improve ir-kbd-i2c get_key functions

2014-03-29 Thread David Härdeman
The arguments used for ir-kbd-i2c's get_key() functions are not really suited for rc-core and the ir_raw/ir_key distinction is just confusing. Convert all of them to return a protocol/scancode/toggle triple instead. Signed-off-by: David Härdeman --- drivers/media/i2c/ir-kbd-

[PATCH 03/11] rc-core: document the protocol type

2014-03-29 Thread David Härdeman
makes it easier to e.g. support multiple protocols with one decoder (think rc5 and rc-streamzap). The information isn't used yet so there should be no functional changes. Signed-off-by: David Härdeman --- drivers/media/i2c/ir-kbd-i2c.c |5 + drivers/media/pci/bt8xx/bttv-in

[PATCH 10/11] [RFC] rc-core: use the full 32 bits for NEC scancodes

2014-03-29 Thread David Härdeman
later which makes the protocol explicit (and which expects all NEC scancodes to be 32 bit, thereby removing the need for guesswork). Signed-off-by: David Härdeman --- drivers/media/pci/saa7134/saa7134-input.c |6 +- drivers/media/rc/img-ir/img-ir-nec.c | 79

[PATCH 06/11] rc-core: remove generic scancode filter

2014-03-29 Thread David Härdeman
created in the first place. Signed-off-by: David Härdeman --- drivers/media/rc/rc-main.c | 66 +--- include/media/rc-core.h|2 + 2 files changed, 45 insertions(+), 23 deletions(-) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc

[PATCH 07/11] dib0700: NEC scancode cleanup

2014-03-29 Thread David Härdeman
poll_reply->data; Which is the same as the order used in drivers/media/rc/ir-nec-decoder.c. This patch changes the code to match my assumption (the generated scancode should, however, not change). Signed-off-by: David Härdeman CC: Patrick Boettcher --- drivers/media/usb/dvb-usb

[PATCH 09/11] saa7134: NEC scancode fix

2014-03-29 Thread David Härdeman
still a strong hint that the change is correct). Signed-off-by: David Härdeman --- drivers/media/pci/saa7134/saa7134-input.c |2 - drivers/media/rc/keymaps/rc-behold.c | 68 +++-- 2 files changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/media/pci

[PATCH 04/11] rc-core: do not change 32bit NEC scancode format for now

2014-03-29 Thread David Härdeman
. Furthermore, I'm convinced that we have to stop playing games trying to decipher the "meaning" of NEC scancodes (what's the customer/vendor/address, which byte is the MSB, etc). This patch is in preparation for the next few patches in this series. Signed-off-by: David Härdeman ---

NECX scancode consistency

2014-03-27 Thread David Härdeman
=== order: ããaacc (!!!) keymap: RC_MAP_BEHOLD (0x6b86 -> 0x866b) code: *scancode = RC_SCANCODE_NECX(((data[10] << 8) | data[11]), data[9]); The only NECX keymap not listed above is RC_MAP_PIXELVIEW_002T which is used in ./usb/cx231xx/cx231xx-cards.c, but that

lmedm04 NEC scancode question

2014-03-27 Thread David Härdeman
addr << 16 | not_addr << 8 | cmd Except for when addr = 0x00 in which case the scancode is simply NEC16: 0x00 << 8 | cmd Is my interpretation correct? -- David Härdeman -- To unsubscribe from this list: send the line "unsubscribe linux-media" i

Re: [PATCH] rc-core: do not change 32bit NEC scancode format for now

2014-03-27 Thread David Härdeman
On Thu, Mar 27, 2014 at 11:21:23PM +, James Hogan wrote: >Hi David, > >On Thursday 27 March 2014 22:00:37 David Härdeman wrote: >> This reverts 18bc17448147e93f31cc9b1a83be49f1224657b2 >> >> The patch ignores the fact that NEC32 scancodes are generated not only in

Re: dib0700 NEC scancode question

2014-03-27 Thread David Härdeman
On Thu, Mar 27, 2014 at 11:13:35PM +0100, Patrick Boettcher wrote: >Hi David, > >On Thursday 27 March 2014 22:40:41 David Härdeman wrote: >> On Thu, Mar 27, 2014 at 01:07:28PM +0100, David Härdeman wrote: >> >Hi Patrick, >> > >> >a quick question regard

Re: dib0700 NEC scancode question

2014-03-27 Thread David Härdeman
On Thu, Mar 27, 2014 at 01:07:28PM +0100, David Härdeman wrote: >Hi Patrick, > >a quick question regarding the dib0700 driver: > >in ./media/usb/dvb-usb/dib0700_core.c the RC RX packet is defined as: ... >The NEC protocol transmits in the order: ... >Does the dib0700 fw rea

[PATCH] rc-core: do not change 32bit NEC scancode format for now

2014-03-27 Thread David Härdeman
. Furthermore, I'm convinced that we have to stop playing games trying to decipher the "meaning" of NEC scancodes (what's the customer/vendor/address, which byte is the MSB, etc). I'll post separate proposals to that effect later. Signed-off-by: David Härdeman --- drivers/

dib0700 NEC scancode question

2014-03-27 Thread David Härdeman
correct, which is why I'm checking all the places where NEC scancodes are generated). -- David Härdeman -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] rc-main: add generic scancode filtering

2014-03-26 Thread David Härdeman
On 2014-03-26 08:08, Antti Seppälä wrote: On 26 March 2014 01:21, David Härdeman wrote: On Tue, Mar 25, 2014 at 09:12:11AM +, James Hogan wrote: On Tuesday 25 March 2014 00:51:46 David Härdeman wrote: What's the purpose of providing the sw scancode filtering in the case where there

Re: [PATCH v4 00/10] media: rc: ImgTec IR decoder driver

2014-03-26 Thread David Härdeman
On 2014-03-26 10:28, James Hogan wrote: On 25/03/14 23:53, David Härdeman wrote: One thing I just noticed...your copyright headers throughout the driver seems a bit...sparse? :) True, I can add the basic: ... to each of the files if you think it's necessary. I think doing so for eac

[PATCH 2/3] rc-core: improve ir-kbd-i2c get_key functions

2014-03-25 Thread David Härdeman
The arguments used for ir-kbd-i2c's get_key() functions are not really suited for rc-core and the ir_raw/ir_key distinction is just confusing. Convert all of them to return a protocol/scancode/toggle triple instead. Signed-off-by: David Härdeman --- drivers/media/i2c/ir-kbd-

[PATCH 1/3] bt8xx: fixup RC5 decoding

2014-03-25 Thread David Härdeman
perfectly backwards compatible). Signed-off-by: David Härdeman --- drivers/media/pci/bt8xx/bttv-input.c | 62 ++- drivers/media/pci/bt8xx/bttvp.h |2 - drivers/media/rc/keymaps/rc-nebula.c | 112 +- 3 files changed, 88 insertions(+), 88

[PATCH 0/3] rc-core: misc protocol related fixups

2014-03-25 Thread David Härdeman
entertaining) is currently not used in rc-core (but I plan to use it in the future). --- David Härdeman (3): bt8xx: fixup RC5 decoding rc-core: improve ir-kbd-i2c get_key functions rc-core: document the protocol type drivers/media/i2c/ir-kbd-i2c.c | 91

[PATCH 3/3] rc-core: document the protocol type

2014-03-25 Thread David Härdeman
makes it easier to e.g. support multiple protocols with one decoder (think rc5 and rc-streamzap). The information isn't used yet so there should be no functional changes. Signed-off-by: David Härdeman --- drivers/media/i2c/ir-kbd-i2c.c |5 + drivers/media/pci/bt8xx/bttv-in

Re: [PATCH v4 00/10] media: rc: ImgTec IR decoder driver

2014-03-25 Thread David Härdeman
On Fri, Feb 28, 2014 at 11:28:50PM +, James Hogan wrote: >Add a driver for the ImgTec Infrared decoder block. Two separate rc >input devices are exposed depending on kernel configuration. One uses >the hardware decoder which is set up with timings for a specific >protocol and supports mask/valu

Re: [PATCH 0/3] Series short description

2014-03-25 Thread David Härdeman
On Wed, Mar 26, 2014 at 12:39:23AM +0100, David Härdeman wrote: >The following series implements... Nothing...sorry, I'll send the real patchset soon :) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.

[PATCH 0/3] Series short description

2014-03-25 Thread David Härdeman
The following series implements... --- David Härdeman (3): bt8xx: fixup RC5 decoding rc-core: improve ir-kbd-i2c get_key functions rc-core: document the protocol type drivers/media/i2c/ir-kbd-i2c.c | 91 +++--- drivers/media/pci/bt8xx/bttv

Re: [PATCH 1/5] rc-main: add generic scancode filtering

2014-03-25 Thread David Härdeman
On Tue, Mar 25, 2014 at 09:12:11AM +, James Hogan wrote: >On Tuesday 25 March 2014 00:51:46 David Härdeman wrote: >> On Fri, Feb 28, 2014 at 11:17:02PM +, James Hogan wrote: >> >Add generic scancode filtering of RC input events, and fall back to >> >permitting an

Re: [PATCH v2 0/9] rc: Add IR encode based wakeup filtering

2014-03-24 Thread David Härdeman
extended NEC like this: >0x[16-bit-address][~8-bit-command][8-bit-command] > >and normal NEC like this: >0x[~8-bit-address][8-bit-address][~8-bit-command][8-bit-command] > >Thanks >James -- David Härdeman -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] rc-main: add generic scancode filtering

2014-03-24 Thread David Härdeman
ter); >+ if (ret < 0) >+ goto unlock; >+ } > > /* Success, commit the new filter */ > *filter = local_filter; >-- >1.8.3.2 > >-- >To unsubscribe from this list: send the line "unsubscribe linux-media" in >the body of a message to majord...@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html > -- David Härdeman -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: WPC8769L (WEC1020) support in winbond-cir?

2013-10-15 Thread David Härdeman
some additional Wake-On-IR functionality...I seem to recall). But I think Juan is the one to talk to. I don't have the WEC1020 hardware and I don't have his experience of adding support for it... -- David Härdeman -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH] [media] winbond-cir: remove deprecated IRQF_DISABLED

2013-10-14 Thread David Härdeman
On 2013-10-13 08:11, Michael Opdenacker wrote: This patch proposes to remove the use of the IRQF_DISABLED flag It's a NOOP since 2.6.35 and it will be removed one day. Signed-off-by: Michael Opdenacker Acked-by: David Härdeman --- drivers/media/rc/winbond-cir.c | 2 +- 1 file chang

Re: [PATCH 4/5] [media] winbond: wire up rc feedback led

2013-08-04 Thread David Härdeman
sure that the led is suspended on suspend. > >Signed-off-by: Sean Young Signed-off-by: David Härdeman >--- > drivers/media/rc/Kconfig | 1 - > drivers/media/rc/winbond-cir.c | 38 ++ > 2 files changed, 6 insertions(+), 33 deletions

[PATCH 3/3] rc-core: initialize rc-core earlier if built-in

2013-03-06 Thread David Härdeman
rc-core is a subsystem so it should be registered earlier if built into the kernel. Signed-off-by: David Härdeman --- drivers/media/rc/rc-main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index c56650c..1cf382a

[PATCH 2/3] rc-core: rename ir_input_class to rc_class

2013-03-06 Thread David Härdeman
The name is already misleading and will be more so in the future as the connection to the input subsystem is obscured away further. Signed-off-by: David Härdeman --- drivers/media/rc/rc-main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/rc/rc

[PATCH 1/3] rc-core: don't treat dev->rc_map.rc_type as a bitmap

2013-03-06 Thread David Härdeman
single protocol) as pointed out by James Hogan . Fix both issues by introducing a separate enabled_protocols member to struct rc_dev. Signed-off-by: David Härdeman --- drivers/media/i2c/ir-kbd-i2c.c|1 + drivers/media/rc/ir-jvc-decoder.c |2 +- drivers/media/rc/ir-lirc-codec.c

[PATCH 0/3] rc-core fixes

2013-03-06 Thread David Härdeman
Three minor patches for rc-core...(against the for_v3.9 branch) --- David Härdeman (3): rc-core: don't treat dev->rc_map.rc_type as a bitmap rc-core: rename ir_input_class to rc_class rc-core: initialize rc-core earlier if built-in drivers/media/i2c/ir-k

Re: [PATCH 2/3] [media] redrat3: remove memcpys and fix unaligned memory access

2013-02-26 Thread David Härdeman
, &tmps, 2); >- >- tmpi = cpu_to_be32(header.pause); >- memcpy(buffer + offset, &tmpi, sizeof(tmpi)); >- >- tmps = cpu_to_be16(header.mod_freq_count); >- memcpy(buffer + offset + RR3_FREQ_COUNT_OFFSET, &tmps, 2); >- >- buffer[offset + RR3_NUM_LENGTHS

Re: [patch] [media] mceusb: move check earlier to make smatch happy

2013-02-19 Thread David Härdeman
header */ >+ length = cmdcount % MCE_CODE_LENGTH; >+ cmdbuf[cmdcount - length] -= MCE_CODE_LENGTH - length; >+ > /* All mce commands end with an empty packet (0x80) */ > cmdbuf[cmdcount++] = MCE_IRDATA_TRAILER; > > -- David Härdeman -- To unsubscribe fro

Re: [PATCH 1/3] [media] winbond-cir: only enable higher sample resolution if needed

2013-01-08 Thread David Härdeman
nerates up to a fifth of the interrupts. > >Signed-off-by: Sean Young Thanks Sean! Acked-by: David Härdeman >--- > drivers/media/rc/winbond-cir.c | 27 +++ > 1 file changed, 19 insertions(+), 8 deletions(-) > >diff --git a/drivers/media/rc/winbond-ci

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2013-01-02 Thread David Härdeman
On Tue, Dec 11, 2012 at 10:59:06PM +0200, Antti Palosaari wrote: >Yes, that is. I have said it "million" times I would like to see that >implemented as a one single 4 byte NEC, but it is currently what it >is. What I understand David Härdeman has done some work toward that

Re: [PATCH 2/3] [media] winbond-cir: increase IR receiver resolution

2013-01-02 Thread David Härdeman
On Wed, Oct 24, 2012 at 10:22:41PM +0100, Sean Young wrote: >This is needed for carrier reporting. > >Signed-off-by: Sean Young >--- > drivers/media/rc/winbond-cir.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) Using a resolution of 2us rather than 10us means that the res

Re: [PATCH] rc-core: add separate defines for protocol bitmaps and numbers

2013-01-01 Thread David Härdeman
On Mon, Dec 17, 2012 at 03:15:27PM +, James Hogan wrote: >On 12 October 2012 00:11, David Härdeman wrote: >> The RC_TYPE_* defines are currently used both where a single protocol is >> expected and where a bitmap of protocols is expected. This patch tries >> to separate t

Re: [PATCH] rc-core: don't return from store_protocols without releasing device mutex

2012-12-25 Thread David Härdeman
gt; >Doing that would cause infinite hangs waiting on device mutex next time >around. > >Signed-off-by: Sasha Levin Acked-by: David Härdeman >--- > drivers/media/rc/rc-main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/drivers/media/rc/rc-main.c

[PATCH] siano: fix Kconfig

2012-11-06 Thread David Härdeman
. Fix by making smsir a tristate as well. (I hope that's the correct fix, I'm no Kconfig expert). Signed-off-by: David Härdeman --- drivers/media/common/siano/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/common/siano/Kconfig b/drivers/media/c

Re: [PATCH] [media] winbond-cir: do not rename input name

2012-10-18 Thread David Härdeman
On Wed, Oct 17, 2012 at 04:38:21PM +0100, Sean Young wrote: >"54fd321 [media] winbond: remove space from driver name" inadvertently >renamed the input device name. > >Signed-off-by: Sean Young Acked-by: David Härdeman >--- > drivers/media/rc/winbond-cir.c | 4 ++-- &g

Re: [PATCH] rc-core: add separate defines for protocol bitmaps and numbers

2012-10-18 Thread David Härdeman
On Wed, Oct 17, 2012 at 05:18:56PM +0100, Sean Young wrote: >On Fri, Oct 12, 2012 at 01:11:54AM +0200, David Härdeman wrote: >> The RC_TYPE_* defines are currently used both where a single protocol is >> expected and where a bitmap of protocols is expected. This patch tries >>

Re: [PATCH 2/2] [media] winbond: remove space from driver name

2012-10-11 Thread David Härdeman
. > #define WBCIR_ID_FAMILY 0xF1 /* Family ID for the WPCD376I */ > #define WBCIR_ID_CHIP0x04 /* Chip ID for the WPCD376I > */ > #define INVALID_SCANCODE 0x7FFF /* Invalid with all protos */ >-- >1.7.11.4 > -- David Härdeman -

Re: [PATCHv3 2/9] ir-rx51: Handle signals properly

2012-09-20 Thread David Härdeman
On Tue, 4 Sep 2012 13:43:56 +0100, Sean Young wrote: > This interface is much better but it's also an ABI change. How should this > be handled? Should rc-core expose it's own /dev/rc[0-9] device with its > own ioctls? That was the plan yes. I've posted a patchbomb in the past to the linux-media m

<    1   2   3   4   5   6   >