On Thu, Aug 30, 2012 at 03:56:12PM -0400, Jarod Wilson wrote:
>On Sat, Aug 25, 2012 at 11:46:47PM +0200, David Härdeman wrote:
>> This is two minor winbond-cir fixes as well as the first six patches
>> from my previous patchbomb.
>>
>> The latter have been modified so t
written to the kfifo
at all.
That way we would avoid policy in kernel while still making it possible
to kill a misbehaving user-space process by forcing it to drip feed long
TX sequences.
--
David Härdeman
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
rc-core is a subsystem so it should be registered earlier if built into the
kernel.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-main.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index ec7311f..8134bd8
The name is already misleading and will be more so in the future as the
connection to the input subsystem is obscured away further.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media/rc/rc
that I've
seen with e.g. Sony protocols).
Signed-off-by: David Härdeman
---
drivers/media/rc/Kconfig| 12 --
drivers/media/rc/Makefile |1
drivers/media/rc/ir-rc5-decoder.c | 51 ++
drivers/media/rc/ir-rc5-sz-decoder.c|
"rc_keymap_entry" based ioctls.
Signed-off-by: David Härdeman
---
drivers/media/rc/ir-nec-decoder.c | 28 +++-
drivers/media/rc/rc-main.c | 36 ++-
drivers/media/usb/dvb-usb-v2/af9015.c | 22 +--
dri
Change winbond-cir's tx support to be asynchronous and not to mess with
the TX buffer. Essentially the winbond-cir counterpart to the patch
Sean Young sent for iguanair.
Signed-off-by: David Härdeman
---
drivers/media/rc/winbond-cir.c | 47 +++-
1
This is a minor correctness fix for the duration calculation in
winbond-cir (the read value should be incremented by one).
Signed-off-by: David Härdeman
---
drivers/media/rc/winbond-cir.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/winbond-cir.c b
This is two minor winbond-cir fixes as well as the first six patches
from my previous patchbomb.
The latter have been modified so that backwards compatibility is retained
as much as possible (the format of the sysfs files do not change for
example).
---
David Härdeman (8):
winbond-cir
On Sat, Aug 25, 2012 at 12:26:25AM +0100, Sean Young wrote:
>On Sat, Aug 25, 2012 at 12:05:18AM +0200, David Härdeman wrote:
>> On Thu, Aug 23, 2012 at 10:18:35PM +0100, Sean Young wrote:
>> >Some drivers wait for the IR device to complete sending before
>> >returning
on is duplicated in more than one driver
>> (and would have to be duplicated in even more drivers as they gain TX
>> support), it makes sense to move this timeout calculation to the lirc
>> layer instead.
>>
>> At the same time, centralize some of the sanity ch
On Thu, Aug 23, 2012 at 10:18:25PM +0100, Sean Young wrote:
>"[media] rc-core: move timeout and checks to lirc" introduced a buffer
>overrun by passing the number of bytes, rather than the number of samples,
>to the transmit function.
>
>Signed-off-by: Sean Young
Acked-by
er which device stops sending data
> * @min_timeout: minimum timeout supported by device
> * @max_timeout: maximum timeout supported by device
>@@ -108,6 +109,7 @@ struct rc_dev {
> u32 last_keycode;
> u32 last_scancode;
&g
On Tue, Aug 21, 2012 at 01:55:12PM +0100, Sean Young wrote:
>On Mon, Aug 20, 2012 at 07:02:47PM -0300, Mauro Carvalho Chehab wrote:
>> Em 20-08-2012 18:36, David Härdeman escreveu:
>> > On Thu, Aug 16, 2012 at 08:12:34PM -0300, Mauro Carvalho Chehab wrote:
>> >> E
ed to do an ioctl first to get the bitmask of
supported modes. This would just be another TX mode.
--
David Härdeman
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 20, 2012 at 07:02:47PM -0300, Mauro Carvalho Chehab wrote:
>Em 20-08-2012 18:36, David Härdeman escreveu:
>> On Thu, Aug 16, 2012 at 08:12:34PM -0300, Mauro Carvalho Chehab wrote:
>>> Em 16-08-2012 19:15, Sean Young escreveu:
>>>>
>>>>>
imitrov proposed (i.e. the
Harmony fixups) and see if that makes any difference? Perhaps the
harmony actually does manage to send some bogus data (of sufficiently
short duration not to show up in the captured RX data)...
--
David Härdeman
--
To unsubscribe from this list: send the line "
gt; layer instead.
>>>
>>> At the same time, centralize some of the sanity checks.
>>>
>>> Signed-off-by: David Härdeman
>>> Cc: Jarod Wilson
>>> Signed-off-by: Mauro Carvalho Chehab
>>> ---
>>> drivers/media/rc/ir-lir
On Tue, Jul 31, 2012 at 11:37:03AM +0100, Sean Young wrote:
>The serial driver will detect the winbond cir device as a serial port,
>since it looks exactly like a serial port unless you know what it is
>from the PNP ID.
>
>Winbond CIR 00:04: Region 0x2f8-0x2ff already in use!
>Winbond CIR 00:04: di
On Thu, 5 Jul 2012 17:39:18 +0300, Konstantin Dimitrov
wrote:
> excuse me for my ignorance, but don't you think adjusting the IR
> receiver to universal remote control is fundamentally wrong, while the
> whole point of universal remote control like Logitech Harmony is to be
> adjusted to the IR re
On Thu, 5 Jul 2012 20:30:35 +1000, Anton Blanchard
wrote:
> I had a closer look. I dumped the RC6 debug, but I also printed the raw
> data in the interrupt handler:
>
> printk("%x %d %d\n", irdata, rawir.pulse, rawir.duration);
>
...
> That should have been a pulse but it came out as a space
On Mon, Jul 02, 2012 at 11:58:52AM +1000, Anton Blanchard wrote:
>
>We need to set a timeout so we can go idle on no activity.
This change Acked-by: David Härdeman
>We weren't setting driver_type and allowed_protos, so fix that
>up too.
driver_type is set in the upstream tree
On Mon, Jul 02, 2012 at 11:59:37AM +1000, Anton Blanchard wrote:
>
>When using my Logitech Harmony remote I get regular dropped events
>(about 1 in every 3). Adjusting the sample frequency to 6us so we
>sample at a multiple of an RC-6 pulse (444us) fixes it.
Sounds weird.
The in-kernel RC6 decode
On Mon, Jul 02, 2012 at 11:58:00AM +1000, Anton Blanchard wrote:
>
>We aren't getting any module info for the txandx option because
>of a typo:
>
>parm: txandrx:bool
>
>Signed-off-by: Anton Blanchard
Acked-by: David Härdeman
>---
>
>Index: linux
Using struct rc_event as the data unit for writes from userspace provides
more flexibility and easier future compatibility with future developments
(e.g. if rc-core grew support for some very different transmission, such
as RF transmission).
Signed-off-by: David Härdeman
---
drivers/media/rc
Remove the RC_MAP_EMPTY hack and instead allow for empty keymaps.
Signed-off-by: David Härdeman
---
drivers/media/dvb/dvb-usb/af9015.c |4
drivers/media/dvb/dvb-usb/af9035.c |1 -
drivers/media/dvb/dvb-usb/dvb-usb-remote.c |4 +---
drivers/media/dvb/dvb-usb
A few ifdef __KERNEL__ and some reorganisation to make rc-core.h usable from
userspace programs.
Signed-off-by: David Härdeman
---
include/media/rc-core.h | 76 +--
1 file changed, 54 insertions(+), 22 deletions(-)
diff --git a/include/media/rc
As an example, this patch adds support for the new RCIOCGIRRX ioctl
to rc-loopback.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-loopback.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/media/rc/rc-loopback.c b/drivers/media/rc/rc-loopback.c
Add write functionality to the rc chardev (for use in transmitting remote
control commands on capable hardware).
The data format of the TX data is probably going to have to be dependent
on the rc_driver_type.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-main.c | 68
This patch changes rc-core to use a device table rather than atomic integers
to assign unique numbers to each rc device. This is in preparation for
introducing rc-core chardevs.
Signed-off-by: David Härdeman
---
drivers/media/rc/ir-raw.c |2 +-
drivers/media/rc/rc-main.c | 41
: David Härdeman
---
drivers/media/rc/mceusb.c |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c
index f0f053d..9f546be 100644
--- a/drivers/media/rc/mceusb.c
+++ b/drivers/media/rc/mceusb.c
@@ -785,11 +785,7
t out.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-main.c | 12
include/media/rc-core.h| 38 ++
2 files changed, 50 insertions(+)
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index 390673c..e2b2e8c 100644
As an example, this patch adds support for the new RCIOCSIRRX ioctl
to rc-loopback and removes deprecated functions without a loss in
functionality (as LIRC will automatically use the new functions).
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-loopback.c | 84
This is another step towards allowing multiple keytables per rc_dev.
struct rc_dev is changed to hold an array of keytables (used later for
indexed access to keytables) as well as a list of the same keytables
(used for iteration in fast paths).
Signed-off-by: David Härdeman
---
drivers/media
ATOMIC allocations
can be avoided entirely at the cost of a couple of extra kmalloc()
calls when changing a keytable (which is normally done once during
boot).
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-keytable.c | 671 +++-
include/media/rc-
that I've
seen with e.g. Sony protocols).
Signed-off-by: David Härdeman
---
drivers/media/rc/Kconfig| 12 --
drivers/media/rc/Makefile |1
drivers/media/rc/ir-rc5-decoder.c | 51 ++
drivers/media/rc/ir-rc5-sz-decoder.c|
rc-core is a subsystem so it should be registered earlier if built into the
kernel.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-main.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index 0e50a84..6e02314
The scancode that is reported via the input device(s) is now incomplete
(missing the protocol) and redundant.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-keytable.c | 21 +
1 file changed, 5 insertions(+), 16 deletions(-)
diff --git a/drivers/media/rc/rc
In preparation for the next patches I had to understand the redrat driver (not
an easy task).
In the process I noticed that the debug printing functions look quite
suspicious. This is a minimal attempt at cleaning them up (though more work
remains to be done).
Signed-off-by: David Härdeman
As an example, this patch adds support for the new RCIOCSIRTX ioctl
to rc-loopback and removes deprecated functions without a loss in
functionality (as LIRC will automatically use the new functions).
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-loopback.c | 59
will add further events.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-main.c | 134 +++-
include/media/rc-core.h| 31 ++
2 files changed, 163 insertions(+), 2 deletions(-)
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc
obfuscated and kmalloc-happy) and that the
TX functionality in nuvoton-cir.c is, and was, probably broken
before and after this patch.
Signed-off-by: David Härdeman
---
drivers/media/rc/ene_ir.c| 47 +++
drivers/media/rc/ene_ir.h|9 -
drivers/media/rc/ir-lirc-codec.c | 57
functionality as an alternative to the
old one and another bunch of operations in struct rc_dev are now deprecated.
Signed-off-by: David Härdeman
---
drivers/media/rc/ir-lirc-codec.c | 42 +-
drivers/media/rc/rc-main.c | 13
include/media/rc
sure what the driver is trying to do, however, IR
handling seems incomplete ATM so deleting the offending
parts shouldn't affect funcationality
Signed-off-by: David Härdeman
---
drivers/media/rc/ati_remote.c |3 ---
drivers/media/rc/ir-nec-decoder.c
Add separe rc device events on keytable addition/removal.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-main.c |2 ++
include/media/rc-core.h|2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index 6c8bc3a..b16dbf4
()
instead of:
rc_register_device()
rc_unregister_device()
This allows scancode drivers to skip lots of unnecessary functionality.
Signed-off-by: David Härdeman
---
drivers/media/dvb/dvb-usb/Kconfig |2
drivers/media/dvb/dvb-usb/dvb-usb-remote.c |7
drivers
Simplify and improve the locking in rc-ir-raw by making better use of
the existing kfifo functionality and by using RCU where possible.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-core-priv.h |6 +-
drivers/media/rc/rc-ir-raw.c| 119 ---
2
As an example, this patch adds support for the new RCIOCGIRRX ioctl
to rc-loopback.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-loopback.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/media/rc/rc-loopback.c b/drivers/media/rc/rc-loopback.c
etting the
appropriate flag as now) or not (in which case it should always be on).
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-main.c | 28 +++
include/media/rc-core.h| 65
2 files changed, 93 insertions(+)
diff --git a/driver
Move some more keytable related functionality over to rc-keytable.c which
allows more implementational details to be obscured away.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-core-priv.h | 11 +-
drivers/media/rc/rc-keytable.c | 213
Having a mutex named "lock" is a bit misleading.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-keytable.c |8
drivers/media/rc/rc-main.c | 22 +++---
include/media/rc-core.h|4 ++--
3 files changed, 17 insertions(+), 17 deletion
Reporting pulse/space events via the /dev/rc/rcX device node is an
important step towards having feature parity with LIRC.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-ir-raw.c | 11 +++
include/media/rc-core.h | 10 ++
2 files changed, 21 insertions(+)
diff
The name is already misleading and will be more so in the future as the
connection to the input subsystem is obscured away further.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-main.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media/rc/rc
Fix various sparse warnings under drivers/media/rc/*.c, mostly
by making functions static.
Signed-off-by: David Härdeman
---
drivers/media/rc/ene_ir.c |2 +-
drivers/media/rc/fintek-cir.c |4 ++--
drivers/media/rc/imon.c|8
drivers/media/rc/ite-cir.c
e ops.
Signed-off-by: David Härdeman
---
Documentation/ioctl/ioctl-number.txt |1 +
drivers/media/rc/rc-main.c | 66 ++
include/media/rc-core.h | 19 ++
3 files changed, 86 insertions(+)
diff --git a/Documentation/ioctl/
several
operations in struct rc_dev to be deprecated.
Signed-off-by: David Härdeman
---
drivers/media/rc/ir-lirc-codec.c | 53 +-
drivers/media/rc/rc-core-priv.h |3 ++
drivers/media/rc/rc-main.c | 53 +-
include
in a call to
input_dev->open() which might take the same mutex (to update the user
count, see later patches).
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-main.c | 95 ++--
include/media/rc-core.h|3 -
2 files changed, 40 insertion
Remove a redundant spinlock from struct rc_map.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-keytable.c | 43 +---
include/media/rc-core.h|4 ++--
include/media/rc-map.h |1 -
3 files changed, 20 insertions(+), 28 deletions
Use atomic reads to avoid having to take a mutex when getting
the bitmask of supported protocols.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-core-priv.h |2 +-
drivers/media/rc/rc-ir-raw.c| 12
2 files changed, 5 insertions(+), 9 deletions(-)
diff --git a
As all the basics are now in place, we can finally add the ioctls
for adding/removing keytables from userspace.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-core-priv.h |3 +
drivers/media/rc/rc-keytable.c |6 ++-
drivers/media/rc/rc-main.c | 82
Using the full 32 bits for all kinds of NEC scancodes simplifies rc-core
and the nec decoder without any loss of functionality.
Signed-off-by: David Härdeman
---
drivers/media/dvb/dvb-usb/af9015.c | 22 ++
drivers/media/dvb/dvb-usb/af9035.c | 20
t the most important part is the userspace<->kernel
interface (i.e. the read/write/ioctl interface).
Comments?
---
David Härdeman (43):
rc-core: move timeout and checks to lirc
rc-core: add separate defines for protocol bitmaps and numbers
rc-core: don't thr
This patch lays the groundwork for adding a rc-core chardev.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-main.c | 211
include/media/rc-core.h|6 +
2 files changed, 196 insertions(+), 21 deletions(-)
diff --git a/drivers/media/rc
of the sanity checks.
Signed-off-by: David Härdeman
---
drivers/media/rc/ir-lirc-codec.c | 33 +
drivers/media/rc/mceusb.c| 18 --
drivers/media/rc/rc-loopback.c | 12
3 files changed, 29 insertions(+), 34 deletions
Setting the correct mode is required by rc-core or scancodes won't be
generated (which isn't very user-friendly).
This one-line fix should be suitable for 3.4-rc2.
Signed-off-by: David Härdeman
Cc: sta...@kernel.org
---
drivers/media/rc/winbond-cir.c |1 +
1 file changed, 1
Acked-by: David Härdeman
On Sun, 21 Aug 2011 15:56:47 -0700, Joe Perches wrote:
> Add pr_fmt, convert printks to pr_.
>
> Signed-off-by: Joe Perches
> ---
> drivers/media/rc/winbond-cir.c |6 --
> 1 files changed, 4 insertions(+), 2 deletions(-)
--
To unsubscr
On Wed, 04 May 2011 11:56:17 -0300, Mauro Carvalho Chehab
wrote:
> Em 28-04-2011 12:13, David Härdeman escreveu:
>> The RC_TYPE_* defines are currently used both where a single protocol
is
>> expected and where a bitmap of protocols is expected. This patch tries
>> t
On Wed, 04 May 2011 12:19:12 -0300, Mauro Carvalho Chehab
wrote:
> Em 28-04-2011 12:13, David Härdeman escreveu:
>> Now that the protocol is part of the scancode, it is pretty easy to
merge
>> the rc5 and streamzap decoders. An additional advantage is that the
>> decoder
>
On Wed, 04 May 2011 12:13:49 -0300, Mauro Carvalho Chehab
wrote:
> Em 29-04-2011 05:08, David Härdeman escreveu:
>> diff --git a/drivers/media/rc/keymaps/rc-videomate-s350.c
>> b/drivers/media/rc/keymaps/rc-videomate-s350.c
>> index 26ca260..2f0ec1f 100644
>> --- a/
On Wed, 04 May 2011 12:16:17 -0300, Mauro Carvalho Chehab
wrote:
> Em 28-04-2011 12:13, David Härdeman escreveu:
>> Using the full 32 bits for all kinds of NEC scancodes simplifies
rc-core
>> and the nec decoder without any loss of functionality.
>
> This seems to be a good
On Wed, 04 May 2011 12:23:03 -0300, Mauro Carvalho Chehab
wrote:
> Em 28-04-2011 12:13, David Härdeman escreveu:
>> Durations can never be negative, so it makes sense to consistently use
>> unsigned int for LIRC transmission. Contrary to the initial impression,
>> this shou
On Thu, 28 Apr 2011 21:13:22 +0100, Malcolm Priestley
wrote:
> On Thu, 2011-04-28 at 17:13 +0200, David Härdeman wrote:
>> The following series is what's in my current patch queue for rc-core.
>>
>> It only been lightly tested so far and it's based on the "fo
support), it makes sense to move this timeout calculation to the lirc
layer instead.
At the same time, centralize some of the sanity checks.
Signed-off-by: David Härdeman
---
drivers/media/rc/ir-lirc-codec.c | 33 +
drivers/media/rc/mceusb.c| 18
Durations can never be negative, so it makes sense to consistently use
unsigned int for LIRC transmission. Contrary to the initial impression,
this shouldn't actually change the userspace API.
Signed-off-by: David Härdeman
---
drivers/media/rc/ene_ir.c|4 ++--
drivers/med
that I've
seen with e.g. Sony protocols).
Signed-off-by: David Härdeman
---
drivers/media/rc/Kconfig| 12 --
drivers/media/rc/Makefile |1
drivers/media/rc/ir-rc5-decoder.c | 51 ++
drivers/media/rc/ir-rc5-sz-decoder.c|
Using the full 32 bits for all kinds of NEC scancodes simplifies rc-core
and the nec decoder without any loss of functionality.
Signed-off-by: David Härdeman
---
drivers/media/dvb/dvb-usb/af9015.c | 22 ++
drivers/media/rc/ir-nec-decoder.c | 28
ng
silence after the end of TX data.
Signed-off-by: David Härdeman
---
drivers/media/rc/rc-loopback.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/media/rc/rc-loopback.c b/drivers/media/rc/rc-loopback.c
index 49cee61..cc846b2 100644
--- a/drivers/media/rc
This patch adds preliminary IR TX capabilities to the
winbond-cir driver.
Signed-off-by: David Härdeman
---
drivers/media/rc/winbond-cir.c | 431 +---
1 files changed, 356 insertions(+), 75 deletions(-)
diff --git a/drivers/media/rc/winbond-cir.c b/drivers
Using ir_raw_event_store_with_filter() saves about 20 lines of code.
Signed-off-by: David Härdeman
---
drivers/media/rc/winbond-cir.c | 63 +---
1 files changed, 21 insertions(+), 42 deletions(-)
diff --git a/drivers/media/rc/winbond-cir.c b/drivers/media
Using bool instead of an int helps readability a bit.
Signed-off-by: David Härdeman
---
drivers/media/rc/winbond-cir.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/media/rc/winbond-cir.c b/drivers/media/rc/winbond-cir.c
index b0a5fdc..cdb5ef4
reason for the large number of lines changed in the combined diffstat
(the number of lines changed would probably be in the hundreds rather than
thousands if keymaps were excluded).
Comments?
---
David Härdeman (10):
rc-core: int to bool conversion for winbond-cir
rc-core: add TX su
Using bool instead of an int helps readability a bit.
Signed-off-by: David Härdeman
---
drivers/media/rc/winbond-cir.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/media/rc/winbond-cir.c b/drivers/media/rc/winbond-cir.c
index b0a5fdc..cdb5ef4
Not having the correct mode and a default keymap is not
very user-friendly (and rc-core won't allow it).
Signed-off-by: David Härdeman
---
drivers/media/rc/winbond-cir.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/media/rc/winbond-cir.c b/drivers/med
The conversion of winbond-cir to use rc-core seems to have missed a
a few bits and pieces which were in my local tree. Kudos to
Juan Jesús García de Soria Lucena for noticing.
Signed-off-by: David Härdeman
---
drivers/media/rc/winbond-cir.c | 20 +---
1 files changed, 5
e two
receivers). TX data that is sent is fed back as input on the
corresponding receiver, which allows for debugging of IR decoders,
keymaps, etc.
Signed-off-by: David Härdeman
---
drivers/media/rc/Kconfig | 13 ++
drivers/media/rc/Makefile |1
drivers/media/rc/rc-loopback.c |
On Mon, Nov 22, 2010 at 01:40:28PM -0500, Jarod Wilson wrote:
>On Nov 22, 2010, at 12:42 PM, Mauro Carvalho Chehab wrote:
>
>> Em 19-11-2010 21:43, David Härdeman escreveu:
>>> Convert boolean variables to use the corresponding data type.
>>>
>>> Signed-off
On Mon, Nov 22, 2010 at 03:40:13PM -0200, Mauro Carvalho Chehab wrote:
>Em 19-11-2010 21:43, David Härdeman escreveu:
>> int to bool conversion for module parameters which are truely boolean.
>>
>> Signed-off-by: David Härdeman
>> ---
>> drivers/media/vid
On Mon, Nov 22, 2010 at 02:55:42PM -0200, Mauro Carvalho Chehab wrote:
>Em 19-11-2010 21:43, David Härdeman escreveu:
>> The use of the saa7134_card_ir->users seems racy, so protect the count with
>> a spinlock. Also use proper data types as arguments to __saa7134
On Thu, Nov 18, 2010 at 06:59:43PM -0200, Mauro Carvalho Chehab wrote:
>Em 18-11-2010 18:49, Jarod Wilson escreveu:
>> On Thu, Nov 18, 2010 at 09:43:19PM +0100, David Härdeman wrote:
>>> On Thu, Nov 18, 2010 at 11:33:04AM -0500, Jarod Wilson wrote:
>>>> Mauro&#x
Fix some minor comments etc which are leftover from the old naming scheme.
Signed-off-by: David Härdeman
---
drivers/media/rc/ir-raw.c |2 +-
drivers/media/rc/rc-core-priv.h |6 +++---
drivers/media/rc/rc-main.c |2 +-
include/media/rc-core.h | 12
int to bool conversion for module parameters which are truely boolean.
Signed-off-by: David Härdeman
---
drivers/media/video/saa7134/saa7134-input.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/video/saa7134/saa7134-input.c
b/drivers/media/video
bttv_ir is more consistent with all other structs used in the same driver.
Also, clean up the struct to remove commented out members and the work_struct
which is unused.
Signed-off-by: David Härdeman
---
drivers/media/video/bt8xx/bttv-input.c | 27 +--
drivers/media
Convert boolean variables to use the corresponding data type.
Signed-off-by: David Härdeman
---
drivers/media/rc/mceusb.c | 62 +++--
1 files changed, 26 insertions(+), 36 deletions(-)
diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c
The use of the saa7134_card_ir->users seems racy, so protect the count with
a spinlock. Also use proper data types as arguments to __saa7134_ir_start()
and __saa7134_ir_stop() to remove some unnecessary casts.
Signed-off-by: David Härdeman
---
drivers/media/video/saa7134/saa7134-input.c |
Both timers are used for a similar purpose. Merging them allows for some
minor simplifications.
Signed-off-by: David Härdeman
---
drivers/media/video/saa7134/saa7134-input.c | 10 --
drivers/media/video/saa7134/saa7134.h |1 -
2 files changed, 4 insertions(+), 7 deletions
Similarly to saa7134, bttv_ir has two timers, only one of which is used
at a time and which serve the same purpose. Merge them.
Signed-off-by: David Härdeman
---
drivers/media/video/bt8xx/bttv-input.c |8 +++-
drivers/media/video/bt8xx/bttvp.h |3 +--
2 files changed, 4
Mostly using appropriate data types and constants (e.g. int -> bool).
Signed-off-by: David Härdeman
---
drivers/media/video/saa7134/saa7134-input.c | 49 ++-
drivers/media/video/saa7134/saa7134.h |4 +-
2 files changed, 21 insertions(+), 32 deletions(-)
d
Using the full keycode for BeholdTV hardware makes another module
parameter unnecessary.
Signed-off-by: David Härdeman
---
drivers/media/rc/keymaps/rc-behold.c| 70 ++-
drivers/media/video/saa7134/saa7134-input.c | 19 +--
2 files changed, 37 insertions
ir_rc5_remote_gap is a leftover from ir-common, remove it.
Signed-off-by: David Härdeman
---
drivers/media/video/saa7134/saa7134-input.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/media/video/saa7134/saa7134-input.c
b/drivers/media/video/saa7134/saa7134
Here's a set of smaller patches which performs various cleanups, mostly to
the saa7134 and bttv driver. They are based on the media_tree.git repo
(2.6.38 branch) on top of Mauro's recent renaming patches.
---
David Härdeman (10):
saa7134: remove unused module parameter
sa
301 - 400 of 544 matches
Mail list logo
