Re: Null pointer dereference in ngene-core.c

2016-09-19 Thread Devin Heitmueller
On Mon, Sep 19, 2016 at 8:51 PM, Alexandre-Xavier Labonté-Lamoureux wrote: > Hi people, > > In the file "/linux/drivers/media/pci/ngene/ngene-core.c", there is a > null pointer dereference at line 1480. > > Code in the function "static int init_channel(struct ngene_channel *chan)" > ==

Re: Null pointer dereference in ngene-core.c

2016-09-19 Thread Devin Heitmueller
On Mon, Sep 19, 2016 at 8:51 PM, Alexandre-Xavier Labonté-Lamoureux wrote: > Hi people, > > In the file "/linux/drivers/media/pci/ngene/ngene-core.c", there is a > null pointer dereference at line 1480. > > Code in the function "static int init_channel(struct ngene_channel *chan)" > ==

Re: [PATCH 2/9] em28xx: Bulk transfer implementation fix

2018-01-05 Thread Devin Heitmueller
Hi Brad, My documents indicate that Register 0x5D and 0x5E are read-only, and populated based on the eeprom programming. On your device, what is the value of those registers prior to you changing them? If you write to those registers, do they reflect the new values if you read them back? Does c

Regression in VB2 alloc prepare/finish balancing with em28xx/au0828

2018-01-28 Thread Devin Heitmueller
Hello all, I recently updated to the latest kernel, and I am seeing the following dumped to dmesg with both au0828 and em28xx based devices whenever I exit tvtime (my kernel is compiled with CONFIG_VIDEO_ADV_DEBUG=y by default): [ 129.219666] vb2: counters for queue 88026463ac48: [ 129.2196

Re: Regression in VB2 alloc prepare/finish balancing with em28xx/au0828

2018-01-29 Thread Devin Heitmueller
Hello Sakari, Thanks for taking the time to investigate. See comments inline. On Sun, Jan 28, 2018 at 5:23 PM, Sakari Ailus wrote: > Hi Devin, > > On Sun, Jan 28, 2018 at 09:12:44AM -0500, Devin Heitmueller wrote: >> Hello all, >> >> I recently updated to the latest

Re: Regression in VB2 alloc prepare/finish balancing with em28xx/au0828

2018-02-01 Thread Devin Heitmueller
o you see any reason where at least for my local tree I cannot simply revert this patch until a real solution is found? Cheers, Devin On Mon, Jan 29, 2018 at 8:44 PM, Devin Heitmueller wrote: > Hello Sakari, > > Thanks for taking the time to investigate. See comments inline. > > On S

Re: [PATCH 1/1] vb2: core: Finish buffers at the end of the stream

2018-02-02 Thread Devin Heitmueller
Hello Sakari, Thanks for proposing this patch. I'll give it a try this weekend. Regards, Devin On Fri, Feb 2, 2018 at 5:08 AM, Sakari Ailus wrote: > If buffers were prepared or queued and the buffers were released without > starting the queue, the finish mem op (corresponding to the prepare m

Re: [PATCH 1/1] vb2: core: Finish buffers at the end of the stream

2018-02-05 Thread Devin Heitmueller
Hi Sakari, I tried this patch, and I no longer see the messages in dmesg output when closing the V4L2 device node. Tested-by: Devin Heitmueller Thanks, Devin On Fri, Feb 2, 2018 at 8:57 AM, Devin Heitmueller wrote: > Hello Sakari, > > Thanks for proposing this patch. I'll

Re: [media] duplicate code in media drivers

2018-05-21 Thread Devin Heitmueller
>> diff -u -p drivers/media/dvb-frontends/au8522_decoder.c >> /tmp/nothing/media/dvb-frontends/au8522_decoder.c >> --- drivers/media/dvb-frontends/au8522_decoder.c >> +++ /tmp/nothing/media/dvb-frontends/au8522_decoder.c >> @@ -280,14 +280,9 @@ static void setup_decoder_defaults(struc >>

Re: [PATCH] au8522: remove duplicate code

2018-05-22 Thread Devin Heitmueller
Reviewed-by: Devin Heitmueller Devin On Tue, May 22, 2018 at 1:09 PM, Gustavo A. R. Silva wrote: > This code has been there for nine years now, and it has been > working "good enough" since then [1]. > > Remove duplicate code by getting rid of the if-else statement. >

Re: [PATCH] media: em28xx: fix a regression with HVR-950

2018-06-26 Thread Devin Heitmueller
On Tue, Jun 26, 2018 at 4:09 PM, Brad Love wrote: > Hi Mauro, > > It turns out this patch breaks DualHD multiple tuner capability. When > alt mode is set in start_streaming it immediately kills the other tuners > stream. Essentially both tuners cannot be used together when this is > applied. I unf

cx88 invalid video opcodes when VBI enabled

2018-04-15 Thread Devin Heitmueller
Hello, I received a report of a case where cx88 video capture was failing on start and the dmesg was reporting an invalid opcode on the video IRQ handler. I did a bisect, and it looks like it's a result of the videobuf2 conversion done back in late 2014. A few notes: 1. It only seems to occur

Re: cx88 invalid video opcodes when VBI enabled

2018-04-17 Thread Devin Heitmueller
Hi Daniel, Thanks for the feedback. On Tue, Apr 17, 2018 at 12:53 AM, Daniel Glöckner wrote: >> [ 54.427224] cx88[0]: irq vid [0x10088] vbi_risc1* vbi_risc2* opc_err* >> [ 54.427232] cx88[0]/0: video risc op code error >> [ 54.427238] cx88[0]: video y / packed - dma channel status dump >

Re: cx88 invalid video opcodes when VBI enabled

2018-04-17 Thread Devin Heitmueller
Hello Daniel, See below. Devin [ 68.750805] cx88[0]: irq vid [0x18080] vbi_risc2* vbi_sync opc_err* [ 68.750805] cx88[0]/0: video risc op code error [ 68.750809] cx88[0]: video y / packed - dma channel status dump [ 68.750811] cx88[0]: cmds: initial risc: 0x8aa98000 [ 68.750813] cx88

Re: cx88 invalid video opcodes when VBI enabled

2018-04-21 Thread Devin Heitmueller
Hi Daniel, My apologies for the delayed replies; been out of town for the last couple of days. On Fri, Apr 20, 2018 at 5:54 PM, Daniel Glöckner wrote: > for some reason I feel like buffer_queue in cx88-vbi.c should not be > calling cx8800_start_vbi_dma as it is also called a few lines further >

[PATCH] cx88: Get rid of spurious call to cx8800_start_vbi_dma()

2018-04-24 Thread Devin Heitmueller
389208e1173e097590856ed24a505551510f78d4. Thanks to Daniel Glöckner for spotting the actual bug after I spent several days trying to chase down the issue. Signed-off-by: Devin Heitmueller Thanks-to: Daniel Glöckner Cc: Hans Verkuil --- drivers/media/pci/cx88/cx88-vbi.c | 1 - 1 file changed, 1 deletion

Re: [PATCH] cx231xx: correctly handling failed allocation

2015-12-29 Thread Devin Heitmueller
On Tue, Dec 29, 2015 at 1:53 PM, Insu Yun wrote: > Since kmalloc can be failed in memory pressure, > if not properly handled, NULL dereference can be happend > > Signed-off-by: Insu Yun > --- > drivers/media/usb/cx231xx/cx231xx-417.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dri

Re: em28xx driver for StarTech SVID2USB2

2016-01-06 Thread Devin Heitmueller
On Wed, Jan 6, 2016 at 1:27 PM, Schubert, Matthew R. (LARC-D319)[TEAMS2] wrote: > Hello, > > We are attempting to use a StarTech Video Capture cable (Part# SVID2USB2) > with our CentOS 6.7 machine with no success. The em28xx driver seems to load > but cannot properly ID the capture cable. Below

Re: HVR-850 2040:b140 fails to initialize

2016-03-08 Thread Devin Heitmueller
> Appreciate some advice. Return it and get an HVR-950q. This has been a known issue for more than 5 years and nobody's gotten around to fixing it (largely because of limitations inside the V4L2 framework). Devin (a.k.a. the guy who added the original support for the HVR-850). -- Devin J. Heit

Re: [PATCH 08/12] Add USB quirk for HVR-950q to avoid intermittent device resets

2017-06-19 Thread Devin Heitmueller
> I've accepted the other patches in this patch series for the media subsystem, > but this patch should go through the USB subsystem. Cc-ed linux-usb. > > Acked-by: Hans Verkuil I'm not sure who on the linux-usb mailing list would need to deal with this, but would be great if we could get this

Re: Bug: Two device nodes created in /dev for a single UVC webcam

2018-02-20 Thread Devin Heitmueller
Hi Laurent, On Mon, Feb 19, 2018 at 11:19 AM, Laurent Pinchart wrote: > I've tested VLC (2.2.8) and haven't noticed any issue. If a program is > directed to the metadata video node and tries to capture video from it it will > obviously fail. That being said, software that work today should contin

Re: pinnacle 300i driver crashed after first device access

2018-02-23 Thread Devin Heitmueller
On Fri, Feb 23, 2018 at 2:30 PM, Federico Allegretti wrote: > i noticed that my pinnacle 300i could accept full resolution settings: > v4l2-ctl --set-fmt-video=width=720,height=576 > > only the first time the command is fired. > > after that, evey time i try to set that resolution with the same >

Re: pinnacle 300i driver crashed after first device access

2018-02-23 Thread Devin Heitmueller
On Fri, Feb 23, 2018 at 2:37 PM, Devin Heitmueller wrote: > On Fri, Feb 23, 2018 at 2:30 PM, Federico Allegretti > wrote: >> i noticed that my pinnacle 300i could accept full resolution settings: >> v4l2-ctl --set-fmt-video=width=720,height=576 >> >> only the f

Re: [PATCH RFC] media: em28xx: don't use coherent buffer for DMA transfers

2018-02-28 Thread Devin Heitmueller
On Tue, Feb 27, 2018 at 12:42 PM, Mauro Carvalho Chehab wrote: > While coherent memory is cheap on x86, it has problems on > arm. So, stop using it. > > Signed-off-by: Mauro Carvalho Chehab > --- > > I wrote this patch in order to check if this would make things better > for ISOCH transfers on Ra

Re: [PATCH v2 0/6] Fix tvp5150 regression with em28xx

2016-12-21 Thread Devin Heitmueller
Hi Mauro, > With that, I completed the tests on HVR-950. My tests covered: > - S-Video, Composite, TV > - 480i and 480p > - Closed Captions (with HVR-350 - it seems that MediaMVP doesn't > produce NTSC CC). FYI: the MediaMVP HD can be configured to output NTSC CC over VBI. If you want that fun

Re: [xawtv3] Request: Support for FM RDS

2017-02-15 Thread Devin Heitmueller
Hi George, The big problem is that almost none of the hardware tuners out there which support FM have support for RDS. You generally need an extra chip, and very few devices have it (IIRC, none of the ones that are supported in Linux have been available in retail for a number of years). Don't ge

Re: Problem: saa7113 (saa7115) vs. "conrad usb grabber usb-472"

2017-02-21 Thread Devin Heitmueller
> lsusb: > Bus 003 Device 002: ID 0573:0400 Zoran Co. Personal Media Division (Nogatech) > D-Link V100 The Zoran usbvision driver has been a mess for years, and it's not going to get better anytime soon. It's a *really* old design and there hasn't been any interest from any of the developers to

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-05 Thread Devin Heitmueller
> Currently, the driver doesn't support (2), because, at the time > I wrote the driver, I didn't find a way to read the interrupts generated > by tvp5150 at em28xx[1], due to the lack of em28xx documentation, > but adding support for it shoudn't be hard. I may eventually do it > when I have some ti

Re: [RFC] [media] imx: assume MEDIA_ENT_F_ATV_DECODER entities output video on pad 1

2017-04-05 Thread Devin Heitmueller
>> For what it's worth, I doubt most of the em28xx designs have the >> tvp5150 interrupt request line connected in any way. > > True. But, on embedded hardware, such line may be connected into the > SoC. Actually, from the IGEPv3 expansion diagram: > > > https://www.isee.biz/support/downlo

Re: [PATCH] Support HVR-1200 analog video as a clone of HVR-1500. Tested, composite and s-video inputs.

2017-09-18 Thread Devin Heitmueller
On Sun, Sep 17, 2017 at 5:42 PM, Nigel Kettlewell wrote: > I propose the following patch to support Hauppauge HVR-1200 analog video, > nothing more than a clone of HVR-1500. Patch based on Linux 4.9 commit > 69973b830859bc6529a7a0468ba0d80ee5117826 > > I have tested composite and S-Video inputs. >

Re: [PATCH v3 04/26] media: lirc_zilog: remove receiver

2017-10-11 Thread Devin Heitmueller
> There's an ir_lock mutex in the driver to prevent simultaneous access to the > Rx and Tx functions of the z8. Accessing Rx and Tx functions of the chip > together can cause it to do the wrong thing (sometimes hang?), IIRC. > > I'll see if I can dig up my old disassembly of the z8's firmware to

Re: [PATCH v3 04/26] media: lirc_zilog: remove receiver

2017-10-11 Thread Devin Heitmueller
Hi Andy, > 5. Rx and IR Learn both use the same external hardware. Not > coordinating Rx with Learn mode in the same driver, will prevent Learn > operation from working. That is, if Learn mode is ever implemented. > (Once upon a time, I was planning on doing that. But I have no time > for that

Re: cx231xx IR remote control protocol

2017-10-23 Thread Devin Heitmueller
Hi Oleh, On Mon, Oct 23, 2017 at 5:37 AM, Sean Young wrote: > Hi Oleh, > > On Sun, Oct 22, 2017 at 05:01:05PM +0300, Oleh Kravchenko wrote: >> Hi, >> >> I'm trying add support remote control for tuners: >> - EvroMedia Full Hybrid Full HD >> - Astrometa T2hybrid >> >> But I'm stuck. Can anybody re

RFC: Power states and VIDIOC_STREAMON

2017-04-19 Thread Devin Heitmueller
Hello all, I'm in the process of putting together a bunch of long-standing fixes for HVR-950q driver, and I ran into a regression related to the way the video decoder is being managed. Before we dig into the details here's the general question: Should a user be able to interrogate video decoder

[PATCH] cx88: Fix regression in initial video standard setting

2017-04-19 Thread Devin Heitmueller
ession was introduced in the following commit: commit ccd6f1d488e7 ("[media] cx88: move width, height and field to core struct") Author: Hans Verkuil Date: Sat Sep 20 09:23:44 2014 -0300 [media] cx88: move width, height and field to core struct Signed-off-by: Devin Heitmueller --

[PATCH 06/12] au8522 Remove 0x4 bit for register reads

2017-04-19 Thread Devin Heitmueller
: Devin Heitmueller --- drivers/media/dvb-frontends/au8522_dig.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/media/dvb-frontends/au8522_dig.c b/drivers/media/dvb-frontends/au8522_dig.c index d117ddb..3f3635f 100644 --- a/drivers/media/dvb-frontends

[PATCH 00/12] minor cleanups for HVR-950q

2017-04-19 Thread Devin Heitmueller
This is a series of mostly minor cleanups/fixes for the HVR-950q driver. We'll get this stuff merged since it's non-controversial, and then we can argue about the more invasive patches to follow. Devin Heitmueller (12): au8522: don't attempt to configure unsupported VBI slicer

[PATCH 01/12] au8522: don't attempt to configure unsupported VBI slicer

2017-04-19 Thread Devin Heitmueller
only supported way to access VBI on this device. Signed-off-by: Devin Heitmueller --- drivers/media/dvb-frontends/au8522_decoder.c | 38 1 file changed, 38 deletions(-) diff --git a/drivers/media/dvb-frontends/au8522_decoder.c b/drivers/media/dvb-frontends/au8522_deco

[PATCH 04/12] au8522: remove note about VBI not being implemented

2017-04-19 Thread Devin Heitmueller
I got this working a couple of years ago. Remove it from the list of known issues. Signed-off-by: Devin Heitmueller --- drivers/media/dvb-frontends/au8522_decoder.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/dvb-frontends/au8522_decoder.c b/drivers/media/dvb-frontends

[PATCH 05/12] au8522: remove leading bit for register writes

2017-04-19 Thread Devin Heitmueller
The leading bit in register values is actually an indicator as to whether to perform a read or write, so remove the bit from the register values, since the au8522_writereg() is now responsible for adding this bit automatically. Signed-off-by: Devin Heitmueller --- drivers/media/dvb-frontends

[PATCH 02/12] au8522: don't touch i2c master registers on au8522

2017-04-19 Thread Devin Heitmueller
n actually interfere with the operation of the bus. Signed-off-by: Devin Heitmueller --- drivers/media/dvb-frontends/au8522_decoder.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/dvb-frontends/au8522_decoder.c b/drivers/media/dvb-frontends/au8522_decoder.c index 12a5c2c..7811

[PATCH 08/12] Add USB quirk for HVR-950q to avoid intermittent device resets

2017-04-19 Thread Devin Heitmueller
startup, in particular when starting up ALSA audio streaming in parallel - the sysfs entries created by snd-usb-audio on streaming startup would result in unsupported control messages being sent during tuning which would put the chip into an unknown state. Signed-off-by: Devin Heitmueller

[PATCH 03/12] au8522: rework setup of audio routing

2017-04-19 Thread Devin Heitmueller
inputs from 1300ms down to 600ms (as measured by "time v4l2-ctl -i 0") Note this does not address outstanding issues related to the management of the module clocks and power control for the various blocks, which will be done in a separate patch. Signed-off-by: Devin Heitmueller --- dri

[PATCH 09/12] xc5000: Don't spin waiting for analog lock

2017-04-19 Thread Devin Heitmueller
stent with other functions). Note this change has no practical effect at this time as none of the callers inspect the return value. Signed-off-by: Devin Heitmueller --- drivers/media/tuners/xc5000.c | 26 ++ 1 file changed, 2 insertions(+), 24 deletions(-) diff --

[PATCH 07/12] au8522: fix lock detection to be more reliable.

2017-04-19 Thread Devin Heitmueller
Only looking at the lock register causes the status to float between locked and not locked when there is no signal. So improve the logic to also examine the state of the FSC PLL, which results in the lock status being consistently reported. Signed-off-by: Devin Heitmueller --- drivers/media

[PATCH 12/12] au0828: Add timer to restart TS stream if no data arrives on bulk endpoint

2017-04-19 Thread Devin Heitmueller
For reasons unclear, we intermittently see a case where the tune is successful but the bulk stream fails to deliver any packets. Add a timer to automatically stop/start the data pump if we encounter such a case. Signed-off-by: Devin Heitmueller --- drivers/media/usb/au0828/au0828-dvb.c | 30

[PATCH 11/12] Fix breakage in "make menuconfig" for media_build

2017-04-19 Thread Devin Heitmueller
The Kconfig format is strict enough where if the indentation isn't correct then the "make menuconfig" will break. Fix the indentation to match all the other entries. Signed-off-by: Devin Heitmueller --- drivers/media/rc/Kconfig | 8 1 file changed, 4 insertions(

[PATCH 10/12] au8522: Set the initial modulation

2017-04-19 Thread Devin Heitmueller
We need to set the initial modulation on driver setup, or else any calls to GET_FRONTEND prior to the first SET_FRONTEND call will get back garbage. Signed-off-by: Devin Heitmueller --- drivers/media/dvb-frontends/au8522_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media

Re: RFC: Power states and VIDIOC_STREAMON

2017-04-21 Thread Devin Heitmueller
>> I had always interpreted it such that the STREAMON call just >> controlled whether the DMA engine was running, and thus you could do >> anything else with the decoder before calling STREAMON other than >> actually receiving video buffers. > > Indeed there's an ambiguity there, although I always

[PATCH] mxl111sf: Fix driver to use heap allocate buffers for USB messages

2017-04-21 Thread Devin Heitmueller
them. Note: we also had to tweak the API to mxl111sf_ctrl_msg to pass the pointer to the state struct rather than the device, since we need it inside the function to access the buffers and the mutex. This patch adjusts the callers to match the API change. Signed-off-by: Devin Heitmueller

Re: [PATCH 1/2] em28xx: allow setting the eeprom bus at cards struct

2017-05-01 Thread Devin Heitmueller
On Mon, May 1, 2017 at 10:11 AM, Frank Schäfer wrote: > > Am 01.05.2017 um 13:38 schrieb Mauro Carvalho Chehab: >> Right now, all devices use bus 0 for eeprom. However, newer >> versions of Terratec H6 use a different buffer for eeprom. >> >> So, add support to use a different I2C address for eepr

Re: [bug report] drx: add initial drx-d driver

2017-12-14 Thread Devin Heitmueller
> I think I wrote the driver more than 10 years ago and somebody later > submitted it > to the kernel. I'm pretty sure that was me, or perhaps I was the first person to get it to work with a device upstream - it was so long ago. > I don't know if there is a anybody still maintaining this. Is it

V4L2 spec behavior for G_TUNER and T_STANDBY

2011-01-01 Thread Devin Heitmueller
I have been doing some application conformance for VLC, and I noticed something interesting with regards to the G_TUNER call. If you have a tuner which supports sleeping, making a G_TUNER call essentially returns garbage. === r...@devin-laptop2:~# v4l2-ctl -d /dev/video1 --get-tuner Tuner: Nam

Re: V4L2 spec behavior for G_TUNER and T_STANDBY

2011-01-01 Thread Devin Heitmueller
Hi Hans, Thanks for the feedback. On Sat, Jan 1, 2011 at 4:18 PM, Hans Verkuil wrote: >> This basically means that a video tuner will bail out, which sounds >> good because the rest of the function supposedly assumes a radio >> device.  However, as a result the has_signal() call (which returns >

Re: Problem with em28xx driver in Gumstix Overo

2011-01-03 Thread Devin Heitmueller
On Mon, Jan 3, 2011 at 3:13 PM, Linus Torvalds wrote: >> // if (!dev->progressive) >> // height >>= norm_maxh(dev); This would suggest that the device is providing progressive video and there is a mismatch between the board profile and the actual hardware, which is certainly possible but I know a

Re: Debug code in HG repositories

2011-01-07 Thread Devin Heitmueller
On Fri, Jan 7, 2011 at 2:53 PM, Oliver Endriss wrote: > Hi guys, > > are you aware that there is a lot of '#if 0' code in the HG repositories > which is not in GIT? > > When drivers were submitted to the kernel from HG, the '#if 0' stuff was > stripped, unless it was marked as 'keep'... > > This w

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-13 Thread Devin Heitmueller
On Thu, Jan 13, 2011 at 8:21 AM, Jean Delvare wrote: > My bet is that register at 0x00 is a control register, and writing bit > 7 (value 0x80) makes the chip busy enough that it can't process I2C > requests at the same time. The following naks would be until the > chip is operational again. Corre

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-13 Thread Devin Heitmueller
On Thu, Jan 13, 2011 at 11:34 AM, Andy Walls wrote: > Devin, > > You've seen the clock stretch with your I2C analyzer? The Beagle I was using when I did the captures doesn't show clock stretch. My "Logic" logic analyzer does, but I wasn't using that at the time. That said, I can say with some a

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-13 Thread Devin Heitmueller
On Thu, Jan 13, 2011 at 11:48 AM, Jean Delvare wrote: > On Thu, 13 Jan 2011 11:34:42 -0500, Andy Walls wrote: >> How should clock stretches by slaves be handled using i2c-algo-bit? > > It is already handled. But hdpvr-i2c doesn't use i2c-algo-bit. I2C > support is done with USB commands instead. M

Re: [linux-media] API V3 vs SAPI behavior difference in reading tuning parameters

2011-01-14 Thread Devin Heitmueller
On Fri, Jan 14, 2011 at 8:35 AM, Thierry LELEGARD wrote: > But there is worse. If I set a wrong parameter in the tuning operation, > for instance guard interval 1/32, the API V3 returns the correct value > which is actually used by the tuner (GUARD_INTERVAL_1_8), while S2API > returns the "cached"

Re: [GIT PATCHES for 2.6.38] Zilog Z8 IR unit fixes

2011-01-19 Thread Devin Heitmueller
On Wed, Jan 19, 2011 at 11:08 AM, Jarod Wilson wrote: >> BTW, does your HVR-1950 have a blaster? > > Yes, it does, looks like a jack identical to the one on the hdpvr, which > is good, since I don't have the 1950's blaster cable. Correct - it uses the same cable as the HD-PVR. The IR receiver on

Re: DViCO FusionHDTV7 Dual Express I2C write failed

2011-01-19 Thread Devin Heitmueller
On Wed, Jan 19, 2011 at 10:59 AM, VDR User wrote: > Can someone please look into this and possibly provide a fix for the > bug?  I'm surprised it hasn't happened yet after all this time but > maybe it's been forgotten the bug existed. You shouldn't be too surprised. In many cases device support

Re: Hauppauge Nova-T-500; losing one tuner. Regression?

2011-01-23 Thread Devin Heitmueller
Hi Alex, > As a refresher, the drivers in the 2.6.26.6-49 kernel didn't yet include > support for the new I2C functions only supported by dib0700 firmware > revisions >= 1.20.  I don't think this is relevant to the Nova-T-500, > though, as only s5h1411_frontend_attach() and lgdt3305_frontend_attac

[PATCH] Fix bug in au0828 VBI streaming

2011-01-23 Thread Devin Heitmueller
- Kernel Labs http://www.kernellabs.com au0828: fix VBI handling when in V4L2 streaming mode From: Devin Heitmueller It turns up V4L2 streaming mode (a.k.a mmap) was broken for VBI streaming. This was causing libzvbi to fall back to V4L1 capture mode, and is a blatent violation of the V4L2

[RFC PATCH] tuner-core: fix broken G_TUNER call when tuner is in standby

2011-01-23 Thread Devin Heitmueller
Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com tuner-core: fix broken G_TUNER call when tuner is in standby From: Devin Heitmueller The logic for determining the supported device modes was combined with the logic which dictates whether the tuner was asleep. This resulted in calls

Re: DViCO FusionHDTV7 Dual Express I2C write failed

2011-01-24 Thread Devin Heitmueller
On Mon, Jan 24, 2011 at 10:49 AM, Mark Zimmerman wrote: > From looking at the code and a dump of the firmware file, the first > i2c write would have a length of 3; so this error: > > xc5000: I2C write failed (len=3) > > tells me that there were probably no successful i2c transactions on > this dev

Re: [PATCH] video/cx231xx: Fix sparse warning: Using plain integer as NULL pointer

2011-01-25 Thread Devin Heitmueller
CX25840_SVIDEO_ON, .amux = CX231XX_AMUX_LINE_IN, - .gpio = 0, + .gpio = NULL, } }, }, }; -- 1.7.2.2 Reviewed-by: Devin Heitmueller -- Devin Heitmueller Senior Software Engineer Hauppauge Computer W

Re: [PATCH] video/saa7164: Fix sparse warning: Using plain integer as NULL pointer

2011-01-25 Thread Devin Heitmueller
On Tue, Jan 25, 2011 at 5:54 PM, Peter Hüwe wrote: > Hi Julia, > > thanks for your input. > So do I understand you correctly if I say > if(!x) is better than if(x==NULL) in any case? > > Or only for the kmalloc family? > > Do you remember the reason why !x should be preferred? > > In Documentation

Re: DVB driver for TerraTec H7 - how do I install them?

2011-01-25 Thread Devin Heitmueller
On Tue, Jan 25, 2011 at 6:29 PM, Torfinn Ingolfsen wrote: > Anybody? If Terratec provided the driver, any support related questions should be directed to them, not to this list. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the lin

Re: What to do with videodev.h

2011-01-26 Thread Devin Heitmueller
On Wed, Jan 26, 2011 at 6:36 AM, Mauro Carvalho Chehab wrote: > We should touch the tools that we care of. Maybe Devin could change tvtime, > we should remove V4L1 driver from xawtv3/xawtv4. Yeah, I have some tvtime work planned, and dropping v4l1 was definitely on the list. I actually dropped t

Re: Is media_build download broken?

2011-01-26 Thread Devin Heitmueller
On Wed, Jan 26, 2011 at 9:38 AM, Jarod Wilson wrote: > Seems that an explicit 'pull over ssh' command was recently added > to media_build, which only works if you've got a shell account on > linuxtv.org. I'll ask Mauro about it and/or just fix it. He should just have to do "git://" instead of "ss

Re: HVR1255 svideo

2011-01-29 Thread Devin Heitmueller
On Sat, Jan 29, 2011 at 1:53 PM, Jon Goldberg wrote: > Hi > > I've been trying to get the Svideo input on my HVR-1255 working.  From > the latest code in cx23885-cards.c, it seems that only DVB is > supported.  I have some experience writing Linux Kernel/Drivers so I'm > determined to get this wor

Re: [PATCH v2] video/saa7164: Fix sparse warning: Using plain integer as NULL pointer

2011-01-30 Thread Devin Heitmueller
On Sun, Jan 30, 2011 at 2:33 PM, Peter Huewe wrote: > From: Peter Huewe > > This patch fixes the warning "Using plain integer as NULL pointer", > generated by sparse, by replacing >        if(var == 0) > with >        if (!var) > after an allocation > and all other offending 0s with NULL. > > Ker

Call for testers: V4L1 support dropped from tvtime

2011-02-01 Thread Devin Heitmueller
I know this is the linux-media mailing list and not the tvtime mailing list, but it seems relevant given the overlap in the user base and the fact that these changes are specifically in response to recent events with v4l-dvb. I have modified the KernelLabs build of tvtime to no longer depend on V4

[PATCH RESEND] Fix bug in au0828 VBI streaming

2011-02-02 Thread Devin Heitmueller
On Sun, Jan 23, 2011 at 5:12 PM, Devin Heitmueller wrote: > Attached is a patch for a V4L2 spec violation with regards to the > au0828 not working in streaming mode. > > This was just an oversight on my part when I did the original VBI > support for this bridge, as libzvbi was s

Re: [PATCH RESEND] Fix bug in au0828 VBI streaming

2011-02-03 Thread Devin Heitmueller
On Wed, Feb 2, 2011 at 8:58 AM, Devin Heitmueller wrote: > On Sun, Jan 23, 2011 at 5:12 PM, Devin Heitmueller > wrote: >> Attached is a patch for a V4L2 spec violation with regards to the >> au0828 not working in streaming mode. >> >> This was just an oversight on m

Re: [RFC PATCH] tuner-core: fix broken G_TUNER call when tuner is in standby

2011-02-03 Thread Devin Heitmueller
On Wed, Feb 2, 2011 at 10:21 AM, Mauro Carvalho Chehab wrote: > Em 23-01-2011 20:22, Devin Heitmueller escreveu: >> Hello all, >> >> The following patch addresses a V4L2 specification violation where the >> G_TUNER call would return complete garbage in the event that t

Re: em28xx: board id [eb1a:2863 eMPIA Technology, Inc] Silver Crest VG2000 "USB 2.0 Video Grabber"

2011-02-08 Thread Devin Heitmueller
On Tue, Feb 8, 2011 at 5:05 PM, Martin Seekatz wrote: > The vbi0 device is not working: > ERROR: Couldn't attach to DCOP server! > [0x10713a0] v4l2 demux error: device does not support mmap i/o > [0x10713a0] v4l2 demux error: device does not support mmap i/o > [0x1270260] v4l2 access error: device

Re: em28xx: board id [eb1a:2863 eMPIA Technology, Inc] Silver Crest VG2000 "USB 2.0 Video Grabber"

2011-02-09 Thread Devin Heitmueller
On Wed, Feb 9, 2011 at 4:44 PM, Martin Seekatz wrote: > Hi Devin, > > Model: Silver Crest VG2000  "USB 2.0 Video Grabber" > Vendor/Product id: [eb1a:2863] > Driver: em28xx > > I got your points and see that this device is now fully supportet. > > Will the kernel list be updated? I'm not sure whic

Re: em28xx: board id [eb1a:2863 eMPIA Technology, Inc] Silver Crest VG2000 "USB 2.0 Video Grabber"

2011-02-09 Thread Devin Heitmueller
On Wed, Feb 9, 2011 at 5:36 PM, Martin Seekatz wrote: > Hello Devin, > > I mean that list > http://www.kernel.org/doc/Documentation/video4linux/CARDLIST.em28xx It actually is there: 29 -> EM2860/TVP5150 Reference Design If the vendor did not build the hardware with its own unique USB ID (becaus

Re: em28xx: board id [eb1a:2863 eMPIA Technology, Inc] Silver Crest VG2000 "USB 2.0 Video Grabber"

2011-02-09 Thread Devin Heitmueller
On Wed, Feb 9, 2011 at 6:06 PM, Martin Seekatz wrote: > Am Mittwoch 09 Februar 2011 schrieb Devin Heitmueller: >> On Wed, Feb 9, 2011 at 5:36 PM, Martin Seekatz > wrote: >> > Hello Devin, >> > >> > I mean that list >> > http://www.kernel.org/doc

Re: PCTV USB2 PAL / adds loud hum to correct audio

2011-02-12 Thread Devin Heitmueller
On Sat, Feb 12, 2011 at 3:22 PM, AW wrote: > Hi! > > When I try to use my new USB TV tuner on Fedora 14 (log messages: in the end) > with this: > mplayer -tv > driver=v4l2:input=0:width=768:height=576:device=/dev/video2:norm=5:chanlist=europe-west:freq=224.25 > tv:// > > I hear nothing, but I c g

Re: [corrected get-bisect results]: DViCO FusionHDTV7 Dual Express I2C write failed

2011-02-13 Thread Devin Heitmueller
On Sun, Feb 13, 2011 at 9:47 AM, Mark Zimmerman wrote: > Clearly my previous bisection went astray; I think I have a more > sensible result this time. > > qpc$ git bisect good > 44835f197bf1e3f57464f23dfb239fef06cf89be is the first bad commit > commit 44835f197bf1e3f57464f23dfb239fef06cf89be > Aut

Re: [corrected get-bisect results]: DViCO FusionHDTV7 Dual Express I2C write failed

2011-02-14 Thread Devin Heitmueller
On Sun, Feb 13, 2011 at 7:16 PM, Andy Walls wrote: > Devin, > > I just checked.  The CX23885 driver *is* setting up to allow slaves to > stretch the clock. > > By analysis, I have confirmed that Jean's sugguested patch that I moved > forward was wrong for the hardware's behavior.  When the cx23885

Re: IR for remote control not working for Hauppauge WinTV-HVR-1150 (SAA7134)

2011-02-16 Thread Devin Heitmueller
On Tue, Feb 15, 2011 at 5:18 PM, Jarod Wilson wrote: > On Tue, Feb 15, 2011 at 05:04:33PM -0500, Jarod Wilson wrote: >> First off, video4linux-list is dead, you want linux-media (added to cc). >> >> On Tue, Feb 15, 2011 at 06:27:29PM -0200, Fernando Laudares Camargos wrote: >> > Hello, >> > >> > I

Re: IR for remote control not working for Hauppauge WinTV-HVR-1150 (SAA7134)

2011-02-16 Thread Devin Heitmueller
On Wed, Feb 16, 2011 at 11:54 AM, Fernando Laudares Camargos wrote: > Thanks, Jarod, for re-directing the message and explaining why the fix > from Mauro's wouldn't suffice here. > > Devin: I was hoping they (Hauppauge) had used the same componentry as > of the predecessor board (HVR-1120) for the

Re: utv 330 : gadmei USB 2860 Device : No Audio

2011-02-20 Thread Devin Heitmueller
Hello Pranjal, On Sun, Feb 20, 2011 at 10:13 AM, Pranjal Pandey wrote: > I am trying to use UTV 330 tv tuner card to watch tv on my laptop. I > am using Ubuntu 10.10 with 2.6.35 kernel. To play the tv i use > > tvtime -d /dev/video1 > > Tvtime plays the video properly but there is no audio. > > T

Re: PCTV nanoStick T2 in stock - Driver work?

2011-02-23 Thread Devin Heitmueller
On Wed, Feb 23, 2011 at 11:49 AM, Nicolas Will wrote: > Hello > > The DVB-T2 USB stick appears to be in stock in the UK. > > Product page: > http://www.pctvsystems.com/Products/ProductsEuropeAsia/Digitalproducts/PCTVnanoStickT2/tabid/248/language/en-GB/Default.aspx > > Play.com, Dabs and Amzon.co.

Re: PCTV nanoStick T2 in stock - Driver work?

2011-02-23 Thread Devin Heitmueller
On Wed, Feb 23, 2011 at 12:45 PM, Steve Kerrison wrote: > That would be me :) > > I have indeed, but don't have much to speak of seeing as when I started > I'd never touched Linux kernel-space driver development. > > At the moment I have hardware and usb data from myself and others. I'm > hoping t

Re: Hauppauge WinTV USB 2

2011-02-23 Thread Devin Heitmueller
On Wed, Feb 23, 2011 at 2:46 PM, Vivek Periaraj wrote: > Hi Folks, > > I bought a new Hauppauge WinTV USB 2 tuner card and was hoping to use it in > linux. I specifically looked up to find whether this card is supported or not, > and I found that it's indeed supported by em28xx drivers. The produ

Question on V4L2 S_STD call

2011-02-23 Thread Devin Heitmueller
Hello there, I was debugging some PAL issues with cx231xx, and noticed some unexpected behavior with regards to selecting PAL standards. In particular, tvtime has an option for PAL which corresponds to the underlying value "0xff". This basically selects *any* PAL standard. However, the cx231xx h

Re: Hauppauge WinTV USB 2

2011-02-23 Thread Devin Heitmueller
On Wed, Feb 23, 2011 at 4:25 PM, Vivek Periaraj wrote: > Hi Devin, > > Thanks for the reply! > > Like you advised, I took the latest code and started building it as mentioned > in this link --> http://linuxtv.org/wiki/index.php/Trident_TM6000 but getting > this error: > > /mnt/share1/Debian/Hauppa

Re: Question on V4L2 S_STD call

2011-02-23 Thread Devin Heitmueller
On Wed, Feb 23, 2011 at 4:53 PM, Andy Walls wrote: > "When the standard set is ambiguous drivers may return EINVAL or choose > any of the requested standards." Returning -EINVAL is really not desired behavior. > If you don't have standard autodetection before the DIF, your > safest bet is to hav

Re: Question on V4L2 S_STD call

2011-02-23 Thread Devin Heitmueller
On Wed, Feb 23, 2011 at 5:29 PM, Mauro Carvalho Chehab wrote: > Not all PAL standards. "Only" the european PAL standards (B/G/D/K/I/H): Correct. > PAL/M, PAL/N, PAL/Nc and PAL/60 are not part of it. This is the equivalent > of the V4L1 definition for PAL (on V4L1, there was just PAL/NSTC/SECAM,

Re: IR for remote control not working for Hauppauge WinTV-HVR-1150 (SAA7134)

2011-03-03 Thread Devin Heitmueller
On Thu, Mar 3, 2011 at 8:51 AM, Fernando Laudares Camargos wrote: > Of course, it did not worked since the device is probably not a i2c > remote as was HVR-1110. That makes me wondering what have changed at > the IR level from the HVR-1110 to 1120 and then to 1150 and if the > remote control is wo

Re: em28xx: dvb lock bug on re-plug of device?

2011-03-03 Thread Devin Heitmueller
On Thu, Mar 3, 2011 at 11:01 AM, Steve Kerrison wrote: > Hi all, > > I wonder if Devin/Mauro could help me with something as I've run into a > problem developing a driver for the PCTV 290e? > > First plug of the device works fine, em28xx and em28xx_dvb are loaded. > However, if I disconnect and th

Re: BUG at mm/mmap.c:2309 when cx18.ko and cx18-alsa.ko loaded

2011-03-04 Thread Devin Heitmueller
On Thu, Mar 3, 2011 at 9:06 PM, Andy Walls wrote: > Hi, > > I got a BUG when loading the cx18.ko module (which in turn requests the > cx18-alsa.ko module) on a kernel built from this repository > >        http://git.linuxtv.org/media_tree.git staging/for_v2.6.39 > > which I beleive is based on 2.6

Re: mygica hdcap

2011-03-10 Thread Devin Heitmueller
On Thu, Mar 10, 2011 at 3:30 PM, Jarod Wilson wrote: > It looks like an at least semi-similar device to the Hauppauge HD-PVR, > which is under v4l, so it probably does make sense here. Not aware of > anyone working on your specific hardware, but Hans Verkuil posted some > patches for some at least

Re: WinTV 1400 broken with recent versions?

2011-03-11 Thread Devin Heitmueller
On Fri, Mar 11, 2011 at 6:04 PM, wrote: > > Hey, > > i tried to revert that patch manually (e.g. switching into the directory, > vim cx23885-i2c.c, removing the stuff which was added), then "make clean" > "make distclean" followed by "./build.sh" then make rmmod, then plugged in > the card, dmesg

Re: WinTV 1400 broken with recent versions?

2011-03-11 Thread Devin Heitmueller
On Fri, Mar 11, 2011 at 6:30 PM, wrote: > >> Doesn't seem weird to me at all.  This is a pretty uncommon card, so >> it is entirely possible that many revisions could go by without >> someone noticing a regression.  I know for example that the HVR-1500Q >> (the US version of that board) was broke

  1   2   3   4   5   6   7   8   9   10   >