RE: [PATCH 2/6] si4713 : Modified i2c driver to handle cases where interrupts are not used

2013-09-02 Thread Dinesh Ram
have the hardware anymore. Regards, Dinesh From: Hans Verkuil [hverk...@xs4all.nl] Sent: 02 September 2013 09:11 To: edubez...@gmail.com Cc: Dinesh Ram; Linux-Media; Dinesh Ram Subject: Re: [PATCH 2/6] si4713 : Modified i2c driver to handle cases where

RE: [PATCH 2/6] si4713 : Modified i2c driver to handle cases where interrupts are not used

2013-09-30 Thread Dinesh Ram
Ram Cc: edubez...@gmail.com; Linux-Media Subject: Re: [PATCH 2/6] si4713 : Modified i2c driver to handle cases where interrupts are not used On 09/02/2013 12:29 PM, Dinesh Ram wrote: Hi Hans and Eduardo, Sorry for my radio silence. I was infact travelling and didn't have much opportunity

[REVIEW PATCH 3/9] si4713 : Reorganized includes in si4713.c/h

2013-10-15 Thread Dinesh Ram
Moved the header linux/regulator/consumer.h from si4713.c to si4713.h Signed-off-by: Dinesh Ram dinesh@cern.ch --- drivers/media/radio/si4713/si4713.c |1 - drivers/media/radio/si4713/si4713.h |1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/radio

[REVIEW PATCH 8/9] si4713: move supply list to si4713_platform_data

2013-10-15 Thread Dinesh Ram
The supply list is needed by the platform driver, but not by the usb driver. So this information belongs to the platform data and should not be hardcoded in the subdevice driver. Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- arch/arm/mach-omap2/board-rx51-peripherals.c |7

[REVIEW PATCH 9/9] si4713: si4713_set_rds_radio_text overwrites terminating \0

2013-10-15 Thread Dinesh Ram
si4713_set_rds_radio_text will overwrite the terminating zero at the end of the rds radio text string in order to send out a carriage return as per the RDS spec. Use a separate char buffer for the CR instead of corrupting the control string. Signed-off-by: Hans Verkuil hans.verk...@cisco.com ---

[REVIEW PATCH 2/9] si4713 : Modified i2c driver to handle cases where interrupts are not used

2013-10-15 Thread Dinesh Ram
Checks have been introduced at several places in the code to test if an interrupt is set or not. For devices which do not use the interrupt, to get a valid response, within a specified timeout, the device is polled instead. Signed-off-by: Dinesh Ram dinesh@cern.ch --- drivers/media/radio

[Review Patch 0/9] si4713 usb device driver

2013-10-15 Thread Dinesh Ram
loads again. Let me know when you are able to test it again. Kind regards, Dinesh Ram dinesh@cern.ch dinesh.ram...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

[REVIEW PATCH 7/9] si4713 : Added MAINTAINERS entry for radio-usb-si4713 driver

2013-10-15 Thread Dinesh Ram
Hans Verkuil hverk...@xs4all.nl will maintain the USB driver for si4713 Signed-off-by: Dinesh Ram dinesh@cern.ch --- MAINTAINERS | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 72b1e5c..1ed7363 100644 --- a/MAINTAINERS +++ b

[REVIEW PATCH 5/9] si4713 : HID blacklist Si4713 USB development board

2013-10-15 Thread Dinesh Ram
as an HID device and hence loads the custom driver. Signed-off-by: Dinesh Ram dinesh@cern.ch Signed-off-by: Jiri Kosina jkos...@suse.cz Acked-by: Jiri Kosina jkos...@suse.cz --- drivers/hid/hid-core.c |1 + drivers/hid/hid-ids.h |2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers

[REVIEW PATCH 6/9] si4713 : Added the USB driver for Si4713

2013-10-15 Thread Dinesh Ram
This is the USB driver for the Silicon Labs development board. It contains the Si4713 FM transmitter chip. Signed-off-by: Dinesh Ram dinesh@cern.ch --- drivers/media/radio/si4713/Kconfig| 15 + drivers/media/radio/si4713/Makefile |1 + drivers/media/radio/si4713

[REVIEW PATCH 4/9] si4713 : Bug fix for si4713_tx_tune_power() method in the i2c driver

2013-10-15 Thread Dinesh Ram
In the si4713_tx_tune_power() method, the args array element 'power' can take values between SI4713_MIN_POWER and SI4713_MAX_POWER. power = 0 is also valid. All the values (0 power SI4713_MIN_POWER) are illegal and hence are all mapped to SI4713_MIN_POWER. Signed-off-by: Dinesh Ram dinesh

FW: [REVIEW PATCH 1/9] si4713 : Reorganized drivers/media/radio directory

2013-12-03 Thread Dinesh Ram
Mail to the mailing list from my gmail id bounce back. Trying with this ID. From: d ram [dinesh.ram...@gmail.com] Sent: 03 December 2013 16:57 To: Mauro Carvalho Chehab Cc: Dinesh Ram; Linux-Media; Hans Verkuil; Eduardo Valentin Subject: Re: [REVIEW PATCH 1/9] si4713 : Reorganized drivers/media

[RFC PATCH 3/5] si4713 : Bug fix for si4713_tx_tune_power() method in the i2c driver

2013-08-21 Thread Dinesh Ram
In the si4713_tx_tune_power() method, the args array element 'power' can take values between SI4713_MIN_POWER and SI4713_MAX_POWER. power = 0 is also valid. All the values (0 power SI4713_MIN_POWER) are illegal and hence are all mapped to SI4713_MIN_POWER. Signed-off-by: Dinesh Ram din

[RFC PATCH 5/5] si4713 : Added the USB driver for Si4713

2013-08-21 Thread Dinesh Ram
This is the USB driver for the Silicon Labs development board. It contains the Si4713 FM transmitter chip. Signed-off-by: Dinesh Ram din...@cisco.com --- drivers/media/radio/si4713/Kconfig| 15 + drivers/media/radio/si4713/Makefile | 1 + drivers/media/radio/si4713/radio

[RFC PATCH 2/5] si4713 : Modified i2c driver to handle cases where interrupts are not used

2013-08-21 Thread Dinesh Ram
Checks have been introduced at several places in the code to test if an interrupt is set or not. For devices which do not use the interrupt, to get a valid response, within a specified timeout, the device is polled instead. Signed-off-by: Dinesh Ram din...@cisco.com --- drivers/media/radio

[RFC PATCH 4/5] si4713 : HID blacklist Si4713 USB development board

2013-08-21 Thread Dinesh Ram
as an HID device and hence loads the custom driver. Signed-off-by: Dinesh Ram din...@cisco.com --- drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 36668d1..109510f 100644 --- a/drivers/hid

[PATCH 4/6] si4713 : HID blacklist Si4713 USB development board

2013-08-30 Thread Dinesh Ram
as an HID device and hence loads the custom driver. Signed-off-by: Dinesh Ram din...@cisco.com Cc: Jiri Kosina jkos...@suse.cz Cc: linux-in...@vger.kernel.org --- drivers/hid/hid-core.c | 1 + drivers/hid/hid-ids.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/hid/hid-core.c b

[PATCH 2/6] si4713 : Modified i2c driver to handle cases where interrupts are not used

2013-08-30 Thread Dinesh Ram
Checks have been introduced at several places in the code to test if an interrupt is set or not. For devices which do not use the interrupt, to get a valid response, within a specified timeout, the device is polled instead. Signed-off-by: Dinesh Ram din...@cisco.com --- drivers/media/radio

[PATCH 0/6] si4713 : USB driver

2013-08-30 Thread Dinesh Ram
This is a follow-up to the patch-series mailed on 21-Agu-2013 to the mailing list. Please note that I will not be reachable at the cisco email id anymore. So please send you comments and suggestions to my private email : dinesh@cern.ch All the patches are on top of the latest version of

[PATCH 3/6] si4713 : Bug fix for si4713_tx_tune_power() method in the i2c driver

2013-08-30 Thread Dinesh Ram
In the si4713_tx_tune_power() method, the args array element 'power' can take values between SI4713_MIN_POWER and SI4713_MAX_POWER. power = 0 is also valid. All the values (0 power SI4713_MIN_POWER) are illegal and hence are all mapped to SI4713_MIN_POWER. Signed-off-by: Dinesh Ram din

[PATCH 6/6] si4713 : Added MAINTAINERS entry for radio-usb-si4713 driver

2013-08-30 Thread Dinesh Ram
Hans Verkuil hverk...@xs4all.nl will maintain the USB driver for si4713 Signed-off-by: Dinesh Ram din...@cisco.com --- MAINTAINERS | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index b2618ce..ddd4d5f 100644 --- a/MAINTAINERS +++ b

[PATCH 5/6] si4713 : Added the USB driver for Si4713

2013-08-30 Thread Dinesh Ram
This is the USB driver for the Silicon Labs development board. It contains the Si4713 FM transmitter chip. Signed-off-by: Dinesh Ram din...@cisco.com --- drivers/media/radio/si4713/Kconfig| 15 + drivers/media/radio/si4713/Makefile | 1 + drivers/media/radio/si4713/radio

RE: [PATCH v2 6/6] si4713 : Added MAINTAINERS entry for radio-usb-si4713 driver

2013-08-30 Thread Dinesh Ram
Hans Verkuil hverk...@xs4all.nl will maintain the USB driver for si4713 Signed-off-by: Dinesh Ram din...@cisco.com --- MAINTAINERS | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index b2618ce..ddd4d5f 100644 --- a/MAINTAINERS +++ b