Re: [PATCHv2] serio: add hangup support

2016-08-03 Thread Dmitry Torokhov
On Wed, Aug 03, 2016 at 01:00:44PM +0200, Hans Verkuil wrote: > The Pulse-Eight USB CEC adapter is a usb device that shows up as a ttyACM0 > device. > It requires that you run inputattach in order to communicate with it via > serio. > > This all works well, but it would be nice to have a udev ru

Re: ERROR: "vb2_ops_wait_finish" [drivers/input/touchscreen/sur40.ko] undefined!

2015-10-18 Thread Dmitry Torokhov
On Sat, Oct 17, 2015 at 06:19:31PM -0700, Randy Dunlap wrote: > On 10/17/15 17:38, kbuild test robot wrote: > > Hi Florian, > > > > FYI, the error/warning still remains. > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > master > > head: 81429a6dbcbf3a01830d

[PATCH] android: fix warning when releasing active sync point

2015-12-14 Thread Dmitry Torokhov
lback (disable_signaling) to fence operations so that drivers can do proper clean ups when we remove last callback for given fence. Reviewed-by: Andrew Bresticker Signed-off-by: Dmitry Torokhov --- drivers/dma-buf/fence.c| 6 +- drivers/staging/android/sync.c | 8 include/

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Dmitry Torokhov
On Tue, Dec 15, 2015 at 2:01 AM, Maarten Lankhorst wrote: > Op 15-12-15 om 02:29 schreef Dmitry Torokhov: >> Userspace can close the sync device while there are still active fence >> points, in which case kernel produces the following warning: >> >> [ 43.853

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Dmitry Torokhov
On Tue, Dec 15, 2015 at 1:26 AM, Daniel Vetter wrote: > On Mon, Dec 14, 2015 at 05:29:55PM -0800, Dmitry Torokhov wrote: >> Userspace can close the sync device while there are still active fence >> points, in which case kernel produces the following warning: >> >> [ 4

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Dmitry Torokhov
On Tue, Dec 15, 2015 at 5:50 AM, Frank Binns wrote: > Is this not the issue fixed by 8e43c9c75? No because if we start teardown without waiting for the fence to be signaled it will still be on the active_list. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Dmitry Torokhov
On Tue, Dec 15, 2015 at 5:30 AM, Gustavo Padovan wrote: > 2015-12-14 Dmitry Torokhov : > >> Userspace can close the sync device while there are still active fence >> points, in which case kernel produces the following warning: >> >> [ 43.

Re: [PATCH] android: fix warning when releasing active sync point

2015-12-15 Thread Dmitry Torokhov
On Tue, Dec 15, 2015 at 11:00 AM, Gustavo Padovan wrote: > 2015-12-15 Daniel Vetter : > >> On Mon, Dec 14, 2015 at 05:29:55PM -0800, Dmitry Torokhov wrote: >> > Userspace can close the sync device while there are still active fence >> > points, in which case kernel

Re: [PATCH 5/5] kfifo: log based kfifo API

2013-01-08 Thread Dmitry Torokhov
Hi Yuanhan, On Tue, Jan 08, 2013 at 10:57:53PM +0800, Yuanhan Liu wrote: > The current kfifo API take the kfifo size as input, while it rounds > _down_ the size to power of 2 at __kfifo_alloc. This may introduce > potential issue. > > Take the code at drivers/hid/hid-logitech-dj.c as example: >

[PATCH] Media: remove incorrect __exit markups

2013-02-24 Thread Dmitry Torokhov
: Dmitry Torokhov --- drivers/media/i2c/adp1653.c | 4 ++-- drivers/media/i2c/smiapp/smiapp-core.c | 4 ++-- drivers/media/platform/soc_camera/omap1_camera.c | 4 ++-- drivers/media/radio/radio-si4713.c | 4 ++-- drivers/media/rc/ir-rx51.c

Re: [PATCH] Media: remove incorrect __exit markups

2013-02-25 Thread Dmitry Torokhov
On Mon, Feb 25, 2013 at 08:49:26AM +0100, Guennadi Liakhovetski wrote: > Hi Dmitry > > On Sun, 24 Feb 2013, Dmitry Torokhov wrote: > > > Even if bus is not hot-pluggable, the devices can be unbound from the > > driver via sysfs, so we should not be using __exit a

[PATCH v2] Media: remove incorrect __init/__exit markups

2013-02-25 Thread Dmitry Torokhov
() methods should not be marked __init unless platform_driver_probe() is used. Signed-off-by: Dmitry Torokhov --- v1->v2: removed __init markup on omap1_cam_probe() that was pointed out by Guennadi Liakhovetski. drivers/media/i2c/adp1653.c | 4 ++-- drivers/me

Re: [PATCH 2/3] Input: move drivers/input/fixp-arith.h to include/linux

2012-04-23 Thread Dmitry Torokhov
sin(HUE) and cos(HUE). > > Signed-off-by: Antonio Ospite Acked-by: Dmitry Torokhov > --- > drivers/input/ff-memless.c|3 +-- > {drivers/input => include/linux}/fixp-arith.h |0 > 2 files changed, 1 insertion(+), 2 deletions(-) > rename {

Re: [PATCH 0/3] gspca - ov534: saturation and hue (using fixp-arith.h)

2012-04-23 Thread Dmitry Torokhov
On Mon, Apr 23, 2012 at 03:21:04PM +0200, Antonio Ospite wrote: > Hi, > > here are a couple more of controls for the gspca ov534 subdriver. > > In order to control the HUE value the sensor expects sin(HUE) and > cos(HUE) to be set so I decided to reuse the fixed point implementation > of sine and

Re: [PATCH 1/5] Driver core: driver_find() drops reference before returning

2012-01-28 Thread Dmitry Torokhov
evented a driver from being unregistered or unloaded. > Hence the patch will not introduce any new bugs. The existing callers > all seem to be okay in this respect, however I don't understand the > video drivers well enough to be certain about them. > > Signed-off-by: Alan Stern > CC

Re: [PATCH v2 4/8] drivers: input: use module_platform_driver_probe()

2013-03-14 Thread Dmitry Torokhov
Hi Fabio, On Thursday, March 14, 2013 06:09:34 PM Fabio Porcedda wrote: > This patch converts the drivers to use the > module_platform_driver_probe() macro which makes the code smaller and > a bit simpler. I already have patches from Sachin Kamat for this, I am waiting for -rc3 to sync up with ma

[PATCH] pwc - fix few use-after-free and memory leaks

2009-08-13 Thread Dmitry Torokhov
Hi Mauro, I just happen to peek inside the PWC driver and did not like what I saw there. Please consider applying the patch below. Thanks! -- Dmitry V4L/DVB: pwc - fix few use-after-free and memory leaks From: Dmitry Torokhov It is not allowed to call input_free_device() after

Re: [RFC] Infrared Keycode standardization

2009-08-27 Thread Dmitry Torokhov
On Thu, Aug 27, 2009 at 09:36:36PM +0300, Ville Syrjälä wrote: > On Thu, Aug 27, 2009 at 04:57:10AM -0300, Mauro Carvalho Chehab wrote: > > After years of analyzing the existing code and receiving/merging patches > > related to IR, and taking a looking at the current scenario, it is clear to > > m

Re: [RFC] Infrared Keycode standardization

2009-08-27 Thread Dmitry Torokhov
On Thu, Aug 27, 2009 at 06:06:13PM +0100, Peter Brouwer wrote: > Mauro Carvalho Chehab wrote: > > Hi Mauro, All > > Would it be an alternative to let lirc do the mapping and just let the > driver pass the codes of the remote to the event port. I don't think that blindly passing IR codes through i

Re: [RFC] Infrared Keycode standardization

2009-08-31 Thread Dmitry Torokhov
Mauro, On Mon, Aug 31, 2009 at 02:47:41AM -0300, Mauro Carvalho Chehab wrote: > Em Sat, 29 Aug 2009 15:45:28 -0300 > Mauro Carvalho Chehab escreveu: > > > Ok, I've did several changes on both V4L and dvb-usb IR implementations. > > They > > scancode tables are now implemented at the same way, a

[PATCH] DVB/V4L: ov511 - export snapshot button through input layer

2009-09-03 Thread Dmitry Torokhov
: Dmitry Torokhov --- Mauro, This is something that's been sitting in my queue for quite some time, please consider applying. Thanks! drivers/media/video/Kconfig |8 +++ drivers/media/video/ov511.c | 109 +++ drivers/media/video/ov511.h |8 +

Re: [PATCH] DVB/V4L: ov511 - export snapshot button through input layer

2009-09-04 Thread Dmitry Torokhov
On Friday 04 September 2009 01:37:46 am Laurent Pinchart wrote: > > + usb_make_path(udev, ov->key_phys, OV511_KEY_PHYS_SIZE); > > + strlcat(ov->key_phys, "/input0", OV511_KEY_PHYS_SIZE); > > What about sizeof(ov->key_phys) instead of OV511_KEY_PHYS_SIZE ? I don't really have preference.

Re: [PATCH] input:keyboard: "keycode & KEY_MAX" changes some keycode value.

2013-11-23 Thread Dmitry Torokhov
Hi Andrew, On Sat, Nov 23, 2013 at 09:45:45PM +0800, andrew.liu200...@gmail.com wrote: > From: Andrew Liu > > For exmaple, keycode: KEY_OK(0x160) is changed by "and" operation with > KEY_MAX(0x2ff) to KEY_KPENTER(96). > > Signed-off-by: Andrew Liu > --- > drivers/input/keyboard/adp5588-keys.c

Re: [PATCH 1/3] fixp-arith: replace sin/cos table by a better precision one

2015-02-04 Thread Dmitry Torokhov
the > usage inside ff-memless.c. Move those logic to there, as they're > not needed elsewhere. > > Cc: Hans de Goede > Cc: Dmitry Torokhov > Cc: linux-in...@vger.kernel.org > Signed-off-by: Mauro Carvalho Chehab > Signed-off-by: Prashant Laddha > Signed-off-by:

[PATCH] [media] exynos4-is: fix error handling of irq_of_parse_and_map

2014-11-14 Thread Dmitry Torokhov
Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Signed-off-by: Dmitry Torokhov --- Not tested, found by casual code inspection. drivers/media/platform/exynos4-is/fimc-is.c | 4 ++-- 1 file changed, 2 insertions

Re: input_polldev interval (was Re: [sur40] Debugging a race condition)?

2015-03-25 Thread Dmitry Torokhov
On March 24, 2015 11:52:54 PM PDT, Florian Echtler wrote: >Sorry for the continued noise, but this bug/crash is proving quite >difficult to nail down. > >Currently, I'm setting the interval for input_polldev to 10 ms. >However, with video data being retrieved at the same time, it's quite >possible

<    1   2   3