Re: em28xx: idVendor=eb1a, idProduct=e301
Hi, port20031 wrote: Hi, I've made tests with my board: Model: Kaiomy TVnPC U2 http://www.kaiomy.com/products_feat.aspx?id=56 idVendor=eb1a, idProduct=e301 uname -r 2.6.35.12-88.fc14.i686.PAE What happened? You can share the dmesg as well. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[ANNOUNCE] mercurial backport tree is needing a new maintainer
Hello, I am just writing to officially say that I cannot maintain the hg backport tree anymore. Sorry for this, I *really* tried to help here, but, since I know some people still like to use it I prefer write this email. Unfortunately due my current activities I cannot give attention which this task requires. Also, if I could say something here for the next person which will take care about it. - Doing backport manually from 200 to 400 backports doesn't work - Making a script to do it, also not good approach since it will break because of our macros. The best opition here to my eyes, is tar the current -git tree and make a directory with the backports (Mauro's new build system). This will save a lot of time: - no need to backport the current patches coming - will keep the tree updated - Minize the backport job. I will keep around, helping the group with what I can. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
hg slow commit
Hello everyone, Most of you should asking yourself why the hg commit are very slow. Unfortunately, I had a business trip (out of my country) in the last 3 weeks. Now, I am back and I will restart the commits and read all my emails. If you guys want to help me or have free time to do this, please let me know. Sorry for the inconvenient. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH -hg] Warn user that driver is backported and might not work as expected
Hi, Mauro Carvalho Chehab wrote: Since the migration to -git, less developers are using the -hg tree. Also, some changes are happening upstream that would require much more than just compiling the tree with an older version, to be sure that the backport won't break anything, like the removal of BKL. As normal users might not be aware of those issues, and bug reports may be sent based on a backported tree, add some messages to warn about the usage of a backported experimental (unsupported) tree. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com Applied, thanks! Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH -hg] Warn user that driver is backported and might not work as expected
Hi, David Ellingsworth wrote: snip --- a/v4l/scripts/make_kconfig.pl Sun Jun 27 17:17:06 2010 -0300 +++ b/v4l/scripts/make_kconfig.pl Fri Sep 17 11:49:02 2010 -0300 @@ -671,4 +671,13 @@ EOF2 } +print EOF3; +WARNING: This is the V4L/DVB backport tree, with experimental drivers +backported to run on legacy kernels from the development tree at: + http://git.linuxtv.org/media-tree.git. +It is generally safe to use it for testing a new driver or +feature, but its usage on production environments is risky. +Don't use it at production. You've being warned. The last line should read: Don't use it in production. You've been warned. Fixed thanks! Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH/RFC v2 0/8] dsbr100: driver cleanup and fixes
Hi David, On Tue, Sep 14, 2010 at 11:56 AM, David Ellingsworth da...@identd.dyndns.org wrote: Alexey, Can you review/test this patch series? Patches 2/8, 3/8, and 5/8 are bug fixes the rest are mainly cleanups. Patch 2/8 should fix a crash in the normal case if the device is disconnected while not in use. I will also check your patches soon. I have this old hardware at home. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: HG has errors on kernel 2.6.32
Hi Jan, On Thu, Aug 26, 2010 at 4:54 PM, Jan Hoogenraad jan-conceptro...@hoogenraad.net wrote: Douglas: I see on that http://www.xs4all.nl/~hverkuil/logs/Thursday.log that building linux-2.6.32 yields ERRORS skip_spaces has only been included in string.h starting from linux-2.6.33. Should I have a look on how to fix this, or do you want to do this ? It's up to you. I can fix it, easily. -- second request: can we do some small changes to avoid the compiler warnings ? I will check on the git tree which patch touch on this and commit it. As backport tree, I cannot commit anything besides on existing source of git tree. Thanks Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Failure of v4l-dvb daily build against kernel 2.6.28 and others
Hello Jan, On Wed, Aug 25, 2010 at 8:11 AM, Jan Hoogenraad jan-conceptro...@hoogenraad.net wrote: Douglas: I now see that some more versions have several build errors and/or warnings. Could you, in the process of backporting, try to reduce this as well ? Actually, the fixes from yesterday should improve this. Thanks Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: V4L hg tree fails to compile against kernel 2.6.28
Hello Jan, On Wed, Aug 25, 2010 at 3:26 AM, Jan Hoogenraad jan-conceptro...@hoogenraad.net wrote: Thanks for your help. I pulled the code Actually, now the function definition in compat.h causes a compilation error: see first text below. I fixed that by inserting #include linux/err.h at line 38 in compat.h in my local branch After that, compilation succeeds. Thanks, applied. Now, the device will not install, as dvb_usb cannot install anymore. see second text below. Therefore, I have replaced the __kmalloc_track_caller with kmalloc (as it was in dvb_demux.c before the change 2ceef3d75547 at line 49 can you make both changes in the hg branch ? This one won't be required because the idea is support until kernel 2.6.26. Please check my next email about hg x announcement. Thanks for checking it, your help is appreciate. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[ANOUNCE] removal of backport for versions older than 2.6.26
Hello folks, I would like to share that I will just keep the maintain of compatibility of hg from 2.6.26 until lastest upstream kernel. I am writing this because we have errors from IR to lowest kernels from a lot of time and just 1 person pinged me about it which also claims that he is moving to new versions. So, if you are looking for a backport until 2.6.26 I can help. Otherwise, I will work on keeping hg synced with git, backporting and continuing helping on drivers at upstream. I have selected 2.6.26 because between all free distros available out there the lowest kernel used is 2.6.26. Finally, the next cut for backport version can happen probably based on 2.6.32 since most of free distros will be using kernel = 2.6.32. If someone, would like to maintain a backport tree to 2.6.26 fell free to contact me/send patches or contact Mauro. This increased can keep occurring (not frequently) but of course according with kernel evolution. Hans, could you please adjust your emails scripts? Thanks Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: V4L hg tree fails to compile against kernel 2.6.28
Hello Jan, On Tue, Aug 24, 2010 at 5:04 PM, Jan Hoogenraad jan-conceptro...@hoogenraad.net wrote: Douglas: On compiling with Linux 2.6.28-19-generic #62-Ubuntu I now get: dvb_demux.c: In function 'dvbdmx_write': dvb_demux.c:1137: error: implicit declaration of function 'memdup_user' dvb_demux.c:1137: warning: assignment makes pointer from integer without a cast This is probably due to changeset 2ceef3d75547 which introduced the use of this function: http://linuxtv.org/hg/v4l-dvb/diff/2ceef3d75547/linux/drivers/media/dvb/dvb-core/dvb_demux.c This function is not available in linux/string.h in kernel 2.6.29 and lower. http://lxr.free-electrons.com/source/include/linux/string.h?v=2.6.28 Could you please advise me on what to do ? For this issue, I have fixed right now, please try again with a updated repository. But since I have commited several patches yesterday, we have another one that probably will reach your compilantion (the kfifo one). I will work to fix this one too. Thanks for the report. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: V4L hg tree fails to compile against kernel 2.6.28
Hi, On Tue, Aug 24, 2010 at 11:45 PM, Douglas Schilling Landgraf dougsl...@gmail.com wrote: Hello Jan, On Tue, Aug 24, 2010 at 5:04 PM, Jan Hoogenraad jan-conceptro...@hoogenraad.net wrote: Douglas: On compiling with Linux 2.6.28-19-generic #62-Ubuntu I now get: dvb_demux.c: In function 'dvbdmx_write': dvb_demux.c:1137: error: implicit declaration of function 'memdup_user' dvb_demux.c:1137: warning: assignment makes pointer from integer without a cast This is probably due to changeset 2ceef3d75547 which introduced the use of this function: http://linuxtv.org/hg/v4l-dvb/diff/2ceef3d75547/linux/drivers/media/dvb/dvb-core/dvb_demux.c This function is not available in linux/string.h in kernel 2.6.29 and lower. http://lxr.free-electrons.com/source/include/linux/string.h?v=2.6.28 Could you please advise me on what to do ? For this issue, I have fixed right now, please try again with a updated repository. But since I have commited several patches yesterday, we have another one that probably will reach your compilantion (the kfifo one). I will work to fix this one too. Thanks for the report. Ok, should be working right now, I have made the backports needed/adjusts to compile agains 2.6.29. Let me know if you have any problem. Tomorrow I will continue commiting patches to get hg synced with git. Thanks Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: V4L hg tree fails to compile against latest stable kernel 2.6.35
Hello Derek, On Sun, Aug 15, 2010 at 2:22 AM, Douglas Schilling Landgraf dougsl...@gmail.com wrote: Hello Derek, On Sat, Aug 14, 2010 at 12:46 PM, VDR User user@gmail.com wrote: On Wed, Aug 4, 2010 at 10:19 PM, Douglas Schilling Landgraf dougsl...@gmail.com wrote: I am already working to give a full update to hg tree. Sorry this problem. Hi Douglas. Any estimate when this will be fixed? Was hoping it was already since new stable kernel 2.6.35.2 is out now but still the same problem when I tried just now. I am already working on it this weekend. I will reply this thread when finished. 2.6.35 should be working, let me know if not. Now, I need to backport the changes to old kernels and commit other patches in my pending list. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Error building v4l
Hello, On Sat, Aug 14, 2010 at 3:34 AM, andrea.amoros...@gmail.com andrea.amoros...@gmail.com wrote: Building the v4l, I obtain the following error: home/andreak/src/v4l-dvb-src/v4l-dvb-main/v4l-dvb/v4l/mceusb.c: In function 'mceusb_dev_probe': /home/andreak/src/v4l-dvb-src/v4l-dvb-main/v4l-dvb/v4l/mceusb.c:923: error: implicit declaration of function 'usb_alloc_coherent' /home/andreak/src/v4l-dvb-src/v4l-dvb-main/v4l-dvb/v4l/mceusb.c:923: warning: assignment makes pointer from integer without a cast /home/andreak/src/v4l-dvb-src/v4l-dvb-main/v4l-dvb/v4l/mceusb.c:1003: error: implicit declaration of function 'usb_free_coherent' make[3]: *** [/home/andreak/src/v4l-dvb-src/v4l-dvb-main/v4l-dvb/v4l/mceusb.o] Error 1 make[2]: *** [_module_/home/andreak/src/v4l-dvb-src/v4l-dvb-main/v4l-dvb/v4l] Error 2 make[2]: Leaving directory `/usr/src/linux-headers-2.6.32-24-generic' make[1]: *** [default] Errore 2 make[1]: uscita dalla directory «/home/andreak/src/v4l-dvb-src/v4l-dvb-main/v4l-dvb/v4l» make: *** [all] Errore 2 My system is a Kubuntu 10.04 amd64 with kernel 2.6.32-24-generic #39-Ubuntu SMP Wed Jul 28 05:14:15 UTC 2010 x86_64 GNU/Linux How can I solve? Please download the new patches available and try again. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: V4L hg tree fails to compile against latest stable kernel 2.6.35
Hello Derek, On Sat, Aug 14, 2010 at 12:46 PM, VDR User user@gmail.com wrote: On Wed, Aug 4, 2010 at 10:19 PM, Douglas Schilling Landgraf dougsl...@gmail.com wrote: I am already working to give a full update to hg tree. Sorry this problem. Hi Douglas. Any estimate when this will be fixed? Was hoping it was already since new stable kernel 2.6.35.2 is out now but still the same problem when I tried just now. I am already working on it this weekend. I will reply this thread when finished. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: 2.6.35 and current v4l-dvb - error: implicit declaration of function 'usb_buffer_free'
Hello, 2010/8/13 Igor M. Liplianin liplia...@me.by: В сообщении от 13 августа 2010 05:19:49 автор Douglas Schilling Landgraf написал: Hello, 2010/8/11 Goga777 goga...@bk.ru: Hi I can't compile current v4l-dvb with new 2.6.35 kernel arvdr:/usr/src/v4l-dvb# make make -C /usr/src/v4l-dvb/v4l make[1]: Entering directory `/usr/src/v4l-dvb/v4l' creating symbolic links... make -C firmware prep make[2]: Entering directory `/usr/src/v4l-dvb/v4l/firmware' make[2]: Leaving directory `/usr/src/v4l-dvb/v4l/firmware' make -C firmware make[2]: Entering directory `/usr/src/v4l-dvb/v4l/firmware' make[2]: Nothing to be done for `default'. make[2]: Leaving directory `/usr/src/v4l-dvb/v4l/firmware' Kernel build directory is /lib/modules/2.6.35-tux/build make -C /lib/modules/2.6.35-tux/build SUBDIRS=/usr/src/v4l-dvb/v4l modules make[2]: Entering directory `/usr/src/linux-2.6.35' CC [M] /usr/src/v4l-dvb/v4l/au0828-video.o /usr/src/v4l-dvb/v4l/au0828-video.c: In function 'au0828_uninit_isoc': /usr/src/v4l-dvb/v4l/au0828-video.c:185: error: implicit declaration of function 'usb_buffer_free' /usr/src/v4l-dvb/v4l/au0828-video.c: In function 'au0828_init_isoc': /usr/src/v4l-dvb/v4l/au0828-video.c:255: error: implicit declaration of function 'usb_buffer_alloc' /usr/src/v4l-dvb/v4l/au0828-video.c:256: warning: assignment makes pointer from integer without a cast make[3]: *** [/usr/src/v4l-dvb/v4l/au0828-video.o] Ошибка 1 make[2]: *** [_module_/usr/src/v4l-dvb/v4l] Error 2 make[2]: Leaving directory `/usr/src/linux-2.6.35' make[1]: *** [default] Ошибка 2 make[1]: Leaving directory `/usr/src/v4l-dvb/v4l' make: *** [all] Ошибка 2 Both functions were renamed in upstream, backport created and commited, please try again. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Is it better other way round, to rename all appearances of functions and define a macro? Like this: #if LINUX_VERSION_CODE KERNEL_VERSION(2,6,35) #define usb_alloc_coherent(a, b, c, d) usb_buffer_alloc(a, b, c, d) #define usb_free_coherent(a, b, c, d) usb_buffer_free(a, b, c, d) #endif In the end it will be more similar in code to the last kernel :) Yes, agreed but all drivers must be renamed with the new function name first. Otherwise, it will keep breaking. Thanks for looking it. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: 2.6.35 and current v4l-dvb - error: implicit declaration of function 'usb_buffer_free'
Hello, 2010/8/11 Goga777 goga...@bk.ru: Hi I can't compile current v4l-dvb with new 2.6.35 kernel arvdr:/usr/src/v4l-dvb# make make -C /usr/src/v4l-dvb/v4l make[1]: Entering directory `/usr/src/v4l-dvb/v4l' creating symbolic links... make -C firmware prep make[2]: Entering directory `/usr/src/v4l-dvb/v4l/firmware' make[2]: Leaving directory `/usr/src/v4l-dvb/v4l/firmware' make -C firmware make[2]: Entering directory `/usr/src/v4l-dvb/v4l/firmware' make[2]: Nothing to be done for `default'. make[2]: Leaving directory `/usr/src/v4l-dvb/v4l/firmware' Kernel build directory is /lib/modules/2.6.35-tux/build make -C /lib/modules/2.6.35-tux/build SUBDIRS=/usr/src/v4l-dvb/v4l modules make[2]: Entering directory `/usr/src/linux-2.6.35' CC [M] /usr/src/v4l-dvb/v4l/au0828-video.o /usr/src/v4l-dvb/v4l/au0828-video.c: In function 'au0828_uninit_isoc': /usr/src/v4l-dvb/v4l/au0828-video.c:185: error: implicit declaration of function 'usb_buffer_free' /usr/src/v4l-dvb/v4l/au0828-video.c: In function 'au0828_init_isoc': /usr/src/v4l-dvb/v4l/au0828-video.c:255: error: implicit declaration of function 'usb_buffer_alloc' /usr/src/v4l-dvb/v4l/au0828-video.c:256: warning: assignment makes pointer from integer without a cast make[3]: *** [/usr/src/v4l-dvb/v4l/au0828-video.o] Ошибка 1 make[2]: *** [_module_/usr/src/v4l-dvb/v4l] Error 2 make[2]: Leaving directory `/usr/src/linux-2.6.35' make[1]: *** [default] Ошибка 2 make[1]: Leaving directory `/usr/src/v4l-dvb/v4l' make: *** [all] Ошибка 2 Both functions were renamed in upstream, backport created and commited, please try again. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: V4L hg tree fails to compile against latest stable kernel 2.6.35
Hello Derek, On Tue, Aug 3, 2010 at 10:37 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 03-08-2010 03:44, VDR User escreveu: On Mon, Aug 2, 2010 at 11:36 PM, VDR User user@gmail.com wrote: Any idea when this will be fixed? It is up to Douglas to do the backport, but you can just use the latest git tree, where those patches are applied already at 2.6.35, at the branch staging/v2.6.36. I am already working to give a full update to hg tree. Sorry this problem. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: em28xx/xc3028 - kernel driver vs. Markus Rechberger's driver
Hello, On Fri, Jul 2, 2010 at 10:47 AM, Torsten Krah tk...@fachschaft.imn.htwk-leipzig.de wrote: Am Freitag, 2. Juli 2010, um 02:59:57 schrieb Douglas Schilling Landgraf: humm, not really :-/ Are you sure em28xx/device get loaded when your device is plugged? A good test: - unplug your device - dmesg -c (clear the dmesg) - plug your device - check your dmesg, see if there is any error or message and please send to us the output. - lsmod could help also. - if it's ok, load the i2c modules The em28xx device gets not loaded because the usb id has changed and e1ba:2871 is not associated to the em28xx-cards. the usb id is wrong like i mentioned before - that may be the cause. I provide you with dmesg later on. Maybe i need the patch Thorsten did too, to patch the em28xx-cards.c to get the new wrong usb id regognized as a em28xx device so that i can reflash the eeprom of the device. I might give this a try later this day. Please try it, should be the root cause. @Thorsten: Did you reflash the device eeprom with your patched em28xx driver or without the patch? What's the message of rewirte_eeprom.pl? The same as Throsten? No, all ok.My distribution is lacking any i2c_smbus module - can't load this one. Maybe Ubuntu does not build or 2.6.32 does not habe this one (looking through the source i did not find it yet - maybe i missed that). Well,in my tests never needed to load i2c_smbus. Let me know if you need any additional help. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [git:v4l-dvb/other] V4L/DVB: drivers/media/video/pvrusb2: Add missing mutex_unlock
Hello Mike, Mike Isely wrote: Mauro: FYI, I posted an Acked-By: Mike Isely is...@pobox.com weeks ago, back on 27-May, immediately after the patch was posted. It's a great catch, and the bug has been there since basically the beginning of the driver. Was I ever supposed to see any kind of reaction to that ack (e.g. having the Acked-By added to the patch)? I had posted it in reply to the original patch, copied back to the patch author, to lkml, to linux-media, kernel-janitors, and Mauro. -Mike It seems my mistake since I have added CC instead of Acked-by, sorry. This happened because usually I add CC to the authors of drivers when I took patches from patchwork and I wanna notify them. In your case, I missed the acked-by. Mauro, if possible, could you please replace CC to the correct Acked-by before submit this patch to Linus? Thanks Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: em28xx/xc3028 - kernel driver vs. Markus Rechberger's driver
Hi, On Wed, Jun 30, 2010 at 4:16 PM, Torsten Krah tk...@fachschaft.imn.htwk-leipzig.de wrote: Am Dienstag, 29. Juni 2010 schrieben Sie: Could you please verify if you have the module i2c-dev loaded? Yes it is. Example: #lsmod | grep i2c_dev i2c_dev 6976 0 i2c_core 21104 11 i2c_dev,lgdt330x,tuner_xc2028,tuner,tvp5150,saa7115,em28xx,v4l2_common,vide odev,tveeprom,i2c_i801 #lsmod | grep i2c i2c_dev 4970 0 i2c_algo_bit 5028 1 radeon If yes, please give us the output of: #i2cdetect -l i2c-0 smbus SMBus I801 adapter at ece0 SMBus adapter i2c-1 smbus em28xx #0 SMBus adapter ^ here my device/driver Thats the output: # i2cdetect -l i2c-0 i2c I2C adapter Basically, in your case the tool is not able to recognize your device by i2cdetect.This may happen because i2c_dev module was not able to load? Its loaded. If the module is not loaded, please load it manually and give a new try. Did that but still no success. I did right now a test with i2c-tools 3.0.0 and 3.0.2. http://dl.lm-sensors.org/i2c-tools/releases/ I am using version 3.0.2. Let us know the results. Did what you told but still no success using the tool - any other hints or things i can do? humm, not really :-/ Are you sure em28xx/device get loaded when your device is plugged? A good test: - unplug your device - dmesg -c (clear the dmesg) - plug your device - check your dmesg, see if there is any error or message and please send to us the output. - lsmod could help also. - if it's ok, load the i2c modules What's the message of rewirte_eeprom.pl? The same as Throsten? @Thorsten, in my case never needed to load modprobed i2c-smbus also. That's why rewrite_eeprom failed to you, the script is not looking to load this module. Thanks for the feedback. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: em28xx/xc3028 - kernel driver vs. Markus Rechberger's driver
Hello Torsten, On Tue, Jun 29, 2010 at 10:42 AM, Torsten Krah tk...@fachschaft.imn.htwk-leipzig.de wrote: Am Mittwoch, 23. Juni 2010, um 00:15:36 schrieb Mauro Carvalho Chehab: You probably damaged the contents of the device's eeprom. If you have the logs with the previous eeprom contents somewhere, it is possible to recover it. There's an util at v4l-utils that allows re-writing the information at the eeprom. Hi, can you tell me which util and how it can be done. I am too affected and damaged the eeprom (don't know how) - but my usb id did change too from e1ba:2870 to eb1a:2871. Still need to find a old dmesg log for my stick but it should be this: http://www.mail-archive.com/linux-media@vger.kernel.org/msg14758.html Is this output enough to rewrite the correct eeprom date back to my borked stick or is something else needed? Yes, I think it's enough, of course if it's not the right one, you always can re-write until you get the right eeprom. Good luck! The rewrite_eeprom.pl is available under git.utils tree: http://git.linuxtv.org/v4l-utils.git All instructions are available into the source code. Let me know if you have any problem with such tool. BTW, maybe is a good idea to create at wikipage a page for EEPROMs. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: em28xx/xc3028 - kernel driver vs. Markus Rechberger's driver
Hello, On Tue, Jun 29, 2010 at 4:42 PM, Torsten Krah tk...@fachschaft.imn.htwk-leipzig.de wrote: Am Dienstag, 29. Juni 2010 schrieb Douglas Schilling Landgraf: The rewrite_eeprom.pl is available under git.utils tree: http://git.linuxtv.org/v4l-utils.git All instructions are available into the source code. Let me know if you have any problem with such tool. Hi, yes i have problems with the tool :-). Connected my broken device: lsusb: Bus 001 Device 002: ID eb1a:2871 eMPIA Technology, Inc. dmesg: [ 455.348172] usb 1-1: new high speed USB device using ehci_hcd and address 2 [ 455.481791] usb 1-1: configuration #1 chosen from 1 choice [ 455.609668] usbcore: registered new interface driver snd-usb-audio Running the script which does generate the recover script does work. But running this one fails with: Could not detect i2c bus from any device, run again ./rewrite_eeprom.pl. Did you forget to connect the device? Modules supported: em28xx saa7134 Device is connected. Anything what i can do? Could you please verify if you have the module i2c-dev loaded? Example: #lsmod | grep i2c_dev i2c_dev 6976 0 i2c_core 21104 11 i2c_dev,lgdt330x,tuner_xc2028,tuner,tvp5150,saa7115,em28xx,v4l2_common,videodev,tveeprom,i2c_i801 If yes, please give us the output of: #i2cdetect -l i2c-0 smbus SMBus I801 adapter at ece0 SMBus adapter i2c-1 smbus em28xx #0 SMBus adapter ^ here my device/driver Basically, in your case the tool is not able to recognize your device by i2cdetect.This may happen because i2c_dev module was not able to load? If the module is not loaded, please load it manually and give a new try. I did right now a test with i2c-tools 3.0.0 and 3.0.2. http://dl.lm-sensors.org/i2c-tools/releases/ Let us know the results. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://linuxtv.org/hg/~dougsland/v4l-dvb
Hello, On Fri, May 14, 2010 at 12:54 AM, Douglas Schilling Landgraf dougsl...@gmail.com wrote: Hello Mauro, Please pull from http://linuxtv.org/hg/~dougsland/v4l-dvb for the following: - ir-core-priv.h: error: field 'rx_work' has incomplete type Added: - cx231xx.h: Add include media/ir-kbd-i2c.h Thanks Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: 2.6.29 additional build errors
Hello Samuel, 2010/5/15 Samuel Rakitničan samuel.rakitni...@gmail.com: Additional build errors found after disabling the non building modules on todays mercurial tree. Please update your local repository: $ hg pull -u $ make distclean $ make Now should work. Thanks for your report. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: av7110 and budget_av are broken!
Hello Oliver, On Sat, May 15, 2010 at 8:06 PM, Oliver Endriss o.endr...@gmx.de wrote: On Wednesday 21 April 2010 11:44:16 Oliver Endriss wrote: On Wednesday 21 April 2010 08:37:39 Hans Verkuil wrote: Am 22.3.2010 20:34, schrieb e9hack: Am 20.3.2010 22:37, schrieb Hans Verkuil: On Saturday 20 March 2010 17:03:01 e9hack wrote: OK, I know that. But does the patch I mailed you last time fix this problem without causing new ones? If so, then I'll post that patch to the list. With your last patch, I've no problems. I'm using a a TT-C2300 and a Budget card. If my VDR does start, currently I've no chance to determine which module is load first, but it works. If I unload all modules and load it again, I've no problem. In this case, the modules for the budget card is load first and the modules for the FF loads as second one. Ping!! It's merged in Mauro's fixes tree, but I don't think those pending patches have been pushed upstream yet. Mauro, can you verify this? They should be pushed to 2.6.34! What about the HG driver? The v4l-dvb HG repository is broken for 7 weeks... Hi guys, we have May 16th, and the HG driver is broken for 10 weeks now! History: - The changeset which caused the mess was applied on March 2nd: http://linuxtv.org/hg/v4l-dvb/rev/2eda2bcc8d6f - A fix is waiting at fixes.git since March 24th: http://git.linuxtv.org/fixes.git?a=commitdiff_plain;h=40358c8b5380604ac2507be2fac0c9bbd3e02b73 Are there any plans to bring v4ldvb HG to an usable state? Yes, Now I will collect patches from devel and fixes tree. At least until we achieve a better approach on it. Sorry the delay. Sounds good? Any other suggestion? Let me work on it. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: av7110 and budget_av are broken!
On Sat, May 15, 2010 at 8:06 PM, Oliver Endriss o.endr...@gmx.de wrote: On Wednesday 21 April 2010 11:44:16 Oliver Endriss wrote: On Wednesday 21 April 2010 08:37:39 Hans Verkuil wrote: Am 22.3.2010 20:34, schrieb e9hack: Am 20.3.2010 22:37, schrieb Hans Verkuil: On Saturday 20 March 2010 17:03:01 e9hack wrote: OK, I know that. But does the patch I mailed you last time fix this problem without causing new ones? If so, then I'll post that patch to the list. With your last patch, I've no problems. I'm using a a TT-C2300 and a Budget card. If my VDR does start, currently I've no chance to determine which module is load first, but it works. If I unload all modules and load it again, I've no problem. In this case, the modules for the budget card is load first and the modules for the FF loads as second one. Ping!! It's merged in Mauro's fixes tree, but I don't think those pending patches have been pushed upstream yet. Mauro, can you verify this? They should be pushed to 2.6.34! What about the HG driver? The v4l-dvb HG repository is broken for 7 weeks... Hi guys, we have May 16th, and the HG driver is broken for 10 weeks now! History: - The changeset which caused the mess was applied on March 2nd: http://linuxtv.org/hg/v4l-dvb/rev/2eda2bcc8d6f - A fix is waiting at fixes.git since March 24th: http://git.linuxtv.org/fixes.git?a=commitdiff_plain;h=40358c8b5380604ac2507be2fac0c9bbd3e02b73 Are there any plans to bring v4ldvb HG to an usable state? Please hg pull -u, now should include the change that you are looking for. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH -hg] Build fix for mercurial tree
On Thu, May 13, 2010 at 3:43 PM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Fix backport tree compilations with kernels older than 2.6.33.
Compile tested only, with 2.6.32.4 kernel.
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
diff --git a/linux/drivers/media/IR/ir-core-priv.h
b/linux/drivers/media/IR/ir-core-priv.h
--- a/linux/drivers/media/IR/ir-core-priv.h
+++ b/linux/drivers/media/IR/ir-core-priv.h
@@ -28,7 +28,11 @@ struct ir_raw_handler {
struct ir_raw_event_ctrl {
struct work_struct rx_work; /* for the rx decoding
workqueue */
+#if LINUX_VERSION_CODE KERNEL_VERSION(2, 6, 33)
+ struct kfifo *kfifo; /* fifo for the
pulse/space durations */
+#else
struct kfifo kfifo; /* fifo for the
pulse/space durations */
+#endif
ktime_t last_event; /* when last event
occurred */
enum raw_event_type last_type; /* last event type */
struct input_dev *input_dev; /* pointer to the
parent input_dev */
diff --git a/linux/drivers/media/IR/ir-raw-event.c
b/linux/drivers/media/IR/ir-raw-event.c
--- a/linux/drivers/media/IR/ir-raw-event.c
+++ b/linux/drivers/media/IR/ir-raw-event.c
@@ -61,8 +61,13 @@ static void ir_raw_event_work(struct wor
struct ir_raw_event_ctrl *raw =
container_of(work, struct ir_raw_event_ctrl, rx_work);
+#if LINUX_VERSION_CODE KERNEL_VERSION(2, 6, 33)
+ while (kfifo_get(raw-kfifo, (void *)ev, sizeof(ev)) == sizeof(ev))
+ RUN_DECODER(decode, raw-input_dev, ev);
+#else
while (kfifo_out(raw-kfifo, ev, sizeof(ev)) == sizeof(ev))
RUN_DECODER(decode, raw-input_dev, ev);
+#endif
}
int ir_raw_event_register(struct input_dev *input_dev)
@@ -77,8 +82,15 @@ int ir_raw_event_register(struct input_d
ir-raw-input_dev = input_dev;
INIT_WORK(ir-raw-rx_work, ir_raw_event_work);
+#if LINUX_VERSION_CODE KERNEL_VERSION(2, 6, 33)
+ ir-raw-kfifo = kfifo_alloc(sizeof(s64) * MAX_IR_EVENT_SIZE,
+ GFP_KERNEL, NULL);
+ if (ir-raw-kfifo == NULL)
+ rc = -ENOMEM;
+#else
rc = kfifo_alloc(ir-raw-kfifo, sizeof(s64) * MAX_IR_EVENT_SIZE,
GFP_KERNEL);
+#endif
if (rc 0) {
kfree(ir-raw);
ir-raw = NULL;
@@ -87,7 +99,11 @@ int ir_raw_event_register(struct input_d
rc = RUN_DECODER(raw_register, input_dev);
if (rc 0) {
+#if LINUX_VERSION_CODE KERNEL_VERSION(2, 6, 33)
+ kfifo_free(ir-raw-kfifo);
+#else
kfifo_free(ir-raw-kfifo);
+#endif
kfree(ir-raw);
ir-raw = NULL;
return rc;
@@ -106,7 +122,11 @@ void ir_raw_event_unregister(struct inpu
cancel_work_sync(ir-raw-rx_work);
RUN_DECODER(raw_unregister, input_dev);
+#if LINUX_VERSION_CODE KERNEL_VERSION(2, 6, 33)
+ kfifo_free(ir-raw-kfifo);
+#else
kfifo_free(ir-raw-kfifo);
+#endif
kfree(ir-raw);
ir-raw = NULL;
}
@@ -128,8 +148,13 @@ int ir_raw_event_store(struct input_dev
if (!ir-raw)
return -EINVAL;
+#if LINUX_VERSION_CODE KERNEL_VERSION(2, 6, 33)
+ if (kfifo_put(ir-raw-kfifo, (void *)ev, sizeof(*ev)) != sizeof(*ev))
+ return -ENOMEM;
+#else
if (kfifo_in(ir-raw-kfifo, ev, sizeof(*ev)) != sizeof(*ev))
return -ENOMEM;
+#endif
return 0;
}
Applied, thanks.
Cheers
Douglas
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Mercurial x git tree sync - was: Re: Remote control at Zolid Hybrid TV Tuner
Hi,
On Thu, May 13, 2010 at 1:49 AM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
hermann pitton wrote:
Am Mittwoch, den 12.05.2010, 15:59 -0300 schrieb Mauro Carvalho Chehab:
Sander Pientka wrote:
Hi Hermann,
I am going to revive this old thread, I completely forgot about it and
I still want to solve this problem.
Yes, with the IR transmitter not plugged in, the gpio is reported as
0 by dmesg.
I am aware there is a picture of the backside missing on the wiki, I
will try to make one a.s.a.p.
NEC IR support seems to be built-in already:
drivers/media/IR/ir-nec-decoder.c.
Besides, dmesg outputs a section of error messages I don't understand:
[ 1585.548221] tda18271_write_regs: ERROR: idx = 0x5, len = 1,
i2c_transfer returned: -5
[ 1585.548229] tda18271_toggle_output: error -5 on line 47
[ 1585.720118] tda18271_write_regs: ERROR: idx = 0x5, len = 1,
i2c_transfer returned: -5
[ 1585.720129] tda18271_init: error -5 on line 826
[ 1585.720136] tda18271_tune: error -5 on line 904
[ 1585.720141] tda18271_set_analog_params: error -5 on line 1041
[ 1586.381026] tda18271_write_regs: ERROR: idx = 0x6, len = 1,
i2c_transfer returned: -5
[ 1586.500589] tda18271_write_regs: ERROR: idx = 0x1d, len = 1,
i2c_transfer returned: -5
[ 1586.629447] tda18271_write_regs: ERROR: idx = 0x10, len = 1,
i2c_transfer returned: -5
[ 1586.629458] tda18271_channel_configuration: error -5 on line 160
[ 1586.629465] tda18271_set_analog_params: error -5 on line 1041
Do you have any idea about the origin of these errors? Do you think
they affect the IR functionality?
The above errors won't change anything at IR side. For IR, the better
approach
is to start using raw_decode mode. I've enabled it only for Avermedia M135A,
since this is the board I'm using at the IR refactoring tests, but the same
approach
should work fine for any other saa7134 board that uses GPIO18 or GPIO16.
For GPIO18,
all you need is to use something like:
case SAA7134_BOARD_AVERMEDIA_M135A:
ir_codes = RC_MAP_AVERMEDIA_M135A_RM_JX;
mask_keydown = 0x004;
mask_keyup = 0x004;
mask_keycode = 0x;
raw_decode = 1;
break;
(Of course, replacing the board name by your board name
(SAA7134_BOARD_ZOLID_HYBRID_PCI?),
and pointing to the proper ir_codes table. You'll likely need to write one
table for
the IR that were shipped with your board.
To do that, you'll need to enable debug at ir_core (modprobe ir_core
debug=1), and type every
key on your keyboard, associating the scancode number with a key name. See
http://www.linuxtv.org/wiki/index.php/Remote_Controllers for a reference of
the most comon keycodes.
For example, pressing the power button of an IR I have here (for Leadtek
PVR3000), it
gives this info at the dmesg log:
ir_nec_decode: NEC scancode 0x0300
All I need to do is to write a new keymap:
add a new media/rc-map.h
as, for example:
drivers/media/IR/keymaps/rc-leadtek_pvr3000.c
(copying one of the existing keymaps) and add:
static struct ir_scancode leadtek_winfast_pvr3000_dlx[] = {
{ 0x300, KEY_POWER2 },
for every key that it is there. Then, add the new file at
drivers/media/IR/keymaps/Makefile.
I've tried to summarize the above patches on a change I just did at the
wiki page. Feel
free to improve it, if needed.
Cheers,
Mauro
Hi Mauro,
what I did try to point to, with some sarcasm involved, is that I can't
advice any v4l-dvb as reference anymore.
Well, any help to fix v4l-dvb trees are welcome.
To start to look such up, with all patches involved, per user, who
likely does not know himself on what he exactly is, find the last
building kernel for him then, guess on pending pull requests that time,
and so on, is not making any sense for me.
Should we not state, that is nothing against Douglas at all or Hans with
his build reports, please be on latest .rc and git to test anything we
have around?
We are out of sync else.
Hermann,
Sorry, but, sometimes, it is very hard to understand your English. I'm
suspecting
that you're referring to the sync between hg and git.
Short answer:
- AFAIK, Douglas finished syncing the trees at the night of May, 12.
Exactly.
- Developers primary reference tree:
http://git.linuxtv.org/v4l-dvb.git
- Backport tree:
http://linuxtv.org/hg/v4l-dvb
Agreed.
As the backport is manual, some delay is expected at the backport tree.
Also,
backports are made at the best efforts basis. So, nobody can warrant that the
drivers will behave correctly with an old kernel. Also, eventually, the
backport tree
can break when compiled with an older kernel.
As Mauro pointed, the backport job is done by 99% of time taking every single
patch available in git tree and apply it manually and fixing
eventually problems.
So, it's can take some time.
Developers
[PULL] http://linuxtv.org/hg/~dougsland/v4l-dvb
Hello Mauro, Please pull from http://linuxtv.org/hg/~dougsland/v4l-dvb for the following: - ir-core-priv.h: error: field 'rx_work' has incomplete type Thanks Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://kernellabs.com/hg/~dheitmueller/ngene2
Hello Devin/Mauro, On Fri, May 7, 2010 at 11:52 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Devin Heitmueller wrote: Hello, Please PULL from http://kernellabs.com/hg/~dheitmueller/ngene2 for the following: Hi Devin, As agreed via IRC with you and stoth, I'm applying all patches, except for the ones that are currently creating unused files at the building system. Let's apply them after you have added some code running there. ngene: properly support boards where channel 0 isn't a TS input ngene: add initial support for digital side of Avermedia m780 ngene: split out i2c code into a separate file Committed. ngene: split out card specific code into a separate file ngene: split out DVB audio/video into a separate file Not merged: it just creates a file with currently unused code. ngene: move more card-specific code to ngene-cards.c This patch were folded with ngene: split out card specific code into a separate file. ngene: split out eeprom functions int a separate file ngene: move a few more DVB a/v related functions Not merged: they just create a file with currently unused code. ngene: start separating out DVB functions into separate file Committed, with a few trivial conflict resolving changes, caused by not merging the 3 previous patches. ngene: Add lgdt3303 and mt2131 deps to Kconfig Committed. I've stored locally the rebased diffs for the non-applied patches. So, on your next ngene pull, you won't need to rebase against my git. It should also be noticed that I needed to apply one patch before your series, in order to fix those compilation errors: drivers/media/dvb/ngene/ngene-cards.c:42:20: error: mt2131.h: Arquivo ou diretório não encontrado drivers/media/dvb/ngene/ngene-cards.c:111: error: variable ‘m780_tunerconfig’ has initializer but incomplete type drivers/media/dvb/ngene/ngene-cards.c:113: warning: excess elements in struct initializer drivers/media/dvb/ngene/ngene-cards.c:113: warning: (near initialization for ‘m780_tunerconfig’) drivers/media/dvb/ngene/ngene-cards.c: In function ‘demod_attach_lg330x’: drivers/media/dvb/ngene/ngene-cards.c:126: error: ‘mt2131_attach’ undeclared (first use in this function) drivers/media/dvb/ngene/ngene-cards.c:126: error: (Each undeclared identifier is reported only once drivers/media/dvb/ngene/ngene-cards.c:126: error: for each function it appears in.) drivers/media/dvb/ngene/ngene-cards.c:126: warning: type defaults to ‘int’ in declaration of ‘__a’ drivers/media/dvb/ngene/ngene-cards.c:126: warning: type defaults to ‘int’ in declaration of ‘type name’ drivers/media/dvb/ngene/ngene-cards.c:126: warning: type defaults to ‘int’ in declaration of ‘type name’ drivers/media/dvb/ngene/ngene-cards.c:126: error: called object ‘__a’ is not a function The fix were to just add the proper tuner include directory: --- a/drivers/media/dvb/ngene/Makefile +++ b/drivers/media/dvb/ngene/Makefile @@ -8,4 +8,4 @@ obj-$(CONFIG_DVB_NGENE) += ngene.o EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core/ EXTRA_CFLAGS += -Idrivers/media/dvb/frontends/ - +EXTRA_CFLAGS += -Idrivers/media/common/tuners/ Douglas, It seems to me that the better option is if you just pull from ngene2 tree at hg. This will produce a small diff between -git and -hg, but, as according with Devin, they'll send soon an update on ngene driver adding some working code for eeprom and ngene-av, it should probably be ok for you to handle this difference for a couple weeks, especially since it won't produce any runtime difference. Of course, it is up to you to decide, as you're the maintainer of the backport tree ;) I have merged all patches from http://kernellabs.com/hg/~dheitmueller/ngene2. Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [hg:v4l-dvb] Add FE_CAN_PSK_8 to allow apps to identify PSK_8 capable DVB devices
Hello Klaus, On Mon, May 10, 2010 at 2:45 PM, Klaus Schmidinger klaus.schmidin...@tvdr.de wrote: On 10.05.2010 06:40, Patch from Klaus Schmidinger wrote: The patch number 14692 was added via Douglas Schilling Landgraf dougsl...@redhat.com to http://linuxtv.org/hg/v4l-dvb master development tree. Kernel patches in this development tree may be modified to be backward compatible with older kernels. Compatibility modifications will be removed before inclusion into the mainstream Kernel If anyone has any objections, please let us know by sending a message to: Linux Media Mailing List linux-media@vger.kernel.org This patch should not have been applied, as was decided in the original thread. The patch was reverted yesterday during the hg - git sync. http://linuxtv.org/hg/v4l-dvb/rev/9b6b81d5efbd Thanks Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://www.linuxtv.org/hg/~dougsland/v4l-dvb
Hello Mauro, Please pull from http://www.linuxtv.org/hg/~dougsland/v4l-dvb for the following: - FusionHDTV: Use quick reads for I2C IR device probingdefault tip - vpfe capture - fix for kernel crash - ov511: Fix continuation lines - saa7134-cards: Add support new TV cards - saa7134: add support for Avermedia M733A - saa7134: fix GPIO HW-404M7 - drivers/media/video: avoid NULL dereference - Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb - cx88-dvb: fix on switch identation - cx23885: strcpy() = strlcpy() - cx25821: fix coding style issues in cx25821-video-upstream.c Thanks Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] gspca: Add CONFIG_INPUT to gspca_input_connect()
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c index 1830ea9..df44eca 100644 --- a/drivers/media/video/gspca/gspca.c +++ b/drivers/media/video/gspca/gspca.c @@ -2281,9 +2281,11 @@ int gspca_dev_probe(struct usb_interface *intf, goto out; gspca_set_default_mode(gspca_dev); +#ifdef CONFIG_INPUT ret = gspca_input_connect(gspca_dev); if (ret) goto out; +#endif mutex_init(gspca_dev-usb_lock); mutex_init(gspca_dev-read_lock); -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb
Hello Ricardo, On Wed, Mar 24, 2010 at 10:27 AM, Ricardo Maraschini xrma...@gmail.com wrote: Signed-off-by: Ricardo Maraschini ricardo.marasch...@gmail.com --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:52:23 2010 -0300 +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Wed Mar 24 09:57:06 2010 -0300 @@ -1401,8 +1401,6 @@ case CX88_BOARD_SAMSUNG_SMT_7020: dev-ts_gen_cntrl = 0x08; - struct cx88_core *core = dev-core; - cx_set(MO_GP0_IO, 0x0101); cx_clear(MO_GP0_IO, 0x01); This version seems ok to my eyes. Thanks Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Pull request: http://linuxtv.org/hg/~hgoede/gspca
Hi, On 03/18/2010 09:25 AM, Mauro Carvalho Chehab wrote: Hans de Goede wrote: Hi Mauro, Please pull from: http://linuxtv.org/hg/~hgoede/gspca For the following changes: gspca_spca561: Fix LED on rev12a cameras gspca_spca561: Add support for camera button sn9c102: Make hv7131d sensor code also recognize the HV7131E gspca: make usb id 0461:0815 get handled by the right driver Hmm... something got wrong here: # Mercurial patches imported from http://linuxtv.org/hg/~hgoede/gspca hg_14494_gspca_mr97310a_simplify_sensor_detection.patch hg_14495_gspca_sq905c_add_an_additional_usb_id.patch hg_14496_gscpa_documentation_add_cpia1_cameras.patch hg_14497_gscpa_pac207_add_support_for_camera_button.patch hg_14498_gscpa_pac7311_add_support_for_camera_button.patch hg_14499_gscpa_zc3xx_add_support_for_camera_button.patch hg_14500_gspca_sonixb_add_support_for_camera_button.patch hg_14501_gspca_sonixj_add_camera_button_support.patch hg_14502_gspca_sonixb_leave_bridge_gain_at_1_0_when_we_have_a_sensor_gain.patch hg_14503_gscpa_sonixb_differentiate_between_sensors_with_a_coarse_and_fine_expo_ctrl.patch hg_14504_gspca_sonixb_pas202_fixup_brightness_ctrl_and_add_gain_and_exposure_ctrls.patch hg_14505_gscpa_sonixb_limit_ov7630_max_framerate_at_640x480.patch hg_14506_gspca_mr97310a_add_support_for_the_sakar_1638x_cyberpix.patch hg_14507_documentation_gspca_txt_update_known_mr97310a_cams.patch hg_14508_gspca_sonixb_pas106_fixup_brightness_ctrl_and_add_gain_and_exposure_ctrls.patch hg_14509_gspca_sonixb_make_sonixb_driver_handle_pas106_and_pas202_cameras.patch hg_14510_gspca_pac7302_much_improved_exposure_control.patch hg_14511_gspca_main_allow_use_of_input_device_creation_code_for_non_int_inputs.patch hg_14512_gspca_main_some_input_error_handling_fixes.patch hg_14513_gspca_main_fix_a_compile_error_when_config_input_is_not_set.patch hg_14514_gspca_ov519_add_support_for_the_button_on_ov519_based_cams.patch hg_14515_gspca_ov519_add_support_for_the_button_on_ov518_based_cams.patch hg_14516_gspca_ov519_add_support_for_the_button_on_ov511_based_cams.patch hg_14517_gspca_stv06xx_add_support_for_camera_button.patch hg_14518_gspca_spca561_fix_led_on_rev12a_cameras.patch hg_14519_gspca_spca561_add_support_for_camera_button.patch hg_14520_sn9c102_make_hv7131d_sensor_code_also_recognize_the_hv7131e.patch hg_14521_gspca_make_usb_id_0461_0815_get_handled_by_the_right_driver.patch Maybe Douglas had to directly import some patches from -git, instead of pulling from -hg (or maybe you're just faster than Douglas, sending a new patch series before he finish the import of the older ones). I remember to took these patches from git, sorry Hans. I will took your new patches from you new hg tree. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://kernellabs.com/hg/~mkrufky/dvb-usb
Hey Michael, Michael Krufky wrote: Doug, If possible, would you pull this changeset from my hg tree rather than doing a git backport, after Mauro merges this? If possible, I'd like to retain the hash value of this changeset so that I don't have to rebuild all of my development trees. If you can do this for me, I'd really appreciate it. If a more detailed explanation of why I am making this request is required, please say so and I'll explain in further detail. Sure. Cheers Douglas Mauro, Please pull from: http://kernellabs.com/hg/~mkrufky/dvb-usb for: - dvb-usb: enable specifying a separate generic bulk ctrl response endpoint dvb-usb-urb.c |2 ++ dvb-usb.h |7 +++ 2 files changed, 9 insertions(+) This opens the door to make the dvb-usb framework more generic to be able to support a variety of additional new devices. It also will allow us to cleanup / remove some redundant code in some existing dvb-usb drivers. After this is merged, cleanup patches on existing drivers will follow. Thanks regards, Mike Krufky -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: problem compiling modoule mt9t031 in current v4l-dvb-hg
Hi, On 03/07/2010 08:32 AM, Halim Sahin wrote: Hi Folks, I was not able to build v4l-dvb from hg (checked out today). /root/work/v4l-dvb/v4l/mt9t031.c:729: error: unknown field 'runtime_suspend' specified in initializer /root/work/v4l-dvb/v4l/mt9t031.c:730: error: unknown field 'runtime_resume' specified in initializer /root/work/v4l-dvb/v4l/mt9t031.c:730: warning: initialization from incompatible pointer type make[3]: *** [/root/work/v4l-dvb/v4l/mt9t031.o] Error 1 make[2]: *** [_module_/root/work/v4l-dvb/v4l] Error 2 make[1]: *** [default] Fehler 2 make: *** [all] Fehler 2 Kernel 2.6.31 (x86_64) regards Halim Thanks for your report. This issue was resolved, refresh your branch. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: v4l-dvb build problem with soc_camera
Hi, On 03/07/2010 08:38 AM, Halim Sahin wrote: Hi, Same environment like in my previous mail: /root/work/v4l-dvb/v4l/soc_camera.c:27:30: error: linux/pm_runtime.h: No such file or directory /root/work/v4l-dvb/v4l/soc_camera.c: In function 'soc_camera_open': /root/work/v4l-dvb/v4l/soc_camera.c:392: error: implicit declaration of function 'pm_runtime_enable' /root/work/v4l-dvb/v4l/soc_camera.c:393: error: implicit declaration of function 'pm_runtime_resume' /root/work/v4l-dvb/v4l/soc_camera.c:422: error: implicit declaration of function 'pm_runtime_disable' /root/work/v4l-dvb/v4l/soc_camera.c: In function 'soc_camera_close': /root/work/v4l-dvb/v4l/soc_camera.c:448: error: implicit declaration of function 'pm_runtime_suspend' make[3]: *** [/root/work/v4l-dvb/v4l/soc_camera.o] Error 1 make[2]: *** [_module_/root/work/v4l-dvb/v4l] Error 2 make[1]: *** [default] Fehler 2 make: *** [all] Fehler 2 BR. Halim Thanks for your report. This issue was resolved. Please update your tree. Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: v4l-utils: i2c-id.h and alevt
On 03/10/2010 02:04 AM, hermann pitton wrote: Hi Hans, both, Am Dienstag, den 09.03.2010, 08:48 +0100 schrieb Hans Verkuil: It's nice to see this new tree, that should be make it easier to develop utilities! After a quick check I noticed that the i2c-id.h header was copied from the kernel. This is not necessary. The only utility that includes this is v4l2-dbg and that one no longer needs it. Hans, can you remove this? The second question is whether anyone would object if alevt is moved from dvb-apps to v4l-utils? It is much more appropriate to have that tool in v4l-utils. i wonder that this stays such calm, hopefully a good sign. In fact alevt analog should come with almost every distribution, but the former alevt-dvb, named now only alevt, well, might be ok in some future, is enhanced for doing also dvb-t-s and hence there ATM. Does anyone know of other unmaintained but useful tools that we might merge into v4l-utils? E.g. xawtv perhaps? If for xawtv could be some more care, ships also since close to ever with alevtd, that would be fine, but I'm not sure we are talking about tools anymore in such case, since xawtv4x, tvtime and mpeg4ip ;) for example are also there and unmaintained. I think would be nice to hear a word from Devin, which have been working in tvtime. Devin? Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [hg:v4l-dvb] gspca - main: Fix a compile error when CONFIG_INPUT is not set
Hi,
Jean-Francois Moine wrote:
On Wed, 03 Mar 2010 00:45:02 +0100
Patch from Jean-Fran?ois Moine hg-com...@linuxtv.org wrote:
The patch number 14343 was added via Douglas Schilling Landgraf
dougsl...@redhat.com to http://linuxtv.org/hg/v4l-dvb master
development tree.
Kernel patches in this development tree may be modified to be backward
compatible with older kernels. Compatibility modifications will be
removed before inclusion into the mainstream Kernel
If anyone has any objections, please let us know by sending a message
to: Linux Media Mailing List linux-media@vger.kernel.org
--
From: Jean-Fran?ois Moine moin...@free.fr
gspca - main: Fix a compile error when CONFIG_INPUT is not set
Reported-by: Randy Dunlap randy.dun...@oracle.com
Priority: normal
[dougsl...@redhat.com: patch backported to hg tree]
Signed-off-by: Jean-Fran?ois Moine moin...@free.fr
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com
---
linux/drivers/media/video/gspca/gspca.c |6 ++
1 file changed, 6 insertions(+)
diff -r c533329e3c41 -r 6519c63ecf6d
linux/drivers/media/video/gspca/gspca.c ---
a/linux/drivers/media/video/gspca/gspca.c Tue Mar 02 20:16:17
2010 -0300 +++ b/linux/drivers/media/video/gspca/gspca.cTue
Mar 02 20:38:01 2010 -0300 @@ -44,10 +44,12 @@
#include gspca.h
+#ifdef CONFIG_INPUT
#if LINUX_VERSION_CODE = KERNEL_VERSION(2, 6, 19)
#include linux/input.h
#include linux/usb/input.h
#endif
+#endif
/* global values */
#define DEF_NURBS 3/* default number of URBs */
@@ -2371,9 +2373,11 @@
void gspca_disconnect(struct usb_interface *intf)
{
struct gspca_dev *gspca_dev = usb_get_intfdata(intf);
+#ifdef CONFIG_INPUT
#if LINUX_VERSION_CODE = KERNEL_VERSION(2, 6, 19)
struct input_dev *input_dev;
#endif
+#endif
PDEBUG(D_PROBE, %s disconnect,
video_device_node_name(gspca_dev-vdev));
@@ -2385,6 +2389,7 @@
wake_up_interruptible(gspca_dev-wq);
}
+#ifdef CONFIG_INPUT
#if LINUX_VERSION_CODE = KERNEL_VERSION(2, 6, 19)
gspca_input_destroy_urb(gspca_dev);
input_dev = gspca_dev-input_dev;
@@ -2393,6 +2398,7 @@
input_unregister_device(input_dev);
}
#endif
+#endif
/* the device is freed at exit of this function */
gspca_dev-dev = NULL;
---
Patch is available at:
http://linuxtv.org/hg/v4l-dvb/rev/6519c63ecf6d4e7e2c1c3d46ac2a161da8d6c6f4
Hello Douglas,
I do not understand your patch. Do you mean that the input events
cannot be used with kernel 2.6.19, while CONFIG_INPUT can be set?
Anyway, this patch seems complex. It would have been easier to simply
unset CONFIG_INPUT when kernel 2.6.19.
Agreed. Anyway, there are parts which still need CONFIG_INPUT if we want
to remove the kernel check. Going to review this one.
I join the diff of gspca.c between v4l-dvb and my repository. This last
one is closer to the git version and there are still other changes done
in git. How do you think I should merge?
If I understand your question correctly, the better way is wait until I
complete the merge between git and hg which I intend to complete today
and then merge the hg trees. I will give you a note.
Cheers
Douglas
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [hg:v4l-dvb] gspca - main: Fix a compile error when CONFIG_INPUT is not set
Hello Jean,
On 03/03/2010 11:19 AM, Douglas Schilling Landgraf wrote:
Hi,
Jean-Francois Moine wrote:
On Wed, 03 Mar 2010 00:45:02 +0100
Patch from Jean-Fran?ois Moine hg-com...@linuxtv.org wrote:
The patch number 14343 was added via Douglas Schilling Landgraf
dougsl...@redhat.com to http://linuxtv.org/hg/v4l-dvb master
development tree.
Kernel patches in this development tree may be modified to be backward
compatible with older kernels. Compatibility modifications will be
removed before inclusion into the mainstream Kernel
If anyone has any objections, please let us know by sending a message
to: Linux Media Mailing List linux-media@vger.kernel.org
--
From: Jean-Fran?ois Moine moin...@free.fr
gspca - main: Fix a compile error when CONFIG_INPUT is not set
Reported-by: Randy Dunlap randy.dun...@oracle.com
Priority: normal
[dougsl...@redhat.com: patch backported to hg tree]
Signed-off-by: Jean-Fran?ois Moine moin...@free.fr
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com
---
linux/drivers/media/video/gspca/gspca.c |6 ++
1 file changed, 6 insertions(+)
diff -r c533329e3c41 -r 6519c63ecf6d
linux/drivers/media/video/gspca/gspca.c ---
a/linux/drivers/media/video/gspca/gspca.cTue Mar 02 20:16:17
2010 -0300 +++ b/linux/drivers/media/video/gspca/gspca.cTue
Mar 02 20:38:01 2010 -0300 @@ -44,10 +44,12 @@ #include gspca.h
+#ifdef CONFIG_INPUT
#if LINUX_VERSION_CODE = KERNEL_VERSION(2, 6, 19)
#include linux/input.h
#include linux/usb/input.h
#endif
+#endif
/* global values */
#define DEF_NURBS 3/* default number of URBs */
@@ -2371,9 +2373,11 @@
void gspca_disconnect(struct usb_interface *intf)
{
struct gspca_dev *gspca_dev = usb_get_intfdata(intf);
+#ifdef CONFIG_INPUT
#if LINUX_VERSION_CODE = KERNEL_VERSION(2, 6, 19)
struct input_dev *input_dev;
#endif
+#endif
PDEBUG(D_PROBE, %s disconnect,
video_device_node_name(gspca_dev-vdev));
@@ -2385,6 +2389,7 @@
wake_up_interruptible(gspca_dev-wq);
}
+#ifdef CONFIG_INPUT
#if LINUX_VERSION_CODE = KERNEL_VERSION(2, 6, 19)
gspca_input_destroy_urb(gspca_dev);
input_dev = gspca_dev-input_dev;
@@ -2393,6 +2398,7 @@
input_unregister_device(input_dev);
}
#endif
+#endif
/* the device is freed at exit of this function */
gspca_dev-dev = NULL;
---
Patch is available at:
http://linuxtv.org/hg/v4l-dvb/rev/6519c63ecf6d4e7e2c1c3d46ac2a161da8d6c6f4
Hello Douglas,
I do not understand your patch. Do you mean that the input events
cannot be used with kernel 2.6.19, while CONFIG_INPUT can be set?
Anyway, this patch seems complex. It would have been easier to simply
unset CONFIG_INPUT when kernel 2.6.19.
Agreed. Anyway, there are parts which still need CONFIG_INPUT if we
want to remove the kernel check. Going to review this one.
I join the diff of gspca.c between v4l-dvb and my repository. This last
one is closer to the git version and there are still other changes done
in git. How do you think I should merge?
If I understand your question correctly, the better way is wait until
I complete the merge between git and hg which I intend to complete
today and then merge the hg trees. I will give you a note.
git and hg are synced, now I will work about compatible items in the tree.
Cheers
Douglas
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ANNOUNCE] git tree repositories libv4l
Hello all, On 02/23/2010 10:51 AM, Hans de Goede wrote: Hi, On 02/23/2010 04:37 PM, Mauro Carvalho Chehab wrote: Hans de Goede wrote: Ok, so this will give me a local tree, how do I get this onto linuxtv.org ? I added it. In thesis, it is open for commit to you, me, hverkuil and dougsland. I see good, thanks! Can someone (Douglas ?) with better hg / git powers then me please somehow import all the libv4l changes from: http://linuxtv.org/hg/~hgoede/libv4l Done! Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: I don't get GIT
Hello Brandon, On 02/05/2010 09:48 AM, Brandon Jenkins wrote: Hi Linux Media, As an end user I am most interested in updating specific drivers for my system. Most distros, that I know of, only bump kernel versions by releasing a new version of the distro. As development move to the GIT repository, how do I as an end user pull the drivers and compile for my current running kernel? I am not too interested in compiling the whole kernel just to get the fixes of the drivers. NOTE: The sole reason this server exists is to provide TV and media distribution in the home. We still have mercurial tree available which became the backport tree. Basically, almost daily this tree is synced with git tree and backported some drivers to work with old kernels. When I read through Mauro's announcement of the GIT repository it seemed to indicate that this feature wasn't available. Although I could have read that incorrectly. You can download the hg tree following the linuxtv wiki page: http://www.linuxtv.org/wiki/index.php/How_to_Obtain,_Build_and_Install_V4L-DVB_Device_Drivers#Using_Mercurial Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] sq905c: remove unused variable
Removed unused variable. Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com Thanks, Douglas patch-sq905c.diff Description: Binary data
Re: [PULL] http://kernellabs.com/hg/~dheitmueller/xc3028-regression
Hello Devin Mauro, On Fri, Jan 22, 2010 at 6:16 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: Devin Heitmueller wrote: Hello Mauro, Please PULL from http://kernellabs.com/hg/~dheitmueller/xc3028-regression for the following: xc3028: fix regression in firmware loading time This is a fix for a regression you introduced into the tuner-xc2028 driver in rev 12824. Devin Applied on -git, thanks. Applied to -hg tree, thanks! Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-3
Hello, On Fri, Jan 22, 2010 at 7:32 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: Devin Heitmueller wrote: Hello Mauro, Please PULL from http://kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-3 for the following: cx18-alsa: Fix the rates definition and move some buffer freeing code. cx18: address possible passing of NULL to snd_card_free cx18-alsa: codingstyle cleanup cx18-alsa: codingstyle cleanup cx18: codingstyle fixes cx18-alsa: codingstyle fixes cx18-alsa: fix codingstyle issue cx18-alsa: fix memory leak in error condition cx18-alsa: remove a couple of warnings cx18-alsa: name alsa device after the actual card cx18: cleanup cx18-alsa debug logging cx18: rework cx18-alsa module loading to support automatic loading cx18-alsa: remove unneeded debug line cx18: export more symbols required by cx18-alsa cx18: add cx18-alsa module to Makefile cx18: overhaul ALSA PCM device handling so it works cx18: export a couple of symbols so they can be shared with cx18-alsa cx18: make it so cx18-alsa-main.c compiles cx18: rename cx18-alsa.c cx18-alsa: Add non-working cx18-alsa-pcm.[ch] files to avoid data loss cx18-alsa: Initial non-working cx18-alsa files There is one remaining checkpatch warning: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable #45: FILE: drivers/media/video/cx18/cx18-driver.c:52: +EXPORT_SYMBOL(cx18_ext_init); Please send later a patch fixing it. This tree is the same as hvr-1600-alsa-2 except I rebased it off of the v4l-dvb tip, fixing the merge conflict with Andy's cx18-stream changes. Applied on -git, thanks. Applied on -hg tree, thanks Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://udev.netup.ru/hg/v4l-dvb-aospan-22fix
Hello, On Fri, Jan 22, 2010 at 5:31 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Abylai Ospan wrote: Hello, On Fri, 2010-01-22 at 15:34 -0200, Mauro Carvalho Chehab wrote: You forgot to sign it. You can simply reply to this email with your SOB, as I'll need to add Olvier's ack on it also. fixed. http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-22fix/rev/058d68daed91 Applied on -git, thanks. PS.: Douglas should update -hg tree when he have time. Applied on -hg tree, thanks Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://linuxtv.org/hg/~awalls/v4l-dvb-bugfix
On Fri, Jan 22, 2010 at 6:24 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Andy Walls wrote: Mauro, Please pull from http://linuxtv.org/hg/~awalls/v4l-dvb-bugfix for the following 3 changesets: 01/03: ivtv: Fix race condition for queued udma transfers http://linuxtv.org/hg/~awalls/v4l-dvb-bugfix?cmd=changeset;node=0ffbc0331b4d 02/03: cx25840, v4l2-subdev, ivtv, pvrusb2: Fix ivtv/cx25840 tinny audio http://linuxtv.org/hg/~awalls/v4l-dvb-bugfix?cmd=changeset;node=7753cdcebd28 03/03: ivtv: Adjust msleep() delays used to prevent tinny audio and PCI bus hang http://linuxtv.org/hg/~awalls/v4l-dvb-bugfix?cmd=changeset;node=ec42a97b1a36 drivers/media/video/cx25840/cx25840-core.c | 48 +++-- drivers/media/video/ivtv/ivtv-irq.c | 5 +-- drivers/media/video/ivtv/ivtv-streams.c | 8 +++- drivers/media/video/ivtv/ivtv-udma.c | 1 drivers/media/video/pvrusb2/pvrusb2-hdw.c | 1 include/media/v4l2-subdev.h | 1 6 files changed, 51 insertions(+), 13 deletions(-) Thanks go to Argus for figuring out the causal relationship for the tinny audio problem. Many thanks go to Martin Dauskardt whose extensive testing efforts found optimal time delays for the msleep()s to avoid video artifacts. Thanks, Andy Applied on -git, thanks. Applied on -hg tree, thanks! Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] http://mercurial.intuxication.org/hg/v4l-dvb-commits
Hello, On Fri, Jan 22, 2010 at 6:33 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: Igor M. Liplianin wrote: Mauro, Please pull from http://mercurial.intuxication.org/hg/v4l-dvb-commits for the following 5 changesets: 01/05: Add Support for DVBWorld DVB-S2 PCI 2004D card http://mercurial.intuxication.org/hg/v4l-dvb-commits?cmd=changeset;node=199213295c11 02/05: Compro S350 GPIO change http://mercurial.intuxication.org/hg/v4l-dvb-commits?cmd=changeset;node=84347195a02c 03/05: dm1105: connect splitted else-if statements http://mercurial.intuxication.org/hg/v4l-dvb-commits?cmd=changeset;node=cd9e72ee99c4 04/05: dm1105: use dm1105_dev dev instead of dm1105dvb http://mercurial.intuxication.org/hg/v4l-dvb-commits?cmd=changeset;node=5cb9c8978917 05/05: dm1105: use macro for read/write registers http://mercurial.intuxication.org/hg/v4l-dvb-commits?cmd=changeset;node=6ed71bd9d32b dvb/dm1105/Kconfig | 1 dvb/dm1105/dm1105.c | 539 +- video/saa7134/saa7134-cards.c | 4 3 files changed, 285 insertions(+), 259 deletions(-) applied on -git, thanks. Applied on -hg tree, thanks! Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://linuxtv.org/hg/~dougsland/v4l-dvb
Hello Mauro, Please pull from http://linuxtv.org/hg/~dougsland/v4l-dvb for the following: - cx23888-ir: fix kfifo erros for kernels 2.6.33 - meye: fix kfifo errors for kernels 2.6.33 Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Fix for breakage caused by kfifo backport
Hello Andy, On 01/15/2010 10:00 AM, Andy Walls wrote: Mauro, At http://linuxtv.org/hg/~awalls/cx23885-ir2 I have a change checked in to fix the v4l-dvb compilation breakage for kernels less than 2.6.33 cause by the kfifo API change. I have fixed both the cx23885 and meye driver so they compile again for older kernels. All the changes in this repo are OK to PULL as is, even though I haven't finished all the changes for the TeVii S470 IR (I was planning on a PULL request late this evening EST). You can also just cherry pick the one that fixes the kfifo problem if you want. [I was unaware of the timing of the backport, but since it was stopping me from working, I fixed it as I thought appropriate. Ouch, I was expecting to send the pull request for these changes before. I have created the exactly same patches. Anyway, good that we have these backports done. Please feel free to contact me on any backport changes that have my fingerprints all over it, with which you would like help. I'd like to help minimize the impact to users, testers, and developers, who may not have the bleeding edge kernel - or at least the impact to me ;) ] Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://linuxtv.org/hg/~dougsland/miro
Hello Mauro, Please pull from http://linuxtv.org/hg/~dougsland/miro for the following: - Add header to make radio-miro compatible with kernel 2.6.33 Cheers Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Nova-T 500 Dual DVB-T
Hello Yves, On 12/20/2009 03:21 AM, Yves wrote: Hi, I have a Nova-T 500 Dual DVB-T card that used to work very well under Mandriva 2008.1 (kernel 2.6.24.7). I moved to Mandriva 2009.1, then 2010.0 (kernel 2.6.31.6) and it doesn't work well any more. Scan can't find channels. I tried hading options dvb-usb-dib0700 force_lna_activation=1 in /etc/modprobe.conf. It improve just a bit. Scan find only a few channels. If I revert to Mandriva 2008.1 (in another partition), all things are good (without adding anything in modprobe.conf). Is there a new version of the driver (dvb_usb_dib0700) that correct this behavior. If not, how to install the driver from kernel 2.6.24.7 in kernel 2.6.31.6 ? Please try the current driver available at v4l/dvb develpment tree and share your results here. hg clone http://linuxtv.org/hg/v4l-dvb make make rmmod make install Finally, just restart your machine and test your favourite application. For additional info: http://www.linuxtv.org/wiki/index.php/How_to_Obtain,_Build_and_Install_V4L-DVB_Device_Drivers Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Pinnacle Hybrid Pro Stick USB scan problems
Hi Andreas, On 12/19/2009 06:46 AM, Andreas Lunderhage wrote: There is a missing header file in the repo... /home/lunderhage/v4l-dvb/v4l/radio-miropcm20.c:20:23: error: sound/aci.h: No such file or directory Can someone push that file into the repo or send it to me, please? Thanks for your report. Please add into v4l/versions.txt file: [2.6.33] RADIO_MIROPCM20 then make distclean make make rmmod make install Cheers Douglas BR /Andreas Devin Heitmueller wrote: On Mon, Dec 14, 2009 at 2:05 PM, Andreas Lunderhage lunderh...@home.se wrote: Hi, I have problems scanning with my Pinnacle Hybrid Pro Stick (320E). When using the scan command, it finds the channels in the first mux in the mux file but it fails to tune the next ones. If I use Kaffeine to scan, it gives the same result but I can also see that the signal strength shows 99% on those muxes it fails to scan. I thinks this is a problem with the tuning since if I watch one channel and switch to another (on another mux), it fails to tune. If I stop the viewing of the current channel first, then it will succeed tuning the next. I'm running Ubuntu 9.04 32-bit (kernel 2.6.28-17-generic) with the code built from the repository today. I'm also running Ubuntu 9.10 64-bit (kernel 2.6.31-16) (on another machine), but it gives the same problem. First, make sure you are running the latest v4l-dvb code (instructions at http://linuxtv.org/repo), and then try commenting out line 181 of em28xx-cards.c and see if that fixes the issue. Devin -- video4linux-list mailing list Unsubscribe mailto:video4linux-list-requ...@redhat.com?subject=unsubscribe https://www.redhat.com/mailman/listinfo/video4linux-list -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://linuxtv.org/hg/~dougsland/v4l-dvb
Hello Mauro, Please pull from http://linuxtv.org/hg/~dougsland/v4l-dvb for the following: - radio-tea5764: Correct size given to memsetdefault - uvc: Correct size given to memset - radio-sf16fmi: add autoprobing - radio-sf16fmi: fix mute, add SF16-FMP to texts - vpif: move vpif_remove to .devexit - vpfe_capture: move vpfe_remove to .devexit - sh_mobile_ceu_camera: don't use __exit_p to wrap sh_mobile_ceu_remove - vpss: move vpss_remove to .devexit - Use dev-bus_id instead of dev_name in pre 2.6.26 kernels - bttv: fix MODULE_PARM_DESC for i2c_debug and i2c_hw - radio-si470x: support PM functions - radio-si470x: support RDS on si470x i2c driver - radio-si470x: move some file operations to common file - videobuf_dma_contig_user_get() for non-aligned offsets - bttv: add i2c addr for old WinTV card to IR probe list - ov511.c typo: lock = unlock - pms.c: fix use of KERNEL_VERSION - cpia2: use __stringify macro. - vpif_display/saa7134-alsa/quickcam_messenger: Move dereference after NULL test - PWC: parameter trace is only available in debug Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://www.linuxtv.org/hg/~dougsland/v4l-dvb
Hello Mauro, Please pull from http://www.linuxtv.org/hg/~dougsland/v4l-dvb for the following: - radio-mr800: set radio frequency only upon success - radio-mr800: simplify device warnings - radio-mr800: preserve radio state during suspend/resume - radio-mr800: fix behavior of set_stereo function - radio-mr800: ensure the radio is initialized to a consistent state - radio-mr800: remove device initialization from open/close - radio-mr800: fix potential use after free - radio-mr800: remove device removed indicator - radio-mr800: simplify locking in ioctl callbacks - radio-mr800: simplify access to amradio_device - radio-mr800: remove unnecessary local variable - radio-mr800: simplify error paths in usb probe callback - radio-mr800: simplify video_device allocation - radio-mr800: implement proper locking Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC/RFT 0/14] radio-mr800 patch series
Hello Alexey, On Wed, 23 Sep 2009 03:43:55 +0400 Alexey Klimov klimov.li...@gmail.com wrote: On Tue, Sep 22, 2009 at 5:06 AM, David Ellingsworth da...@identd.dyndns.org wrote: On Mon, Sep 21, 2009 at 8:03 PM, Alexey Klimov klimov.li...@gmail.com wrote: Hello, David On Mon, Sep 14, 2009 at 11:09 PM, Alexey Klimov klimov.li...@gmail.com wrote: Hello David, On Sun, Sep 13, 2009 at 7:22 AM, David Ellingsworth da...@identd.dyndns.org wrote: What follow is a series of patches to clean up the radio-mr800 driver. I do _not_ have access to this device so these patches need to be tested. These patches should apply to Mauro's git tree and against the 2.6.31 release kernel. The patches in this series are as follows: 01. radio-mr800: implement proper locking 02. radio-mr800: simplify video_device allocation 03. radio-mr800: simplify error paths in usb probe callback 04. radio-mr800: remove an unnecessary local variable 05. radio-mr800: simplify access to amradio_device 06. radio-mr800: simplify locking in ioctl callbacks 07. radio-mr800: remove device-removed indicator 08. radio-mr800: fix potential use after free 09. radio-mr800: remove device initialization from open/close 10. radio-mr800: ensure the radio is initialized to a consistent state 11. radio-mr800: fix behavior of set_radio function 12. radio-mr800: preserve radio state during suspend/resume 13. radio-mr800: simplify device warnings 14. radio-mr800: set radio frequency only upon success The first 7 in this series are the same as those submitted in my last series and will not be resent. The remaining 7 patches in this series will be sent separately for review. I applied your patches and tested radio device. Radio works fine, but unfortunately sudden disconnect while playing radio with gnomeradio creates troubles. I see such oops in dmesg: radio_mr800: version 0.11-david AverMedia MR 800 USB FM radio driver usb 2-2: new low speed USB device using ohci_hcd and address 16 usb 2-2: New USB device found, idVendor=07ca, idProduct=b800 usb 2-2: New USB device strings: Mfr=1, Product=2, SerialNumber=0 usb 2-2: Product: AVerMedia USB Radio usb 2-2: Manufacturer: AVerMedia Technologies usb 2-2: configuration #1 chosen from 1 choice radio-mr800 2-2:1.0: Non-NULL drvdata on register usb 2-2: USB disconnect, address 16 BUG: unable to handle kernel NULL pointer dereference at 009f IP: [8119222b] dev_set_drvdata+0x25/0x30 PGD 3c0e1067 PUD 33b1d067 PMD 0 Oops: 0002 [#1] SMP last sysfs file: /sys/devices/pci:00/:00:02.0/usb2/2-2/2-2:1.0/uevent CPU 1 Modules linked in: radio_mr800 v4l2_common videodev v4l1_compat v4l2_compat_ioctl32 nls_iso8859_1 nls_cp437 vfat fat usb_storage nls_utf8 cifs ext2 ipt_MASQUERADE iptable_nat nf_nat nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 ip_tables x_tables ppp_async crc_ccitt ppp_generic slhc cpufreq_powersave powernow_k8 freq_table snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device snd_pcm_oss snd_mixer_oss reiserfs usbhid hid snd_hda_codec_analog snd_hda_intel ohci_hcd ehci_hcd snd_hda_codec snd_hwdep snd_pcm snd_timer nvidia(P) snd usbcore soundcore snd_page_alloc rtc_cmos sg rtc_core rtc_lib i2c_nforce2 forcedeth e100 nls_base k8temp mii i2c_core hwmon thermal button [last unloaded: v4l2_compat_ioctl32] Pid: 11790, comm: gnomeradio Tainted: P 2.6.31 #12 System Product Name RIP: 0010:[8119222b] [8119222b] dev_set_drvdata+0x25/0x30 RSP: 0018:880031741e28 EFLAGS: 00010206 RAX: 0017 RBX: 88003c3a4030 RCX: 8109458a RDX: RSI: RDI: 88003c3a4030 RBP: R08: R09: R10: 880029391e70 R11: 0246 R12: 81349ec0 R13: 880029391e70 R14: 8800173d7000 R15: 88003fac8300 FS: 7fa0f88e3750() GS:88000290() knlGS:f7327a10 CS: 0010 DS: ES: CR0: 80050033 CR2: 009f CR3: 3165c000 CR4: 06e0 DR0: DR1: DR2: DR3: DR6: 0ff0 DR7: 0400 Process gnomeradio (pid: 11790, threadinfo 88003174, task 88003bcc5820) Stack: 8800173d7000 88003c3a5a60 88003c3a5a60 a0c603cb 0 88003c3a5800 a0c603e5 88003c3a5800 88003e400890 0 81349ec0 a000d5c7 8800331593c0 8118fb37 Call Trace: [a0c603cb] ? v4l2_device_disconnect+0x13/0x1c [videodev] [a0c603e5] ? v4l2_device_unregister+0x11/0x4b [videodev] [a000d5c7] ? usb_amradio_video_device_release+0x11/0x26 [radio_mr800] [8118fb37] ? device_release+0x41/0x6a [81118bf3] ? kobject_release+0x48/0x5e [81118bab] ? kobject_release+0x0/0x5e
[PULL] http://linuxtv.org/hg/~dougsland/v4l-dvb
Hello Mauro, Please pull from http://www.linuxtv.org/hg/~dougsland/v4l-dvb for the following: - go7007: sound needs compat.hdefault tip - go7007: convert printks to v4l2_info - s2250-board: Implement brightness and contrast controls - s2250-board: Fix memory leaks - go7007: Implement vidioc_g_std and vidioc_querystd - go7007: Merge struct gofh and go declarations - go7007: Fix mpeg controls - go7007: Fix whitespace and line lengths - go7007: Updates to Kconfig and Makefile - radio-si4713: remove #include linux/version.h - video: initial support for ADV7180 - kzalloc failure ignored in au8522_probe() - GSPCA: kmalloc failure ignored in sd_start() - kmalloc failure ignored in lgdt3304_attach() and s921_attach() - kmalloc failure ignored in m920x_firmware_download() - Add support for Compro VideoMate E800 (DVB-T part only) - FM TX: si4713: Kconfig: Fixed two typos. - uvc: introduce missing kfree - Change tuner type of BeholdTV cards Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://linuxtv.org/hg/~dougsland/em28xx
Hello Mauro, Please pull from http://linuxtv.org/hg/~dougsland/em28xx for the following: - em28xx-cards: Add vendor/product id for Kworld DVD Maker 2 Thanks to C Western l...@c-m-w.me.uk for reporting this board. Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://linuxtv.org/hg/~dougsland/video4linux
Hello Mauro, Please pull from http://www.linuxtv.org/hg/~dougsland/video4linux for the following: - Fix test of bandwidth range in cx22700_set_tps() - support AverMedia Studio 505 - FM1216MK5 FM radio Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://linuxtv.org/hg/~dougsland/empire/
Hello Mauro, Please pull from http://linuxtv.org/hg/~dougsland/empire/ for the following: - em28xx: fix empire auto-detect Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://linuxtv.org/hg/~dougsland/v4l-dvb
Hello Mauro, On Tue, 28 Jul 2009 12:04:48 -0300 Douglas Schilling Landgraf dougsl...@gmail.com wrote: Hello Mauro, Please pull from http://linuxtv.org/hg/~dougsland/v4l-dvb for the following: - saa7134: fix lock imbalancedefault tip - af9015: Fix for crash in dvb-usb-af9015 - v4l doc: fix cqcam source code path - stv680: kfree called before usb_kill_urb - ir-kbd-i2c: Add support for Z8F0811/Hauppage IR transceivers - cx18: Add i2c initialization for Z8F0811/Hauppage IR transceivers - ir-kbd-i2c: Allow use of ir-kdb-i2c internal get_key funcs and set ir_type - ir-kbd-i2c: Remove superfulous inlines - ir-kbd-i2c: fix spaces - gspca - sn9c20x: Fix up i2c_r functions Added to the above list: hdpvr: fix lock imbalances Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH repost2 1/2] V4L: hdpvr, fix lock imbalances
Hello Jiri,
On Thu, 30 Jul 2009 23:49:48 +0200
Jiri Slaby jirisl...@gmail.com wrote:
Hrm, nobody picked these up, twice. Maybe this time :)?
--
Thanks for this email. Both patches are applied to devel tree.
Cheers,
Douglas
There are many lock imbalances in this driver. Fix all found.
Signed-off-by: Jiri Slaby jirisl...@gmail.com
---
drivers/media/video/hdpvr/hdpvr-core.c | 12 ++--
drivers/media/video/hdpvr/hdpvr-video.c |6 --
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/media/video/hdpvr/hdpvr-core.c
b/drivers/media/video/hdpvr/hdpvr-core.c index 188bd5a..1c9bc94 100644
--- a/drivers/media/video/hdpvr/hdpvr-core.c
+++ b/drivers/media/video/hdpvr/hdpvr-core.c
@@ -126,7 +126,7 @@ static int device_authorization(struct
hdpvr_device *dev) char *print_buf = kzalloc(5*buf_size+1,
GFP_KERNEL); if (!print_buf) {
v4l2_err(dev-v4l2_dev, Out of memory\n);
- goto error;
+ return retval;
}
#endif
@@ -140,7 +140,7 @@ static int device_authorization(struct
hdpvr_device *dev) if (ret != 46) {
v4l2_err(dev-v4l2_dev,
unexpected answer of status request, len
%d\n, ret);
- goto error;
+ goto unlock;
}
#ifdef HDPVR_DEBUG
else {
@@ -163,7 +163,7 @@ static int device_authorization(struct
hdpvr_device *dev) v4l2_err(dev-v4l2_dev, unknown firmware version
0x%x\n, dev-usbc_buf[1]);
ret = -EINVAL;
- goto error;
+ goto unlock;
}
response = dev-usbc_buf+38;
@@ -188,10 +188,10 @@ static int device_authorization(struct
hdpvr_device *dev) 1);
v4l2_dbg(MSG_INFO, hdpvr_debug, dev-v4l2_dev,
magic request returned %d\n, ret);
- mutex_unlock(dev-usbc_mutex);
retval = ret != 8;
-error:
+unlock:
+ mutex_unlock(dev-usbc_mutex);
return retval;
}
@@ -350,6 +350,7 @@ static int hdpvr_probe(struct usb_interface
*interface,
mutex_lock(dev-io_mutex);
if (hdpvr_alloc_buffers(dev, NUM_BUFFERS)) {
+ mutex_unlock(dev-io_mutex);
v4l2_err(dev-v4l2_dev,
allocating transfer buffers failed\n);
goto error;
@@ -381,7 +382,6 @@ static int hdpvr_probe(struct usb_interface
*interface,
error:
if (dev) {
- mutex_unlock(dev-io_mutex);
/* this frees allocated memory */
hdpvr_delete(dev);
}
diff --git a/drivers/media/video/hdpvr/hdpvr-video.c
b/drivers/media/video/hdpvr/hdpvr-video.c index ccd47f5..5937de2
100644 --- a/drivers/media/video/hdpvr/hdpvr-video.c
+++ b/drivers/media/video/hdpvr/hdpvr-video.c
@@ -375,6 +375,7 @@ static int hdpvr_open(struct file *file)
* in resumption */
mutex_lock(dev-io_mutex);
dev-open_count++;
+ mutex_unlock(dev-io_mutex);
fh-dev = dev;
@@ -383,7 +384,6 @@ static int hdpvr_open(struct file *file)
retval = 0;
err:
- mutex_unlock(dev-io_mutex);
return retval;
}
@@ -519,8 +519,10 @@ static unsigned int hdpvr_poll(struct file
*filp, poll_table *wait)
mutex_lock(dev-io_mutex);
- if (video_is_unregistered(dev-video_dev))
+ if (video_is_unregistered(dev-video_dev)) {
+ mutex_unlock(dev-io_mutex);
return -EIO;
+ }
if (dev-status == STATUS_IDLE) {
if (hdpvr_start_streaming(dev)) {
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://linuxtv.org/hg/~dougsland/video4linux
Hello Andy, On Tue, 28 Jul 2009 07:40:24 -0400 Andy Walls awa...@radix.net wrote: On Mon, 2009-07-27 at 22:28 -0300, Douglas Schilling Landgraf wrote: Hello Mauro, Please pull from http://linuxtv.org/hg/~dougsland/video4linux for the following: - saa7134: fix lock imbalance - Fix for crash in dvb-usb-af9015 - v4l doc: fix cqcam source code path - stv680: kfree called before usb_kill_urb - ir-kbd-i2c: Add support for Z8F0811/Hauppage IR transceivers - cx18: Add i2c initialization for Z8F0811/Hauppage IR transceivers Hi, Looking through the web interface, this #define looks like it might have been imported with a problem: http://linuxtv.org/hg/~dougsland/video4linux/rev/81939abc76b1#l2.23 please ensure there is a space or tab between the symbol and the open parenthesis: #define CX18_HW_Z8F0811_IR_HAUP (CX18_HW_Z8F0811_IR_RX_HAUP | \ CX18_HW_Z8F0811_IR_TX_HAUP) This might just be a web interface rendering problem. Weird thing, all patches applied clean as usually I do. Anyway, you are right and I am going to create a new tree. Thanks for pointing that. Mauro: Please *do not* pull from this tree. Cheers, Douglas Thanks, Andy - ir-kbd-i2c: Allow use of ir-kdb-i2c internal get_key funcs and set ir_type - ir-kbd-i2c: Remove superfulous inlines - gspca - sn9c20x: Fix up i2c_r functions Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://linuxtv.org/hg/~dougsland/v4l-dvb
Hello Mauro, Please pull from http://linuxtv.org/hg/~dougsland/v4l-dvb for the following: - saa7134: fix lock imbalancedefault tip - af9015: Fix for crash in dvb-usb-af9015 - v4l doc: fix cqcam source code path - stv680: kfree called before usb_kill_urb - ir-kbd-i2c: Add support for Z8F0811/Hauppage IR transceivers - cx18: Add i2c initialization for Z8F0811/Hauppage IR transceivers - ir-kbd-i2c: Allow use of ir-kdb-i2c internal get_key funcs and set ir_type - ir-kbd-i2c: Remove superfulous inlines - ir-kbd-i2c: fix spaces - gspca - sn9c20x: Fix up i2c_r functions Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://linuxtv.org/hg/~dougsland/video4linux
Hello Mauro, Please pull from http://linuxtv.org/hg/~dougsland/video4linux for the following: - saa7134: fix lock imbalance - Fix for crash in dvb-usb-af9015 - v4l doc: fix cqcam source code path - stv680: kfree called before usb_kill_urb - ir-kbd-i2c: Add support for Z8F0811/Hauppage IR transceivers - cx18: Add i2c initialization for Z8F0811/Hauppage IR transceivers - ir-kbd-i2c: Allow use of ir-kdb-i2c internal get_key funcs and set ir_type - ir-kbd-i2c: Remove superfulous inlines - gspca - sn9c20x: Fix up i2c_r functions Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://linuxtv.org/hg/~dougsland/v4l-dvb
Hello Mauro, Please pull from http://www.linuxtv.org/hg/~dougsland/v4l-dvb for the following: bttv and meye: Use PCI_VDEVICE radio-si470x: fix lock imbalance em28xx, fix lock imbalance adv7343: remove unused #include linux/version.h mt312: Fix checkpatch warnings remove redundant tests on unsigned ivtv-driver.c: Remove unnecessary semicolons Remove unnecessary semicolons cx18-fileops.c: Remove unnecessary semicolons Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://linuxtv.org/hg/~dougsland/video4linux
Hello Mauro, Please pull from http://linuxtv.org/hg/~dougsland/video4linux for the following: - dvb: Fix broken link in get_dvb_firmware for nxt2004 (A180) - tvp514x: try_count off by one - v4l: generate KEY_CAMERA instead of BTN_0 key events on input devices - se401: Fix unsafe use of sprintf with identical source/destination - usbvision-core.c: vfree does its own NULL check - dsbr100: change radio-muted to radio-status, update suspend/resume - dsbr100: no need to pass curfreq value to dsbr100_setfreq() - dsbr100: remove usb_dsbr100_open/close calls - dsbr100: remove radio-users counter - V4L: return -ENOMEM Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://linuxtv.org/hg/~dougsland/em28xx/
Hello Mauro, Please pull from http://www.linuxtv.org/hg/~dougsland/em28xx for the following: - em28xx: Add Kworld 315 entry - em28xx: set up tda9887_conf in em28xx_card_setup() Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] em28xx device mode detection based on endpoints
Hello Devin, On Mon, 1 Jun 2009 11:19:22 -0400 Devin Heitmueller dheitmuel...@kernellabs.com wrote: On Sat, May 23, 2009 at 11:05 AM, Markus Rechberger mrechber...@gmail.com wrote: Hi, On Sat, May 23, 2009 at 4:49 PM, Markus Rechberger mrechber...@gmail.com wrote: On Sat, May 23, 2009 at 4:04 PM, Markus Rechberger mrechber...@gmail.com wrote: Hi, for em28xx devices the device node detection can be based on the encoded endpoint address, for example EP 0x81 (USB IN, Interrupt), 0x82 (analog video EP), 0x83 (analog audio ep), 0x84 (mpeg-ts input EP). It is not necessary that digital TV devices have a frontend, the em28xx chip only specifies an MPEG-TS input EP. Following patch adds a check based on the Endpoints, although it might be extended that all devices match the possible devicenodes based on the endpoints, currently the driver registers an analog TV node by default for all unknown devices which is not necessarily correct, this patch disables the ATV node if no analog TV endpoint is available. attached patch fixes the deregistration, as well loads the em28xx-dvb module automatically as soon as an MPEG-TS endpoint was found. Signed-off-by: Markus Rechberger mrechber...@gmail.com best regards, Markus Hello Markus, I spent some time reviewing this patch, and the patch's content does not seem to match your description of its functionality. Further, this patch appears to be a combination of a number of several different changes, rather than being broken into separate patches. First off, I totally agree that the analog subsystem should not be loaded on devices such as em287[0-4]. I was going to do this work (using the chip id to determine analog support) but just had not had a chance to doing the necessary testing to ensure it did not break anything. The patch appears to be primarily for devices that are not supported in the kernel. In fact, the logic as written *only* gets used for unknown devices. Further, the code that doesn't create the frontend device has no application in the kernel. All devices currently in the kernel make use of the dvb frontend interface, so there is no practical application to loading the driver and setting up the isoc handlers but blocking access to the dvb frontend device. Aside from the code that selectively disables analog support, the patch only seems to advance compatibility with your userland em28xx framework while providing no benefit to the in-kernel driver. Regarding the possibility of custom firmware, we currently do not have any devices in the in-kernel driver that make use of custom firmware. If you could tell me how to check for custom firmware versus the default vendor firmware, I could potentially do a patch that uses the vendor registers unless custom firmware is installed, at which point we could have custom logic (such as using the endpoint definition). However, given there are no such devices in-kernel, this is not a high priority as far as I am concerned. For what it's worth, I did add an additional patch to allow the user to disable the 480Mbps check via a modprobe option (to avoid a regression for any of your existing customers), and I will be checking in the code to properly compute the isoc size for em2874/em2884 based on the vendor registers (even though there are currently no supported devices in the kernel that require it currently). However, I do not believe the patch you have proposed is appropriate for inclusion in the mainline kernel. Agree with you Devin. Also, the patch does a lot of changes instead of break it in several patches. Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://linuxtv.org/hg/~dougsland/v4l-dvb
Hello Mauro, Please pull from http://linuxtv.org/hg/~dougsland/v4l-dvb for the following: - em28xx: Fix for Slow Memory Leak - bt8xx: remove always false if Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv4 0 of 8] FM Transmitter (si4713) and another changes
Hello Eduardo, On Wed, 27 May 2009 12:35:47 +0300 Eduardo Valentin eduardo.valen...@nokia.com wrote: Hello all, I'm resending the FM transmitter driver and the proposed changes in v4l2 api files in order to cover the fmtx extended controls class. It is basically the same series of version #3. However I rewrote it to add the following comments: * Check kernel version for i2c helper function. Now the board data is passed not using i2c_board_info. This way all supported kernel versions can use the api. Besides that, the .s_config callback was added in core ops. * All patches are against v4l-dvb hg repository. Again, comments are welcome. I have a comment, please check some headers to avoid errors. Instead of: patch 05: #include media/linux/v4l2-device.h #include media/linux/v4l2-ioctl.h #include media/linux/v4l2-i2c-drv.h #include media/linux/v4l2-subdev.h patch 06: #include media/linux/v4l2-device.h #include media/linux/v4l2-common.h #include media/linux/v4l2-ioctl.h Please use: #include media/v4l2-device.h #include media/v4l2-ioctl.h #include media/v4l2-i2c-drv.h #include media/v4l2-subdev.h and #include media/v4l2-device.h #include media/v4l2-common.h #include media/v4l2-ioctl.h Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] uvc: Add Microsoft VX 500 webcam
Hello Laurent, On Mon, 20 Apr 2009 20:07:31 +0200 Laurent Pinchart laurent.pinch...@skynet.be wrote: Hi Douglas, On Wednesday 15 April 2009 15:48:08 Douglas Schilling Landgraf wrote: Hello Laurent, On Wed, 15 Apr 2009 11:46:52 +0200 Laurent Pinchart laurent.pinch...@skynet.be wrote: Hi Douglas, On Wednesday 15 April 2009 09:03:45 Douglas Schilling Landgraf wrote: Hello Laurent, Attached patch for the following: Added Microsoft VX 500 webcam to uvc driver. Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com Could you please send me the output of lsusb -v -d 045e:074a using usbutils 0.72 or newer (0.73+ preferred) ? usbutils-0.73-2 Have you tried the latest driver ? Yes The MINMAX quirk isn't required anymore for most cameras (although the two supported Microsoft webcams still need it, so I doubt it will work as-is). Indeed, attached new patch. The new patch shouldn't be needed at all, as it doesn't declare any quirk. The camera should work out of the box using the latest driver. It doesn't work to me. :-( Best regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] uvc: Add Microsoft VX 500 webcam
Hello Laurent, Attached patch for the following: Added Microsoft VX 500 webcam to uvc driver. Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com Thanks, Douglas uvc-microsoft-vx500.diff Description: Binary data
Re: [PATCH] uvc: Add Microsoft VX 500 webcam
Hello Laurent,
On Wed, 15 Apr 2009 11:46:52 +0200
Laurent Pinchart laurent.pinch...@skynet.be wrote:
Hi Douglas,
On Wednesday 15 April 2009 09:03:45 Douglas Schilling Landgraf wrote:
Hello Laurent,
Attached patch for the following:
Added Microsoft VX 500 webcam to uvc driver.
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com
Could you please send me the output of
lsusb -v -d 045e:074a
using usbutils 0.72 or newer (0.73+ preferred) ?
usbutils-0.73-2
Have you tried the latest driver ?
Yes
The MINMAX quirk isn't required
anymore for most cameras (although the two supported Microsoft
webcams still need it, so I doubt it will work as-is).
Indeed, attached new patch.
Thanks,
Douglas
Bus 002 Device 015: ID 045e:074a Microsoft Corp.
Device Descriptor:
bLength18
bDescriptorType 1
bcdUSB 2.00
bDeviceClass 239 Miscellaneous Device
bDeviceSubClass 2 ?
bDeviceProtocol 1 Interface Association
bMaxPacketSize064
idVendor 0x045e Microsoft Corp.
idProduct 0x074a
bcdDevice1.01
iManufacturer 2 Microsoft
iProduct1 Microsoft LifeCam
iSerial 0
bNumConfigurations 1
Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 569
bNumInterfaces 2
bConfigurationValue 1
iConfiguration 0
bmAttributes 0x80
(Bus Powered)
MaxPower 150mA
Interface Association:
bLength 8
bDescriptorType11
bFirstInterface 0
bInterfaceCount 2
bFunctionClass 14 Video
bFunctionSubClass 3 Video Interface Collection
bFunctionProtocol 0
iFunction 1 Microsoft LifeCam
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber0
bAlternateSetting 0
bNumEndpoints 1
bInterfaceClass14 Video
bInterfaceSubClass 1 Video Control
bInterfaceProtocol 0
iInterface 1 Microsoft LifeCam
VideoControl Interface Descriptor:
bLength13
bDescriptorType36
bDescriptorSubtype 1 (HEADER)
bcdUVC 1.00
wTotalLength 103
dwClockFrequency 15.00MHz
bInCollection 1
baInterfaceNr( 0) 1
VideoControl Interface Descriptor:
bLength 9
bDescriptorType36
bDescriptorSubtype 3 (OUTPUT_TERMINAL)
bTerminalID 2
wTerminalType 0x0101 USB Streaming
bAssocTerminal 0
bSourceID 5
iTerminal 0
VideoControl Interface Descriptor:
bLength26
bDescriptorType36
bDescriptorSubtype 6 (EXTENSION_UNIT)
bUnitID 4
guidExtensionCode {7033f028-1163-2e4a-ba2c-6890eb334016}
bNumControl 8
bNrPins 1
baSourceID( 0) 3
bControlSize1
bmControls( 0) 0x0f
iExtension 0
VideoControl Interface Descriptor:
bLength26
bDescriptorType36
bDescriptorSubtype 6 (EXTENSION_UNIT)
bUnitID 5
guidExtensionCode {3fae1228-d7bc-114e-a357-6f1edef7d61d}
bNumControl 8
bNrPins 1
baSourceID( 0) 4
bControlSize1
bmControls( 0) 0x00
iExtension 0
VideoControl Interface Descriptor:
bLength18
bDescriptorType36
bDescriptorSubtype 2 (INPUT_TERMINAL)
bTerminalID 1
wTerminalType 0x0201 Camera Sensor
bAssocTerminal 0
iTerminal 0
wObjectiveFocalLengthMin 0
wObjectiveFocalLengthMax 0
wOcularFocalLength0
bControlSize 3
bmControls 0x
VideoControl Interface Descriptor:
bLength11
bDescriptorType36
bDescriptorSubtype 5 (PROCESSING_UNIT)
Warning: Descriptor too short
bUnitID 3
bSourceID 1
wMaxMultiplier 0
bControlSize2
bmControls 0x053f
Brightness
Contrast
Hue
Saturation
Sharpness
Gamma
Backlight Compensation
Power Line Frequency
iProcessing 0
Re: [PATCH 1/1] em28xx: Fix for Slow Memory Leak
Hello Robert,
On Tue, 14 Apr 2009 15:17:16 -0400
Robert Krakora rob.krak...@messagenetsystems.com wrote:
em28xx: Fix for Slow Memory Leak
Thanks, I am going to test and commit your patch.
Cheers,
Douglas
From: Robert Krakora rob.krak...@messagenetsystems.com
Test Code: (Provided by Douglas)
v4l-dvb/v4l2-apps/test/stress-buffer.c
The audio DMA area was never being freed and would slowly leak over
time as the v4l device was opened and closed by an application.
Thanks again to Douglas for generating the test code to help locate
memory leaks!!!
Priority: normal
Signed-off-by: Robert Krakora rob.krak...@messagenetsystems.com
diff -r 5567e82c34a0 linux/drivers/media/video/em28xx/em28xx-audio.c
--- a/linux/drivers/media/video/em28xx/em28xx-audio.c Tue Mar 31
07:24:14 2009 -0300
+++ b/linux/drivers/media/video/em28xx/em28xx-audio.c Tue Apr 14
10:16:45 2009 -0400
@@ -278,6 +278,7 @@
#endif
dprintk(Allocating vbuffer\n);
+
if (runtime-dma_area) {
if (runtime-dma_bytes size)
return 0;
@@ -385,6 +386,18 @@
mutex_lock(dev-lock);
dev-adev.users--;
em28xx_audio_analog_set(dev);
+ if (substream == dev-adev.capture_pcm_substream)
+ {
+ if (substream substream-runtime
substream-runtime-dma_area) {
+ dprintk(freeing\n);
+ vfree(substream-runtime-dma_area);
+ substream-runtime-dma_area = NULL;
+ }
+ }
+ else
+ {
+ em28xx_errdev(substream(%p) !=
dev-adev.capture_pcm_substream(%p)\n, substream,
dev-adev.capture_pcm_substream);
+ }
mutex_unlock(dev-lock);
return 0;
--
To unsubscribe from this list: send the line unsubscribe
linux-media in the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [linux-dvb] Multiple em28xx devices
Hello rvf16, On Thu, 09 Apr 2009 17:05:36 +0300 rvf16 rv...@yahoo.gr wrote: Hello. I am trying to use two Terratec Cinergy Hybrid T USB XS FM tuners, at the same time, on the same system. Both work great when used solely. When used simultaneously the second one gives the following error : v4l2: unable to open '/dev/video1': No space left on device I am using the em28xx-new-b2e841c05e94 driver from http://mcentral.de/hg/~mrec/em28xx-new on a Fedora 6 system. I have opened this topic in the em28xx mailing list http://mcentral.de/pipermail/em28xx/ but it seems it is not maintained any more. According to comments on relevant problems (the following is for spca5xx driver for cameras with same problem) : --- When other USB devices are present on the same host controller bus as the camera, the bandwidth requirements of the spca5xx driver are not being met, with some hardware configurations. The spca5xx driver is asking for more bandwidth than is available which results in these error messages. --- We are, under these circumstances, advised to either insert the device in another USB socket or even install a PCI card with extra USB sockets so that the device ends up in different bus. I tried to insert the second device in another usb socket but it always ends up at the same bus with the first one : #lsusb Bus 005 Device 014: ID 0ccd:0072 TerraTec Electronic GmbH Bus 005 Device 015: ID 0ccd:0072 TerraTec Electronic GmbH Bus 005 Device 001: ID : Bus 002 Device 006: ID 046d:c50e Logitech, Inc. MX-1000 Cordless Mouse Receiver Bus 002 Device 001: ID : Bus 004 Device 001: ID : Bus 003 Device 001: ID : Bus 001 Device 001: ID : which happens to a lot of people from what i have seen. As this is a laptop with 4 USB sockets : # lspci | grep USB 00:1d.0 USB Controller: Intel Corporation 82801G (ICH7 Family) USB UHCI #1 (rev 01) 00:1d.1 USB Controller: Intel Corporation 82801G (ICH7 Family) USB UHCI #2 (rev 01) 00:1d.2 USB Controller: Intel Corporation 82801G (ICH7 Family) USB UHCI #3 (rev 01) 00:1d.3 USB Controller: Intel Corporation 82801G (ICH7 Family) USB UHCI #4 (rev 01) 00:1d.7 USB Controller: Intel Corporation 82801G (ICH7 Family) USB2 EHCI Controller (rev 01) i cannot install a PCI card with extra USB sockets so there goes workaround number two. In spca5xx case a developer patched the driver so that the bandwidth was throttled in such a way that two devices used simultaneously would never exceed maximum. Can that be done with em28xx? If not, is there any other workaround to this problem? Please use upstream repository, we do not support sources from http://mcentral.de/hg/~mrec/em28xx-new this is a parallel project. For additional info how to download upstream tree see: http://www.linuxtv.org/wiki/index.php/How_to_Obtain%2C_Build_and_Install_V4L-DVB_Device_Drivers Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [linux-dvb] Multiple em28xx devices
Hello Devin, On Thu, 9 Apr 2009 10:20:33 -0400 Devin Heitmueller devin.heitmuel...@gmail.com wrote: On Thu, Apr 9, 2009 at 10:14 AM, Douglas Schilling Landgraf Please use upstream repository, we do not support sources from http://mcentral.de/hg/~mrec/em28xx-new this is a parallel project. For additional info how to download upstream tree see: http://www.linuxtv.org/wiki/index.php/How_to_Obtain%2C_Build_and_Install_V4L-DVB_Device_Drivers Cheers, Douglas Douglas, Unless he is willing to do without dvb support, he's not going to be able to use the upstream em28xx driver with the Terratec XS. The idea behind that email is to inform that we do not support any parallel project. I've got a device being mailed to me, at which point I will be able to get the dvb support working. Great, good news! Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://www.linuxtv.org/hg/~dougsland/v4l-dvb
Hello Mauro, Please pull from http://www.linuxtv.org/hg/~dougsland/v4l-dvb for the following: - em28xx: Add EmpireTV board support - em28xx: fix typo em28xx_errdev message - get_dvb_firmware: trivial url change Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://www.linuxtv.org/hg/~dougsland/v4l-dvb
Hello Mauro, This is a new request pull to rewrite_eeprom tool. I have added validations, warning messages and a backup feature. Since I don't have any em2874/em2884 device I am not able to implement any addicional validation but it seems already safe enough. for these devices too. - v4l2-apps/util: Add rewrite_eeprom tool Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://www.linuxtv.org/hg/~dougsland/em28xx
Hello Devin, On Tue, 31 Mar 2009 16:36:47 -0400 Devin Heitmueller devin.heitmuel...@gmail.com wrote: Hello Douglas, This patch looks pretty good. My only comment is to ask that you please not mix large patches like this with whitespace changes in the same changeset. It makes it much harder to review the patch when functional changes are accompanied by stuff like this: - *vfd = *template; - vfd-minor = -1; - vfd-parent = dev-udev-dev; - vfd-release = video_device_release; - vfd-debug = video_debug; + + *vfd = *template; + vfd-minor = -1; + vfd-v4l2_dev = dev-v4l2_dev; + vfd-release = video_device_release; + vfd-debug = video_debug; - -void em28xx_i2c_call_clients(struct em28xx *dev, unsigned int cmd, void *arg); void em28xx_do_i2c_scan(struct em28xx *dev); -int em28xx_i2c_register(struct em28xx *dev); -int em28xx_i2c_unregister(struct em28xx *dev); +int em28xx_i2c_register(struct em28xx *dev); +int em28xx_i2c_unregister(struct em28xx *dev); Every instance of code like the above requires me to look at it closely and make a determination whether the content *actually* changed. Ok, agreed. Thanks for reviewing! Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://linuxtv.org/hg/~dougsland/v4l-dvb
Hello Hermann. On Thu, 12 Mar 2009 01:44:30 +0100 hermann pitton hermann-pit...@arcor.de wrote: Hi, Am Mittwoch, den 11.03.2009, 14:44 -0300 schrieb Douglas Schilling Landgraf: Hello, On Sun, 08 Mar 2009 01:45:36 +0100 hermann pitton hermann-pit...@arcor.de wrote: Hi! Am Samstag, den 07.03.2009, 19:19 -0500 schrieb Andy Walls: On Sat, 2009-03-07 at 19:06 -0500, Andy Walls wrote: On Sat, 2009-03-07 at 18:26 -0500, Devin Heitmueller wrote: On Sat, Mar 7, 2009 at 5:45 PM, Douglas Schilling Landgraf dougsl...@gmail.com wrote: Hi Mauro, Please pull from: http://linuxtv.org/hg/~dougsland/v4l-dvb for the following: - v4l2-apps/util: Add rewrite_eeprom tool Modules this script is known to work with: em28xx and saa7134 Thanks, Douglas -- Added to the same tree new version of script: - A few improvements to initial version of script - Added validations to avoid issues to users - Added a huge red warning message IMO, the current version will cover those suggestions. If not, please let me know. Thanks everyone, Douglas seems to be safe to me on the saa7134 driver, but those pointing to further risks are welcome. Good to know! The dual saa7134 PCI bridge devices in need of a correct eeprom are out of the game in the original dual/triple slots, even first and second bridge might be swapped compared to the m$ driver and so on. Those tools are around anyway, I remember the case of a manipulated eeprom we alredy had. (with one of Dmitry's devices, IIRC) On some mobo's with lots of saa713X devices the eeprom readout can be flaky sometimes. If it is only a single device likely the PSU is becoming faulty, just to remember to check against that too. If there is a known list of critical eeprom types and about cases we disabled the write protection, this would be good to know as well. Agreed. Thanks for your comments! Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://www.linuxtv.org/hg/~dougsland/em28xx
Hello Mauro, Please pull from http://www.linuxtv.org/hg/~dougsland/em28xx for the following: - em28xx: convert to v4l2_subdev Thanks to Hans Verkuil hverk...@xs4all.nl for helping this conversion. Boards tested: - WinTV HVR-900 - PlayTV Box4 - SIIG AVTuner-PVR - Pixelview Prolink PlayTV USB 2.0 - Hauppauge WinTV HVR 850 - Pinnacle Dazzle DVC 90 - Pinnacle Dazzle DVC 101 - Pinnacle Dazzle DVC 107 - Gadmei UTV310 Changes: # linux/drivers/media/video/em28xx/em28xx-cards.c | 143 +++- # linux/drivers/media/video/em28xx/em28xx-core.c |9 - # linux/drivers/media/video/em28xx/em28xx-i2c.c | 72 # linux/drivers/media/video/em28xx/em28xx-video.c | 78 ++--- # linux/drivers/media/video/em28xx/em28xx.h | 10 + Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://linuxtv.org/hg/~dougsland/v4l-dvb
Hello, On Sun, 08 Mar 2009 01:45:36 +0100 hermann pitton hermann-pit...@arcor.de wrote: Hi! Am Samstag, den 07.03.2009, 19:19 -0500 schrieb Andy Walls: On Sat, 2009-03-07 at 19:06 -0500, Andy Walls wrote: On Sat, 2009-03-07 at 18:26 -0500, Devin Heitmueller wrote: On Sat, Mar 7, 2009 at 5:45 PM, Douglas Schilling Landgraf dougsl...@gmail.com wrote: Hi Mauro, Please pull from: http://linuxtv.org/hg/~dougsland/v4l-dvb for the following: - v4l2-apps/util: Add rewrite_eeprom tool Modules this script is known to work with: em28xx and saa7134 Thanks, Douglas -- Added to the same tree new version of script: - A few improvements to initial version of script - Added validations to avoid issues to users - Added a huge red warning message IMO, the current version will cover those suggestions. If not, please let me know. Thanks everyone, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://linuxtv.org/hg/~dougsland/v4l-dvb
Hello everyone, First of all, thanks for your comments guys. On Sat, 7 Mar 2009 18:26:05 -0500 Devin Heitmueller devin.heitmuel...@gmail.com wrote: On Sat, Mar 7, 2009 at 5:45 PM, Douglas Schilling Landgraf dougsl...@gmail.com wrote: Hi Mauro, Please pull from: http://linuxtv.org/hg/~dougsland/v4l-dvb for the following: - v4l2-apps/util: Add rewrite_eeprom tool Modules this script is known to work with: em28xx and saa7134 Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Wow, this script really scares the crap out of me. Is this something we *really* need? IMO yes. The first version of this script was created because an em28xx user sent an email to me and Mauro asking *help* since his eeprom was lost and he would like to recover it. A few time later, his board was recovered by [this script] and now his device is working and supported by the upstream driver. If so, it needs to have a HUGE WARNING explaining the few cases that it should actually be used, and it should also explicitly block usage against chipsets except for those that have been validated to work. Well, I have read several good ideas from you and others developers. For now, it's very easy to implement such warning message, no problem from my side. Do you really want to be responsible for the first time some unknowing user runs this against cx88 or some other chipset you never tried it against and it bricks their board? As Andy already sent, it's a *GPL* code. Of course, nobody wants to fell bad because a user replaced his eeprom. We are here because we want to help them. So, let's add such warning message. Also, this won't work against newer em28xx chipsets like the em2874 and em2884, which have 16-bit eeproms. And if you corrupt the eeprom on the em2874, you actually *WILL* brick the device (which is why I removed the code that reads the eeprom in the first place). Ok, I will add a comment to the script for such chipsets since I don't have those here for test now. On the other hand, I have tested with several older em28xx devices replacing a *good* eeprom with *wrong* eeprom and then replaced it again with a good one.. no bad affects, device is working fine like new. *Of course, neither me or Mauro we DO NOT recommend nobody to run this script if it's not really needed (like: erased/wrong eeprom cases).* Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://linuxtv.org/hg/~dougsland/v4l-dvb/
On Thu, 26 Feb 2009 15:28:11 -0300 Mauro Carvalho Chehab mche...@infradead.org wrote: On Sun, 22 Feb 2009 12:50:34 -0500 CityK ci...@rogers.com wrote: Douglas Schilling Landgraf wrote: Hi Mauro, Please pull from http://linuxtv.org/hg/~dougsland/v4l-dvb/ for the following: - v4l2-apps: Add parser for USB snoops captured from SniffUSB 2.0 It is not clear to me why this ended up in /v4l2-apps/test, as opposed to /v4l2/util -- can someone comment? Thanks. You're right. This one is at the wrong place. I'll move it. Thanks Mauro/CityK! Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: POLL: for/against dropping support for kernels 2.6.22
Hello Hans, On Sun, 22 Feb 2009 11:15:01 +0100 Hans Verkuil hverk...@xs4all.nl wrote: Hi all, There are lot's of discussions, but it can be hard sometimes to actually determine someone's opinion. So here is a quick poll, please reply either to the list or directly to me with your yes/no answer and (optional but welcome) a short explanation to your standpoint. It doesn't matter if you are a user or developer, I'd like to see your opinion regardless. Please DO NOT reply to the replies, I'll summarize the results in a week's time and then we can discuss it further. Should we drop support for kernels 2.6.22 in our v4l-dvb repository? _: Yes _: No No Optional question: Why: I know it's not easy task keep this support working... but we still have *users* around the world using kernel 2.6.22 (as some of them already reported this). Cheers, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] em28xx: register device to soundcard for sysfs
On Thu, 19 Feb 2009 17:41:56 +0100 Nicola Soranzo nsora...@tiscali.it wrote: As explained in Writing an ALSA driver (T. Iwai), audio drivers should set the struct device for the card before registering the card instance. This will add the correct /sys/class/sound/cardN/device symlink, so HAL can see the device and ConsoleKit sets its ACL permissions for the logged-in user. For em28xx audio capture cards found e.g. in Hauppauge WinTV-HVR-900 (R2), this patch fixes errors like: ALSA lib pcm_hw.c:1429:(_snd_pcm_hw_open) Invalid value for card Error opening audio: Permission denied when running mplayer as a normal user. Priority: normal Signed-off-by: Nicola Soranzo nsora...@tiscali.it --- diff -r 80e785538796 -r ef8cc17cc048 linux/drivers/media/video/em28xx/em28xx-audio.c --- a/linux/drivers/media/video/em28xx/em28xx-audio.c Wed Feb 18 18:27:33 2009 +0100 +++ b/linux/drivers/media/video/em28xx/em28xx-audio.c Thu Feb 19 17:36:44 2009 +0100 @@ -560,6 +560,8 @@ pcm-info_flags = 0; pcm-private_data = dev; strcpy(pcm-name, Empia 28xx Capture); + + snd_card_set_dev(card, dev-udev-dev); strcpy(card-driver, Empia Em28xx Audio); strcpy(card-shortname, Em28xx Audio); strcpy(card-longname, Empia Em28xx Audio); -- Applied, thanks! Cheers, Douglas, -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://www.linuxtv.org/hg/~dougsland/em28xx
Mauro, Added new patch. On Thu, 19 Feb 2009 12:41:13 -0300 Douglas Schilling Landgraf dougsl...@gmail.com wrote: Hi Mauro, Please pull from http://www.linuxtv.org/hg/~dougsland/em28xx for the following: - em28xx-cards: remove incorrect entry - em28xx-cards: Add SIIG AVTuner-PVR board - em28xx: register device to soundcard for sysfs Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://www.linuxtv.org/hg/~dougsland/em28xx
Hi Mauro, Please pull from http://www.linuxtv.org/hg/~dougsland/em28xx for the following: - em28xx: support added for IO-DATA GV/MVP SZ - EMPIA-2820 chipset Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://linuxtv.org/hg/~dougsland/radios/
Hello Mauro, Please pull from http://linuxtv.org/hg/~dougsland/radios/ for the following: - radio-mr800: fix checking of retval after usb_bulk_msg - radio-mr800: increase version and add comments - radio-mr800: add few lost mutex locks - radio-mr800: add stereo support - radio-mr800: fix amradio_set_freq - radio-mr800: move radio start and stop in one function - radio-mr800: add more dev_err messages in probe - radio-mr800: place dev_err instead of dev_warn - radio-mr800: codingstyle cleanups Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] http://linuxtv.org/hg/~dougsland/radios/
Hi Mauro, I've added a new patch. On Thu, 5 Feb 2009 15:46:02 -0200 Douglas Schilling Landgraf dougsl...@gmail.com wrote: Hello Mauro, Please pull from http://linuxtv.org/hg/~dougsland/radios/ for the following: - radio-mr800: fix checking of retval after usb_bulk_msg - radio-mr800: increase version and add comments - radio-mr800: add few lost mutex locks - radio-mr800: add stereo support - radio-mr800: fix amradio_set_freq - radio-mr800: move radio start and stop in one function - radio-mr800: add more dev_err messages in probe - radio-mr800: place dev_err instead of dev_warn - radio-mr800: codingstyle cleanups - radio-si470x: use usb_make_path in usb-radio drivers Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch review] em28xx: correct mailing list
Hi Alexey, Applied, thanks. Cheers, Douglas On Sun, 25 Jan 2009 06:36:33 +0300 Alexey Klimov klimov.li...@gmail.com wrote: Hello all I'm not sure is this patch really suitable. But looks that main development mail-list moved to linux-media.. --- Correct mailing list in 3 places in em28xx-cards.c Move to linux-media on vger.kernel.org. Signed-off-by: Alexey Klimov klimov.li...@gmail.com -- diff -r 6a6eb9efc6cd linux/drivers/media/video/em28xx/em28xx-cards.c --- a/linux/drivers/media/video/em28xx/em28xx-cards.c Fri Jan 23 22:35:12 2009 -0200 +++ b/linux/drivers/media/video/em28xx/em28xx-cards.c Sun Jan 25 06:28:10 2009 +0300 @@ -1679,7 +1679,7 @@ em28xx_errdev(If the board were missdetected, please email this log to:\n); em28xx_errdev(\tV4L Mailing List - video4linux-l...@redhat.com\n); + linux-media@vger.kernel.org\n); em28xx_errdev(Board detected as %s\n, em28xx_boards[dev-model].name); @@ -1711,7 +1711,7 @@ em28xx_errdev(If the board were missdetected, please email this log to:\n); em28xx_errdev(\tV4L Mailing List - video4linux-l...@redhat.com\n); + linux-media@vger.kernel.org\n); em28xx_errdev(Board detected as %s\n, em28xx_boards[dev-model].name); @@ -1724,7 +1724,7 @@ em28xx_errdev(You may try to use card=n insmod option to workaround that.\n); em28xx_errdev(Please send an email with this log to:\n); - em28xx_errdev(\tV4L Mailing List video4linux-l...@redhat.com\n); + em28xx_errdev(\tV4L Mailing List linux-media@vger.kernel.org\n); em28xx_errdev(Board eeprom hash is 0x%08lx\n, dev-hash); em28xx_errdev(Board i2c devicelist hash is 0x%08lx\n, dev-i2c_hash); -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PULL] http://linuxtv.org/hg/~dougsland/em28xx
Hello Mauro, Please pull from http://linuxtv.org/hg/~dougsland/em28xx/ for the following: - em28xx: Add entry for GADMEI TVR200 Thanks to Yohanes Nugroho yoha...@gmail.com for testing and data collection. Thanks, Douglas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
