Re: [RFC/PATCH v2] media: Add stk1160 new driver

2012-06-03 Thread Ezequiel Garcia
Hans, On Sun, Jun 3, 2012 at 7:33 AM, Hans Verkuil hverk...@xs4all.nl wrote: Thanks. I've fixed several things reported by v4l2-compliance (see my patch below), but you are using an older v4l2-compliance version. You should clone and compile the v4l-utils.git repository yourself, rather than

Re: [RFC/PATCH v2] media: Add stk1160 new driver

2012-06-04 Thread Ezequiel Garcia
On Mon, Jun 4, 2012 at 5:47 AM, Hans Verkuil hverk...@xs4all.nl wrote: Would you care to explain me this change in your patch? +       set_bit(V4L2_FL_USE_FH_PRIO, dev-vdev.flags); See Documentation/video4linux/v4l2-framework.txt: flags: optional. Set to V4L2_FL_USE_FH_PRIO if you want to

[Q] Why is it needed to add an alsa module to v4l audio capture devices?

2012-06-07 Thread Ezequiel Garcia
Hi all, (I hope this is a genuine question, and I'm not avoiding my own homework here.) I'm trying to support the audio part of the stk1160 usb bridge (similar to em28xx). Currently, the snd-usb-audio module is being loaded when I physically plug my device, but I can't seem to capture any sound

[PATCH] em28xx: Make em28xx_ir_change_protocol a static function

2012-06-09 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com ---  drivers/media/video/em28xx/em28xx-input.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/em28xx/em28xx-input.c b/drivers/media/video/em28xx/em28xx-input.c index 2630b26..53cc36b 100644

Re: [Q] Why is it needed to add an alsa module to v4l audio capture devices?

2012-06-11 Thread Ezequiel Garcia
Hi Laurent and Mauro, On Mon, Jun 11, 2012 at 10:30 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 07-06-2012 15:26, Ezequiel Garcia escreveu: Hi all, (I hope this is a genuine question, and I'm not avoiding my own homework here.) I'm trying to support the audio part

[PATCH 1/3] em28xx: Fix wrong AC97 mic register usage

2012-06-11 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/video/em28xx/em28xx-audio.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/em28xx/em28xx-audio.c b/drivers/media/video/em28xx/em28xx-audio.c index d7e2a3d..e2a7a00 100644

[PATCH 2/3] em28xx: Rename AC97 registers to use sound/ac97_codec.h definitions

2012-06-11 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/video/em28xx/em28xx-audio.c | 27 --- drivers/media/video/em28xx/em28xx-core.c | 33 +++-- 2 files changed, 31 insertions(+), 29 deletions(-) diff --git a/drivers/media/video

[PATCH 3/3] em28xx: Remove unused AC97 register definitions

2012-06-11 Thread Ezequiel Garcia
There is a specific header sound/ac97_codec.h that defines these. All drivers should use it instead of rolling its own set of macros. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/video/em28xx/em28xx-reg.h | 51 +-- 1 files changed, 1

[PATCH] em28xx: Make a few drxk_config structs static

2012-06-12 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/video/em28xx/em28xx-dvb.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/em28xx/em28xx-dvb.c b/drivers/media/video/em28xx/em28xx-dvb.c index 16410ac..241a71a 100644

[PATCH] em28xx: Remove useless runtime-private_data usage

2012-06-12 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/video/em28xx/em28xx-audio.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/em28xx/em28xx-audio.c b/drivers/media/video/em28xx/em28xx-audio.c index d7e2a3d..2fcddae 100644

Re: Patches

2012-06-15 Thread Ezequiel Garcia
Hi Peter, On Thu, Jun 14, 2012 at 9:23 PM, Peter Senna Tschudin peter.se...@gmail.com wrote: When I run it pointing to the patch, it also includes Julia Lawall and Greg Kroah-Hartman. See: $ scripts/get_maintainer.pl outgoing/0001-RESEND-cx231xx-Paranoic-stack-memory-save.patch Mauro

STK1160 has audio now (was Re: [Q] Why is it needed to add an alsa module to v4l audio capture devices?)

2012-06-15 Thread Ezequiel Garcia
Hi again, On Mon, Jun 11, 2012 at 1:39 PM, Ezequiel Garcia some setup is required to configure the audio input associated with a video input, and to enable clock for the audio sampler. Such setup is made when a video input is selected. You likely need something similar for stk1160. I've

Re: Easycap DC60 stk1160 driver

2013-09-19 Thread Ezequiel Garcia
Hi Cees Bassa, On Thu, Sep 19, 2013 at 02:14:57PM +0200, C. Bassa wrote: My EasyCAP DC60 device works fine in Xubuntu 12.04.3 (kernel 3.2.0) but when I try to use it in Xubuntu 13.04 (kernel 3.8.0) it displays a green screen when using mplayer, or fails to stream all together using cheese.

Re: Easycap DC60 stk1160 driver

2013-09-19 Thread Ezequiel Garcia
On Thu, Sep 19, 2013 at 05:29:42PM +0200, C. Bassa wrote: Hi Ezequiel and Andrew, Andrew replied to my request on his easycap forum, so I'll answer you both here. On Thu, Sep 19, 2013 at 2:39 PM, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: If you have any chance to test

Re: advice on Easycap dongles and VBI interface..

2013-12-05 Thread Ezequiel Garcia
Hi Andrea and Hans, On Thu, Dec 05, 2013 at 12:53:32PM +0100, Hans Verkuil wrote: - finally which approach do you suggest for supporting this ancient feature, if feasibiliy tests are ok: - a libusb quick hack? - an implementation of the bindings between user level /dev/vbi and

Re: Fwd: dib8000 scanning not working on 3.10.3

2013-12-10 Thread Ezequiel Garcia
Hi Luis, On Wed, Jul 31, 2013 at 03:47:10PM -0300, Luis Polasek wrote: Hi, I just upgraded my kernel to 3.10.3, and dib8000 scanning does not work anymore. I'm just wondering, is this issue still present in mainline kernel? -- Ezequiel García, Free Electrons Embedded Linux, Kernel and

Re: Fwd: dib8000 scanning not working on 3.10.3

2013-12-11 Thread Ezequiel Garcia
this: git://git.free-electrons.com/users/ezequiel-garcia/linux/ It won't happen anytime soon, but I'll try to do it before the end of the year. -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line

Re: [PATCH 0/2] Fix a few more warnings

2012-10-29 Thread Ezequiel Garcia
On Mon, Oct 29, 2012 at 8:19 AM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 10/29/2012 11:21 AM, Mauro Carvalho Chehab wrote: Hans Verkuil yesterday's build still got two warnings at the generic drivers: http://hverkuil.home.xs4all.nl/logs/Sunday.log They didn't appear at

Re: [PATCH 35/68] [media] pwc-if: must check vb2_queue_init() success

2012-10-29 Thread Ezequiel Garcia
On Sat, Oct 27, 2012 at 5:40 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: drivers/media/usb/pwc/pwc-if.c: In function 'usb_pwc_probe': drivers/media/usb/pwc/pwc-if.c:1003:16: warning: ignoring return value of 'vb2_queue_init', declared with attribute warn_unused_result [-Wunused-result]

Re: [PATCH 0/2] Fix a few more warnings

2012-10-29 Thread Ezequiel Garcia
On Mon, Oct 29, 2012 at 8:32 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em Mon, 29 Oct 2012 12:19:32 +0100 Sylwester Nawrocki s.nawro...@samsung.com escreveu: On 10/29/2012 11:21 AM, Mauro Carvalho Chehab wrote: Hans Verkuil yesterday's build still got two warnings at the generic

Re: [PATCH 35/68] [media] pwc-if: must check vb2_queue_init() success

2012-10-29 Thread Ezequiel Garcia
On Mon, Oct 29, 2012 at 8:44 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em Mon, 29 Oct 2012 08:37:31 -0300 Ezequiel Garcia elezegar...@gmail.com escreveu: On Sat, Oct 27, 2012 at 5:40 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: drivers/media/usb/pwc/pwc-if.c: In function

Re: [PATCH 00/23] em28xx: add support fur USB bulk transfers

2012-10-31 Thread Ezequiel Garcia
On Tue, Oct 30, 2012 at 10:39 PM, Benny Amorsen benny+use...@amorsen.dk wrote: Frank Schäfer fschaefer@googlemail.com writes: This patch series adds support for USB bulk transfers to the em28xx driver. I tried these patches on my Raspberry Pi, 3.6.1 kernel, Nanostick 290e options em28xx

Re: [PATCH 00/23] em28xx: add support fur USB bulk transfers

2012-10-31 Thread Ezequiel Garcia
Benny, On Wed, Oct 31, 2012 at 4:58 PM, Benny Amorsen benny+use...@amorsen.dk wrote: Is this a regression caused by patches or a general issue with the Raspberry board ? It is a general issue with the Raspberry USB host controller or driver. Bulk transfers work, isochronous transfers have

[PATCH] stkwebcam: Fix sparse warning on undeclared symbol

2012-11-01 Thread Ezequiel Garcia
andreaanacl...@libero.it Cc: Arvydas Sidorenko asi...@gmail.com Cc: Jaime Velasco Juan jsagarri...@gmail.com Cc: Hans de Goede hdego...@redhat.com Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- Ouch, there doesn't seem to be an active maintainer for this. If anyone has a device and can give

Re: [PATCH] stkwebcam: Fix sparse warning on undeclared symbol

2012-11-02 Thread Ezequiel Garcia
Hi Arvydas, On Fri, Nov 2, 2012 at 4:35 AM, Arvydas Sidorenko asi...@gmail.com wrote: why the heck do we need this first_init? first_init was introduced in 7b1c8f58fcdbed75 for turning off LED when the cam finishes the capture. Andrea Anacleto andreaanacl...@libero.it claimed that the

Re: [PATCH] stkwebcam: Fix sparse warning on undeclared symbol

2012-11-03 Thread Ezequiel Garcia
Hi Arvydas, On Sat, Nov 3, 2012 at 12:48 AM, Arvydas Sidorenko asi...@gmail.com wrote: If you have the time to test it and stamp a Tested-by on it, I would appreciate it. Thanks, Ezequiel I applied and tested on 3.7.0-rc3 - everything is ok. Thanks! Ezequiel -- To unsubscribe

Re: [PATCH] staging/media: Use dev_ printks in go7007/s2250-loader.c

2012-11-05 Thread Ezequiel Garcia
On Mon, Nov 5, 2012 at 10:30 AM, Toshiaki Yamane yamaneto...@gmail.com wrote: I tried to check in get_maintainer.pl... Do I need to be re-sent to the address Mauro Carvalho Chehab mche...@infradead.org? No, that's not necessary. You need to send these to linux-media and Cc any relevant

Re: Regarding bulk transfers on stk1160

2012-11-14 Thread Ezequiel Garcia
Hi Greg, On Tue, Nov 13, 2012 at 11:58 AM, Greg KH g...@kroah.com wrote: Or better yet, buy a board with a working USB port, like a BeagleBone or the like :) Michael Hartup (the interested user) *has* a beaglebone. I'm trying to help him getting it ready for stk1160. However, Michael is

[PATCH] stk1160: Replace BUG_ON with WARN_ON

2012-11-23 Thread Ezequiel Garcia
This situation is not even an error condition so it's stupid to BUG_ON. Learn the lesson: http://permalink.gmane.org/gmane.linux.kernel/1347333 Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/usb/stk1160/stk1160-video.c |2 +- 1 files changed, 1 insertions(+), 1

Re: ivtv driver inputs randomly block

2012-11-28 Thread Ezequiel Garcia
On Wed, Nov 28, 2012 at 12:20 AM, Brian J. Murrell br...@interlinx.bc.ca wrote: To remedy the hanging input I simply have to rmmod ivtv modprobe ivtv and all is back to normal again, until it happens again. Any ideas? Can you post a dmesg output when this happens? Thanks, Ezequiel --

Re: ivtv driver inputs randomly block

2012-11-28 Thread Ezequiel Garcia
On Wed, Nov 28, 2012 at 10:10 AM, Brian J. Murrell br...@interlinx.bc.ca wrote: On 12-11-28 08:08 AM, Ezequiel Garcia wrote: Can you post a dmesg output when this happens? Unfortunately, there is nothing at all in dmesg when this happens. Try again with modprobe ivtv ivtv_debug=10

Re: [PATCH 0/23] media: Replace memcpy with struct assignment

2012-11-28 Thread Ezequiel Garcia
On Tue, Oct 23, 2012 at 4:57 PM, Ezequiel Garcia elezegar...@gmail.com wrote: Hello everyone, This is a large patchset that replaces struct memcpy with struct assignment, whenever possible at drivers/media. The patches are hand applied and every change has been thoroughly reviewed. However

Re: ivtv driver inputs randomly block

2012-11-29 Thread Ezequiel Garcia
Hi Brian, See my comments below. On Wed, Nov 28, 2012 at 8:19 PM, Brian J. Murrell br...@interlinx.bc.ca wrote: On 12-11-28 08:13 AM, Ezequiel Garcia wrote: Try again with modprobe ivtv ivtv_debug=10 OK. Happened again. The kernel log for the whole day since starting the module

Re: ivtv driver inputs randomly block

2012-11-29 Thread Ezequiel Garcia
Hi Brian, On Thu, Nov 29, 2012 at 12:53 PM, Brian J. Murrell br...@interlinx.bc.ca wrote: [...] I am sure you would agree that this is not really a suitable work-around, yes? I meant doing that just as a debug trial to know if maybe MythTV was doing something wrong. Andy already answered

Re: [PATCH] stv0900: Multistream support

2012-11-29 Thread Ezequiel Garcia
Hi Evgeny, On Thu, Nov 29, 2012 at 4:27 PM, CrazyCat crazyca...@yandex.ru wrote: Multistream support for stv0900. For Netup Dual S2 CI with STV0900BAC/AAC. Signed-off-by: Evgeny Plehov evgenyple...@ukr.net diff --git a/drivers/media/dvb-frontends/stv0900_core.c

Re: [PATCH 01/23] uvc: Replace memcpy with struct assignment

2012-12-27 Thread Ezequiel Garcia
Mauro, On Tue, Oct 23, 2012 at 4:57 PM, Ezequiel Garcia elezegar...@gmail.com wrote: This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested

saa711x doesn't match in easycap devices (stk1160 bridged)

2012-12-28 Thread Ezequiel Garcia
Hi everyone, Some stk1160 users (a lot acually) are reporting that stk1160 is broken. The reports come in the out of tree driver [1], but probably the issue is in mainline too. Now, it seems to me the problem is the saa711x decoder can't get matched, see a portion of dmesg. [89947.448813] usb

Re: saa711x doesn't match in easycap devices (stk1160 bridged)

2012-12-29 Thread Ezequiel Garcia
Ccing a few more people to get some feedback. Toughts anyone? Have you ever seen this before? On Fri, Dec 28, 2012 at 11:13 AM, Ezequiel Garcia elezegar...@gmail.com wrote: Hi everyone, Some stk1160 users (a lot acually) are reporting that stk1160 is broken. The reports come in the out

Re: saa711x doesn't match in easycap devices (stk1160 bridged)

2012-12-29 Thread Ezequiel Garcia
Hi Hans, On Sat, Dec 29, 2012 at 12:10 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Sat December 29 2012 15:25:08 Ezequiel Garcia wrote: Ccing a few more people to get some feedback. Toughts anyone? Have you ever seen this before? On Fri, Dec 28, 2012 at 11:13 AM, Ezequiel Garcia elezegar

Re: [GIT PULL FOR 3.9] em28xx videobuf2 support and v4l2-compliance fixes

2013-01-04 Thread Ezequiel Garcia
On Fri, Jan 4, 2013 at 4:41 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: [snip] are available in the git repository at: git://git.kernellabs.com/dheitmueller/linuxtv.git v39staging for you to fetch changes up to 381abfc158c2dad81a558a3d3ff924fc7f80d277: em28xx: convert to

Re: [PATCH 01/23] uvc: Replace memcpy with struct assignment

2013-01-12 Thread Ezequiel Garcia
On Wed, Jan 9, 2013 at 9:19 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Ezequiel, On Thursday 27 December 2012 21:49:37 Mauro Carvalho Chehab wrote: Em Thu, 27 Dec 2012 18:12:46 -0300 Ezequiel Garcia escreveu: On Tue, Oct 23, 2012 at 4:57 PM, Ezequiel Garcia wrote

[PATCH v2] uvc: Replace memcpy with struct assignment

2013-01-14 Thread Ezequiel Garcia
This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com Signed-off-by: Ezequiel Garcia elezegar

Re: [PATCH 2/4] staging: media: go7007: firmware protection Protection for unfirmware load

2013-01-16 Thread Ezequiel Garcia
Hi Volokh, On Wed, Jan 16, 2013 at 10:42 AM, Volokh Konstantin volok...@gmail.com wrote: On Wed, Jan 16, 2013 at 04:35:45PM +0300, Dan Carpenter wrote: The problem is that the firmware was being unloaded on disconnect? If no firmware was loaded (no exists,wrong or some error) then rmmod fails

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-04 Thread Ezequiel Garcia
Hello Hans, On Mon, Feb 4, 2013 at 9:36 AM, Hans Verkuil hverk...@xs4all.nl wrote: This patch series updates this driver to the control framework, switches it to unlocked_ioctl, fixes a variety of V4L2 compliance issues. It compiles, but to my knowledge nobody has hardware to test this :-(

Re: Question about printking

2013-02-04 Thread Ezequiel Garcia
Hi Joe, On Sat, Feb 2, 2013 at 4:43 PM, Joe Perches j...@perches.com wrote: On Sat, 2013-02-02 at 16:30 -0300, Ezequiel Garcia wrote: ptr = kmalloc(sizeof(foo)); if (!ptr) { pr_err(Cannot allocate memory for foo\n); return -ENOMEM; } His argue against it was that kmalloc

Re: [RFC PATCH 1/8] stk-webcam: various fixes.

2013-02-05 Thread Ezequiel Garcia
On Tue, Feb 5, 2013 at 12:35 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Tue February 5 2013 16:28:17 Arvydas Sidorenko wrote: On Mon, Feb 4, 2013 at 2:35 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Arvydas, Yes indeed, it would be great if you could test this! Note that the

Re: [PATCH] solo6x10: Maintainer change

2013-02-21 Thread Ezequiel Garcia
Hi Ismael, On Thu, Feb 21, 2013 at 7:53 PM, Ismael Luceno ismael.luc...@gmail.com wrote: Signed-off-by: Ismael Luceno ismael.luc...@corp.bluecherry.net --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3b95564..eb277c9

Re: [RFC V1 0/8] Add a driver for somagic smi2021

2013-03-15 Thread Ezequiel Garcia
On Thu, Mar 14, 2013 at 03:06:56PM +0100, Jon Arne Jørgensen wrote: This patch-set will add a driver for the Somagic SMI2021 chip. This chip is found inside different usb video-capture devices. Most of them are branded as EasyCap, but there also seems to be some other brands selling devices

Re: [RFC V1 1/8] smi2021: Add the header file

2013-03-15 Thread Ezequiel Garcia
is heavily influensed by the STK1160 driver. + * Copyright (C) 2012 Ezequiel Garcia + * elezegarcia--a.t--gmail.com Cool ;-) + * + */ + +#ifndef SMI2021_H +#define SMI2021_H + +#include linux/module.h +#include linux/usb.h +#include linux/types.h +#include linux/spinlock_types.h

Re: [RFC V1 2/8] smi2021: Add smi2021_main.c

2013-03-15 Thread Ezequiel Garcia
Public License + * along with this program; if not, see http://www.gnu.org/licenses/. + * + * This driver is heavily influensed by the STK1160 driver. + * Copyright (C) 2012 Ezequiel Garcia + * elezegarcia--a.t--gmail.com + * + */ + +#include smi2021.h + +#define VENDOR_ID 0x1c88 + +static

Re: [RFC V1 3/8] smi2021: Add smi2021_i2c.c

2013-03-15 Thread Ezequiel Garcia
General Public License + * along with this program; if not, see http://www.gnu.org/licenses/. + * + * This driver is heavily influensed by the STK1160 driver. + * Copyright (C) 2012 Ezequiel Garcia + * elezegarcia--a.t--gmail.com + * + */ + +#include smi2021.h + +/* The device

Re: [RFC V1 4/8] smi2021: Add smi2021_v4l2.c

2013-03-15 Thread Ezequiel Garcia
have received a copy of the GNU General Public License + * along with this program; if not, see http://www.gnu.org/licenses/. + * + * This driver is heavily influensed by the STK1160 driver. + * Copyright (C) 2012 Ezequiel Garcia + * elezegarcia--a.t--gmail.com + * + */ + +#include smi2021.h

Re: [RFC V1 5/8] smi2021: Add smi2021_video.c

2013-03-15 Thread Ezequiel Garcia
details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, see http://www.gnu.org/licenses/. + * + * This driver is heavily influensed by the STK1160 driver. + * Copyright (C) 2012 Ezequiel Garcia + * elezegarcia--a.t--gmail.com

Re: [RFC V1 0/8] Add a driver for somagic smi2021

2013-03-17 Thread Ezequiel Garcia
Hi Jon, On Sun, Mar 17, 2013 at 09:01:58PM +0100, Jon Arne Jørgensen wrote: On Fri, Mar 15, 2013 at 09:08:58AM -0300, Ezequiel Garcia wrote: On Thu, Mar 14, 2013 at 03:06:56PM +0100, Jon Arne Jørgensen wrote: This patch-set will add a driver for the Somagic SMI2021 chip. This chip

[PATCH 01/10] stk1160: Remove unneeded struct vb2_queue clearing

2012-08-23 Thread Ezequiel Garcia
struct vb2_queue is allocated through kzalloc as part of a larger struct, there's no need to clear it. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/usb/stk1160/stk1160-v4l.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/media/usb

[PATCH 02/10] pwc: Remove unneeded struct vb2_queue clearing

2012-08-23 Thread Ezequiel Garcia
struct vb2_queue is allocated through kzalloc as part of a larger struct, there's no need to clear it. Cc: Hans de Goede hdego...@redhat.com Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/usb/pwc/pwc-if.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff

[PATCH 03/10] vivi: Remove unneeded struct vb2_queue clearing

2012-08-23 Thread Ezequiel Garcia
struct vb2_queue is allocated through kzalloc as part of a larger struct, there's no need to clear it. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/platform/vivi.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/vivi.c b

[PATCH 04/10] mem2mem_testdev: Remove unneeded struct vb2_queue clear on queue_init()

2012-08-23 Thread Ezequiel Garcia
queue_init() is always called by v4l2_m2m_ctx_init(), which allocates a context struct v4l2_m2m_ctx with kzalloc. Therefore, there is no need to clear vb2_queue src/dst structs. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/platform/mem2mem_testdev.c |2 -- 1 files

[PATCH 05/10] coda: Remove unneeded struct vb2_queue clear on queue_init()

2012-08-23 Thread Ezequiel Garcia
queue_init() is always called by v4l2_m2m_ctx_init(), which allocates a context struct v4l2_m2m_ctx with kzalloc. Therefore, there is no need to clear vb2_queue src/dst structs. Cc: Javier Martin javier.mar...@vista-silicon.com Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers

[PATCH 06/10] mem2mem-deinterlace: Remove unneeded struct vb2_queue clear on queue_init()

2012-08-23 Thread Ezequiel Garcia
queue_init() is always called by v4l2_m2m_ctx_init(), which allocates a context struct v4l2_m2m_ctx with kzalloc. Therefore, there is no need to clear vb2_queue src/dst structs. Cc: Javier Martin javier.mar...@vista-silicon.com Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers

[PATCH 07/10] mem2mem-emmaprp: Remove unneeded struct vb2_queue clear on queue_init()

2012-08-23 Thread Ezequiel Garcia
queue_init() is always called by v4l2_m2m_ctx_init(), which allocates a context struct v4l2_m2m_ctx with kzalloc. Therefore, there is no need to clear vb2_queue src/dst structs. Cc: Javier Martin javier.mar...@vista-silicon.com Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers

[PATCH 08/10] s5p-fimc: Remove unneeded struct vb2_queue clear on queue_init()

2012-08-23 Thread Ezequiel Garcia
queue_init() is always called by v4l2_m2m_ctx_init(), which allocates a context struct v4l2_m2m_ctx with kzalloc. Therefore, there is no need to clear vb2_queue src/dst structs. Cc: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media

[PATCH] stk1160: Remove unused 'ifnum' variable

2012-08-23 Thread Ezequiel Garcia
Since ifnum is not used anywhere it is safe to remove it. This was spotted by Hans's media_tree daily build. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/usb/stk1160/stk1160-core.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/media

[PATCH 1/9] s5p: Don't check vb2_queue_init() return value

2012-08-24 Thread Ezequiel Garcia
Right now vb2_queue_init() returns always 0 and it will be changed to return void. Cc: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/platform/s5p-fimc/fimc-m2m.c |7 +++ drivers/media/platform/s5p-g2d/g2d.c|7

[PATCH 2/9] coda: Don't check vb2_queue_init() return value

2012-08-24 Thread Ezequiel Garcia
Right now vb2_queue_init() returns always 0 and it will be changed to return void. Cc: Javier Martin javier.mar...@vista-silicon.com Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/platform/coda.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 3/9] mem2mem-emmaprp: Don't check vb2_queue_init() return value

2012-08-24 Thread Ezequiel Garcia
Right now vb2_queue_init() returns always 0 and it will be changed to return void. Cc: Javier Martin javier.mar...@vista-silicon.com Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/platform/mx2_emmaprp.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions

[PATCH 4/9] mem2mem-deinterlace: Don't check vb2_queue_init() return value

2012-08-24 Thread Ezequiel Garcia
Right now vb2_queue_init() returns always 0 and it will be changed to return void. Cc: Javier Martin javier.mar...@vista-silicon.com Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/platform/m2m-deinterlace.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions

[PATCH 5/9] marvel-cam: Don't check vb2_queue_init() return value

2012-08-24 Thread Ezequiel Garcia
Right now vb2_queue_init() returns always 0 and it will be changed to return void. Cc: Jonathan Corbet cor...@lwn.net Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/platform/marvell-ccic/mcam-core.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff

[PATCH 6/9] soc-camera: Don't check vb2_queue_init() return value

2012-08-24 Thread Ezequiel Garcia
Right now vb2_queue_init() returns always 0 and it will be changed to return void. Cc: Josh Wu josh...@atmel.com Cc: Javier Martin javier.mar...@vista-silicon.com Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Magnus Damm magnus.d...@gmail.com Signed-off-by: Ezequiel Garcia elezegar

[PATCH 7/9] stk1160: Don't check vb2_queue_init() return

2012-08-24 Thread Ezequiel Garcia
Right now vb2_queue_init() returns always 0 and it will be changed to return void. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/usb/stk1160/stk1160-core.c |4 +--- drivers/media/usb/stk1160/stk1160-v4l.c | 12 +++- drivers/media/usb/stk1160/stk1160.h

[PATCH 8/9] mem2mem_testdev: Don't check vb2_queue_init() return value

2012-08-24 Thread Ezequiel Garcia
Right now vb2_queue_init() returns always 0 and it will be changed to return void. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/platform/mem2mem_testdev.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform

[PATCH 9/9] videobuf2-core: Change vb2_queue_init return type to void

2012-08-24 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/v4l2-core/videobuf2-core.c |3 +-- include/media/videobuf2-core.h |2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core

Re: [PATCH 9/9] videobuf2-core: Change vb2_queue_init return type to void

2012-08-25 Thread Ezequiel Garcia
(Ccing videobuf2 authors) On Sat, Aug 25, 2012 at 12:28 PM, Jonathan Corbet cor...@lwn.net wrote: On Sat, 25 Aug 2012 00:09:06 -0300 Ezequiel Garcia elezegar...@gmail.com wrote: -int vb2_queue_init(struct vb2_queue *q) +void vb2_queue_init(struct vb2_queue *q) { BUG_ON(!q

Re: [PATCH 9/9] videobuf2-core: Change vb2_queue_init return type to void

2012-08-28 Thread Ezequiel Garcia
Hi Jon, Thanks for your answers, I really appreciate it. On Tue, Aug 28, 2012 at 1:55 PM, Jonathan Corbet cor...@lwn.net wrote: On Sun, 26 Aug 2012 19:59:40 -0300 Ezequiel Garcia elezegar...@gmail.com wrote: 1. Why do we need to check for all these conditions in the first place

Re: gspca_pac7302 driver broken ?

2012-09-02 Thread Ezequiel Garcia
Hi Frank, On Sun, Sep 2, 2012 at 2:15 PM, Frank Schäfer fschaefer@googlemail.com wrote: Hi, can anyone who owns such a device confirm that the gspca_pac7302 driver (kernel 3.6.0-rc1+) is fine ? It's working here with latest media-tree kernel. Driver Info: Driver name :

Re: [PATCH 1/5] drivers/media/platform/davinci/vpbe.c: fix error return code

2012-09-05 Thread Ezequiel Garcia
Hi Peter, On Tue, Sep 4, 2012 at 1:14 PM, Peter Senna Tschudin peter.se...@gmail.com wrote: From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that

Re: [PATCH 2/5] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code

2012-09-05 Thread Ezequiel Garcia
Hi Peter, On Tue, Sep 4, 2012 at 1:14 PM, Peter Senna Tschudin peter.se...@gmail.com wrote: From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that

Re: [PATCH 3/5] drivers/media/platform/s5p-tv/mixer_video.c: fix error return code

2012-09-05 Thread Ezequiel Garcia
Hi Peter, On Tue, Sep 4, 2012 at 1:14 PM, Peter Senna Tschudin peter.se...@gmail.com wrote: From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that

Re: [PATCH 4/5] drivers/media/platform/vino.c: fix error return code

2012-09-05 Thread Ezequiel Garcia
Hi Peter, On Tue, Sep 4, 2012 at 1:14 PM, Peter Senna Tschudin peter.se...@gmail.com wrote: From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that

Re: [PATCH 11/14] drivers/media/usb/stk1160/stk1160-i2c.c: fix error return code

2012-09-07 Thread Ezequiel Garcia
); if (rc 0) return rc; -- Acked-by: Ezequiel Garcia elezegar...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: dvb-apps scan files

2012-09-08 Thread Ezequiel Garcia
Great! On Sat, Sep 8, 2012 at 12:48 AM, Hernán Rossetto hmronl...@gmail.com wrote: Please add the attached files for Argentina and Brazil to the DVB-T scan list. You will notice they have the same content already published here http://www.linuxtv.org/wiki/index.php/ISDB-T_Frequency_Table

Re: [PATCH v2] drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c: fix error return code

2012-09-08 Thread Ezequiel Garcia
Peter, On Sat, Sep 8, 2012 at 11:01 AM, Peter Senna Tschudin peter.se...@gmail.com wrote: From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-14 Thread Ezequiel Garcia
Hi Jon, On Thu, Sep 13, 2012 at 2:54 PM, Jonathan Corbet cor...@lwn.net wrote: Well, there is some documentation here: https://lwn.net/Articles/447435/ I thank you for this. It really helped me getting started on videobuf2. This reminds me that I've always meant to turn it into

Re: [PATCH 9/9] videobuf2-core: Change vb2_queue_init return type to void

2012-09-15 Thread Ezequiel Garcia
On Sat, Sep 15, 2012 at 9:48 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 28-08-2012 14:23, Ezequiel Garcia escreveu: Hi Jon, Thanks for your answers, I really appreciate it. On Tue, Aug 28, 2012 at 1:55 PM, Jonathan Corbet cor...@lwn.net wrote: On Sun, 26 Aug 2012 19:59:40 -0300

Re: [GIT PULL] Initial i.MX5/CODA7 support for the CODA driver

2012-09-15 Thread Ezequiel Garcia
to b50252c494ad56b88904811b1ac2d4fee1972446: media: coda: set up buffers to be sized as negotiated with s_fmt (2012-09-13 17:14:36 +0200) Ezequiel Garcia (1): coda: Remove unneeded struct vb2_queue clear on queue_init() Ezequiel

Re: [PATCH 9/9] videobuf2-core: Change vb2_queue_init return type to void

2012-09-15 Thread Ezequiel Garcia
Mauro, (Cc got messed up, so I'm sending this to you and media list) On Sat, Sep 15, 2012 at 10:37 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em Sat, 15 Sep 2012 10:05:40 -0300 Ezequiel Garcia elezegar...@gmail.com escreveu: On Sat, Sep 15, 2012 at 9:48 AM, Mauro Carvalho Chehab

[PATCH 1/4] videobuf2-core: Replace BUG_ON and return an error at vb2_queue_init()

2012-09-17 Thread Ezequiel Garcia
cor...@lwn.net Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- This patchset replaces: [PATCH 9/9] videobuf2-core: Change vb2_queue_init return type to void drivers/media/v4l2-core/videobuf2-core.c | 19 +++ include/media/videobuf2-core.h |2 +- 2 files

[PATCH 3/4] vivi: Add return code check at vb2_queue_init()

2012-09-17 Thread Ezequiel Garcia
This function returns an integer and it's mandatory to check the return code. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/platform/vivi.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/vivi.c b/drivers/media/platform

[PATCH 4/4] uvc: Add return code check at vb2_queue_init()

2012-09-17 Thread Ezequiel Garcia
This function returns an integer and it's mandatory to check the return code. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/usb/uvc/uvc_queue.c |8 ++-- drivers/media/usb/uvc/uvc_video.c |4 +++- drivers/media/usb/uvc/uvcvideo.h |2 +- 3 files changed

[PATCH v2] videobuf2-core: Replace BUG_ON and return an error at vb2_queue_init()

2012-09-17 Thread Ezequiel Garcia
...@lwn.net Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- Changes from v1: Replace WARN_ON_ONCE with WARN_ON drivers/media/v4l2-core/videobuf2-core.c | 19 +++ include/media/videobuf2-core.h |2 +- 2 files changed, 12 insertions(+), 9 deletions(-) diff

Re: [PATCH 1/4] stk1160: Make kill/free urb debug message more verbose

2012-09-23 Thread Ezequiel Garcia
Mauro, On Sun, Aug 19, 2012 at 10:23 PM, Ezequiel Garcia elezegar...@gmail.com wrote: This is just a cleaning patch to produce more useful debug messages. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/usb/stk1160/stk1160-video.c | 14 +++--- 1 files

Re: [PATCHv3 0/6] media: convert to c99 format

2012-09-25 Thread Ezequiel Garcia
On Tue, Sep 25, 2012 at 8:09 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em Ter, 2012-09-25 às 08:03 -0300, Ezequiel Garcia escreveu: Shubhrajyoti, Thanks for your patches. I'm adding media maintainer (Mauro) in Cc. When you send patches for a file you should check who maintains

[PATCH] em28xx: Replace memcpy with struct assignment

2012-09-26 Thread Ezequiel Garcia
This kind of memcpy() is error-prone and its replacement with a struct assignment is prefered. Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/usb/em28xx/em28xx-cards.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/usb/em28xx

[PATCH v2] uvc: Add return code check at vb2_queue_init()

2012-09-26 Thread Ezequiel Garcia
This function returns an integer and it's mandatory to check the return code. Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- Changes from v1: * Change variable name rc - ret * Add return 0 on successful uvc_queue_init drivers

Re: [patch] [media] cx25821: testing the wrong variable

2012-09-29 Thread Ezequiel Garcia
On Sat, Sep 29, 2012 at 11:32 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Sat, Sep 29, 2012 at 12:52:38PM +0200, walter harms wrote: Am 29.09.2012 09:12, schrieb Dan Carpenter: -input_filename could be NULL here. The intent was to test -_filename. Signed-off-by: Dan Carpenter

Re: [GIT PATCHES FOR v3.6] Samsung media driver fixes

2012-10-01 Thread Ezequiel Garcia
Mauro and folks, On Mon, Oct 1, 2012 at 10:35 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Hi Anti/Sylwester, Em 01-10-2012 08:50, Antti Palosaari escreveu: Hello I have had similar problems too. We need badly find out better procedures for patch handling. Something like parches are

[PATCH] MAINTAINERS: Add stk1160 driver

2012-10-01 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0750c24..17f6fb0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3168,6 +3168,13 @@ T: git git://git.kernel.org

Re: [GIT PATCHES FOR v3.6] Samsung media driver fixes

2012-10-01 Thread Ezequiel Garcia
On Mon, Oct 1, 2012 at 11:44 AM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 10/01/2012 04:28 PM, Hans Verkuil wrote: On Mon October 1 2012 16:05:15 Ezequiel Garcia wrote: Mauro and folks, On Mon, Oct 1, 2012 at 10:35 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Hi Anti

Re: [PATCH] MAINTAINERS: Add stk1160 driver

2012-10-01 Thread Ezequiel Garcia
On Mon, Oct 1, 2012 at 1:32 PM, Antti Palosaari cr...@iki.fi wrote: On 10/01/2012 05:20 PM, Ezequiel Garcia wrote: Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH v2] MAINTAINERS: Add stk1160 driver

2012-10-01 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- Changes from v1: Fix my mail address MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0750c24..17f6fb0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3168,6 +3168,13

<    1   2   3   4   5   6   7   8   9   >