Re: Splitting stk1160-ac97 as a module (Re: linux-next: Tree for May 1 (media/usb/stk1160))

2013-05-06 Thread Ezequiel Garcia
On Sat, May 04, 2013 at 09:59:50PM +0200, Yann E. MORIN wrote: > Ezequiel, All, > > On Sat, May 04, 2013 at 02:21:44PM -0300, Ezequiel Garcia wrote: > > I'm trying to split the ac97 support into a separate module. > > So far I've managed to do this with two differ

Re: stk1160: cannot alloc 196608 bytes

2013-05-11 Thread Ezequiel Garcia
On Thu, May 9, 2013 at 1:11 PM, a b wrote: > Hi, > > I am seeing occasional issues when using an easycap card on our fedora > 17 machine. [...] On a very quick look you seem to be getting out of memory (out of blocks of pages large enough for stk1160). Now, this may be some bug in stk1160, maybe

Re: stk1160: cannot alloc 196608 bytes

2013-05-11 Thread Ezequiel Garcia
On Sat, May 11, 2013 at 10:28 AM, Ezequiel Garcia wrote: > On Thu, May 9, 2013 at 1:11 PM, a b wrote: >> Hi, >> >> I am seeing occasional issues when using an easycap card on our fedora >> 17 machine. > [...] > > On a very quick look you seem to be getting out

Re: Audio: no sound

2013-05-23 Thread Ezequiel Garcia
Hi Alejandro, On Wed, May 22, 2013 at 10:12 PM, "Alejandro A. Valdés" wrote: > > Being able to capture the TV signal from a cable decoder; but can't make it > with getting audio working.I'm using an Easycap dc60 USB adapter, plugged in > to one of the USB 2.0 ports of an ASUS laptop, running t

Re: Audio: no sound

2013-05-23 Thread Ezequiel Garcia
On Thu, May 23, 2013 at 1:19 PM, "Alejandro A. Valdés" wrote: > Good morning, > > Please find the output the cat /proc/asound/ command below: > > # cat /proc/asound/cards > 0 [Intel ]: HDA-Intel - HDA Intel > HDA Intel at 0xf7cf8000 irq 45 > 1 [EasyALSA1 ]: ea

Re: Audio: no sound

2013-05-23 Thread Ezequiel Garcia
Alejandro, You dropped the linux-media list from Cc. I'm adding it back. On Thu, May 23, 2013 at 3:30 PM, "Alejandro A. Valdés" wrote: > # lsmod > Module Size Used by > snd_usb_audio 106622 0 > snd_usbmidi_lib24590 1 snd_usb_audio > easycap 121386

Re: Audio: no sound

2013-05-30 Thread Ezequiel Garcia
Hi Alejandro, See below. On Sat, May 25, 2013 at 4:00 AM, Jon Arne Jørgensen wrote: > On Thu, May 23, 2013 at 09:48:38PM -0300, "Alejandro A. Valdés" wrote: [...] >> [ 187.472216] easycap::0adjust_contrast: adjusting contrast to 0x3F >> [ 187.496207] easycap::0adjust_saturation: adjusting sat

Re: Unrecognized decoder chip (not gm7113c)

2013-05-30 Thread Ezequiel Garcia
Hi Greg, On Thu, May 30, 2013 at 3:58 PM, Greg Horvath wrote: > I have ported the 3.2 version of driver to kernel version 3.0.8 running on > an rk3066 (mk808) device. > That's cool. > [13336.159017] stk1160: driver ver 0.9.5 successfully loaded [...] First of all, look here: you seem to have p

Re: Unrecognized decoder chip (not gm7113c)

2013-05-30 Thread Ezequiel Garcia
On Thu, May 30, 2013 at 6:22 PM, Greg Horvath wrote: > I am not running them at the same time. There are two sets of dmesg output. > One for the stk1160 driver and the other when I attempted to load easycap > driver without loading stk1160. > > Right. In that case you can forget about the "easyca

Re: stk1160: cannot alloc 196608 bytes

2013-05-31 Thread Ezequiel Garcia
definitely >> try this out and let you know how it goes. >> Will probably give it a few days worth of runs to see if it re-occurs. >> >> Thanks again! >> >> On Sat, May 11, 2013 at 3:40 PM, Ezequiel Garcia >> wrote: >>> On Sat, May 11, 2013 a

Re: Unrecognized decoder chip (not gm7113c)

2013-05-31 Thread Ezequiel Garcia
On Fri, May 31, 2013 at 12:23 PM, Greg Horvath wrote: > I will try and get a 3.7 kernel running on an x86 machine and > see if I can get it to run though. Thanks for taking the time to > investigate. > That sounds like a good plan! Please try with a v3.7+ kernel on x86 and report your findings.

Re: [REVIEW PATCH 9/9] v4l2: remove parent from v4l2 core.

2013-06-11 Thread Ezequiel Garcia
Hi Hans, On Mon, Jun 10, 2013 at 9:48 AM, Hans Verkuil wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > --- > drivers/media/v4l2-core/v4l2-dev.c | 34 > +++--- > drivers/media/v4l2-core/v4l2-ioctl.c |7 +-- > include/media/v4l2-dev.h

Re: Audio: no sound

2013-06-11 Thread Ezequiel Garcia
Ale, On Mon, Jun 10, 2013 at 8:27 PM, "Alejandro A. Valdés" wrote: [...] > > > Besides, please find the kernel configuration file attached t this note. > Seems that the STK1160_AC97 is already there (Ln 4151 AND SS). > Yes, it seems your configuration is correct. I have a device here that behave

Re: Possible problem with stk1160 driver

2013-07-16 Thread Ezequiel Garcia
Hi Sergei, On Wed, Jul 17, 2013 at 12:04:18AM +0200, Sergey 'Jin' Bostandzhyan wrote: > > I am not quite sure if the problem is in the driver or if the user space > applications are doing something in a weird or wrong way, I hope you can > help me. > > I have one of those easycap 4x-input device

[PATCH] stk1160: Allow to change input while streaming

2013-07-17 Thread Ezequiel Garcia
Remove the check as there's no reason to prevent the input from being set when the device is streaming. This allows surveillance applications (such as motion, zoneminder, etc.) to configure the input while streaming. Reported-by: Sergey 'Jin' Bostandzhyan Signed-off-by: Ezequiel

Re: Possible problem with stk1160 driver

2013-07-17 Thread Ezequiel Garcia
Hi Sergey, On Wed, Jul 17, 2013 at 12:04:18AM +0200, Sergey 'Jin' Bostandzhyan wrote: > > It generally works fine, I can, for example, open the video device using VLC, > select one of the inputs and get the picture. > > However, programs like motion or zoneminder fail, I am not quite sure if it

Re: Possible problem with stk1160 driver

2013-07-17 Thread Ezequiel Garcia
Hi Sergey, On Wed, Jul 17, 2013 at 11:31:39PM +0200, Sergey 'Jin' Bostandzhyan wrote: > On Wed, Jul 17, 2013 at 05:44:29AM -0300, Ezequiel Garcia wrote: > > On Wed, Jul 17, 2013 at 12:04:18AM +0200, Sergey 'Jin' Bostandzhyan wrote: > > > > > > It

Re: Possible problem with stk1160 driver

2013-07-18 Thread Ezequiel Garcia
Hi Hans, Thanks for jumping in. On Thu, Jul 18, 2013 at 08:31:13AM +0200, Hans Verkuil wrote: > On 07/18/2013 02:17 AM, Ezequiel Garcia wrote: > > > > Ah... forgot to mention about that. I haven't included the fix for standard > > setting, because either the stk

[PATCH] media: stk1160: Ignore unchanged standard set

2013-07-18 Thread Ezequiel Garcia
arted. Signed-off-by: Ezequiel Garcia --- Cc: Sergey 'Jin' Bostandzhyan Cc: Hans Verkuil drivers/media/usb/stk1160/stk1160-v4l.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/stk1160/stk1160-v4l.c b/drivers/media/usb/stk1160/stk1160-v4l.c index ee46d82..c45c9

Re: linux-next: Tree for Jul 24 (media/usb/stk1160)

2013-07-24 Thread Ezequiel Garcia
Hello Randy, On Wed, Jul 24, 2013 at 10:32:57AM -0700, Randy Dunlap wrote: > On 07/23/13 23:32, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20130723: > > > > on x86_64: > > > drivers/built-in.o: In function `stk1160_ac97_register': > (.text+0x414e77): undefined reference to `snd

Re: [patch] [media] cx25821: testing the wrong variable

2012-09-29 Thread Ezequiel Garcia
On Sat, Sep 29, 2012 at 11:32 AM, Dan Carpenter wrote: > On Sat, Sep 29, 2012 at 12:52:38PM +0200, walter harms wrote: >> >> >> Am 29.09.2012 09:12, schrieb Dan Carpenter: >> > ->input_filename could be NULL here. The intent was to test >> > ->_filename. >> > >> > Signed-off-by: Dan Carpenter >>

Re: [GIT PATCHES FOR v3.6] Samsung media driver fixes

2012-10-01 Thread Ezequiel Garcia
Mauro and folks, On Mon, Oct 1, 2012 at 10:35 AM, Mauro Carvalho Chehab wrote: > Hi Anti/Sylwester, > > Em 01-10-2012 08:50, Antti Palosaari escreveu: >> Hello >> I have had similar problems too. We need badly find out better procedures >> for patch handling. Something like parches are updated a

[PATCH] MAINTAINERS: Add stk1160 driver

2012-10-01 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0750c24..17f6fb0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3168,6 +3168,13 @@ T: git git://git.kernel.org/pub/scm/linux/kernel

Re: [GIT PATCHES FOR v3.6] Samsung media driver fixes

2012-10-01 Thread Ezequiel Garcia
On Mon, Oct 1, 2012 at 11:44 AM, Sylwester Nawrocki wrote: > On 10/01/2012 04:28 PM, Hans Verkuil wrote: >> On Mon October 1 2012 16:05:15 Ezequiel Garcia wrote: >>> Mauro and folks, >>> >>> On Mon, Oct 1, 2012 at 10:35 AM, Mauro Carvalho Chehab >>> w

Re: [PATCH] MAINTAINERS: Add stk1160 driver

2012-10-01 Thread Ezequiel Garcia
On Mon, Oct 1, 2012 at 1:32 PM, Antti Palosaari wrote: > On 10/01/2012 05:20 PM, Ezequiel Garcia wrote: >> >> Signed-off-by: Ezequiel Garcia >> --- >> MAINTAINERS |7 +++ >> 1 files changed, 7 insertions(+), 0 deletions(-) >> >> diff --git

[PATCH v2] MAINTAINERS: Add stk1160 driver

2012-10-01 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- Changes from v1: Fix my mail address MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0750c24..17f6fb0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3168,6 +3168,13 @@ T: git git

Re: [PATCH] tm6000: Add parameter to keep urb bufs allocated.

2012-10-04 Thread Ezequiel Garcia
Hi Julian, Nice work! Just one pico-tiny nitpick: On Thu, Oct 4, 2012 at 11:04 AM, Julian Scheel wrote: > On systems where it cannot be assured that enough continous memory is > available > all the time it can be very useful to only allocate the memory once when it is > needed the first time. A

Re: [PATCH] tm6000: Add parameter to keep urb bufs allocated.

2012-10-08 Thread Ezequiel Garcia
On Mon, Oct 8, 2012 at 5:49 AM, Julian Scheel wrote: > Hi Ezequiel, > > Am Donnerstag, den 04.10.2012, 14:35 -0300 schrieb Ezequiel Garcia: >> Nice work! Just one pico-tiny nitpick: > > Should I update the patch to reflect this? Or is it ok if the maintainer > integ

Re: [GIT PULL for 3.7-rc1] media updates - part 1

2012-10-09 Thread Ezequiel Garcia
n unless we really did > reset tuner > [media] au0828: prevent i2c gate from being kept open while in analog > mode > [media] au0828: fix case where STREAMOFF being called on stopped stream > causes BUG() > [media] au0828: speed up i2c clock when doing xc5000 firmw

[PATCH] [for 3.7] stk1160: Add support for S-Video input

2012-10-09 Thread Ezequiel Garcia
In order to fully replace easycap driver with stk1160, it's also necessary to add S-Video support. A similar patch backported for v3.2 kernel has been tested by three different users. Signed-off-by: Ezequiel Garcia --- Hi Mauro, I'm sending this for inclusion in v3.7 second media pu

Re: [PATCH] [for 3.7] stk1160: Add support for S-Video input

2012-10-09 Thread Ezequiel Garcia
On Tue, Oct 9, 2012 at 7:25 PM, Mauro Carvalho Chehab wrote: > Em Tue, 9 Oct 2012 19:01:03 -0300 > Ezequiel Garcia escreveu: > >> In order to fully replace easycap driver with stk1160, >> it's also necessary to add S-Video support. >> >> A similar pat

Re: [PATCH] [for 3.7] stk1160: Add support for S-Video input

2012-10-09 Thread Ezequiel Garcia
On Tue, Oct 9, 2012 at 9:13 PM, Mauro Carvalho Chehab wrote: > Em Tue, 9 Oct 2012 21:11:04 -0300 > Mauro Carvalho Chehab escreveu: > >> Em Tue, 9 Oct 2012 21:04:46 -0300 >> Mauro Carvalho Chehab escreveu: >> >> > Em Tue, 9 Oct 2012 20:52:06 -0300 >> &

Re: [PATCH] [media] stk1160: Remove dead code from stk1160_i2c_read_reg()

2012-10-12 Thread Ezequiel Garcia
On Sun, Nov 9, 2008 at 2:04 PM, Jesper Juhl wrote: > There are two checks for 'rc' being less than zero with no change to > 'rc' between the two, so the second is just dead code - remove it. > > Signed-off-by: Jesper Juhl > --- > drivers/media/usb/stk1160/stk1160-i2c.c |3 --- > 1 files chan

Re: PROBLEM: Ali m5602 won't compile (3.4.9-gentoo)

2012-10-14 Thread Ezequiel Garcia
(Adding media list in Cc) On Sun, Oct 14, 2012 at 11:39 AM, Yuriy Davygora wrote: > Hello, > > I have trouble compiling the 3.4.9 kernel with genkernel (gentoo) > having enabled the Ali Corp webcam (m5602) driver. > > Here's the output of the ver_linux script: > > ==

PROBLEM: Ali m5602 won't compile (3.4.9-gentoo)

2012-10-15 Thread Ezequiel Garcia
On Sun, Oct 14, 2012 at 11:39 AM, Yuriy Davygora wrote: > Hello, > > I have trouble compiling the 3.4.9 kernel with genkernel (gentoo) > having enabled the Ali Corp webcam (m5602) driver. > > Here's the output of the ver_linux script: > > = > > yuriy-newlaptop

Re: PROBLEM: Ali m5602 won't compile (3.4.9-gentoo)

2012-10-15 Thread Ezequiel Garcia
Yuri, On Mon, Oct 15, 2012 at 7:55 AM, Ezequiel Garcia wrote: > On Sun, Oct 14, 2012 at 11:39 AM, Yuriy Davygora > wrote: >> Hello, >> >> I have trouble compiling the 3.4.9 kernel with genkernel (gentoo) >> having enabled the Ali Corp webcam (m5602) driver. &g

Re: PROBLEM: Ali m5602 won't compile (3.4.9-gentoo)

2012-10-15 Thread Ezequiel Garcia
On Mon, Oct 15, 2012 at 10:21 AM, Yuriy Davygora wrote: > Hi Ezequiel, > > thank you very very much! This was indeed the problem. I wonder, why > menuconfig did not warn me that USB is marked to be compiled as > module, when I chose to build in the gspca support, but, nevertheless, > now it wo

Re: [PATCH] [media] stk1160: Check return value of stk1160_read_reg() in stk1160_i2c_read_reg()

2012-10-15 Thread Ezequiel Garcia
On Mon, Oct 15, 2012 at 7:52 PM, Jesper Juhl wrote: > On Mon, 15 Oct 2012, Jesper Juhl wrote: > >> On Sat, 13 Oct 2012, Ezequiel Garcia wrote: >> >> > On Sun, Nov 9, 2008 at 2:04 PM, Jesper Juhl wrote: >> > > There are two checks for 'rc'

Re: [PATCH] [media] stk1160: Check return value of stk1160_read_reg() in stk1160_i2c_read_reg()

2012-10-15 Thread Ezequiel Garcia
On Mon, Oct 15, 2012 at 9:03 PM, Jesper Juhl wrote: > On Mon, 15 Oct 2012, Ezequiel Garcia wrote: > >> On Mon, Oct 15, 2012 at 7:52 PM, Jesper Juhl wrote: >> > On Mon, 15 Oct 2012, Jesper Juhl wrote: >> > >> >> On Sat, 13 Oct 2012, Ezequiel Garcia wro

Re: [PATCH] [media] stk1160: Check return value of stk1160_read_reg() in stk1160_i2c_read_reg()

2012-10-17 Thread Ezequiel Garcia
On Tue, Oct 16, 2012 at 4:06 PM, Jesper Juhl wrote: > On Mon, 15 Oct 2012, Ezequiel Garcia wrote: > >> On Mon, Oct 15, 2012 at 9:03 PM, Jesper Juhl wrote: >> > On Mon, 15 Oct 2012, Ezequiel Garcia wrote: >> > >> >> On Mon, Oct 15, 2012 at 7:52 PM, Jespe

Re: [PATCH V2] drivers/media/v4l2-core/videobuf2-core.c: fix error return code

2012-10-18 Thread Ezequiel Garcia
On Thu, Oct 18, 2012 at 11:47 AM, Peter Senna Tschudin wrote: > This patch fixes a NULL pointer dereference bug at __vb2_init_fileio(). > The NULL pointer deference happens at videobuf2-core.c: > > static size_t __vb2_perform_fileio(struct vb2_queue *q, char __user *data, > size_t count, >

[PATCH 0/23] media: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
an lead to very strange code. Not to mention, using struct assignment instead of memcpy is by far more readable. Comments, feedback and flames are welcome. Thanks! Peter Senna Tschudin, Ezequiel Garcia (23): wl128x: Replace memcpy with struct assignment radio-wl1273: Replace memcpy with

[PATCH 01/23] uvc: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Cc: Laurent Pinchart Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/usb/u

[PATCH 21/23] dvb-frontends: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/dvb-frontends/cx241

[PATCH 23/23] wl128x: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/radio/wl128x/fmdrv_co

[PATCH 22/23] radio-wl1273: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/radio/radio-wl1273.c |3

[PATCH 14/23] tuners/tda18271: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/tuners/tda18271-maps.c |

[PATCH 17/23] cx23885: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/pci/cx23885/cx23885-v

[PATCH 18/23] cx18: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Cc: Andy Walls Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/pci/cx

[PATCH 20/23] dvb-core: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/dvb-core/dvb_frontend.c

[PATCH 19/23] bttv: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/pci/bt8xx/bttv-i2c.c |3

[PATCH 16/23] cx88: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/pci/cx88/cx88-cards.

[PATCH 10/23] dvb-usb/friio-fe: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/usb/dvb-usb/friio-fe.c |

[PATCH 12/23] tuners/xc4000: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/tuners/xc4000.c |

[PATCH 15/23] ivtv: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Cc: Andy Walls Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/pci/iv

[PATCH 13/23] tuners/xc2028: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/tuners/tuner-xc2028.c |

[PATCH 11/23] au0828: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/usb/au0828/au0828-c

[PATCH 06/23] pvrusb2: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Cc: Mike Isely Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/usb/pv

[PATCH 08/23] cx25840: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/i2c/cx25840/cx2584

[PATCH 09/23] zr36067: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/pci/zoran/zoran_card.c

[PATCH 07/23] hdpvr: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Cc: Mike Isely Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/usb/hdpv

[PATCH 03/23] usbvision: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/usb/usbvision/usbvision

[PATCH 02/23] cx231xx: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/usb/cx231xx/cx231xx-c

[PATCH 05/23] pwc: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Cc: Hans de Goede Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/usb

[PATCH 04/23] sn9c102: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
llows: (http://coccinelle.lip6.fr/) // @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // Signed-off-by: Peter Senna Tschudin Signed-off-by: Ezequiel Garcia --- drivers/media/usb/sn9c102/sn9c102_

Re: [PATCH 15/23] ivtv: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
Hey Andy, On Tue, Oct 23, 2012 at 7:08 PM, Andy Walls wrote: > On Tue, 2012-10-23 at 16:57 -0300, Ezequiel Garcia wrote: >> This kind of memcpy() is error-prone. Its replacement with a struct >> assignment is prefered because it's type-safe and much easier to read. &g

Re: [PATCH 04/23] sn9c102: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
On Tue, Oct 23, 2012 at 4:57 PM, Ezequiel Garcia wrote: > This kind of memcpy() is error-prone. Its replacement with a struct > assignment is prefered because it's type-safe and much easier to read. > > Found by coccinelle. Hand patched and reviewed. > Tested by compilation on

Re: [PATCH 17/23] cx23885: Replace memcpy with struct assignment

2012-10-23 Thread Ezequiel Garcia
(CCed Steven Toth and Devin Heitmueller) On Tue, Oct 23, 2012 at 7:16 PM, Andy Walls wrote: > On Tue, 2012-10-23 at 16:57 -0300, Ezequiel Garcia wrote: >> This kind of memcpy() is error-prone. Its replacement with a struct >> assignment is prefered because it's type-safe and

[PATCH] stk1160: Try to continue with fewer transfer buffers

2012-10-23 Thread Ezequiel Garcia
Many people are trying to use stk1160 on low memory devices. Instead of failing if one allocation fails, we allow the driver to continue working if fewer transfer buffers are available. Signed-off-by: Ezequiel Garcia --- drivers/media/usb/stk1160/stk1160-video.c | 23

Re: [PATCH 0/2] Fix a few more warnings

2012-10-29 Thread Ezequiel Garcia
On Mon, Oct 29, 2012 at 8:19 AM, Sylwester Nawrocki wrote: > On 10/29/2012 11:21 AM, Mauro Carvalho Chehab wrote: >> Hans Verkuil yesterday's build still got two warnings at the >> generic drivers: >> http://hverkuil.home.xs4all.nl/logs/Sunday.log >> >> They didn't appear at i386 build pro

Re: [PATCH 35/68] [media] pwc-if: must check vb2_queue_init() success

2012-10-29 Thread Ezequiel Garcia
On Sat, Oct 27, 2012 at 5:40 PM, Mauro Carvalho Chehab wrote: > drivers/media/usb/pwc/pwc-if.c: In function 'usb_pwc_probe': > drivers/media/usb/pwc/pwc-if.c:1003:16: warning: ignoring return value of > 'vb2_queue_init', declared with attribute warn_unused_result [-Wunused-result] > In the past,

Re: [PATCH 0/2] Fix a few more warnings

2012-10-29 Thread Ezequiel Garcia
On Mon, Oct 29, 2012 at 8:32 AM, Mauro Carvalho Chehab wrote: > Em Mon, 29 Oct 2012 12:19:32 +0100 > Sylwester Nawrocki escreveu: > >> On 10/29/2012 11:21 AM, Mauro Carvalho Chehab wrote: >> > Hans Verkuil yesterday's build still got two warnings at the >> > generic drivers: >> > http://h

Re: [PATCH 35/68] [media] pwc-if: must check vb2_queue_init() success

2012-10-29 Thread Ezequiel Garcia
On Mon, Oct 29, 2012 at 8:44 AM, Mauro Carvalho Chehab wrote: > Em Mon, 29 Oct 2012 08:37:31 -0300 > Ezequiel Garcia escreveu: > >> On Sat, Oct 27, 2012 at 5:40 PM, Mauro Carvalho Chehab >> wrote: >> > drivers/media/usb/pwc/pwc-if.c: In function 'usb_pwc_pro

Re: [PATCH 00/23] em28xx: add support fur USB bulk transfers

2012-10-31 Thread Ezequiel Garcia
On Tue, Oct 30, 2012 at 10:39 PM, Benny Amorsen wrote: > Frank Schäfer writes: > >> This patch series adds support for USB bulk transfers to the em28xx driver. > > I tried these patches on my Raspberry Pi, 3.6.1 kernel, Nanostick 290e > > options em28xx prefer_bulk=1 core_debug=1 usb_debug=1 > op

Re: [PATCH 00/23] em28xx: add support fur USB bulk transfers

2012-10-31 Thread Ezequiel Garcia
Benny, On Wed, Oct 31, 2012 at 4:58 PM, Benny Amorsen wrote: >> >> Is this a regression caused by patches or a general issue with the >> Raspberry board ? > > It is a general issue with the Raspberry USB host controller or driver. > Bulk transfers work, isochronous transfers have problems. I was

[PATCH] stkwebcam: Fix sparse warning on undeclared symbol

2012-11-01 Thread Ezequiel Garcia
tion only. Cc: Andrea Anacleto Cc: Arvydas Sidorenko Cc: Jaime Velasco Juan Cc: Hans de Goede Signed-off-by: Ezequiel Garcia --- Ouch, there doesn't seem to be an active maintainer for this. If anyone has a device and can give it a try, it would be nice. The change is pretty simple any

Re: [PATCH] stkwebcam: Fix sparse warning on undeclared symbol

2012-11-02 Thread Ezequiel Garcia
Hi Arvydas, On Fri, Nov 2, 2012 at 4:35 AM, Arvydas Sidorenko wrote: >> why the heck do we need this first_init? > > first_init was introduced in 7b1c8f58fcdbed75 for turning off LED when > the cam finishes > the capture. > Andrea Anacleto claimed that the change > broke his webcam > on the same

Re: [PATCH] stkwebcam: Fix sparse warning on undeclared symbol

2012-11-03 Thread Ezequiel Garcia
Hi Arvydas, On Sat, Nov 3, 2012 at 12:48 AM, Arvydas Sidorenko wrote: >> If you have the time to test it and stamp a "Tested-by" on it, I would >> appreciate it. >> >> Thanks, >> >> Ezequiel > > I applied and tested on 3.7.0-rc3 - everything is ok. Thanks! Ezequiel -- To unsubscribe fro

Re: [PATCH] staging/media: Use dev_ printks in go7007/s2250-loader.c

2012-11-05 Thread Ezequiel Garcia
On Mon, Nov 5, 2012 at 10:30 AM, Toshiaki Yamane wrote: > > I tried to check in get_maintainer.pl... > Do I need to be re-sent to the address "Mauro Carvalho Chehab > "? > No, that's not necessary. You need to send these to linux-media and Cc any relevant maintainer, if there is one available.

Re: Regarding bulk transfers on stk1160

2012-11-14 Thread Ezequiel Garcia
Hi Greg, On Tue, Nov 13, 2012 at 11:58 AM, Greg KH wrote: > > Or better yet, buy a board with a working USB port, like a BeagleBone or > the like :) > Michael Hartup (the interested user) *has* a beaglebone. I'm trying to help him getting it ready for stk1160. However, Michael is getting choppy

[PATCH] stk1160: Replace BUG_ON with WARN_ON

2012-11-23 Thread Ezequiel Garcia
This situation is not even an error condition so it's stupid to BUG_ON. Learn the lesson: http://permalink.gmane.org/gmane.linux.kernel/1347333 Signed-off-by: Ezequiel Garcia --- drivers/media/usb/stk1160/stk1160-video.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --

Re: ivtv driver inputs randomly "block"

2012-11-28 Thread Ezequiel Garcia
On Wed, Nov 28, 2012 at 12:20 AM, Brian J. Murrell wrote: > > To remedy the hanging input I simply have to rmmod ivtv && modprobe ivtv > and all is back to normal again, until it happens again. > > Any ideas? > Can you post a dmesg output when this happens? Thanks, Ezequiel -- To unsubscrib

Re: ivtv driver inputs randomly "block"

2012-11-28 Thread Ezequiel Garcia
On Wed, Nov 28, 2012 at 10:10 AM, Brian J. Murrell wrote: > On 12-11-28 08:08 AM, Ezequiel Garcia wrote: >> >> Can you post a dmesg output when this happens? > > Unfortunately, there is nothing at all in dmesg when this happens. > Try again with modprobe ivtv ivtv_debug=1

Re: [PATCH 0/23] media: Replace memcpy with struct assignment

2012-11-28 Thread Ezequiel Garcia
On Tue, Oct 23, 2012 at 4:57 PM, Ezequiel Garcia wrote: > Hello everyone, > > This is a large patchset that replaces struct memcpy with struct assignment, > whenever possible at drivers/media. > > The patches are hand applied and every change has been thoroughly reviewed. &

Re: [PATCH 0/23] media: Replace memcpy with struct assignment

2012-11-28 Thread Ezequiel Garcia
On Wed, Nov 28, 2012 at 4:55 PM, Mauro Carvalho Chehab wrote: [...] > > There are 400+ patches pending today at patchwork. I doubt I'll have enough > time for all of them, so, I'll skip cleanup patches like the above, in order > to try to focus on bug fixes and patches that brings new functionalit

Re: ivtv driver inputs randomly "block"

2012-11-29 Thread Ezequiel Garcia
Hi Brian, See my comments below. On Wed, Nov 28, 2012 at 8:19 PM, Brian J. Murrell wrote: > On 12-11-28 08:13 AM, Ezequiel Garcia wrote: >> >> Try again with >> modprobe ivtv ivtv_debug=10 > > OK. Happened again. The kernel log for the whole day since starting &

Re: ivtv driver inputs randomly "block"

2012-11-29 Thread Ezequiel Garcia
Hi Brian, On Thu, Nov 29, 2012 at 12:53 PM, Brian J. Murrell wrote: [...] > > I am sure you would agree that this is not really a suitable > work-around, yes? > I meant doing that just as a debug trial to know if maybe MythTV was doing something wrong. Andy already answered explaining this shou

Re: [PATCH] stv0900: Multistream support

2012-11-29 Thread Ezequiel Garcia
Hi Evgeny, On Thu, Nov 29, 2012 at 4:27 PM, CrazyCat wrote: > Multistream support for stv0900. For Netup Dual S2 CI with STV0900BAC/AAC. > > Signed-off-by: Evgeny Plehov > diff --git a/drivers/media/dvb-frontends/stv0900_core.c > b/drivers/media/dvb-frontends/stv0900_core.c > index b551ca3..0fb

[PATCH V2 1/2] staging: easycap: Clean comment style in easycap_usb_probe()

2012-02-22 Thread Ezequiel Garcia
Some of these comments may still need to be reviewed. This patch only cleans the comment style. Signed-off-by: Ezequiel Garcia --- V2: Fix comment style and resend patch to proper maintainers. drivers/staging/media/easycap/easycap_main.c | 243 +- 1 files changed, 79

[PATCH V2 2/2] staging: easycap: Fix incorrect comment

2012-02-22 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- V2: resend to proper maintainers drivers/staging/media/easycap/easycap_main.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/easycap/easycap_main.c b/drivers/staging/media/easycap/easycap_main.c index

[PATCH 1/9] staging: easycap: Split device struct alloc and retrieval code

2012-02-24 Thread Ezequiel Garcia
When the device is probed a driver struct is either allocated or retrieved. This operation is logically splitted in several functions. Signed-off-by: Ezequiel Garcia --- drivers/staging/media/easycap/easycap_main.c | 384 +++--- 1 files changed, 216 insertions(+), 168

[PATCH 2/9] staging: easycap: Split buffer and video urb allocation

2012-02-24 Thread Ezequiel Garcia
When the device is probed, this driver allocates frame buffers, field buffers, isoc buffers and urbs. This patch just split this into separate functions, which helps clearing the currently gigantic probe function. Signed-off-by: Ezequiel Garcia --- drivers/staging/media/easycap/easycap_main.c

[PATCH 3/9] staging: easycap: Push bInterfaceNumber saving to config_easycap()

2012-02-24 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/staging/media/easycap/easycap_main.c | 72 +++--- 1 files changed, 41 insertions(+), 31 deletions(-) diff --git a/drivers/staging/media/easycap/easycap_main.c b/drivers/staging/media/easycap/easycap_main.c index 6d7cdef..9d6dc09

[PATCH 4/9] staging: easycap: Initialize 'ntsc' parameter before usage

2012-02-24 Thread Ezequiel Garcia
This parameter is now initialized at init_easycap(), this way we assure it won't be used uninitialized. Signed-off-by: Ezequiel Garcia --- drivers/staging/media/easycap/easycap_main.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/ea

[PATCH 5/9] staging: easycap: Push video registration to easycap_register_video()

2012-02-24 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/staging/media/easycap/easycap_main.c | 58 +++--- 1 files changed, 33 insertions(+), 25 deletions(-) diff --git a/drivers/staging/media/easycap/easycap_main.c b/drivers/staging/media/easycap/easycap_main.c index 480164d..68af1a2

[PATCH 6/9] staging: easycap: Split audio buffer and urb allocation

2012-02-24 Thread Ezequiel Garcia
When the device is probed, this driver allocates audio buffers, and audio urbs. This patch just split this into separate functions, which helps clearing the currently gigantic probe function. Signed-off-by: Ezequiel Garcia --- drivers/staging/media/easycap/easycap_main.c | 229

[PATCH 7/9] staging: easycap: Clean comment style in easycap_usb_disconnect()

2012-02-24 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/staging/media/easycap/easycap_main.c | 64 ++ 1 files changed, 24 insertions(+), 40 deletions(-) diff --git a/drivers/staging/media/easycap/easycap_main.c b/drivers/staging/media/easycap/easycap_main.c index 6e1734d..de53ed8

[PATCH 8/9] staging: easycap: Clean comment style in easycap_delete()

2012-02-24 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/staging/media/easycap/easycap_main.c | 43 + 1 files changed, 16 insertions(+), 27 deletions(-) diff --git a/drivers/staging/media/easycap/easycap_main.c b/drivers/staging/media/easycap/easycap_main.c index de53ed8..76a2c5b

[PATCH 9/9] staging: easycap: Split easycap_delete() into several pieces

2012-02-24 Thread Ezequiel Garcia
The patch splits easycap_delete(), which is in charge of buffer deallocation, into smaller functions each deallocating a specific kind of buffer. Signed-off-by: Ezequiel Garcia --- drivers/staging/media/easycap/easycap_main.c | 445 ++--- 1 files changed, 249 insertions

Re: [GIT PULL for v3.5-rc1] media updates for v3.5

2012-05-24 Thread Ezequiel Garcia
Hi Mauro, On Thu, May 24, 2012 at 12:34 PM, Mauro Carvalho Chehab wrote: > Ezequiel Garcia (2): >      [media] em28xx: Make card_setup() and pre_card_setup() static >      [media] em28xx: Remove unused list_head struct for queued buffers > > Ezequiel García (19): >      [med

<    4   5   6   7   8   9   10   11   >