Re: [PATCH] go7007 patch for 3.2.x

2012-03-20 Thread Greg KH
On Tue, Mar 20, 2012 at 07:30:51PM +0400, volokh wrote: please reply this at linux-media@vger.kernel.org I`ve some trouble - add new tuning option for card( V4L2_MPEG_VIDEO_ENCODING_H263 ,V4L2_CID_MPEG_VIDEO_B_FRAMES) - add framesizesframeintervals control - testedrealize motion

Re: [PATCH] usb: gadget/uvc: Remove non-required locking from 'uvc_queue_next_buffer' routine

2012-03-22 Thread Greg KH
On Thu, Mar 22, 2012 at 10:20:37AM +0530, Bhupesh Sharma wrote: This patch removes the non-required spinlock acquire/release calls on 'queue_irqlock' from 'uvc_queue_next_buffer' routine. This routine is called from 'video-encode' function (which translates to either

Re: [PATCH] usb: gadget/uvc: Remove non-required locking from 'uvc_queue_next_buffer' routine

2012-03-23 Thread Greg KH
On Fri, Mar 23, 2012 at 05:31:19PM +0800, Bhupesh SHARMA wrote: Hi Felipe, -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Thursday, March 22, 2012 8:11 PM To: Bhupesh SHARMA Cc: linux-...@vger.kernel.org; laurent.pinch...@ideasonboard.com; spear

Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-06-25 Thread Greg KH
On Mon, Jun 25, 2012 at 05:49:25PM -0300, Mauro Carvalho Chehab wrote: Greg, Basically, the recent changes at request_firmware() exposed an issue that affects all media drivers that use firmware (64 drivers). What change was that? How did it break anything? Driver's documentation at

Re: [PATCH RFC 1/4] kmod: add a routine to return if usermode is disabled

2012-06-26 Thread Greg KH
On Tue, Jun 26, 2012 at 04:34:19PM -0300, Mauro Carvalho Chehab wrote: Several media devices are only capable of probing the device if the firmware load is enabled, e. g. when the usermode var is not disabled. Add a routine to allow those drivers to test if probe can continue or need to be

Re: [PATCH RFC 3/4] em28xx: Workaround for new udev versions

2012-06-26 Thread Greg KH
On Tue, Jun 26, 2012 at 04:34:21PM -0300, Mauro Carvalho Chehab wrote: New udev-182 seems to be buggy: even when usermode is enabled, it insists on needing that probe would defer any firmware requests. So, drivers with firmware need to defer probe for the first driver's core request, otherwise

Re: [PATCH RFC 3/4] em28xx: Workaround for new udev versions

2012-06-26 Thread Greg KH
On Tue, Jun 26, 2012 at 04:34:21PM -0300, Mauro Carvalho Chehab wrote: New udev-182 seems to be buggy: even when usermode is enabled, it insists on needing that probe would defer any firmware requests. So, drivers with firmware need to defer probe for the first driver's core request, otherwise

Re: [PATCH RFC 2/4] em28xx: defer probe() if userspace mode is disabled

2012-06-26 Thread Greg KH
On Tue, Jun 26, 2012 at 04:34:20PM -0300, Mauro Carvalho Chehab wrote: + /* + * If the device requires firmware, probe() may need to be + * postponed, as udev may not be ready yet to honour firmware + * load requests. + */ + if

Re: [PATCH RFC 4/4] tuner-xc2028: tag the usual firmwares to help dracut

2012-06-26 Thread Greg KH
On Tue, Jun 26, 2012 at 04:34:22PM -0300, Mauro Carvalho Chehab wrote: When tuner-xc2028 is not compiled as a module, dracut will need to copy the firmware inside the initfs image. So, use MODULE_FIRMWARE() to indicate such need. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com ---

Re: [PATCH RFC 3/4] em28xx: Workaround for new udev versions

2012-06-26 Thread Greg KH
On Tue, Jun 26, 2012 at 06:21:02PM -0300, Mauro Carvalho Chehab wrote: Em 26-06-2012 17:42, Greg KH escreveu: On Tue, Jun 26, 2012 at 04:34:21PM -0300, Mauro Carvalho Chehab wrote: New udev-182 seems to be buggy: even when usermode is enabled, it insists on needing that probe would defer

Re: [PATCH v2 1/2] dma-buf: add reference counting for exporter module

2012-08-09 Thread Greg KH
On Thu, Aug 09, 2012 at 11:36:21AM +0200, Tomasz Stanislawski wrote: This patch adds reference counting on a module that exported dma-buf and implements its operations. This prevents the module from being unloaded while DMABUF file is in use. Why force all of the modules to be changed by hand,

Re: [PATCH] [media] winbond-cir: Fix initialization

2012-08-16 Thread Greg KH
On Tue, Jul 31, 2012 at 11:37:03AM +0100, Sean Young wrote: The serial driver will detect the winbond cir device as a serial port, since it looks exactly like a serial port unless you know what it is from the PNP ID. Winbond CIR 00:04: Region 0x2f8-0x2ff already in use! Winbond CIR 00:04:

Re: [stable for 3.2][patch] Kernel 3.2 add support for IT9135 chip version 2 devices.

2012-04-01 Thread Greg KH
On Sun, Apr 01, 2012 at 02:30:54PM +0100, Malcolm Priestley wrote: Originally, IT9135 chip version 2 devices were never intended to be supported in kernel 3.2 as they were thought at the time only on ID 048d:9006. However, they have since been supplied on ID 048d:9135, the following error

Re: How do I detect if disconnect is called due to module removal?

2012-04-27 Thread Greg KH
On Fri, Apr 27, 2012 at 07:43:50PM +0200, Hans Verkuil wrote: Hi all, I'm cleaning up some USB FM radio drivers and I realized that I need to know in the disconnect callback whether I'm called due to a module unload or due to an unplug event. You shouldn't care. In the first case I need

Re: [PATCH v11 0/8] PHY framework

2013-09-03 Thread Greg KH
On Tue, Sep 03, 2013 at 08:55:23PM +0530, Kishon Vijay Abraham I wrote: Hi Greg, On Wednesday 28 August 2013 12:50 AM, Felipe Balbi wrote: Hi, On Mon, Aug 26, 2013 at 01:44:49PM +0530, Kishon Vijay Abraham I wrote: On Wednesday 21 August 2013 11:16 AM, Kishon Vijay Abraham I wrote:

Re: [PATCH v11 0/8] PHY framework

2013-09-20 Thread Greg KH
On Fri, Sep 20, 2013 at 11:04:40AM +0530, Kishon Vijay Abraham I wrote: Hi Greg, On Tuesday 17 September 2013 09:11 PM, Felipe Balbi wrote: On Wed, Sep 04, 2013 at 02:27:06PM +0530, Kishon Vijay Abraham I wrote: On Tuesday 03 September 2013 09:20 PM, Greg KH wrote: On Tue, Sep 03, 2013

Re: [PATCH v11 2/8] usb: phy: omap-usb2: use the new generic PHY framework

2013-09-26 Thread Greg KH
On Wed, Aug 21, 2013 at 11:16:07AM +0530, Kishon Vijay Abraham I wrote: Used the generic PHY framework API to create the PHY. Now the power off and power on are done in omap_usb_power_off and omap_usb_power_on respectively. The omap-usb2 driver is also moved to driver/phy. However using the

Re: [stable] Re: Dependency bug in the uvcvideo Kconfig

2013-09-27 Thread Greg KH
On Thu, Sep 19, 2013 at 04:00:53PM -0700, Randy Dunlap wrote: On 09/19/13 13:17, Randy Dunlap wrote: On 09/18/13 20:44, Jeff P. Zacher wrote: You are correct that this problem shown in the forum was in 3.5.4. However, I am having wither the same or similar problem in 3.10.7.

Re: [PATCH 0/7] video phy's adaptation to *generic phy framework*

2013-10-16 Thread Greg KH
On Wed, Oct 16, 2013 at 09:58:09PM +0530, Kishon Vijay Abraham I wrote: Hi Greg, This series includes video PHY adaptation to Generic PHY Framework. With the adaptation they were able to get rid of plat data callbacks. Since you've taken the Generic PHY Framework, I think this series

Re: [PATCH v2] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

2013-11-26 Thread Greg KH
On Wed, Nov 27, 2013 at 11:48:08AM +0800, Chen Gang wrote: dev_*() assumes 'go' is already initialized, so need use pr_*() instead of before 'go' initialized. Related warning (with allmodconfig under hexagon): CC [M] drivers/staging/media/go7007/go7007-usb.o

Re: [PATCH][RESEND 5/8] uio: uio_pruss: use gen_pool_dma_alloc() to allocate sram memory

2013-12-09 Thread Greg KH
On Fri, Nov 01, 2013 at 07:48:18PM +0800, Nicolin Chen wrote: Since gen_pool_dma_alloc() is introduced, we implement it to simplify code. Signed-off-by: Nicolin Chen b42...@freescale.com --- Acked-by: Greg Kroah-Hartman gre...@linuxfoundation.org -- To unsubscribe from this list: send the

Re: Regarding bulk transfers on stk1160

2012-11-13 Thread Greg KH
On Tue, Nov 13, 2012 at 10:56:48AM -0300, Ezequiel Garcia wrote: Hello, A user (Michael Hartup in Cc) wants to use stk1160 on low power, low cost devices (like raspberrypi). At the moment raspberrypi can't stream using isoc urbs due to problems with usb host driver (dwc-otg) preventing

Re: Hauppauge WinTV HVR 900 (M/R 65018/B3C0) doesn't work anymore since linux 3.6.6

2012-11-15 Thread Greg KH
On Wed, Nov 14, 2012 at 09:30:14PM +0100, Philippe Valembois - Phil wrote: Hello, I have posted a bug report here : https://bugzilla.kernel.org/show_bug.cgi?id=50361 and I have been told to send it to the ML too. The commit causing the bug has been pushed to kernel between linux-3.5 and

Re: [PATCH 133/493] remove use of __devexit_p

2013-01-03 Thread Greg KH
On Thu, Jan 03, 2013 at 12:43:10PM +0100, Guennadi Liakhovetski wrote: Hi Bill On Mon, 19 Nov 2012, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer needed. Doesn't this also make the use of __refdata in many locations like this [snip]

Re: [PATCH 0/3] Move media staging drivers to staging/media

2011-11-17 Thread Greg KH
On Thu, Nov 17, 2011 at 07:47:50PM +0200, Tomas Winkler wrote: On Wed, Nov 2, 2011 at 5:10 PM, Greg KH gre...@suse.de wrote: On Wed, Nov 02, 2011 at 09:45:09AM -0200, Mauro Carvalho Chehab wrote: Greg, As agreed, this is the patches that move media drivers to their I've probably missed

Re: [PATCH 0/3] Move media staging drivers to staging/media

2011-11-17 Thread Greg KH
On Thu, Nov 17, 2011 at 09:10:27PM +0200, Tomas Winkler wrote: On Thu, Nov 17, 2011 at 8:09 PM, Greg KH gre...@suse.de wrote: On Thu, Nov 17, 2011 at 07:47:50PM +0200, Tomas Winkler wrote: On Wed, Nov 2, 2011 at 5:10 PM, Greg KH gre...@suse.de wrote: On Wed, Nov 02, 2011 at 09:45:09AM

Re: [patch -longterm] V4L/DVB: v4l2-ioctl: integer overflow in video_usercopy()

2012-01-03 Thread Greg KH
On Thu, Dec 15, 2011 at 07:50:30AM -0200, Mauro Carvalho Chehab wrote: On 15-12-2011 07:33, Hans Verkuil wrote: On Thursday, December 15, 2011 10:21:41 Mauro Carvalho Chehab wrote: On 15-12-2011 04:34, Dan Carpenter wrote: On a 32bit system the multiplication here could overflow. p-count

Re: fix regression in pwc_set_shutter_speed???

2010-01-29 Thread Greg KH
On Fri, Jan 29, 2010 at 12:45:37AM +, Jef Treece wrote: I reported a regression and provided a fix a few months ago for a regression in pwc_set_shutter_speed that was introduced in approx April 2009. Is that regression going to get fixed? It's really causing a lot of pain because it means

Re: fix regression in pwc_set_shutter_speed???

2010-01-29 Thread Greg KH
On Sat, Jan 30, 2010 at 12:03:09AM +, Jef Treece wrote: Here's a link to the previous message: http://www.mail-archive.com/linux-media@vger.kernel.org/msg14330.html Great. Video developers, any comments? Jef, were you able to narrow it down to the actual patch that caused the problem.

Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes

2010-02-08 Thread Greg KH
On Thu, Feb 04, 2010 at 04:07:36PM +0200, Pekka Sarnila wrote: Yes, my comment maybe criticizes more the basic architectural structure of usb putting it's own work up to higher layer. The only practical thing is that, if there is a non-HID device suffering from that FULLSPEED problem, the

[PATCH] dvb: l64781.ko broken with gcc 4.5

2010-02-09 Thread Greg KH
From: Richard Guenther rguent...@suse.de I'm trying to fix it on the GCC side (PR43007), but the module is quite stupid in using ULL constants to operate on u32 values: static int apply_frontend_param (struct dvb_frontend* fe, struct dvb_frontend_parameters *param) { ... static const u32 ppm =

[PATCH] dvb: l64781.ko broken with gcc 4.5

2010-02-09 Thread Greg KH
From: Richard Guenther rguent...@suse.de I'm trying to fix it on the GCC side (PR43007), but the module is quite stupid in using ULL constants to operate on u32 values: static int apply_frontend_param (struct dvb_frontend* fe, struct dvb_frontend_parameters *param) { ... static const u32 ppm =

Re: Driver crash on kernel 2.6.32.7. Interaction between cx8800 (DVB-S) and USB HVR Hauppauge 950q

2010-02-11 Thread Greg KH
On Wed, Feb 10, 2010 at 10:34:56AM -0500, Andy Walls wrote: On Tue, 2010-02-09 at 22:12 -0500, Devin Heitmueller wrote: On Tue, Feb 9, 2010 at 10:05 PM, Richard Lemieux rlem...@cooptel.qc.ca wrote: Andy, This is a great answer! Thanks very much. When I get into this situation

Re: alevt-dvb 1.7.0: new version, should be free from bugs now

2010-02-18 Thread Greg KH
On Thu, Feb 18, 2010 at 09:57:56AM +0100, Chicken Shack wrote: For Greg Kroah-Hartman: This one should go into kernel 2.6.32, just to close a gap of kernel regressions: http://linuxtv.org/hg/v4l-dvb/rev/2dfe2234e7ea I have no idea what you are asking me to do here. If you need a patch in

Re: alevt-dvb 1.7.0: new version, should be free from bugs now

2010-02-18 Thread Greg KH
On Thu, Feb 18, 2010 at 04:15:47PM +0100, Chicken Shack wrote: Am Donnerstag, den 18.02.2010, 06:40 -0800 schrieb Greg KH: On Thu, Feb 18, 2010 at 09:57:56AM +0100, Chicken Shack wrote: For Greg Kroah-Hartman: This one should go into kernel 2.6.32, just to close a gap of kernel

Re: [git:v4l-dvb/master] sysfs: sysfs_sd_setattr set iattrs unconditionally

2010-03-06 Thread Greg KH
On Sat, Mar 06, 2010 at 05:06:55PM +0100, Jean Delvare wrote: Err, what's happening here? I can't see any chmod call in any V4L or DVB driver, so why would this patch matter there? And we will get this fix through Linus' tree anyway, so why bother at all? I'm puzzled. I'm confused too, I got a

Re: [GIT PATCHES for 2.6.31] V4L/DVB fixes

2009-07-24 Thread Greg KH
On Fri, Jul 24, 2009 at 02:40:20PM -0300, Mauro Carvalho Chehab wrote: Linus, Please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git for_linus This series adds a new gscpca sub-driver for sn9c20x webcams. There are several popular webcam

Re: [GIT PATCHES for 2.6.31] V4L/DVB fixes

2009-07-24 Thread Greg KH
On Fri, Jul 24, 2009 at 05:32:23PM -0400, Devin Heitmueller wrote: On Fri, Jul 24, 2009 at 4:50 PM, Greg KHgre...@suse.de wrote: On Fri, Jul 24, 2009 at 02:40:20PM -0300, Mauro Carvalho Chehab wrote: Linus, Please pull from:        

Re: How to handle devices sitting on multiple busses ?

2009-08-24 Thread Greg KH
On Mon, Aug 24, 2009 at 01:57:44PM +0200, Laurent Pinchart wrote: Hi Greg, while working on video input support for embedded platforms a few developers including myself ran independently into a Linux device model issue. We all came up with hackish solutions that we are not very happy with,

[patch 20/24] V4L: em28xx: set up tda9887_conf in em28xx_card_setup()

2009-09-16 Thread Greg KH
2.6.30-stable review patch. If anyone has any objections, please let us know. -- From: Franklin Meng fmeng2...@yahoo.com V4L: em28xx: set up tda9887_conf in em28xx_card_setup() (cherry picked from commit ae3340cbf59ea362c2016eea762456cc0969fd9e) Added tda9887_conf set up into

[126/136] saa7134: ir-kbd-i2c init data needs a persistent object

2009-10-01 Thread Greg KH
2.6.31-stable review patch. If anyone has any objections, please let us know. -- From: Brian Rogers br...@xyzw.org commit 7aedd5ec87686c557d48584d69ad880c11a0984d upstream. Tested on MSI t...@nywhere Plus. Original commit message: ir-kbd-i2c's ir_probe() function can be

[125/136] em28xx: ir-kbd-i2c init data needs a persistent object

2009-10-01 Thread Greg KH
2.6.31-stable review patch. If anyone has any objections, please let us know. -- From: Brian Rogers br...@xyzw.org commit d2ebd0f806fdb6104903365e355675934eec22b2 upstream. Original commit message: ir-kbd-i2c's ir_probe() function can be called much later (i.e. at ir-kbd-i2c

Re: [PATCH] media: i.MX27 camera: fix picture source width

2013-02-15 Thread Greg KH
On Fri, Feb 15, 2013 at 06:08:41PM +0100, Christoph Fritz wrote: While using a mt9m001 (monochrome) camera the final output falsely gets horizontally divided into two pictures. The issue was git bisected to commit f410991dcf1f | [media] i.MX27 camera: add support for YUV420 format |

Re: [PATCHSET] kthread_worker: reimplement flush_kthread_work() to allow freeing during execution

2012-09-17 Thread Greg KH
On Mon, Sep 17, 2012 at 12:40:16PM -0700, Tejun Heo wrote: On Fri, Sep 14, 2012 at 03:50:40PM -0700, Colin Cross wrote: This patch set fixes a reproducible crash I'm seeing on a 3.4.10 kernel. flush_kthread_worker (which is different from flush_kthread_work) is initializing a kthread_work

Re: [PATCHSET] kthread_worker: reimplement flush_kthread_work() to allow freeing during execution

2012-09-27 Thread Greg KH
On Mon, Sep 17, 2012 at 01:28:50PM -0700, Greg KH wrote: On Mon, Sep 17, 2012 at 12:40:16PM -0700, Tejun Heo wrote: On Fri, Sep 14, 2012 at 03:50:40PM -0700, Colin Cross wrote: This patch set fixes a reproducible crash I'm seeing on a 3.4.10 kernel. flush_kthread_worker (which

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-02 Thread Greg KH
On Tue, Oct 02, 2012 at 09:33:03AM -0700, Linus Torvalds wrote: I don't know where the problem started in udev, but the report I saw was that udev175 was fine, and udev182 was broken, and would deadlock if module_init() did a request_firmware(). That kind of nested behavior is absolutely

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-02 Thread Greg KH
On Tue, Oct 02, 2012 at 03:12:39PM -0700, Greg KH wrote: On Tue, Oct 02, 2012 at 09:33:03AM -0700, Linus Torvalds wrote: I don't know where the problem started in udev, but the report I saw was that udev175 was fine, and udev182 was broken, and would deadlock if module_init() did

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Greg KH
On Wed, Oct 03, 2012 at 04:36:53PM +0200, Kay Sievers wrote: On Wed, Oct 3, 2012 at 12:12 AM, Greg KH gre...@linuxfoundation.org wrote: Mauro, what version of udev are you using that is still showing this issue? Kay, didn't you resolve this already? If not, what was the reason why

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Greg KH
On Wed, Oct 03, 2012 at 10:32:08AM -0700, Linus Torvalds wrote: On Wed, Oct 3, 2012 at 10:09 AM, Al Viro v...@zeniv.linux.org.uk wrote: + if (!S_ISREG(inode-i_mode)) + return false; + size = i_size_read(inode); Probably better to do vfs_getattr() and check

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-03 Thread Greg KH
On Wed, Oct 03, 2012 at 01:39:23PM -0700, Linus Torvalds wrote: On Wed, Oct 3, 2012 at 12:50 PM, Greg KH gre...@linuxfoundation.org wrote: Ok, like this? This looks good to me. Having udev do firmware loading and tieing it to the driver model may have not been such a good idea so many

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

2012-10-04 Thread Greg KH
On Thu, Oct 04, 2012 at 09:39:41AM -0400, Josh Boyer wrote: That said, there's clearly enough variation here that I think that for now I won't take the step to disable the udev part. I'll do the patch to support direct filesystem firmware loading using the udev default paths, and that

Re: udev breakages -

2012-10-04 Thread Greg KH
On Thu, Oct 04, 2012 at 10:29:51AM -0700, Eric W. Biederman wrote: There are still quite a few interesting cases that devtmpfs does not even think about supporting. Cases that were reported when devtmpfs was being reviewed. Care to refresh my memory? Additionally the devtmpfs

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 12:16:10PM +0530, Kishon Vijay Abraham I wrote: +struct phy_provider *__of_phy_provider_register(struct device *dev, + struct module *owner, struct phy * (*of_xlate)(struct device *dev, + struct of_phandle_args *args)); +struct phy_provider

Re: [PATCH 02/15] usb: phy: omap-usb2: use the new generic PHY framework

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 12:16:11PM +0530, Kishon Vijay Abraham I wrote: Used the generic PHY framework API to create the PHY. Now the power off and power on are done in omap_usb_power_off and omap_usb_power_on respectively. However using the old USB PHY library cannot be completely removed

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Greg KH
On Thu, Jul 18, 2013 at 02:29:52PM +0530, Kishon Vijay Abraham I wrote: Hi, On Thursday 18 July 2013 12:50 PM, Greg KH wrote: On Thu, Jul 18, 2013 at 12:16:10PM +0530, Kishon Vijay Abraham I wrote: +struct phy_provider *__of_phy_provider_register(struct device *dev, + struct module

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-18 Thread Greg KH
On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay Abraham I wrote: +ret = dev_set_name(phy-dev, %s.%d, dev_name(dev), id); Your naming is odd, no phy anywhere in it? You rely on the sender to never send a duplicate name.id pair? Why not create your own ids based on the

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-19 Thread Greg KH
On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:13 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay Abraham I wrote: + ret = dev_set_name(phy-dev, %s.%d, dev_name(dev), id); Your naming is odd, no phy

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-19 Thread Greg KH
On Fri, Jul 19, 2013 at 12:06:01PM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:13 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:07:10AM

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-20 Thread Greg KH
On Sat, Jul 20, 2013 at 08:49:32AM +0530, Kishon Vijay Abraham I wrote: Hi, On Saturday 20 July 2013 05:20 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 12:06:01PM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:25:44AM

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-20 Thread Greg KH
On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform data. Ick, don't pass strings around, pass pointers. If you have platform data you can get to, then put the pointer there, don't use a name

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 01:12:07PM +0200, Tomasz Figa wrote: On Sunday 21 of July 2013 16:37:33 Kishon Vijay Abraham I wrote: Hi, On Sunday 21 July 2013 04:01 PM, Tomasz Figa wrote: Hi, On Saturday 20 of July 2013 19:59:10 Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 12:22:48PM +0200, Sascha Hauer wrote: On Sat, Jul 20, 2013 at 07:59:10PM -0700, Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform data. Ick, don't

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-22 Thread Greg KH
On Mon, Jul 22, 2013 at 12:55:18PM +0530, Kishon Vijay Abraham I wrote: The issue (or one of the issues) in this discussion is that Greg does not like the idea of using names or IDs to associate PHYs with controllers, because they are too prone to duplications or other

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 08:48:24PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, Thanks for helping to clarify the issues here.

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 09:58:34PM +0530, Kishon Vijay Abraham I wrote: Hi Greg, On Tuesday 23 July 2013 09:48 PM, Greg KH wrote: On Tue, Jul 23, 2013 at 08:48:24PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy itself? If you had a priv pointer to search from, then you could have just passed the original phy pointer in the first place, right? IMHO it would be better if you

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 06:44:56PM +0100, Mark Brown wrote: On Tue, Jul 23, 2013 at 10:37:11AM -0700, Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: I fully agree that a simple, single string will not scale even in some, not so uncommon cases

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 07:48:11PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 10:37:11 Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy itself? If you had a priv pointer to search from

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due to multiple devices being in the system (dynamic ids, look back earlier in this thread for details about that.) I got copied in very late so don't have most of the

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 10:07:52PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 12:44:23 Greg KH wrote: On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due to multiple devices being in the system (dynamic ids

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 11:05:48PM +0200, Tomasz Figa wrote: That's not so bad, as long as you let the phy core use whatever name it wants for the device when it registers it with sysfs. Yes, in regulator core consumer names are completely separated from this. Regulator core simply

Re: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework

2013-08-01 Thread Greg KH
On Fri, Jul 26, 2013 at 06:19:16PM +0530, Kishon Vijay Abraham I wrote: +static int phy_get_id(void) +{ + int ret; + int id; + + ret = ida_pre_get(phy_ida, GFP_KERNEL); + if (!ret) + return -ENOMEM; + + ret = ida_get_new(phy_ida, id); + if (ret 0) +

Re: 'Siano Mobile Silicon' firmware doesn't load in 3.10.x

2013-08-08 Thread Greg KH
On Thu, Aug 08, 2013 at 05:52:53PM +0200, mario tillmann wrote: With the latest kernel 3.10.x I get an error message when loading the firmware sms1xxx-hcw-55xxx-dvbt-02.fw: smscore_load_firmware_family2: line: 986: sending MSG_SMS_DATA_VALIDITY_REQ expecting 0xcfed1755 smscore_onresponse:

Re: stv090x vs stv0900 support

2013-08-29 Thread Greg KH
On Thu, Aug 29, 2013 at 03:20:32PM +, Krishna Kishore wrote: Hi, Can someone help me, please? Personally, I'm not allowed to do so because of: SASKEN BUSINESS DISCLAIMER: This message may contain confidential, proprietary or legally privileged information. In case you are not the

Re: [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Dell SP2008WFP monitor.

2013-08-29 Thread Greg KH
On Fri, Aug 30, 2013 at 02:41:17AM +0200, Laurent Pinchart wrote: Hi Joseph, Thank you for the patch. On Thursday 29 August 2013 11:17:41 Joseph Salisbury wrote: BugLink: http://bugs.launchpad.net/bugs/1217957 Add quirk for Dell SP2008WFP monitor: 05a9:2641 Signed-off-by: Joseph

Re: [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Dell SP2008WFP monitor.

2013-08-30 Thread Greg KH
On Fri, Aug 30, 2013 at 12:28:16PM +0200, Laurent Pinchart wrote: Hi Greg, On Thursday 29 August 2013 21:00:21 Greg KH wrote: On Fri, Aug 30, 2013 at 02:41:17AM +0200, Laurent Pinchart wrote: On Thursday 29 August 2013 11:17:41 Joseph Salisbury wrote: BugLink: http

Re: [RFC PATCH 0/2] managed token devres interfaces

2014-04-09 Thread Greg KH
On Wed, Apr 09, 2014 at 09:21:06AM -0600, Shuah Khan wrote: Media devices often have hardware resources that are shared across several functions. For instance, TV tuner cards often have MUXes, converters, radios, tuners, etc. that are shared across various functions. However, v4l2, alsa, DVB,

Re: [PATCH] radio-bcm2048.c: fix wrong overflow check

2014-04-22 Thread Greg KH
On Tue, Apr 22, 2014 at 11:38:36AM +0200, Pavel Machek wrote: On Tue 2014-04-22 12:16:56, Dan Carpenter wrote: On Tue, Apr 22, 2014 at 10:55:53AM +0200, Pali Rohár wrote: On Tuesday 22 April 2014 10:39:17 Dan Carpenter wrote: On Sun, Apr 20, 2014 at 04:56:22PM +0200, Pavel Machek wrote:

Re: [PATCH 0/2] Add support for sii9234 chip

2014-05-03 Thread Greg KH
On Fri, Apr 11, 2014 at 01:48:28PM +0200, Tomasz Stanislawski wrote: Hi everyone, This patchset adds support for sii9234 HD Mobile Link Bridge. The chip is used to convert HDMI signal into MHL. The driver enables HDMI output on Trats and Trats2 boards. The code is based on the driver

Re: [PATCH] gpio: removes all usage of gpiochip_remove retval

2014-05-29 Thread Greg KH
On Thu, May 29, 2014 at 11:54:52PM +0200, abdoulaye berthe wrote: Signed-off-by: abdoulaye berthe berthe...@gmail.com Why? -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] [media] staging: allow omap4iss to be modular

2014-06-12 Thread Greg KH
On Thu, Jun 12, 2014 at 04:15:32PM +0200, Arnd Bergmann wrote: On Thursday 12 June 2014 16:12:17 Laurent Pinchart wrote: From 3a965f4fd5a6b3ef4a66aa4e7c916cfd34fd5706 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann a...@arndb.de Date: Tue, 21 Jan 2014 09:32:43 +0100 Subject: [PATCH]

Re: [PATCH] [media] staging: allow omap4iss to be modular

2014-06-12 Thread Greg KH
On Thu, Jun 12, 2014 at 04:28:39PM +0200, Arnd Bergmann wrote: On Thursday 12 June 2014 07:25:15 Greg KH wrote: On Thu, Jun 12, 2014 at 04:15:32PM +0200, Arnd Bergmann wrote: On Thursday 12 June 2014 16:12:17 Laurent Pinchart wrote: From 3a965f4fd5a6b3ef4a66aa4e7c916cfd34fd5706 Mon Sep

Re: [REPOST PATCH 1/8] fence: dma-buf cross-device synchronization (v17)

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 12:36:54PM +0200, Maarten Lankhorst wrote: +#define CREATE_TRACE_POINTS +#include trace/events/fence.h + +EXPORT_TRACEPOINT_SYMBOL(fence_annotate_wait_on); +EXPORT_TRACEPOINT_SYMBOL(fence_emit); Are you really willing to live with these as tracepoints for forever?

Re: [REPOST PATCH 1/8] fence: dma-buf cross-device synchronization (v17)

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 12:36:54PM +0200, Maarten Lankhorst wrote: + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public

Re: [REPOST PATCH 4/8] android: convert sync to fence api, v5

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 12:37:11PM +0200, Maarten Lankhorst wrote: Just to show it's easy. Android syncpoints can be mapped to a timeline. This removes the need to maintain a separate api for synchronization. I've left the android trace events in place, but the core fence events should

Re: [REPOST PATCH 1/8] fence: dma-buf cross-device synchronization (v17)

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 12:36:54PM +0200, Maarten Lankhorst wrote: A fence can be attached to a buffer which is being filled or consumed by hw, to allow userspace to pass the buffer without waiting to another device. For example, userspace can call page_flip ioctl to display the next frame of

Re: [REPOST PATCH 1/8] fence: dma-buf cross-device synchronization (v17)

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 09:23:06PM -0400, Rob Clark wrote: On Wed, Jun 18, 2014 at 9:13 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Jun 18, 2014 at 12:36:54PM +0200, Maarten Lankhorst wrote: +#define CREATE_TRACE_POINTS +#include trace/events/fence.h

Re: [REPOST PATCH 1/8] fence: dma-buf cross-device synchronization (v17)

2014-06-18 Thread Greg KH
On Thu, Jun 19, 2014 at 09:57:35AM +0530, Sumit Semwal wrote: Hi Greg, On 19 June 2014 06:55, Rob Clark robdcl...@gmail.com wrote: On Wed, Jun 18, 2014 at 9:16 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Jun 18, 2014 at 12:36:54PM +0200, Maarten Lankhorst wrote: A fence can

Re: [REPOST PATCH 1/8] fence: dma-buf cross-device synchronization (v17)

2014-06-19 Thread Greg KH
On Thu, Jun 19, 2014 at 10:00:18AM -0400, Rob Clark wrote: On Wed, Jun 18, 2014 at 9:13 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Jun 18, 2014 at 12:36:54PM +0200, Maarten Lankhorst wrote: +#define CREATE_TRACE_POINTS +#include trace/events/fence.h

Re: [REPOST PATCH 1/8] fence: dma-buf cross-device synchronization (v17)

2014-06-19 Thread Greg KH
On Thu, Jun 19, 2014 at 01:45:30PM -0400, Rob Clark wrote: On Thu, Jun 19, 2014 at 1:00 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Jun 19, 2014 at 10:00:18AM -0400, Rob Clark wrote: On Wed, Jun 18, 2014 at 9:13 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Jun 18

Re: [REPOST PATCH 1/8] fence: dma-buf cross-device synchronization (v17)

2014-06-19 Thread Greg KH
On Thu, Jun 19, 2014 at 09:15:36PM +0200, Daniel Vetter wrote: On Thu, Jun 19, 2014 at 7:00 PM, Greg KH gre...@linuxfoundation.org wrote: + BUG_ON(f1-context != f2-context); Nice, you just crashed the kernel, making it impossible to debug or recover :( agreed, that should

Re: [REPOST PATCH 1/8] fence: dma-buf cross-device synchronization (v17)

2014-06-19 Thread Greg KH
On Thu, Jun 19, 2014 at 03:39:47PM -0700, H. Peter Anvin wrote: On 06/19/2014 01:01 PM, Greg KH wrote: On Thu, Jun 19, 2014 at 09:15:36PM +0200, Daniel Vetter wrote: On Thu, Jun 19, 2014 at 7:00 PM, Greg KH gre...@linuxfoundation.org wrote: + BUG_ON(f1-context != f2-context

Re: [git:media_tree/master] [media] saa7134: fix regression with tvtime

2014-06-27 Thread Greg KH
On Fri, Jun 27, 2014 at 05:40:49PM +0200, Hans Verkuil wrote: Is this in the queue for v3.14 and 3.15? I haven't seen any email about it being added to either of those kernels, but the patch should have been mailed to the stable mailinglist. It has been merged into 3.16. Was it perhaps

Re: [PATCH v2 0/9] Updated fence patch series

2014-07-01 Thread Greg KH
On Tue, Jul 01, 2014 at 12:57:02PM +0200, Maarten Lankhorst wrote: So after some more hacking I've moved dma-buf to its own subdirectory, drivers/dma-buf and applied the fence patches to its new place. I believe that the first patch should be applied regardless, and the rest should be ready

Re: [PATCH v2 0/9] Updated fence patch series

2014-07-07 Thread Greg KH
On Mon, Jul 07, 2014 at 03:23:17PM +0200, Daniel Vetter wrote: On Wed, Jul 2, 2014 at 7:37 AM, Greg KH gre...@linuxfoundation.org wrote: Android can expose fences to userspace. It's possible to make the new fence mechanism expose the same fences to userspace by changing sync_fence_create

Re: [PATCH v2 0/9] Updated fence patch series

2014-07-08 Thread Greg KH
On Tue, Jul 08, 2014 at 03:44:27PM +0200, Daniel Vetter wrote: On Mon, Jul 07, 2014 at 10:30:52AM -0700, Greg KH wrote: On Mon, Jul 07, 2014 at 03:23:17PM +0200, Daniel Vetter wrote: On Wed, Jul 2, 2014 at 7:37 AM, Greg KH gre...@linuxfoundation.org wrote: Android can expose fences

Re: [PATCH v2 0/9] Updated fence patch series

2014-07-08 Thread Greg KH
On Tue, Jul 08, 2014 at 08:22:11PM +0530, Sumit Semwal wrote: On 8 July 2014 20:09, Greg KH gre...@linuxfoundation.org wrote: On Tue, Jul 08, 2014 at 03:44:27PM +0200, Daniel Vetter wrote: On Mon, Jul 07, 2014 at 10:30:52AM -0700, Greg KH wrote: On Mon, Jul 07, 2014 at 03:23:17PM +0200

Re: [PATCH v2 0/9] Updated fence patch series

2014-07-08 Thread Greg KH
On Wed, Jul 02, 2014 at 11:12:32AM +0200, Maarten Lankhorst wrote: op 02-07-14 07:37, Greg KH schreef: On Tue, Jul 01, 2014 at 12:57:02PM +0200, Maarten Lankhorst wrote: So after some more hacking I've moved dma-buf to its own subdirectory, drivers/dma-buf and applied the fence patches

Re: [PATCH v2] [media] v4l2-common: fix overflow in v4l_bound_align_image()

2014-09-10 Thread Greg KH
On Wed, Sep 10, 2014 at 06:51:09PM +0200, Maciej Matraszek wrote: Fix clamp_align() used in v4l_bound_align_image() to prevent overflow when passed large value like UINT32_MAX. In the current implementation: clamp_align(UINT32_MAX, 8, 8192, 3) returns 8, because in line: x = (x + (1

Re: [PATCH v2] [media] v4l2-common: fix overflow in v4l_bound_align_image()

2014-09-12 Thread Greg KH
On Fri, Sep 12, 2014 at 06:11:49PM +0200, Maciej Matraszek wrote: On Wed, 2014-09-10 at 10:10 -0700, Greg KH wrote: Fixes: b0d3159be9a3 (V4L/DVB (11901): v4l2: Create helper function for bounding and aligning images) Signed-off-by: Maciej Matraszek m.matras...@samsung.com Acked

<    1   2   3   4   >