Re: [PATCH] soc-camera: fix rectangle adjustment in cropping

2017-02-27 Thread Guennadi Liakhovetski
On Mon, 27 Feb 2017, Hans Verkuil wrote: > On 02/27/2017 10:02 AM, Laurent Pinchart wrote: > > Hi Guennadi, > > > > On Monday 27 Feb 2017 09:54:19 Guennadi Liakhovetski wrote: > >> On Mon, 27 Feb 2017, Laurent Pinchart wrote: > >>> On Sunday 26 Feb

Re: [PATCH] soc-camera: fix rectangle adjustment in cropping

2017-02-27 Thread Guennadi Liakhovetski
Hi Laurent, On Mon, 27 Feb 2017, Laurent Pinchart wrote: > Hi Guennadi, > > Thank you for the patch. > > On Sunday 26 Feb 2017 21:58:16 Guennadi Liakhovetski wrote: > > From: Koji Matsuoka > > > > update_subrect() adjusts the sub-rectangle to be inside a b

[PATCH] soc-camera: fix rectangle adjustment in cropping

2017-02-26 Thread Guennadi Liakhovetski
a bug, which is fixed by this patch. Signed-off-by: Koji Matsuoka Signed-off-by: Yoshihiro Kaneko [g.liakhovet...@gmx.de: dropped supposedly wrong hunks] Signed-off-by: Guennadi Liakhovetski --- This is a part of the https://patchwork.linuxtv.org/patch/26441/ submitted almost 2.5 years ago

Re: [PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table

2017-02-26 Thread Guennadi Liakhovetski
and > that the MODALIAS reported will always be of the form i2c:. > > But this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF. > > Signed-off-by: Javier Martinez Canillas Acked-by: Guennadi Liakhovetski

Re: v4l2: Adding support for multiple MIPI CSI-2 virtual channels

2017-02-22 Thread Guennadi Liakhovetski
Hi, On Tue, 21 Feb 2017, Ajay kumar wrote: > Hi Everyone, > > On Fri, Feb 17, 2017 at 7:27 PM, Thomas Axelsson > wrote: > > Hi, > > > > I have a v4l2_subdev that provides multiple MIPI CSI-2 Virtual > > Channels. I want to configure each virtual channel individually (e.g. > > set_fmt), but th

Re: patch superseded? (was: [linux-media] Patch notification: 1 patch updated)

2017-02-13 Thread Guennadi Liakhovetski
On Mon, 13 Feb 2017, Hans Verkuil wrote: > This is the v2 patch: > > https://patchwork.linuxtv.org/patch/32648/ Oh, ok, thanks! Guennadi > Hans > > On 02/13/2017 04:10 PM, Guennadi Liakhovetski wrote: > > Hi, > > > > According to the explanations be

patch superseded? (was: [linux-media] Patch notification: 1 patch updated)

2017-02-13 Thread Guennadi Liakhovetski
Hi, According to the explanations below, "superseded" means, that either a newer version of the patch is available, or it's been included in a pull request. Since I don't see a newer version, I should assume, that it's been included in a pull request. However, I don't see one on linux-media ei

Re: metadata node

2017-02-11 Thread Guennadi Liakhovetski
On Fri, 10 Feb 2017, Stanimir Varbanov wrote: > Hi Guennadi, > > On 02/02/2017 08:35 PM, Guennadi Liakhovetski wrote: > > Hi Stanimir, > > > > On Mon, 30 Jan 2017, Stanimir Varbanov wrote: > > > >> Hi Guennadi, > >> > >> On 01/1

[PATCH v2 4/4] uvcvideo: support compound controls

2017-02-07 Thread Guennadi Liakhovetski
control with more data, the data has to be read out separately after the event has been dequeued. Change-Id: I170a07d6172acbd096416e29da9e38d0d68e8f8c Signed-off-by: Guennadi Liakhovetski Tracked-On: --- drivers/media/usb/uvc/uvc_ctrl.c | 123 --- drivers/media

[PATCH v2 1/4] uvcvideo: prepare to support compound controls

2017-02-07 Thread Guennadi Liakhovetski
Not all V4L2 or UVC controls use arguments, that fit in 32 bits, some occupy buffers of arbitrary size. To support them uvcvideo control mapping .get() and .set() methods should take memory buffers as arguments instead of 32-bit integers. Signed-off-by: Guennadi Liakhovetski --- drivers/media

[PATCH v2 3/4] uvcvideo: handle control pipe protocol STALLs

2017-02-07 Thread Guennadi Liakhovetski
When a command ends up in a STALL on the control pipe, use the Request Error Code control to provide a more precise error information to the user. Signed-off-by: Guennadi Liakhovetski --- drivers/media/usb/uvc/uvc_video.c | 59 +++ 1 file changed, 53

[PATCH v2 0/4] uvcvideo: asynchronous control reporting

2017-02-07 Thread Guennadi Liakhovetski
compound controls, however, V4L2 events for them will not deliver updated data, since V4L2 events only support integer (up to 64 bits) controls. Asynchronous control processing also includes more advanced protocol STALL handling, which can be caused by racing controls. Guennadi Liakhovetski (4

[PATCH v2 2/4] uvcvideo: send a control event when a Control Change interrupt arrives

2017-02-07 Thread Guennadi Liakhovetski
. Signed-off-by: Guennadi Liakhovetski --- drivers/media/usb/uvc/uvc_ctrl.c | 149 + drivers/media/usb/uvc/uvc_status.c | 112 +--- drivers/media/usb/uvc/uvc_v4l2.c | 4 +- drivers/media/usb/uvc/uvcvideo.h | 14 +++- include/uapi/linux

Re: metadata node

2017-02-02 Thread Guennadi Liakhovetski
Hi Stanimir, On Mon, 30 Jan 2017, Stanimir Varbanov wrote: > Hi Guennadi, > > On 01/11/2017 11:42 AM, Guennadi Liakhovetski wrote: [snip] > > In any case, _if_ we do keep the current approach of separate /dev/video* > > nodes, we need a way to associate video and meta

Metadata node IRC discussion on 19.01.2017

2017-01-26 Thread Guennadi Liakhovetski
Hi all, A discussion of per-frame metadata took place on 19.01 on IRC. Participants: everybody in CC and myself. An earlier email on this mailing list https://www.mail-archive.com/linux-media@vger.kernel.org/msg107013.html served as a basis. The current state of the patches is: [v2.2,1/4] v4l

metadata node

2017-01-11 Thread Guennadi Liakhovetski
Hi Laurent, As you know, I'm working on a project, that involves streaming metadata, obtained from UVC payload headers to the userspace. Luckily, you have created "metadata node" patces a while ago. The core patch has also been acked by Hans, so, I decided it would be a safe enough bet to base

Re: [PATCH v3 4/4] uvcvideo: add a metadata device node

2017-01-03 Thread Guennadi Liakhovetski
Hi Laurent, On Fri, 30 Dec 2016, Laurent Pinchart wrote: > Hi Guennadi, > > On Friday 30 Dec 2016 14:04:34 Guennadi Liakhovetski wrote: > > On Fri, 30 Dec 2016, Laurent Pinchart wrote: > > > On Friday 30 Dec 2016 11:43:02 Guennadi Liakhovetski wrote: > > >>

[GIT PULL] soc-camera: 2 patches

2016-12-31 Thread Guennadi Liakhovetski
Hi Mauro, The following changes since commit 40eca140c404505c09773d1c6685d818cb55ab1a: [media] mn88473: add DVB-T2 PLP support (2016-12-27 14:00:15 -0200) are available in the git repository at: git://linuxtv.org/gliakhovetski/v4l-dvb.git for-4.11-1 for you to fetch changes up to 1e86b6cf8

Re: [PATCH v3 1/4] uvcvideo: (cosmetic) add and use an inline function

2016-12-30 Thread Guennadi Liakhovetski
Hi Laurent, On Fri, 30 Dec 2016, Laurent Pinchart wrote: > Hi Guennadi, > > Thank you for the patch. > > On Monday 12 Dec 2016 12:16:49 Guennadi Liakhovetski wrote: > > From: Guennadi Liakhovetski > > > > Add an inline function to obtain a struct uvc

Re: [PATCH v3 4/4] uvcvideo: add a metadata device node

2016-12-30 Thread Guennadi Liakhovetski
On Fri, 30 Dec 2016, Laurent Pinchart wrote: > Hi Guennadi, > > On Friday 30 Dec 2016 11:43:02 Guennadi Liakhovetski wrote: > > Hi Laurent, > > > > I'd like to discuss extending this patch a bit, preferably as an > > incremental patch. > > > >

Re: [PATCH v3 4/4] uvcvideo: add a metadata device node

2016-12-30 Thread Guennadi Liakhovetski
di On Mon, 12 Dec 2016, Guennadi Liakhovetski wrote: > From: Guennadi Liakhovetski > > Some UVC video cameras contain metadata in their payload headers. This > patch extracts that data, skipping the standard part of the header, on > both bulk and isochronous endpoints and makes

Re: 3A / auto-exposure Region of Interest setting

2016-12-21 Thread Guennadi Liakhovetski
...one more issue to clarify - how to report compound controls with control events, which also until now only support 32- and 64-bit integers. Thanks Guennadi On Wed, 21 Dec 2016, Guennadi Liakhovetski wrote: > Hi Laurent, > > On Tue, 29 Nov 2016, Laurent Pinchart wrote: > >

Re: 3A / auto-exposure Region of Interest setting

2016-12-21 Thread Guennadi Liakhovetski
Hi Laurent, On Tue, 29 Nov 2016, Laurent Pinchart wrote: > Hi Guennadi, > > (CC'ing Sakari) > > On Monday 28 Nov 2016 15:18:03 Guennadi Liakhovetski wrote: > > Hi, > > > > Has anyone already considered supporting 3A (e.g. auto-exposure) Region of >

Re: Problem with uvcvideo timestamps

2016-12-16 Thread Guennadi Liakhovetski
Hi Niels, Sorry for a late reply. On Mon, 31 Oct 2016, Niels Möller wrote: > Hi, > > I'm tracking down a problem in Chrome, where video streams captured > from a Logitech c930e camera get bogus timestamps. Chrome started > using camera timestamps on linux a few months ago. I've noted commit >

[PATCH v3 2/4] uvcvideo: (cosmetic) remove a superfluous assignment

2016-12-12 Thread Guennadi Liakhovetski
From: Guennadi Liakhovetski Remove a superfluous assignment to a local variable at the end of a function. Signed-off-by: Guennadi Liakhovetski --- drivers/media/usb/uvc/uvc_video.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b

[PATCH v3 4/4] uvcvideo: add a metadata device node

2016-12-12 Thread Guennadi Liakhovetski
From: Guennadi Liakhovetski Some UVC video cameras contain metadata in their payload headers. This patch extracts that data, skipping the standard part of the header, on both bulk and isochronous endpoints and makes it available to the user space on a separate video node, using the

[PATCH v3 0/4] uvcvideo: metadata device node

2016-12-12 Thread Guennadi Liakhovetski
From: Guennadi Liakhovetski This is v3 of the uvcvideo metadata node patch along with three auxiliary patches. All comments to v2 have been addressed, more details are in the patch header. Patch 3 in the series is a fix and should go to stable too. Thanks Guennadi -- To unsubscribe from this

[PATCH v3 3/4] uvcvideo: fix a wrong macro

2016-12-12 Thread Guennadi Liakhovetski
From: Guennadi Liakhovetski Don't mix up UVC_BUF_STATE_* and VB2_BUF_STATE_* codes. Signed-off-by: Guennadi Liakhovetski Cc: sta...@vger.kernel.org --- drivers/media/usb/uvc/uvc_queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_queue

[PATCH v3 1/4] uvcvideo: (cosmetic) add and use an inline function

2016-12-12 Thread Guennadi Liakhovetski
From: Guennadi Liakhovetski Add an inline function to obtain a struct uvc_buffer pointer from a struct vb2_v4l2_buffer one. Signed-off-by: Guennadi Liakhovetski --- drivers/media/usb/uvc/uvc_queue.c | 6 +++--- drivers/media/usb/uvc/uvcvideo.h | 4 2 files changed, 7 insertions(+), 3

Re: [PATCH v2 3/3] uvcvideo: add a metadata device node

2016-12-08 Thread Guennadi Liakhovetski
On Thu, 8 Dec 2016, Laurent Pinchart wrote: > Hi Guennadi, > > On Thursday 08 Dec 2016 14:34:46 Guennadi Liakhovetski wrote: > > On Tue, 6 Dec 2016, Laurent Pinchart wrote: > > > On Tuesday 06 Dec 2016 11:39:22 Guennadi Liakhovetski wrote: > > >> On Tue

Re: [PATCH v2 3/3] uvcvideo: add a metadata device node

2016-12-08 Thread Guennadi Liakhovetski
Hi Laurent, One more question: On Tue, 6 Dec 2016, Laurent Pinchart wrote: > Hi Guennadi, > > On Tuesday 06 Dec 2016 11:39:22 Guennadi Liakhovetski wrote: > > On Tue, 6 Dec 2016, Laurent Pinchart wrote: > > > On Monday 05 Dec 2016 23:13:53 Guennadi Liakhovetski wrote: &

Re: [PATCH v2 3/3] uvcvideo: add a metadata device node

2016-12-06 Thread Guennadi Liakhovetski
Hi Laurent, On Tue, 6 Dec 2016, Laurent Pinchart wrote: > Hi Guennadi, > > On Monday 05 Dec 2016 23:13:53 Guennadi Liakhovetski wrote: > > Just one question: > > > > On Tue, 6 Dec 2016, Laurent Pinchart wrote: > > >>>> + /* > > >&g

Re: [PATCH v2 3/3] uvcvideo: add a metadata device node

2016-12-05 Thread Guennadi Liakhovetski
Just one question: On Tue, 6 Dec 2016, Laurent Pinchart wrote: > > >> +/* > > >> + * Register a metadata node. TODO: shall this only be enabled > > >> for some > > >> + * cameras? > > >> + */ > > >> +if (!(dev->quirks & UVC_QUIRK_BUILTIN_ISIGHT)) > > >> +

Re: [PATCH v2 3/3] uvcvideo: add a metadata device node

2016-12-05 Thread Guennadi Liakhovetski
Hi Laurent, Thanks for the review! I'll work to address your comments. A couple of clarifications: On Mon, 5 Dec 2016, Laurent Pinchart wrote: > Hi Guennadi, > > Thank you for the patch. > > On Friday 02 Dec 2016 11:53:23 Guennadi Liakhovetski wrote: > > Some

[PATCH v2 3/3] uvcvideo: add a metadata device node

2016-12-02 Thread Guennadi Liakhovetski
V4L2_BUF_TYPE_META_CAPTURE buffer queue type. Even though different cameras will have different metadata formats, we use the same V4L2_META_FMT_UVC pixel format for all of them. Users have to parse data, based on the specific camera model information. Signed-off-by: Guennadi Liakhovetski --- v2

3A / auto-exposure Region of Interest setting

2016-11-28 Thread Guennadi Liakhovetski
Hi, Has anyone already considered supporting 3A (e.g. auto-exposure) Region of Interest selection? In UVC this is the "Digital Region of Interest (ROI) Control." Android defines ANDROID_CONTROL_AE_REGIONS, ANDROID_CONTROL_AWB_REGIONS, ANDROID_CONTROL_AF_REGIONS. The UVC control defines just a

YUV444 contradicting wikipedia

2016-10-26 Thread Guennadi Liakhovetski
Hi, Looks like the Linux definition of the (packed) YUV444 format contradicts wikipedia. According to https://linuxtv.org/downloads/v4l-dvb-apis-new/uapi/v4l/pixfmt-packed-yuv.html The Linux V4L2_PIX_FMT_YUV444 format takes 16 bits per pixel, whereas the wikipedia https://en.wikipedia.org/wik

Re: [PATCH v5 01/13] media: mt9m111: make a standalone v4l2 subdevice

2016-08-30 Thread Guennadi Liakhovetski
as I mentioned in my reply to your other patch, maybe good to join this with #3. Otherwise and with that in mind > Signed-off-by: Robert Jarzmik Acked-by: Guennadi Liakhovetski Thanks Guennadi > --- > drivers/media/i2c/soc_camera/mt9m111.c | 51 > ++

Re: [PATCH v5 03/13] media: mt9m111: move mt9m111 out of soc_camera

2016-08-30 Thread Guennadi Liakhovetski
Hi Robert, You could use "git format-patch -M" to make this patch much smaller and to make it simple to verify, what actually changed in mt9m111.c, if anything. Actually it might even be good to merge this patch with patch #1. Thanks Guennadi On Mon, 29 Aug 2016, Robert Jarzmik wrote: > As th

Re: [PATCH 01/24] v4l: Add metadata buffer type and format

2016-06-27 Thread Guennadi Liakhovetski
Hi Laurent, Just one question to this patch: On Mon, 20 Jun 2016, Laurent Pinchart wrote: > The metadata buffer type is used to transfer metadata between userspace > and kernelspace through a V4L2 buffers queue. It comes with a new > metadata capture capability and format description. > > Signe

Re: [PATCH 01/24] v4l: Add metadata buffer type and format

2016-06-24 Thread Guennadi Liakhovetski
Hi Hans, On Fri, 24 Jun 2016, Hans Verkuil wrote: > On 06/24/2016 05:57 PM, Hans Verkuil wrote: > > On 06/20/2016 09:10 PM, Laurent Pinchart wrote: > >> The metadata buffer type is used to transfer metadata between userspace > >> and kernelspace through a V4L2 buffers queue. It comes with a new >

Re: [PATCH 01/24] v4l: Add metadata buffer type and format

2016-06-24 Thread Guennadi Liakhovetski
nd format description. > > > > Signed-off-by: Laurent Pinchart Tested-by: Guennadi Liakhovetski If an acked-by is desired too, I'll give the patch a second look next Monday just to see if I can find a missing empty line to nit-pick on ;-) Thanks Guennadi > I am willing to A

[PATCH 1/3] uvcvideo: initialise the entity function field

2016-06-24 Thread Guennadi Liakhovetski
Since a recent commit: [media] media-device: move media entity register/unregister functions drivers have to set entity function before registering an entity. Fix the uvcvideo driver to comply with this. Signed-off-by: Guennadi Liakhovetski --- drivers/media/usb/uvc/uvc_entity.c | 5 + 1

[PATCH 2/3] uvcvideo: send a control event when a Control Change interrupt arrives

2016-06-24 Thread Guennadi Liakhovetski
. Signed-off-by: Guennadi Liakhovetski --- drivers/media/usb/uvc/uvc_ctrl.c | 121 - drivers/media/usb/uvc/uvc_status.c | 112 ++ drivers/media/usb/uvc/uvc_v4l2.c | 4 +- drivers/media/usb/uvc/uvcvideo.h | 14 - include

[PATCH 3/3] uvcvideo: add a metadata device node

2016-06-24 Thread Guennadi Liakhovetski
V4L2_BUF_TYPE_META_CAPTURE buffer queue type. Even though different cameras will have different metadata formats, we use the same V4L2_META_FMT_UVC pixel format for all of them. Users have to parse data, based on the specific camera model information. Signed-off-by: Guennadi Liakhovetski

[PATCH 0/3] uvcvideo: a cosmetic fix and 2 new features

2016-06-24 Thread Guennadi Liakhovetski
Hi Laurent, The first patch in the series fixes a warning, introduced by a recent framework change. Maybe you already have a similar one in your queue, drop this one then, please. Patch 2/3 implements support for asynchronous controls, using V4L2 events. Patch 3/3 adds a metadata device node t

[PATCH] V4L: fix the Z16 format definition

2016-06-17 Thread Guennadi Liakhovetski
A copy paste error created that format with the same one-line description as Y8I and Y12I, whereas Z16 is quite different from them both. Signed-off-by: Guennadi Liakhovetski --- Documentation/DocBook/media/v4l/pixfmt-z16.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH/RFC v2 4/4] v4l: vsp1: Add HGO support

2016-06-13 Thread Guennadi Liakhovetski
Hi Laurent, On Thu, 12 May 2016, Laurent Pinchart wrote: > The HGO is a Histogram Generator One-Dimension. It computes per-channel > histograms over a configurable region of the image with optional > subsampling. > > Signed-off-by: Laurent Pinchart [snip] Do I understand this correctly, that

Re: multi-sensor media controller

2016-05-29 Thread Guennadi Liakhovetski
Hi Jeremy, On Fri, 27 May 2016, Jeremy Gebben wrote: > Hi, > > Can someone give me a quick sanity check on a media controller set up? > > We have have devices (well, phones) that can have 2 or more sensors and 2 or > more 'front end' ISPs. The ISPs take CSI input from a sensor, and can produce

Re: [PATCH/RFC v2 0/4] Meta-data video device type

2016-05-23 Thread Guennadi Liakhovetski
Hi Sakari, On Fri, 13 May 2016, Sakari Ailus wrote: > Hi Hans and Laurent, > > On Fri, May 13, 2016 at 11:26:22AM +0200, Hans Verkuil wrote: > > On 05/12/2016 02:17 AM, Laurent Pinchart wrote: > > > Hello, > > > > > > This RFC patch series is a second attempt at adding support for passing > > >

[Q] Asynchronous controls vs. events

2016-05-17 Thread Guennadi Liakhovetski
Hi, I need to add asynchronous control support to the UVC driver. Some UVC cameras support some controls in asynchronous mode. For those controls a USB status is returned to the host, but the control will only be completed, when an Interrupt packet is sent by the device. I can see two ways to

[GIT PULL] soc-camera: first pull for 4.7

2016-04-09 Thread Guennadi Liakhovetski
: soc_camera: rcar_vin: add device tree support for r8a7792 (2016-04-06 06:08:42 +0200) ---- Guennadi Liakhovetski (1): au0828: remove unused macro Simon Horman (3): rcar_vin: Use ARCH_RENESAS sh_mobile_ceu_camera: Re

Re: [PATCH RFC v2 1/2] media: platform: transfer format translations to soc_mediabus

2016-04-05 Thread Guennadi Liakhovetski
Hi Robert, Not sure I understand, what should the purpose of this patch be? Why do you want to move some function(s) from one file to another? And you aren't even calling the new soc_mbus_build_fmts_xlate() function, and you aren't replacing the currently used analogous soc_camera_init_user_for

[PATCH] au0828: remove unused macro

2016-04-05 Thread Guennadi Liakhovetski
An V4L2_CID_PRIVATE_SHARPNESS macro is defined in the su0828 driver, but never used. Remove it. Signed-off-by: Guennadi Liakhovetski --- diff --git a/drivers/media/usb/au0828/au0828.h b/drivers/media/usb/au0828/au0828.h index 23f869c..6871a21 100644 --- a/drivers/media/usb/au0828/au0828.h

Re: [PATCH v4 2/2] media: soc_camera: rcar_vin: add device tree support for r8a7792

2016-04-05 Thread Guennadi Liakhovetski
Hi Simon, On Tue, 15 Mar 2016, Simon Horman wrote: > Simply document new compatibility string. > As a previous patch adds a generic R-Car Gen2 compatibility string > there appears to be no need for a driver updates. > > By documenting this compat string it may be used in DTSs shipped, for > exam

Re: per-frame camera metadata (again)

2016-01-05 Thread Guennadi Liakhovetski
On Fri, 1 Jan 2016, Guennadi Liakhovetski wrote: > Hi Laurent, > > On Sun, 27 Dec 2015, Laurent Pinchart wrote: > > > Hi Guennadi, > > > > On Thursday 24 December 2015 11:42:49 Guennadi Liakhovetski wrote: > > > Hi Laurent, > > > > >

Re: per-frame camera metadata (again)

2016-01-01 Thread Guennadi Liakhovetski
Hi Laurent, On Sun, 27 Dec 2015, Laurent Pinchart wrote: > Hi Guennadi, > > On Thursday 24 December 2015 11:42:49 Guennadi Liakhovetski wrote: > > Hi Laurent, > > > > Let me put this at the top: So far it looks like we converge on two > > possibilities: >

Re: per-frame camera metadata (again)

2015-12-24 Thread Guennadi Liakhovetski
Hi Laurent, Let me put this at the top: So far it looks like we converge on two possibilities: (1) a separate video-device node with a separate queue. No user-space visible changes are required apart from new FOURCC codes. In the kernel we'd have to add some subdev API between the bridge and t

Re: per-frame camera metadata (again)

2015-12-23 Thread Guennadi Liakhovetski
Hi Sakari, On Sat, 19 Dec 2015, Sakari Ailus wrote: > Hi Guennadi and Hans, > > Hans Verkuil wrote: > > On 12/16/15 10:37, Guennadi Liakhovetski wrote: > > > Hi all, > > > > > > A project, I am currently working on, requires acquiringing per-frame >

Re: per-frame camera metadata (again)

2015-12-22 Thread Guennadi Liakhovetski
Hi Laurent, On Mon, 21 Dec 2015, Laurent Pinchart wrote: > Hi Guennadi, > > On Wednesday 16 December 2015 12:25:24 Guennadi Liakhovetski wrote: > > On Wed, 16 Dec 2015, Hans Verkuil wrote: > > > On 12/16/15 10:37, Guennadi Liakhovetski wrote: > > > > Hi a

Re: per-frame camera metadata (again)

2015-12-16 Thread Guennadi Liakhovetski
Hi Hans, Thanks for your comments. On Wed, 16 Dec 2015, Hans Verkuil wrote: > On 12/16/15 10:37, Guennadi Liakhovetski wrote: > > Hi all, > > > > A project, I am currently working on, requires acquiringing per-frame > > metadata from the camera and passing it to

per-frame camera metadata (again)

2015-12-16 Thread Guennadi Liakhovetski
Hi all, A project, I am currently working on, requires acquiringing per-frame metadata from the camera and passing it to user-space. This is not the first time this comes up and I know such discussions have been held before. A typical user is Android (also my case), where you have to provide p

[PATCH] V4L: add Y12I, Y8I and Z16 pixel format documentation

2015-12-15 Thread Guennadi Liakhovetski
Add documentation for 3 formats, used by RealSense cameras like R200. Signed-off-by: Guennadi Liakhovetski --- Documentation/DocBook/media/v4l/pixfmt-y12i.xml | 49 +++ Documentation/DocBook/media/v4l/pixfmt-y8i.xml | 80 + Documentation/DocBook/media/v4l

[PATCH] mt9t001: fix clean up in case of power-on failures

2015-12-14 Thread Guennadi Liakhovetski
If the driver fails to reset the camera or to set up control handlers, it has to power the camera back off. Signed-off-by: Guennadi Liakhovetski --- drivers/media/i2c/mt9t001.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/mt9t001.c b

Re: Mt9v024 gettting image problem

2015-11-27 Thread Guennadi Liakhovetski
Hi, The reason for a lower framerate must not necessarily be in the program, it can be the hardware - either the clock frequency, your camera is driven by, or the slow CPU, or the camera host driver, or your frame processing. Thanks Guennadi On Thu, 26 Nov 2015, Ayhan KÃ~\Ã~GÃ~\KMANÄ°SA wrote:

Re: [git:media_tree/master] [media] rcar_vin: Remove obsolete platform data support

2015-11-21 Thread Guennadi Liakhovetski
On Sat, 21 Nov 2015, Mauro Carvalho Chehab wrote: > Em Sat, 21 Nov 2015 14:21:34 +0100 (CET) > Guennadi Liakhovetski escreveu: > > > Hi Mauro, > > > > I see neither an Acked-by nor an SOB from me, can the reason be, that the > > original patch hasn't been

Re: [git:media_tree/master] [media] rcar_vin: Remove obsolete platform data support

2015-11-21 Thread Guennadi Liakhovetski
Hi Mauro, I see neither an Acked-by nor an SOB from me, can the reason be, that the original patch hasn't been CCed to me?.. It's not assigned to me in patchwork either. Thanks Guennadi On Thu, 19 Nov 2015, Mauro Carvalho Chehab wrote: > This is an automatic generated email to let you know th

[GIT PULL] soc-camera: first 4.5 batch

2015-11-15 Thread Guennadi Liakhovetski
Hi Mauro, I've got 9 patches from Josh Wu for 4.5. Please, note, that patches 2-4 also touch vore v4l2-clock files, so, maybe you or someone else want to look at them too. The following changes since commit 79f5b6ae960d380c829fb67d5dadcd1d025d2775: [media] c8sectpfe: Remove select on CONFIG_

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-10-29 Thread Guennadi Liakhovetski
Hi Robert, On Tue, 27 Oct 2015, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > > Hi Robert, > > > > Didn't you tell me, that your dmaengine patch got rejected and therefore > > these your patches were on hold? > They were reverted, and then re

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-10-27 Thread Guennadi Liakhovetski
Hi Robert, Didn't you tell me, that your dmaengine patch got rejected and therefore these your patches were on hold? Thanks Guennadi On Sat, 24 Oct 2015, Robert Jarzmik wrote: > Robert Jarzmik writes: > > > Fix the error path where the video buffer wasn't allocated nor > > mapped. In this ca

Re: [PATCH 5/5] media: atmel-isi: support RGB565 output when sensor output YUV formats

2015-10-18 Thread Guennadi Liakhovetski
Hi Josh, On Wed, 14 Oct 2015, Josh Wu wrote: > Dear Guennadi, > > Thanks for the review. > > On 10/5/2015 1:02 AM, Guennadi Liakhovetski wrote: > > On Tue, 22 Sep 2015, Josh Wu wrote: > > > > > This patch enable Atmel ISI preview path to convert the YUV to

Re: [PATCH 1/5] media: atmel-isi: correct yuv swap according to different sensor outputs

2015-10-18 Thread Guennadi Liakhovetski
Hi Josh, On Wed, 14 Oct 2015, Josh Wu wrote: > Hi, Dear Guennadi > > Thanks for the review. > > On 10/5/2015 12:43 AM, Guennadi Liakhovetski wrote: > > Hi Josh, > > > > On Tue, 22 Sep 2015, Josh Wu wrote: > > > > > we need to configure th

Re: [PATCH 1/5] media: atmel-isi: correct yuv swap according to different sensor outputs

2015-10-04 Thread Guennadi Liakhovetski
Even simpler: On Sun, 4 Oct 2015, Guennadi Liakhovetski wrote: > Hi Josh, > > On Tue, 22 Sep 2015, Josh Wu wrote: > > > we need to configure the YCC_SWAP bits in ISI_CFG2 according to current > > sensor output and Atmel ISI output format. > > > > C

Re: [PATCH 5/5] media: atmel-isi: support RGB565 output when sensor output YUV formats

2015-10-04 Thread Guennadi Liakhovetski
On Tue, 22 Sep 2015, Josh Wu wrote: > This patch enable Atmel ISI preview path to convert the YUV to RGB format. > > Signed-off-by: Josh Wu > --- > > drivers/media/platform/soc_camera/atmel-isi.c | 38 > --- > 1 file changed, 29 insertions(+), 9 deletions(-) > > diff

Re: [PATCH 4/5] media: atmel-isi: setup YCC_SWAP correctly when using preview path

2015-10-04 Thread Guennadi Liakhovetski
On Tue, 22 Sep 2015, Josh Wu wrote: > The preview path only can convert UYVY format to RGB data. > > To make preview path work correctly, we need to set up YCC_SWAP > according to sensor output and convert them to UYVY. > > Signed-off-by: Josh Wu > --- > > drivers/media/platform/soc_camera/at

Re: [PATCH 1/5] media: atmel-isi: correct yuv swap according to different sensor outputs

2015-10-04 Thread Guennadi Liakhovetski
Hi Josh, On Tue, 22 Sep 2015, Josh Wu wrote: > we need to configure the YCC_SWAP bits in ISI_CFG2 according to current > sensor output and Atmel ISI output format. > > Current there are two cases Atmel ISI supported: > 1. Atmel ISI outputs YUYV format. > This case we need to setup YCC_SWA

Re: [git:media_tree/master] [media] rcar_vin: call g_std() instead of querystd()

2015-09-27 Thread Guennadi Liakhovetski
t; ioctl, all other ioctls should use the last set standard." So call the > > g_std() > > subdevice method instead of querystd() in the driver's set_fmt() method. > > > > Reported-by: Hans Verkuil > > Signed-off-by: Sergei Shtylyov > > Acked-by: Hans

Re: RFC: ov5640 kernel driver.

2015-09-21 Thread Guennadi Liakhovetski
Hi Javier, On Mon, 21 Sep 2015, Javier Martin wrote: > Hi, > we want to a v4l2 driver for the ov5640 sensor from Omnivision. > > AFAIK, there was an attempt in the past to mainline that driver [1] but it > didn't make it in the end. > > Some people were asking for the code for the ov5640 and th

[GIT PULL] soc-camera: 4.4 batch #1

2015-09-20 Thread Guennadi Liakhovetski
Hi Mauro, I missed the 4.3 cycle completely, so, this should clean up my backlog. There are still PXA patches outstanding, but Robert wanted to work a bit more on them. The following changes since commit 9ddf9071ea17b83954358b2dac42b34e5857a9af: Merge tag 'v4.3-rc1' into patchwork (2015-09-1

Re: [PATCH 0/4] atmel-isi: Remove platform data support

2015-09-20 Thread Guennadi Liakhovetski
Hi Laurent, Josh, It's ok not to CC me immediately if it's expected, that patches will be further forwarded (by Josh in this case) to me. And it helps, that Josh has collected all Atmel ISI patches in a git tree branch - thanks! But, please make sure, that all patches also appear in my mailbox

Re: [PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity

2015-09-18 Thread Guennadi Liakhovetski
Hi Josh, On Fri, 18 Sep 2015, Josh Wu wrote: > Hi, Guennadi > > On 9/18/2015 5:44 PM, Guennadi Liakhovetski wrote: > > Hi Nicolas, > > > > Patch handling is on my todo for the coming weekend... > > Beside this patch, Atmel-isi still have server other patches i

Re: [PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity

2015-09-18 Thread Guennadi Liakhovetski
Hi Nicolas, Patch handling is on my todo for the coming weekend... Thanks Guennadi On Fri, 18 Sep 2015, Nicolas Ferre wrote: > Le 04/08/2015 13:22, Laurent Pinchart a écrit : > > Hi Josh, > > > > Thank you for the patch. > > > > On Tuesday 04 August 2015 17:37:49 Josh Wu wrote: > >> This patc

Re: [PATCH] [media] soc_camera: soc_camera_pdrv_probe: fix potential NULL pointer dereference

2015-09-16 Thread Guennadi Liakhovetski
On Wed, 16 Sep 2015, Wang YanQing wrote: > Move dereference of sdesc after NULL pointer checker. > > Signed-off-by: Wang YanQing > --- > drivers/media/platform/soc_camera/soc_camera.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/soc_camera/s

Re: [PATCH] media: soc-camera: increase the length of clk_name on soc_of_bind()

2015-08-30 Thread Guennadi Liakhovetski
Hi Josh, Sorry, I missed the 4.3 merge cycle, but isn't this patch a fix? Isn't it fixing soc-camera / atmel-isi on a specific platform, where the clock name is longer, than currently supported? Is this platform in the mainline and its current camera support is broken because of this? In such a

Re: [PATCH v3 4/4] media: pxa_camera: conversion to dmaengine

2015-08-30 Thread Guennadi Liakhovetski
Hi Robert, I assume, the next iteration of your patches won't contain a local copy of the SG splitting code. On Wed, 29 Jul 2015, Robert Jarzmik wrote: > Convert pxa_camera to dmaengine. This removes all DMA registers > manipulation in favor of the more generic dmaengine API. > > The functiona

Re: [PATCH v3 3/4] media: pxa_camera: trivial move of dma irq functions

2015-08-30 Thread Guennadi Liakhovetski
On Wed, 29 Jul 2015, Robert Jarzmik wrote: > From: Robert Jarzmik > > This moves the dma irq handling functions up in the source file, so that > they are available before DMA preparation functions. It prepares the > conversion to DMA engine, where the descriptors are populated with these > funct

Re: [PATCH 2/2] media: atmel-isi: move configure_geometry() to start_streaming()

2015-08-30 Thread Guennadi Liakhovetski
Yep, I see the thread and updates to this patch now, please, ignore this mail, sorry. Thanks Guennadi On Sun, 30 Aug 2015, Guennadi Liakhovetski wrote: > Hi Josh, > > On Wed, 17 Jun 2015, Josh Wu wrote: > > > As in set_fmt() function we only need to know which format i

Re: [PATCH 2/2] media: atmel-isi: move configure_geometry() to start_streaming()

2015-08-30 Thread Guennadi Liakhovetski
Hi Josh, On Wed, 17 Jun 2015, Josh Wu wrote: > As in set_fmt() function we only need to know which format is been set, > we don't need to access the ISI hardware in this moment. > > So move the configure_geometry(), which access the ISI hardware, to > start_streaming() will make code more consis

Re: [PATCH 1/2] media: atmel-isi: setup the ISI_CFG2 register directly

2015-08-30 Thread Guennadi Liakhovetski
Hi Josh, On Wed, 17 Jun 2015, Josh Wu wrote: > In the function configure_geometry(), we will setup the ISI CFG2 > according to the sensor output format. > > It make no sense to just read back the CFG2 register and just set part > of it. > > So just set up this register directly makes things sim

Re: HDMI and Composite capture on Lager, for kernel 4.1, version 5

2015-07-28 Thread Guennadi Liakhovetski
field > [PATCH 13/13] media: rcar_vin: Reject videobufs that are too small Since Hans would like to pull these patches urgently: for patches #6, 7 (in its updated version 6 of yesterday 27.07.2015), and 8-13: Acked-by: Guennadi Liakhovetski Thanks Guennadi -- To unsubscribe

Re: [PATCH 04/14] tw9910: init priv->scale and update standard

2015-07-28 Thread Guennadi Liakhovetski
On Tue, 28 Jul 2015, Hans Verkuil wrote: > On 07/26/2015 12:00 PM, Guennadi Liakhovetski wrote: > > Hi Hans, > > > > On Fri, 24 Jul 2015, Hans Verkuil wrote: > > > >> Guennadi, > >> > >> I want to make a pull request for this pat

Re: [PATCH v2 4/4] media: pxa_camera: conversion to dmaengine

2015-07-26 Thread Guennadi Liakhovetski
Hi Robert, On Sun, 19 Jul 2015, Robert Jarzmik wrote: > Robert Jarzmik writes: > > > Guennadi Liakhovetski writes: > > > >>> /* init DMA for Y channel */ > >> > >> How about taking the loop over the sg list out of pxa_init_dma_channe

Re: [PATCH 04/14] tw9910: init priv->scale and update standard

2015-07-26 Thread Guennadi Liakhovetski
cks for patches 1 and > 2. > > Regards, > > Hans > > On 06/22/2015 09:29 AM, Hans Verkuil wrote: > > On 06/22/2015 09:21 AM, Guennadi Liakhovetski wrote: > >> Hi Hans, > >> > >> On Mon, 22 Jun 2015, Hans Verkuil wrote: > >> &g

Re: [PATCH v2 4/4] media: pxa_camera: conversion to dmaengine

2015-07-12 Thread Guennadi Liakhovetski
Hi Robert, On Sun, 5 Jul 2015, Robert Jarzmik wrote: > Convert pxa_camera to dmaengine. This removes all DMA registers > manipulation in favor of the more generic dmaengine API. > > The functional level should be the same as before. The biggest change is > in the videobuf_sg_splice() function, w

Re: [PATCH 1/4] media: pxa_camera: fix the buffer free path (fwd)

2015-07-12 Thread Guennadi Liakhovetski
Hi Robert, No idea why this mail hasn't been delivered... Sorry, resending. Thanks Guennadi -- Forwarded message -- Date: Sun, 31 May 2015 21:34:50 +0200 (CEST) From: Guennadi Liakhovetski Subject: Re: [PATCH 1/4] media: pxa_camera: fix the buffer free path Hi Robert, T

Re: [PATCH v2 3/4] media: pxa_camera: trivial move of dma irq functions

2015-07-12 Thread Guennadi Liakhovetski
On Sun, 5 Jul 2015, Robert Jarzmik wrote: > From: Robert Jarzmik > > This moves the dma irq handling functions up in the source file, so that > they are available before DMA preparation functions. It prepares the > conversion to DMA engine, where the descriptors are populated with these > functi

Re: [PATCH v2 1/4] media: pxa_camera: fix the buffer free path

2015-07-12 Thread Guennadi Liakhovetski
Hi Robert, On Sun, 5 Jul 2015, Robert Jarzmik wrote: > From: Robert Jarzmik > > Fix the error path where the video buffer wasn't allocated nor > mapped. In this case, in the driver free path don't try to unmap memory > which was not mapped in the first place. Have I missed your reply to my com

Re: [PATCH 10/15] media: rcar_vin: Use correct pad number in try_fmt

2015-07-12 Thread Guennadi Liakhovetski
On Thu, 25 Jun 2015, William Towle wrote: > Fix rcar_vin_try_fmt's use of an inappropriate pad number when calling > the subdev set_fmt function - for the ADV7612, IDs should be non-zero. > > Signed-off-by: William Towle > Reviewed-by: Rob Taylor > --- > drivers/media/platform/soc_camera/rcar_

Re: userspace media util repository

2015-06-23 Thread Guennadi Liakhovetski
Do you mean this? http://git.linuxtv.org/cgit.cgi/v4l-utils.git/ Regards Guennadi On Wed, 24 Jun 2015, Kim, Heung Jun wrote: > Hi all, > > I’m looking for official repository for user space media utils. For testing > media device status on target I was about to use it, but I couldn’t find

Re: [PATCH 04/14] tw9910: init priv->scale and update standard

2015-06-22 Thread Guennadi Liakhovetski
Hi Hans, On Mon, 22 Jun 2015, Hans Verkuil wrote: > On 06/21/2015 07:23 PM, Guennadi Liakhovetski wrote: > > On Mon, 15 Jun 2015, Hans Verkuil wrote: > > > >> From: Hans Verkuil > >> > >> When the standard changes the VACTIVE and VDELAY values need to

<    1   2   3   4   5   6   7   8   9   10   >