arsing library
> *
> * Copyright (C) 2012 - 2013 Samsung Electronics Co., Ltd.
> - * Sylwester Nawrocki
> + * Author: Sylwester Nawrocki
> *
> * Copyright (C) 2012 Renesas Electronics Corp.
> * Author: Guennadi Liakhovetski
> @@ -103,7 +103,6
To protect against open() racing with rmmod, hold the list_lock also while
obtaining a reference to the camera host driver and check that the video
device hasn't been unregistered yet.
Signed-off-by: Guennadi Liakhovetski
---
drivers/media/platform/soc_camera/soc_camera.c |
On Tue, 2 Apr 2013, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Friday 29 March 2013 16:13:41 Guennadi Liakhovetski wrote:
> > Hi Mauro
> >
> > On Sun, 24 Mar 2013, Mauro Carvalho Chehab wrote:
> > > == Guennadi Liakhovetski ==
> > >
eceiver_properties {
> + SI476X_PROP_INT_CTL_ENABLE = 0x,
> + SI476X_PROP_DIGITAL_IO_INPUT_SAMPLE_RATE= 0x0200,
> + SI476X_PROP_DIGITAL_IO_INPUT_FORMAT = 0x0201,
> + SI476X_PROP_DIGITAL_IO_OUTPUT_SAMPLE_RATE = 0x0202,
>
Hi Mauro
On Sun, 24 Mar 2013, Mauro Carvalho Chehab wrote:
> == Guennadi Liakhovetski ==
>
> I suspect that some of the above may be obsoleted:
>
> Nov,13 2012: sh_vou: Move from videobuf to videobuf2
> http://patchwork.linux
if (IS_ERR(clk))
return -EPROBE_DEFER;
/*
* enable the clock - this needs a subdev pointer, that we stored
* in the clock object for the bridge driver to use with
* v4l2_clk_get() above
*/
v4l2_clk_enable(clk);
do_probe();
Hi Sylwester
Thanks for reviewing.
On Mon, 18 Mar 2013, Sylwester Nawrocki wrote:
> Hi Guennadi,
>
> On 03/15/2013 10:27 PM, Guennadi Liakhovetski wrote:
> > Typical video devices like camera sensors require an external clock source.
> > Many such devices cannot even
_platform_driver_probe().
>
> Signed-off-by: Fabio Porcedda
> Cc: Fabio Estevam
> Cc: Guennadi Liakhovetski
> Cc: Mauro Carvalho Chehab
Thanks, will queue for 3.10.
Guennadi
> ---
> drivers/media/platform/soc_camera/mx2_camera.c | 3 +--
> 1 file changed, 1 insertion(+),
On Mon, 18 Mar 2013, Hans Verkuil wrote:
> On Fri March 15 2013 22:27:49 Guennadi Liakhovetski wrote:
> > Instead of centrally enabling and disabling subdevice master clocks in
> > soc-camera core, let subdevice drivers do that themselves, using the
> > V4L2 clock API and s
2 +-
> drivers/media/i2c/soc_camera/rj54n1cb0c.c |2 +-
> drivers/media/i2c/soc_camera/tw9910.c |2 +-
[snip]
> drivers/media/platform/sh_vou.c |2 +-
> drivers/media/platform/soc_camera/soc_camera.c |2 +-
For the above
Acked-by: Gu
he s_std subdev operation.
>
> Signed-off-by: Hans Verkuil
> ---
[snip]
> drivers/media/platform/sh_vou.c | 12 ++--
> drivers/media/platform/soc_camera/soc_camera.c |4 ++--
For the above two:
Acked-by: Guennadi Liakhovetski
Thanks
Guennadi
-
Update of V4l2 clock and asynchronous probing patches. Various review
comments are addressed, as described in individual patches.
Guennadi Liakhovetski (7):
media: V4L2: add temporary clock helpers
media: V4L2: support asynchronous subdevice registration
media: soc-camera: switch I2C
Register the imx074 camera I2C and the CSI-2 platform devices directly
in board platform data instead of letting the sh_mobile_ceu_camera driver
and the soc-camera framework register them at their run-time. This uses
the V4L2 asynchronous subdevice probing capability.
Signed-off-by: Guennadi
so far only very few systems have been ported to that framework. This patch
adds a set of temporary helpers, mimicking the generic clock API, to V4L2.
Platforms, adopting the clock API, should switch to using it. Eventually
this temporary API should be removed.
Signed-off-by: Guennadi Liakhovetski
) subdevice drivers must register themselves with the framework.
A bridge driver on the other hand must register notification callbacks,
that will be called upon various related events.
Signed-off-by: Guennadi Liakhovetski
---
v6:
1. clock name is now -
2. modified API: instead of bind-bound-unbind use
Instead of centrally enabling and disabling subdevice master clocks in
soc-camera core, let subdevice drivers do that themselves, using the
V4L2 clock API and soc-camera convenience wrappers.
Signed-off-by: Guennadi Liakhovetski
---
v6: clock name update
drivers/media/i2c/soc_camera/imx074.c
, even when there are multiple such instances registered with a
single soc-camera host simultaneously.
Signed-off-by: Guennadi Liakhovetski
---
v6: update to new v4l2-clk and v4l2-async APIs, export a new
soc_camera_power_init() functions for asynchronous subdevices to request
regulators
drivers
Both synchronous and asynchronous imx074 subdevice probing is supported by
this patch.
Signed-off-by: Guennadi Liakhovetski
---
v6: update to new v4l2-async API, use soc_camera_power_init()
drivers/media/i2c/soc_camera/imx074.c | 24 +---
1 files changed, 21 insertions
Use the v4l2-async API to support asynchronous subdevice probing,
including the CSI2 subdevice. Synchronous probing is still supported too.
Signed-off-by: Guennadi Liakhovetski
---
v6: update to the new v4l2-async API
.../platform/soc_camera/sh_mobile_ceu_camera.c | 136
roah-Hartman
> Cc: Mauro Carvalho Chehab
> Cc: Josh Wu
> Cc: Guennadi Liakhovetski
> Cc: Hans Verkuil
> Cc: linux-media@vger.kernel.org
> ---
> drivers/media/platform/soc_camera/atmel-isi.c | 12 +---
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff
> Cc: Josh Wu
> Cc: Guennadi Liakhovetski
> Cc: Hans Verkuil
> Cc: linux-media@vger.kernel.org
Thanks for the patch. Subtracting this series
http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/61403
you only need to convert atmel-isi.c. Please, respin.
Thanks
h e.g.
> > between primary and secondary sensors.
>
> In that case having the I2C bus number and address in the name doesn't create
> an extra portability issue, does it ?
>
> > For what it's worth, the SMIA++ driver uses the actual name of the sensor
> > since there are about 10 sensors supported at the moment, and calling them
> > all smiapp- looks a bit insipid. So one has to talk to the sensor to
> > know what it's called.
> >
> > This isn't strictly mandatory but a nice feature.
> >
> > > you should discover the pipeline and find the sensor by iterating over
> > > entities, instead of using the sensor entity name.
> >
> > To be fully generic, yes.
>
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
so far only very few systems have been ported to that framework. This patch
adds a set of temporary helpers, mimicking the generic clock API, to V4L2.
Platforms, adopting the clock API, should switch to using it. Eventually
this temporary API should be removed.
Signed-off-by: Guennadi Liakhovetski
wclient -u 'accepted' 17111
pwclient -u 'accepted' 17082
pwclient -u 'accepted' 17339
pwclient -u 'accepted' 17081
pwclient -u 'accepted' 17109
pwclient -u 'accepted' 17110
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Sour
1):
soc-camera: mt9m111: Fix auto-exposure control
Guennadi Liakhovetski (1):
mt9m111: fix Oops - initialise context before dereferencing
drivers/media/i2c/soc_camera/mt9m111.c |9 +
drivers/media/i2c/soc_camera/mt9v022.c | 19 ++-
2 files changed,
ned-off-by: Guennadi Liakhovetski
---
drivers/media/i2c/soc_camera/mt9m111.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/soc_camera/mt9m111.c
b/drivers/media/i2c/soc_camera/mt9m111.c
index ea874ce..cfdda50 100644
--- a/drivers/media/i2c/soc_camera
Hi Libin
On Tue, 12 Mar 2013, Libin Yang wrote:
> Hi Guennadi,
>
> Thanks for your careful review. Please help see my comments below.
>
> >-Original Message-
> >From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
> >Sent: Tuesday, March 05, 2013 5:
On Tue, 12 Mar 2013, javier Martin wrote:
> Hi Guernnadi, Christoph,
>
> On 12 March 2013 09:25, Christoph Fritz wrote:
> > On Tue, 2013-03-12 at 08:58 +0100, Guennadi Liakhovetski wrote:
> >> On Thu, 7 Mar 2013, javier Martin wrote:
> >
> >> > What m
Hi Javier
On Thu, 7 Mar 2013, javier Martin wrote:
> Hi,
> sorry for the long delay. I missed this one.
>
> On 5 March 2013 18:56, Guennadi Liakhovetski wrote:
> > (Javier's opinion requested)
> >
> > I'm no expert in i.MX27 hardware, would be great to h
e
> and colour models.
> @@ -36,7 +35,6 @@ config SOC_CAMERA_MT9T112
> config SOC_CAMERA_MT9V022
> tristate "mt9v022 and mt9v024 support"
> depends on SOC_CAMERA && I2C
> - select GPIO_PCA953X if MT9V022_PCA9536_SWITCH
> help
>
anage to get
it in on time for 3.10. Let me know if you'd like me to do the next couple
of rounds :) Or if you disagree with my comments and prefer your present
state.
On Fri, 8 Mar 2013, Sylwester Nawrocki wrote:
> From: Guennadi Liakhovetski
>
> Add a V4L2 OF parser, im
On Fri, 8 Mar 2013, Guennadi Liakhovetski wrote:
> On Fri, 8 Mar 2013, Benoît Thébaudeau wrote:
>
> > Hi Javier,
> >
> > On Friday, March 8, 2013 1:37:38 PM, Javier Martin wrote:
> > > Hi Benoît,
> > >
> > > On 8 March
On Mon, 11 Mar 2013, Silviu Popescu wrote:
> On Mon, Mar 11, 2013 at 9:50 AM, Guennadi Liakhovetski
> wrote:
> >
> > Is there anything in this patch, that this patch series
> >
> > http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/61337
>
platform_device *pdev)
>
> priv->irq = irq;
>
> - priv->base = devm_request_and_ioremap(&pdev->dev, res);
> - if (!priv->base) {
> - dev_err(&pdev->dev, "Unable to ioremap CSI2 registers.\n");
> - return -ENXIO;
> - }
eir recommended register settings
> somewhere without having this evaluation board.
I just tested my mt9m131 camera on a i.MX31 board, if not this your email
I don't think I'd be alarmed by the image quality it's producing, maybe
I'm just less picky:-) And yes, in general I ag
mt9m111->ctx = &context_b;
from mt9m111_init() to probing, instead of adding a context_a selection.
And I think it would be more logical to move those lines to
mt9m111_probe(), directly below the mt9m111 allocation, not to
mt9m111_video_probe(). Please, make this change and submit a patch.
V4L2_MBUS_FMT_RGB555_2X8_PADHI_BE = 0x1003,
> @@ -46,6 +46,10 @@ enum v4l2_mbus_pixelcode {
> V4L2_MBUS_FMT_BGR565_2X8_LE = 0x1006,
> V4L2_MBUS_FMT_RGB565_2X8_BE = 0x1007,
> V4L2_MBUS_FMT_RGB565_2X8_LE = 0x1008,
> + V4L2_MBUS_FMT_RGB666_1X18 = 0x1
ode
cannot change data endianness, therefore two locations with opposite
endianness are erroneous. This change might affest the omap1-camera driver,
existing configurations should be verified.
Cc: Janusz Krzysztofik
Signed-off-by: Guennadi Liakhovetski
---
drivers/media/platform/soc_camera/soc_
set to
> > V4L2_EXPOSURE_AUTO (0).
> >
> > This patch makes mt9m111_set_autoexposure() interpret the value set for
> > V4L2_CID_EXPOSURE_AUTO as defined by enum v4l2_exposure_auto_type.
> >
> > Cc: Guennadi Liakhovetski
> > Cc: Mickaël Guivarc'h
> > Cc:
uster it with the normal exposure, but I'm not an expert in that, not
sure if it would make sense.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux
On Wed, 6 Mar 2013, Albert Wang wrote:
> Hi, Guennadi
>
>
> >-Original Message-
> >From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
> >Sent: Wednesday, 06 March, 2013 23:02
> >To: Albert Wang
> >Cc: cor...@lwn.net; linux-media@vge
On Wed, 6 Mar 2013, Albert Wang wrote:
> Hi, Guennadi
>
>
> >-Original Message-
> >From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
> >Sent: Tuesday, 05 March, 2013 18:43
> >To: Albert Wang
> >Cc: cor...@lwn.net; linux-media@vger.kernel.
eedn't enter single buffer mode.
> If we still can't get new buffer after 1 frame, then CCIC has to enter single
> buffer mode.
> But if we are lucky enough and get new buffer when next frame come, then
> we can still run in normal mode.
Thanks for the explanation. Could y
Hi Albert
On Wed, 6 Mar 2013, Albert Wang wrote:
> Hi, Guennadi
>
>
> >-Original Message-
> >From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
> >Sent: Tuesday, 05 March, 2013 17:51
> >To: Albert Wang
> >Cc: cor...@lwn.net; linux-media
> } else { /* channel 2 */
> + writel((pcdev->s_width << 16) | pcdev->s_height,
> + pcdev->base_emma + PRP_SRC_FRAME_SIZE);
> writel((icd->user_width << 16) | icd->user_height,
> pcdev
dia/platform/marvell-ccic/mcam-core.h
> @@ -44,6 +44,15 @@ enum mcam_state {
> };
> #define MAX_DMA_BUFS 3
>
> +#ifdef MCAM_MODE_DMA_CONTIG
> +/*
> + * CCIC can support at most 3 frame buffers in DMA_CONTIG buffer mode
> + * 2 - Use Two Buffers mode
> + * 3 - Use Three Buffer
ang
> Acked-by: Jonathan Corbet
Acked-by: Guennadi Liakhovetski
Thanks
Guennadi
> ---
> drivers/media/platform/marvell-ccic/mcam-core.c |3 ++-
> drivers/media/platform/marvell-ccic/mcam-core.h |8
> drivers/media/platform/marvell-ccic/mmp-driver.c | 11 +++
for
other platforms would have to just extensively test this and verify the
final result (I think I know one such person ;-)). A couple of minor
comments below. In general - it does look quite good to me! So, provided
relevant testing is done and, possibly, my comments addressed:
Acked-by: Guennadi Li
lete)(struct mcam_camera *cam, unsigned int frame);
>
> /* Current operating parameters */
> u32 sensor_type;/* Currently ov7670 only */
> diff --git a/drivers/media/platform/marvell-ccic/mmp-driver.c
> b/drivers/media/platform/marvell-ccic/mmp-driver.c
>
ate {
> * let the platform pick.
> */
> enum mcam_buffer_mode {
> - B_vmalloc = 0,
> - B_DMA_contig = 1,
> - B_DMA_sg = 2
> + B_VMALLOC = 0,
> + B_DMA_CONTIG = 1,
> + B_DMA_SG = 2
> };
>
> /*
> @@ -59,13 +59,13 @@ static inline int m
dphy[3];/* DPHY: CSI2_DPHY3, CSI2_DPHY5, CSI2_DPHY6 */
> + int dphy3_algo; /* Exist 2 algos for calculate CSI2_DPHY3 */
> + int mipi_enabled; /* MIPI enabled flag */
> + int lane; /* ccic used lane number; 0 means DVP mode */
>
mcam->regs = devm_request_and_ioremap(&pdev->dev, res);
Don't kill me, but they've recently invented devm_ioremap_resource(),
which is essentially the same as devm_request_and_ioremap(), but also
returns an error code and prints an error message, so, you wouldn't have
dth * fmt->height;
>
> spin_lock_irqsave(&cam->dev_lock, flags);
> + dma_handle = vb2_dma_contig_plane_dma_addr(vb, 0);
> + BUG_ON(!dma_handle);
Again - a bit too strong. But the truth is - .buf_queue() cannot fail...
Would it be possible to move this pointer calculation to .buf_pre
}
> + }
> + }
> + return 0;
> +}
>
> static int mmpcam_probe(struct platform_device *pdev)
> {
> @@ -331,6 +374,10 @@ static int mmpcam_probe(struct platform_device *pdev)
> ret = -ENODEV;
> goto out_unmap1;
>
register(&sh_veu_pdrv);
> -}
> -
> -module_init(sh_veu_init);
> -module_exit(sh_veu_exit);
> +module_platform_driver_probe(sh_veu_pdrv, sh_veu_probe);
>
> MODULE_DESCRIPTION("sh-mobile VEU mem2mem driver");
> MODULE_AUTHOR("Guennadi Liakhovetski, ");
a->dphy;
> + /* mosetly it won't happen. dphy is an array in pdata, but in case .. */
> + if (unlikely(mcam->dphy == NULL)) {
> + ret = -EINVAL;
> + goto out_free;
> + }
> + mcam->mipi_enabled = 0;
> + mcam->lane = pdata->
Hi
On Mon, 4 Mar 2013, Sachin Kamat wrote:
> Use the newly introduced devm_ioremap_resource() instead of
> devm_request_and_ioremap() which provides more consistent error handling.
>
> Signed-off-by: Sachin Kamat
> Cc: Guennadi Liakhovetski
Thanks for the patches. I'll
o you have any suggestions on how I could debug it? I've been looking
> for any android command line programs to take snap shots but nothing
> so far. An advice is welcome.
>
> Thanks a lot.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-medi
specifically disables sysfs bind/unbind
> attributes.
>
> Similarly probe() methods should not be marked __init unless
> platform_driver_probe() is used.
>
> Signed-off-by: Dmitry Torokhov
> ---
>
> v1->v2: removed __init markup on omap1_cam_probe() that was po
This looks correct, but don't we also have to remove __init from
omap1_cam_probe()? Or would that be a separate patch?
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line &qu
| 114 +++-
drivers/media/platform/soc_camera/pxa_camera.c | 65 +++--
2 files changed, 67 insertions(+), 112 deletions(-)
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list
git repository at:
git://linuxtv.org/gliakhovetski/v4l-dvb.git for-3.8-set_3
Guennadi Liakhovetski (2):
sh-mobile-ceu-camera: fix SHARPNESS control default
mt9t112: mt9t111 format set up differs from mt9t112
drivers/media/i2c/soc_camera/mt9t112.c
7;m not exactly sure where the actual crash happens, one
of the possibilities is if the match_i2c() function is called for an
invalid or unbound i2c device. You'll have to debug this too.
Thanks
Guennadi
> 3: When I just build and use either the capture/display driver and
> th
A recent commit broke compilation of 3 camera drivers: for PXA2x0, OMAP1
and MX1 by using a wrong pointer. Fix them.
Signed-off-by: Guennadi Liakhovetski
---
Mauro, if possible, would be nice to merge this with
http://patchwork.linuxtv.org/patch/15990/
which is already in -next. If too late
been verified to work with mt9t111. Limit the driver to only
report one supported format with mt9t111 until more formats are
implemented.
Signed-off-by: Guennadi Liakhovetski
---
drivers/media/i2c/soc_camera/mt9t112.c | 18 +-
1 files changed, 13 insertions(+), 5 deletions(-)
The V4L2_CID_SHARPNESS control in the sh-mobile-ceu-camera driver, if off,
turns the CEU low-pass filter on. This is the opposite to the hardware
default and can degrade image quality. Switch default to on to restore the
default unfiltered mode.
Signed-off-by: Guennadi Liakhovetski
---
This bug
Hi Simon
On Tue, 8 Jan 2013, Simon Horman wrote:
> On Wed, Dec 26, 2012 at 06:49:11PM +0100, Guennadi Liakhovetski wrote:
> > Register the imx074 camera I2C and the CSI-2 platform devices directly
> > in board platform data instead of letting the sh_mobile_ceu_camera driver
On Tue, 8 Jan 2013, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Tuesday 08 January 2013 10:56:43 Guennadi Liakhovetski wrote:
> > On Tue, 8 Jan 2013, Laurent Pinchart wrote:
> > > On Tuesday 08 January 2013 10:25:15 Guennadi Liakhovetski wrote:
> > > >
tages during subdevice probing, e.g. after completion.
Then the bridge driver can request single groups to be probed, finish its
own probing and continue its video subsystem configuration from its
callbacks.
Signed-off-by: Guennadi Liakhovetski
---
v5: Now really fix the case, when subdevices
On Tue, 8 Jan 2013, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Tuesday 08 January 2013 10:25:15 Guennadi Liakhovetski wrote:
> > On Tue, 8 Jan 2013, Laurent Pinchart wrote:
> > > On Monday 07 January 2013 11:23:55 Guennadi Liakhovet
with DT overlays, because endpoint nodes on both sides of
the video data bus contain references to the other side and I don't know
whether and how these can be created and / or updated at run-time.
Otherwise, yes, the approach that we're currently developing on V4L allows
us to build
Hi Laurent
On Tue, 8 Jan 2013, Laurent Pinchart wrote:
> Hi Guennadi,
>
> Thanks for the patch.
>
> On Monday 07 January 2013 11:23:55 Guennadi Liakhovetski wrote:
> > >From 0e1eae338ba898dc25ec60e3dba99e5581edc199 Mon Sep 17 00:00:00 2001
> >
> > From:
Hi Mauro
On Sun, 6 Jan 2013, Mauro Carvalho Chehab wrote:
> == Guennadi Liakhovetski ==
>
> Oct,30 2012: [v2,2/4] media: mx2_camera: Add image size HW limits.
> http://patchwork.linuxtv.org/patch/15298 Javier Martin
>
In the mai
On Mon, 7 Jan 2013, Julia Lawall wrote:
> On Mon, 7 Jan 2013, Guennadi Liakhovetski wrote:
>
> > (adding Robert to CC)
> >
> > Hi Julia
> >
> > Thanks for the patch.
> >
> > On Mon, 7 Jan 2013, Julia Lawall wrote:
> >
> > > From
e
> *pdev)
>
> clk_put(pcdev->clk);
>
> + free_irq(pcdev->irq, pcdev);
> pxa_free_dma(pcdev->dma_chans[0]);
> pxa_free_dma(pcdev->dma_chans[1]);
> pxa_free_dma(pcdev->dma_chans[2]);
> - free_irq(pcdev->irq, pcdev);
>
>
>From 0e1eae338ba898dc25ec60e3dba99e5581edc199 Mon Sep 17 00:00:00 2001
From: Guennadi Liakhovetski
Date: Fri, 19 Oct 2012 23:40:44 +0200
Subject: [PATCH] media: V4L2: support asynchronous subdevice registration
Currently bridge device drivers register devices for all subdevices
synchronou
On Fri, 4 Jan 2013, Prabhakar Lad wrote:
> Hi Guennadi,
>
> On Wed, Jan 2, 2013 at 3:49 PM, Guennadi Liakhovetski
> wrote:
> > Hi Prabhakar
> >
> > On Wed, 2 Jan 2013, Prabhakar Lad wrote:
> >
> >> Hi,
> >>
> >> This is my firs
Hi Libin
On Thu, 3 Jan 2013, Libin Yang wrote:
> Hi Guennadi,
>
> Thanks for your review. Please see my comments below.
>
> >-Original Message-
> >From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
> >Sent: Wednesday, January 02, 2013 12:06 AM
t 3696068e4e1231311b07e5c312876deec182f18b:
Add linux-next specific files for 20130103 (2013-01-03 14:24:37 +1100)
are available in the git repository at:
git://linuxtv.org/gliakhovetski/v4l-dvb.git for-3.9
Fabio Estevam (1):
mx2_camera: Convert it to platform driver
Guennadi Lia
struct soc_camera_link currently contains fields, used both by sensor and
bridge drivers. To make subdevice driver re-use simpler, split it into a
host and a subdevice parts.
Signed-off-by: Guennadi Liakhovetski
---
v2: following an off-list discussion with Laurent, .add_device() and
superfluous? If so, I'm sure you'd be happy to make a couple more patches
to continue this series ;-)
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe
Hi Sylwester
On Wed, 2 Jan 2013, Sylwester Nawrocki wrote:
> Hi Guennadi,
>
> On 01/02/2013 12:31 PM, Guennadi Liakhovetski wrote:
> > Hi Sylwester
> >
> > Thanks for picking up these patches! In general both look good to me, just
> > a couple of nit-pick
v_err(&client->dev, "Unable to get regulators\n");
> + return -ENODEV;
> + }
> +
> v4l2_ctrl_handler_init(&mt9p031->ctrls, ARRAY_SIZE(mt9p031_ctrls) + 6);
>
> v4l2_ctrl_new_std(&mt9p031->ctrls, &mt9p031_ctrl_ops,
> --
&
4l2-of.c
> @@ -0,0 +1,249 @@
> +/*
> + * V4L2 OF binding parsing library
> + *
> + * Copyright (C) 2012 Renesas Electronics Corp.
> + * Author: Guennadi Liakhovetski
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms o
Hi Sylwester
Thanks for picking up these patches! In general both look good to me, just
a couple of nit-picks, that I couldn't help remarking:-)
On Mon, 31 Dec 2012, Sylwester Nawrocki wrote:
> From: Guennadi Liakhovetski
>
> This patch adds a document describing common OF bind
q;
Presumably, ext_freq should be retrieved, using v4l2_clk_get_rate() and
target_freq could be a proprietary property of your device.
Thanks
Guennadi
> };
>
> should this all be individual properties ?
>
> Regards,
> --Prabhakar
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-
am_vb_stop_streaming(struct vb2_queue *vq)
> > {
> > - struct mcam_camera *cam = vb2_get_drv_priv(vq);
> > + struct mcam_camera *cam = get_mcam(vq);
> > unsigned long flags;
> >
> > if (cam->state == S_BUFWAIT) {
> > @@ -1181,6 +1187,7 @@ static int mcam_vb_st
m);
> -out_gpio2:
> +out_power_down:
> mmpcam_power_down(mcam);
> - gpio_free(pdata->sensor_reset_gpio);
> -out_gpio:
> - gpio_free(pdata->sensor_power_gpio);
> -out_unmap2:
> +out_uninit_clk:
> mcam_init_clk(mcam, pdata, 0);
> - io
nsure clear the obsolete frame flags before every really start
> streaming.
Apart from the remark, that Jon has made:
Acked-by: Guennadi Liakhovetski
Thanks
Guennadi
>
> Signed-off-by: Albert Wang
> Signed-off-by: Libin Yang
> ---
> drivers/medi
>and the other two
> >+imgsz_w = (fmt->bytesperline * 3 / 2) & IMGSZ_H_MASK;
> >? But maybe I'm wrong, please, double-check and confirm.
> >
> [Albert Wang] It looks they are both 12 bit planar format, they have same
> imgsz_w.
> Anyway,
mmon for all cases, perhaps just put it above switch?
> + mvb->yuv_p.u = mvb->yuv_p.y + pixel_count;
> + mvb->yuv_p.v = mvb->yuv_p.u + pixel_count / 2;
> + break;
> + case V4L2_PIX_FMT_YUV420:
> + mvb->yuv_p.y = dma_handle;
> +
s.
>
> Signed-off-by: Albert Wang
> Signed-off-by: Libin Yang
Acked-by: Guennadi Liakhovetski
Thanks
Guennadi
> ---
> drivers/media/platform/marvell-ccic/mcam-core.c |6 ++
> drivers/media/platform/marvell-ccic/mcam-core.h |2 ++
> drivers/media
the rest and just return with no error.
This seems strange, usually a failure to get clocks, that the platform
tells you to get, is fatal.
> + if (IS_ERR(mcam->clk[i])) {
> + dev_err(mcam->dev,
> + "Could not get
= pdata->bus_type;
> + mcam->dphy = pdata->dphy;
> + mcam->mipi_enabled = 0;
ditto
> + mcam->lane = pdata->lane;
> mcam->chip_id = V4L2_IDENT_ARMADA610;
> mcam->buffer_mode = B_DMA_sg;
> spin_lock_init(&mcam->dev_lock);
On Sat, 15 Dec 2012, Albert Wang wrote:
> From: Libin Yang
>
> This patch replaces the global frame stats variables by using
> internal variables in mcam_camera structure.
>
> Signed-off-by: Albert Wang
> Signed-off-by: Libin Yang
Acked-by: Guennadi Liakhovet
Use the v4l2-async API to support asynchronous subdevice probing,
including the CSI2 subdevice. Synchronous probing is still supported too.
Signed-off-by: Guennadi Liakhovetski
---
.../platform/soc_camera/sh_mobile_ceu_camera.c | 135
drivers/media/platform/soc_camera
Register the imx074 camera I2C and the CSI-2 platform devices directly
in board platform data instead of letting the sh_mobile_ceu_camera driver
and the soc-camera framework register them at their run-time. This uses
the V4L2 asynchronous subdevice probing capability.
Signed-off-by: Guennadi
Both synchronous and asynchronous imx074 subdevice probing is supported by
this patch.
Signed-off-by: Guennadi Liakhovetski
---
drivers/media/i2c/soc_camera/imx074.c | 23 ---
1 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/soc_camera
last version of the v4l2-clock patch. If desired, a git branch can
be provided.
Thanks
Guennadi
Guennadi Liakhovetski (6):
media: V4L2: support asynchronous subdevice registration
media: soc-camera: switch I2C subdevice drivers to use v4l2-clk
soc-camera: add V4L2-async support
Instead of centrally enabling and disabling subdevice master clocks in
soc-camera core, let subdevice drivers do that themselves, using the
V4L2 clock API and soc-camera convenience wrappers.
Signed-off-by: Guennadi Liakhovetski
---
drivers/media/i2c/soc_camera/imx074.c | 18
701 - 800 of 2736 matches
Mail list logo
